Make Skia Build more modular [40045064] - Visible to Public

In Progress

Task

Status Update

No update yet.

Description

kj...@google.com

created issue #1

Dec 10, 2022 08:39AM

This is a tracking bug for work to make the Skia build modular such that Bazel clients can easily pick and choose the parts of Skia they want *without* needing compile time flags.

Mentioned issues (3)

P2	Simplify SkOpts compilation “ b/40045066 ”	ap...@ #154, ap...@ #155, ap...@ #156, ap...@ #157
--	-- “ b/284138320 ”	ap...@ #159, ap...@ #160
--	-- “ b/237076898 ”	ap...@ #180

Links (6950)

Comments

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #2Dec 13, 2022 02:13AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a

commit a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Dec 09 20:57:46 2022

Remove dependency of SkPaint -> SkPaintPriv

If we want SkPaint to be a part of "core", then we need
to trim down the .cpp file a bit. This moves all
SkPaintPriv:: implementations to SkPaintPriv.cpp
(Which were just Flatten and Unflatten).

ComputeResScaleForStroking seems to be more related to
Matrices and Paths than Paint, so I moved it to
SkMatrixPriv (and you'll see in a follow-up CL I'm attempting
the ambitious removal of getFillPath)

Change-Id: I14b3d6fb2c69bdeacee998c0d0bc436c59096300
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/616818
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Herb Derby <herb@google.com>

[modify] https://crrev.com/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a/src/core/SkMatrixPriv.h
[modify] https://crrev.com/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a/src/core/SkPaint.cpp
[modify] https://crrev.com/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a/src/core/SkPaintPriv.cpp
[modify] https://crrev.com/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a/src/core/SkMatrix.cpp
[modify] https://crrev.com/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a/bench/PathBench.cpp
[modify] https://crrev.com/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a/src/core/SkPaintPriv.h

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #3Dec 13, 2022 11:35PM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #4Dec 14, 2022 02:10AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/db70f2fd672f3964576c212ed7eddc6e6d542a9d

commit db70f2fd672f3964576c212ed7eddc6e6d542a9d
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Dec 13 12:44:43 2022

[includes] Enforce IWYU on SkPath related things

(SkPath itself already is IWYU-enforced)

This will hopefully make it a bit easier to set up a modular
build of Skia that can just export paths without too much
extra stuff.

Change-Id: I915120a3ef6ea7975b2ecc73ee10d269155c730a
Bug: skia:13052, skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/617638
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/include/core/SkPathBuilder.h
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/include/private/SkPathRef.h
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/src/BUILD.bazel
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/src/core/SkPathRef.cpp
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/src/core/SkPathBuilder.cpp
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/src/core/SkPathPriv.h

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #5Dec 14, 2022 07:24AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #6Dec 15, 2022 02:12AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/8e165b9cf288fd3d3fbe06cf2fc3032897312a5a

commit 8e165b9cf288fd3d3fbe06cf2fc3032897312a5a
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Dec 14 14:35:14 2022

Mark SkPathUtils functions as SK_API

Otherwise, the Chrome build breaks with a link error when
linking libcc_paint.so

Follow-up to https://skia-review.googlesource.com/c/skia/+/616821

Change-Id: I93c6e3b9713f11054c030cccdd0a48341e37a152
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/618817
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>

[modify] https://crrev.com/8e165b9cf288fd3d3fbe06cf2fc3032897312a5a/include/core/SkPathUtils.h

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #7Dec 16, 2022 01:05AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #8Dec 17, 2022 08:19AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #9Dec 21, 2022 04:25AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/16741cadb533d39cdde03423fd3fefe162899f3e

commit 16741cadb533d39cdde03423fd3fefe162899f3e
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Dec 20 16:11:40 2022

[includes] Enforce IWYU on SkCubicMap and SkGlyph

I was curious if these actually depended on PathOps or not.

SkCubicMap does not anymore, there was some #ifdef'd code
that currently exists in CubicMapTest.cpp anyway.

If we want SkGlyph in "core", we will want to remove the
dependency on pathops.

Change-Id: I9e2b7a37b5758d044575dad651d5bc1b203c070c
Bug: skia:13052, skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/621199
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>

[modify] https://crrev.com/16741cadb533d39cdde03423fd3fefe162899f3e/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/16741cadb533d39cdde03423fd3fefe162899f3e/src/core/SkCubicSolver.h
[modify] https://crrev.com/16741cadb533d39cdde03423fd3fefe162899f3e/src/core/SkGlyph.cpp
[modify] https://crrev.com/16741cadb533d39cdde03423fd3fefe162899f3e/src/core/SkCubicMap.cpp
[modify] https://crrev.com/16741cadb533d39cdde03423fd3fefe162899f3e/include/core/SkCubicMap.h
[modify] https://crrev.com/16741cadb533d39cdde03423fd3fefe162899f3e/src/core/SkGlyph.h

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #10Jan 4, 2023 02:36AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #11Jan 4, 2023 03:17AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/c31623792b89e119ce1ae7f636f3ed82155535f6

commit c31623792b89e119ce1ae7f636f3ed82155535f6
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 03 15:34:27 2023

Use skvx instead of SkDVector in Path/PathBuilder

We would like to remove the dependency of SkPath on SkPathops.

Remaining dependencies:
- SkGeometry.cpp
- SkGlyph.cpp

While working on this, I broke something and the Paths tests
started to fail. I found those hard to understand and debug,
so I ported some of the failing ones over to PathBuilder
(which does not have as comprehensive of tests). I figured out
what I was doing wrong and what those failing tests were for.
See the additional documentation in SkPath.cpp and SkPathBuilder.cpp

This adds some new static methods to skvx, along with unit tests
for them.

Because I was comparing functionality between skvx and SkDVector,
I added some tests to the latter for an apples to apple comparison.

Change-Id: I8aa43ed021949ccf1015b2dedf26a52b59d15860
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/621198
Reviewed-by: Michael Ludwig <michaelludwig@google.com>

[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/tests/SkVxTest.cpp
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/tests/PathOpsDVectorTest.cpp
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/src/core/SkPath.cpp
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/include/private/SkVx.h
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/tests/Test.h
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/tests/PathBuilderTest.cpp
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/src/core/SkPathBuilder.cpp

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #12Jan 4, 2023 06:26AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #13Jan 4, 2023 06:26AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #14Jan 5, 2023 05:26AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #15Jan 5, 2023 08:05AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #16Jan 5, 2023 08:18AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #17Jan 6, 2023 12:19AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #18Jan 6, 2023 01:52AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #19Jan 6, 2023 07:27AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #20Jan 10, 2023 03:19AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #21Jan 10, 2023 03:41AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/c383f4309d84176793759f3068d549d8f52330be

commit c383f4309d84176793759f3068d549d8f52330be
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Jan 09 16:09:05 2023

Add tests for solving cubic roots with double precision.

In order to break the SkPath -> pathops dependency that currently
exist, we'll need to extract the logic to do that. One thing
that will need to be extracted is the ability to solve cubic
functions (e.g. Ax^3 + Bx^2 + Cx + D = 0) which is used to
chop cubics for perspective matrices.

No direct tests for the existing logic in PathOps exists,
so this adds some, including tests for solving quadratics
because the current cubic root finding logic falls back
to the quadratic methods if A == 0.

There does not appear to be existing logic (outside of pathops)
for determining if doubles are close enough, so this adds some
(and a few tests). The double comparison added is only what
was necessary to write tests, not a general purpose comparison
(which is tricky) [1].

[1] https://randomascii.wordpress.com/2012/02/25/comparing-floating-point-numbers-2012-edition/

Change-Id: I8b072f590027b43c4e7c2e2e2f9e28043b177b55
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/627018
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/gn/tests.gni
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/gn/core.gni
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/include/private/SkFloatingPoint.h
[add] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/tests/CubicRootsTest.cpp
[add] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/tests/QuadRootsTest.cpp
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/src/core/BUILD.bazel
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/tests/BUILD.bazel
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/public.bzl
[add] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/src/core/SkFloatingPoint.cpp
[add] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/tests/FloatingPointTest.cpp

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #22Jan 11, 2023 12:38AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/c13c6e7083dbb3323634a21e7609467dbc764efc

commit c13c6e7083dbb3323634a21e7609467dbc764efc
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 10 13:37:50 2023

Fix input and output of SaveLayerRestore_DrawColor test

The "original" color in this CL had incorrectly flipped the
arguments to SkColorSetA. By not using a constant value
for the expected_alpha/color, the unexpected behavior was not
noticed.

This also removes the one usage in Chrome of SkMulDiv255Round, which
Skia plans to remove from the public API.

Bug: skia:13983
Change-Id: I89b7cde9566a0c8281804f433310ec51a58dc433
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4148388
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1090784}

[modify] https://crrev.com/c13c6e7083dbb3323634a21e7609467dbc764efc/cc/paint/paint_op_buffer_unittest.cc

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #23Jan 11, 2023 06:17AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #24Jan 11, 2023 11:00AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e

commit 6c113cb8d7f92c08eb933f18bea5cc2f85ac286e
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 10 18:33:29 2023

Add gni file list for Skia codecs used by Chromium

Chromium [1] currently has a hard-coded list of sources
used for the implementation of certain codecs. This
is potentially brittle, so this change starts to introduce
some gni lists that could be used.

It is a little harder to use gn file lists like this
for Skia because GN complains if the same source file
is included multiple times (but Bazel, the source of
truth of these .gni lists, does not). I made two file
lists to slightly reduce the hard coded files in
skia/BUILD.gn as long as I was here.

In order to do this, I had to relax a constraint on
the gni_exporter tool. It would fail if the same file
was included more than once; I changed this to remove
duplicates. I also changed the file lists to be sorted
in a non-case-sensitive manner, as this is easier and
hopefully reduces churn when GN decides to (arbitrarily)
re-sort the list of files.

[1] https://source.chromium.org/chromium/chromium/src/+/main:skia/BUILD.gn;l=338;drc=f62bcc24c9aaff6ea3db5c870d813fb9c6449f04

Change-Id: Id25a7e9a018a5e2713fa91e3e0611515533afce9
Bug: skia:12541, skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/627989
Reviewed-by: Chris Mumford <cmumford@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/gn/sksl_tests.gni
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/gn/utils.gni
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/gn/core.gni
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/bazel/exporter/gni_exporter_test.go
[add] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/gn/codec.gni
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/BUILD.gn
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/modules/svg/svg.gni
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/bazel/exporter_tool/main.go
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/bazel/exporter/gni_exporter.go
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/gn/gpu.gni

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #25Jan 12, 2023 01:46AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/cf0e6550bf157de22edd9923bb7876cd52a24ee8

commit cf0e6550bf157de22edd9923bb7876cd52a24ee8
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 11 13:43:40 2023

Break apart more gni file lists

The metal headers are used by Chromium and Flutter, the dawn ones
just by Chromium (it seems)

Change-Id: I1c3fb3224a5b8e638891f86cd71165a4e532c18f
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/628737
Reviewed-by: Herb Derby <herb@google.com>

[modify] https://crrev.com/cf0e6550bf157de22edd9923bb7876cd52a24ee8/gn/shared_sources.gni
[modify] https://crrev.com/cf0e6550bf157de22edd9923bb7876cd52a24ee8/BUILD.gn
[modify] https://crrev.com/cf0e6550bf157de22edd9923bb7876cd52a24ee8/bazel/exporter_tool/main.go
[modify] https://crrev.com/cf0e6550bf157de22edd9923bb7876cd52a24ee8/bazel/exporter/gni_exporter.go
[modify] https://crrev.com/cf0e6550bf157de22edd9923bb7876cd52a24ee8/gn/gpu.gni

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #26Jan 12, 2023 06:43AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #27Jan 13, 2023 12:12AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/e4b9ef3f8406704184c357a0cb7bc63a76c46961

commit e4b9ef3f8406704184c357a0cb7bc63a76c46961
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 11 20:29:50 2023

Break out metal headers used by C++ and ObjC code

The chromium build the metal part of code in a different [1]
target than the rest of the code. As such, they see a
gn check errors like:
ERROR at //third_party/skia/src/gpu/ganesh/GrBackendUtils.cpp:26:11: Including a private header.
#include "src/gpu/ganesh/mtl/GrMtlCppUtil.h"
^--------------------------------
This file is private to the target //skia:skia_metal
ERROR at //third_party/skia/src/gpu/ganesh/GrDirectContext.cpp:40:11: Including a private header.
#include "src/gpu/ganesh/mtl/GrMtlTrampoline.h"
^-----------------------------------
This file is private to the target //skia:skia_metal

To fix this, we can split the headers used by the C++ code
out into their own GNI file group and list that in both
targets (rather than trying to make GrMtlCppUtil.h et al public)

[1] https://source.chromium.org/chromium/chromium/src/+/main:skia/BUILD.gn;l=767-769;drc=f62bcc24c9aaff6ea3db5c870d813fb9c6449f04

Change-Id: I781e35c61123b0f6f874bdb0ed2542fceff81807
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/628981
Reviewed-by: Jim Van Verth <jvanverth@google.com>

[modify] https://crrev.com/e4b9ef3f8406704184c357a0cb7bc63a76c46961/BUILD.gn
[modify] https://crrev.com/e4b9ef3f8406704184c357a0cb7bc63a76c46961/bazel/exporter_tool/main.go
[modify] https://crrev.com/e4b9ef3f8406704184c357a0cb7bc63a76c46961/src/gpu/ganesh/mtl/BUILD.bazel
[modify] https://crrev.com/e4b9ef3f8406704184c357a0cb7bc63a76c46961/bazel/exporter/gni_exporter.go
[modify] https://crrev.com/e4b9ef3f8406704184c357a0cb7bc63a76c46961/gn/gpu.gni

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #28Jan 13, 2023 03:15AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #29Jan 13, 2023 05:57AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/14db02a66c15e461a552eecc0106714b285d39dc

commit 14db02a66c15e461a552eecc0106714b285d39dc
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jan 12 18:56:16 2023

[skia] Allow skia target to be compliant with gn check

On the Skia side, we produced several new GNI file lists:
- http://review.skia.org/627988
- http://review.skia.org/627989
- http://review.skia.org/628737
- http://review.skia.org/628743
- http://review.skia.org/628981

This CL uses them in public or sources if they are to be
used by Chromium or not.

This should make it harder for Chromium to unintentionally
#include Skia internals (e.g. files in src or include/private).

Symbols from include/private could still be visible via transitive
dependencies, and follow-on work will put those in a private
namespace to further discourage use.

One fuzzer needs to have gn check disabled because it directly
tests SkJSON.h, an internal file.

Change-Id: I76064f8322beec4c0b14efc90cd1ea7fc1f57f7a
Bug: skia:13983, skia:12541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4089412
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1091959}

[modify] https://crrev.com/14db02a66c15e461a552eecc0106714b285d39dc/skia/tools/fuzzers/BUILD.gn
[modify] https://crrev.com/14db02a66c15e461a552eecc0106714b285d39dc/skia/BUILD.gn

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #30Jan 13, 2023 06:46AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #31Jan 14, 2023 01:36AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a

commit 1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Jan 13 14:35:48 2023

Fix includes of Chromium-specific Skia headers

Follow-up to crrev.com/c/4089412 and review.skia.org/628743

Bug: skia:13983
Change-Id: Ied97f41665fe30a99c6284474c1eb5828a9b5df1
Disable-Rts: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4163300
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1092390}

[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/components/viz/service/display_embedder/skia_output_device_vulkan_secondary_cb.cc
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/android_webview/browser/gfx/aw_draw_fn_impl.cc
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/android_webview/browser/gfx/vulkan_gl_interop.cc
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/skia/BUILD.gn
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/skia/ext/SkDiscardableMemory_chrome.h
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/android_webview/browser/gfx/aw_vulkan_context_provider.h
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/android_webview/DEPS

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #32Jan 14, 2023 04:42AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #33Jan 18, 2023 07:23AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/2c40402bd5ff2e3db59a02e2737cdf0015cdb6d0

commit 2c40402bd5ff2e3db59a02e2737cdf0015cdb6d0
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 17 18:51:30 2023

Remove shim files for private Chrome GPU usage

No longer needed after https://chromium-review.googlesource.com/c/chromium/src/+/4163300

Change-Id: I620bfadd96e220f25ad348be300ccd78d85aabf7
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/630757
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>

[modify] https://crrev.com/2c40402bd5ff2e3db59a02e2737cdf0015cdb6d0/gn/core.gni
[delete] https://crrev.com/115e4e3f9e51311b9d595a2e75dc4e21d361efa2/src/core/SkDiscardableMemory.h
[modify] https://crrev.com/2c40402bd5ff2e3db59a02e2737cdf0015cdb6d0/tools/rewrite_includes.py
[modify] https://crrev.com/2c40402bd5ff2e3db59a02e2737cdf0015cdb6d0/src/core/BUILD.bazel
[delete] https://crrev.com/115e4e3f9e51311b9d595a2e75dc4e21d361efa2/src/gpu/vk/GrVkSecondaryCBDrawContext.h

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #34Jan 19, 2023 02:35AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/808ddfb12d85fa3b411a1e26c7071952b31b627f

commit 808ddfb12d85fa3b411a1e26c7071952b31b627f
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 18 15:34:11 2023

Remove uses of SkMath.h

These are the last direct includes, as well as the last
usage of the symbols there.

I added DCHECK or other validation to make sure the cast
from signed to unsigned didn't underflow, but otherwise
the code should be identical.

Skia plans to remove SkMath.h from the public API.

As long as I was removing #includes, I decided to add a few
that were used but not explicitly specified to save future
churn if we refactor #includes internally.

Change-Id: Ib26f1fcf38da03e5fcfd0f3af0e7e05a1d837959
Bug: skia:13983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4174994
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1093880}

[modify] https://crrev.com/808ddfb12d85fa3b411a1e26c7071952b31b627f/cc/raster/raster_buffer_provider.cc
[modify] https://crrev.com/808ddfb12d85fa3b411a1e26c7071952b31b627f/cc/paint/paint_op_writer.cc
[modify] https://crrev.com/808ddfb12d85fa3b411a1e26c7071952b31b627f/cc/paint/paint_filter.h
[modify] https://crrev.com/808ddfb12d85fa3b411a1e26c7071952b31b627f/cc/paint/paint_filter.cc
[modify] https://crrev.com/808ddfb12d85fa3b411a1e26c7071952b31b627f/cc/paint/paint_op_reader.cc

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #35Jan 19, 2023 05:05AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/3554d02ae0d95dea057406cdef9225c8ebe3f828

commit 3554d02ae0d95dea057406cdef9225c8ebe3f828
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 18 15:51:39 2023

Remove SkMath.h from the public API

This had been waiting on:
- http://ag/21022503
- http://go/cl-c/4174994

Change-Id: I4aa3a750a52a05a0dcd9ac8336f9239bfaf6876a
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/631239
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

[modify] https://crrev.com/3554d02ae0d95dea057406cdef9225c8ebe3f828/gn/core.gni
[modify] https://crrev.com/3554d02ae0d95dea057406cdef9225c8ebe3f828/tools/rewrite_includes.py
[modify] https://crrev.com/3554d02ae0d95dea057406cdef9225c8ebe3f828/include/core/BUILD.bazel
[modify] https://crrev.com/3554d02ae0d95dea057406cdef9225c8ebe3f828/RELEASE_NOTES.txt
[delete] https://crrev.com/1ace2d223d23dfe2f431c3cc3e813f924fc6fdaf/include/core/SkMath.h
[modify] https://crrev.com/3554d02ae0d95dea057406cdef9225c8ebe3f828/public.bzl

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #36Jan 19, 2023 05:57AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #37Jan 20, 2023 09:53AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #38Jan 21, 2023 03:59AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/3eb13398100b409d62c0d5798786917b26f74df5

commit 3eb13398100b409d62c0d5798786917b26f74df5
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Jan 20 15:37:39 2023

[base] Make Bazel target and enforce IWYU

This creates the first "buffet" package, located in //src:base.
I plan to create all buffet packages in //src: and then use
aliases to make the public ones easily findable in //:

Having this be a target makes sure that none of the files in
base depend on things outside of base.

Enforcing IWYU took a bit of effort.
This adds a new macro for generating .h.cpp files from .h files
that only works if the file is defined in the same package
(folder) as the generating rule. I think this will eventually
replace the old rule.

I removed the files in the new base package from the generated
list of .h files because I saw conflicts as a result of the
current Bazel buffet defining SK_DEBUG as a define, whereas
the base package does not set any defines (the tentative plan
is to set those from files in base like SkAttributes.h). This
did catch at least two files (SkTFitsIn.h, SkSafeMath.h) which
was using SK_DEBUG without including the appropriate file.

I initially tried just generating .cpp files for all .h files,
but saw this tickle at least one IWYU bug (with templates?)
where IWYU wanted a header to include itself. Thus, we just
have a list of files to opt-in to header-generation and IWYU
enforcement.

See also: http://cl/503435314

Change-Id: I0a34633d469fcd84dcc6de428b708939cacbf1b0
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/632040
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/include/private/base/BUILD.bazel
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/src/base/BUILD.bazel
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/infra/bots/tasks.json
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/include/private/base/SkTFitsIn.h
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/include/config/BUILD.bazel
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/include/BUILD.bazel
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/bazel/generate_cpp_files_for_headers.bzl
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/bazel/macros.bzl
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/infra/bots/gen_tasks_logic/gen_tasks_logic.go
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/infra/bots/jobs.json
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/src/base/SkSafeMath.h
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/src/BUILD.bazel

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #39Jan 21, 2023 08:01AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/67be14faaa640eb3be1f83328c4be07f1038328e

commit 67be14faaa640eb3be1f83328c4be07f1038328e
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Jan 20 20:14:25 2023

Add tests for SkDCubic::chopAt

The plan is to pull this out of PathOps into base so as to break
the dependency between SkPath and Pathops.

Change-Id: Ib750a334309762620551ebfec0675994bb6fa6fc
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/632517
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>

[add] https://crrev.com/67be14faaa640eb3be1f83328c4be07f1038328e/tests/CubicChopTest.cpp
[modify] https://crrev.com/67be14faaa640eb3be1f83328c4be07f1038328e/gn/tests.gni
[modify] https://crrev.com/67be14faaa640eb3be1f83328c4be07f1038328e/tests/BUILD.bazel

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #40Jan 21, 2023 08:59AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #41Jan 22, 2023 01:34AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/91a14b75ee56bdba22d97d8573e7878ce17bfa8c

commit 91a14b75ee56bdba22d97d8573e7878ce17bfa8c
Author: Florin Malita <fmalita@chromium.org>
Date: Fri Jan 20 22:33:43 2023

Manual revert "[base] Make Bazel target and enforce IWYU"

This reverts commit 3eb13398100b409d62c0d5798786917b26f74df5.

Reason for revert: breaking g3 rolls

https://critique.corp.google.com/cl/503461112/analysis

Original change's description:

- Show quoted text -

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #42Jan 24, 2023 05:40AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/b08a5b73a023371b65057f95fa2441f18c80d103

commit b08a5b73a023371b65057f95fa2441f18c80d103
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Jan 23 13:15:20 2023

Reland "[base] Make Bazel target and enforce IWYU"

This reverts commit 91a14b75ee56bdba22d97d8573e7878ce17bfa8c.

This creates the first "buffet" package, located in //src:base.
I plan to create all buffet packages in //src: and then use
aliases to make the public ones easily findable in //:

Having this be a target makes sure that none of the files in
base depend on things outside of base.

Enforcing IWYU took a bit of effort.
This adds a new macro for generating .h.cpp files from .h files
that only works if the file is defined in the same package
(folder) as the generating rule. I think this will eventually
replace the old rule.

I removed the files in the new base package from the generated
list of .h files because I saw conflicts as a result of the
current Bazel buffet defining SK_DEBUG as a define, whereas
the base package does not set any defines (the tentative plan
is to set those from files in base like SkAttributes.h). This
did catch at least two files (SkTFitsIn.h, SkSafeMath.h) which
was using SK_DEBUG without including the appropriate file.

I initially tried just generating .cpp files for all .h files,
but saw this tickle at least one IWYU bug (with templates?)
where IWYU wanted a header to include itself. Thus, we just
have a list of files to opt-in to header-generation and IWYU
enforcement.

See also:
- http://cl/503435314
- http://cl/503953788

Change-Id: Id1dafcfef632866b16db29acd7a6bc070d25d9f3
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/632578
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/include/private/base/BUILD.bazel
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/src/base/BUILD.bazel
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/infra/bots/tasks.json
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/include/private/base/SkTFitsIn.h
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/include/config/BUILD.bazel
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/include/BUILD.bazel
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/bazel/generate_cpp_files_for_headers.bzl
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/bazel/macros.bzl
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/src/base/SkSafeMath.h
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/infra/bots/jobs.json
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/infra/bots/gen_tasks_logic/gen_tasks_logic.go
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/src/BUILD.bazel

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #43Jan 26, 2023 02:38AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/876b045881a6b53d0db19ed812abd8814d7c359c

commit 876b045881a6b53d0db19ed812abd8814d7c359c
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 24 16:04:37 2023

[base] Add extra tests for cubic and quadratic root solving

This originally started as an attempt to unify the PathOps
and base root-finding algorithms [1], however that was abandoned
due to precision-sensitive code in PathOps.

While doing that, I found some cases that caused asserts because
sk_doubles_nearly_equal_ulps was used with two very small numbers
(which it Units of Least Precision are not the accurate choice
to differentiate). This inspired me to add a few more tests and
a simple fuzzer for the new code.

I initially tried to make the fuzzer verify the roots were correct,
however due to floating point imprecisions, this was an infeasible
game of whack-a-float. At least we can assert we do only return
finite numbers, the roots are unique, and for the case of the
ValidT roots, only roots in the range [0, 1].

CubicMapTest doesn't need the PathOps version of the root solver,
so I changed it to use the base version.

Change-Id: Ic5a190fe16a54046319da4946a95b5e4c1df6ba6
Bug: skia:13983, skia:14063
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/633476
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>

[add] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/fuzz/oss_fuzz/FuzzCubicQuadRoots.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/src/base/SkCubics.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/tests/QuadRootsTest.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/tests/BUILD.bazel
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/src/pathops/SkPathOpsQuad.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/src/pathops/SkPathOpsCubic.cpp
[add] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/fuzz/FuzzCubicQuadRoots.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/tests/CubicRootsTest.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/BUILD.gn
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/src/base/SkQuads.h
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/fuzz/FuzzMain.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/src/base/SkQuads.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/src/base/SkCubics.h
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/tests/CubicMapTest.cpp

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #44Jan 26, 2023 03:48AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/668d32d23387111e495bb6975cbeeda27aa9df57

commit 668d32d23387111e495bb6975cbeeda27aa9df57
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 25 16:47:20 2023

[skia] Remove reference to empty SkUtilsArm.cpp file

The file is empty: https://github.com/google/skia/blob/876b045881a6b53d0db19ed812abd8814d7c359c/src/core/SkUtilsArm.cpp

Bug: skia:13983
Change-Id: I6424cacdc9de7c8b73417a9e9290fc4fd1baf602
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4194696
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Quick-Run: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1096815}

[modify] https://crrev.com/668d32d23387111e495bb6975cbeeda27aa9df57/skia/BUILD.gn

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #45Jan 26, 2023 06:23AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #46Jan 31, 2023 07:11AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d

commit 3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Jan 30 19:28:12 2023

Replace Pathops in Geometry::ChopMonoCubic implementation

This uses code in base instead, breaking the connection between
SkPath and Pathops.

This extracts one more function into SkBezierCurves.h, one
that converts between the control points and the polynomial.
It also adds a test comparing that functionality to the
Pathops one. We might be able to, in a follow-up CL, replace
SkDCubic::Coefficients with SkBezierCubic::ConvertToPolynomial.

Change-Id: I65e2b692c63a8c647ac48552008424ef1ea5d737
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/633458
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

[modify] https://crrev.com/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d/tests/CubicChopTest.cpp
[modify] https://crrev.com/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d/src/pathops/SkPathOpsCubic.cpp
[modify] https://crrev.com/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d/src/base/SkBezierCurves.cpp
[modify] https://crrev.com/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d/src/base/SkBezierCurves.h
[modify] https://crrev.com/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d/BUILD.gn
[modify] https://crrev.com/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d/src/core/SkGeometry.cpp

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #47Jan 31, 2023 07:11AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #48Feb 2, 2023 01:31AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #49Feb 2, 2023 02:58AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #50Feb 11, 2023 10:19AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/97fd0734cc5975df41c63a5155634dc7c7a4b6dc

commit 97fd0734cc5975df41c63a5155634dc7c7a4b6dc
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Feb 10 23:18:38 2023

Remove unused include of SkRandom.h

The Skia team intends to remove SkRandom.h from the public API.

This was the only known use of it in Chrome.

Change-Id: If16da227b45db34b43f70206da05b795700b63d7
Bug: skia:13983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4242158
Commit-Queue: Scott Violet <sky@chromium.org>
Quick-Run: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1104100}

[modify] https://crrev.com/97fd0734cc5975df41c63a5155634dc7c7a4b6dc/components/tab_groups/tab_group_color.cc

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #51Feb 14, 2023 01:58AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #52Feb 14, 2023 04:45AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #53Feb 16, 2023 02:24AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #54Feb 16, 2023 05:28AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #55Feb 17, 2023 01:20AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/7ab77ebd763de401cd559e3f254ee3e23ec3c2f4

commit 7ab77ebd763de401cd559e3f254ee3e23ec3c2f4
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Feb 16 14:19:51 2023

Have Skia build use lists of files instead of hard-coded paths

This makes renaming or otherwise splitting the encoder logic
easier.

Using skia_discardable_memory_chromium allows Skia to remove
chromium-specific files from its more general file lists.

Bug: skia:13983
Change-Id: I88c635db3197418e5ded8e279541bfd62b71d563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4260665
Reviewed-by: Florin Malita <fmalita@chromium.org>
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1106186}

[modify] https://crrev.com/7ab77ebd763de401cd559e3f254ee3e23ec3c2f4/skia/BUILD.gn

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #56Feb 17, 2023 02:36AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/24984ec7ec49f93e6b6175ff8aa151f265188e39

commit 24984ec7ec49f93e6b6175ff8aa151f265188e39
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Feb 16 13:41:20 2023

Introduce filegroups and gni file lists for encoding logic

This will allow the Skia Chrome BUILD.gn file [3] have fewer
hard-coded paths and make CLs like [1] and [2] easier.

[1] https://skia-review.googlesource.com/c/skia/+/643298
[2] https://skia-review.googlesource.com/c/skia/+/644318
[3] https://source.chromium.org/chromium/chromium/src/+/main:skia/BUILD.gn;l=322;drc=1e4f64e234bf69fa231f5463cf18ebb74125f05c

Change-Id: Ie4f5c74f6a2a01c2e6f195a4680abd772d8f6c31
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/644658
Reviewed-by: Ben Wagner <bungeman@google.com>

[modify] https://crrev.com/24984ec7ec49f93e6b6175ff8aa151f265188e39/gn/core.gni
[modify] https://crrev.com/24984ec7ec49f93e6b6175ff8aa151f265188e39/BUILD.gn
[modify] https://crrev.com/24984ec7ec49f93e6b6175ff8aa151f265188e39/bazel/exporter_tool/main.go
[modify] https://crrev.com/24984ec7ec49f93e6b6175ff8aa151f265188e39/src/images/BUILD.bazel

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #57Feb 17, 2023 06:11AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/64d3cff36a1596dfc50c1242d71ce47543d93723

commit 64d3cff36a1596dfc50c1242d71ce47543d93723
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Feb 16 19:10:32 2023

Use Skia's encode file lists instead of hard-coded files

After https://skia-review.googlesource.com/c/skia/+/644658 is rolled
into Chrome, this will clean up those hard-coded files so we
can seamlessly land CLs like
https://skia-review.googlesource.com/c/skia/+/644318

Bug: skia:13983
Change-Id: I01b1c5bcd6f15e1c74ef4c9c411ea075d6fcf718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4261368
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1106351}

[modify] https://crrev.com/64d3cff36a1596dfc50c1242d71ce47543d93723/skia/BUILD.gn

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #58Feb 17, 2023 07:35AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/5c1224bc407e3c42cbb45a1ebed2f0fe7dd268b3

commit 5c1224bc407e3c42cbb45a1ebed2f0fe7dd268b3
Author: Iman Saboori <isaboori@google.com>
Date: Thu Feb 16 20:34:12 2023

Revert "Use Skia's encode file lists instead of hard-coded files"

This reverts commit 64d3cff36a1596dfc50c1242d71ce47543d93723.

Reason for revert: [Build sheriff] It stops code base to be compiled
crbug.com/1416980

Original change's description:

- Show quoted text -

Bug: skia:13983
Change-Id: If6f6a7e6deffe8b99d008c529bf85ebf50c35a75
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4262691
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Iman Saboori <isaboori@google.com>
Cr-Commit-Position: refs/heads/main@{#1106406}

[modify] https://crrev.com/5c1224bc407e3c42cbb45a1ebed2f0fe7dd268b3/skia/BUILD.gn

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #59Feb 17, 2023 07:41AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #60Feb 17, 2023 10:09AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/da6ae9bbeed261b92ba2bc26455dbc63b5636765

commit da6ae9bbeed261b92ba2bc26455dbc63b5636765
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Feb 16 23:02:17 2023

Revert "Move src/images to src/encode"

This reverts commit cdb0955534cd7400c67dc82b8e549a2892853e87.

Reason for revert: Chrome has reverted https://chromium-review.googlesource.com/c/chromium/src/+/4262691

Original change's description:

- Show quoted text -

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #61Feb 17, 2023 11:28PM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/372a0857bf47009a6b245679a5d926b3bf5ca92a

commit 372a0857bf47009a6b245679a5d926b3bf5ca92a
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Feb 17 11:44:38 2023

Reland "Move src/images to src/encode"

This reverts commit da6ae9bbeed261b92ba2bc26455dbc63b5636765.

Reason for revert: Chrome has rolled

Original change's description:

- Show quoted text -

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #62Feb 18, 2023 12:10AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/d62f12f4d34253ba142430839137ecfd782fab73

commit d62f12f4d34253ba142430839137ecfd782fab73
Author: Kevin Lubick <kjlubick@chromium.org>
Date: Fri Feb 17 13:09:40 2023

Reland "Use Skia's encode file lists instead of hard-coded files"

This reverts commit 5c1224bc407e3c42cbb45a1ebed2f0fe7dd268b3.

Reason for revert: Can reland now that https://skia-review.googlesource.com/c/skia/+/644658 has rerolled into Chrome

Original change's description:

- Show quoted text -

Bug: skia:13983
Change-Id: Icccc355d88396bd9fddb09d5c532ba3a8a095b0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4262157
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1106734}

[modify] https://crrev.com/d62f12f4d34253ba142430839137ecfd782fab73/skia/BUILD.gn

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #63Feb 25, 2023 05:04AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a

commit ad8cdf1f6239a4a88a238577232c2d5c05f6a12a
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Feb 24 17:12:13 2023

Clear non-image stuff out of SkImage.cpp

Change-Id: I3fd2378e25ae86b116be08edf31be07d2be802c6
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/648856
Reviewed-by: Nicolette Prevost <nicolettep@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Nicolette Prevost <nicolettep@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>

[add] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/src/core/SkMipmapBuilder.cpp
[modify] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/gn/core.gni
[modify] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/src/image/SkImage.cpp
[modify] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/src/core/SkSamplingPriv.h
[modify] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/src/core/BUILD.bazel
[modify] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/public.bzl
[modify] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/src/core/SkMipmapBuilder.h

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #64Feb 28, 2023 02:26AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1

commit 7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Feb 27 13:39:31 2023

Remove SK_HAS_ANDROID_CODEC guard

It was only used in one place and was on by default in nearly every
build. Let's try removing the guard.

This requires breaking a dependency knot between SkCodec
and SkAndroidCodec. If a frame depends on frame N-1,
SkCodec would need to have SkAndroidCodec decode frame N-1, which
in turn requires a call to handleFrameIndex at N-1.

Instead of having SkCodec know about SkAndroidCodec, I turned
the call into a callback function, which *only* SkAndroidCodec sets.

This logic confused me greatly until I realized that this was
(complicated) recursion and then what the base case was (finding
a frame that does not need an earlier frame). I added some comments
to hopefully make that connection easier for future readers of
the code.

I also learned that if you want to be able to pass in a lambda
as a function parameter, you cannot use a function pointer
but must take in a std::function.

See also the discussion on https://skia-review.googlesource.com/c/skia/+/333225?tab=comments

Change-Id: I71c2e393d1a81b782f04433750134f32ea7dd2be
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/645436
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>

[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/modules/canvaskit/BUILD.gn
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/src/codec/SkCodec.cpp
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/BUILD.gn
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/include/codec/SkCodec.h
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/src/codec/SkAndroidCodec.cpp
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/public.bzl
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/defines.bzl

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #65Feb 28, 2023 04:39AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/a13d52c7aaa842ddc9cea34f779561152bbeff78

commit a13d52c7aaa842ddc9cea34f779561152bbeff78
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Feb 27 16:30:55 2023

Remove unused method from SkClipStack

This breaks one more link between src/core and src/gpu

Change-Id: I3d63edbc85cb22d9c0d2fe77ee60eb4386577841
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/649520
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Nicolette Prevost <nicolettep@google.com>

[modify] https://crrev.com/a13d52c7aaa842ddc9cea34f779561152bbeff78/src/core/SkClipStack.h
[modify] https://crrev.com/a13d52c7aaa842ddc9cea34f779561152bbeff78/src/core/SkClipStack.cpp

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #66Feb 28, 2023 05:23AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #67Mar 2, 2023 12:41AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/f9c77b544bbf313749ca5949c85048f500990a3c

commit f9c77b544bbf313749ca5949c85048f500990a3c
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Feb 28 12:30:15 2023

Remove shim files

This private files are no longer used by Android.

No-Try: true
Change-Id: Ib337c21d9c388edb3f74f7004f47f7aef60cf37a
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/650117
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>

[modify] https://crrev.com/f9c77b544bbf313749ca5949c85048f500990a3c/gn/core.gni
[delete] https://crrev.com/bed6349fac158d3f121f06ea5add7200be44bf30/src/core/SkTSearch.h
[modify] https://crrev.com/f9c77b544bbf313749ca5949c85048f500990a3c/tools/rewrite_includes.py
[modify] https://crrev.com/f9c77b544bbf313749ca5949c85048f500990a3c/include/private/BUILD.bazel
[delete] https://crrev.com/bed6349fac158d3f121f06ea5add7200be44bf30/include/private/SkMalloc.h
[delete] https://crrev.com/bed6349fac158d3f121f06ea5add7200be44bf30/include/private/SkFixed.h

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #68Mar 3, 2023 11:13PM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #69Mar 14, 2023 02:00AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #70Mar 14, 2023 02:29AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #71Mar 15, 2023 04:34AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #72Mar 15, 2023 04:37AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #73Mar 16, 2023 04:18AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/9dcbea82236c37587cf48c6b1c9ec6499bc1704b

commit 9dcbea82236c37587cf48c6b1c9ec6499bc1704b
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Mar 15 17:17:16 2023

Update Chromium to use SkTextureCompressionType instead of SkImage constant

Follow-up to https://skia-review.googlesource.com/c/skia/+/656237

While I was fixing these files, I tidied up some #includes that
were missing/extra, as Skia is actively cleaning up our internal
includes and this will help reduce future churn.

Bug: skia:13983
Change-Id: I57c51e45266ea2171ff221f62b8fa99c01a80b30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4340209
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1117594}

[modify] https://crrev.com/9dcbea82236c37587cf48c6b1c9ec6499bc1704b/gpu/command_buffer/service/shared_image/wrapped_sk_image_backing.cc
[modify] https://crrev.com/9dcbea82236c37587cf48c6b1c9ec6499bc1704b/gpu/command_buffer/service/shared_image/wrapped_sk_image_backing_factory.cc
[modify] https://crrev.com/9dcbea82236c37587cf48c6b1c9ec6499bc1704b/gpu/command_buffer/service/skia_utils.cc

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #74Mar 16, 2023 04:33AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/c947fef0b7b7bc0258e6778e5566e47ccb974705

commit c947fef0b7b7bc0258e6778e5566e47ccb974705
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Mar 15 17:31:16 2023

Fix includes as a result of removing SkImage

In https://skia-review.googlesource.com/c/skia/+/656879 we are
removing an unnecessary include that some files in Chromium
were transitively depending on. This CL fixes those dependencies
and a few others that I noticed were missing.

Bug: skia:13983
Change-Id: I2a4f54df1ba3613266716a1536d58146699a08b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4340411
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1117603}

[modify] https://crrev.com/c947fef0b7b7bc0258e6778e5566e47ccb974705/android_webview/browser/gfx/vulkan_gl_interop.cc
[modify] https://crrev.com/c947fef0b7b7bc0258e6778e5566e47ccb974705/android_webview/browser/gfx/vulkan_gl_interop.h
[modify] https://crrev.com/c947fef0b7b7bc0258e6778e5566e47ccb974705/gpu/skia_bindings/grcontext_for_gles2_interface.h

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #75Mar 16, 2023 06:09AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/22d81958032172454b575f7f6d767f8ccd6872bd

commit 22d81958032172454b575f7f6d767f8ccd6872bd
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Mar 14 17:07:09 2023

Remove legacy pin methods from SkImagePriv

Last usage removed in http://ag/21990732

Change-Id: Idb5684e5947f9d2e4f7e1b881d146b7b3172ed2d
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/656242
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

[modify] https://crrev.com/22d81958032172454b575f7f6d767f8ccd6872bd/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/22d81958032172454b575f7f6d767f8ccd6872bd/src/image/SkImage_Raster.h
[modify] https://crrev.com/22d81958032172454b575f7f6d767f8ccd6872bd/src/core/SkImagePriv.h
[modify] https://crrev.com/22d81958032172454b575f7f6d767f8ccd6872bd/tests/PinnedImageTest.cpp

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #76Mar 20, 2023 01:16PM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #77Mar 20, 2023 09:52PM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/5b2cbd717b555792602461e9d6f47b663dfd18c5

commit 5b2cbd717b555792602461e9d6f47b663dfd18c5
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Mar 20 10:50:43 2023

Revert "Introduce SkImages namespace; remove Ganesh GPU code from SkImage_Raster"

This reverts commit d21c3f85a2425d7d31ae1a258b920fccd53aed1c.

Reason for revert: Broke Chromium, Android, and G3

Original change's description:

- Show quoted text -

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #78Mar 21, 2023 12:23PM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5

commit ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Mar 20 20:31:01 2023

Reland "Introduce SkImages namespace; remove Ganesh GPU code from SkImage_Raster"

This is a reland of commit d21c3f85a2425d7d31ae1a258b920fccd53aed1c
- Removes a non-existent file from public.bzl
- Adds implementation of some missing backwards-compatible shims
- Re-adds an unintentionally deleted null check from gm/image.cpp

Original change's description:

- Show quoted text -

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #79Mar 22, 2023 09:14AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/3e6bfdfea566b8368b10cd911499ae1bb09d3004

commit 3e6bfdfea566b8368b10cd911499ae1bb09d3004
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Mar 21 14:34:49 2023

Revert "Reland "Introduce SkImages namespace; remove Ganesh GPU code from SkImage_Raster""

This reverts commit ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5.

Reason for revert: Mysterious Android failures. Readback issues?

Original change's description:

- Show quoted text -

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #80Mar 23, 2023 05:35AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #81Mar 24, 2023 01:10AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #82Mar 24, 2023 02:04AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #83Mar 24, 2023 11:58PM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/77472bf8434041b6e8a239f93816088e680f479c

commit 77472bf8434041b6e8a239f93816088e680f479c
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Mar 24 11:11:17 2023

Reland "Reland "Introduce SkImages namespace; remove Ganesh GPU code from SkImage_Raster""

This reverts commit 3e6bfdfea566b8368b10cd911499ae1bb09d3004.

Reason for revert: Fixing Android

Original change's description:

- Show quoted text -

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #84Mar 25, 2023 07:44AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #85Mar 28, 2023 07:31AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #86Mar 31, 2023 02:51AM

kj...@google.com <kj...@google.com> #87Mar 31, 2023 05:55AM

[Empty comment from Monorail migration]

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #88Mar 31, 2023 07:55AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/f6c1eefd46005871af541940ea36fc000fec5451

commit f6c1eefd46005871af541940ea36fc000fec5451
Author: Michael Ludwig <michaelludwig@google.com>
Date: Thu Mar 30 19:56:51 2023

Revert "Remove some GPU-specific methods from SkImage"

This reverts commit 89ea350e87a8f1ecef317e40b6386a138bb8e7b0.

Reason for revert: breaking chrome build around flush() ambiguity

Original change's description:

- Show quoted text -

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #89Apr 1, 2023 02:02AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/79f6ec67cb060f4cb13a030cdaded2276f489226

commit 79f6ec67cb060f4cb13a030cdaded2276f489226
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Mar 31 15:01:36 2023

Fix use of GrDirectContext->flush and Skia includes

In http://review.skia.org/664477 we
introduce a new API to GrDirectContext that requires disambiguating
flushes. Additional changes change up #includes a bit and
would otherwise break Chrome in places that were not
including correctly.

Bug: skia:13983, skia:13052
Change-Id: Ia14c826d1a32f97e5f9c510d32532805a38fc16d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4387338
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1124723}

[modify] https://crrev.com/79f6ec67cb060f4cb13a030cdaded2276f489226/gpu/command_buffer/service/shared_image/external_vk_image_backing.cc
[modify] https://crrev.com/79f6ec67cb060f4cb13a030cdaded2276f489226/printing/common/metafile_utils.cc
[modify] https://crrev.com/79f6ec67cb060f4cb13a030cdaded2276f489226/components/paint_preview/common/serial_utils.cc
[modify] https://crrev.com/79f6ec67cb060f4cb13a030cdaded2276f489226/printing/metafile_skia.h

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #90Apr 1, 2023 02:32AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/aedee7ddca3b435793ce91ae1160b1e3aea753bf

commit aedee7ddca3b435793ce91ae1160b1e3aea753bf
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Mar 31 15:31:43 2023

Disable legacy SkImage factories

Follow-up to https://skia-review.googlesource.com/c/skia/+/661059
and https://chromium-review.googlesource.com/c/chromium/src/+/4348201

Chromium and all deps should be migrated to the new APIs at this
point, so we can set SK_DISABLE_LEGACY_IMAGE_FACTORIES to
prevent unintentional use.

Bug: skia:13983
Change-Id: Ibf7a7f900c142f6b6ab803758364aa98f84ef01b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4388783
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1124742}

[modify] https://crrev.com/aedee7ddca3b435793ce91ae1160b1e3aea753bf/skia/BUILD.gn
[modify] https://crrev.com/aedee7ddca3b435793ce91ae1160b1e3aea753bf/cc/paint/image_transfer_cache_entry.cc

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #91Apr 1, 2023 06:56AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5

commit 4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Mar 31 12:34:10 2023

Reland "Remove some GPU-specific methods from SkImage"

This reverts commit f6c1eefd46005871af541940ea36fc000fec5451.

Reason for revert: Fixed clients

Client CLs:
- https://crrev.com/c/4387338

Original change's description:

- Show quoted text -

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #92Apr 2, 2023 12:30PM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/7ca5e4f609d6628c5294f8837cf384b2f2bbc342

commit 7ca5e4f609d6628c5294f8837cf384b2f2bbc342
Author: Michael Ludwig <michaelludwig@google.com>
Date: Sun Apr 02 00:39:33 2023

Revert "Reland "Remove some GPU-specific methods from SkImage""

This reverts commit 4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5.

Reason for revert: cc_unittest asserts in Skia code related to YUV
images and ref counting.

Original change's description:

- Show quoted text -

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #93Apr 5, 2023 02:58AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/7a2d1b334fc86133e203daa19d53dcacd6893757

commit 7a2d1b334fc86133e203daa19d53dcacd6893757
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Apr 04 13:50:57 2023

Reland "Reland "Remove some GPU-specific methods from SkImage""

This reverts commit 7ca5e4f609d6628c5294f8837cf384b2f2bbc342.

Fix use-after free by reffing pointers and avoid extra copy
in MakeBackendTextureFromImage which loses mipmaps.

Original change's description:

- Show quoted text -

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #94Apr 6, 2023 04:48AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/1e83bc195f7f035a54f3793aa13902f7209bee41

commit 1e83bc195f7f035a54f3793aa13902f7209bee41
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Apr 05 14:16:17 2023

Allow SkImage pointer in GetBackendTextureFromImage

While Skia exclusively uses the sk_sp version, clients seem to use
a mix of sk_sp and raw pointers. It seems silly to require clients
to wrap the pointer just to have it be unwrapped, so this extra alias
should make the transition more seamless.

Change-Id: Iaa45f9e75848297386c8cf261c69c08fddd99dac
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/666857
Reviewed-by: Brian Osman <brianosman@google.com>

[modify] https://crrev.com/1e83bc195f7f035a54f3793aa13902f7209bee41/src/image/SkImage.cpp
[modify] https://crrev.com/1e83bc195f7f035a54f3793aa13902f7209bee41/include/gpu/ganesh/SkImageGanesh.h
[modify] https://crrev.com/1e83bc195f7f035a54f3793aa13902f7209bee41/src/gpu/ganesh/image/SkImage_GaneshFactories.cpp

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #95Apr 6, 2023 06:13AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7

commit c6bda115cf96bf5e03bd3dc5fe67046da3f62da7
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Apr 05 19:34:43 2023

Move mipmap serialization and deserialization to read/writebuffer

This will allow compilation of SkImage related things (including
Mipmaps) without needing to bring in the PNG codec.

This re-uses the Image serialization and deserialization proc
for the mipmap layers, with the default still being PNG encoding.

It also reduces code size by letting the linker drop out the
WEBP and JPEG encoders in certain circumstances.

Bug: skia:13983
Change-Id: I0249be88e6f97bb8b70bbebf4b5acc5958836bbf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/664177
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

[modify] https://crrev.com/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7/RELEASE_NOTES.md
[modify] https://crrev.com/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7/src/core/SkMipmap.h
[modify] https://crrev.com/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7/include/core/SkSerialProcs.h
[modify] https://crrev.com/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7/src/core/SkReadBuffer.cpp
[modify] https://crrev.com/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7/src/core/SkMipmap.cpp
[modify] https://crrev.com/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7/src/core/SkWriteBuffer.cpp

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #96Apr 7, 2023 03:51AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/f9a0d0472a5eef23c339e34708f543ce15e6bcf4

commit f9a0d0472a5eef23c339e34708f543ce15e6bcf4
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Apr 06 14:14:20 2023

Remove WIC and CG image encoders

These are unused inside of Skia and in our major clients. Removing
them will make modularization of the codecs easier.

Bug: skia:13983
Change-Id: Ibcc12c81fe723a4f06aeda7d6ca52e503439d8e3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/667142
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>

[modify] https://crrev.com/f9a0d0472a5eef23c339e34708f543ce15e6bcf4/RELEASE_NOTES.md
[delete] https://crrev.com/3ff611ffaae34e87263f523b5cc80a1c0f521b13/src/ports/SkImageEncoder_CG.cpp
[modify] https://crrev.com/f9a0d0472a5eef23c339e34708f543ce15e6bcf4/BUILD.gn
[modify] https://crrev.com/f9a0d0472a5eef23c339e34708f543ce15e6bcf4/src/encode/SkImageEncoderPriv.h
[delete] https://crrev.com/3ff611ffaae34e87263f523b5cc80a1c0f521b13/src/ports/SkImageEncoder_WIC.cpp
[modify] https://crrev.com/f9a0d0472a5eef23c339e34708f543ce15e6bcf4/src/encode/SkImageEncoder.cpp
[modify] https://crrev.com/f9a0d0472a5eef23c339e34708f543ce15e6bcf4/public.bzl
[modify] https://crrev.com/f9a0d0472a5eef23c339e34708f543ce15e6bcf4/gm/encode_platform.cpp

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #97Apr 10, 2023 11:45PM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #98Apr 11, 2023 12:46AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/be9784a9b4901aa856618841210b7a50f6af585b

commit be9784a9b4901aa856618841210b7a50f6af585b
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Apr 07 17:59:35 2023

Remove legacy SkImage factories

All major clients should be migrated.

Change-Id: Ide026c79a96e48ffbe2d9b7ddefc2e5864fc9b1f
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/667305
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Herb Derby <herb@google.com>

[modify] https://crrev.com/be9784a9b4901aa856618841210b7a50f6af585b/src/image/SkImage.cpp
[modify] https://crrev.com/be9784a9b4901aa856618841210b7a50f6af585b/include/core/SkImage.h

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #99Apr 11, 2023 01:52AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/9f27f16e5fb76a8a869432a6189e472a816faea4

commit 9f27f16e5fb76a8a869432a6189e472a816faea4
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Apr 10 15:51:29 2023

Add CHECK to SkImages::GetBackendTextureFromImage and squash NPE

It was noticed in https://chromium-review.googlesource.com/c/chromium/src/+/4401454
that there could be a null dereference (crash) if
SkImages::TextureFromYUVATextures returned false.

One way this can happen is if SkImages::GetBackendTextureFromImage
returns false (and thus the given yuv_texture is invalid).

This makes sure the three textures we get are valid (using CHECK
because they should always be gettable) and a nullness
check for yuva_image.

Bug: skia:13983
Change-Id: Ie5849a8bb56a9f4534cc511ad468e5eb0027b5a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4402159
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1128162}

[modify] https://crrev.com/9f27f16e5fb76a8a869432a6189e472a816faea4/cc/tiles/gpu_image_decode_cache.cc

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #100Apr 11, 2023 02:40AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/1537de2c4cc0d2c12cddc3e23cbc47306103c5ba

commit 1537de2c4cc0d2c12cddc3e23cbc47306103c5ba
Author: Greg Daniel <egdaniel@google.com>
Date: Mon Apr 10 16:38:52 2023

Revert "Remove legacy SkImage factories"

This reverts commit be9784a9b4901aa856618841210b7a50f6af585b.

Reason for revert: breaking all graphite builds

Original change's description:

- Show quoted text -

Bug: skia:13983
Change-Id: I230dff1bb93f00ec4cd99eeef101a4df6fdac0fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/668576
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Greg Daniel <egdaniel@google.com>

[modify] https://crrev.com/1537de2c4cc0d2c12cddc3e23cbc47306103c5ba/src/image/SkImage.cpp
[modify] https://crrev.com/1537de2c4cc0d2c12cddc3e23cbc47306103c5ba/include/core/SkImage.h

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #101Apr 11, 2023 03:53AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/a3db72436782867851ab512141284564f183067b

commit a3db72436782867851ab512141284564f183067b
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Apr 10 17:05:21 2023

Reland "Remove legacy SkImage factories"

This is a reland of commit be9784a9b4901aa856618841210b7a50f6af585b

Original change's description:

- Show quoted text -

Bug: skia:13983
Change-Id: If14e147dca941d11b1401ca8dd6f8918d5c8743f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/668596
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

[modify] https://crrev.com/a3db72436782867851ab512141284564f183067b/src/image/SkImage.cpp
[modify] https://crrev.com/a3db72436782867851ab512141284564f183067b/include/gpu/graphite/Context.h
[modify] https://crrev.com/a3db72436782867851ab512141284564f183067b/include/core/SkImage.h

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #102Apr 12, 2023 08:38AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/a976b1be29b42a417ea0f3136170f582e0d18764

commit a976b1be29b42a417ea0f3136170f582e0d18764
Author: Kevin Lubick <kjlubick@chromium.org>
Date: Tue Apr 11 22:37:05 2023

Include no-opt impl of jpeg encoding in non-blink builds

This will let us land a refactor of image encoding in Skia. [1]

This requires the following staging cl to land and roll [2].

[1] https://skia-review.googlesource.com/c/skia/+/667298
[2] https://skia-review.googlesource.com/c/skia/+/669116

Change-Id: I66e48ddaf06880f418ad954511306162b77e3f88
Bug: skia:13983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415176
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1128955}

[modify] https://crrev.com/a976b1be29b42a417ea0f3136170f582e0d18764/skia/BUILD.gn

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #103Apr 12, 2023 09:51PM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #104Apr 12, 2023 09:51PM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #105Apr 12, 2023 09:51PM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #106Apr 13, 2023 12:42AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/62b95b68d49384463ce03415a212e30b0611ea2f

commit 62b95b68d49384463ce03415a212e30b0611ea2f
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Apr 12 12:16:47 2023

Fix Bazel test targets

Follow-up to https://skia-review.googlesource.com/c/skia/+/667296

Change-Id: I5169cf7a93f15f6f6fcdf2d9900fbda4efc62ccf
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/669856
Reviewed-by: Herb Derby <herb@google.com>

[modify] https://crrev.com/62b95b68d49384463ce03415a212e30b0611ea2f/tests/BUILD.bazel

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #107Apr 13, 2023 01:59AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/e2d3dc99f4642e474c5228b59e24995022463884

commit e2d3dc99f4642e474c5228b59e24995022463884
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Apr 12 13:51:15 2023

Remove encodeToData from CanvasKit and documentation

Follow-up to https://skia-review.googlesource.com/c/skia/+/667296

This adds gn arguments so clients can explicitly disable certain
encoders without having to use #ifdefs.

Change-Id: I49b9e2db3b268eaf4171b720ebfed09472af3859
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/669916
Reviewed-by: Leon Scroggins <scroggo@google.com>

[modify] https://crrev.com/e2d3dc99f4642e474c5228b59e24995022463884/modules/canvaskit/debugger_bindings.cpp
[modify] https://crrev.com/e2d3dc99f4642e474c5228b59e24995022463884/gn/skia.gni
[modify] https://crrev.com/e2d3dc99f4642e474c5228b59e24995022463884/site/docs/user/api/skcanvas_creation.md
[modify] https://crrev.com/e2d3dc99f4642e474c5228b59e24995022463884/modules/canvaskit/compile.sh
[modify] https://crrev.com/e2d3dc99f4642e474c5228b59e24995022463884/BUILD.gn
[modify] https://crrev.com/e2d3dc99f4642e474c5228b59e24995022463884/modules/canvaskit/canvaskit_bindings.cpp

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #108Apr 15, 2023 06:15AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/65d42d9528fce4d188ea649fc7adab5054bf401c

commit 65d42d9528fce4d188ea649fc7adab5054bf401c
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Apr 14 18:25:04 2023

Export public headers from encoders in GN build

Follow-up to https://skia-review.googlesource.com/c/skia/+/668696

Canary-Flutter-PR: 41204
Change-Id: If114f3374ef6bd34881e6d025ebbbb2719b4f4af
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/671917
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>

[modify] https://crrev.com/65d42d9528fce4d188ea649fc7adab5054bf401c/BUILD.gn

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #109Apr 15, 2023 06:28AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #110Apr 22, 2023 12:40AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #111Apr 24, 2023 09:52PM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #112Apr 25, 2023 01:39AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #113Apr 26, 2023 02:23AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/982db0d1bc06cbb20812d2b1de2b3adabdb861cd

commit 982db0d1bc06cbb20812d2b1de2b3adabdb861cd
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Apr 25 15:39:49 2023

Move cross-context image to use DeferredFromTextureGenerator

Should have been done in http://review.skia.org/673717

Bug: skia:13983
Change-Id: Ief2339b7ea4a1d8b0b45179c256f99b371390406
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/680557
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

[modify] https://crrev.com/982db0d1bc06cbb20812d2b1de2b3adabdb861cd/tests/GrMipMappedTest.cpp
[modify] https://crrev.com/982db0d1bc06cbb20812d2b1de2b3adabdb861cd/src/gpu/ganesh/GrBackendTextureImageGenerator.cpp
[modify] https://crrev.com/982db0d1bc06cbb20812d2b1de2b3adabdb861cd/src/gpu/ganesh/GrBackendTextureImageGenerator.h
[modify] https://crrev.com/982db0d1bc06cbb20812d2b1de2b3adabdb861cd/src/gpu/ganesh/image/SkImage_GaneshFactories.cpp

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #114Apr 26, 2023 06:01AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #115Apr 27, 2023 11:00PM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #116May 1, 2023 11:56PM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/1b1bc99c13729be3dfab95c4c7771a4936365222

commit 1b1bc99c13729be3dfab95c4c7771a4936365222
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 01 13:19:16 2023

Remove last SK_GANESH #ifdefs from non-Ganesh SkImage code

Change-Id: Ic546e0dea6108ba38b1dcc230870b54dc5db8719
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/684578
Owners-Override: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

[add] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/relnotes/skimage_methods.md
[modify] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/src/image/SkImage.cpp
[modify] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/src/gpu/ganesh/image/SkImage_GaneshBase.h
[modify] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/src/image/SkImage_Base.cpp
[modify] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/src/gpu/ganesh/image/SkImage_GaneshBase.cpp
[modify] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/src/image/SkImage_Base.h
[modify] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/include/core/SkImage.h

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #117May 3, 2023 02:25AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #118May 3, 2023 06:43AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #119May 4, 2023 09:26PM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/a88cd1bb5f323981c7dc796d2d3d9a8fa09aae37

commit a88cd1bb5f323981c7dc796d2d3d9a8fa09aae37
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu May 04 11:25:46 2023

Put MakeRenderTarget behind an #ifdef

This is needed to land https://skia-review.googlesource.com/c/skia/+/687779
because this code is compiled sometimes with no GPU backend
(e.g. ios_simulator).

Bug: skia:13983
Change-Id: Ie756fa34e616f347072b3ab1f23150ba8756aeb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4503058
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1139439}

[modify] https://crrev.com/a88cd1bb5f323981c7dc796d2d3d9a8fa09aae37/ui/gfx/color_conversion_sk_filter_cache.cc

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #120May 8, 2023 09:31PM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/64ba57381c94352724cff0af77b24d14d18a5024

commit 64ba57381c94352724cff0af77b24d14d18a5024
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed May 03 12:36:52 2023

Don't define SkSurface::MakeRenderTarget when there is no GPU backend

Follow up on Android TODO in SkSurface

Client CLs:
- http://ag/22965803
- http://ag/22989547
- https://crrev.com/c/4503058

Change-Id: I8ba72c2c60c9c1ca2fa2a55e720e9eabc99451ad
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/687779
Reviewed-by: Leon Scroggins <scroggo@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>

[modify] https://crrev.com/64ba57381c94352724cff0af77b24d14d18a5024/src/image/SkSurface.cpp
[modify] https://crrev.com/64ba57381c94352724cff0af77b24d14d18a5024/include/core/SkSurface.h

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #121May 9, 2023 05:15AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #122May 9, 2023 07:44AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/70b7b2ca2106a2022ad636c0cd44335f5931c22f

commit 70b7b2ca2106a2022ad636c0cd44335f5931c22f
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 08 21:40:46 2023

Fix include of GrTypes.h

In https://skia-review.googlesource.com/c/skia/+/687639, we
remove GrTypes.h from SkSurface.h and this would otherwise
break.

Bug: skia:13983
Change-Id: Iac65504dcf76bca88ad696d3dd3a84b1a9ebfb6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4514119
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1141068}

[modify] https://crrev.com/70b7b2ca2106a2022ad636c0cd44335f5931c22f/third_party/blink/renderer/platform/graphics/canvas_resource_provider.h

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #123May 11, 2023 01:18AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #124May 12, 2023 10:15PM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #125May 13, 2023 12:12AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #126May 13, 2023 02:34AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #127May 16, 2023 01:11AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/32f2606a1ebe97e5b9b95c89860b503d2ba3f292

commit 32f2606a1ebe97e5b9b95c89860b503d2ba3f292
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 15 14:28:25 2023

Fix legacy SkSurface::MakeNull call

This prevents us from setting SK_DISABLE_LEGACY_SKSURFACE_FACTORIES

Change-Id: I75971bcfcc2290f2e6c34a67d16ecc7e86acf6af
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/698058
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

[modify] https://crrev.com/32f2606a1ebe97e5b9b95c89860b503d2ba3f292/src/image/SkSurface_Null.cpp

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #128May 16, 2023 01:41AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #129May 16, 2023 05:04AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/d26f042bb364f459bd2eb82cf91eb910d2466c70

commit d26f042bb364f459bd2eb82cf91eb910d2466c70
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 15 19:03:53 2023

SkSurface::MakeNull -> SkSurfaces::Null

API change happened in https://skia-review.googlesource.com/c/skia/+/696537

Change-Id: Ie0ffbe66d83004f7a6fea1a7e1d23ddc8ae7c300
Bug: skia:13983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4532575
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1144281}

[modify] https://crrev.com/d26f042bb364f459bd2eb82cf91eb910d2466c70/ui/ozone/platform/cast/surface_factory_cast.cc

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #130May 16, 2023 10:15AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/5a3cae2a9dbba6bde350ee93c91c4246a8f9e524

commit 5a3cae2a9dbba6bde350ee93c91c4246a8f9e524
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 15 19:46:10 2023

Remove one more legacy SkSurface factory

Change-Id: Ib68429cad836ad96486b477f0f5462d83a110f99
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/698315
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

[modify] https://crrev.com/5a3cae2a9dbba6bde350ee93c91c4246a8f9e524/src/gpu/graphite/ImageFactories.cpp

kj...@google.com <kj...@google.com> #131May 18, 2023 01:07AM

[Empty comment from Monorail migration]

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #132May 18, 2023 01:18AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/9ca6646e9f1d4146cd9612e25ec3fb28b18693a9

commit 9ca6646e9f1d4146cd9612e25ec3fb28b18693a9
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed May 17 14:33:52 2023

Delete unused shim image factory code

This should have been deleted in
https://skia-review.googlesource.com/c/skia/+/668596

Change-Id: Ic2e935d40ee330cf9e4e79b4e156f19ddf108275
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/699537
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

[modify] https://crrev.com/9ca6646e9f1d4146cd9612e25ec3fb28b18693a9/src/image/SkImage_AndroidFactories.cpp

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #133May 20, 2023 04:18AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #134May 20, 2023 07:08AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/c80e566b30f6b35ea1b08b7794b3a894deaee47c

commit c80e566b30f6b35ea1b08b7794b3a894deaee47c
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri May 19 21:05:35 2023

Revert "Remove legacy SkSurface factories"

This reverts commit 280b58560f3430b5eecd223d69ff792682dd6d15.

Reason for revert: Need to land https://github.com/flutter/engine/pull/42158 and have that roll into G3

Original change's description:

- Show quoted text -

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #135May 23, 2023 11:04PM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #136May 23, 2023 11:47PM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed

commit 657ed9cf2379a950b925cb2aba7c85d6e1dd36ed
Author: Brian Osman <brianosman@google.com>
Date: Tue May 23 12:40:12 2023

Reland "Replace SkOpts::hash/hash_fn with SkChecksum::Hash32"

This reverts commit fc369d15070f10199e122d0be2d94e060e81d795.

Reason for revert: Added SK_SPI to fix shared library builds

Original change's description:

- Show quoted text -

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #137May 24, 2023 06:31AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/69f7860093b4ec7971d1e3bee458847aa849c351

commit 69f7860093b4ec7971d1e3bee458847aa849c351
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue May 23 18:27:44 2023

Add placeholders to pdf.gni for SkJpegInfo

We need to land this first to fix Chrome's build rules

Bug: skia:13983
Change-Id: I825e4ade1742836e44089b6b07ce159c5ed0cade
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/702221
Reviewed-by: Ben Wagner <bungeman@google.com>

[modify] https://crrev.com/69f7860093b4ec7971d1e3bee458847aa849c351/gn/pdf.gni
[modify] https://crrev.com/69f7860093b4ec7971d1e3bee458847aa849c351/bazel/exporter/gni_exporter.go

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #138May 24, 2023 10:01PM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/b5e69114df6d10a6d19be48c83acfa3f7bcaac69

commit b5e69114df6d10a6d19be48c83acfa3f7bcaac69
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri May 19 15:09:24 2023

Reland "Remove legacy SkSurface factories"

This is a reland of commit 280b58560f3430b5eecd223d69ff792682dd6d15

flutter->G3 has landed, so we should be good to go

Original change's description:

- Show quoted text -

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #139May 25, 2023 01:57AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/6b21dd5cba02e2bb57ba701def95c76936a362b0

commit 6b21dd5cba02e2bb57ba701def95c76936a362b0
Author: Brian Osman <brianosman@google.com>
Date: Tue May 23 15:38:11 2023

Remove empty SkOpts files (crc32, sse42)

Bug: skia:13983
Change-Id: Ie4de8f8a92cb2c204ac807f4eabdd78311acac00
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/702837
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>

[modify] https://crrev.com/6b21dd5cba02e2bb57ba701def95c76936a362b0/gn/opts.gni
[modify] https://crrev.com/6b21dd5cba02e2bb57ba701def95c76936a362b0/gn/shared_sources.gni
[delete] https://crrev.com/5ebf90ed364b03354d75e7640421cdc0c181043f/src/opts/SkOpts_crc32.cpp
[modify] https://crrev.com/6b21dd5cba02e2bb57ba701def95c76936a362b0/BUILD.gn
[modify] https://crrev.com/6b21dd5cba02e2bb57ba701def95c76936a362b0/gn/gn_to_bp.py
[modify] https://crrev.com/6b21dd5cba02e2bb57ba701def95c76936a362b0/src/opts/BUILD.bazel
[delete] https://crrev.com/5ebf90ed364b03354d75e7640421cdc0c181043f/src/opts/SkOpts_sse42.cpp

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #140May 25, 2023 03:26AM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/1bd909bbe61a290fa99f0e5c7913fd3de0dafe9c

commit 1bd909bbe61a290fa99f0e5c7913fd3de0dafe9c
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed May 24 17:25:52 2023

Use file lists for Skia's pdf jpeg parsing code

Follow-up to https://skia-review.googlesource.com/c/skia/+/702221
and precursor to https://skia-review.googlesource.com/c/skia/+/702138

Bug: skia:13983
Change-Id: Ida9b3667f5854e023629e061d190149b8f5f0b2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4562335
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1148610}

[modify] https://crrev.com/1bd909bbe61a290fa99f0e5c7913fd3de0dafe9c/skia/BUILD.gn

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #141May 25, 2023 04:25AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #142May 25, 2023 09:58PM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #143May 25, 2023 11:39PM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/156faa03aa5ef28c9b2e187255fccc0aec79ff8f

commit 156faa03aa5ef28c9b2e187255fccc0aec79ff8f
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu May 25 13:38:30 2023

Update Skia's legacy build flags

The deleted defines are no longer in the Skia codebase
(and thus have no effect). PDFium has rolled, so we should
be able to disable unintentional calls to the shim surface
factories.

Bug: skia:13983
Change-Id: I104f3fdfc566b338757b41b97c1a66dbe43b3432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4544537
Reviewed-by: Florin Malita <fmalita@chromium.org>
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1149058}

[modify] https://crrev.com/156faa03aa5ef28c9b2e187255fccc0aec79ff8f/skia/BUILD.gn

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #144May 31, 2023 01:21AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/bab82f14da1a77c782f307b3765f29aa251bf57f

commit bab82f14da1a77c782f307b3765f29aa251bf57f
Author: Brian Osman <brianosman@google.com>
Date: Tue May 30 13:33:21 2023

Switch back to Skia CPU defines in SkVx.h

This effectively reverts commit:
7d3b27d90ea433dd02a556f7831e55f6c4ef27b7

I intend to switch the compilation target within translation units, and
this style makes it much simpler (we can just redefine SK_CPU_SSE_LEVEL,
rather than the set of compiler CPU defines).

Notes:
- I removed the __F16C__ 8-wide half/float conversion blocks. These were
never used, except in the to-be-deleted SkVM interpreter (and even
then, only when dealing with half-float buffers).
- I left the WASM checks using the compiler define - we don't have a
Skia name for that yet, and there's only one target at this point, so
no need to re-define and re-compile.
- Similarly, I did change the various NEON defines back, but I left the
__aarch64__ checks. Those are guarding intrinsics that are specific to
64-bit NEON, and ALL 64-bit ARM has that functionality, so gating it
on the compiler defines doesn't hurt anything.

Bug: skia:13983
Change-Id: I2c5ad50081e747c10ab047caa82d9eafe3cbe571
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/704780
Reviewed-by: John Stiles <johnstiles@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

[modify] https://crrev.com/bab82f14da1a77c782f307b3765f29aa251bf57f/src/base/SkVx.h

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #145May 31, 2023 07:29AM

br...@google.com <br...@google.com> #146Jun 1, 2023 03:46AM

[Empty comment from Monorail migration]

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #147Jun 1, 2023 10:10PM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/074580d41cd5d30a175359b7d3ad9352ae7a3dbc

commit 074580d41cd5d30a175359b7d3ad9352ae7a3dbc
Author: Colin Blundell <blundell@chromium.org>
Date: Thu Jun 01 12:09:22 2023

[//viz] Restore capturing result of flush() following recent CL

[1] inadvertently dropped the capturing of the result of a call to
flush(), which will result in incorrect behavior. This CL restores this
capturing.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/4566404

Bug: skia:13983
Change-Id: Iffec24ffb86e113d863ca41574b468cc442288a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4579018
Auto-Submit: Colin Blundell <blundell@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1151786}

[modify] https://crrev.com/074580d41cd5d30a175359b7d3ad9352ae7a3dbc/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #148Jun 21, 2023 10:04PM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #149Jun 26, 2023 11:51PM

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/61afceadc4c747b0de775aeb25aeac5500708ae8

commit 61afceadc4c747b0de775aeb25aeac5500708ae8
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Jun 26 13:50:08 2023

Make use of Skia's codecs explicit in Blink gif decoding and viz unittests

In http://review.skia.org/689016, Skia added APIs to allow a single
codec to be explicitly used.

This CL replaces the 2 use of SkCodec::Make* with an explicit,
specific codec that is intended. This means it will no longer
try to decode the bytes with all of the compiled-in Skia codecs,
but only PNG or GIF (depending on the file).

Bug: skia:13983
Change-Id: Ia58061be43027c4b2f6b4eecdf6dc6ea8357c61d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615536
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Cr-Commit-Position: refs/heads/main@{#1162373}

[modify] https://crrev.com/61afceadc4c747b0de775aeb25aeac5500708ae8/components/viz/service/debugger/viz_debugger_unittests/viz_debugger_unittest_base.cc
[modify] https://crrev.com/61afceadc4c747b0de775aeb25aeac5500708ae8/third_party/blink/renderer/platform/image-decoders/gif/gif_image_decoder.cc

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #150Jun 30, 2023 01:18AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/095359e3efca1a43f6c5bb154033e7fe919569aa

commit 095359e3efca1a43f6c5bb154033e7fe919569aa
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jun 27 14:27:45 2023

Remove conditional compilation of SkJpegSourceMgr.cpp

The only thing SK_CODEC_DECODES_JPEG should control is the legacy
registration of decoding the JPEG codec.

Other uses had been removed previously in http://review.skia.org/689016

Change-Id: Ib12eae183fb1e87747442807e55d6605e6230765
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/717077
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>

[modify] https://crrev.com/095359e3efca1a43f6c5bb154033e7fe919569aa/src/codec/SkJpegSourceMgr.cpp

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #151Jun 30, 2023 05:49AM

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/5768563647c16ed56ed528f6ad4c30cca7140f95

commit 5768563647c16ed56ed528f6ad4c30cca7140f95
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jun 29 17:06:54 2023

Remove #ifdefs from SkAndroidCodec.cpp

We don't have two gif codecs anymore and if we cannot decode
a certain format (WebP, DNG) codec should be nullptr earlier
in the chain anyway.

The AVIF #ifdef was the trickiest to duplicate the functionality
of (see https://skia-review.googlesource.com/c/skia/+/566440).
I added a way to query the registered codecs so we don't have
#ifdefs (which make modular builds difficult in Bazel).

Bug: skia:13983
Change-Id: I0d2b614dcd76ff3a118a4e8160f03badafb6f45a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/717156
Owners-Override: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

[modify] https://crrev.com/5768563647c16ed56ed528f6ad4c30cca7140f95/include/android/SkHeifDecoder.h
[modify] https://crrev.com/5768563647c16ed56ed528f6ad4c30cca7140f95/src/codec/SkCodecPriv.h
[modify] https://crrev.com/5768563647c16ed56ed528f6ad4c30cca7140f95/src/codec/SkCodec.cpp
[modify] https://crrev.com/5768563647c16ed56ed528f6ad4c30cca7140f95/src/codec/SkAndroidCodec.cpp

is...@google.com <is...@google.com> #152Jun 30, 2023 05:49AM

Edits/notes reflect the following in Monorail: blocked-on.

[Monorail blocked-on: crbug.com/skia/14317, crbug.com/skia/14355]

kj...@google.com <kj...@google.com> Jul 26, 2023 10:57PM

Accepted by kj...@google.com.

ap...@google.com <ap...@google.com> #153Jul 28, 2023 04:11AM

Project: skia
Branch: main

commit e3ca856e7ed6c285734dacf87faccdbf9a321f05
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jul 26 08:58:05 2023

Remove legacy SkImage and SkSurface methods

Client CLs:
- http://ag/23168890
- http://ag/23171851
- http://ag/23473641
- http://ag/23494824
- http://cl/551209733
- https://crrev.com/c/4566404
- https://crrev.com/c/4705004
- https://github.com/flutter/engine/pull/42425
- https://github.com/flutter/engine/pull/43786
- https://github.com/flutter/engine/pull/43965

Change-Id: I06c71cf6dc77aeaa3f78dec61c7b7c6eca688884
Bug:

b/40045064

Reviewed-on: https://skia-review.googlesource.com/c/skia/+/729776
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

M gm/colorspace.cpp
M gm/makecolorspace.cpp
M gm/runtimeshader.cpp
M gm/wacky_yuv_formats.cpp
M include/core/SkImage.h
M include/core/SkSurface.h
M src/gpu/graphite/Image_Graphite.cpp
M src/image/SkImage.cpp
M src/image/SkSurface.cpp
M tests/ImageTest.cpp

https://skia-review.googlesource.com/729776

ap...@google.com <ap...@google.com> #154Aug 8, 2023 05:20AM

Project: skia
Branch: main

commit 84e1ebb63bc71171998ebf3ab8f70964dbe0167b
Author: Brian Osman <brianosman@google.com>
Date: Fri Aug 04 17:16:54 2023

Split out BlitMask opts into separate cpp files

See https://skia-review.googlesource.com/c/skia/+/727257 for details

Bug:

b/40045064

Bug:

b/40045066

Change-Id: I2294e49be894d7b470e6a69b4a7ec06ec44439cd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/736881
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>

M gn/core.gni
M public.bzl
M src/core/BUILD.bazel
A src/core/SkBlitMask.h
A src/core/SkBlitMask_opts.cpp
A src/core/SkBlitMask_opts_ssse3.cpp
M src/core/SkBlitter_ARGB32.cpp
M src/core/SkGraphics.cpp
M src/core/SkOpts.cpp
M src/core/SkOpts.h
M src/opts/SkOpts_ssse3.cpp

https://skia-review.googlesource.com/736881

ap...@google.com <ap...@google.com> #155Aug 10, 2023 11:39PM

Project: skia
Branch: main

commit 7a1fec6b197f14894118dc16c22b317af6d92bb4
Author: Brian Osman <brianosman@google.com>
Date: Mon Aug 07 16:50:59 2023

Split out BlitRow opts into separate cpp files

Bug:

b/40045064

Bug:

b/40045066

Change-Id: I79ab47708ed68d6af8a071fa24d51b10bb61ec1b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/736360
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>

M gn/core.gni
M public.bzl
M src/core/BUILD.bazel
M src/core/SkBlitRow.h
A src/core/SkBlitRow_opts.cpp
A src/core/SkBlitRow_opts_hsw.cpp
M src/core/SkGraphics.cpp
M src/core/SkOpts.cpp
M src/core/SkOpts.h
M src/opts/SkOpts_hsw.cpp

https://skia-review.googlesource.com/736360

ap...@google.com <ap...@google.com> #156Aug 12, 2023 02:12AM

Project: skia
Branch: main

commit a45e98a60a3bdd444cce9c1f7443e11f9c2b30db
Author: Brian Osman <brianosman@google.com>
Date: Thu Aug 10 16:55:04 2023

Split out Swizzler opts into separate cpp files

Bug:

b/40045064

Bug:

b/40045066

Change-Id: I9fd6e0818b1c3aff4176af6d5a84e8e90b9a38ec
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/740296
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

M bench/SwizzleBench.cpp
M dm/DMSrcSink.cpp
M gm/png_codec.cpp
M gn/core.gni
M public.bzl
M src/codec/SkJpegxlCodec.cpp
M src/codec/SkSwizzler.cpp
M src/codec/SkSwizzler.h
M src/core/BUILD.bazel
M src/core/SkConvertPixels.cpp
M src/core/SkGraphics.cpp
M src/core/SkOpts.cpp
M src/core/SkOpts.h
M src/core/SkSwizzle.cpp
A src/core/SkSwizzler_opts.cpp
A src/core/SkSwizzler_opts_hsw.cpp
A src/core/SkSwizzler_opts_ssse3.cpp
M src/gpu/AtlasTypes.cpp
M src/opts/SkOpts_hsw.cpp
M src/opts/SkOpts_ssse3.cpp
M tests/SwizzlerTest.cpp

https://skia-review.googlesource.com/740296

ap...@google.com <ap...@google.com> #157Aug 15, 2023 01:37AM

Project: skia
Branch: main

commit 1cf6f71c81206fd9deb46d68540dd167f98b79b3
Author: Brian Osman <brianosman@google.com>
Date: Fri Aug 11 11:54:45 2023

Split out memset opts into separate cpp files

These used to be in SkUtils_opts. I also renamed everything so that
they're declared in SkMemset.h, and defined in SkMemset_opts.h.

Bug:

b/40045064

Bug:

b/40045066

Change-Id: Idefa5b8d5f59595ddce907742f50e02174e42964
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/740638
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>

M bench/MemsetBench.cpp
M gn/core.gni
M public.bzl
M src/codec/SkPngCodec.cpp
M src/codec/SkSampler.cpp
M src/core/BUILD.bazel
M src/core/SkAlphaRuns.cpp
M src/core/SkBitmapProcState.cpp
M src/core/SkBitmapProcState_matrixProcs.cpp
M src/core/SkBlitRow_D32.cpp
M src/core/SkBlitter.cpp
M src/core/SkBlitter_ARGB32.cpp
M src/core/SkDevice.cpp
M src/core/SkGraphics.cpp
A src/core/SkMemset.h
A src/core/SkMemset_opts.cpp
A src/core/SkMemset_opts_avx.cpp
A src/core/SkMemset_opts_erms.cpp
M src/core/SkOpts.cpp
M src/core/SkOpts.h
D src/core/SkOpts_erms.cpp
M src/core/SkPixmap.cpp
M src/core/SkRasterPipelineBlitter.cpp
M src/core/SkVertices.cpp
M src/gpu/ganesh/GrDrawOpAtlas.cpp
M src/gpu/ganesh/GrResourceCache.cpp
M src/gpu/ganesh/vk/GrVkPipelineStateCache.cpp
M src/gpu/graphite/DrawAtlas.cpp
M src/opts/BUILD.bazel
M src/opts/SkMemset_opts.h
M src/opts/SkOpts_avx.cpp
M src/pdf/SkPDFGraphicState.h
M src/ports/SkScalerContext_mac_ct.cpp
M tests/ApplyGammaTest.cpp
M tests/BitmapCopyTest.cpp
M tests/CachedDecodingPixelRefTest.cpp
M tests/CopySurfaceTest.cpp
M tests/ImageTest.cpp
M tests/MemsetTest.cpp
M tests/RasterPipelineBuilderTest.cpp
M tools/fiddle/fiddle_main.cpp

https://skia-review.googlesource.com/740638

ap...@google.com <ap...@google.com> #158Aug 15, 2023 10:39AM

Project: skia
Branch: main

commit 022415d74e73de8e4a496ed047ac6b361a44a7f9
Author: Leon Scroggins III <scroggo@google.com>
Date: Mon Aug 14 09:48:06 2023

Fix typo in EncodeAnimated for NDK

Bug: 40045064
Change-Id: I2eed07d3db88160fd6f4749fb3ea00841a5b2836
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/741516
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>

M src/ports/SkImageEncoder_NDK.cpp

https://skia-review.googlesource.com/741516

ap...@google.com <ap...@google.com> #159Aug 30, 2023 12:28AM

Project: skia
Branch: main

commit 625f61e96c8e99a625d3aacc7f24a1d0d8e72b4b
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Aug 29 10:26:26 2023

Move SkOpts things around for easier modularization

It's a bit awkward to have a src/core depend on src/codec,
so the swizzles that are needed in core are now defined in
src/SkSwizzlePriv.h.

Additionally, it's a bit awkward to have many of the SkOpts
implementations actually depend on SkOpts due to the indirect
#include of SkRasterPipelineOpList.h, so I split out the
defines that are necessary into their own file.

Change-Id: Iba4efdd756996b234fb6dfa593e0e1ff444d6f20
Bug:

b/284138320

b/40045064

Reviewed-on: https://skia-review.googlesource.com/c/skia/+/748876
Reviewed-by: Brian Osman <brianosman@google.com>

M .bazelrc
M bench/SwizzleBench.cpp
M dm/DMSrcSink.cpp
M gn/core.gni
M public.bzl
M src/codec/SkJpegxlCodec.cpp
M src/codec/SkPngCodec.cpp
M src/codec/SkSwizzler.cpp
M src/codec/SkSwizzler.h
M src/core/BUILD.bazel
M src/core/SkBitmapProcState_opts.cpp
M src/core/SkBitmapProcState_opts_hsw.cpp
M src/core/SkBitmapProcState_opts_ssse3.cpp
M src/core/SkBlitMask_opts.cpp
M src/core/SkBlitMask_opts_ssse3.cpp
M src/core/SkBlitRow_opts.cpp
M src/core/SkBlitRow_opts_hsw.cpp
M src/core/SkConvertPixels.cpp
M src/core/SkGraphics.cpp
M src/core/SkMemset_opts.cpp
M src/core/SkMemset_opts_avx.cpp
M src/core/SkOpts.h
A src/core/SkOptsTargets.h
M src/core/SkSwizzle.cpp
M src/core/SkSwizzlePriv.h
M src/core/SkSwizzler_opts.cpp
M src/core/SkSwizzler_opts_hsw.cpp
M src/core/SkSwizzler_opts_ssse3.cpp
M src/gpu/AtlasTypes.cpp
M tests/SwizzlerTest.cpp

https://skia-review.googlesource.com/748876

ap...@google.com <ap...@google.com> #160Aug 30, 2023 01:41AM

Project: skia
Branch: main

commit e51a4e742e2889674b18c02174852b1792efa619
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Aug 29 10:31:26 2023

Enforce IWYU on SkResourceCache etc

Makes the modularization easier.

Change-Id: Ie85d6fd7c2298947a16e3502d5f28578903b6314
Bug:

b/40045064

b/284138320

Reviewed-on: https://skia-review.googlesource.com/c/skia/+/748877
Reviewed-by: Ben Wagner <bungeman@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>

M include/core/SkRegion.h
M src/core/SkRegion.cpp
M src/core/SkRegion_path.cpp
M src/core/SkResourceCache.cpp
M src/core/SkResourceCache.h
M toolchain/linux_trampolines/clang_trampoline_linux.sh

https://skia-review.googlesource.com/748877

ap...@google.com <ap...@google.com> #161Aug 31, 2023 11:42PM

Project: skia
Branch: main

commit a13a9d6efbbc35a4d4f645c162be4af8dfed081d
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Aug 30 16:11:55 2023

Misc IWYU cleanups

This removes SkFuzzLogging.h which had appeared unused as well
as SkAutoTime which also appeared unused.

I would like to remove SkTime.h from the public API in a future
change.

Change-Id: Iaea43df7f22581c19ae3b36793cb82b6e1ed6e63
Bug:

b/40045064

Reviewed-on: https://skia-review.googlesource.com/c/skia/+/749656
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

M include/core/SkGraphics.h
M include/core/SkImageFilter.h
M include/core/SkTime.h
M include/core/SkTypeface.h
M src/core/SkGraphics.cpp
M src/core/SkImageFilter.cpp
M src/core/SkTime.cpp
M src/core/SkTypeface.cpp
M toolchain/linux_trampolines/IWYU_mapping.imp
M toolchain/linux_trampolines/clang_trampoline_linux.sh

https://skia-review.googlesource.com/749656

ap...@google.com <ap...@google.com> #162Sep 8, 2023 11:13PM

Project: chromium/src
Branch: main

commit becc92d6485af6b0b483a7bae262b4326f39a2ea
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Sep 08 13:12:35 2023

Set SkSerialProcs for explicit image encoding

Skia plans to stop the default behavior of encoding SkImages in
SkPictures using a PNG encoder. To preserve that behavior,
clients need to explicitly set an SkSerialProc to do so.

I assume that picture_debug_util.cc and gpu_benchmarking_extension.cc
both have SkPictures which could contain SkImages. I can tell by
inspection serial_utils_unittest.cc does not, but figured we could
make the use of the default behavior explicit.

Bug:

b/40045064

Change-Id: I54b0fb960eec688359e11cb27948f00ce9463f56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845659
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1194054}

M cc/debug/BUILD.gn
M cc/debug/picture_debug_util.cc
M components/paint_preview/common/serial_utils_unittest.cc
M content/renderer/gpu_benchmarking_extension.cc

https://chromium-review.googlesource.com/4845659

ap...@google.com <ap...@google.com> #163Sep 12, 2023 10:38PM

Project: skia
Branch: main

commit 55c9c377f0b028c4966481d7e437536eeca8a734
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Sep 11 17:23:42 2023

Make SKP deserialize null instead of PNG images by default.

Client CLs:
- http://cl/563413765
- https://pdfium-review.googlesource.com/c/pdfium/+/111650
- https://github.com/flutter/engine/pull/45511
- https://crrev.com/c/4833521
- http://ag/24692530
Change-Id: I9fa03445e3cd41b1692e2d5a1aae3c7ff7e72e45
Bug:

b/40045064

Reviewed-on: https://skia-review.googlesource.com/c/skia/+/752378
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

M dm/DMSrcSink.cpp
D docs/examples/Picture_008.cpp
M docs/examples/Picture_MakeFromData.cpp
M docs/examples/Picture_MakeFromStream.cpp
M docs/examples/Picture_serialize.cpp
M docs/examples/Picture_serialize_2.cpp
M fuzz/FuzzCanvas.cpp
M gm/3d.cpp
M gm/image.cpp
M include/core/SkPicture.h
M modules/skottie/src/SkottieTool.cpp
A relnotes/skpicture_png.md
M src/core/SkGlyph.cpp
M src/core/SkPicture.cpp
M src/core/SkWriteBuffer.cpp
M src/core/SkWriteBuffer.h
M tests/ImageFilterTest.cpp
M tests/PictureTest.cpp
M tests/SerializationTest.cpp
M tools/dump_record.cpp
M tools/fiddle/all_examples.cpp
M tools/viewer/Viewer.cpp

https://skia-review.googlesource.com/752378

ap...@google.com <ap...@google.com> #164Sep 13, 2023 06:02AM

Project: skia
Branch: main

commit 2d295711337cf6fcbf66dfc90af39d4188999108
Author: Ben Wagner <bungeman@google.com>
Date: Tue Sep 12 19:56:37 2023

Revert "Make SKP deserialize null instead of PNG images by default."

This reverts commit 55c9c377f0b028c4966481d7e437536eeca8a734.

Reason for revert: Test-Mac12-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-Slug
Slug serialization and deserialization in Chrome need to be updated.

Original change's description:
> Make SKP deserialize null instead of PNG images by default.
>
> Client CLs:
> - http://cl/563413765
> - https://pdfium-review.googlesource.com/c/pdfium/+/111650
> - https://github.com/flutter/engine/pull/45511
> - https://crrev.com/c/4833521
> - http://ag/24692530
> Change-Id: I9fa03445e3cd41b1692e2d5a1aae3c7ff7e72e45
> Bug:

b/40045064

> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/752378
> Commit-Queue: Kevin Lubick <kjlubick@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

Bug:

b/40045064

Change-Id: I409cecaf333938a61493ab412cf7cb365c267505
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/755036
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: Ben Wagner <bungeman@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Brian Osman <brianosman@google.com>

M dm/DMSrcSink.cpp
A docs/examples/Picture_008.cpp
M docs/examples/Picture_MakeFromData.cpp
M docs/examples/Picture_MakeFromStream.cpp
M docs/examples/Picture_serialize.cpp
M docs/examples/Picture_serialize_2.cpp
M fuzz/FuzzCanvas.cpp
M gm/3d.cpp
M gm/image.cpp
M include/core/SkPicture.h
M modules/skottie/src/SkottieTool.cpp
D relnotes/skpicture_png.md
M src/core/SkGlyph.cpp
M src/core/SkPicture.cpp
M src/core/SkWriteBuffer.cpp
M src/core/SkWriteBuffer.h
M tests/ImageFilterTest.cpp
M tests/PictureTest.cpp
M tests/SerializationTest.cpp
M tools/dump_record.cpp
M tools/fiddle/all_examples.cpp
M tools/viewer/Viewer.cpp

https://skia-review.googlesource.com/755036

ap...@google.com <ap...@google.com> #165Sep 15, 2023 08:20AM

Project: skia
Branch: main

commit 37ea783440eafda23fa9ccadefe9235cd6c456fa
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Sep 14 14:53:18 2023

Remove some unused path effects

SkMergePathEffect, SkMatrixPathEffect, SkStrokePathEffect, and
SkStrokeAndFillPathEffect are removed.

These appear unused by our major clients and would be adding
complexity to the modular build effort.

Change-Id: Idfe1a420424cd63df86061c55e01a94a62b2d9bf
Bug:

b/40045064

Reviewed-on: https://skia-review.googlesource.com/c/skia/+/755996
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

M gm/circulararcs.cpp
M gm/patheffects.cpp
M gm/strokefill.cpp
M gm/typeface.cpp
M gn/effects.gni
M include/effects/BUILD.bazel
D include/effects/SkOpPathEffect.h
D include/effects/SkStrokeAndFillPathEffect.h
M public.bzl
A relnotes/patheffects.md
M src/effects/BUILD.bazel
D src/effects/SkOpPE.h
D src/effects/SkOpPathEffect.cpp
M src/ports/SkGlobalInitialization_default.cpp
M tools/viewer/PatchSlide.cpp

https://skia-review.googlesource.com/755996

ap...@google.com <ap...@google.com> #166Sep 16, 2023 02:32AM

Project: skia
Branch: main

commit a2d4f1efa87dbe184daefd7cc84f14b2a9879348
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Sep 15 11:21:18 2023

Add SkSerialProcs and SkDeserialProcs to Slug serialization

The shadertext3 gm started asserting when run in the glserializeslug
config after [1] landed. This was because the gm draws text with a
paint that has an image shader in it. During serialization, the
shader tried to serialize the (raster) SkImage and failed because
the default behavior of "use the PNG codec" was removed in [1].

This pipes in a way for the SkTestCanvas to supply that png codec
behavior for both serialization and deserialization (even though
it is a bit more ergonomic to simply register the decoder and
rely on the default behavior in practice).

This also makes SkSerialProcs required for SkWriteBuffer and
SkBinaryWriteBuffer since the default behavior for images is
nothing and should be specified if SkImages are being serialized.

[1] https://skia-review.googlesource.com/c/skia/+/752378

Bug:

b/40045064

Change-Id: I26d3e069d4512d110afd25261ff0b07f2046aecd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/754856
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>

M gm/image.cpp
M include/private/chromium/SkChromeRemoteGlyphCache.h
M include/private/chromium/Slug.h
M src/core/SkFlattenable.cpp
M src/core/SkPicture.cpp
M src/core/SkPictureData.cpp
M src/core/SkScalerContext.cpp
M src/core/SkTextBlob.cpp
M src/core/SkTextBlobTrace.cpp
M src/core/SkWriteBuffer.cpp
M src/core/SkWriteBuffer.h
M src/gpu/ganesh/GrPersistentCacheUtils.cpp
M src/gpu/ganesh/gl/builders/GrGLProgramBuilder.cpp
M src/gpu/ganesh/mtl/GrMtlPipelineStateBuilder.mm
M src/text/gpu/SkChromeRemoteGlyphCache.cpp
M src/text/gpu/Slug.cpp
M src/utils/SkTestCanvas.cpp
M tests/ColorFilterTest.cpp
M tests/DescriptorTest.cpp
M tests/FlattenDrawableTest.cpp
M tests/FontTest.cpp
M tests/GrGlyphVectorTest.cpp
M tests/PaintTest.cpp
M tests/PathTest.cpp
M tests/SerializationTest.cpp
M tests/SkFontMetricsPrivTest.cpp
M tests/SkGlyphTest.cpp
M tests/SkRemoteGlyphCacheTest.cpp
M tests/SkStrikeTest.cpp
M tests/StrikeForGPUTest.cpp
M tests/VerticesTest.cpp
M tools/debugger/DrawCommand.cpp
M tools/debugger/JsonWriteBuffer.h

https://skia-review.googlesource.com/754856

ap...@google.com <ap...@google.com> #167Sep 19, 2023 04:15AM

Project: skia
Branch: main

commit a8d0102a90b46d144919cb89c2f0a1305c1989fc
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Sep 18 11:33:07 2023

Remove TextBlob's empty mailbox in favor of delegate

The empty mailbox is a bit awkward with a buffet build because
the client would have to select the "empty" implementation
or incur link errors from SkTextBlob.cpp

This has the gpu backend register a callback function to be
invoked when the textblob is being destroyed.

Change-Id: I90ce506961a5ced41f68c5519977228268b836f7
Bug:

b/40045064

Reviewed-on: https://skia-review.googlesource.com/c/skia/+/755597
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

M bazel/exporter_tool/main.go
M gn/core.gni
M include/core/SkTextBlob.h
M public.bzl
M src/BUILD.bazel
M src/core/SkTextBlob.cpp
M src/text/BUILD.bazel
D src/text/EmptyMailboxImpl.cpp
M src/text/GlyphRun.cpp
M src/text/GlyphRun.h
D src/text/TextBlobMailbox.h
M src/text/gpu/TextBlobRedrawCoordinator.cpp

https://skia-review.googlesource.com/755597

ap...@google.com <ap...@google.com> #168Sep 20, 2023 12:37AM

Project: skia
Branch: main

commit 7e4d9768657c9cc730b24507dd705580e0f2fdf5
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Sep 19 09:54:10 2023

Add way to get GrDirectContext from Ganesh-backed image

This will help us more cautiously roll out https://crrev.com/c/4864397

Bug:

b/40045064

Change-Id: I772535ec638920ddcb792cb2875f9d48ec9dd2b5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/757496
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

M include/private/chromium/SkImageChromium.h
M src/gpu/ganesh/image/SkImage_GaneshBase.cpp

https://skia-review.googlesource.com/757496

ap...@google.com <ap...@google.com> #169Sep 21, 2023 03:46AM

Project: chromium/src
Branch: main

commit be4a28535f13c9a099d2a915e6f8ff1eea864296
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Sep 20 17:44:42 2023

Add SkSerialProcs for slugs

This is a follow-up to https://crrev.com/c/4845659 and
a precursor to https://skia-review.googlesource.com/c/skia/+/755548
where Skia will stop automatically serializing SkImages -> PNG
for SkPictures.

Slugs do not (AFAICT) currently have glyphs which are backed
by SkDrawables which have SkImages, but they do have SkPaints,
which can have SkImages in them (e.g. SkImageShader).

Bug:

b/40045064

Change-Id: I1f26bbb31dad7d155cabd7e416abf07a1e5fc3ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4864397
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1199106}

M cc/paint/paint_op_reader.cc
M cc/paint/paint_op_writer.cc

https://chromium-review.googlesource.com/4864397

ap...@google.com <ap...@google.com> #170Sep 23, 2023 03:45AM

Project: skia
Branch: main

commit 7de94b89ddbc03885c85612e0f37ec77bc30f4d2
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Sep 22 11:14:34 2023

Extract SkImageGenerator::MakeFromEncoded into own file

This will hopefully make it easier to bring in the implementation of
this only when one or more code is registered instead of explicitly
needing to bring a file when there are no codecs installed.

Change-Id: I725f589dd615dbd3520751edc23056908782c251
Bug:

b/40045064

Reviewed-on: https://skia-review.googlesource.com/c/skia/+/759457
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

M BUILD.gn
M gn/codec.gni
M public.bzl
M src/codec/BUILD.bazel
A src/codec/SkImageGenerator_FromEncoded.cpp
M src/core/SkImageGenerator.cpp
M src/image/SkImageGeneratorPriv.h
M src/ports/BUILD.bazel
M src/ports/SkImageGenerator_none.cpp
M src/ports/SkImageGenerator_skia.cpp

https://skia-review.googlesource.com/759457

ap...@google.com <ap...@google.com> #171Sep 26, 2023 01:25AM

Project: skia
Branch: main

commit c3bac5ba5017d9f3e80547b54426a7bf93388028
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Sep 25 08:43:57 2023

Reland "Make SKP deserialize null instead of PNG images by default."

This make SKP deserialize null instead of PNG images by default,
with a SK_DISABLE_LEGACY_PNG_WRITEBUFFER guard to preserve the
previous behavior.

The reason we need to do this is allow SkPictures to be serialized
or deserialized without a dependency on codecs, to allow the build
to be more modular and not have subtle dependencies.

Clients will need to update places where they serialize SkPictures
(or MultiPictureDocuments) to expressly include an SkSerialProc
(and SkDeserialProc) for images if encoding is desired. Some changes
are listed below:
- http://cl/563413765
- https://pdfium-review.googlesource.com/c/pdfium/+/111650
- https://github.com/flutter/engine/pull/45511
- https://crrev.com/c/4845659
- http://ag/24692530

Original change's description:
> Reland "Revert "Make SKP deserialize null instead of PNG images by default.""
>
> This reverts commit b78c91996051d250b6a2946a7b6f14719e014d57.
>
> Reason for revert: Possible cause of https://crbug.com/1485891
>
> Original change's description:
> > Revert "Revert "Make SKP deserialize null instead of PNG images by default.""
> >
> > This reverts commit 2d295711337cf6fcbf66dfc90af39d4188999108.
> >
> > Change-Id: I158484509c1d067cbebdc99f97e42ff734fa855a
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/755548
> > Reviewed-by: Brian Osman <brianosman@google.com>
> > Commit-Queue: Kevin Lubick <kjlubick@google.com>
>
> Change-Id: Ifb716927460a8ab6a03dafc168d1eb1eb230fea7
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/759268
> Owners-Override: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Kevin Lubick <kjlubick@google.com>
> Auto-Submit: Kevin Lubick <kjlubick@google.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Change-Id: Ia93eff9b5ff42fabdd6abae69ba997ddd7c9b1c7
Bug:

b/40045064

, chromium:1485891
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/759936
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

M dm/DMSrcSink.cpp
D docs/examples/Picture_008.cpp
M docs/examples/Picture_MakeFromData.cpp
M docs/examples/Picture_MakeFromStream.cpp
M docs/examples/Picture_serialize.cpp
M docs/examples/Picture_serialize_2.cpp
M fuzz/FuzzCanvas.cpp
M gm/3d.cpp
M include/core/SkPicture.h
M modules/skottie/src/SkottieTool.cpp
A relnotes/skpicture_png.md
M src/core/SkGlyph.cpp
M src/core/SkPicture.cpp
M src/core/SkWriteBuffer.cpp
M src/core/SkWriteBuffer.h
M tests/ImageFilterTest.cpp
M tests/PictureTest.cpp
M tests/SerializationTest.cpp
M tools/dump_record.cpp
M tools/fiddle/all_examples.cpp
M tools/viewer/Viewer.cpp

https://skia-review.googlesource.com/759936

ap...@google.com <ap...@google.com> #172Oct 3, 2023 05:54AM

Project: chromium/src
Branch: main

commit 09b321368cc2a74ba32c1a2135322b91cc148516
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Oct 02 18:52:25 2023

Disable legacy SkWriteBuffer behavior w/r to png encoding

Bug:

b/40045064

Change-Id: I216e156b7cdb2b81623b212c1ea54f8b8f8798d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4902280
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204173}

M skia/BUILD.gn

https://chromium-review.googlesource.com/4902280

ap...@google.com <ap...@google.com> #173Oct 6, 2023 04:36AM

Project: skia
Branch: main

commit 0c81587d7ddec88f1fedcd56b45bfd5981ec71f6
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Oct 05 11:20:54 2023

Make SkReadBuffer *not* call SkImages::DeferredFromEncodedData by default

This previous behavior resulted in an implicit dependency between core
and codecs. This CL removes that dep.

If someone wants to call SkImages::DeferredFromEncodedData,
this will now be a link error unless at least one codec is built in.

Change-Id: Ib649b8efdf74872791b38b4a2f021380acd430e3
Bug:

b/40045064

Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761881
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>

M include/core/SkSerialProcs.h
A relnotes/readbuffer-deserial.md
M src/codec/SkImageGenerator_FromEncoded.cpp
M src/core/BUILD.bazel
M src/core/SkReadBuffer.cpp
M src/image/SkImage_LazyFactories.cpp

https://skia-review.googlesource.com/761881

ap...@google.com <ap...@google.com> #174Oct 6, 2023 07:42AM

Project: skia
Branch: main

commit be579dcde23b33c286fdf602fc38fc3ce99e21dc
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Oct 05 11:11:20 2023

Enforce IWYU on ToolUtils.h

I plan to split this up to avoid #ifdefs in a follow-on CL

Bug:

b/40045064

Change-Id: I84c918a9407faeb642d3b6c86cf1fe1105fa2e52
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/762402
Reviewed-by: Ben Wagner <bungeman@google.com>

M dm/DM.cpp
M gm/drawatlas.cpp
M gm/imagefilterstransformed.cpp
M gm/imagemakewithfilter.cpp
M gm/palette.cpp
M gm/stroketext.cpp
M modules/skottie/tests/Text.cpp
M src/gpu/graphite/DrawAtlas.cpp
M tests/graphite/RecordingOrderTest.cpp
M toolchain/linux_trampolines/clang_trampoline_linux.sh
M tools/ToolUtils.cpp
M tools/ToolUtils.h
M tools/fonts/ToolUtilsFont.cpp
M tools/viewer/FatBitsSlide.cpp
M tools/viewer/GlyphTransformSlide.cpp

https://skia-review.googlesource.com/762402

ap...@google.com <ap...@google.com> #175Oct 6, 2023 07:42AM

Project: skia
Branch: main

commit 9b028376f9166aa35a7cf113a70d2fa64eec152c
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Oct 05 15:04:54 2023

Split ToolUtils into a few files for easier modularization

The plan is to have a "test_base" module which all tests depend on,
and then some other test modules that "tests who need pathops"
or "tests that need a gpu" will depend on.

test_base:
deps [core_skia, base_skia]
srcs [ToolUtils.h/cpp, ...

test_ganesh_gl
deps [test_base, ganesh_gl, core_skia, ...]
srcs [GpuToolUtils.h/.cpp, ...]

In theory, we could keep tool utils the way it is, and just
change the deps, but that would involve some duplication of
the test harnesses and I think will be a bit less neat.

Bug:

b/40045064

Change-Id: Ic4bce9df859d3f831c879cf17ac1608bc6612355
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/762976
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

M BUILD.gn
M bench/graphite/BoundsManagerBench.cpp
M bench/graphite/IntersectionTreeBench.cpp
M bench/nanobench.cpp
M dm/DMSrcSink.cpp
M gm/bitmaprect.cpp
M gm/colorwheel.cpp
M gm/composeshader.cpp
M gm/crop_imagefilter.cpp
M gm/croppedrects.cpp
M gm/draw_bitmap_rect_skbug4374.cpp
M gm/drawbitmaprect.cpp
M gm/drawimageset.cpp
M gm/drawminibitmaprect.cpp
M gm/graphite_replay.cpp
M gm/graphitestart.cpp
M gm/image.cpp
M gm/imagemakewithfilter.cpp
M gm/imagemasksubset.cpp
M gm/localmatrixshader.cpp
M gm/orientation.cpp
M gm/perspimages.cpp
M gm/tallstretchedbitmaps.cpp
M gm/tilemodes.cpp
M src/gpu/ganesh/image/GrImageUtils.h
M tests/BigImageTest.cpp
M tests/FilterResultTest.cpp
M tests/ImageFilterTest.cpp
M tests/NdkDecodeTest.cpp
M tests/NdkEncodeTest.cpp
M tests/ProcessorTest.cpp
M tests/ShaderImageFilterTest.cpp
M tests/TestUtils.cpp
M tests/TestUtils.h
M tests/graphite/CacheKeyTest.cpp
M tests/graphite/ImageProviderTest.cpp
M tests/graphite/ImageShaderTest.cpp
M toolchain/linux_trampolines/clang_trampoline_linux.sh
M tools/BUILD.bazel
A tools/EncodeUtils.cpp
A tools/EncodeUtils.h
A tools/GpuToolUtils.cpp
A tools/GpuToolUtils.h
A tools/SvgPathExtractor.cpp
A tools/SvgPathExtractor.h
M tools/ToolUtils.cpp
M tools/ToolUtils.h
M tools/skdiff/skdiff_utils.cpp
M tools/skpbench/skpbench.cpp
M tools/viewer/BisectSlide.cpp
M tools/viewer/SlidesSlide.cpp
M tools/window/GraphiteDawnWindowContext.cpp
M tools/window/GraphiteMetalWindowContext.mm
M tools/window/GraphiteVulkanWindowContext.cpp

https://skia-review.googlesource.com/762976

ap...@google.com <ap...@google.com> #176Oct 7, 2023 04:57AM

Project: skia
Branch: main

commit 8b741889ed193b6f9ee0c1a41d1c0f45c7e8d5cd
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Oct 06 11:41:38 2023

Split codec-related parts out of tools/Resources.h

This will make tests easier to modularize since only a few
unit tests actually need to decode an image to work.

Change-Id: I1ded07f22b4bcbf356a36f7b3b4fd56d21c828cf
Bug:

b/40045064

Reviewed-on: https://skia-review.googlesource.com/c/skia/+/763560
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

M BUILD.gn
M bench/BlendmodeBench.cpp
M bench/ColorFilterBench.cpp
M bench/DecodeBench.cpp
M bench/EncodeBench.cpp
M bench/FilteringBench.cpp
M bench/ImageFilterDAGBench.cpp
M bench/PDFBench.cpp
M bench/ParagraphBench.cpp
M bench/VertBench.cpp
M docs/examples/Canvas_saveLayer_3.cpp
M gm/all_bitmap_configs.cpp
M gm/alpha_image.cpp
M gm/animated_image_orientation.cpp
M gm/asyncrescaleandread.cpp
M gm/bigtext.cpp
M gm/bitmapimage.cpp
M gm/blurimagevmask.cpp
M gm/blurs.cpp
M gm/colorfilterimagefilter.cpp
M gm/colorfilters.cpp
M gm/colorspace.cpp
M gm/colorwheel.cpp
M gm/complexclip.cpp
M gm/compositor_quads.cpp
M gm/coordclampshader.cpp
M gm/copy_to_4444.cpp
M gm/destcolor.cpp
M gm/draw_bitmap_rect_skbug4374.cpp
M gm/drawatlas.cpp
M gm/ducky_yuv_blend.cpp
M gm/encode.cpp
M gm/encode_alpha_jpeg.cpp
M gm/encode_color_types.cpp
M gm/encode_platform.cpp
M gm/filterindiabox.cpp
M gm/fontations_ft_compare.cpp
M gm/fpcoordinateoverride.cpp
M gm/graphite_replay.cpp
M gm/graphitestart.cpp
M gm/grayscalejpg.cpp
M gm/hsl.cpp
M gm/imagefilters.cpp
M gm/imagefilterstransformed.cpp
M gm/imagefromyuvtextures.cpp
M gm/imagemakewithfilter.cpp
M gm/kawase_blur_rt.cpp
M gm/localmatriximageshader.cpp
M gm/localmatrixshader.cpp
M gm/lumafilter.cpp
M gm/make_raster_image.cpp
M gm/makecolorspace.cpp
M gm/mesh.cpp
M gm/orientation.cpp
M gm/patch.cpp
M gm/perspimages.cpp
M gm/perspshaders.cpp
M gm/repeated_bitmap.cpp
M gm/rippleshadergm.cpp
M gm/runtimecolorfilter.cpp
M gm/runtimeimagefilter.cpp
M gm/runtimeshader.cpp
M gm/savelayer.cpp
M gm/showmiplevels.cpp
M gm/skbug_8664.cpp
M gm/srgb.cpp
M gm/subsetshader.cpp
M gm/swizzle.cpp
M gm/texelsubset.cpp
M gm/tilemodes.cpp
M gm/tilemodes_alpha.cpp
M gm/vertices.cpp
M gm/wacky_yuv_formats.cpp
M gm/yuv420_odd_dim.cpp
M tests/CodecTest.cpp
M tests/EncodeTest.cpp
M tests/ImageIsOpaqueTest.cpp
M tests/ImageNewShaderTest.cpp
M tests/ImageTest.cpp
M tests/JpegGainmapTest.cpp
M tests/MipMapTest.cpp
M tests/NdkDecodeTest.cpp
M tests/NdkEncodeTest.cpp
M tests/SamplingTest.cpp
M tests/SerialProcsTest.cpp
M tests/Skbug6389.cpp
M tests/TextureStripAtlasManagerTest.cpp
M tests/graphite/ProxyCacheTest.cpp
M third_party/vulkanmemoryallocator/GrVulkanMemoryAllocator.cpp
M toolchain/linux_trampolines/clang_trampoline_linux.sh
M tools/BUILD.bazel
D tools/DecodeFile.h
A tools/DecodeUtils.cpp
A tools/DecodeUtils.h
M tools/Resources.cpp
M tools/Resources.h
M tools/viewer/3DSlide.cpp
M tools/viewer/CameraSlide.cpp
M tools/viewer/ClipSlide.cpp
M tools/viewer/LayersSlide.cpp
M tools/viewer/MeshSlide.cpp
M tools/viewer/MixerSlide.cpp
M tools/viewer/PatchSlide.cpp
M tools/viewer/ShadowReferenceSlide.cpp
M tools/viewer/ShipSlide.cpp
M tools/viewer/SkSLSlide.cpp
M tools/viewer/SlidesSlide.cpp
M tools/viewer/Viewer.cpp
M tools/viewer/XferSlide.cpp

https://skia-review.googlesource.com/763560

ap...@google.com <ap...@google.com> #177Oct 9, 2023 11:34PM

Project: skia
Branch: main

commit b136cffed41c890fac71772751c0caae73f22e82
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Oct 06 11:56:48 2023

Remove tests based on flag-based Bazel rules

It will be easier to make use of the buffet build modules if
we don't have similar-sounding names in the way.

Change-Id: I58d04f52cf8f49fd41a56eef6129e6b605cce394
Bug:

b/40045064

Reviewed-on: https://skia-review.googlesource.com/c/skia/+/763561
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>

M .bazelrc
M bazel/buildrc
M infra/bots/jobs.json
M infra/bots/tasks.json
M tests/BUILD.bazel
M tests/testgroups.bzl
M tests/tests.bzl

https://skia-review.googlesource.com/763561

ap...@google.com <ap...@google.com> #178Oct 9, 2023 11:34PM

Project: skia
Branch: main

commit c5541e2bd2131c1f87ab7f765d3219e8513e71e2
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Oct 09 08:19:28 2023

Make tests which depend on modular Bazel build

Future CLs will add more skia_cc_libraries to tests/BUILD.bazel
and make use of all the various groups defined in testgroups.bzl.

Change-Id: If76fb53bebab8e3f6a38c2120e5dec0c07e7dc4e
Bug:

b/40045064

Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761862
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>

M include/utils/BUILD.bazel
M infra/bots/gen_tasks_logic/gen_tasks_logic.go
M infra/bots/jobs.json
M infra/bots/tasks.json
M resources/BUILD.bazel
M src/base/BUILD.bazel
M src/utils/BUILD.bazel
M tests/BUILD.bazel
M tests/testgroups.bzl
M tests/tests.bzl
M tools/BUILD.bazel
M tools/flags/BUILD.bazel
M tools/fonts/BUILD.bazel

https://skia-review.googlesource.com/761862

ap...@google.com <ap...@google.com> #179Oct 12, 2023 06:01AM

Project: chromium/src
Branch: main

commit f360efc64e740ebff326a9a51533cf7f13c50ea9
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Oct 11 18:58:21 2023

Register deserialization of Slugs in SkPicture

In https://skia-review.googlesource.com/c/skia/+/755550 we deprecated
the default behavior of SkPictures deserializing Slugs (currently
a gpu-only type) so serialization works without a subtle link to
a GPU backend.

This means clients who need to deserialize Slugs in SkPictures
need to register that behavior explicitly, using a provided
helper function.

The change does *not* impact directly serializing Slugs, only
in situations where an SkPicture would have a Slug inside it
(e.g. a call to drawSlug).

Bug: b:40045064
Change-Id: Icb9e9e520aa70b2b0b03512eb7cd0e0a976990ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4885951
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1208367}

M components/paint_preview/DEPS
M components/paint_preview/common/serial_utils.cc
M skia/BUILD.gn

https://chromium-review.googlesource.com/4885951

ap...@google.com <ap...@google.com> #180Oct 12, 2023 06:48AM

Project: skia
Branch: main

commit 1931535039ed26abd38ff321fe5b7edc0521b01c
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Oct 11 14:56:20 2023

Minor fixes for buffet build

Certain toolchains compile headers independently, and thus noticed some
missing #includes. This also removes the default_malloc_impl module,
as that gives linking errors in some environments because a symbol
is potentially missing depending on link order.

See also http://cl/572301023

Bug:

b/40045064

Bug:

b/237076898

Change-Id: Ia0a3f32bdab9bc92d09eddd3e5dc7c190cb5caf3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/765357
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>

M BUILD.bazel
M bazel/exporter_tool/main.go
M example/external_client/BUILD.bazel
M gn/core.gni
M include/core/BUILD.bazel
M include/private/BUILD.bazel
M src/core/BUILD.bazel
M src/core/SkBlitBWMaskTemplate.h
M src/core/SkTextFormatParams.h
M src/core/SkVerticesPriv.h
M src/opts/BUILD.bazel
M src/pathops/BUILD.bazel
M src/ports/BUILD.bazel
M src/sksl/analysis/SkSLNoOpErrorReporter.h
M src/sksl/ir/SkSLEmptyExpression.h
M src/sksl/ir/SkSLFunctionReference.h
M src/sksl/ir/SkSLMethodReference.h
M src/sksl/ir/SkSLPoison.h
M src/sksl/transform/SkSLTransform.h
M tests/BUILD.bazel

https://skia-review.googlesource.com/765357

Issue 40045064

Description

Issue summary

Mentioned issues (3)

Links (6950)

Comments

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #2Dec 13, 2022 02:13AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #3Dec 13, 2022 11:35PM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #4Dec 14, 2022 02:10AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #5Dec 14, 2022 07:24AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #6Dec 15, 2022 02:12AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #7Dec 16, 2022 01:05AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #8Dec 17, 2022 08:19AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #9Dec 21, 2022 04:25AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #10Jan 4, 2023 02:36AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #11Jan 4, 2023 03:17AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #12Jan 4, 2023 06:26AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #13Jan 4, 2023 06:26AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #14Jan 5, 2023 05:26AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #15Jan 5, 2023 08:05AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #16Jan 5, 2023 08:18AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #17Jan 6, 2023 12:19AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #18Jan 6, 2023 01:52AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #19Jan 6, 2023 07:27AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #20Jan 10, 2023 03:19AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #21Jan 10, 2023 03:41AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #22Jan 11, 2023 12:38AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #23Jan 11, 2023 06:17AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #24Jan 11, 2023 11:00AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #25Jan 12, 2023 01:46AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #26Jan 12, 2023 06:43AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #27Jan 13, 2023 12:12AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #28Jan 13, 2023 03:15AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #29Jan 13, 2023 05:57AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #30Jan 13, 2023 06:46AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #31Jan 14, 2023 01:36AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #32Jan 14, 2023 04:42AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #33Jan 18, 2023 07:23AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #34Jan 19, 2023 02:35AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #35Jan 19, 2023 05:05AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #36Jan 19, 2023 05:57AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #37Jan 20, 2023 09:53AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #38Jan 21, 2023 03:59AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #39Jan 21, 2023 08:01AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #40Jan 21, 2023 08:59AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #41Jan 22, 2023 01:34AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #42Jan 24, 2023 05:40AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #43Jan 26, 2023 02:38AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #44Jan 26, 2023 03:48AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #45Jan 26, 2023 06:23AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #46Jan 31, 2023 07:11AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #47Jan 31, 2023 07:11AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #48Feb 2, 2023 01:31AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #49Feb 2, 2023 02:58AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #50Feb 11, 2023 10:19AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #51Feb 14, 2023 01:58AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #52Feb 14, 2023 04:45AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #53Feb 16, 2023 02:24AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #54Feb 16, 2023 05:28AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #55Feb 17, 2023 01:20AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #56Feb 17, 2023 02:36AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #57Feb 17, 2023 06:11AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #58Feb 17, 2023 07:35AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #59Feb 17, 2023 07:41AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #60Feb 17, 2023 10:09AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #61Feb 17, 2023 11:28PM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #62Feb 18, 2023 12:10AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #63Feb 25, 2023 05:04AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #64Feb 28, 2023 02:26AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #65Feb 28, 2023 04:39AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #66Feb 28, 2023 05:23AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #67Mar 2, 2023 12:41AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #68Mar 3, 2023 11:13PM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #69Mar 14, 2023 02:00AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #70Mar 14, 2023 02:29AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #71Mar 15, 2023 04:34AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #72Mar 15, 2023 04:37AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #73Mar 16, 2023 04:18AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #74Mar 16, 2023 04:33AM

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #75Mar 16, 2023 06:09AM