In Progress
Status Update
This is a tracking bug for work to make the Skia build modular such that Bazel clients can easily pick and choose the parts of Skia they want *without* needing compile time flags.
Issue summary
Comments
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #2
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a
commit a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Dec 09 20:57:46 2022
Remove dependency of SkPaint -> SkPaintPriv
If we want SkPaint to be a part of "core", then we need
to trim down the .cpp file a bit. This moves all
SkPaintPriv:: implementations to SkPaintPriv.cpp
(Which were just Flatten and Unflatten).
ComputeResScaleForStroking seems to be more related to
Matrices and Paths than Paint, so I moved it to
SkMatrixPriv (and you'll see in a follow-up CL I'm attempting
the ambitious removal of getFillPath)
Change-Id: I14b3d6fb2c69bdeacee998c0d0bc436c59096300
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/616818
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Herb Derby <herb@google.com>
[modify] https://crrev.com/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a/src/core/SkMatrixPriv.h
[modify] https://crrev.com/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a/src/core/SkPaint.cpp
[modify] https://crrev.com/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a/src/core/SkPaintPriv.cpp
[modify] https://crrev.com/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a/src/core/SkMatrix.cpp
[modify] https://crrev.com/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a/bench/PathBench.cpp
[modify] https://crrev.com/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a/src/core/SkPaintPriv.h
https://skia.googlesource.com/skia/+/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a
commit a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Dec 09 20:57:46 2022
Remove dependency of SkPaint -> SkPaintPriv
If we want SkPaint to be a part of "core", then we need
to trim down the .cpp file a bit. This moves all
SkPaintPriv:: implementations to SkPaintPriv.cpp
(Which were just Flatten and Unflatten).
ComputeResScaleForStroking seems to be more related to
Matrices and Paths than Paint, so I moved it to
SkMatrixPriv (and you'll see in a follow-up CL I'm attempting
the ambitious removal of getFillPath)
Change-Id: I14b3d6fb2c69bdeacee998c0d0bc436c59096300
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/616818
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Herb Derby <herb@google.com>
[modify] https://crrev.com/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a/src/core/SkMatrixPriv.h
[modify] https://crrev.com/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a/src/core/SkPaint.cpp
[modify] https://crrev.com/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a/src/core/SkPaintPriv.cpp
[modify] https://crrev.com/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a/src/core/SkMatrix.cpp
[modify] https://crrev.com/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a/bench/PathBench.cpp
[modify] https://crrev.com/a73b0b5903ddf6117ece1a0cf2f4d0da8a3fcf5a/src/core/SkPaintPriv.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #3
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2
commit 177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Dec 12 15:25:15 2022
Move getFillPath from Paint to SkPathUtils.h
It is now named FillPathWithPaint. The behavior should be
unchanged.
The legacy call site is available with the define:
SK_LEGACY_GET_FILL_PATH
Client guards:
- http://cl/494768310
- https://crrev.com/c/4097825
- http://ag/20709885
Change-Id: If7e622b8b6392d0d19eab09ac6184a6f89f2cdb7
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/616821
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Herb Derby <herb@google.com>
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/gn/core.gni
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/bench/StrokeBench.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/gm/overstroke.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/src/core/SkDraw.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/gm/strokes.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/src/core/BUILD.bazel
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tools/fiddle/all_examples.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tests/DashPathEffectTest.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/include/core/SkPaint.h
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tests/DrawPathTest.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tests/BlurTest.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tools/viewer/PathOverstrokeSlide.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/gm/strokerect.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/src/core/SkPaint.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/docs/examples/strokerect_gm.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/modules/pathkit/pathkit_wasm_bindings.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/modules/sksg/src/SkSGGeometryEffect.cpp
[rename] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/docs/examples/FillPathWithPaint_2.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tests/PathTest.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/docs/examples/zero_off_dashing.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tools/viewer/QuadStrokerSlide.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tests/PaintTest.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tools/viewer/SimpleStrokerSlide.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/modules/canvaskit/canvaskit_bindings.cpp
[add] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/src/core/SkPathUtils.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tools/viewer/VariableWidthStrokerSlide.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tests/StrokerTest.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/docs/examples/convex_overstroke_linear_approx_curve.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tools/viewer/FatBitsSlide.cpp
[rename] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/docs/examples/FillPathWithPaint.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/gm/pathfill.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/docs/examples/convex_overstroke_quad.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/BUILD.gn
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tools/fonts/TestSVGTypeface.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/src/xps/SkXPSDevice.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/docs/examples/cubics_are_horrible.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/gm/fatpathfill.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tools/viewer/PathSlide.cpp
[add] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/include/core/SkPathUtils.h
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tests/StrokeTest.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/bench/PathBench.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/modules/sksg/src/SkSGDraw.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/include/core/BUILD.bazel
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/RELEASE_NOTES.txt
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/public.bzl
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/gm/bug12866.cpp
https://skia.googlesource.com/skia/+/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2
commit 177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Dec 12 15:25:15 2022
Move getFillPath from Paint to SkPathUtils.h
It is now named FillPathWithPaint. The behavior should be
unchanged.
The legacy call site is available with the define:
SK_LEGACY_GET_FILL_PATH
Client guards:
- http://cl/494768310
- https://crrev.com/c/4097825
- http://ag/20709885
Change-Id: If7e622b8b6392d0d19eab09ac6184a6f89f2cdb7
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/616821
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Herb Derby <herb@google.com>
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/gn/core.gni
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/bench/StrokeBench.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/gm/overstroke.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/src/core/SkDraw.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/gm/strokes.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/src/core/BUILD.bazel
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tools/fiddle/all_examples.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tests/DashPathEffectTest.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/include/core/SkPaint.h
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tests/DrawPathTest.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tests/BlurTest.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tools/viewer/PathOverstrokeSlide.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/gm/strokerect.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/src/core/SkPaint.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/docs/examples/strokerect_gm.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/modules/pathkit/pathkit_wasm_bindings.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/modules/sksg/src/SkSGGeometryEffect.cpp
[rename] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/docs/examples/FillPathWithPaint_2.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tests/PathTest.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/docs/examples/zero_off_dashing.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tools/viewer/QuadStrokerSlide.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tests/PaintTest.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tools/viewer/SimpleStrokerSlide.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/modules/canvaskit/canvaskit_bindings.cpp
[add] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/src/core/SkPathUtils.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tools/viewer/VariableWidthStrokerSlide.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tests/StrokerTest.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/docs/examples/convex_overstroke_linear_approx_curve.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tools/viewer/FatBitsSlide.cpp
[rename] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/docs/examples/FillPathWithPaint.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/gm/pathfill.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/docs/examples/convex_overstroke_quad.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/BUILD.gn
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tools/fonts/TestSVGTypeface.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/src/xps/SkXPSDevice.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/docs/examples/cubics_are_horrible.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/gm/fatpathfill.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tools/viewer/PathSlide.cpp
[add] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/include/core/SkPathUtils.h
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/tests/StrokeTest.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/bench/PathBench.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/modules/sksg/src/SkSGDraw.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/include/core/BUILD.bazel
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/RELEASE_NOTES.txt
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/public.bzl
[modify] https://crrev.com/177a712dcb1c5c89f2aa2ae7d813d8834cf35ec2/gm/bug12866.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #4
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/db70f2fd672f3964576c212ed7eddc6e6d542a9d
commit db70f2fd672f3964576c212ed7eddc6e6d542a9d
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Dec 13 12:44:43 2022
[includes] Enforce IWYU on SkPath related things
(SkPath itself already is IWYU-enforced)
This will hopefully make it a bit easier to set up a modular
build of Skia that can just export paths without too much
extra stuff.
Change-Id: I915120a3ef6ea7975b2ecc73ee10d269155c730a
Bug: skia:13052, skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/617638
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/include/core/SkPathBuilder.h
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/include/private/SkPathRef.h
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/src/BUILD.bazel
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/src/core/SkPathRef.cpp
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/src/core/SkPathBuilder.cpp
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/src/core/SkPathPriv.h
https://skia.googlesource.com/skia/+/db70f2fd672f3964576c212ed7eddc6e6d542a9d
commit db70f2fd672f3964576c212ed7eddc6e6d542a9d
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Dec 13 12:44:43 2022
[includes] Enforce IWYU on SkPath related things
(SkPath itself already is IWYU-enforced)
This will hopefully make it a bit easier to set up a modular
build of Skia that can just export paths without too much
extra stuff.
Change-Id: I915120a3ef6ea7975b2ecc73ee10d269155c730a
Bug: skia:13052, skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/617638
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/include/core/SkPathBuilder.h
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/include/private/SkPathRef.h
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/src/BUILD.bazel
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/src/core/SkPathRef.cpp
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/src/core/SkPathBuilder.cpp
[modify] https://crrev.com/db70f2fd672f3964576c212ed7eddc6e6d542a9d/src/core/SkPathPriv.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #5
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/537e1e8c1ca6988f30acab807ae5230462bf677a
commit 537e1e8c1ca6988f30acab807ae5230462bf677a
Author: Herb Derby <herb@google.com>
Date: Tue Dec 13 19:03:27 2022
Move sk_is_trivially_relocatable_* to its own file
Bug: skia:13983
Change-Id: Ic396d47a2c4b145fb838b81bca9a7134ae125f91
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/618437
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/gn/core.gni
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/include/private/gpu/ganesh/GrTypesPriv.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/src/codec/SkRawCodec.cpp
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/src/gpu/ganesh/ClipStack.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/modules/skshaper/src/SkShaper_harfbuzz.cpp
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/src/utils/SkCanvasStack.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/modules/skottie/src/text/SkottieShaper.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/src/gpu/ganesh/GrBufferAllocPool.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/include/private/SkTemplates.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/src/gpu/ganesh/GrSurfaceProxyView.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/include/private/BUILD.bazel
[add] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/include/private/SkTypeTraits.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/src/svg/SkSVGDevice.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/include/private/SkTArray.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/include/core/SkPaint.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/public.bzl
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/src/gpu/ganesh/ops/OpsTask.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/include/core/SkPath.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/src/gpu/ganesh/GrVertexChunkArray.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/include/core/SkRegion.h
https://skia.googlesource.com/skia/+/537e1e8c1ca6988f30acab807ae5230462bf677a
commit 537e1e8c1ca6988f30acab807ae5230462bf677a
Author: Herb Derby <herb@google.com>
Date: Tue Dec 13 19:03:27 2022
Move sk_is_trivially_relocatable_* to its own file
Bug: skia:13983
Change-Id: Ic396d47a2c4b145fb838b81bca9a7134ae125f91
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/618437
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/gn/core.gni
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/include/private/gpu/ganesh/GrTypesPriv.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/src/codec/SkRawCodec.cpp
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/src/gpu/ganesh/ClipStack.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/modules/skshaper/src/SkShaper_harfbuzz.cpp
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/src/utils/SkCanvasStack.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/modules/skottie/src/text/SkottieShaper.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/src/gpu/ganesh/GrBufferAllocPool.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/include/private/SkTemplates.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/src/gpu/ganesh/GrSurfaceProxyView.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/include/private/BUILD.bazel
[add] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/include/private/SkTypeTraits.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/src/svg/SkSVGDevice.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/include/private/SkTArray.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/include/core/SkPaint.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/public.bzl
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/src/gpu/ganesh/ops/OpsTask.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/include/core/SkPath.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/src/gpu/ganesh/GrVertexChunkArray.h
[modify] https://crrev.com/537e1e8c1ca6988f30acab807ae5230462bf677a/include/core/SkRegion.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #6
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/8e165b9cf288fd3d3fbe06cf2fc3032897312a5a
commit 8e165b9cf288fd3d3fbe06cf2fc3032897312a5a
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Dec 14 14:35:14 2022
Mark SkPathUtils functions as SK_API
Otherwise, the Chrome build breaks with a link error when
linking libcc_paint.so
Follow-up to https://skia-review.googlesource.com/c/skia/+/616821
Change-Id: I93c6e3b9713f11054c030cccdd0a48341e37a152
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/618817
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/8e165b9cf288fd3d3fbe06cf2fc3032897312a5a/include/core/SkPathUtils.h
https://skia.googlesource.com/skia/+/8e165b9cf288fd3d3fbe06cf2fc3032897312a5a
commit 8e165b9cf288fd3d3fbe06cf2fc3032897312a5a
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Dec 14 14:35:14 2022
Mark SkPathUtils functions as SK_API
Otherwise, the Chrome build breaks with a link error when
linking libcc_paint.so
Follow-up to https://skia-review.googlesource.com/c/skia/+/616821
Change-Id: I93c6e3b9713f11054c030cccdd0a48341e37a152
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/618817
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/8e165b9cf288fd3d3fbe06cf2fc3032897312a5a/include/core/SkPathUtils.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #7
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/f549128104babe451bacf60e5851dbf73b2940d6
commit f549128104babe451bacf60e5851dbf73b2940d6
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Dec 15 13:37:49 2022
Add skpathutils namespace
Follow-up to https://skia-review.googlesource.com/c/skia/+/616821
This keeps the global namespace symbols around until I can
update G3, Chrome, and PDFium (Android update hasn't landed yet).
Change-Id: I5c125e7064ab50d1b47176c74f09658dea223eec
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/619099
Reviewed-by: Leon Scroggins <scroggo@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/src/core/SkPathUtils.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/bench/StrokeBench.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/gm/overstroke.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/src/core/SkDraw.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/gm/strokes.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tests/StrokerTest.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/docs/examples/convex_overstroke_linear_approx_curve.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tools/viewer/FatBitsSlide.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tests/DashPathEffectTest.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/docs/examples/FillPathWithPaint.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/gm/pathfill.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/docs/examples/convex_overstroke_quad.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tools/fonts/TestSVGTypeface.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/src/xps/SkXPSDevice.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tests/DrawPathTest.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/gm/fatpathfill.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/docs/examples/cubics_are_horrible.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tools/viewer/PathSlide.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/include/core/SkPathUtils.h
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tests/BlurTest.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tools/viewer/PathOverstrokeSlide.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/src/core/SkPaint.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/gm/strokerect.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tests/StrokeTest.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/bench/PathBench.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/docs/examples/strokerect_gm.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/modules/sksg/src/SkSGDraw.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/modules/pathkit/pathkit_wasm_bindings.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/modules/sksg/src/SkSGGeometryEffect.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/docs/examples/FillPathWithPaint_2.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tests/PathTest.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/docs/examples/zero_off_dashing.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tools/viewer/QuadStrokerSlide.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tests/PaintTest.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tools/viewer/SimpleStrokerSlide.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/RELEASE_NOTES.txt
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/gm/bug12866.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/modules/canvaskit/canvaskit_bindings.cpp
https://skia.googlesource.com/skia/+/f549128104babe451bacf60e5851dbf73b2940d6
commit f549128104babe451bacf60e5851dbf73b2940d6
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Dec 15 13:37:49 2022
Add skpathutils namespace
Follow-up to https://skia-review.googlesource.com/c/skia/+/616821
This keeps the global namespace symbols around until I can
update G3, Chrome, and PDFium (Android update hasn't landed yet).
Change-Id: I5c125e7064ab50d1b47176c74f09658dea223eec
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/619099
Reviewed-by: Leon Scroggins <scroggo@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/src/core/SkPathUtils.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/bench/StrokeBench.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/gm/overstroke.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/src/core/SkDraw.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/gm/strokes.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tests/StrokerTest.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/docs/examples/convex_overstroke_linear_approx_curve.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tools/viewer/FatBitsSlide.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tests/DashPathEffectTest.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/docs/examples/FillPathWithPaint.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/gm/pathfill.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/docs/examples/convex_overstroke_quad.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tools/fonts/TestSVGTypeface.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/src/xps/SkXPSDevice.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tests/DrawPathTest.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/gm/fatpathfill.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/docs/examples/cubics_are_horrible.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tools/viewer/PathSlide.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/include/core/SkPathUtils.h
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tests/BlurTest.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tools/viewer/PathOverstrokeSlide.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/src/core/SkPaint.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/gm/strokerect.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tests/StrokeTest.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/bench/PathBench.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/docs/examples/strokerect_gm.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/modules/sksg/src/SkSGDraw.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/modules/pathkit/pathkit_wasm_bindings.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/modules/sksg/src/SkSGGeometryEffect.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/docs/examples/FillPathWithPaint_2.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tests/PathTest.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/docs/examples/zero_off_dashing.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tools/viewer/QuadStrokerSlide.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tests/PaintTest.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/tools/viewer/SimpleStrokerSlide.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/RELEASE_NOTES.txt
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/gm/bug12866.cpp
[modify] https://crrev.com/f549128104babe451bacf60e5851dbf73b2940d6/modules/canvaskit/canvaskit_bindings.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #8
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/a085e20a32d6716fadf727b25092b01fda66442e
commit a085e20a32d6716fadf727b25092b01fda66442e
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Dec 16 20:35:37 2022
[includes] Enforce IWYU on various base and core files.
Change-Id: I533a70c574e4b547f95099dff6edec70d895abf4
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/620220
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/include/core/SkMatrix.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/gpu/ResourceKey.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkLineClipper.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkRRect.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkEdgeBuilder.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/include/core/SkStream.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkArenaAlloc.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/include/BUILD.bazel
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkASAN.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkGeometry.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkSafeMath.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkEdgeBuilder.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/tools/DDLTileHelper.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkMatrix.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkRasterPipeline.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkTLazy.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkArenaAlloc.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/include/private/SkThreadID.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkRasterPipeline.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/include/private/SkContainers.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkEdgeClipper.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkLineClipper.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/include/core/SkRRect.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkEdgeClipper.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/gpu/ganesh/SurfaceDrawContext.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkTBlockList.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkGeometry.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkMatrixPriv.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkCubicClipper.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkStream.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/include/private/SkIDChangeListener.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkContainers.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkString.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/include/private/SkMutex.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkCubicClipper.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/include/core/SkString.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/BUILD.bazel
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/gpu/ganesh/gl/GrGLAssembleInterface.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/tools/UrlDataManager.cpp
https://skia.googlesource.com/skia/+/a085e20a32d6716fadf727b25092b01fda66442e
commit a085e20a32d6716fadf727b25092b01fda66442e
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Dec 16 20:35:37 2022
[includes] Enforce IWYU on various base and core files.
Change-Id: I533a70c574e4b547f95099dff6edec70d895abf4
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/620220
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/include/core/SkMatrix.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/gpu/ResourceKey.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkLineClipper.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkRRect.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkEdgeBuilder.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/include/core/SkStream.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkArenaAlloc.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/include/BUILD.bazel
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkASAN.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkGeometry.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkSafeMath.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkEdgeBuilder.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/tools/DDLTileHelper.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkMatrix.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkRasterPipeline.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkTLazy.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkArenaAlloc.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/include/private/SkThreadID.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkRasterPipeline.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/include/private/SkContainers.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkEdgeClipper.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkLineClipper.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/include/core/SkRRect.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkEdgeClipper.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/gpu/ganesh/SurfaceDrawContext.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkTBlockList.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkGeometry.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkMatrixPriv.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkCubicClipper.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkStream.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/include/private/SkIDChangeListener.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkContainers.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkString.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/include/private/SkMutex.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/core/SkCubicClipper.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/include/core/SkString.h
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/BUILD.bazel
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/src/gpu/ganesh/gl/GrGLAssembleInterface.cpp
[modify] https://crrev.com/a085e20a32d6716fadf727b25092b01fda66442e/tools/UrlDataManager.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #9
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/16741cadb533d39cdde03423fd3fefe162899f3e
commit 16741cadb533d39cdde03423fd3fefe162899f3e
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Dec 20 16:11:40 2022
[includes] Enforce IWYU on SkCubicMap and SkGlyph
I was curious if these actually depended on PathOps or not.
SkCubicMap does not anymore, there was some #ifdef'd code
that currently exists in CubicMapTest.cpp anyway.
If we want SkGlyph in "core", we will want to remove the
dependency on pathops.
Change-Id: I9e2b7a37b5758d044575dad651d5bc1b203c070c
Bug: skia:13052, skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/621199
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/16741cadb533d39cdde03423fd3fefe162899f3e/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/16741cadb533d39cdde03423fd3fefe162899f3e/src/core/SkCubicSolver.h
[modify] https://crrev.com/16741cadb533d39cdde03423fd3fefe162899f3e/src/core/SkGlyph.cpp
[modify] https://crrev.com/16741cadb533d39cdde03423fd3fefe162899f3e/src/core/SkCubicMap.cpp
[modify] https://crrev.com/16741cadb533d39cdde03423fd3fefe162899f3e/include/core/SkCubicMap.h
[modify] https://crrev.com/16741cadb533d39cdde03423fd3fefe162899f3e/src/core/SkGlyph.h
https://skia.googlesource.com/skia/+/16741cadb533d39cdde03423fd3fefe162899f3e
commit 16741cadb533d39cdde03423fd3fefe162899f3e
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Dec 20 16:11:40 2022
[includes] Enforce IWYU on SkCubicMap and SkGlyph
I was curious if these actually depended on PathOps or not.
SkCubicMap does not anymore, there was some #ifdef'd code
that currently exists in CubicMapTest.cpp anyway.
If we want SkGlyph in "core", we will want to remove the
dependency on pathops.
Change-Id: I9e2b7a37b5758d044575dad651d5bc1b203c070c
Bug: skia:13052, skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/621199
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/16741cadb533d39cdde03423fd3fefe162899f3e/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/16741cadb533d39cdde03423fd3fefe162899f3e/src/core/SkCubicSolver.h
[modify] https://crrev.com/16741cadb533d39cdde03423fd3fefe162899f3e/src/core/SkGlyph.cpp
[modify] https://crrev.com/16741cadb533d39cdde03423fd3fefe162899f3e/src/core/SkCubicMap.cpp
[modify] https://crrev.com/16741cadb533d39cdde03423fd3fefe162899f3e/include/core/SkCubicMap.h
[modify] https://crrev.com/16741cadb533d39cdde03423fd3fefe162899f3e/src/core/SkGlyph.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #10
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/8b0def3a0c517c96326e40db2f2d2c86361666a5
commit 8b0def3a0c517c96326e40db2f2d2c86361666a5
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Dec 20 20:23:53 2022
Introduce SkPathEnums.h
This also has some misc cleanups of SkPathRef including
removal of unused methods and moving an SkPath implementation
to SkPath.cpp.
As we modularize things into base and core, we want
SkPathRef to be in core, but not used outside of core.
Thus, we need to any dependencies from stuff outside of
core on SkPathRef (e.g. effects/gpu). This is achieved
by moving the enums those things reference to SkPathEnums.h
(which will eventually be in base).
I moved kPathRefGenIDBitCnt from SkPathPriv.h to SkPathRef.cpp
because it was only used in SkPath.cpp and SkPathRef.cpp
(and we might want to decouple SkPath.cpp from SkPathPriv.h
anyway) and now only used directly by SkPathRef.cpp.
Change-Id: Iccc1d0ba822ad374205ec798ef2f44cc42f9e107
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/621196
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/gn/core.gni
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/src/core/SkPath_serial.cpp
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/src/core/SkPath.cpp
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/src/effects/SkOpPathEffect.cpp
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/include/private/SkPathRef.h
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/src/core/SkPathRef.cpp
[add] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/include/private/SkPathEnums.h
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/src/core/SkPathBuilder.cpp
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/src/gpu/ganesh/effects/GrConvexPolyEffect.cpp
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/src/core/SkPathPriv.h
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/src/pathops/SkOpBuilder.cpp
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/tests/PathTest.cpp
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/include/private/BUILD.bazel
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/src/utils/SkDashPath.cpp
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/gm/aaa.cpp
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/public.bzl
https://skia.googlesource.com/skia/+/8b0def3a0c517c96326e40db2f2d2c86361666a5
commit 8b0def3a0c517c96326e40db2f2d2c86361666a5
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Dec 20 20:23:53 2022
Introduce SkPathEnums.h
This also has some misc cleanups of SkPathRef including
removal of unused methods and moving an SkPath implementation
to SkPath.cpp.
As we modularize things into base and core, we want
SkPathRef to be in core, but not used outside of core.
Thus, we need to any dependencies from stuff outside of
core on SkPathRef (e.g. effects/gpu). This is achieved
by moving the enums those things reference to SkPathEnums.h
(which will eventually be in base).
I moved kPathRefGenIDBitCnt from SkPathPriv.h to SkPathRef.cpp
because it was only used in SkPath.cpp and SkPathRef.cpp
(and we might want to decouple SkPath.cpp from SkPathPriv.h
anyway) and now only used directly by SkPathRef.cpp.
Change-Id: Iccc1d0ba822ad374205ec798ef2f44cc42f9e107
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/621196
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/gn/core.gni
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/src/core/SkPath_serial.cpp
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/src/core/SkPath.cpp
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/src/effects/SkOpPathEffect.cpp
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/include/private/SkPathRef.h
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/src/core/SkPathRef.cpp
[add] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/include/private/SkPathEnums.h
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/src/core/SkPathBuilder.cpp
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/src/gpu/ganesh/effects/GrConvexPolyEffect.cpp
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/src/core/SkPathPriv.h
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/src/pathops/SkOpBuilder.cpp
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/tests/PathTest.cpp
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/include/private/BUILD.bazel
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/src/utils/SkDashPath.cpp
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/gm/aaa.cpp
[modify] https://crrev.com/8b0def3a0c517c96326e40db2f2d2c86361666a5/public.bzl
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #11
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/c31623792b89e119ce1ae7f636f3ed82155535f6
commit c31623792b89e119ce1ae7f636f3ed82155535f6
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 03 15:34:27 2023
Use skvx instead of SkDVector in Path/PathBuilder
We would like to remove the dependency of SkPath on SkPathops.
Remaining dependencies:
- SkGeometry.cpp
- SkGlyph.cpp
While working on this, I broke something and the Paths tests
started to fail. I found those hard to understand and debug,
so I ported some of the failing ones over to PathBuilder
(which does not have as comprehensive of tests). I figured out
what I was doing wrong and what those failing tests were for.
See the additional documentation in SkPath.cpp and SkPathBuilder.cpp
This adds some new static methods to skvx, along with unit tests
for them.
Because I was comparing functionality between skvx and SkDVector,
I added some tests to the latter for an apples to apple comparison.
Change-Id: I8aa43ed021949ccf1015b2dedf26a52b59d15860
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/621198
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/tests/SkVxTest.cpp
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/tests/PathOpsDVectorTest.cpp
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/src/core/SkPath.cpp
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/include/private/SkVx.h
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/tests/Test.h
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/tests/PathBuilderTest.cpp
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/src/core/SkPathBuilder.cpp
https://skia.googlesource.com/skia/+/c31623792b89e119ce1ae7f636f3ed82155535f6
commit c31623792b89e119ce1ae7f636f3ed82155535f6
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 03 15:34:27 2023
Use skvx instead of SkDVector in Path/PathBuilder
We would like to remove the dependency of SkPath on SkPathops.
Remaining dependencies:
- SkGeometry.cpp
- SkGlyph.cpp
While working on this, I broke something and the Paths tests
started to fail. I found those hard to understand and debug,
so I ported some of the failing ones over to PathBuilder
(which does not have as comprehensive of tests). I figured out
what I was doing wrong and what those failing tests were for.
See the additional documentation in SkPath.cpp and SkPathBuilder.cpp
This adds some new static methods to skvx, along with unit tests
for them.
Because I was comparing functionality between skvx and SkDVector,
I added some tests to the latter for an apples to apple comparison.
Change-Id: I8aa43ed021949ccf1015b2dedf26a52b59d15860
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/621198
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/tests/SkVxTest.cpp
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/tests/PathOpsDVectorTest.cpp
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/src/core/SkPath.cpp
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/include/private/SkVx.h
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/tests/Test.h
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/tests/PathBuilderTest.cpp
[modify] https://crrev.com/c31623792b89e119ce1ae7f636f3ed82155535f6/src/core/SkPathBuilder.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #12
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/8f541068859732fee75411f4e196bfd700d7b8d0
commit 8f541068859732fee75411f4e196bfd700d7b8d0
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Dec 20 13:55:38 2022
[base] Split SkTypes.h logic out into smaller files
This shouldn't change anything functionally, but makes it easier
to reason about a few smaller files rather than one big file.
Additionally, this will keep our files in base with (hopefully)
a smaller, clearer dependency footprint.
Change-Id: Ifd7fc26cebc0d42dfc6096c029e52ac75fa95274
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/620836
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
[add] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/base/SkFeatures.h
[modify] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/gn/core.gni
[modify] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/base/BUILD.bazel
[modify] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/core/SkTypes.h
[add] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/base/SkAPI.h
[modify] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/base/SkAlign.h
[modify] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/BUILD.bazel
[modify] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/modules/pathkit/pathkit_wasm_bindings.cpp
[add] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/base/SkAssert.h
[add] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/base/SkAttributes.h
[add] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/base/SkLoadUserConfig.h
[modify] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/public.bzl
[add] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/base/SkDebug.h
https://skia.googlesource.com/skia/+/8f541068859732fee75411f4e196bfd700d7b8d0
commit 8f541068859732fee75411f4e196bfd700d7b8d0
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Dec 20 13:55:38 2022
[base] Split SkTypes.h logic out into smaller files
This shouldn't change anything functionally, but makes it easier
to reason about a few smaller files rather than one big file.
Additionally, this will keep our files in base with (hopefully)
a smaller, clearer dependency footprint.
Change-Id: Ifd7fc26cebc0d42dfc6096c029e52ac75fa95274
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/620836
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
[add] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/base/SkFeatures.h
[modify] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/gn/core.gni
[modify] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/base/BUILD.bazel
[modify] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/core/SkTypes.h
[add] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/base/SkAPI.h
[modify] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/base/SkAlign.h
[modify] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/BUILD.bazel
[modify] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/modules/pathkit/pathkit_wasm_bindings.cpp
[add] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/base/SkAssert.h
[add] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/base/SkAttributes.h
[add] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/base/SkLoadUserConfig.h
[modify] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/public.bzl
[add] https://crrev.com/8f541068859732fee75411f4e196bfd700d7b8d0/include/base/SkDebug.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #13
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/cbb82107d3d80506a1cb72aafcda22d73d7b8acb
commit cbb82107d3d80506a1cb72aafcda22d73d7b8acb
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 03 17:21:17 2023
[base] Move align-functions from SkTypes to base/SkAlign.h
After our modularization effort, I do expect include/private to
still exist, just for things like include/private/SkPathRef.h which
depend on things in include/core.
include/base (as the README says), should only depend on system files
and other base files. We will be adding Bazel cc_library rules
(eventually) to enforce this.
Change-Id: I6275377c54718a8ce0e4efd093ae43e9dd2cef1e
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/620658
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/graphite/UploadBufferManager.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/gn/core.gni
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/ResourceKey.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/graphite/Attribute.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/core/SkBlockAllocator.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/codec/SkWbmpCodec.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/tests/SkTBlockListTest.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/include/core/SkTypes.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/effects/SkDashPathEffect.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/codec/SkBmpStandardCodec.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/tests/ReadPixelsTest.cpp
[add] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/include/base/SkAlign.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/tests/Writer32Test.cpp
[add] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/include/base/README.md
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/include/BUILD.bazel
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/include/private/SkTemplates.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/codec/SkSwizzler.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/graphite/dawn/DawnBuffer.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/graphite/geom/IntersectionTree.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/ganesh/GrProgramDesc.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/codec/SkBmpCodec.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/codec/SkWebpCodec.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/graphite/mtl/MtlBuffer.mm
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/tests/ChecksumTest.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/tests/TransferPixelsTest.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/tests/CodecTest.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/tests/SerializationTest.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/codec/SkJpegCodec.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/utils/SkCustomTypeface.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/codec/SkBmpRLECodec.cpp
[add] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/include/base/BUILD.bazel
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/core/SkBuffer.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/graphite/DrawBufferManager.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/tests/GrGpuBufferTest.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/graphite/UploadTask.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/core/SkStream.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/core/SkContainers.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/tests/OverAlignedTest.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/core/SkAutoMalloc.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/utils/SkDashPath.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/bazel/exporter_tool/main.go
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/graphite/UniformManager.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/RELEASE_NOTES.txt
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/graphite/Caps.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/public.bzl
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/effects/SkTableMaskFilter.cpp
https://skia.googlesource.com/skia/+/cbb82107d3d80506a1cb72aafcda22d73d7b8acb
commit cbb82107d3d80506a1cb72aafcda22d73d7b8acb
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 03 17:21:17 2023
[base] Move align-functions from SkTypes to base/SkAlign.h
After our modularization effort, I do expect include/private to
still exist, just for things like include/private/SkPathRef.h which
depend on things in include/core.
include/base (as the README says), should only depend on system files
and other base files. We will be adding Bazel cc_library rules
(eventually) to enforce this.
Change-Id: I6275377c54718a8ce0e4efd093ae43e9dd2cef1e
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/620658
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/graphite/UploadBufferManager.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/gn/core.gni
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/ResourceKey.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/graphite/Attribute.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/core/SkBlockAllocator.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/codec/SkWbmpCodec.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/tests/SkTBlockListTest.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/include/core/SkTypes.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/effects/SkDashPathEffect.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/codec/SkBmpStandardCodec.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/tests/ReadPixelsTest.cpp
[add] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/include/base/SkAlign.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/tests/Writer32Test.cpp
[add] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/include/base/README.md
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/include/BUILD.bazel
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/include/private/SkTemplates.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/codec/SkSwizzler.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/graphite/dawn/DawnBuffer.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/graphite/geom/IntersectionTree.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/ganesh/GrProgramDesc.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/codec/SkBmpCodec.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/codec/SkWebpCodec.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/graphite/mtl/MtlBuffer.mm
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/tests/ChecksumTest.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/tests/TransferPixelsTest.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/tests/CodecTest.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/tests/SerializationTest.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/codec/SkJpegCodec.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/utils/SkCustomTypeface.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/codec/SkBmpRLECodec.cpp
[add] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/include/base/BUILD.bazel
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/core/SkBuffer.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/graphite/DrawBufferManager.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/tests/GrGpuBufferTest.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/graphite/UploadTask.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/core/SkStream.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/core/SkContainers.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/tests/OverAlignedTest.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/core/SkAutoMalloc.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/utils/SkDashPath.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/bazel/exporter_tool/main.go
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/graphite/UniformManager.cpp
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/RELEASE_NOTES.txt
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/gpu/graphite/Caps.h
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/public.bzl
[modify] https://crrev.com/cbb82107d3d80506a1cb72aafcda22d73d7b8acb/src/effects/SkTableMaskFilter.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #14
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/699841c3e8624fe76b40f94346fef030ea18404a
commit 699841c3e8624fe76b40f94346fef030ea18404a
Author: Brian Osman <brianosman@google.com>
Date: Wed Jan 04 15:32:03 2023
Move SkImageInfoPriv.h to src/core
It didn't need to be included by GrTypesPriv.h
Bug: skia:13983
Change-Id: I96eb3068c310b10399c75dfb8147cb5e3a382e08
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/626076
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkVMBlitter.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/gn/core.gni
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkDraw.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/gpu/ganesh/gl/GrGLUtil.h
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/BUILD.bazel
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/gpu/ganesh/GrProxyProvider.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/image/SkImage_Gpu.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkMipmap.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/gpu/graphite/Device.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/images/SkWebpEncoder.cpp
[rename] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkImageInfoPriv.h
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/include/private/BUILD.bazel
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkMipmap.h
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkPixmap.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkYUVAPixmaps.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/pdf/SkPDFBitmap.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkImageInfo.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkRasterPipeline.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/tests/ExtendedSkColorTypeTests.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/include/private/gpu/ganesh/GrTypesPriv.h
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkConvertPixels.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkBlitter_Sprite.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/tests/EncodeTest.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkBitmap.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/tests/WritePixelsTest.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/gm/p3.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/images/SkImageEncoderPriv.h
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/dm/DMSrcSink.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/image/SkSurface_Raster.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/shaders/SkImageShader.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/gpu/ganesh/GrResourceProvider.h
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/tests/graphite/ReadWritePixelsGraphiteTest.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/public.bzl
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/shaders/SkPictureShader.cpp
https://skia.googlesource.com/skia/+/699841c3e8624fe76b40f94346fef030ea18404a
commit 699841c3e8624fe76b40f94346fef030ea18404a
Author: Brian Osman <brianosman@google.com>
Date: Wed Jan 04 15:32:03 2023
Move SkImageInfoPriv.h to src/core
It didn't need to be included by GrTypesPriv.h
Bug: skia:13983
Change-Id: I96eb3068c310b10399c75dfb8147cb5e3a382e08
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/626076
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkVMBlitter.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/gn/core.gni
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkDraw.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/gpu/ganesh/gl/GrGLUtil.h
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/BUILD.bazel
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/gpu/ganesh/GrProxyProvider.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/image/SkImage_Gpu.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkMipmap.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/gpu/graphite/Device.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/images/SkWebpEncoder.cpp
[rename] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkImageInfoPriv.h
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/include/private/BUILD.bazel
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkMipmap.h
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkPixmap.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkYUVAPixmaps.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/pdf/SkPDFBitmap.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkImageInfo.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkRasterPipeline.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/tests/ExtendedSkColorTypeTests.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/include/private/gpu/ganesh/GrTypesPriv.h
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkConvertPixels.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkBlitter_Sprite.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/tests/EncodeTest.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/core/SkBitmap.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/tests/WritePixelsTest.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/gm/p3.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/images/SkImageEncoderPriv.h
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/dm/DMSrcSink.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/image/SkSurface_Raster.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/shaders/SkImageShader.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/gpu/ganesh/GrResourceProvider.h
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/tests/graphite/ReadWritePixelsGraphiteTest.cpp
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/public.bzl
[modify] https://crrev.com/699841c3e8624fe76b40f94346fef030ea18404a/src/shaders/SkPictureShader.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #15
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6
commit ffd084f4c4bf57e50d0817f25eb584ca020cf3e6
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 04 19:51:12 2023
[base] Move include/base to include/private/base
This should make it clear that "base" are internal to Skia and not
to be used by clients.
Change-Id: I2f4c6ef8ea7d4a8f59f5a6760df9ca832db03e03
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/626202
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/gn/core.gni
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/ResourceKey.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/core/SkBlockAllocator.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/codec/SkWbmpCodec.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/tests/SkTBlockListTest.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/core/SkTypes.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/effects/SkDashPathEffect.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/BUILD.bazel
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/codec/SkSwizzler.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/graphite/dawn/DawnBuffer.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/ganesh/GrProgramDesc.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/codec/SkWebpCodec.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/graphite/mtl/MtlBuffer.mm
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/tests/TransferPixelsTest.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/tests/CodecTest.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/utils/SkCustomTypeface.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/codec/SkBmpRLECodec.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/core/SkBuffer.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/graphite/DrawBufferManager.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/tests/GrGpuBufferTest.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/graphite/UploadTask.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/core/SkStream.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/core/SkContainers.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/tests/OverAlignedTest.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/utils/SkDashPath.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/graphite/UniformManager.cpp
[rename] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/base/SkDebug.h
[rename] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/base/SkAPI.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/graphite/UploadBufferManager.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/graphite/Attribute.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/codec/SkBmpStandardCodec.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/tests/Writer32Test.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/SkTemplates.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/graphite/geom/IntersectionTree.h
[rename] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/base/README.md
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/codec/SkBmpCodec.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/tests/ChecksumTest.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/BUILD.bazel
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/tests/SerializationTest.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/codec/SkJpegCodec.cpp
[rename] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/base/BUILD.bazel
[rename] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/base/SkLoadUserConfig.h
[rename] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/base/SkAlign.h
[rename] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/base/SkAssert.h
[rename] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/base/SkFeatures.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/core/SkAutoMalloc.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/bazel/exporter_tool/main.go
[rename] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/base/SkAttributes.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/graphite/Caps.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/public.bzl
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/effects/SkTableMaskFilter.cpp
https://skia.googlesource.com/skia/+/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6
commit ffd084f4c4bf57e50d0817f25eb584ca020cf3e6
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 04 19:51:12 2023
[base] Move include/base to include/private/base
This should make it clear that "base" are internal to Skia and not
to be used by clients.
Change-Id: I2f4c6ef8ea7d4a8f59f5a6760df9ca832db03e03
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/626202
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/gn/core.gni
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/ResourceKey.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/core/SkBlockAllocator.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/codec/SkWbmpCodec.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/tests/SkTBlockListTest.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/core/SkTypes.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/effects/SkDashPathEffect.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/BUILD.bazel
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/codec/SkSwizzler.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/graphite/dawn/DawnBuffer.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/ganesh/GrProgramDesc.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/codec/SkWebpCodec.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/graphite/mtl/MtlBuffer.mm
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/tests/TransferPixelsTest.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/tests/CodecTest.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/utils/SkCustomTypeface.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/codec/SkBmpRLECodec.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/core/SkBuffer.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/graphite/DrawBufferManager.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/tests/GrGpuBufferTest.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/graphite/UploadTask.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/core/SkStream.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/core/SkContainers.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/tests/OverAlignedTest.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/utils/SkDashPath.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/graphite/UniformManager.cpp
[rename] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/base/SkDebug.h
[rename] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/base/SkAPI.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/graphite/UploadBufferManager.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/graphite/Attribute.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/codec/SkBmpStandardCodec.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/tests/Writer32Test.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/SkTemplates.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/graphite/geom/IntersectionTree.h
[rename] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/base/README.md
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/codec/SkBmpCodec.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/tests/ChecksumTest.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/BUILD.bazel
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/tests/SerializationTest.cpp
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/codec/SkJpegCodec.cpp
[rename] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/base/BUILD.bazel
[rename] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/base/SkLoadUserConfig.h
[rename] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/base/SkAlign.h
[rename] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/base/SkAssert.h
[rename] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/base/SkFeatures.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/core/SkAutoMalloc.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/bazel/exporter_tool/main.go
[rename] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/include/private/base/SkAttributes.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/gpu/graphite/Caps.h
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/public.bzl
[modify] https://crrev.com/ffd084f4c4bf57e50d0817f25eb584ca020cf3e6/src/effects/SkTableMaskFilter.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #16
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/a24947d2357d8d3bfdf2160cefe4c204123455eb
commit a24947d2357d8d3bfdf2160cefe4c204123455eb
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 04 20:03:28 2023
Break apart some uses of SkTypes
These files will be moved into base in the following CL:
include/private/SingleOwner.h
include/private/SkDeque.h
include/private/SkMalloc.h
include/private/SkMutex.h
include/private/SkSemaphore.h
include/private/SkThreadID.h
include/private/SkTo.h
Change-Id: I11fd0fc6be4a8694093703dffb7579e29a9585ef
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/626236
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/a24947d2357d8d3bfdf2160cefe4c204123455eb/include/private/SkDeque.h
[modify] https://crrev.com/a24947d2357d8d3bfdf2160cefe4c204123455eb/src/ports/SkMemory_malloc.cpp
[modify] https://crrev.com/a24947d2357d8d3bfdf2160cefe4c204123455eb/include/private/SingleOwner.h
[modify] https://crrev.com/a24947d2357d8d3bfdf2160cefe4c204123455eb/include/private/SkMutex.h
[modify] https://crrev.com/a24947d2357d8d3bfdf2160cefe4c204123455eb/include/private/SkSemaphore.h
[modify] https://crrev.com/a24947d2357d8d3bfdf2160cefe4c204123455eb/include/private/SkMalloc.h
[modify] https://crrev.com/a24947d2357d8d3bfdf2160cefe4c204123455eb/src/core/SkDeque.cpp
[modify] https://crrev.com/a24947d2357d8d3bfdf2160cefe4c204123455eb/include/private/SkThreadID.h
[modify] https://crrev.com/a24947d2357d8d3bfdf2160cefe4c204123455eb/include/private/SkTo.h
https://skia.googlesource.com/skia/+/a24947d2357d8d3bfdf2160cefe4c204123455eb
commit a24947d2357d8d3bfdf2160cefe4c204123455eb
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 04 20:03:28 2023
Break apart some uses of SkTypes
These files will be moved into base in the following CL:
include/private/SingleOwner.h
include/private/SkDeque.h
include/private/SkMalloc.h
include/private/SkMutex.h
include/private/SkSemaphore.h
include/private/SkThreadID.h
include/private/SkTo.h
Change-Id: I11fd0fc6be4a8694093703dffb7579e29a9585ef
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/626236
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/a24947d2357d8d3bfdf2160cefe4c204123455eb/include/private/SkDeque.h
[modify] https://crrev.com/a24947d2357d8d3bfdf2160cefe4c204123455eb/src/ports/SkMemory_malloc.cpp
[modify] https://crrev.com/a24947d2357d8d3bfdf2160cefe4c204123455eb/include/private/SingleOwner.h
[modify] https://crrev.com/a24947d2357d8d3bfdf2160cefe4c204123455eb/include/private/SkMutex.h
[modify] https://crrev.com/a24947d2357d8d3bfdf2160cefe4c204123455eb/include/private/SkSemaphore.h
[modify] https://crrev.com/a24947d2357d8d3bfdf2160cefe4c204123455eb/include/private/SkMalloc.h
[modify] https://crrev.com/a24947d2357d8d3bfdf2160cefe4c204123455eb/src/core/SkDeque.cpp
[modify] https://crrev.com/a24947d2357d8d3bfdf2160cefe4c204123455eb/include/private/SkThreadID.h
[modify] https://crrev.com/a24947d2357d8d3bfdf2160cefe4c204123455eb/include/private/SkTo.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #17
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/ecd3a2f865baebb829bdcc37224d1f02e5715e48
commit ecd3a2f865baebb829bdcc37224d1f02e5715e48
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jan 05 13:17:45 2023
Remove enums from SkTypes.h
SkBackingFit (only used privately) -> src/gpu/SkBackingFit.h
SkBudgeted -> skgpu::Budgeted in include/gpu/GpuTypes.h because
it appears to be used in both Ganesh and Graphite.
This uses a typedef to support backwards compatibility until
we migrate clients.
Change-Id: I9a30c1f9a0c2688a5210c45e8b38b2f4ecd4b4fb
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/621977
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/d3d/GrD3DGpu.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrResourceAllocator.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrGpuResource.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/ResourceCache.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Texture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TriangulatingPathRendererTests.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/OpChainTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrTextureProxy.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tools/fm/fm.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ColorFilterTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/RepeatedClippedBlurTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/image/SkImage.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Buffer.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ImageNewShaderTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/image_shader.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TransferPixelsTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TextureProxyTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ImageTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrRecordingContextPriv.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tools/skpbench/skpbench.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/effects/imagefilters/SkDisplacementMapImageFilter.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrMeshTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrThreadSafeCacheTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/dawn/GrDawnTexture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrSlugTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/TextureUtils.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TextureOpTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/Device_v1.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrSurfaceProxyPriv.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/gl/GrGLGpu.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/image.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/effects/imagefilters/SkBlendImageFilter.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrTextureRenderTargetProxy.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mock/GrMockGpu.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/modules/canvaskit/gm_bindings.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Device.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/textblobmixedsizes.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrGpu.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/effects/imagefilters/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/effects/imagefilters/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/Skbug5221.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/dawn/GrDawnGpu.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/mtl/MtlComputeCommandEncoder.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/PrimitiveProcessorTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ExtendedSkColorTypeTests.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrMipMappedTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrOpListFlushTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Sampler.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TextureStripAtlasManagerTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/fuzz/FuzzCreateDDL.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/vk/GrVkImage.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/graphite/RecorderTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/clockwise.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/core/SkSpecialImage.cpp
[add] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/SkBackingFit.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrSurfaceResolveTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/docs/examples/Image_MakeBackendTextureFromSkImage.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/DefaultPathRendererTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrAHardwareBufferImageGenerator.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/dawn/GrDawnTexture.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/gpu_blur_utils.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/DeviceTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrRenderTargetProxy.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/core/SkSpecialSurface.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/PremulAlphaRoundTripTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/mtl/MtlTexture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/PathRendererCacheTests.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/d3d/GrD3DTexture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrFinishedFlushTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrAHardwareBufferTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tools/gpu/ProxyUtils.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/image/SkImage_Lazy.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/include/core/SkTypes.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrSurfaceProxyView.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ImageIsOpaqueTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TestUtils.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/dawn/DawnResourceProvider.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/Skbug6653.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ProxyTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/vk/GrVkTexture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mtl/GrMtlTexture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/BlurTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/ops/SoftwarePathRenderer.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/core/SkDeferredDisplayListRecorder.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrGpu.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/effects/imagefilters/SkLightingImageFilter.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/vk/VulkanResourceProvider.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/include/gpu/GpuTypes.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ProxyRefTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/mtl/MtlResourceProvider.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/dawn/GrDawnBuffer.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/DrawOpAtlasTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrBackendTextureImageGenerator.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GLBackendSurfaceTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SkSLES2ConformanceTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/d3d/GrD3DAttachment.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/dawn/GrDawnAttachment.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/gl/GrGLTextureRenderTarget.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/ops/TextureOp.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/Skbug12214.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/SurfaceContext.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mtl/GrMtlTextureRenderTarget.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mock/GrMockSurfaceProxy.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrTextureProxy.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mtl/GrMtlAttachment.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/surface.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/DMSAATest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrProxyProvider.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/image/SkImage_Gpu.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/mtl/MtlRenderCommandEncoder.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/vk/VulkanResourceProvider.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/d3d/GrD3DTextureRenderTarget.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/vk/GrVkTextureRenderTarget.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ApplyGammaTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mtl/GrMtlAttachment.mm
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Resource.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ProgramsTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SurfaceDrawContextTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrClipStackTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/SurfaceDrawContext.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/PinnedImageTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/PromiseImageTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SRGBReadWritePixelsTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Texture.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mock/GrMockGpu.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Surface_Graphite.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SkSLTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrTextBlobTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/SurfaceDrawContext.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/vk/GrVkBuffer.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/dawn/GrDawnGpu.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/VkHardwareBufferTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/image/SkImage_GpuYUVA.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/include/core/SkSurface.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/core/SkBlurMF.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ImageFilterTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/dawn/DawnResourceProvider.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrContextOOM.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tools/skottie2movie.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/Device.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrRenderTargetProxy.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/ComputePipeline.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/ResourceProvider.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/image_pict.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SurfaceTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/image/SkImage_GpuBase.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/BulkRectTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ShaderImageFilterTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SkRemoteGlyphCacheTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/gl/GrGLTexture.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/graphite/GraphiteResourceCacheTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/skbug_12212.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/VkYcbcrSamplerTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/include/core/SkImage.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/d3d/GrD3DTexture.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/vk/VulkanTexture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/vk/GrVkGpu.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/d3d/GrD3DGpu.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/core/SkGpuBlurUtils.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/ResourceProvider.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/docs/examples/Surface_MakeRenderTarget_2.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/LazyProxyTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrDDLImageTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/ops/LatticeOp.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GpuDrawPathTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrSurfaceProxy.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrResourceProvider.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/SkGr.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/LazyStencilAttachmentTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/vk/GrVkTexture.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TraceMemoryDumpTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mtl/GrMtlGpu.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/imagemasksubset.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/ResourceCache.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrPipelineDynamicStateTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Device.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/simple_magnification.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/vk/GrVkGpu.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/gl/GrGLBuffer.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/gl/GrGLAttachment.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TestUtils.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/gl/GrGLTextureRenderTarget.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrTextureRenderTargetProxy.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/SkGr.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/gl/GrGLTexture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/ClipStack.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrTextureMipMapInvalidationTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/bench/nanobench.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ProxyConversionTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gn/gpu.gni
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/imagefromyuvtextures.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/bench/GrMipmapBench.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrThreadSafeCache.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/WritePixelsTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/vk/GrVkTextureRenderTarget.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/image/SkSurface_Gpu.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TextBlobCacheTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ResourceAllocatorTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SkSLCross.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/public.bzl
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/d3d/GrD3DBuffer.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Surface_Graphite.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/MatrixColorFilterTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ClearTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrSubmittedFlushTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/docs/examples/Surface_MakeRenderTarget.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mtl/GrMtlGpu.mm
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/WrappedSurfaceCopyOnWriteTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Image_Graphite.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/d3d/GrD3DTextureRenderTarget.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tools/gpu/YUVUtils.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrSurfaceProxyView.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/graphite/TextureProxyTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SkRuntimeEffectTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Recording.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/vk/GrVkImage.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/image/SkSurface.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/DeferredDisplayListTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/SpecialImage_Graphite.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/vk/VulkanTexture.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/dawn/DawnTexture.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrGpuBufferTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/RuntimeBlendTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/TextureProxy.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mock/GrMockTexture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/dm/DMSrcSink.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/docs/examples/blur4444.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrGpuResource.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/anisotropic.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/TextureProxy.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/docs/examples/Surface_MakeRenderTarget_3.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/modules/skottie/src/SkottieTool.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/dawn/DawnTexture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/modules/canvaskit/canvaskit_bindings.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/dftext.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/dftext_blob_persp.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mock/GrMockBuffer.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrProxyProvider.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/DrawAtlas.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrSurfaceTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/core/SkRuntimeEffect.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/example/VulkanBasic.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tools/fiddle/fiddle_main.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/docs/examples/Surface_characterize.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/BUILD.bazel
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Resource.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/mtl/MtlBlitCommandEncoder.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrRecordingContextPriv.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/fuzz/FuzzCanvas.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrDrawOpAtlas.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tools/skiaserve/Request.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/bench/GrResourceCacheBench.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/core/SkImageFilter.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrResourceProvider.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/CompressedBackendAllocationTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ProcessorTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/clear_swizzle.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/discard.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SrcSrcOverBatchTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/GraphicsPipeline.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tools/viewer/TextureUploadSlide.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/TextureUtils.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TextureBindingsResetTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/VkDrawableTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/RELEASE_NOTES.txt
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/effects/imagefilters/SkAlphaThresholdImageFilter.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrSurfaceProxy.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/gl/GrGLGpu.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SurfaceSemaphoreTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mock/GrMockAttachment.h
https://skia.googlesource.com/skia/+/ecd3a2f865baebb829bdcc37224d1f02e5715e48
commit ecd3a2f865baebb829bdcc37224d1f02e5715e48
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jan 05 13:17:45 2023
Remove enums from SkTypes.h
SkBackingFit (only used privately) -> src/gpu/SkBackingFit.h
SkBudgeted -> skgpu::Budgeted in include/gpu/GpuTypes.h because
it appears to be used in both Ganesh and Graphite.
This uses a typedef to support backwards compatibility until
we migrate clients.
Change-Id: I9a30c1f9a0c2688a5210c45e8b38b2f4ecd4b4fb
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/621977
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/d3d/GrD3DGpu.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrResourceAllocator.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrGpuResource.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/ResourceCache.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Texture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TriangulatingPathRendererTests.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/OpChainTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrTextureProxy.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tools/fm/fm.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ColorFilterTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/RepeatedClippedBlurTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/image/SkImage.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Buffer.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ImageNewShaderTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/image_shader.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TransferPixelsTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TextureProxyTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ImageTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrRecordingContextPriv.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tools/skpbench/skpbench.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/effects/imagefilters/SkDisplacementMapImageFilter.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrMeshTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrThreadSafeCacheTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/dawn/GrDawnTexture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrSlugTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/TextureUtils.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TextureOpTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/Device_v1.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrSurfaceProxyPriv.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/gl/GrGLGpu.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/image.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/effects/imagefilters/SkBlendImageFilter.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrTextureRenderTargetProxy.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mock/GrMockGpu.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/modules/canvaskit/gm_bindings.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Device.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/textblobmixedsizes.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrGpu.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/effects/imagefilters/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/effects/imagefilters/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/Skbug5221.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/dawn/GrDawnGpu.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/mtl/MtlComputeCommandEncoder.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/PrimitiveProcessorTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ExtendedSkColorTypeTests.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrMipMappedTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrOpListFlushTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Sampler.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TextureStripAtlasManagerTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/fuzz/FuzzCreateDDL.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/vk/GrVkImage.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/graphite/RecorderTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/clockwise.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/core/SkSpecialImage.cpp
[add] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/SkBackingFit.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrSurfaceResolveTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/docs/examples/Image_MakeBackendTextureFromSkImage.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/DefaultPathRendererTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrAHardwareBufferImageGenerator.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/dawn/GrDawnTexture.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/gpu_blur_utils.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/DeviceTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrRenderTargetProxy.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/core/SkSpecialSurface.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/PremulAlphaRoundTripTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/mtl/MtlTexture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/PathRendererCacheTests.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/d3d/GrD3DTexture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrFinishedFlushTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrAHardwareBufferTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tools/gpu/ProxyUtils.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/image/SkImage_Lazy.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/include/core/SkTypes.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrSurfaceProxyView.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ImageIsOpaqueTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TestUtils.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/dawn/DawnResourceProvider.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/Skbug6653.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ProxyTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/vk/GrVkTexture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mtl/GrMtlTexture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/BlurTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/ops/SoftwarePathRenderer.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/core/SkDeferredDisplayListRecorder.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrGpu.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/effects/imagefilters/SkLightingImageFilter.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/vk/VulkanResourceProvider.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/include/gpu/GpuTypes.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ProxyRefTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/mtl/MtlResourceProvider.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/dawn/GrDawnBuffer.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/DrawOpAtlasTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrBackendTextureImageGenerator.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GLBackendSurfaceTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SkSLES2ConformanceTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/d3d/GrD3DAttachment.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/dawn/GrDawnAttachment.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/gl/GrGLTextureRenderTarget.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/ops/TextureOp.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/Skbug12214.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/SurfaceContext.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mtl/GrMtlTextureRenderTarget.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mock/GrMockSurfaceProxy.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrTextureProxy.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mtl/GrMtlAttachment.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/surface.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/DMSAATest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrProxyProvider.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/image/SkImage_Gpu.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/mtl/MtlRenderCommandEncoder.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/vk/VulkanResourceProvider.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/d3d/GrD3DTextureRenderTarget.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/vk/GrVkTextureRenderTarget.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ApplyGammaTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mtl/GrMtlAttachment.mm
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Resource.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ProgramsTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SurfaceDrawContextTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrClipStackTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/SurfaceDrawContext.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/PinnedImageTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/PromiseImageTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SRGBReadWritePixelsTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Texture.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mock/GrMockGpu.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Surface_Graphite.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SkSLTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrTextBlobTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/SurfaceDrawContext.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/vk/GrVkBuffer.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/dawn/GrDawnGpu.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/VkHardwareBufferTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/image/SkImage_GpuYUVA.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/include/core/SkSurface.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/core/SkBlurMF.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ImageFilterTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/dawn/DawnResourceProvider.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrContextOOM.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tools/skottie2movie.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/Device.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrRenderTargetProxy.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/ComputePipeline.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/ResourceProvider.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/image_pict.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SurfaceTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/image/SkImage_GpuBase.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/BulkRectTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ShaderImageFilterTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SkRemoteGlyphCacheTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/gl/GrGLTexture.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/graphite/GraphiteResourceCacheTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/skbug_12212.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/VkYcbcrSamplerTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/include/core/SkImage.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/d3d/GrD3DTexture.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/vk/VulkanTexture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/vk/GrVkGpu.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/d3d/GrD3DGpu.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/core/SkGpuBlurUtils.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/ResourceProvider.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/docs/examples/Surface_MakeRenderTarget_2.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/LazyProxyTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrDDLImageTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/ops/LatticeOp.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GpuDrawPathTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrSurfaceProxy.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrResourceProvider.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/SkGr.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/LazyStencilAttachmentTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/vk/GrVkTexture.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TraceMemoryDumpTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mtl/GrMtlGpu.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/imagemasksubset.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/ResourceCache.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrPipelineDynamicStateTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Device.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/simple_magnification.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/vk/GrVkGpu.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/gl/GrGLBuffer.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/gl/GrGLAttachment.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TestUtils.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/gl/GrGLTextureRenderTarget.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrTextureRenderTargetProxy.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/SkGr.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/gl/GrGLTexture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/ClipStack.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrTextureMipMapInvalidationTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/bench/nanobench.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ProxyConversionTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gn/gpu.gni
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/imagefromyuvtextures.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/bench/GrMipmapBench.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrThreadSafeCache.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/WritePixelsTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/vk/GrVkTextureRenderTarget.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/image/SkSurface_Gpu.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TextBlobCacheTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ResourceAllocatorTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SkSLCross.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/public.bzl
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/d3d/GrD3DBuffer.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Surface_Graphite.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/MatrixColorFilterTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ClearTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrSubmittedFlushTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/docs/examples/Surface_MakeRenderTarget.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mtl/GrMtlGpu.mm
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/WrappedSurfaceCopyOnWriteTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Image_Graphite.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/d3d/GrD3DTextureRenderTarget.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tools/gpu/YUVUtils.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrSurfaceProxyView.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/graphite/TextureProxyTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SkRuntimeEffectTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Recording.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/vk/GrVkImage.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/image/SkSurface.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/DeferredDisplayListTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/SpecialImage_Graphite.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/vk/VulkanTexture.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/dawn/DawnTexture.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrGpuBufferTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/RuntimeBlendTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/TextureProxy.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mock/GrMockTexture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/dm/DMSrcSink.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/docs/examples/blur4444.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrGpuResource.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/anisotropic.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/TextureProxy.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/docs/examples/Surface_MakeRenderTarget_3.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/modules/skottie/src/SkottieTool.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/dawn/DawnTexture.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/modules/canvaskit/canvaskit_bindings.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/dftext.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/dftext_blob_persp.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mock/GrMockBuffer.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrProxyProvider.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/DrawAtlas.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/GrSurfaceTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/core/SkRuntimeEffect.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/example/VulkanBasic.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tools/fiddle/fiddle_main.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/docs/examples/Surface_characterize.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/BUILD.bazel
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/Resource.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/mtl/MtlBlitCommandEncoder.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrRecordingContextPriv.h
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/fuzz/FuzzCanvas.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrDrawOpAtlas.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tools/skiaserve/Request.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/bench/GrResourceCacheBench.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/core/SkImageFilter.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrResourceProvider.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/CompressedBackendAllocationTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/ProcessorTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/clear_swizzle.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/gm/discard.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SrcSrcOverBatchTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/GraphicsPipeline.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tools/viewer/TextureUploadSlide.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/graphite/TextureUtils.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/TextureBindingsResetTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/VkDrawableTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/RELEASE_NOTES.txt
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/effects/imagefilters/SkAlphaThresholdImageFilter.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/GrSurfaceProxy.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/gl/GrGLGpu.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/tests/SurfaceSemaphoreTest.cpp
[modify] https://crrev.com/ecd3a2f865baebb829bdcc37224d1f02e5715e48/src/gpu/ganesh/mock/GrMockAttachment.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #18
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/19936eb1b23fef5187b07fb2e0e67dcf605c0672
commit 19936eb1b23fef5187b07fb2e0e67dcf605c0672
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jan 05 14:00:37 2023
[base] Move some files from include/private to include/private/base
These ones were arbitrarily chosen among files that did not have
any dependencies on include/core:
include/private/SingleOwner.h
include/private/SkDeque.h
include/private/SkMalloc.h
include/private/SkMutex.h
include/private/SkOnce.h
include/private/SkSemaphore.h
include/private/SkStringView.h
include/private/SkTFitsIn.h
include/private/SkThreadAnnotations.h
include/private/SkThreadID.h
include/private/SkTo.h
Change-Id: I32b945b459922e39e3e40c9f4af134b269d4958a
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/626078
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFDocumentPriv.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/effects/imagefilters/SkBlurImageFilter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/graphite/ResourceCache.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkWbmpCodec.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontConfigInterface_direct.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/skpinfo.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/TextBlobTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkIcoCodec.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkFont_serial.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkMemory_malloc.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkTypeface_mac_ct.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkIntersections.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/SkSLString.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/CodecTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPixmap.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkSpinlock.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkTypeface_mac_ct.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skparagraph/src/ParagraphImpl.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkArenaAlloc.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkMaskGamma.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkPathOpsQuad.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/win/SkDWriteFontFileStream.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkTypeface.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skparagraph/src/Run.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkColorTable.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFDocument.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/GrMeshTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/DataRefTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/ir/SkSLVariable.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkBigPicture.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkString.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/GrThreadSafeCacheTest.cpp
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkMutex.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFTypes.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkPath.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkTSort.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkSpan.h
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkThreadID.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkShadowUtils.cpp
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkStringView.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/SkSLErrorReporter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/AAClipTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkOpBuilder.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/fonts/TestSVGTypeface.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkPolyUtils.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/jetski/src/Image.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skottie/src/effects/SkSLEffect.cpp
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkMalloc.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/effects/imagefilters/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkPathOpsWinding.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/svg/SkSVGCanvas.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkPathOpsTSect.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkMemory_mozalloc.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/ir/SkSLFunctionCall.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/fonts/ToolUtilsFont.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/YUVTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/gpu/graphite/Recorder.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkTypefaceCache.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/FontTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontConfigInterface.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkScalerContext_mac_ct.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkPathBuilder.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkBlockAllocator.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkDescriptor.cpp
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkDeque.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkUTF.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkTInternalLList.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkCpu.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkImageFilterCache.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/PDFDeflateWStreamTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkColorSpace.h
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkSemaphore.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/EncodeTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkParse.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrDeferredProxyUploader.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkFDot6.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkClipStack.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkOverdrawCanvas.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkContainers.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkPixelRef.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkDashPath.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/ops/TextureOp.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/xml/SkXMLWriter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/skslc/ProcessWorklist.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/GrClipStackTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontMgr_mac_ct.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/NdkEncodeTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkPatchUtils.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/BUILD.bazel
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/debugger/DrawCommand.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkBlitter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkSemaphore.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkOSFile_win.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/dm/DMJsonWriter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkMallocPixelRef.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkStroke.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkFontMetrics.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/bench/MutexBench.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkBlurMask.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/ImageFilterTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/gm/tallstretchedbitmaps.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/Device.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrManagedResource.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkScan_Antihair.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ResourceKey.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skunicode/src/SkUnicode_icu.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkData.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skshaper/src/SkShaper_primitive.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/SkRemoteGlyphCacheTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/GrStyledShapeTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/xml/SkXMLParser.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/sksg/tests/SGTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/codegen/SkSLMetalCodeGenerator.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkRegionPriv.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkEdge.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkScalerContext.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/SVGDeviceTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkPaint.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/SkSpinlock.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/mac/SkCreateCGImageRef.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPicture.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/vk/GrVkGpu.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPaint.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skresources/include/SkResources.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkScan_AntiPath.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/gradients/GrGradientBitmapCache.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkImageInfo.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/ClipStackTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/mtl/GrMtlUtil.mm
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/gm/blurrect.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkZip.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/transform/SkSLEliminateDeadGlobalVariables.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/SkColorData.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkParseEncodedOrigin.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkVertices.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skshaper/src/SkShaper.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/RasterPipelineBuilderTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontHost_FreeType_common.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkCanvas.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkPathOpsDebug.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/gn/gpu.gni
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkGeometry.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/PathOpsThreeWayTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/gpu/gl/glx/CreatePlatformGLTestContext_glx.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/transform/SkSLRenamePrivateSymbols.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/sksl-minify/SkSLMinify.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkBitmapProcState_matrixProcs.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkStroke.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/TextBlobCacheTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/ResourceAllocatorTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkYUVAPixmaps.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkMask.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/trace/ChromeTracingTracer.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkClusterator.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/gn/core.gni
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/PDFPrimitivesTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkJpegxlCodec.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/skslc/Main.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkDraw.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkWriter32.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/gradients/GrGradientBitmapCache.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/BUILD.bazel
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPictureRecord.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/graphite/QueueManager.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrSurfaceProxyView.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkSharedMutex.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkMessageBus.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/MipMapTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontHost_win.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFBitmap.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkScalerCache.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/VkWrapTests.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkStream.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkWriter32.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/mac/SkCTFont.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkBitSet.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/codegen/SkSLGLSLCodeGenerator.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkScalerContext_win_dw.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/gm/lattice.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/CachedDataTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/codegen/SkSLRasterPipelineCodeGenerator.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/MatrixTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkAnalyticEdge.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrProxyProvider.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkArenaAlloc.h
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkTFitsIn.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skparagraph/include/ParagraphCache.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/win/SkWGL_win.cpp
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkOnce.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/GrSurfaceTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/BUILD.bazel
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkJpegInfo.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkRemotableFontMgr_win_dw.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/RectanizerPow2.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/effects/SkRuntimeEffect.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/fuzz/FuzzCanvas.cpp
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkTo.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrResourceProvider.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkImageEncoder_NDK.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkCachedData.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/SkIDChangeListener.h
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SingleOwner.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/bazel/exporter_tool/main.go
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkGlyph.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/gl/GrGLGpu.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkEdge.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkMatrix.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/d3d/GrD3DGpu.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkRawCodec.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkFont.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPictureRecord.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/xml/SkDOM.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/effects/GrPorterDuffXferProcessor.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/ImageTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/graphite/dawn/DawnTestContext.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/particles/src/SkParticleEffect.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFTypes.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/vk/GrVkResourceProvider.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/codegen/SkSLVMCodeGenerator.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkRect.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkDataTable.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/SkSLOperator.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skunicode/src/SkUnicode_client.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/DequeTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPixelRef.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/SkTDArray.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkWuffsCodec.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/SkSLMangler.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/MaskCacheTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/gm/image.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPathRef.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkStream.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrResourceCache.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/SkTemplates.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFMakeCIDGlyphWidthsArray.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkPathOpsOp.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/CrashHandler.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/StreamTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkRasterPipelineBlitter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFMakeToUnicodeCmap.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/xps/SkXPSDevice.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/skqp/src/jni_skqp.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/lazy/SkDiscardableMemoryPool.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/ExtendedSkColorTypeTests.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/SkRasterPipelineTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkGlobalInitialization_core.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrCaps.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/RRectInPathTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrRenderTargetProxy.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkTSearch.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/SkScalerCacheTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/SkSLIntrinsicList.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkAnalyticEdge.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/image/SkImage_Lazy.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkTypeface_win_dw.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/effects/SkDashPathEffect.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkDeque.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/effects/SkTableColorFilter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkBmpBaseCodec.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontMgr_FontConfigInterface.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkSurfaceProps.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/svg/src/SkSVGRenderContext.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFGraphicState.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/TestUtils.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/fuzz/Fuzz.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkAAClip.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkSafeMath.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/experimental/sktext/include/Types.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skottie/src/Skottie.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkAlphaRuns.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/lazy/SkDiscardableMemoryPool.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/ProxyTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/gpu/GrTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/ops/SoftwarePathRenderer.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFMetadata.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkAutoPixmapStorage.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkLineClipper.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/win/SkDWriteFontFileStream.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/RecorderTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkOpCoincidence.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkCanvasStateUtils.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/effects/SkEmbossMask.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/FontMgrTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/PathTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkCanvas.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/bench/PDFBench.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkCachedData.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/gpu/ganesh/GrImageContext.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkFontMgr.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/SkPathRef.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/fonts/SkFontMgr_indirect.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/svg/src/SkSVGDOM.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/trace/EventTracingPriv.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkMalloc.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFFont.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkMatrix.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/SerializationTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontHost_FreeType.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkResourceCache.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/ir/SkSLType.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/gm/texteffects.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkExecutor.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/AtlasTypes.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrProgramDesc.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkMultiPictureDocument.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skshaper/src/SkShaper_harfbuzz.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkEventTracer.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/PDFGlyphsToUnicodeTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkAutoMalloc.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/SkStringViewTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkString.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/AtlasTypes.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/graphite/ResourceTypes.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrSamplerState.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkCharToGlyphCache.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPath.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/SurfaceTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkOSFile_posix.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrBackendTextureImageGenerator.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkScan_AAAPath.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/SkSLModuleLoader.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/text/gpu/SubRunContainer.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkTime.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/sk_app/android/surface_glue_android.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/viewer/ParticlesSlide.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFSubsetFont.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skparagraph/src/TextLine.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkCustomTypeface.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/fonts/SkRemotableFontMgr.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/fonts/TestTypeface.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkRegion_path.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/ir/SkSLConstructorStruct.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/SkMetaData.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkTDArray.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/OverAlignedTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrSurfaceProxy.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFType1Font.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/FitsInTest.cpp
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkThreadAnnotations.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/mtl/GrMtlGpu.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/SkBase64Test.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/graphite/ResourceCache.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skparagraph/tests/SkShaperJSONWriter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkPathOpsCubic.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPictureData.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/debugger/DebugCanvas.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontMgr_fuchsia.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/PathOpsExtendedTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkJpegCodec.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkJSON.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontMgr_win_dw.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skshaper/tests/ShaperTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/codegen/SkSLRasterPipelineBuilder.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/effects/SkOpPathEffect.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/gm/imagefromyuvtextures.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/SkTLogic.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/gpu/GrTypes.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkDeflate.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/WritePixelsTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/EmptyPathTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/Time.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/SkTArray.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/gpu/graphite/Context.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/public.bzl
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/win/SkDWrite.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkMipmap.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkDevice.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrProgramDesc.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkWebpCodec.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/viewer/Viewer.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkEdgeBuilder.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/opts/SkRasterPipeline_opts.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontConfigInterface_direct_factory.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/OnceTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkWriteBuffer.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkBmpRLECodec.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkBuffer.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkTBlockList.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkBitmap.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkRegion.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/effects/imagefilters/SkDropShadowImageFilter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkAntiRun.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/graphite/TextureProxy.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/MemoryTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkThreadID.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sfnt/SkOTUtils.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/viewer/PathClipSlide.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/BitmapTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkColorPriv.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkSharedMutex.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/CanvasTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkTypeface.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPath_serial.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/gm/dftext.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/ir/SkSLFunctionDeclaration.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skparagraph/src/ParagraphImpl.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkIPoint16.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkMaskBlurFilter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkRecorder.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skplaintexteditor/src/shape.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkXfermode.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontMgr_android_parser.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkVM.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkMD5.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkOpts.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkRuntimeEffect.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/ScalarTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/graphite/ShaderCodeDictionary.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/canvaskit/WasmCommon.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkStrikeCache.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontHost_FreeType_common.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/graphite/Resource.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/ShadowTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontMgr_fontconfig.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/ports/SkFontMgr_indirect.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/GradientTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkBlitter.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkPathOpsCubic.cpp
https://skia.googlesource.com/skia/+/19936eb1b23fef5187b07fb2e0e67dcf605c0672
commit 19936eb1b23fef5187b07fb2e0e67dcf605c0672
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jan 05 14:00:37 2023
[base] Move some files from include/private to include/private/base
These ones were arbitrarily chosen among files that did not have
any dependencies on include/core:
include/private/SingleOwner.h
include/private/SkDeque.h
include/private/SkMalloc.h
include/private/SkMutex.h
include/private/SkOnce.h
include/private/SkSemaphore.h
include/private/SkStringView.h
include/private/SkTFitsIn.h
include/private/SkThreadAnnotations.h
include/private/SkThreadID.h
include/private/SkTo.h
Change-Id: I32b945b459922e39e3e40c9f4af134b269d4958a
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/626078
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFDocumentPriv.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/effects/imagefilters/SkBlurImageFilter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/graphite/ResourceCache.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkWbmpCodec.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontConfigInterface_direct.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/skpinfo.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/TextBlobTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkIcoCodec.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkFont_serial.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkMemory_malloc.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkTypeface_mac_ct.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkIntersections.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/SkSLString.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/CodecTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPixmap.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkSpinlock.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkTypeface_mac_ct.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skparagraph/src/ParagraphImpl.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkArenaAlloc.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkMaskGamma.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkPathOpsQuad.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/win/SkDWriteFontFileStream.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkTypeface.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skparagraph/src/Run.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkColorTable.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFDocument.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/GrMeshTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/DataRefTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/ir/SkSLVariable.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkBigPicture.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkString.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/GrThreadSafeCacheTest.cpp
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkMutex.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFTypes.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkPath.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkTSort.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkSpan.h
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkThreadID.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkShadowUtils.cpp
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkStringView.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/SkSLErrorReporter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/AAClipTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkOpBuilder.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/fonts/TestSVGTypeface.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkPolyUtils.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/jetski/src/Image.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skottie/src/effects/SkSLEffect.cpp
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkMalloc.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/effects/imagefilters/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkPathOpsWinding.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/svg/SkSVGCanvas.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkPathOpsTSect.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkMemory_mozalloc.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/ir/SkSLFunctionCall.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/fonts/ToolUtilsFont.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/YUVTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/gpu/graphite/Recorder.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkTypefaceCache.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/FontTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontConfigInterface.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkScalerContext_mac_ct.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkPathBuilder.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkBlockAllocator.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkDescriptor.cpp
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkDeque.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkUTF.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkTInternalLList.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkCpu.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkImageFilterCache.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/PDFDeflateWStreamTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkColorSpace.h
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkSemaphore.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/EncodeTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkParse.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrDeferredProxyUploader.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkFDot6.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkClipStack.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkOverdrawCanvas.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkContainers.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkPixelRef.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkDashPath.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/ops/TextureOp.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/xml/SkXMLWriter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/skslc/ProcessWorklist.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/GrClipStackTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontMgr_mac_ct.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/NdkEncodeTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkPatchUtils.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/BUILD.bazel
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/debugger/DrawCommand.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkBlitter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkSemaphore.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkOSFile_win.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/dm/DMJsonWriter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkMallocPixelRef.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkStroke.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkFontMetrics.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/bench/MutexBench.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkBlurMask.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/ImageFilterTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/gm/tallstretchedbitmaps.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/Device.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrManagedResource.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkScan_Antihair.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ResourceKey.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skunicode/src/SkUnicode_icu.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkData.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skshaper/src/SkShaper_primitive.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/SkRemoteGlyphCacheTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/GrStyledShapeTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/xml/SkXMLParser.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/sksg/tests/SGTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/codegen/SkSLMetalCodeGenerator.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkRegionPriv.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkEdge.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkScalerContext.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/SVGDeviceTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkPaint.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/SkSpinlock.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/mac/SkCreateCGImageRef.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPicture.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/vk/GrVkGpu.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPaint.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skresources/include/SkResources.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkScan_AntiPath.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/gradients/GrGradientBitmapCache.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkImageInfo.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/ClipStackTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/mtl/GrMtlUtil.mm
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/gm/blurrect.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkZip.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/transform/SkSLEliminateDeadGlobalVariables.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/SkColorData.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkParseEncodedOrigin.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkVertices.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skshaper/src/SkShaper.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/RasterPipelineBuilderTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontHost_FreeType_common.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkCanvas.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkPathOpsDebug.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/gn/gpu.gni
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkGeometry.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/PathOpsThreeWayTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/gpu/gl/glx/CreatePlatformGLTestContext_glx.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/transform/SkSLRenamePrivateSymbols.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/sksl-minify/SkSLMinify.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkBitmapProcState_matrixProcs.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkStroke.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/TextBlobCacheTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/ResourceAllocatorTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkYUVAPixmaps.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkMask.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/trace/ChromeTracingTracer.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkClusterator.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/gn/core.gni
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/PDFPrimitivesTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkJpegxlCodec.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/skslc/Main.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkDraw.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkWriter32.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/gradients/GrGradientBitmapCache.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/BUILD.bazel
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPictureRecord.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/graphite/QueueManager.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrSurfaceProxyView.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkSharedMutex.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkMessageBus.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/MipMapTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontHost_win.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFBitmap.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkScalerCache.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/VkWrapTests.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkStream.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkWriter32.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/mac/SkCTFont.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkBitSet.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/codegen/SkSLGLSLCodeGenerator.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkScalerContext_win_dw.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/gm/lattice.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/CachedDataTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/codegen/SkSLRasterPipelineCodeGenerator.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/MatrixTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkAnalyticEdge.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrProxyProvider.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkArenaAlloc.h
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkTFitsIn.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skparagraph/include/ParagraphCache.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/win/SkWGL_win.cpp
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkOnce.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/GrSurfaceTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/BUILD.bazel
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkJpegInfo.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkRemotableFontMgr_win_dw.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/RectanizerPow2.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/effects/SkRuntimeEffect.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/fuzz/FuzzCanvas.cpp
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkTo.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrResourceProvider.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkImageEncoder_NDK.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkCachedData.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/SkIDChangeListener.h
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SingleOwner.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/bazel/exporter_tool/main.go
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkGlyph.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/gl/GrGLGpu.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkEdge.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkMatrix.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/d3d/GrD3DGpu.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkRawCodec.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkFont.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPictureRecord.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/xml/SkDOM.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/effects/GrPorterDuffXferProcessor.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/ImageTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/graphite/dawn/DawnTestContext.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/particles/src/SkParticleEffect.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFTypes.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/vk/GrVkResourceProvider.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/codegen/SkSLVMCodeGenerator.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkRect.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkDataTable.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/SkSLOperator.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skunicode/src/SkUnicode_client.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/DequeTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPixelRef.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/SkTDArray.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkWuffsCodec.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/SkSLMangler.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/MaskCacheTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/gm/image.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPathRef.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkStream.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrResourceCache.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/SkTemplates.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFMakeCIDGlyphWidthsArray.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkPathOpsOp.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/CrashHandler.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/StreamTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkRasterPipelineBlitter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFMakeToUnicodeCmap.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/xps/SkXPSDevice.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/skqp/src/jni_skqp.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/lazy/SkDiscardableMemoryPool.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/ExtendedSkColorTypeTests.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/SkRasterPipelineTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkGlobalInitialization_core.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrCaps.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/RRectInPathTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrRenderTargetProxy.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkTSearch.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/SkScalerCacheTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/SkSLIntrinsicList.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkAnalyticEdge.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/image/SkImage_Lazy.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkTypeface_win_dw.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/effects/SkDashPathEffect.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkDeque.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/effects/SkTableColorFilter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkBmpBaseCodec.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontMgr_FontConfigInterface.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkSurfaceProps.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/svg/src/SkSVGRenderContext.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFGraphicState.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/TestUtils.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/fuzz/Fuzz.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkAAClip.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkSafeMath.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/experimental/sktext/include/Types.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skottie/src/Skottie.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkAlphaRuns.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/lazy/SkDiscardableMemoryPool.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/ProxyTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/gpu/GrTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/ops/SoftwarePathRenderer.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFMetadata.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkAutoPixmapStorage.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkLineClipper.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/win/SkDWriteFontFileStream.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/RecorderTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkOpCoincidence.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkCanvasStateUtils.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/effects/SkEmbossMask.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/FontMgrTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/PathTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkCanvas.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/bench/PDFBench.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkCachedData.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/gpu/ganesh/GrImageContext.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkFontMgr.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/SkPathRef.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/fonts/SkFontMgr_indirect.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/svg/src/SkSVGDOM.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/trace/EventTracingPriv.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkMalloc.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFFont.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkMatrix.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/SerializationTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontHost_FreeType.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkResourceCache.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/ir/SkSLType.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/gm/texteffects.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkExecutor.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/AtlasTypes.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrProgramDesc.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkMultiPictureDocument.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skshaper/src/SkShaper_harfbuzz.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkEventTracer.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/PDFGlyphsToUnicodeTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkAutoMalloc.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/SkStringViewTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkString.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/AtlasTypes.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/graphite/ResourceTypes.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrSamplerState.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkCharToGlyphCache.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPath.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/SurfaceTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkOSFile_posix.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrBackendTextureImageGenerator.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkScan_AAAPath.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/SkSLModuleLoader.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/text/gpu/SubRunContainer.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkTime.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/sk_app/android/surface_glue_android.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/viewer/ParticlesSlide.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFSubsetFont.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skparagraph/src/TextLine.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkCustomTypeface.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/fonts/SkRemotableFontMgr.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/fonts/TestTypeface.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkRegion_path.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/ir/SkSLConstructorStruct.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/SkMetaData.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkTDArray.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/OverAlignedTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrSurfaceProxy.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkPDFType1Font.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/FitsInTest.cpp
[rename] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/base/SkThreadAnnotations.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/mtl/GrMtlGpu.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/SkBase64Test.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/graphite/ResourceCache.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skparagraph/tests/SkShaperJSONWriter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkPathOpsCubic.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPictureData.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/debugger/DebugCanvas.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontMgr_fuchsia.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/PathOpsExtendedTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkJpegCodec.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/SkJSON.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontMgr_win_dw.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skshaper/tests/ShaperTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/codegen/SkSLRasterPipelineBuilder.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/effects/SkOpPathEffect.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/gm/imagefromyuvtextures.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/SkTLogic.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/gpu/GrTypes.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pdf/SkDeflate.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/WritePixelsTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/EmptyPathTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/Time.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/private/SkTArray.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/gpu/graphite/Context.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/public.bzl
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/utils/win/SkDWrite.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkMipmap.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkDevice.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/ganesh/GrProgramDesc.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkWebpCodec.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/viewer/Viewer.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkEdgeBuilder.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/opts/SkRasterPipeline_opts.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontConfigInterface_direct_factory.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/OnceTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkWriteBuffer.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/codec/SkBmpRLECodec.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkBuffer.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkTBlockList.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkBitmap.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkRegion.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/effects/imagefilters/SkDropShadowImageFilter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkAntiRun.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/graphite/TextureProxy.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/MemoryTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkThreadID.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sfnt/SkOTUtils.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tools/viewer/PathClipSlide.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/BitmapTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkColorPriv.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkSharedMutex.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/CanvasTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/core/SkTypeface.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkPath_serial.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/gm/dftext.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/sksl/ir/SkSLFunctionDeclaration.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skparagraph/src/ParagraphImpl.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkIPoint16.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkMaskBlurFilter.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkRecorder.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/skplaintexteditor/src/shape.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkXfermode.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontMgr_android_parser.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkVM.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkMD5.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkOpts.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkRuntimeEffect.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/ScalarTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/graphite/ShaderCodeDictionary.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/modules/canvaskit/WasmCommon.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkStrikeCache.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontHost_FreeType_common.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/gpu/graphite/Resource.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/ShadowTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/ports/SkFontMgr_fontconfig.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/include/ports/SkFontMgr_indirect.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/tests/GradientTest.cpp
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/core/SkBlitter.h
[modify] https://crrev.com/19936eb1b23fef5187b07fb2e0e67dcf605c0672/src/pathops/SkPathOpsCubic.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #19
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/78421a344944a545c27bcd060cd27f143850c35a
commit 78421a344944a545c27bcd060cd27f143850c35a
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jan 05 20:26:37 2023
SkBudgeted -> skgpu:Budgeted
This enum was moved in https://skia-review.googlesource.com/c/skia/+/621977
Bug: skia:13983
Change-Id: I712e52ce1d8bdef0f9dff023ed44f1b7b33265f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4138958
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1089416}
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/chrome/browser/vr/cmd_buffer_surface_provider.cc
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/components/viz/test/fake_skia_output_surface.cc
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/ui/gfx/color_conversion_sk_filter_cache.cc
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/chrome/browser/vr/native_gl_surface_provider.cc
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/cc/paint/paint_op_buffer_fuzzer.cc
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/cc/tiles/gpu_image_decode_cache_perftest.cc
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/cc/paint/image_transfer_cache_entry.cc
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/content/browser/gpu/gpu_ipc_browsertests.cc
https://chromium.googlesource.com/chromium/src/+/78421a344944a545c27bcd060cd27f143850c35a
commit 78421a344944a545c27bcd060cd27f143850c35a
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jan 05 20:26:37 2023
SkBudgeted -> skgpu:Budgeted
This enum was moved in https://skia-review.googlesource.com/c/skia/+/621977
Bug: skia:13983
Change-Id: I712e52ce1d8bdef0f9dff023ed44f1b7b33265f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4138958
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1089416}
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/chrome/browser/vr/cmd_buffer_surface_provider.cc
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/components/viz/test/fake_skia_output_surface.cc
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/ui/gfx/color_conversion_sk_filter_cache.cc
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/chrome/browser/vr/native_gl_surface_provider.cc
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/cc/paint/paint_op_buffer_fuzzer.cc
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/cc/tiles/gpu_image_decode_cache_perftest.cc
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/cc/paint/image_transfer_cache_entry.cc
[modify] https://crrev.com/78421a344944a545c27bcd060cd27f143850c35a/content/browser/gpu/gpu_ipc_browsertests.cc
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #20
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0
commit 49da12b49cbae3dd1ea9f797e3f5a0d646da94e0
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Jan 09 15:42:03 2023
Move SkStringView from include/private/base into src/base
src/base is where files that we want to be used in the
base package (i.e. minimal deps and used in many parts of Skia)
which are not used by the public API can go.
Change-Id: Idf781f7cc24ab8aa05004c099cea53d65484b1c0
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/627696
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/SkSLIntrinsicList.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/gn/core.gni
[add] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/base/README.md
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/SkSLMangler.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/tools/skslc/Main.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/ir/SkSLFunctionDeclaration.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/codegen/SkSLRasterPipelineCodeGenerator.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/transform/SkSLEliminateDeadGlobalVariables.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/SkSLErrorReporter.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/include/BUILD.bazel
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/include/private/base/README.md
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/SkSLString.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/tools/skslc/ProcessWorklist.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/tools/viewer/ParticlesSlide.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/tests/RasterPipelineBuilderTest.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/include/private/base/BUILD.bazel
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/codegen/SkSLVMCodeGenerator.cpp
[rename] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/base/SkStringView.h
[add] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/base/BUILD.bazel
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/SkSLOperator.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/transform/SkSLRenamePrivateSymbols.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/tools/sksl-minify/SkSLMinify.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/ir/SkSLVariable.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/tests/SkStringViewTest.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/bazel/exporter_tool/main.go
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/BUILD.bazel
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/public.bzl
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/codegen/SkSLGLSLCodeGenerator.cpp
https://skia.googlesource.com/skia/+/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0
commit 49da12b49cbae3dd1ea9f797e3f5a0d646da94e0
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Jan 09 15:42:03 2023
Move SkStringView from include/private/base into src/base
src/base is where files that we want to be used in the
base package (i.e. minimal deps and used in many parts of Skia)
which are not used by the public API can go.
Change-Id: Idf781f7cc24ab8aa05004c099cea53d65484b1c0
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/627696
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/SkSLIntrinsicList.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/gn/core.gni
[add] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/base/README.md
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/SkSLMangler.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/tools/skslc/Main.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/ir/SkSLFunctionDeclaration.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/codegen/SkSLRasterPipelineCodeGenerator.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/transform/SkSLEliminateDeadGlobalVariables.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/SkSLErrorReporter.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/include/BUILD.bazel
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/include/private/base/README.md
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/SkSLString.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/tools/skslc/ProcessWorklist.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/tools/viewer/ParticlesSlide.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/tests/RasterPipelineBuilderTest.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/include/private/base/BUILD.bazel
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/codegen/SkSLVMCodeGenerator.cpp
[rename] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/base/SkStringView.h
[add] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/base/BUILD.bazel
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/SkSLOperator.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/transform/SkSLRenamePrivateSymbols.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/tools/sksl-minify/SkSLMinify.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/ir/SkSLVariable.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/tests/SkStringViewTest.cpp
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/bazel/exporter_tool/main.go
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/BUILD.bazel
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/public.bzl
[modify] https://crrev.com/49da12b49cbae3dd1ea9f797e3f5a0d646da94e0/src/sksl/codegen/SkSLGLSLCodeGenerator.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #21
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/c383f4309d84176793759f3068d549d8f52330be
commit c383f4309d84176793759f3068d549d8f52330be
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Jan 09 16:09:05 2023
Add tests for solving cubic roots with double precision.
In order to break the SkPath -> pathops dependency that currently
exist, we'll need to extract the logic to do that. One thing
that will need to be extracted is the ability to solve cubic
functions (e.g. Ax^3 + Bx^2 + Cx + D = 0) which is used to
chop cubics for perspective matrices.
No direct tests for the existing logic in PathOps exists,
so this adds some, including tests for solving quadratics
because the current cubic root finding logic falls back
to the quadratic methods if A == 0.
There does not appear to be existing logic (outside of pathops)
for determining if doubles are close enough, so this adds some
(and a few tests). The double comparison added is only what
was necessary to write tests, not a general purpose comparison
(which is tricky) [1].
[1] https://randomascii.wordpress.com/2012/02/25/comparing-floating-point-numbers-2012-edition/
Change-Id: I8b072f590027b43c4e7c2e2e2f9e28043b177b55
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/627018
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/gn/tests.gni
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/gn/core.gni
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/include/private/SkFloatingPoint.h
[add] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/tests/CubicRootsTest.cpp
[add] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/tests/QuadRootsTest.cpp
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/src/core/BUILD.bazel
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/tests/BUILD.bazel
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/public.bzl
[add] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/src/core/SkFloatingPoint.cpp
[add] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/tests/FloatingPointTest.cpp
https://skia.googlesource.com/skia/+/c383f4309d84176793759f3068d549d8f52330be
commit c383f4309d84176793759f3068d549d8f52330be
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Jan 09 16:09:05 2023
Add tests for solving cubic roots with double precision.
In order to break the SkPath -> pathops dependency that currently
exist, we'll need to extract the logic to do that. One thing
that will need to be extracted is the ability to solve cubic
functions (e.g. Ax^3 + Bx^2 + Cx + D = 0) which is used to
chop cubics for perspective matrices.
No direct tests for the existing logic in PathOps exists,
so this adds some, including tests for solving quadratics
because the current cubic root finding logic falls back
to the quadratic methods if A == 0.
There does not appear to be existing logic (outside of pathops)
for determining if doubles are close enough, so this adds some
(and a few tests). The double comparison added is only what
was necessary to write tests, not a general purpose comparison
(which is tricky) [1].
[1] https://randomascii.wordpress.com/2012/02/25/comparing-floating-point-numbers-2012-edition/
Change-Id: I8b072f590027b43c4e7c2e2e2f9e28043b177b55
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/627018
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/gn/tests.gni
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/gn/core.gni
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/include/private/SkFloatingPoint.h
[add] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/tests/CubicRootsTest.cpp
[add] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/tests/QuadRootsTest.cpp
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/src/core/BUILD.bazel
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/tests/BUILD.bazel
[modify] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/public.bzl
[add] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/src/core/SkFloatingPoint.cpp
[add] https://crrev.com/c383f4309d84176793759f3068d549d8f52330be/tests/FloatingPointTest.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #22
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/c13c6e7083dbb3323634a21e7609467dbc764efc
commit c13c6e7083dbb3323634a21e7609467dbc764efc
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 10 13:37:50 2023
Fix input and output of SaveLayerRestore_DrawColor test
The "original" color in this CL had incorrectly flipped the
arguments to SkColorSetA. By not using a constant value
for the expected_alpha/color, the unexpected behavior was not
noticed.
This also removes the one usage in Chrome of SkMulDiv255Round, which
Skia plans to remove from the public API.
Bug: skia:13983
Change-Id: I89b7cde9566a0c8281804f433310ec51a58dc433
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4148388
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1090784}
[modify] https://crrev.com/c13c6e7083dbb3323634a21e7609467dbc764efc/cc/paint/paint_op_buffer_unittest.cc
https://chromium.googlesource.com/chromium/src/+/c13c6e7083dbb3323634a21e7609467dbc764efc
commit c13c6e7083dbb3323634a21e7609467dbc764efc
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 10 13:37:50 2023
Fix input and output of SaveLayerRestore_DrawColor test
The "original" color in this CL had incorrectly flipped the
arguments to SkColorSetA. By not using a constant value
for the expected_alpha/color, the unexpected behavior was not
noticed.
This also removes the one usage in Chrome of SkMulDiv255Round, which
Skia plans to remove from the public API.
Bug: skia:13983
Change-Id: I89b7cde9566a0c8281804f433310ec51a58dc433
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4148388
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1090784}
[modify] https://crrev.com/c13c6e7083dbb3323634a21e7609467dbc764efc/cc/paint/paint_op_buffer_unittest.cc
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #23
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a
commit 2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 10 16:24:38 2023
Break apart public and private gpu files in GN lists
In order to make Chrome's build of Skia gn check compliant,
we need to break apart a few of our gni file lists so some
files can be listed as "public" headers, instead of all
being grouped together in "sources".
https://chromium-review.googlesource.com/c/chromium/src/+/4089412
sketched out what changes were needed and this implements
those changes.
I'm not sure why the gpu.gni file re-alphabetized a bunch
of files (AFAIK, the gn binary version was not changed), but
as long as gn format is happy, I'm happy.
Bug: skia:12541, skia:13983
Change-Id: I95409479d8f066f7069f6aa5e1112dede233dd4f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/627988
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/gn/utils.gni
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/include/private/gpu/ganesh/BUILD.bazel
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/src/gpu/gl/BUILD.bazel
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/BUILD.gn
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/src/gpu/vk/BUILD.bazel
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/bazel/exporter_tool/main.go
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/bazel/exporter/gni_exporter.go
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/gn/gpu.gni
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/include/private/chromium/BUILD.bazel
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/include/gpu/vk/BUILD.bazel
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/src/utils/BUILD.bazel
https://skia.googlesource.com/skia/+/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a
commit 2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 10 16:24:38 2023
Break apart public and private gpu files in GN lists
In order to make Chrome's build of Skia gn check compliant,
we need to break apart a few of our gni file lists so some
files can be listed as "public" headers, instead of all
being grouped together in "sources".
https://chromium-review.googlesource.com/c/chromium/src/+/4089412
sketched out what changes were needed and this implements
those changes.
I'm not sure why the gpu.gni file re-alphabetized a bunch
of files (AFAIK, the gn binary version was not changed), but
as long as gn format is happy, I'm happy.
Bug: skia:12541, skia:13983
Change-Id: I95409479d8f066f7069f6aa5e1112dede233dd4f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/627988
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/gn/utils.gni
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/include/private/gpu/ganesh/BUILD.bazel
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/src/gpu/gl/BUILD.bazel
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/BUILD.gn
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/src/gpu/vk/BUILD.bazel
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/bazel/exporter_tool/main.go
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/bazel/exporter/gni_exporter.go
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/gn/gpu.gni
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/include/private/chromium/BUILD.bazel
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/include/gpu/vk/BUILD.bazel
[modify] https://crrev.com/2c5c6ca7b17d9fc3e0081965ac283d0cb0d6558a/src/utils/BUILD.bazel
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #24
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e
commit 6c113cb8d7f92c08eb933f18bea5cc2f85ac286e
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 10 18:33:29 2023
Add gni file list for Skia codecs used by Chromium
Chromium [1] currently has a hard-coded list of sources
used for the implementation of certain codecs. This
is potentially brittle, so this change starts to introduce
some gni lists that could be used.
It is a little harder to use gn file lists like this
for Skia because GN complains if the same source file
is included multiple times (but Bazel, the source of
truth of these .gni lists, does not). I made two file
lists to slightly reduce the hard coded files in
skia/BUILD.gn as long as I was here.
In order to do this, I had to relax a constraint on
the gni_exporter tool. It would fail if the same file
was included more than once; I changed this to remove
duplicates. I also changed the file lists to be sorted
in a non-case-sensitive manner, as this is easier and
hopefully reduces churn when GN decides to (arbitrarily)
re-sort the list of files.
[1] https://source.chromium.org/chromium/chromium/src/+/main:skia/BUILD.gn;l=338;drc=f62bcc24c9aaff6ea3db5c870d813fb9c6449f04
Change-Id: Id25a7e9a018a5e2713fa91e3e0611515533afce9
Bug: skia:12541, skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/627989
Reviewed-by: Chris Mumford <cmumford@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/gn/sksl_tests.gni
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/gn/utils.gni
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/gn/core.gni
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/bazel/exporter/gni_exporter_test.go
[add] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/gn/codec.gni
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/BUILD.gn
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/modules/svg/svg.gni
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/bazel/exporter_tool/main.go
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/bazel/exporter/gni_exporter.go
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/gn/gpu.gni
https://skia.googlesource.com/skia/+/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e
commit 6c113cb8d7f92c08eb933f18bea5cc2f85ac286e
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 10 18:33:29 2023
Add gni file list for Skia codecs used by Chromium
Chromium [1] currently has a hard-coded list of sources
used for the implementation of certain codecs. This
is potentially brittle, so this change starts to introduce
some gni lists that could be used.
It is a little harder to use gn file lists like this
for Skia because GN complains if the same source file
is included multiple times (but Bazel, the source of
truth of these .gni lists, does not). I made two file
lists to slightly reduce the hard coded files in
skia/BUILD.gn as long as I was here.
In order to do this, I had to relax a constraint on
the gni_exporter tool. It would fail if the same file
was included more than once; I changed this to remove
duplicates. I also changed the file lists to be sorted
in a non-case-sensitive manner, as this is easier and
hopefully reduces churn when GN decides to (arbitrarily)
re-sort the list of files.
[1] https://source.chromium.org/chromium/chromium/src/+/main:skia/BUILD.gn;l=338;drc=f62bcc24c9aaff6ea3db5c870d813fb9c6449f04
Change-Id: Id25a7e9a018a5e2713fa91e3e0611515533afce9
Bug: skia:12541, skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/627989
Reviewed-by: Chris Mumford <cmumford@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/gn/sksl_tests.gni
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/gn/utils.gni
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/gn/core.gni
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/bazel/exporter/gni_exporter_test.go
[add] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/gn/codec.gni
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/BUILD.gn
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/modules/svg/svg.gni
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/bazel/exporter_tool/main.go
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/bazel/exporter/gni_exporter.go
[modify] https://crrev.com/6c113cb8d7f92c08eb933f18bea5cc2f85ac286e/gn/gpu.gni
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #25
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/cf0e6550bf157de22edd9923bb7876cd52a24ee8
commit cf0e6550bf157de22edd9923bb7876cd52a24ee8
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 11 13:43:40 2023
Break apart more gni file lists
The metal headers are used by Chromium and Flutter, the dawn ones
just by Chromium (it seems)
Change-Id: I1c3fb3224a5b8e638891f86cd71165a4e532c18f
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/628737
Reviewed-by: Herb Derby <herb@google.com>
[modify] https://crrev.com/cf0e6550bf157de22edd9923bb7876cd52a24ee8/gn/shared_sources.gni
[modify] https://crrev.com/cf0e6550bf157de22edd9923bb7876cd52a24ee8/BUILD.gn
[modify] https://crrev.com/cf0e6550bf157de22edd9923bb7876cd52a24ee8/bazel/exporter_tool/main.go
[modify] https://crrev.com/cf0e6550bf157de22edd9923bb7876cd52a24ee8/bazel/exporter/gni_exporter.go
[modify] https://crrev.com/cf0e6550bf157de22edd9923bb7876cd52a24ee8/gn/gpu.gni
https://skia.googlesource.com/skia/+/cf0e6550bf157de22edd9923bb7876cd52a24ee8
commit cf0e6550bf157de22edd9923bb7876cd52a24ee8
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 11 13:43:40 2023
Break apart more gni file lists
The metal headers are used by Chromium and Flutter, the dawn ones
just by Chromium (it seems)
Change-Id: I1c3fb3224a5b8e638891f86cd71165a4e532c18f
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/628737
Reviewed-by: Herb Derby <herb@google.com>
[modify] https://crrev.com/cf0e6550bf157de22edd9923bb7876cd52a24ee8/gn/shared_sources.gni
[modify] https://crrev.com/cf0e6550bf157de22edd9923bb7876cd52a24ee8/BUILD.gn
[modify] https://crrev.com/cf0e6550bf157de22edd9923bb7876cd52a24ee8/bazel/exporter_tool/main.go
[modify] https://crrev.com/cf0e6550bf157de22edd9923bb7876cd52a24ee8/bazel/exporter/gni_exporter.go
[modify] https://crrev.com/cf0e6550bf157de22edd9923bb7876cd52a24ee8/gn/gpu.gni
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #26
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/dfb838747295b9109343e6f536b25e9fa3fe933e
commit dfb838747295b9109343e6f536b25e9fa3fe933e
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 11 19:05:18 2023
Move two chromium-specific headers into i/p/chromium
Both SkDiscardableMemory.h and GrVkSecondaryCBDrawContext.h
are chromium specific. By moving them to this new location,
it will be easier to specify to Chromium's GN rule that
they are visible to chromium code.
I removed GrVkSecondaryCBDrawContext* from public.bzl
and into only Skia's test target to help enforce the
fact that non-Chromium clients shouldn't need to compile
this code.
Change-Id: I9005238e4691d37610274e5261cf030850d08cb8
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/628743
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/core/SkCachedData.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/gn/core.gni
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/gpu/ganesh/vk/GrVkSecondaryCBDrawContext.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/core/BUILD.bazel
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/include/private/chromium/BUILD.bazel
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/ports/SkDiscardableMemory_none.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/core/SkDiscardableMemory.h
[rename] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/include/private/chromium/GrVkSecondaryCBDrawContext.h
[add] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/include/private/chromium/SkDiscardableMemory.h
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/gpu/ganesh/vk/BUILD.bazel
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/tests/DeferredDisplayListTest.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/BUILD.gn
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/gpu/vk/BUILD.bazel
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/lazy/SkDiscardableMemoryPool.h
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/bazel/exporter/gni_exporter.go
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/tests/DiscardableMemoryPoolTest.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/tests/DiscardableMemoryTest.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/tests/SkResourceCacheTest.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/core/SkResourceCache.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/lazy/SkDiscardableMemoryPool.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/gn/gpu.gni
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/tests/ImageCacheTest.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/tools/rewrite_includes.py
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/gpu/vk/GrVkSecondaryCBDrawContext.h
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/tests/VkDrawableTest.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/bazel/exporter_tool/main.go
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/public.bzl
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/core/SkBitmapCache.cpp
https://skia.googlesource.com/skia/+/dfb838747295b9109343e6f536b25e9fa3fe933e
commit dfb838747295b9109343e6f536b25e9fa3fe933e
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 11 19:05:18 2023
Move two chromium-specific headers into i/p/chromium
Both SkDiscardableMemory.h and GrVkSecondaryCBDrawContext.h
are chromium specific. By moving them to this new location,
it will be easier to specify to Chromium's GN rule that
they are visible to chromium code.
I removed GrVkSecondaryCBDrawContext* from public.bzl
and into only Skia's test target to help enforce the
fact that non-Chromium clients shouldn't need to compile
this code.
Change-Id: I9005238e4691d37610274e5261cf030850d08cb8
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/628743
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/core/SkCachedData.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/gn/core.gni
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/gpu/ganesh/vk/GrVkSecondaryCBDrawContext.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/core/BUILD.bazel
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/include/private/chromium/BUILD.bazel
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/ports/SkDiscardableMemory_none.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/core/SkDiscardableMemory.h
[rename] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/include/private/chromium/GrVkSecondaryCBDrawContext.h
[add] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/include/private/chromium/SkDiscardableMemory.h
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/gpu/ganesh/vk/BUILD.bazel
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/tests/DeferredDisplayListTest.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/BUILD.gn
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/gpu/vk/BUILD.bazel
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/lazy/SkDiscardableMemoryPool.h
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/bazel/exporter/gni_exporter.go
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/tests/DiscardableMemoryPoolTest.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/tests/DiscardableMemoryTest.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/tests/SkResourceCacheTest.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/core/SkResourceCache.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/lazy/SkDiscardableMemoryPool.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/gn/gpu.gni
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/tests/ImageCacheTest.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/tools/rewrite_includes.py
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/gpu/vk/GrVkSecondaryCBDrawContext.h
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/tests/VkDrawableTest.cpp
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/bazel/exporter_tool/main.go
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/public.bzl
[modify] https://crrev.com/dfb838747295b9109343e6f536b25e9fa3fe933e/src/core/SkBitmapCache.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #27
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/e4b9ef3f8406704184c357a0cb7bc63a76c46961
commit e4b9ef3f8406704184c357a0cb7bc63a76c46961
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 11 20:29:50 2023
Break out metal headers used by C++ and ObjC code
The chromium build the metal part of code in a different [1]
target than the rest of the code. As such, they see a
gn check errors like:
ERROR at //third_party/skia/src/gpu/ganesh/GrBackendUtils.cpp:26:11: Including a private header.
#include "src/gpu/ganesh/mtl/GrMtlCppUtil.h"
^--------------------------------
This file is private to the target //skia:skia_metal
ERROR at //third_party/skia/src/gpu/ganesh/GrDirectContext.cpp:40:11: Including a private header.
#include "src/gpu/ganesh/mtl/GrMtlTrampoline.h"
^-----------------------------------
This file is private to the target //skia:skia_metal
To fix this, we can split the headers used by the C++ code
out into their own GNI file group and list that in both
targets (rather than trying to make GrMtlCppUtil.h et al public)
[1] https://source.chromium.org/chromium/chromium/src/+/main:skia/BUILD.gn;l=767-769;drc=f62bcc24c9aaff6ea3db5c870d813fb9c6449f04
Change-Id: I781e35c61123b0f6f874bdb0ed2542fceff81807
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/628981
Reviewed-by: Jim Van Verth <jvanverth@google.com>
[modify] https://crrev.com/e4b9ef3f8406704184c357a0cb7bc63a76c46961/BUILD.gn
[modify] https://crrev.com/e4b9ef3f8406704184c357a0cb7bc63a76c46961/bazel/exporter_tool/main.go
[modify] https://crrev.com/e4b9ef3f8406704184c357a0cb7bc63a76c46961/src/gpu/ganesh/mtl/BUILD.bazel
[modify] https://crrev.com/e4b9ef3f8406704184c357a0cb7bc63a76c46961/bazel/exporter/gni_exporter.go
[modify] https://crrev.com/e4b9ef3f8406704184c357a0cb7bc63a76c46961/gn/gpu.gni
https://skia.googlesource.com/skia/+/e4b9ef3f8406704184c357a0cb7bc63a76c46961
commit e4b9ef3f8406704184c357a0cb7bc63a76c46961
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 11 20:29:50 2023
Break out metal headers used by C++ and ObjC code
The chromium build the metal part of code in a different [1]
target than the rest of the code. As such, they see a
gn check errors like:
ERROR at //third_party/skia/src/gpu/ganesh/GrBackendUtils.cpp:26:11: Including a private header.
#include "src/gpu/ganesh/mtl/GrMtlCppUtil.h"
^--------------------------------
This file is private to the target //skia:skia_metal
ERROR at //third_party/skia/src/gpu/ganesh/GrDirectContext.cpp:40:11: Including a private header.
#include "src/gpu/ganesh/mtl/GrMtlTrampoline.h"
^-----------------------------------
This file is private to the target //skia:skia_metal
To fix this, we can split the headers used by the C++ code
out into their own GNI file group and list that in both
targets (rather than trying to make GrMtlCppUtil.h et al public)
[1] https://source.chromium.org/chromium/chromium/src/+/main:skia/BUILD.gn;l=767-769;drc=f62bcc24c9aaff6ea3db5c870d813fb9c6449f04
Change-Id: I781e35c61123b0f6f874bdb0ed2542fceff81807
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/628981
Reviewed-by: Jim Van Verth <jvanverth@google.com>
[modify] https://crrev.com/e4b9ef3f8406704184c357a0cb7bc63a76c46961/BUILD.gn
[modify] https://crrev.com/e4b9ef3f8406704184c357a0cb7bc63a76c46961/bazel/exporter_tool/main.go
[modify] https://crrev.com/e4b9ef3f8406704184c357a0cb7bc63a76c46961/src/gpu/ganesh/mtl/BUILD.bazel
[modify] https://crrev.com/e4b9ef3f8406704184c357a0cb7bc63a76c46961/bazel/exporter/gni_exporter.go
[modify] https://crrev.com/e4b9ef3f8406704184c357a0cb7bc63a76c46961/gn/gpu.gni
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #28
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/18ac33a9014d980374cc118203af106a9c303a57
commit 18ac33a9014d980374cc118203af106a9c303a57
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jan 12 15:15:07 2023
[base] Fold GrConfig.h into SkTypes.h
Two macros were folded into GrGLUtil.h, where the only use was.
Change-Id: I194bc1d36d3f7edb811d27e3368c5235e79af89b
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/628418
Reviewed-by: Brian Salomon <bsalomon@google.com>
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/tests/PathRendererCacheTests.cpp
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/gm/wacky_yuv_formats.cpp
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/gl/GrGLUtil.h
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/include/core/SkTypes.h
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/gm/constcolorprocessor.cpp
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/include/BUILD.bazel
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/GrResourceCache.h
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/tests/TransferPixelsTest.cpp
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/GrGpu.h
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/GrRecordingContext.cpp
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/tests/PrimitiveProcessorTest.cpp
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/GrAuditTrail.h
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/GrThreadSafePipelineBuilder.h
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/GrRecordingContextPriv.h
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/gn/gpu.gni
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/SurfaceDrawContext.cpp
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/include/gpu/GrRecordingContext.h
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/include/gpu/GrTypes.h
[delete] https://crrev.com/e4b9ef3f8406704184c357a0cb7bc63a76c46961/include/gpu/GrConfig.h
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/tools/rewrite_includes.py
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/GrDistanceFieldGenFromVector.cpp
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/include/gpu/BUILD.bazel
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/RELEASE_NOTES.txt
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/public.bzl
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/GrDirectContextPriv.cpp
https://skia.googlesource.com/skia/+/18ac33a9014d980374cc118203af106a9c303a57
commit 18ac33a9014d980374cc118203af106a9c303a57
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jan 12 15:15:07 2023
[base] Fold GrConfig.h into SkTypes.h
Two macros were folded into GrGLUtil.h, where the only use was.
Change-Id: I194bc1d36d3f7edb811d27e3368c5235e79af89b
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/628418
Reviewed-by: Brian Salomon <bsalomon@google.com>
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/tests/PathRendererCacheTests.cpp
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/gm/wacky_yuv_formats.cpp
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/gl/GrGLUtil.h
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/include/core/SkTypes.h
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/gm/constcolorprocessor.cpp
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/include/BUILD.bazel
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/GrResourceCache.h
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/tests/TransferPixelsTest.cpp
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/GrGpu.h
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/GrRecordingContext.cpp
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/tests/PrimitiveProcessorTest.cpp
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/GrAuditTrail.h
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/GrThreadSafePipelineBuilder.h
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/GrRecordingContextPriv.h
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/gn/gpu.gni
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/SurfaceDrawContext.cpp
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/include/gpu/GrRecordingContext.h
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/include/gpu/GrTypes.h
[delete] https://crrev.com/e4b9ef3f8406704184c357a0cb7bc63a76c46961/include/gpu/GrConfig.h
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/tools/rewrite_includes.py
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/GrDistanceFieldGenFromVector.cpp
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/include/gpu/BUILD.bazel
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/RELEASE_NOTES.txt
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/public.bzl
[modify] https://crrev.com/18ac33a9014d980374cc118203af106a9c303a57/src/gpu/ganesh/GrDirectContextPriv.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #29
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/14db02a66c15e461a552eecc0106714b285d39dc
commit 14db02a66c15e461a552eecc0106714b285d39dc
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jan 12 18:56:16 2023
[skia] Allow skia target to be compliant with gn check
On the Skia side, we produced several new GNI file lists:
- http://review.skia.org/627988
- http://review.skia.org/627989
- http://review.skia.org/628737
- http://review.skia.org/628743
- http://review.skia.org/628981
This CL uses them in public or sources if they are to be
used by Chromium or not.
This should make it harder for Chromium to unintentionally
#include Skia internals (e.g. files in src or include/private).
Symbols from include/private could still be visible via transitive
dependencies, and follow-on work will put those in a private
namespace to further discourage use.
One fuzzer needs to have gn check disabled because it directly
tests SkJSON.h, an internal file.
Change-Id: I76064f8322beec4c0b14efc90cd1ea7fc1f57f7a
Bug: skia:13983, skia:12541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4089412
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1091959}
[modify] https://crrev.com/14db02a66c15e461a552eecc0106714b285d39dc/skia/tools/fuzzers/BUILD.gn
[modify] https://crrev.com/14db02a66c15e461a552eecc0106714b285d39dc/skia/BUILD.gn
https://chromium.googlesource.com/chromium/src/+/14db02a66c15e461a552eecc0106714b285d39dc
commit 14db02a66c15e461a552eecc0106714b285d39dc
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jan 12 18:56:16 2023
[skia] Allow skia target to be compliant with gn check
On the Skia side, we produced several new GNI file lists:
- http://review.skia.org/627988
- http://review.skia.org/627989
- http://review.skia.org/628737
- http://review.skia.org/628743
- http://review.skia.org/628981
This CL uses them in public or sources if they are to be
used by Chromium or not.
This should make it harder for Chromium to unintentionally
#include Skia internals (e.g. files in src or include/private).
Symbols from include/private could still be visible via transitive
dependencies, and follow-on work will put those in a private
namespace to further discourage use.
One fuzzer needs to have gn check disabled because it directly
tests SkJSON.h, an internal file.
Change-Id: I76064f8322beec4c0b14efc90cd1ea7fc1f57f7a
Bug: skia:13983, skia:12541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4089412
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1091959}
[modify] https://crrev.com/14db02a66c15e461a552eecc0106714b285d39dc/skia/tools/fuzzers/BUILD.gn
[modify] https://crrev.com/14db02a66c15e461a552eecc0106714b285d39dc/skia/BUILD.gn
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #30
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/440f50f7190294d9f34214c972d6d128b39966d8
commit 440f50f7190294d9f34214c972d6d128b39966d8
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jan 12 19:00:51 2023
Remove SkBudgeted in favor of skgpu::Budgeted
Apparently I missed some cases in our Objective C code.
All clients have been moved onto the new name.
Change-Id: I560acc40eddc17978e22072321f773f2e0c5255d
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/629456
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/src/gpu/ganesh/mtl/GrMtlTexture.mm
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/site/docs/user/api/skcanvas_creation.md
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/src/gpu/ganesh/mtl/GrMtlBuffer.mm
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/tests/MtlCopySurfaceTest.mm
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/src/gpu/ganesh/mtl/GrMtlGpu.mm
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/src/gpu/ganesh/mtl/GrMtlAttachment.mm
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/src/gpu/ganesh/mtl/GrMtlTextureRenderTarget.mm
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/src/image/SkSurface_GpuMtl.mm
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/include/gpu/GpuTypes.h
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/src/gpu/graphite/mtl/MtlTexture.mm
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/src/gpu/graphite/mtl/MtlResourceProvider.mm
https://skia.googlesource.com/skia/+/440f50f7190294d9f34214c972d6d128b39966d8
commit 440f50f7190294d9f34214c972d6d128b39966d8
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jan 12 19:00:51 2023
Remove SkBudgeted in favor of skgpu::Budgeted
Apparently I missed some cases in our Objective C code.
All clients have been moved onto the new name.
Change-Id: I560acc40eddc17978e22072321f773f2e0c5255d
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/629456
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/src/gpu/ganesh/mtl/GrMtlTexture.mm
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/site/docs/user/api/skcanvas_creation.md
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/src/gpu/ganesh/mtl/GrMtlBuffer.mm
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/tests/MtlCopySurfaceTest.mm
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/src/gpu/ganesh/mtl/GrMtlGpu.mm
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/src/gpu/ganesh/mtl/GrMtlAttachment.mm
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/src/gpu/ganesh/mtl/GrMtlTextureRenderTarget.mm
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/src/image/SkSurface_GpuMtl.mm
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/include/gpu/GpuTypes.h
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/src/gpu/graphite/mtl/MtlTexture.mm
[modify] https://crrev.com/440f50f7190294d9f34214c972d6d128b39966d8/src/gpu/graphite/mtl/MtlResourceProvider.mm
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #31
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a
commit 1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Jan 13 14:35:48 2023
Fix includes of Chromium-specific Skia headers
Follow-up to crrev.com/c/4089412 and review.skia.org/628743
Bug: skia:13983
Change-Id: Ied97f41665fe30a99c6284474c1eb5828a9b5df1
Disable-Rts: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4163300
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1092390}
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/components/viz/service/display_embedder/skia_output_device_vulkan_secondary_cb.cc
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/android_webview/browser/gfx/aw_draw_fn_impl.cc
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/android_webview/browser/gfx/vulkan_gl_interop.cc
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/skia/BUILD.gn
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/skia/ext/SkDiscardableMemory_chrome.h
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/android_webview/browser/gfx/aw_vulkan_context_provider.h
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/android_webview/DEPS
https://chromium.googlesource.com/chromium/src/+/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a
commit 1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Jan 13 14:35:48 2023
Fix includes of Chromium-specific Skia headers
Follow-up to crrev.com/c/4089412 and review.skia.org/628743
Bug: skia:13983
Change-Id: Ied97f41665fe30a99c6284474c1eb5828a9b5df1
Disable-Rts: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4163300
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1092390}
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/components/viz/service/display_embedder/skia_output_device_vulkan_secondary_cb.cc
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/android_webview/browser/gfx/aw_draw_fn_impl.cc
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/android_webview/browser/gfx/vulkan_gl_interop.cc
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/skia/BUILD.gn
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/skia/ext/SkDiscardableMemory_chrome.h
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/android_webview/browser/gfx/aw_vulkan_context_provider.h
[modify] https://crrev.com/1ff2ebf4884f24a0b05c2716ab45882aa3b57e2a/android_webview/DEPS
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #32
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b
commit dc6cc023adbfec496e4dfdcbc38022c4079c2d0b
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Jan 13 16:24:27 2023
[base] Move many files into base
Moved from include/private into include/private/base:
- SkAlignedStorage.h
- SkContainers.h
- SkFloatBits.h
- SkPathEnums.h
- SkTArray.h
- SkTDArray.h
- SkTypeTraits.h
- SkVx.h
- SkCPUTypes.h*
Moved from include/core into include/private/base:
- SkMath.h
- SkSpan.h
We still want SkSpan.h to be a part of the public API,
so include/core/SkSpan.h still exists, it just includes
include/private/base/SkSpan_impl.h
We want to remove SkMath.h from the public API (most
client uses have been removed already), but for now
it too has a shim header file in include/core/SkMath.h
As per the design of base, there are no includes inside
of base on Skia files not also in base. SkLeftShift moved
out of SkTypes.h and into SkMath.h, as that seemed like a better
fit. U8CPU and U16CPU moved into their own file, SkCPUTypes.h
while we decide where their future lies.
Suggested review order:
- include/private/base/BUILD.bazel
- include/private/BUILD.bazel
- include/BUILD.bazel
- gn/*.gni (these are generated from the BUILD.bazel files)
- BUILD.gn
- public.bzl
- Everything else, mostly done with find and replace and
cleaned up with the rewrite_includes.py script.
Change-Id: Icce0d0c445863c6908b63ec31b9595de400988dc
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/629317
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/sksl/DSLCore.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/graphite/UniformManager.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/effects/imagefilters/SkBlurImageFilter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/d3d/GrD3DResourceProvider.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkFontConfigInterface_direct.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/TextBlobTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/TriangulatingPathRendererTests.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkMath.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPixmap.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkTypeface_mac_ct.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsSimplifyDegenerateThreadedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skparagraph/src/ParagraphImpl.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkVMVisualizer.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/viewer/SGSlide.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/gl/GrGLCaps.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrNonAtomicRef.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/flags/CommandLineFlags.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsBattles.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/GrMeshTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkContourMeasure.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkGraphics.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkPath.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkSpan.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/drawglyphs.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/vk/GrVkDescriptorSetManager.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrTexture.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkColor.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skottie/src/text/SkottieShaper.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsChalkboardTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skunicode/include/SkUnicode.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkOpBuilder.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/fonts/TestSVGTypeface.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/texelsubset.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkPolyUtils.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsTightBoundsTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/flippity.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkPathOpsWinding.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkScalerContext_win_dw.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLFunctionCall.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsOpCircleThreadedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/shaders/gradients/SkGradientShaderBase.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/CanvasStateTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/xps/SkXPSDevice.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsOpCubicThreadedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsDebug.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkFontMgr_custom.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/TopoSortTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/text/gpu/TextBlobRedrawCoordinator.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/shapes.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/opts/SkSwizzler_opts.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkBlockAllocator.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkPathOpsTSect.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/codegen/SkSLSPIRVCodeGenerator.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pdf/SkPDFShader.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsThreadedCommon.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPathBuilder.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkScan_Hairline.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLIndexExpression.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsIssue3651.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkColorFilter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPtrRecorder.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/BlurTest.cpp
[rename] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkContainers.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PDFOpaqueSrcModeToSrcOverTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/SrcOverTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/SkSLDefines.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/pathkit/pathkit_wasm_bindings.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkFDot6.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/DDLPromiseImageHelper.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkPixelRef.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkDashPath.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrVertexChunkArray.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/viewer/ParticlesSlide.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/badpaint.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/StrokerTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/sksl/DSLBlock.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLSwizzle.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/PathOpsBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/StringTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/SkFloatingPoint.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkFontMgr_android.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/fonts/TestSVGTypeface.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PromiseImageTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkPatchUtils.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/BUILD.bazel
[add] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkSpan_impl.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/SKPBench.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/polygonoffset.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/SkSLDSLTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/hairlines.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/strokedlines.cpp
[rename] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkAlignedStorage.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/sksl/DSLCase.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skparagraph/src/TextLine.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/ops/QuadPerEdgeAA.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/gpu/vk/VulkanExtensions.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/gpu/GrRecordingContext.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/dm/DMJsonWriter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/SkVxTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkNWayCanvas.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkBlurMask.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/mtl/GrMtlCaps.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ImageFilterTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsFuzz763Test.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkDataTable.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLFunctionDeclaration.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkRegion.h
[rename] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkFloatBits.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ResourceKey.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skunicode/src/SkUnicode_icu.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/strokes.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkShaderUtils.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkResourceCache.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/GrStyledShapeTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrResourceCache.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/codec/SkSwizzler.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkRegionPriv.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkPaint.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/sksl/DSLFunction.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/effects/SkColorMatrixFilter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkRecordDraw.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsBuilderConicTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/viewer/ChartSlide.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/codec/SkJpegPriv.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/debugger/DebugCanvas.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/codec/SkIcoCodec.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/ops/FillRRectOp.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/graphite/CommandBuffer.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsOpLoopThreadedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/BUILD.bazel
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkMath.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/CubicMapTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkImageInfo.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/GrRenderTaskClusterTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/geometry/GrQuadUtils.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/TDPQueueTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/graphite/DrawPass.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/SkColorData.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/ClipStack.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPathPriv.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/convexpaths.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/DashBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PolyUtilsTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/RandomTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsSkpTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkRasterPipeline.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/transform/SkSLEliminateUnreachableCode.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/pathops/SkPathOps.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/gpu/ganesh/GrTypesPriv.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/viewer/ImGuiLayer.h
[rename] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkTArray.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/skdiff/skdiff.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/experimental/ffmpeg/SkVideoEncoder.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/PathBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkGeometry.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsThreeWayTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/ChartBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/TextBlobCacheTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/vertices.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsAngleIdeas.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ResourceAllocatorTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLFieldAccess.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/aaa.cpp
[rename] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/base/SkContainers.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/viewer/TouchGesture.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/text/gpu/SubRunAllocator.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skottie/src/animator/VectorKeyframeAnimator.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsOpTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gn/core.gni
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLConstructorScalarCast.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/fonts/create_test_font.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/graphite/vk/VulkanCaps.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/opts/SkBlitRow_opts.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkTDPQueue.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkCanvasStack.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/gpu/GrContextFactory.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkPathOpsDebug.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkCubicMap.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/gradients/GrGradientBitmapCache.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/BUILD.bazel
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPictureRecord.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/pathmeasure.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrSurfaceProxyView.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/roundrects.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkSharedMutex.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkMessageBus.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/tessellate/FixedCountBufferUtils.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/svg/SkSVGDevice.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/Test.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/dashcubics.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/effects/GrSkSLFP.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/particles/include/SkReflected.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkRecorder.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkPathOpsSimplify.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/polygons.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/PathRendererChain.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/codec/SkJpegUtility.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/codegen/SkSLMetalCodeGenerator.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/canvaskit/wasm_tools/SIMD/simd_int_capabilities.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/codegen/SkSLGLSLCodeGenerator.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/BufferWriter.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ColorTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkOpCoincidence.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/sk_app/Window.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/codegen/SkSLRasterPipelineCodeGenerator.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/analysis/SkSLIsSameExpressionTree.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrBufferAllocPool.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/win/SkWGL_win.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/svg/include/SkSVGTypes.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/BUILD.bazel
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkRemotableFontMgr_win_dw.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/BUILD.gn
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/pathmaskcache.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/RectanizerSkyline.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrThreadSafePipelineBuilder.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/circulararcs.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/StrokeTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkM44.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrResourceProvider.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/CompressedBackendAllocationTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/SkHalf.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/xml/SkXMLWriter.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/canvaskit/wasm_tools/SIMD/simd_float_capabilities.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/skdiff/skdiff_main.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/graphite/geom/Rect.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/SkIDChangeListener.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/sk_app/CommandSet.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bazel/exporter_tool/main.go
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/effects/imagefilters/SkAlphaThresholdImageFilter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/SkSLAnalysis.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/gpu/gl/GrGLExtensions.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/geometry/GrQuad.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkEdge.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/codec/SkRawCodec.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrRenderTask.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkPathMeasure.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/OpChainTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/ToolUtils.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkTypefaceCache.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/xml/SkDOM.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/viewer/PathTextSlide.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/ovals.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/particles/include/SkParticleEffect.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLConstructor.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ClipCubicTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPictureData.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ImageTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/RectanizerBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/mtl/GrMtlResourceProvider.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/vk/GrVkResourceProvider.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/codegen/SkSLVMCodeGenerator.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/viewer/SlideDir.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLChildCall.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skunicode/src/SkUnicode_client.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/SerialProcsTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/viewer/PatchSlide.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/flags/CommandLineFlags.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/fuzz/FuzzPolyUtils.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/GrSlugTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkRect.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/gl/GrGLGpu.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/bleed.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPathRef.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkStream.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkCompressedDataUtils.h
[add] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkMath.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkFontMgr_android_parser.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkCanvasStack.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkPathOpsOp.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/HSVRoundTripTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrGpu.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkGeometry.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsTigerTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/effects/imagefilters/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/xps/SkXPSDevice.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkShadowTessellator.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsQuadIntersectionTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/slug.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/sksl/DSLExpression.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrPersistentCacheUtils.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/FontMgrAndroidParserTest.cpp
[rename] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkVx.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrProcessorUnitTest.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/svg/include/SkSVGContainer.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkMatrixPriv.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPicturePlayback.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/rewrite_includes.py
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/RRectInPathTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/filterfastbounds.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/graphite/PipelineData.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/vk/VulkanMemory.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkTypes.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/codegen/SkSLRasterPipelineBuilder.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkEdgeBuilder.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkOpSegment.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/images/SkJPEGWriteUtility.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/SkContainersTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsOpRectThreadedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkMesh.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/opts/SkBitmapProcState_opts.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkAAClip.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skottie/src/Skottie.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/graphite/PaintParamsKey.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/MathBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/LineBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/flags/CommonFlags.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/SkSLAnalysis.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/SkSLInliner.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/IncrTopoSortTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/opts/SkVM_opts.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/effects/GrConvexPolyEffect.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/colorfilterimagefilter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkColor.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/PolyUtilsBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/OffsetSimplePolyTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/viewer/QuadStrokerSlide.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/gl/GrGLVertexArray.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsBuilderTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/tessellate/Tessellation.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/wacky_yuv_formats.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/perspimages.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkMathPriv.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/SkPathRef.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skottie/src/text/TextAnimator.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/fonts/SkFontMgr_indirect.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkDraw_vertices.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/WangsFormulaTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkMatrix.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/pathcontourstart.cpp
[add] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkCPUTypes.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/Sk4px.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkGlyphRunPainter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/texteffects.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkExecutor.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/AtlasTypes.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkMultiPictureDocument.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/SkSLTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skshaper/src/SkShaper_harfbuzz.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/base/BUILD.bazel
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/geometry/GrAAConvexTessellator.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/SurfaceDrawContext.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/tessellate/WangsFormula.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsSimplifyTrianglesThreadedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PDFGlyphsToUnicodeTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/vk/GrVkCaps.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkDeferredDisplayList.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkString.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/Float16Test.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/MSKPPlayer.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/FloatingPointTextureTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/conicpaths.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/compositor_quads.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkPathWriter.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/MessageBusTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkCharToGlyphCache.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gn/sksl.gni
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/BUILD.bazel
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPath.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkVM.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/AsyncReadTypes.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/TArrayTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkBlitter_ARGB32.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsTestCommon.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skottie/src/effects/MotionBlurEffect.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/SubsetPath.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkJSONWriter.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkHalf.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsSimplifyQuadralateralsThreadedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/fonts/TestTypeface.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/sksg/src/SkSGText.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/composeshader.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skparagraph/src/Run.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkBlendMode.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkRegion_path.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLConstructorStruct.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkTDArray.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/stlouisarch.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/glsl/GrGLSLShaderBuilder.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkGlyph.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/debugger/DrawCommand.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/InsetConvexPolyTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/graphite/ResourceCache.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkFontMgr_custom.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skottie/src/effects/CCTonerEffect.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/effects/imagefilters/SkMatrixConvolutionImageFilter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/GrPipelineDynamicStateTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkLatticeIter.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/ops/AtlasPathRenderer.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/shaders/gradients/SkGradientShaderBase.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsQuadLineIntersectionThreadedTest.cpp
[rename] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkTypeTraits.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/codegen/SkSLSPIRVCodeGenerator.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/debugger/DebugCanvas.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsExtendedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/effects/SkOpPathEffect.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/codegen/SkSLPipelineStageCodeGenerator.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/SkFixed.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/gpu/GrTypes.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/WritePixelsTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/utils/SkNWayCanvas.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/BUILD.bazel
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/public.bzl
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsSimplifyTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/textblobshader.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsSimplifyRectThreadedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkMipmap.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/ScalarBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkFlattenable.cpp
[rename] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkPathEnums.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrDataUtils.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrProgramDesc.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/SkRuntimeEffectTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/codec/SkWebpCodec.cpp
[rename] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkTDArray.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/geometry/GrQuadUtils.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/Sk4fBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/KeyBuilder.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/SkSLParser.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLExternalFunctionCall.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/ops/OpsTask.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkPathOpsTypes.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrAuditTrail.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/GpuRectanizerTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsBuildUseTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsSimplifyQuadThreadedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pdf/SkPDFTag.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/textblob.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkBitmap.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/gl/GrGLProgramDataManager.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkOpEdgeBuilder.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/effects/imagefilters/SkRuntimeImageFilter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkPathOpsCommon.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkColorPriv.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPath_serial.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/dftext_blob_persp.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkMaskBlurFilter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrUniformDataManager.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkRecordOpts.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkFontMgr_android_parser.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLSwitchStatement.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsSimplifyFailTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkImageFilter_Base.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/text/gpu/SubRunAllocator.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ScalarTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/shadowutils.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/particles/include/SkParticleSerialization.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/geometry/GrQuadBuffer.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/MathTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkBitmapProcState.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/utils/SkPaintFilterCanvas.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkFontMgr_fontconfig.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrDrawingManager.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/ports/SkFontMgr_indirect.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ProcessorTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/opts/SkUtils_opts.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/geometry/GrPathUtils.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/PathRenderer.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/TextureBindingsResetTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/GrMemoryPoolTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/RELEASE_NOTES.txt
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsAngleTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/utils/SkRandom.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skparagraph/include/TypefaceFontProvider.h
https://skia.googlesource.com/skia/+/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b
commit dc6cc023adbfec496e4dfdcbc38022c4079c2d0b
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Jan 13 16:24:27 2023
[base] Move many files into base
Moved from include/private into include/private/base:
- SkAlignedStorage.h
- SkContainers.h
- SkFloatBits.h
- SkPathEnums.h
- SkTArray.h
- SkTDArray.h
- SkTypeTraits.h
- SkVx.h
- SkCPUTypes.h*
Moved from include/core into include/private/base:
- SkMath.h
- SkSpan.h
We still want SkSpan.h to be a part of the public API,
so include/core/SkSpan.h still exists, it just includes
include/private/base/SkSpan_impl.h
We want to remove SkMath.h from the public API (most
client uses have been removed already), but for now
it too has a shim header file in include/core/SkMath.h
As per the design of base, there are no includes inside
of base on Skia files not also in base. SkLeftShift moved
out of SkTypes.h and into SkMath.h, as that seemed like a better
fit. U8CPU and U16CPU moved into their own file, SkCPUTypes.h
while we decide where their future lies.
Suggested review order:
- include/private/base/BUILD.bazel
- include/private/BUILD.bazel
- include/BUILD.bazel
- gn/*.gni (these are generated from the BUILD.bazel files)
- BUILD.gn
- public.bzl
- Everything else, mostly done with find and replace and
cleaned up with the rewrite_includes.py script.
Change-Id: Icce0d0c445863c6908b63ec31b9595de400988dc
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/629317
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/sksl/DSLCore.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/graphite/UniformManager.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/effects/imagefilters/SkBlurImageFilter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/d3d/GrD3DResourceProvider.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkFontConfigInterface_direct.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/TextBlobTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/TriangulatingPathRendererTests.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkMath.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPixmap.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkTypeface_mac_ct.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsSimplifyDegenerateThreadedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skparagraph/src/ParagraphImpl.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkVMVisualizer.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/viewer/SGSlide.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/gl/GrGLCaps.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrNonAtomicRef.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/flags/CommandLineFlags.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsBattles.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/GrMeshTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkContourMeasure.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkGraphics.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkPath.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkSpan.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/drawglyphs.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/vk/GrVkDescriptorSetManager.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrTexture.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkColor.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skottie/src/text/SkottieShaper.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsChalkboardTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skunicode/include/SkUnicode.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkOpBuilder.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/fonts/TestSVGTypeface.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/texelsubset.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkPolyUtils.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsTightBoundsTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/flippity.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkPathOpsWinding.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkScalerContext_win_dw.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLFunctionCall.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsOpCircleThreadedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/shaders/gradients/SkGradientShaderBase.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/CanvasStateTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/xps/SkXPSDevice.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsOpCubicThreadedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsDebug.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkFontMgr_custom.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/TopoSortTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/text/gpu/TextBlobRedrawCoordinator.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/shapes.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/opts/SkSwizzler_opts.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkBlockAllocator.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkPathOpsTSect.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/codegen/SkSLSPIRVCodeGenerator.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pdf/SkPDFShader.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsThreadedCommon.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPathBuilder.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkScan_Hairline.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLIndexExpression.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsIssue3651.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkColorFilter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPtrRecorder.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/BlurTest.cpp
[rename] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkContainers.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PDFOpaqueSrcModeToSrcOverTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/SrcOverTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/SkSLDefines.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/pathkit/pathkit_wasm_bindings.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkFDot6.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/DDLPromiseImageHelper.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkPixelRef.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkDashPath.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrVertexChunkArray.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/viewer/ParticlesSlide.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/badpaint.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/StrokerTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/sksl/DSLBlock.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLSwizzle.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/PathOpsBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/StringTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/SkFloatingPoint.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkFontMgr_android.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/fonts/TestSVGTypeface.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PromiseImageTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkPatchUtils.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/BUILD.bazel
[add] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkSpan_impl.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/SKPBench.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/polygonoffset.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/SkSLDSLTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/hairlines.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/strokedlines.cpp
[rename] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkAlignedStorage.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/sksl/DSLCase.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skparagraph/src/TextLine.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/ops/QuadPerEdgeAA.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/gpu/vk/VulkanExtensions.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/gpu/GrRecordingContext.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/dm/DMJsonWriter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/SkVxTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkNWayCanvas.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkBlurMask.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/mtl/GrMtlCaps.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ImageFilterTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsFuzz763Test.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkDataTable.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLFunctionDeclaration.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkRegion.h
[rename] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkFloatBits.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ResourceKey.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skunicode/src/SkUnicode_icu.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/strokes.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkShaderUtils.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkResourceCache.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/GrStyledShapeTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrResourceCache.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/codec/SkSwizzler.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkRegionPriv.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkPaint.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/sksl/DSLFunction.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/effects/SkColorMatrixFilter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkRecordDraw.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsBuilderConicTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/viewer/ChartSlide.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/codec/SkJpegPriv.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/debugger/DebugCanvas.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/codec/SkIcoCodec.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/ops/FillRRectOp.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/graphite/CommandBuffer.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsOpLoopThreadedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/BUILD.bazel
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkMath.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/CubicMapTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkImageInfo.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/GrRenderTaskClusterTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/geometry/GrQuadUtils.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/TDPQueueTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/graphite/DrawPass.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/SkColorData.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/ClipStack.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPathPriv.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/convexpaths.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/DashBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PolyUtilsTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/RandomTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsSkpTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkRasterPipeline.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/transform/SkSLEliminateUnreachableCode.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/pathops/SkPathOps.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/gpu/ganesh/GrTypesPriv.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/viewer/ImGuiLayer.h
[rename] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkTArray.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/skdiff/skdiff.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/experimental/ffmpeg/SkVideoEncoder.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/PathBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkGeometry.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsThreeWayTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/ChartBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/TextBlobCacheTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/vertices.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsAngleIdeas.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ResourceAllocatorTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLFieldAccess.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/aaa.cpp
[rename] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/base/SkContainers.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/viewer/TouchGesture.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/text/gpu/SubRunAllocator.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skottie/src/animator/VectorKeyframeAnimator.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsOpTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gn/core.gni
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLConstructorScalarCast.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/fonts/create_test_font.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/graphite/vk/VulkanCaps.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/opts/SkBlitRow_opts.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkTDPQueue.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkCanvasStack.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/gpu/GrContextFactory.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkPathOpsDebug.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkCubicMap.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/gradients/GrGradientBitmapCache.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/BUILD.bazel
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPictureRecord.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/pathmeasure.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrSurfaceProxyView.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/roundrects.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkSharedMutex.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkMessageBus.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/tessellate/FixedCountBufferUtils.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/svg/SkSVGDevice.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/Test.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/dashcubics.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/effects/GrSkSLFP.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/particles/include/SkReflected.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkRecorder.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkPathOpsSimplify.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/polygons.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/PathRendererChain.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/codec/SkJpegUtility.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/codegen/SkSLMetalCodeGenerator.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/canvaskit/wasm_tools/SIMD/simd_int_capabilities.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/codegen/SkSLGLSLCodeGenerator.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/BufferWriter.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ColorTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkOpCoincidence.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/sk_app/Window.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/codegen/SkSLRasterPipelineCodeGenerator.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/analysis/SkSLIsSameExpressionTree.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrBufferAllocPool.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/win/SkWGL_win.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/svg/include/SkSVGTypes.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/BUILD.bazel
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkRemotableFontMgr_win_dw.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/BUILD.gn
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/pathmaskcache.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/RectanizerSkyline.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrThreadSafePipelineBuilder.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/circulararcs.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/StrokeTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkM44.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrResourceProvider.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/CompressedBackendAllocationTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/SkHalf.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/xml/SkXMLWriter.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/canvaskit/wasm_tools/SIMD/simd_float_capabilities.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/skdiff/skdiff_main.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/graphite/geom/Rect.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/SkIDChangeListener.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/sk_app/CommandSet.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bazel/exporter_tool/main.go
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/effects/imagefilters/SkAlphaThresholdImageFilter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/SkSLAnalysis.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/gpu/gl/GrGLExtensions.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/geometry/GrQuad.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkEdge.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/codec/SkRawCodec.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrRenderTask.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkPathMeasure.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/OpChainTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/ToolUtils.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkTypefaceCache.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/xml/SkDOM.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/viewer/PathTextSlide.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/ovals.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/particles/include/SkParticleEffect.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLConstructor.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ClipCubicTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPictureData.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ImageTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/RectanizerBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/mtl/GrMtlResourceProvider.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/vk/GrVkResourceProvider.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/codegen/SkSLVMCodeGenerator.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/viewer/SlideDir.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLChildCall.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skunicode/src/SkUnicode_client.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/SerialProcsTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/viewer/PatchSlide.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/flags/CommandLineFlags.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/fuzz/FuzzPolyUtils.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/GrSlugTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkRect.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/gl/GrGLGpu.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/bleed.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPathRef.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkStream.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkCompressedDataUtils.h
[add] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkMath.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkFontMgr_android_parser.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkCanvasStack.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkPathOpsOp.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/HSVRoundTripTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrGpu.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkGeometry.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsTigerTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/effects/imagefilters/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/xps/SkXPSDevice.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkShadowTessellator.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsQuadIntersectionTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/slug.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/sksl/DSLExpression.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrPersistentCacheUtils.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/FontMgrAndroidParserTest.cpp
[rename] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkVx.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrProcessorUnitTest.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/svg/include/SkSVGContainer.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkMatrixPriv.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPicturePlayback.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/rewrite_includes.py
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/RRectInPathTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/filterfastbounds.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/graphite/PipelineData.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/vk/VulkanMemory.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkTypes.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/codegen/SkSLRasterPipelineBuilder.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkEdgeBuilder.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkOpSegment.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/images/SkJPEGWriteUtility.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/SkContainersTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsOpRectThreadedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkMesh.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/opts/SkBitmapProcState_opts.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkAAClip.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skottie/src/Skottie.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/graphite/PaintParamsKey.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/MathBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/LineBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/flags/CommonFlags.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/SkSLAnalysis.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/SkSLInliner.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/IncrTopoSortTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/opts/SkVM_opts.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/effects/GrConvexPolyEffect.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/colorfilterimagefilter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkColor.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/PolyUtilsBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/OffsetSimplePolyTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/viewer/QuadStrokerSlide.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/gl/GrGLVertexArray.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsBuilderTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/tessellate/Tessellation.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/wacky_yuv_formats.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/perspimages.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkMathPriv.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/SkPathRef.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skottie/src/text/TextAnimator.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/fonts/SkFontMgr_indirect.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkDraw_vertices.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/WangsFormulaTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkMatrix.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/pathcontourstart.cpp
[add] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkCPUTypes.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/Sk4px.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkGlyphRunPainter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/texteffects.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkExecutor.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/AtlasTypes.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkMultiPictureDocument.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/SkSLTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skshaper/src/SkShaper_harfbuzz.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/base/BUILD.bazel
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/geometry/GrAAConvexTessellator.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/SurfaceDrawContext.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/tessellate/WangsFormula.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsSimplifyTrianglesThreadedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PDFGlyphsToUnicodeTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/vk/GrVkCaps.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkDeferredDisplayList.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkString.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/Float16Test.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/MSKPPlayer.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/FloatingPointTextureTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/conicpaths.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/compositor_quads.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkPathWriter.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/MessageBusTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkCharToGlyphCache.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gn/sksl.gni
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/BUILD.bazel
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPath.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkVM.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/AsyncReadTypes.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/TArrayTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkBlitter_ARGB32.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsTestCommon.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skottie/src/effects/MotionBlurEffect.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/SubsetPath.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/utils/SkJSONWriter.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkHalf.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsSimplifyQuadralateralsThreadedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/fonts/TestTypeface.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/sksg/src/SkSGText.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/composeshader.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skparagraph/src/Run.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkBlendMode.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkRegion_path.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLConstructorStruct.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkTDArray.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/stlouisarch.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/glsl/GrGLSLShaderBuilder.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkGlyph.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/debugger/DrawCommand.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/InsetConvexPolyTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/graphite/ResourceCache.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkFontMgr_custom.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skottie/src/effects/CCTonerEffect.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/effects/imagefilters/SkMatrixConvolutionImageFilter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/GrPipelineDynamicStateTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkLatticeIter.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/ops/AtlasPathRenderer.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/shaders/gradients/SkGradientShaderBase.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsQuadLineIntersectionThreadedTest.cpp
[rename] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkTypeTraits.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/codegen/SkSLSPIRVCodeGenerator.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tools/debugger/DebugCanvas.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsExtendedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/effects/SkOpPathEffect.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/codegen/SkSLPipelineStageCodeGenerator.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/SkFixed.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/gpu/GrTypes.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/WritePixelsTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/utils/SkNWayCanvas.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/BUILD.bazel
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/public.bzl
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsSimplifyTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/textblobshader.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsSimplifyRectThreadedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkMipmap.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/ScalarBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkFlattenable.cpp
[rename] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkPathEnums.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrDataUtils.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrProgramDesc.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/SkRuntimeEffectTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/codec/SkWebpCodec.cpp
[rename] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/private/base/SkTDArray.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/geometry/GrQuadUtils.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/bench/Sk4fBench.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/KeyBuilder.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/SkSLParser.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLExternalFunctionCall.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/ops/OpsTask.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkPathOpsTypes.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrAuditTrail.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/GpuRectanizerTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsBuildUseTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsSimplifyQuadThreadedTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pdf/SkPDFTag.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/textblob.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkBitmap.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/gl/GrGLProgramDataManager.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkOpEdgeBuilder.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/effects/imagefilters/SkRuntimeImageFilter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/pathops/SkPathOpsCommon.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/core/SkColorPriv.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkPath_serial.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/dftext_blob_persp.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkMaskBlurFilter.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrUniformDataManager.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkRecordOpts.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkFontMgr_android_parser.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/sksl/ir/SkSLSwitchStatement.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsSimplifyFailTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkImageFilter_Base.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/text/gpu/SubRunAllocator.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ScalarTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/gm/shadowutils.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/particles/include/SkParticleSerialization.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/geometry/GrQuadBuffer.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/MathTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/core/SkBitmapProcState.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/utils/SkPaintFilterCanvas.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/ports/SkFontMgr_fontconfig.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/GrDrawingManager.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/ports/SkFontMgr_indirect.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/ProcessorTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/opts/SkUtils_opts.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/geometry/GrPathUtils.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/src/gpu/ganesh/PathRenderer.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/TextureBindingsResetTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/GrMemoryPoolTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/RELEASE_NOTES.txt
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/tests/PathOpsAngleTest.cpp
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/include/utils/SkRandom.h
[modify] https://crrev.com/dc6cc023adbfec496e4dfdcbc38022c4079c2d0b/modules/skparagraph/include/TypefaceFontProvider.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #33
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/2c40402bd5ff2e3db59a02e2737cdf0015cdb6d0
commit 2c40402bd5ff2e3db59a02e2737cdf0015cdb6d0
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 17 18:51:30 2023
Remove shim files for private Chrome GPU usage
No longer needed after https://chromium-review.googlesource.com/c/chromium/src/+/4163300
Change-Id: I620bfadd96e220f25ad348be300ccd78d85aabf7
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/630757
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/2c40402bd5ff2e3db59a02e2737cdf0015cdb6d0/gn/core.gni
[delete] https://crrev.com/115e4e3f9e51311b9d595a2e75dc4e21d361efa2/src/core/SkDiscardableMemory.h
[modify] https://crrev.com/2c40402bd5ff2e3db59a02e2737cdf0015cdb6d0/tools/rewrite_includes.py
[modify] https://crrev.com/2c40402bd5ff2e3db59a02e2737cdf0015cdb6d0/src/core/BUILD.bazel
[delete] https://crrev.com/115e4e3f9e51311b9d595a2e75dc4e21d361efa2/src/gpu/vk/GrVkSecondaryCBDrawContext.h
https://skia.googlesource.com/skia/+/2c40402bd5ff2e3db59a02e2737cdf0015cdb6d0
commit 2c40402bd5ff2e3db59a02e2737cdf0015cdb6d0
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 17 18:51:30 2023
Remove shim files for private Chrome GPU usage
No longer needed after https://chromium-review.googlesource.com/c/chromium/src/+/4163300
Change-Id: I620bfadd96e220f25ad348be300ccd78d85aabf7
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/630757
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/2c40402bd5ff2e3db59a02e2737cdf0015cdb6d0/gn/core.gni
[delete] https://crrev.com/115e4e3f9e51311b9d595a2e75dc4e21d361efa2/src/core/SkDiscardableMemory.h
[modify] https://crrev.com/2c40402bd5ff2e3db59a02e2737cdf0015cdb6d0/tools/rewrite_includes.py
[modify] https://crrev.com/2c40402bd5ff2e3db59a02e2737cdf0015cdb6d0/src/core/BUILD.bazel
[delete] https://crrev.com/115e4e3f9e51311b9d595a2e75dc4e21d361efa2/src/gpu/vk/GrVkSecondaryCBDrawContext.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #34
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/808ddfb12d85fa3b411a1e26c7071952b31b627f
commit 808ddfb12d85fa3b411a1e26c7071952b31b627f
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 18 15:34:11 2023
Remove uses of SkMath.h
These are the last direct includes, as well as the last
usage of the symbols there.
I added DCHECK or other validation to make sure the cast
from signed to unsigned didn't underflow, but otherwise
the code should be identical.
Skia plans to remove SkMath.h from the public API.
As long as I was removing #includes, I decided to add a few
that were used but not explicitly specified to save future
churn if we refactor #includes internally.
Change-Id: Ib26f1fcf38da03e5fcfd0f3af0e7e05a1d837959
Bug: skia:13983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4174994
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1093880}
[modify] https://crrev.com/808ddfb12d85fa3b411a1e26c7071952b31b627f/cc/raster/raster_buffer_provider.cc
[modify] https://crrev.com/808ddfb12d85fa3b411a1e26c7071952b31b627f/cc/paint/paint_op_writer.cc
[modify] https://crrev.com/808ddfb12d85fa3b411a1e26c7071952b31b627f/cc/paint/paint_filter.h
[modify] https://crrev.com/808ddfb12d85fa3b411a1e26c7071952b31b627f/cc/paint/paint_filter.cc
[modify] https://crrev.com/808ddfb12d85fa3b411a1e26c7071952b31b627f/cc/paint/paint_op_reader.cc
https://chromium.googlesource.com/chromium/src/+/808ddfb12d85fa3b411a1e26c7071952b31b627f
commit 808ddfb12d85fa3b411a1e26c7071952b31b627f
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 18 15:34:11 2023
Remove uses of SkMath.h
These are the last direct includes, as well as the last
usage of the symbols there.
I added DCHECK or other validation to make sure the cast
from signed to unsigned didn't underflow, but otherwise
the code should be identical.
Skia plans to remove SkMath.h from the public API.
As long as I was removing #includes, I decided to add a few
that were used but not explicitly specified to save future
churn if we refactor #includes internally.
Change-Id: Ib26f1fcf38da03e5fcfd0f3af0e7e05a1d837959
Bug: skia:13983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4174994
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1093880}
[modify] https://crrev.com/808ddfb12d85fa3b411a1e26c7071952b31b627f/cc/raster/raster_buffer_provider.cc
[modify] https://crrev.com/808ddfb12d85fa3b411a1e26c7071952b31b627f/cc/paint/paint_op_writer.cc
[modify] https://crrev.com/808ddfb12d85fa3b411a1e26c7071952b31b627f/cc/paint/paint_filter.h
[modify] https://crrev.com/808ddfb12d85fa3b411a1e26c7071952b31b627f/cc/paint/paint_filter.cc
[modify] https://crrev.com/808ddfb12d85fa3b411a1e26c7071952b31b627f/cc/paint/paint_op_reader.cc
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #35
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/3554d02ae0d95dea057406cdef9225c8ebe3f828
commit 3554d02ae0d95dea057406cdef9225c8ebe3f828
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 18 15:51:39 2023
Remove SkMath.h from the public API
This had been waiting on:
- http://ag/21022503
- http://go/cl-c/4174994
Change-Id: I4aa3a750a52a05a0dcd9ac8336f9239bfaf6876a
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/631239
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/3554d02ae0d95dea057406cdef9225c8ebe3f828/gn/core.gni
[modify] https://crrev.com/3554d02ae0d95dea057406cdef9225c8ebe3f828/tools/rewrite_includes.py
[modify] https://crrev.com/3554d02ae0d95dea057406cdef9225c8ebe3f828/include/core/BUILD.bazel
[modify] https://crrev.com/3554d02ae0d95dea057406cdef9225c8ebe3f828/RELEASE_NOTES.txt
[delete] https://crrev.com/1ace2d223d23dfe2f431c3cc3e813f924fc6fdaf/include/core/SkMath.h
[modify] https://crrev.com/3554d02ae0d95dea057406cdef9225c8ebe3f828/public.bzl
https://skia.googlesource.com/skia/+/3554d02ae0d95dea057406cdef9225c8ebe3f828
commit 3554d02ae0d95dea057406cdef9225c8ebe3f828
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 18 15:51:39 2023
Remove SkMath.h from the public API
This had been waiting on:
- http://ag/21022503
- http://go/cl-c/4174994
Change-Id: I4aa3a750a52a05a0dcd9ac8336f9239bfaf6876a
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/631239
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/3554d02ae0d95dea057406cdef9225c8ebe3f828/gn/core.gni
[modify] https://crrev.com/3554d02ae0d95dea057406cdef9225c8ebe3f828/tools/rewrite_includes.py
[modify] https://crrev.com/3554d02ae0d95dea057406cdef9225c8ebe3f828/include/core/BUILD.bazel
[modify] https://crrev.com/3554d02ae0d95dea057406cdef9225c8ebe3f828/RELEASE_NOTES.txt
[delete] https://crrev.com/1ace2d223d23dfe2f431c3cc3e813f924fc6fdaf/include/core/SkMath.h
[modify] https://crrev.com/3554d02ae0d95dea057406cdef9225c8ebe3f828/public.bzl
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #36
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/46572b4d445f41943059d0e377afc6d6748cd5ca
commit 46572b4d445f41943059d0e377afc6d6748cd5ca
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 18 18:11:06 2023
[base] Move more files into base
Moved from include/private into include/private/base:
- SkFloatingPoint.h
- SkMacros.h
- SkSafe32.h
- SkTLogic.h
- SkTPin.h
- SkTemplates.h
Moved from src/core into src/base:
- SkDeque.cpp
- SkFloatingPoint.cpp
- SkTDArray.cpp
- SkLeanWindows.h
- SkMalloc.cpp
- SkSafeMath.h
- SkSemaphore.cpp
- SkSafeMath.cpp*
Some constants were moved from SkTypes.h into SkMath.h
and the implementation of SkSafeMath was put into its own
file (instead of being in SkMath.cpp)
A shim was added for SkTemplates.h, due to a few uses
lingering in Android.
- frameworks/base/libs/hwui/SkiaCanvas.cpp
- frameworks/base/libs/hwui/pipeline/skia/SkiaRecordingCanvas.cpp
- frameworks/base/libs/hwui/jni/Graphics.cpp
- vendor/...GIFDecode.cpp
Client CLs:
- http://ag/21017148
Suggested review order:
- include/private/base/BUILD.bazel
- include/private/BUILD.bazel
- include/BUILD.bazel
- gn/*.gni (these are generated from the BUILD.bazel files)
- BUILD.gn
- public.bzl
- Everything else, mostly done with find and replace and
cleaned up with the rewrite_includes.py script.
Change-Id: If80cfac68fed4219c4ea144f428461d2426bed24
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/630545
Reviewed-by: Herb Derby <herb@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/particles/include/SkParticleData.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/sksl/analysis/SkSLCheckProgramStructure.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/ColorSpaceTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsAsWinding.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkRRect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/imagefilters/SkBlurImageFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkWebpCodec.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkFontConfigInterface_direct.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/TextBlobTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkIcoCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/TriangulatingPathRendererTests.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/FloatingPointTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/EGLImageTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMath.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/CodecTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkPixmap.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkTypeface_mac_ct.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skunicode/src/SkUnicode.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skparagraph/src/ParagraphImpl.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMaskGamma.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkImageInfo.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/win/SkDWriteFontFileStream.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/addarc.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skparagraph/src/Run.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/d3d/GrD3DPipelineState.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkColorSpaceXformSteps.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/gl/win/GrGLMakeNativeInterface_win.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkBigPicture.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkString.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/viewer/SkottieSlide.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/Stats.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/SkShadowUtils.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/sksl/ir/SkSLFunctionDefinition.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkColor.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/AAClipTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/imagefilters/SkMagnifierImageFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/SkPolyUtils.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/typeface.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsWinding.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/encode_alpha_jpeg.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkWbmpCodec.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMipmapAccessor.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/sksl/ir/SkSLFunctionCall.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkOpSpan.cpp
[add] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/base/SkSafeMath.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkTypeface_win_dw.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/TypefaceTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/viewer/SlideDir.cpp
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/base/SkMalloc.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/svg/src/SkSVGNode.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PathOpsDebug.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/text/RangeSelector.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkScalerContext_mac_ct.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/BrightnessContrastEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/SkTableMaskFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/TextBlobBench.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkBlockAllocator.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsTSect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pdf/SkPDFShader.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/FillEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkPathBuilder.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/fontregen.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrMemoryPool.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkOpSegment.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/LevelsEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/BlurTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PDFDeflateWStreamTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/EncodeTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMaskFilter.cpp
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/base/SkFloatingPoint.cpp
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/base/SkDeque.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkDebug_win.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/rasterhandleallocator.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/pathkit/pathkit_wasm_bindings.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkJpegCodec.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/geometry/GrStyledShape.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PaintTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/ops/TextureOp.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/SkSLInterpreterTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/FontNamesTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkSpriteBlitter_ARGB32.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathWriter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/ApplyGammaTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkFontMgr_android.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/fonts/TestSVGTypeface.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkFontMgr_mac_ct.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkPngCodec.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/SkPatchUtils.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/base/BUILD.bazel
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkRasterClip.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkImageEncoder_CG.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkOSFile_win.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/text/gpu/TextBlob.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/svg/src/SkSVGAttributeParser.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/fuzz/oss_fuzz/FuzzIncrementalImage.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkBlurMask.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/skottie2movie.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/ScaleToSidesTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ResourceKey.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skunicode/src/SkUnicode_icu.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkRecordPattern.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/images/SkJpegEncoder.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/GrStyledShapeTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/xml/SkXMLParser.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkSwizzler.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrFragmentProcessor.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrCpuBuffer.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkTHash.h
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/base/SkSemaphore.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkPaint.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/mac/SkCreateCGImageRef.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/RectangleTextureTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkFontPriv.h
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/base/SkTDArray.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/effects/GrPorterDuffXferProcessor.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkPaint.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkOSLibrary_win.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/viewer/GraphitePrimitivesSlide.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/CompositingImagesBench.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/HueSaturationEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/HardStopGradientBench_ScaleNumHardStops.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/BlendTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/BUILD.bazel
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrResourceProvider.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/svg/src/SkSVGStop.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/SafeMathTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkScalerContext.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkZip.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkPoint.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkVertices.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pdf/SkPDFGraphicState.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/timer/TimeUtils.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkTime.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkRasterPipeline.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkFontStyle.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkDrawShadowInfo.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/gpu/ganesh/GrTypesPriv.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/viewer/ImGuiLayer.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/BlackAndWhiteEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/SkGr.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsDebug.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/nanobench.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkGeometry.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/text/GlyphRun.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkBitmapProcState_matrixProcs.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkStroke.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/SkTextUtils.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/CubicRootsTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/TextBlobCacheTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/images/SkPngEncoder.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMask.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/animator/VectorKeyframeAnimator.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/gm.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gn/core.gni
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PDFPrimitivesTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkJpegxlCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkDraw.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkWriter32.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkJpegGainmap.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkCubicMap.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/gradients/GrGradientBitmapCache.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/BUILD.bazel
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/RecordDrawTest.cpp
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/base/SkLeanWindows.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/MotionTileEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/analytic_gradients.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkFontHost_win.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/FontHostTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/viewer/DegenerateQuadsSlide.cpp
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/base/SkTLogic.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkScalerCache.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/win/SkObjBase.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkJpegRCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/GrGpuBufferTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/gpu/gl/GrGLFunctions.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/Device_drawTexture.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkStream.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkStrokeRec.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/ops/AAHairLinePathRenderer.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/SkBitSet.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/sksl/analysis/SkSLGetLoopUnrollInfo.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkSampler.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/BufferWriter.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/tessellate/MiddleOutPolygonTriangulator.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkSampledCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/MatrixTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/shaders/SkPerlinNoiseShader.cpp
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/base/SkMacros.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/BUILD.bazel
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkOpSpan.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/BUILD.gn
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/win/SkIStream.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/effects/SkRuntimeEffect.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/sksg/slides/SVGPongSlide.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkCubicSolver.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkScalar.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkAndroidCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrResourceProvider.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkTextBlobPriv.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/UtilsTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkGaussFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/text/TextAdapter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/particles/src/SkParticleBinding.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bazel/exporter_tool/main.go
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/SortBench.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkGlyph.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/imagefilters/SkAlphaThresholdImageFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/svg/src/SkSVGGradient.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/gl/GrGLGpu.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/RTreeTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/layers/shapelayer/OffsetPaths.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkMatrix.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/ChecksumBench.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkRawCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkFont.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/layers/shapelayer/Gradient.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/images/SkWebpEncoder.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkImageGeneratorWIC.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/viewer/MSKPSlide.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMask.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/particles/include/SkParticleEffect.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/effects/GrPorterDuffXferProcessor.cpp
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/base/SkSafe32.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/ImageTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/strokerect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkDistanceFieldGen.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/particles/src/SkParticleEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/Composition.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/sksl/codegen/SkSLVMCodeGenerator.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkRect.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/imagefilters/SkDisplacementMapImageFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsCurve.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/CodecExactReadTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrDistanceFieldGenFromVector.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/fuzz/FuzzPolyUtils.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkOpAngle.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkPoint.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkDescriptor.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsPoint.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkBmpStandardCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/Writer32Test.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsConic.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/SkTemplates.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/base/SkMath.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/text/gpu/SDFMaskFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/InfRectTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsOp.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/CrashHandler.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrStyle.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/StreamTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkGeometry.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/xps/SkXPSDevice.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrTestUtils.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/SkShadowTessellator.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/drawatlas.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/lazy/SkDiscardableMemoryPool.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/MemsetBench.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skshaper/src/SkShaper_coretext.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/encode/SkEncoder.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkPicturePlayback.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/rewrite_includes.py
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/sksg/src/SkSGPaint.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkImageEncoder_WIC.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkTypeface_win_dw.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkTypes.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/SkDashPathEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkOpSegment.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMesh.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/gl/mac/GrGLMakeNativeInterface_mac.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/layers/shapelayer/Polystar.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/TestUtils.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkAAClip.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkYUVAInfo.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/Skottie.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkReadBuffer.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/GlowStyles.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/graphite/PaintParamsKey.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/imagefilters/SkLightingImageFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/gl/iOS/GrGLMakeNativeInterface_iOS.cpp
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/base/SkTPin.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkFontDescriptor.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/PolyUtilsBench.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/vk/GrVkRenderPass.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PathTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/svg/include/SkSVGDOM.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkBitmapProcState.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/viewer/QuadStrokerSlide.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkCanvas.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/wacky_yuv_formats.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkFont.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMathPriv.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/QuadRootsTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/fonts/SkFontMgr_indirect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/particles/src/SkParticleDrawable.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkColorSpacePriv.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMatrixInvert.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrDataUtils.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMatrix.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/SerializationTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/pathcontourstart.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkFontHost_FreeType.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkBmpBaseCodec.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkBuffer.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/texteffects.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkExecutor.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/base/BUILD.bazel
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/xml/SkDOM.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/tessellate/WangsFormula.h
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/base/SkFloatingPoint.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/shaders/gradients/SkSweepGradient.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkBmpMaskCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/GaussianBlurEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/p3.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PDFGlyphsToUnicodeTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkColorSpace.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkScan_Path.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PathCoverageTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/ShadowStyles.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/mac/SkUniqueCFRef.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/layers/shapelayer/Repeater.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrSamplerState.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/vk/GrVkDescriptorPool.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gn/sksl.gni
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skresources/src/SkResources.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/BUILD.bazel
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkPath.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkVM.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/SurfaceTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkOSFile_posix.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/graphite/geom/IntersectionTree.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkScan_AAAPath.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkTextBlob.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkTime.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/SkChecksum.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkRasterPipeline.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pdf/SkPDFSubsetFont.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/SkTrimPathEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skparagraph/src/TextLine.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/win/SkDWrite.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/animatedimageblurs.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/ToolUtils.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/jpg_color_cube.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/ports/SkRemotableFontMgr.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkRegion_path.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/dm/DM.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkScopeExit.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/graphite/UniformManager.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/SkHighContrastFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/ShiftChannelsEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pdf/SkPDFType1Font.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pdf/SkPDFShader.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/debugger/DrawCommand.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/SkBase64Test.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkFontMgr_custom.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/imagefilters/SkMatrixConvolutionImageFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/DropShadowEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/AsADashTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/vk/GrVkUtil.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrProcessorSet.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkOSFile.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/shaders/gradients/SkGradientShaderBase.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PathOpsQuadLineIntersectionThreadedTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/DDLTileHelper.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkJpegCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkStrikeCache.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkFontMgr_win_dw.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkAutoBlitterChoose.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/SkVMTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/SkFixed.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/WritePixelsTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/LinearWipeEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PathOpsQuadReduceOrderTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkTextBlob.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/public.bzl
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/sksg/src/SkSGGradient.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkPngCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PathOpsSimplifyRectThreadedTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/win/SkWGL.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkJpegRCodec.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkWebpCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/viewer/Viewer.cpp
[add] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/base/SkTemplates.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkEdgeBuilder.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkCompressedDataUtils.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsTypes.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkBmpRLECodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/TemplatesTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkHeifCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/graphite/geom/BoundsManager.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkBitmap.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkRegion.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/dm/DMSrcSink.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/getpostextpath.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkConvertPixels.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkImageGeneratorCG.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/SkottieTool.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkThreadID.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsCommon.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/BitmapTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkColorPriv.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkVMBlitter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkSharedMutex.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/sksl/analysis/SkSLFinalizationChecks.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/CanvasTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkPath_serial.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/dftext.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/win/SkTScopedComPtr.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/shaders/gradients/SkTwoPointConicalGradient.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMaskBlurFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrBufferAllocPool.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/graphite/DrawAtlas.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkFontMgr_android_parser.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/win/SkHRESULT.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PathOpsCubicReduceOrderTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkVM.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkImageFilter_Base.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/gpu/TestContext.h
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/base/SkSafeMath.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/CopySurfaceTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/text/gpu/SubRunAllocator.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/ScalarTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/graphite/ShaderCodeDictionary.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkStrikeCache.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkRecord.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkEdgeClipper.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/MathTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkBitmapProcState.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrDrawOpAtlas.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkFontMgr_fontconfig.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/RTreeBench.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkImageFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/GradientTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/text/SkottieShaper.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/geometry/GrAAConvexTessellator.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/FontCacheBench.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsCubic.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/win/SkAutoCoInitialize.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/RELEASE_NOTES.txt
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/gl/GrGLAssembleInterface.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PathOpsAngleTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/SurfaceSemaphoreTest.cpp
https://skia.googlesource.com/skia/+/46572b4d445f41943059d0e377afc6d6748cd5ca
commit 46572b4d445f41943059d0e377afc6d6748cd5ca
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 18 18:11:06 2023
[base] Move more files into base
Moved from include/private into include/private/base:
- SkFloatingPoint.h
- SkMacros.h
- SkSafe32.h
- SkTLogic.h
- SkTPin.h
- SkTemplates.h
Moved from src/core into src/base:
- SkDeque.cpp
- SkFloatingPoint.cpp
- SkTDArray.cpp
- SkLeanWindows.h
- SkMalloc.cpp
- SkSafeMath.h
- SkSemaphore.cpp
- SkSafeMath.cpp*
Some constants were moved from SkTypes.h into SkMath.h
and the implementation of SkSafeMath was put into its own
file (instead of being in SkMath.cpp)
A shim was added for SkTemplates.h, due to a few uses
lingering in Android.
- frameworks/base/libs/hwui/SkiaCanvas.cpp
- frameworks/base/libs/hwui/pipeline/skia/SkiaRecordingCanvas.cpp
- frameworks/base/libs/hwui/jni/Graphics.cpp
- vendor/...GIFDecode.cpp
Client CLs:
- http://ag/21017148
Suggested review order:
- include/private/base/BUILD.bazel
- include/private/BUILD.bazel
- include/BUILD.bazel
- gn/*.gni (these are generated from the BUILD.bazel files)
- BUILD.gn
- public.bzl
- Everything else, mostly done with find and replace and
cleaned up with the rewrite_includes.py script.
Change-Id: If80cfac68fed4219c4ea144f428461d2426bed24
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/630545
Reviewed-by: Herb Derby <herb@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/particles/include/SkParticleData.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/sksl/analysis/SkSLCheckProgramStructure.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/ColorSpaceTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsAsWinding.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkRRect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/imagefilters/SkBlurImageFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkWebpCodec.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkFontConfigInterface_direct.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/TextBlobTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkIcoCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/TriangulatingPathRendererTests.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/FloatingPointTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/EGLImageTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMath.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/CodecTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkPixmap.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkTypeface_mac_ct.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skunicode/src/SkUnicode.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skparagraph/src/ParagraphImpl.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMaskGamma.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkImageInfo.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/win/SkDWriteFontFileStream.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/addarc.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skparagraph/src/Run.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/d3d/GrD3DPipelineState.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkColorSpaceXformSteps.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/gl/win/GrGLMakeNativeInterface_win.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkBigPicture.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkString.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/viewer/SkottieSlide.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/Stats.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/SkShadowUtils.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/sksl/ir/SkSLFunctionDefinition.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkColor.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/AAClipTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/imagefilters/SkMagnifierImageFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/SkPolyUtils.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/typeface.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsWinding.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/encode_alpha_jpeg.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkWbmpCodec.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMipmapAccessor.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/sksl/ir/SkSLFunctionCall.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkOpSpan.cpp
[add] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/base/SkSafeMath.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkTypeface_win_dw.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/TypefaceTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/viewer/SlideDir.cpp
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/base/SkMalloc.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/svg/src/SkSVGNode.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PathOpsDebug.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/text/RangeSelector.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkScalerContext_mac_ct.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/BrightnessContrastEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/SkTableMaskFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/TextBlobBench.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkBlockAllocator.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsTSect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pdf/SkPDFShader.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/FillEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkPathBuilder.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/fontregen.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrMemoryPool.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkOpSegment.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/LevelsEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/BlurTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PDFDeflateWStreamTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/EncodeTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMaskFilter.cpp
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/base/SkFloatingPoint.cpp
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/base/SkDeque.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkDebug_win.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/rasterhandleallocator.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/pathkit/pathkit_wasm_bindings.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkJpegCodec.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/geometry/GrStyledShape.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PaintTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/ops/TextureOp.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/SkSLInterpreterTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/FontNamesTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkSpriteBlitter_ARGB32.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathWriter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/ApplyGammaTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkFontMgr_android.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/fonts/TestSVGTypeface.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkFontMgr_mac_ct.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkPngCodec.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/SkPatchUtils.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/base/BUILD.bazel
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkRasterClip.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkImageEncoder_CG.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkOSFile_win.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/text/gpu/TextBlob.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/svg/src/SkSVGAttributeParser.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/fuzz/oss_fuzz/FuzzIncrementalImage.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkBlurMask.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/skottie2movie.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/ScaleToSidesTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ResourceKey.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skunicode/src/SkUnicode_icu.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkRecordPattern.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/images/SkJpegEncoder.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/GrStyledShapeTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/xml/SkXMLParser.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkSwizzler.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrFragmentProcessor.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrCpuBuffer.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkTHash.h
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/base/SkSemaphore.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkPaint.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/mac/SkCreateCGImageRef.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/RectangleTextureTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkFontPriv.h
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/base/SkTDArray.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/effects/GrPorterDuffXferProcessor.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkPaint.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkOSLibrary_win.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/viewer/GraphitePrimitivesSlide.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/CompositingImagesBench.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/HueSaturationEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/HardStopGradientBench_ScaleNumHardStops.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/BlendTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/BUILD.bazel
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrResourceProvider.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/svg/src/SkSVGStop.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/SafeMathTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkScalerContext.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkZip.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkPoint.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkVertices.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pdf/SkPDFGraphicState.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/timer/TimeUtils.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkTime.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkRasterPipeline.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkFontStyle.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkDrawShadowInfo.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/gpu/ganesh/GrTypesPriv.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/viewer/ImGuiLayer.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/BlackAndWhiteEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/SkGr.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsDebug.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/nanobench.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkGeometry.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/text/GlyphRun.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkBitmapProcState_matrixProcs.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkStroke.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/SkTextUtils.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/CubicRootsTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/TextBlobCacheTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/images/SkPngEncoder.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMask.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/animator/VectorKeyframeAnimator.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/gm.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gn/core.gni
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PDFPrimitivesTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkJpegxlCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkDraw.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkWriter32.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkJpegGainmap.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkCubicMap.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/gradients/GrGradientBitmapCache.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/BUILD.bazel
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/RecordDrawTest.cpp
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/base/SkLeanWindows.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/MotionTileEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/analytic_gradients.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkFontHost_win.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/FontHostTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/viewer/DegenerateQuadsSlide.cpp
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/base/SkTLogic.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkScalerCache.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/win/SkObjBase.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkJpegRCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/GrGpuBufferTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/gpu/gl/GrGLFunctions.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/Device_drawTexture.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkStream.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkStrokeRec.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/ops/AAHairLinePathRenderer.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/SkBitSet.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/sksl/analysis/SkSLGetLoopUnrollInfo.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkSampler.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/BufferWriter.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/tessellate/MiddleOutPolygonTriangulator.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkSampledCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/MatrixTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/shaders/SkPerlinNoiseShader.cpp
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/base/SkMacros.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/BUILD.bazel
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkOpSpan.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/BUILD.gn
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/win/SkIStream.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/effects/SkRuntimeEffect.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/sksg/slides/SVGPongSlide.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkCubicSolver.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkScalar.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkAndroidCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrResourceProvider.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkTextBlobPriv.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/UtilsTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkGaussFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/text/TextAdapter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/particles/src/SkParticleBinding.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bazel/exporter_tool/main.go
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/SortBench.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkGlyph.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/imagefilters/SkAlphaThresholdImageFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/svg/src/SkSVGGradient.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/gl/GrGLGpu.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/RTreeTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/layers/shapelayer/OffsetPaths.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkMatrix.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/ChecksumBench.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkRawCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkFont.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/layers/shapelayer/Gradient.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/images/SkWebpEncoder.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkImageGeneratorWIC.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/viewer/MSKPSlide.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMask.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/particles/include/SkParticleEffect.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/effects/GrPorterDuffXferProcessor.cpp
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/base/SkSafe32.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/ImageTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/strokerect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkDistanceFieldGen.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/particles/src/SkParticleEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/Composition.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/sksl/codegen/SkSLVMCodeGenerator.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkRect.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/imagefilters/SkDisplacementMapImageFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsCurve.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/CodecExactReadTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrDistanceFieldGenFromVector.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/fuzz/FuzzPolyUtils.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkOpAngle.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkPoint.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkDescriptor.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsPoint.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkBmpStandardCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/Writer32Test.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsConic.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/SkTemplates.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/base/SkMath.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/text/gpu/SDFMaskFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/InfRectTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsOp.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/CrashHandler.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrStyle.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/StreamTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkGeometry.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/xps/SkXPSDevice.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrTestUtils.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/SkShadowTessellator.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/drawatlas.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/lazy/SkDiscardableMemoryPool.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/MemsetBench.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skshaper/src/SkShaper_coretext.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/encode/SkEncoder.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkPicturePlayback.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/rewrite_includes.py
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/sksg/src/SkSGPaint.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkImageEncoder_WIC.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkTypeface_win_dw.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkTypes.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/SkDashPathEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkOpSegment.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMesh.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/gl/mac/GrGLMakeNativeInterface_mac.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/layers/shapelayer/Polystar.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/TestUtils.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkAAClip.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkYUVAInfo.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/Skottie.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkReadBuffer.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/GlowStyles.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/graphite/PaintParamsKey.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/imagefilters/SkLightingImageFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/gl/iOS/GrGLMakeNativeInterface_iOS.cpp
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/base/SkTPin.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkFontDescriptor.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/PolyUtilsBench.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/vk/GrVkRenderPass.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PathTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/svg/include/SkSVGDOM.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkBitmapProcState.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/viewer/QuadStrokerSlide.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkCanvas.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/wacky_yuv_formats.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkFont.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMathPriv.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/QuadRootsTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/fonts/SkFontMgr_indirect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/particles/src/SkParticleDrawable.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkColorSpacePriv.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMatrixInvert.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrDataUtils.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMatrix.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/SerializationTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/pathcontourstart.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkFontHost_FreeType.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkBmpBaseCodec.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkBuffer.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/texteffects.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkExecutor.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/base/BUILD.bazel
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/xml/SkDOM.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/tessellate/WangsFormula.h
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/base/SkFloatingPoint.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/shaders/gradients/SkSweepGradient.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkBmpMaskCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/GaussianBlurEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/p3.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PDFGlyphsToUnicodeTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkColorSpace.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkScan_Path.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PathCoverageTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/ShadowStyles.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/mac/SkUniqueCFRef.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/layers/shapelayer/Repeater.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrSamplerState.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/vk/GrVkDescriptorPool.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gn/sksl.gni
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skresources/src/SkResources.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/BUILD.bazel
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkPath.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkVM.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/SurfaceTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkOSFile_posix.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/graphite/geom/IntersectionTree.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkScan_AAAPath.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkTextBlob.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkTime.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/SkChecksum.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkRasterPipeline.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pdf/SkPDFSubsetFont.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/SkTrimPathEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skparagraph/src/TextLine.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/win/SkDWrite.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/animatedimageblurs.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/ToolUtils.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/jpg_color_cube.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/ports/SkRemotableFontMgr.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkRegion_path.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/dm/DM.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkScopeExit.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/graphite/UniformManager.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/SkHighContrastFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/ShiftChannelsEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pdf/SkPDFType1Font.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pdf/SkPDFShader.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/debugger/DrawCommand.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/SkBase64Test.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkFontMgr_custom.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/effects/imagefilters/SkMatrixConvolutionImageFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/DropShadowEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/AsADashTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/vk/GrVkUtil.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrProcessorSet.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkOSFile.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/shaders/gradients/SkGradientShaderBase.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PathOpsQuadLineIntersectionThreadedTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/DDLTileHelper.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkJpegCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkStrikeCache.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkFontMgr_win_dw.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkAutoBlitterChoose.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/SkVMTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/SkFixed.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/WritePixelsTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/effects/LinearWipeEffect.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PathOpsQuadReduceOrderTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkTextBlob.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/public.bzl
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/sksg/src/SkSGGradient.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkPngCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PathOpsSimplifyRectThreadedTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/win/SkWGL.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkJpegRCodec.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkWebpCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/viewer/Viewer.cpp
[add] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/private/base/SkTemplates.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkEdgeBuilder.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkCompressedDataUtils.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsTypes.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkBmpRLECodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/TemplatesTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/codec/SkHeifCodec.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/graphite/geom/BoundsManager.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkBitmap.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkRegion.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/dm/DMSrcSink.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/getpostextpath.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkConvertPixels.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkImageGeneratorCG.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/SkottieTool.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkThreadID.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsCommon.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/BitmapTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/include/core/SkColorPriv.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkVMBlitter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkSharedMutex.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/sksl/analysis/SkSLFinalizationChecks.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/CanvasTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkPath_serial.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/gm/dftext.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/win/SkTScopedComPtr.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/shaders/gradients/SkTwoPointConicalGradient.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkMaskBlurFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrBufferAllocPool.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/graphite/DrawAtlas.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkFontMgr_android_parser.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/win/SkHRESULT.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PathOpsCubicReduceOrderTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkVM.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkImageFilter_Base.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tools/gpu/TestContext.h
[rename] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/base/SkSafeMath.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/CopySurfaceTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/text/gpu/SubRunAllocator.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/ScalarTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/graphite/ShaderCodeDictionary.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkStrikeCache.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkRecord.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkEdgeClipper.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/MathTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkBitmapProcState.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/GrDrawOpAtlas.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/ports/SkFontMgr_fontconfig.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/RTreeBench.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/core/SkImageFilter.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/GradientTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/modules/skottie/src/text/SkottieShaper.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/geometry/GrAAConvexTessellator.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/bench/FontCacheBench.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/pathops/SkPathOpsCubic.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/utils/win/SkAutoCoInitialize.h
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/RELEASE_NOTES.txt
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/src/gpu/ganesh/gl/GrGLAssembleInterface.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/PathOpsAngleTest.cpp
[modify] https://crrev.com/46572b4d445f41943059d0e377afc6d6748cd5ca/tests/SurfaceSemaphoreTest.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #37
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/1b3aa8b6e1cc82991861082ab45a0b62aad56288
commit 1b3aa8b6e1cc82991861082ab45a0b62aad56288
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jan 19 19:03:31 2023
[base] Move more files into base
The general answer to "What goes in base?" is "code which
would be generally useful outside of a graphics library".
As such, I'm moving several helpers we have for managing
memory, as long as the remaining files which were needed
to be in base during the proof-of-concept build [1].
Moved from include/private into include/private/base:
- SkNoncopyable.h
Moved from src/core into src/base:
- SkArenaAlloc.cpp
- SkArenaAlloc.h
- SkArenaAllocList.h
- SkASAN.h
- SkAutoMalloc.h
- SkBlockAllocator.cpp
- SkBlockAllocator.h
- SkMathPriv.cpp
- SkMathPriv.h"
- SkScopeExit.h
- SkTBlockList.h
- SkTDArray.cpp
- SkThreadID.cpp
- SkTLazy.h
- SkUTF.cpp
- SkUTF.h
I moved SkUNREACHABLE out of SkTypes and into SkAssert.h since
it felt assert-like.
This adds GrMemoryPool.cpp/.h to the list of files for which
we enforce IWYU, because it wasn't including <memory> and
broke when I enforced IWYU on SkBlockAllocator.
Suggested review order:
- include/private/base/BUILD.bazel
- include/private/BUILD.bazel
- include/BUILD.bazel
- gn/*.gni (these are generated from the BUILD.bazel files)
- BUILD.gn
- public.bzl
- include/core/SkTypes.h and include/core/SkAssert.h
- Everything else, mostly done with find and replace and
cleaned up with the rewrite_includes.py script.
[1] https://skia-review.googlesource.com/c/skia/+/616777
Change-Id: I8d9a7cff89cea425a0ff4e2ee7ccb15abb021217
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/631422
Reviewed-by: Ben Wagner <bungeman@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/include/SkSVGAttribute.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/tessellate/GrPathTessellationShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkFontStream.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrGpuResource.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/effects/imagefilters/SkBlurImageFilter.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkBlockAllocator.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkFontConfigInterface_direct.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/TriangulatingPathRendererTests.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/ColorFilterTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skottie/src/text/Font.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/CodecTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkTypeface_mac_ct.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/sksl/ir/SkSLModifiers.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pdf/SkPDFUtils.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkPathOpsQuad.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/AndroidCodecBench.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/fuzz/FuzzGradients.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrHashMapWithCache.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkTypeface.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skparagraph/src/Run.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBlitter_Sprite.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrNonAtomicRef.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pdf/SkPDFDocument.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/GrMeshTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkString.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBigPicture.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gm/drawminibitmaprect.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/utils/SkJSON.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/SkottieSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/PipelineDataCache.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkTSort.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/tessellate/PathTessellator.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/text/gpu/StrikeCache.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkCanvasPriv.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/AndroidShadowsSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skunicode/include/SkUnicode.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/JSONTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkOpBuilder.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/SkUTFTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkPathOpsWinding.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/PrimitiveProcessorTest.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkArenaAlloc.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkPathOpsTSect.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkMipmapAccessor.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/fonts/ToolUtilsFont.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/TypefaceTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/CanvasStateTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/src/SkSVGNode.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrMeshDrawTarget.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/PathOpsDebug.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/FontTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkScalerContext_mac_ct.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkScalerContext_mac_ct.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/src/SkSVGText.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/DrawCommands.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/sk_app/win/Window_win.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/text/AtlasManager.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrMemoryPool.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkScan_Hairline.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/DrawPass.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkColorShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkOpSegment.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/codec/SkAndroidCodec.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkColorFilter.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/BlurTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gm/scaledemoji.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkMaskFilter.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/src/SkSVGTextPriv.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkDeferredDisplayList.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/DDLPromiseImageHelper.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkClipStack.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/gl/GrGLCaps.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/geometry/GrStyledShape.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/PaintTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrVertexChunkArray.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/ops/TextureOp.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/ArcSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/ImageGeneratorTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/docs/SkPDFDocument.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkSpriteBlitter_ARGB32.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/dawn/GrDawnProgramDataManager.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gn/utils.gni
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/SubsetPath.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkFontMgr_mac_ct.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/utils/SkPatchUtils.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/private/base/BUILD.bazel
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skparagraph/src/OneLineShaper.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/debugger/DrawCommand.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBlitter.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkOSFile_win.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/src/SkSVGAttributeParser.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/VkHardwareBufferTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/effects/GrDistanceFieldGeoProc.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBlurMask.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkTaskGroup.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/Device.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/codec/SkSampler.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skunicode/src/SkUnicode_icu.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/ClipStack_graphite.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skshaper/src/SkShaper_primitive.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkOpContour.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/images/SkJpegEncoder.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/MallocPixelRefTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/sksl/codegen/SkSLMetalCodeGenerator.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/sk_app/MetalWindowContext.mm
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/SkGlyphCacheBench.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gm/coloremoji_blendmodes.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkEdge.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkScalerContext.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkICC.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/VerticesTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/codec/SkCodec.h
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkMathPriv.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkPicture.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkMathPriv.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkScopeExit.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/TextBoxSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/gradients/GrGradientBitmapCache.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/BUILD.bazel
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/ArenaAllocTest.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkTLazy.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/VkPriorityExtensionTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/ClipStack.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/ops/DrawMeshOp.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkRectPriv.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/geometry/GrTriangulator.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/sfnt/SkOTTable_name.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gm/convexpaths.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/experimental/sktext/slides/Text.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skshaper/src/SkShaper.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/RasterPipelineBuilderTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkFontHost_FreeType_common.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkCanvas.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkDevice.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/text/GrAtlasManager.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/graphite/BoundsManagerBench.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/nanobench.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/sksg/src/SkSGDraw.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/images/SkPngEncoder.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/PathOpsAngleIdeas.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/AnimatedTextSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkImageShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pdf/SkClusterator.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gn/core.gni
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkWriter32.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/include/SkSVGValue.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkDraw.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrAutoLocaleSetter.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/fonts/create_test_font.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/mtl/GrMtlGpu.mm
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/BUILD.bazel
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/mock/GrMockCaps.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/GlyphQuadFillBench.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/tessellate/FixedCountBufferUtils.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkMessageBus.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/Test.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/FontHostTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkFontHost_win.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkScalerCache.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkAAClip.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkPathOpsTightBounds.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkPathOpsSimplify.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrThreadSafeCache.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/PathRendererChain.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/utils/SkBitSet.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/sk_app/DawnWindowContext.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/tessellate/MiddleOutPolygonTriangulator.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/codec/SkSampledCodec.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/ColorTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkOpCoincidence.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/LayersSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkAnalyticEdge.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkPerlinNoiseShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrBufferAllocPool.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/sk_app/unix/Window_unix.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/include/SkSVGTypes.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/private/BUILD.bazel
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkRemotableFontMgr_win_dw.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/BUILD.gn
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/RectanizerPow2.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/fuzz/FuzzCanvas.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrResourceProvider.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/effects/GrShadowGeoProc.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkCachedData.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/ops/OpsTask.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/utils/SkCamera.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkGlyph.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skottie/src/SkottiePriv.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/gl/GrGLGpu.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/SRGBTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkFont.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBitmapDevice.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkMaskFilterBase.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkDistanceFieldGen.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/particles/src/SkParticleEffect.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/ops/DefaultPathRenderer.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skunicode/src/SkUnicode_client.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/effects/GrBezierEffect.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/PatchSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrDistanceFieldGenFromVector.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/ShadowUtilsSlide.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkTBlockList.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkDescriptor.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBlenderBase.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/convert-to-nia.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/TextureOpTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/codec/SkBmpStandardCodec.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skparagraph/utils/TestFontCollection.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/Writer32Test.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkStrikeSpec.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrResourceCache.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkASAN.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/geom/IntersectionTree.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkPathOpsOp.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/StreamTest.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkThreadID.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkOSFile_stdio.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrSPIRVUniformHandler.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkRasterPipelineBlitter.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pdf/SkPDFMakeToUnicodeCmap.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/xps/SkXPSDevice.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/dawn/GrDawnGpu.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/PathSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gm/drawatlas.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/PathEffectsSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skshaper/src/SkShaper_coretext.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/encode/SkEncoder.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrProcessorUnitTest.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/geometry/GrPathUtils.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/include/SkSVGAttributeParser.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkImageEncoder_WIC.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/SkTBlockListTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/core/SkTypes.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkEdgeBuilder.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/effects/SkLayerDrawLooper.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/DrawList.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/effects/SkTableColorFilter.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/gpu/vk/VkTestUtils.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkReadBuffer.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/gpu/GrTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skottie/src/layers/shapelayer/ShapeLayer.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/MathBench.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pdf/SkPDFMetadata.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrSurface.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/ops/AtlasTextOp.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrGpu.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/RegionTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkFontDescriptor.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkChromeRemoteGlyphCache.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkLocalMatrixShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/PathTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/effects/SkEmbossMask.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/include/SkSVGRenderContext.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/gpu/YUVUtils.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gm/drawbitmaprect.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/utils/BUILD.bazel
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkShaderBase.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/image/SkImage_Gpu.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/particles/src/SkParticleDrawable.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkDraw_vertices.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/codec/SkJpegDecoderMgr.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pdf/SkPDFFont.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkStringUtils.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skottie/src/layers/PrecompLayer.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrDataUtils.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/SerializationTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/ClipStack.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/sksl/ir/SkSLType.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBuffer.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkColorFilterShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/SkSLTest.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkUTF.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkModeColorFilter.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrDirectContext.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skshaper/src/SkShaper_harfbuzz.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/BUILD.bazel
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/xml/SkDOM.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/PathCoverageTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/UnicodeTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/image/SkImage_GpuYUVA.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBlurMF.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/MSKPPlayer.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/TriangulatorBench.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/gradients/GrGradientShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skottie/src/animator/KeyframeAnimator.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrRenderTargetProxy.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/sk_app/VulkanWindowContext.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrSamplerState.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/BUILD.bazel
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skplaintexteditor/src/editor.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gn/sksl.gni
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkPath.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkScan_AAAPath.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/Registry.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skparagraph/tests/SkShaperJSONWriterTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/gl/builders/GrGLProgramBuilder.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skottie/src/effects/MotionBlurEffect.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/sk_app/android/surface_glue_android.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/private/SkChecksum.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkComposeShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/sk_app/win/RasterWindowContext_win.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkRasterPipeline.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/utils/SkJSONWriter.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrPaint.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/mtl/GrMtlPipelineStateDataManager.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrOpFlushState.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gm/composeshader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/ops/StrokeTessellateOp.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/graphite/IntersectionTreeBench.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/private/base/SkNoncopyable.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/CodecBench.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/glsl/GrGLSLShaderBuilder.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/FrontBufferedStreamTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/debugger/DrawCommand.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/effects/GrBitmapTextGeoProc.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/mtl/GrMtlUniformHandler.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/GrPipelineDynamicStateTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skparagraph/tests/SkShaperJSONWriter.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrBlurUtils.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkUTF.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/sk_app/GLWindowContext.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkPathOpsCubic.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkPictureData.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/glsl/GrGLSLProgramDataManager.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkGpuBlurUtils.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkPathOpsConic.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/utils/SkJSON.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkFontMgr_win_dw.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkAutoMalloc.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/tessellate/GrTessellationShader.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkAutoBlitterChoose.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/sksl/codegen/SkSLRasterPipelineBuilder.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/MaterialShadowsSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/codec/SkFrameHolder.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gm/imagefromyuvtextures.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/gl/builders/GrGLShaderStringBuilder.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/WritePixelsTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/RectanizerSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/text/gpu/StrikeCache.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/private/base/SkAssert.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkDrawLooper.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkMaskGamma.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/public.bzl
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/TLazyTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/codec/SkPngCodec.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkArenaAllocList.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkMipmap.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrResourceAllocator.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkDevice.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/sk_app/GraphiteMetalWindowContext.mm
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/SkRuntimeEffectTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/ops/AtlasRenderTask.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/TypefaceBench.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/ops/OpsTask.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/sksg/src/SkSGInvalidationController.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkCompressedDataUtils.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/effects/GrRRectEffect.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skparagraph/slides/ParagraphSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkVMBlitter.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pdf/SkPDFTag.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/vk/GrVkUniformHandler.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/geom/BoundsManager.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/gl/GrGLProgramDataManager.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/dm/DMSrcSink.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/src/SkSVGPoly.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkBitmapProcShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/include/SkSVGSVG.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/PathClipSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkCanvasPriv.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkVMBlitter.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrDefaultGeoProcFactory.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/RasterPipelineCodeGeneratorTest.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkBlockAllocator.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skparagraph/src/ParagraphStyle.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skparagraph/src/ParagraphImpl.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrDynamicAtlas.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/SkBlockAllocatorTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkMaskBlurFilter.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrUniformDataManager.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skplaintexteditor/src/shape.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/DrawAtlas.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkXfermode.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gm/asyncrescaleandread.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/gpu/TestContext.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrRecordingContext.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/glsl/GrGLSLVarying.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/text/gpu/SubRunAllocator.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/ShaderCodeDictionary.h
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkArenaAlloc.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/tessellate/StrokeTessellator.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkRecord.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/CmapBench.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/MathTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBitmapProcState.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/GradientTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skottie/src/text/SkottieShaper.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBlitter.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/utils/win/SkAutoCoInitialize.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkRasterClipStack.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrMemoryPool.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/PathOpsAngleTest.cpp
https://skia.googlesource.com/skia/+/1b3aa8b6e1cc82991861082ab45a0b62aad56288
commit 1b3aa8b6e1cc82991861082ab45a0b62aad56288
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jan 19 19:03:31 2023
[base] Move more files into base
The general answer to "What goes in base?" is "code which
would be generally useful outside of a graphics library".
As such, I'm moving several helpers we have for managing
memory, as long as the remaining files which were needed
to be in base during the proof-of-concept build [1].
Moved from include/private into include/private/base:
- SkNoncopyable.h
Moved from src/core into src/base:
- SkArenaAlloc.cpp
- SkArenaAlloc.h
- SkArenaAllocList.h
- SkASAN.h
- SkAutoMalloc.h
- SkBlockAllocator.cpp
- SkBlockAllocator.h
- SkMathPriv.cpp
- SkMathPriv.h"
- SkScopeExit.h
- SkTBlockList.h
- SkTDArray.cpp
- SkThreadID.cpp
- SkTLazy.h
- SkUTF.cpp
- SkUTF.h
I moved SkUNREACHABLE out of SkTypes and into SkAssert.h since
it felt assert-like.
This adds GrMemoryPool.cpp/.h to the list of files for which
we enforce IWYU, because it wasn't including <memory> and
broke when I enforced IWYU on SkBlockAllocator.
Suggested review order:
- include/private/base/BUILD.bazel
- include/private/BUILD.bazel
- include/BUILD.bazel
- gn/*.gni (these are generated from the BUILD.bazel files)
- BUILD.gn
- public.bzl
- include/core/SkTypes.h and include/core/SkAssert.h
- Everything else, mostly done with find and replace and
cleaned up with the rewrite_includes.py script.
[1] https://skia-review.googlesource.com/c/skia/+/616777
Change-Id: I8d9a7cff89cea425a0ff4e2ee7ccb15abb021217
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/631422
Reviewed-by: Ben Wagner <bungeman@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/include/SkSVGAttribute.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/tessellate/GrPathTessellationShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkFontStream.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrGpuResource.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/effects/imagefilters/SkBlurImageFilter.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkBlockAllocator.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkFontConfigInterface_direct.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/TriangulatingPathRendererTests.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/ColorFilterTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skottie/src/text/Font.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/CodecTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkTypeface_mac_ct.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/sksl/ir/SkSLModifiers.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pdf/SkPDFUtils.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkPathOpsQuad.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/AndroidCodecBench.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/fuzz/FuzzGradients.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrHashMapWithCache.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkTypeface.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skparagraph/src/Run.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBlitter_Sprite.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrNonAtomicRef.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pdf/SkPDFDocument.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/GrMeshTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkString.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBigPicture.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gm/drawminibitmaprect.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/utils/SkJSON.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/SkottieSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/PipelineDataCache.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkTSort.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/tessellate/PathTessellator.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/text/gpu/StrikeCache.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkCanvasPriv.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/AndroidShadowsSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skunicode/include/SkUnicode.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/JSONTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkOpBuilder.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/SkUTFTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkPathOpsWinding.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/PrimitiveProcessorTest.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkArenaAlloc.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkPathOpsTSect.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkMipmapAccessor.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/fonts/ToolUtilsFont.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/TypefaceTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/CanvasStateTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/src/SkSVGNode.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrMeshDrawTarget.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/PathOpsDebug.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/FontTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkScalerContext_mac_ct.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkScalerContext_mac_ct.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/src/SkSVGText.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/DrawCommands.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/sk_app/win/Window_win.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/text/AtlasManager.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrMemoryPool.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkScan_Hairline.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/DrawPass.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkColorShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkOpSegment.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/codec/SkAndroidCodec.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkColorFilter.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/BlurTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gm/scaledemoji.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkMaskFilter.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/src/SkSVGTextPriv.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkDeferredDisplayList.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/DDLPromiseImageHelper.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkClipStack.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/gl/GrGLCaps.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/geometry/GrStyledShape.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/PaintTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrVertexChunkArray.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/ops/TextureOp.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/ArcSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/ImageGeneratorTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/docs/SkPDFDocument.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkSpriteBlitter_ARGB32.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/dawn/GrDawnProgramDataManager.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gn/utils.gni
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/SubsetPath.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkFontMgr_mac_ct.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/utils/SkPatchUtils.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/private/base/BUILD.bazel
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skparagraph/src/OneLineShaper.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/debugger/DrawCommand.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBlitter.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkOSFile_win.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/src/SkSVGAttributeParser.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/VkHardwareBufferTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/effects/GrDistanceFieldGeoProc.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBlurMask.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkTaskGroup.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/Device.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/codec/SkSampler.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skunicode/src/SkUnicode_icu.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/ClipStack_graphite.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skshaper/src/SkShaper_primitive.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkOpContour.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/images/SkJpegEncoder.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/MallocPixelRefTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/sksl/codegen/SkSLMetalCodeGenerator.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/sk_app/MetalWindowContext.mm
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/SkGlyphCacheBench.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gm/coloremoji_blendmodes.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkEdge.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkScalerContext.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkICC.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/VerticesTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/codec/SkCodec.h
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkMathPriv.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkPicture.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkMathPriv.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkScopeExit.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/TextBoxSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/gradients/GrGradientBitmapCache.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/BUILD.bazel
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/ArenaAllocTest.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkTLazy.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/VkPriorityExtensionTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/ClipStack.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/ops/DrawMeshOp.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkRectPriv.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/geometry/GrTriangulator.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/sfnt/SkOTTable_name.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gm/convexpaths.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/experimental/sktext/slides/Text.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skshaper/src/SkShaper.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/RasterPipelineBuilderTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkFontHost_FreeType_common.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkCanvas.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkDevice.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/text/GrAtlasManager.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/graphite/BoundsManagerBench.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/nanobench.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/sksg/src/SkSGDraw.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/images/SkPngEncoder.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/PathOpsAngleIdeas.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/AnimatedTextSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkImageShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pdf/SkClusterator.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gn/core.gni
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkWriter32.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/include/SkSVGValue.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkDraw.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrAutoLocaleSetter.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/fonts/create_test_font.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/mtl/GrMtlGpu.mm
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/BUILD.bazel
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/mock/GrMockCaps.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/GlyphQuadFillBench.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/tessellate/FixedCountBufferUtils.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkMessageBus.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/Test.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/FontHostTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkFontHost_win.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkScalerCache.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkAAClip.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkPathOpsTightBounds.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkPathOpsSimplify.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrThreadSafeCache.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/PathRendererChain.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/utils/SkBitSet.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/sk_app/DawnWindowContext.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/tessellate/MiddleOutPolygonTriangulator.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/codec/SkSampledCodec.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/ColorTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkOpCoincidence.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/LayersSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkAnalyticEdge.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkPerlinNoiseShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrBufferAllocPool.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/sk_app/unix/Window_unix.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/include/SkSVGTypes.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/private/BUILD.bazel
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkRemotableFontMgr_win_dw.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/BUILD.gn
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/RectanizerPow2.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/fuzz/FuzzCanvas.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrResourceProvider.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/effects/GrShadowGeoProc.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkCachedData.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/ops/OpsTask.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/utils/SkCamera.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkGlyph.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skottie/src/SkottiePriv.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/gl/GrGLGpu.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/SRGBTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkFont.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBitmapDevice.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkMaskFilterBase.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkDistanceFieldGen.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/particles/src/SkParticleEffect.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/ops/DefaultPathRenderer.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skunicode/src/SkUnicode_client.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/effects/GrBezierEffect.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/PatchSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrDistanceFieldGenFromVector.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/ShadowUtilsSlide.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkTBlockList.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkDescriptor.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBlenderBase.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/convert-to-nia.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/TextureOpTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/codec/SkBmpStandardCodec.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skparagraph/utils/TestFontCollection.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/Writer32Test.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkStrikeSpec.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrResourceCache.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkASAN.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/geom/IntersectionTree.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkPathOpsOp.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/StreamTest.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkThreadID.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkOSFile_stdio.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrSPIRVUniformHandler.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkRasterPipelineBlitter.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pdf/SkPDFMakeToUnicodeCmap.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/xps/SkXPSDevice.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/dawn/GrDawnGpu.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/PathSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gm/drawatlas.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/PathEffectsSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skshaper/src/SkShaper_coretext.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/encode/SkEncoder.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrProcessorUnitTest.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/geometry/GrPathUtils.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/include/SkSVGAttributeParser.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkImageEncoder_WIC.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/SkTBlockListTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/core/SkTypes.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkEdgeBuilder.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/effects/SkLayerDrawLooper.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/DrawList.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/effects/SkTableColorFilter.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/gpu/vk/VkTestUtils.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkReadBuffer.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/gpu/GrTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skottie/src/layers/shapelayer/ShapeLayer.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/MathBench.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pdf/SkPDFMetadata.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrSurface.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/ops/AtlasTextOp.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrGpu.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/RegionTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkFontDescriptor.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkChromeRemoteGlyphCache.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkLocalMatrixShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/PathTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/effects/SkEmbossMask.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/include/SkSVGRenderContext.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/gpu/YUVUtils.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gm/drawbitmaprect.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/utils/BUILD.bazel
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkShaderBase.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/image/SkImage_Gpu.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/particles/src/SkParticleDrawable.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkDraw_vertices.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/codec/SkJpegDecoderMgr.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pdf/SkPDFFont.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkStringUtils.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skottie/src/layers/PrecompLayer.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrDataUtils.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/SerializationTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/ClipStack.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/sksl/ir/SkSLType.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBuffer.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkColorFilterShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/SkSLTest.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkUTF.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkModeColorFilter.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrDirectContext.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skshaper/src/SkShaper_harfbuzz.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/BUILD.bazel
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/xml/SkDOM.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/PathCoverageTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/UnicodeTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/image/SkImage_GpuYUVA.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBlurMF.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/MSKPPlayer.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/TriangulatorBench.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/gradients/GrGradientShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skottie/src/animator/KeyframeAnimator.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrRenderTargetProxy.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/sk_app/VulkanWindowContext.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrSamplerState.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/BUILD.bazel
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skplaintexteditor/src/editor.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gn/sksl.gni
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkPath.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkScan_AAAPath.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/Registry.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skparagraph/tests/SkShaperJSONWriterTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/gl/builders/GrGLProgramBuilder.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skottie/src/effects/MotionBlurEffect.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/sk_app/android/surface_glue_android.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/private/SkChecksum.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkComposeShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/sk_app/win/RasterWindowContext_win.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkRasterPipeline.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/utils/SkJSONWriter.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrPaint.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/mtl/GrMtlPipelineStateDataManager.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrOpFlushState.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gm/composeshader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/ops/StrokeTessellateOp.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/graphite/IntersectionTreeBench.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/private/base/SkNoncopyable.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/CodecBench.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/glsl/GrGLSLShaderBuilder.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/FrontBufferedStreamTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/debugger/DrawCommand.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/effects/GrBitmapTextGeoProc.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/mtl/GrMtlUniformHandler.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/GrPipelineDynamicStateTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skparagraph/tests/SkShaperJSONWriter.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrBlurUtils.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkUTF.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/sk_app/GLWindowContext.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkPathOpsCubic.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkPictureData.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/glsl/GrGLSLProgramDataManager.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkGpuBlurUtils.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pathops/SkPathOpsConic.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/utils/SkJSON.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/ports/SkFontMgr_win_dw.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkAutoMalloc.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/tessellate/GrTessellationShader.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkAutoBlitterChoose.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/sksl/codegen/SkSLRasterPipelineBuilder.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/MaterialShadowsSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/codec/SkFrameHolder.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gm/imagefromyuvtextures.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/gl/builders/GrGLShaderStringBuilder.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/WritePixelsTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/RectanizerSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/text/gpu/StrikeCache.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/include/private/base/SkAssert.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkDrawLooper.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkMaskGamma.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/public.bzl
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/TLazyTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/codec/SkPngCodec.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkArenaAllocList.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkMipmap.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrResourceAllocator.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkDevice.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/sk_app/GraphiteMetalWindowContext.mm
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/SkRuntimeEffectTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/ops/AtlasRenderTask.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/TypefaceBench.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/ops/OpsTask.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/sksg/src/SkSGInvalidationController.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkCompressedDataUtils.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/effects/GrRRectEffect.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skparagraph/slides/ParagraphSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkVMBlitter.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/pdf/SkPDFTag.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/vk/GrVkUniformHandler.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/geom/BoundsManager.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/gl/GrGLProgramDataManager.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/dm/DMSrcSink.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/src/SkSVGPoly.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/shaders/SkBitmapProcShader.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/svg/include/SkSVGSVG.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/viewer/PathClipSlide.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkCanvasPriv.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkVMBlitter.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrDefaultGeoProcFactory.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/RasterPipelineCodeGeneratorTest.cpp
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkBlockAllocator.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skparagraph/src/ParagraphStyle.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skparagraph/src/ParagraphImpl.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrDynamicAtlas.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/SkBlockAllocatorTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkMaskBlurFilter.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrUniformDataManager.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skplaintexteditor/src/shape.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/DrawAtlas.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkXfermode.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/gm/asyncrescaleandread.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tools/gpu/TestContext.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrRecordingContext.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/glsl/GrGLSLVarying.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/text/gpu/SubRunAllocator.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/graphite/ShaderCodeDictionary.h
[rename] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/base/SkArenaAlloc.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/tessellate/StrokeTessellator.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkRecord.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/bench/CmapBench.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/MathTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBitmapProcState.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/GradientTest.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/modules/skottie/src/text/SkottieShaper.cpp
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkBlitter.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/utils/win/SkAutoCoInitialize.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/core/SkRasterClipStack.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/src/gpu/ganesh/GrMemoryPool.h
[modify] https://crrev.com/1b3aa8b6e1cc82991861082ab45a0b62aad56288/tests/PathOpsAngleTest.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #38
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/3eb13398100b409d62c0d5798786917b26f74df5
commit 3eb13398100b409d62c0d5798786917b26f74df5
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Jan 20 15:37:39 2023
[base] Make Bazel target and enforce IWYU
This creates the first "buffet" package, located in //src:base.
I plan to create all buffet packages in //src: and then use
aliases to make the public ones easily findable in //:
Having this be a target makes sure that none of the files in
base depend on things outside of base.
Enforcing IWYU took a bit of effort.
This adds a new macro for generating .h.cpp files from .h files
that only works if the file is defined in the same package
(folder) as the generating rule. I think this will eventually
replace the old rule.
I removed the files in the new base package from the generated
list of .h files because I saw conflicts as a result of the
current Bazel buffet defining SK_DEBUG as a define, whereas
the base package does not set any defines (the tentative plan
is to set those from files in base like SkAttributes.h). This
did catch at least two files (SkTFitsIn.h, SkSafeMath.h) which
was using SK_DEBUG without including the appropriate file.
I initially tried just generating .cpp files for all .h files,
but saw this tickle at least one IWYU bug (with templates?)
where IWYU wanted a header to include itself. Thus, we just
have a list of files to opt-in to header-generation and IWYU
enforcement.
See also: http://cl/503435314
Change-Id: I0a34633d469fcd84dcc6de428b708939cacbf1b0
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/632040
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/include/private/base/BUILD.bazel
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/src/base/BUILD.bazel
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/infra/bots/tasks.json
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/include/private/base/SkTFitsIn.h
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/include/config/BUILD.bazel
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/include/BUILD.bazel
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/bazel/generate_cpp_files_for_headers.bzl
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/bazel/macros.bzl
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/infra/bots/gen_tasks_logic/gen_tasks_logic.go
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/infra/bots/jobs.json
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/src/base/SkSafeMath.h
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/src/BUILD.bazel
https://skia.googlesource.com/skia/+/3eb13398100b409d62c0d5798786917b26f74df5
commit 3eb13398100b409d62c0d5798786917b26f74df5
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Jan 20 15:37:39 2023
[base] Make Bazel target and enforce IWYU
This creates the first "buffet" package, located in //src:base.
I plan to create all buffet packages in //src: and then use
aliases to make the public ones easily findable in //:
Having this be a target makes sure that none of the files in
base depend on things outside of base.
Enforcing IWYU took a bit of effort.
This adds a new macro for generating .h.cpp files from .h files
that only works if the file is defined in the same package
(folder) as the generating rule. I think this will eventually
replace the old rule.
I removed the files in the new base package from the generated
list of .h files because I saw conflicts as a result of the
current Bazel buffet defining SK_DEBUG as a define, whereas
the base package does not set any defines (the tentative plan
is to set those from files in base like SkAttributes.h). This
did catch at least two files (SkTFitsIn.h, SkSafeMath.h) which
was using SK_DEBUG without including the appropriate file.
I initially tried just generating .cpp files for all .h files,
but saw this tickle at least one IWYU bug (with templates?)
where IWYU wanted a header to include itself. Thus, we just
have a list of files to opt-in to header-generation and IWYU
enforcement.
See also: http://cl/503435314
Change-Id: I0a34633d469fcd84dcc6de428b708939cacbf1b0
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/632040
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/include/private/base/BUILD.bazel
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/src/base/BUILD.bazel
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/infra/bots/tasks.json
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/include/private/base/SkTFitsIn.h
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/include/config/BUILD.bazel
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/include/BUILD.bazel
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/bazel/generate_cpp_files_for_headers.bzl
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/bazel/macros.bzl
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/infra/bots/gen_tasks_logic/gen_tasks_logic.go
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/infra/bots/jobs.json
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/src/base/SkSafeMath.h
[modify] https://crrev.com/3eb13398100b409d62c0d5798786917b26f74df5/src/BUILD.bazel
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #39
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/67be14faaa640eb3be1f83328c4be07f1038328e
commit 67be14faaa640eb3be1f83328c4be07f1038328e
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Jan 20 20:14:25 2023
Add tests for SkDCubic::chopAt
The plan is to pull this out of PathOps into base so as to break
the dependency between SkPath and Pathops.
Change-Id: Ib750a334309762620551ebfec0675994bb6fa6fc
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/632517
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
[add] https://crrev.com/67be14faaa640eb3be1f83328c4be07f1038328e/tests/CubicChopTest.cpp
[modify] https://crrev.com/67be14faaa640eb3be1f83328c4be07f1038328e/gn/tests.gni
[modify] https://crrev.com/67be14faaa640eb3be1f83328c4be07f1038328e/tests/BUILD.bazel
https://skia.googlesource.com/skia/+/67be14faaa640eb3be1f83328c4be07f1038328e
commit 67be14faaa640eb3be1f83328c4be07f1038328e
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Jan 20 20:14:25 2023
Add tests for SkDCubic::chopAt
The plan is to pull this out of PathOps into base so as to break
the dependency between SkPath and Pathops.
Change-Id: Ib750a334309762620551ebfec0675994bb6fa6fc
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/632517
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
[add] https://crrev.com/67be14faaa640eb3be1f83328c4be07f1038328e/tests/CubicChopTest.cpp
[modify] https://crrev.com/67be14faaa640eb3be1f83328c4be07f1038328e/gn/tests.gni
[modify] https://crrev.com/67be14faaa640eb3be1f83328c4be07f1038328e/tests/BUILD.bazel
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #40
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/94f969c5592acab7f8fd513e9a8403ce6fc4408d
commit 94f969c5592acab7f8fd513e9a8403ce6fc4408d
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Jan 20 21:02:59 2023
Extract the double-precision cubic and quad solving code to base.
Based on https://github.com/google/skia/blob/787feb9bce958b384ed5ac3540f66ccee995799f/src/pathops/SkPathOpsCubic.cpp#L379
The unit tests have been updated to test both the existing
and new implementation. A follow-up CL will have Pathops use
this new code.
Change-Id: I9a134fef9e3e28aff64922a1507f4ffa2a27bb2a
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/631996
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/94f969c5592acab7f8fd513e9a8403ce6fc4408d/gn/core.gni
[add] https://crrev.com/94f969c5592acab7f8fd513e9a8403ce6fc4408d/src/base/SkCubics.cpp
[modify] https://crrev.com/94f969c5592acab7f8fd513e9a8403ce6fc4408d/tests/CubicRootsTest.cpp
[modify] https://crrev.com/94f969c5592acab7f8fd513e9a8403ce6fc4408d/tests/QuadRootsTest.cpp
[modify] https://crrev.com/94f969c5592acab7f8fd513e9a8403ce6fc4408d/src/base/BUILD.bazel
[add] https://crrev.com/94f969c5592acab7f8fd513e9a8403ce6fc4408d/src/base/SkQuads.h
[add] https://crrev.com/94f969c5592acab7f8fd513e9a8403ce6fc4408d/src/base/SkQuads.cpp
[modify] https://crrev.com/94f969c5592acab7f8fd513e9a8403ce6fc4408d/public.bzl
[add] https://crrev.com/94f969c5592acab7f8fd513e9a8403ce6fc4408d/src/base/SkCubics.h
https://skia.googlesource.com/skia/+/94f969c5592acab7f8fd513e9a8403ce6fc4408d
commit 94f969c5592acab7f8fd513e9a8403ce6fc4408d
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Jan 20 21:02:59 2023
Extract the double-precision cubic and quad solving code to base.
Based on https://github.com/google/skia/blob/787feb9bce958b384ed5ac3540f66ccee995799f/src/pathops/SkPathOpsCubic.cpp#L379
The unit tests have been updated to test both the existing
and new implementation. A follow-up CL will have Pathops use
this new code.
Change-Id: I9a134fef9e3e28aff64922a1507f4ffa2a27bb2a
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/631996
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/94f969c5592acab7f8fd513e9a8403ce6fc4408d/gn/core.gni
[add] https://crrev.com/94f969c5592acab7f8fd513e9a8403ce6fc4408d/src/base/SkCubics.cpp
[modify] https://crrev.com/94f969c5592acab7f8fd513e9a8403ce6fc4408d/tests/CubicRootsTest.cpp
[modify] https://crrev.com/94f969c5592acab7f8fd513e9a8403ce6fc4408d/tests/QuadRootsTest.cpp
[modify] https://crrev.com/94f969c5592acab7f8fd513e9a8403ce6fc4408d/src/base/BUILD.bazel
[add] https://crrev.com/94f969c5592acab7f8fd513e9a8403ce6fc4408d/src/base/SkQuads.h
[add] https://crrev.com/94f969c5592acab7f8fd513e9a8403ce6fc4408d/src/base/SkQuads.cpp
[modify] https://crrev.com/94f969c5592acab7f8fd513e9a8403ce6fc4408d/public.bzl
[add] https://crrev.com/94f969c5592acab7f8fd513e9a8403ce6fc4408d/src/base/SkCubics.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #41
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/91a14b75ee56bdba22d97d8573e7878ce17bfa8c
commit 91a14b75ee56bdba22d97d8573e7878ce17bfa8c
Author: Florin Malita <fmalita@chromium.org>
Date: Fri Jan 20 22:33:43 2023
Manual revert "[base] Make Bazel target and enforce IWYU"
This reverts commit 3eb13398100b409d62c0d5798786917b26f74df5.
Reason for revert: breaking g3 rolls
https://critique.corp.google.com/cl/503461112/analysis
Original change's description:
https://skia.googlesource.com/skia/+/91a14b75ee56bdba22d97d8573e7878ce17bfa8c
commit 91a14b75ee56bdba22d97d8573e7878ce17bfa8c
Author: Florin Malita <fmalita@chromium.org>
Date: Fri Jan 20 22:33:43 2023
Manual revert "[base] Make Bazel target and enforce IWYU"
This reverts commit 3eb13398100b409d62c0d5798786917b26f74df5.
Reason for revert: breaking g3 rolls
https://critique.corp.google.com/cl/503461112/analysis
Original change's description:
Bug: skia:13983
TBR=kjlubick@google.com
Change-Id: I8d1049da97388f536eea88c6ea43407267899d0b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/631414
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Auto-Submit: Florin Malita <fmalita@chromium.org>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Nolan Scobie <nscobie@google.com>
[modify] https://crrev.com/91a14b75ee56bdba22d97d8573e7878ce17bfa8c/include/private/base/BUILD.bazel
[modify] https://crrev.com/91a14b75ee56bdba22d97d8573e7878ce17bfa8c/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/91a14b75ee56bdba22d97d8573e7878ce17bfa8c/src/base/BUILD.bazel
[modify] https://crrev.com/91a14b75ee56bdba22d97d8573e7878ce17bfa8c/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/91a14b75ee56bdba22d97d8573e7878ce17bfa8c/infra/bots/tasks.json
[modify] https://crrev.com/91a14b75ee56bdba22d97d8573e7878ce17bfa8c/include/private/base/SkTFitsIn.h
[modify] https://crrev.com/91a14b75ee56bdba22d97d8573e7878ce17bfa8c/include/config/BUILD.bazel
[modify] https://crrev.com/91a14b75ee56bdba22d97d8573e7878ce17bfa8c/include/BUILD.bazel
[modify] https://crrev.com/91a14b75ee56bdba22d97d8573e7878ce17bfa8c/bazel/generate_cpp_files_for_headers.bzl
[modify] https://crrev.com/91a14b75ee56bdba22d97d8573e7878ce17bfa8c/bazel/macros.bzl
[modify] https://crrev.com/91a14b75ee56bdba22d97d8573e7878ce17bfa8c/infra/bots/gen_tasks_logic/gen_tasks_logic.go
[modify] https://crrev.com/91a14b75ee56bdba22d97d8573e7878ce17bfa8c/infra/bots/jobs.json
[modify] https://crrev.com/91a14b75ee56bdba22d97d8573e7878ce17bfa8c/src/base/SkSafeMath.h
[modify] https://crrev.com/91a14b75ee56bdba22d97d8573e7878ce17bfa8c/src/BUILD.bazel
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #42
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/b08a5b73a023371b65057f95fa2441f18c80d103
commit b08a5b73a023371b65057f95fa2441f18c80d103
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Jan 23 13:15:20 2023
Reland "[base] Make Bazel target and enforce IWYU"
This reverts commit 91a14b75ee56bdba22d97d8573e7878ce17bfa8c.
This creates the first "buffet" package, located in //src:base.
I plan to create all buffet packages in //src: and then use
aliases to make the public ones easily findable in //:
Having this be a target makes sure that none of the files in
base depend on things outside of base.
Enforcing IWYU took a bit of effort.
This adds a new macro for generating .h.cpp files from .h files
that only works if the file is defined in the same package
(folder) as the generating rule. I think this will eventually
replace the old rule.
I removed the files in the new base package from the generated
list of .h files because I saw conflicts as a result of the
current Bazel buffet defining SK_DEBUG as a define, whereas
the base package does not set any defines (the tentative plan
is to set those from files in base like SkAttributes.h). This
did catch at least two files (SkTFitsIn.h, SkSafeMath.h) which
was using SK_DEBUG without including the appropriate file.
I initially tried just generating .cpp files for all .h files,
but saw this tickle at least one IWYU bug (with templates?)
where IWYU wanted a header to include itself. Thus, we just
have a list of files to opt-in to header-generation and IWYU
enforcement.
See also:
- http://cl/503435314
- http://cl/503953788
Change-Id: Id1dafcfef632866b16db29acd7a6bc070d25d9f3
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/632578
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/include/private/base/BUILD.bazel
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/src/base/BUILD.bazel
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/infra/bots/tasks.json
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/include/private/base/SkTFitsIn.h
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/include/config/BUILD.bazel
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/include/BUILD.bazel
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/bazel/generate_cpp_files_for_headers.bzl
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/bazel/macros.bzl
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/src/base/SkSafeMath.h
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/infra/bots/jobs.json
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/infra/bots/gen_tasks_logic/gen_tasks_logic.go
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/src/BUILD.bazel
https://skia.googlesource.com/skia/+/b08a5b73a023371b65057f95fa2441f18c80d103
commit b08a5b73a023371b65057f95fa2441f18c80d103
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Jan 23 13:15:20 2023
Reland "[base] Make Bazel target and enforce IWYU"
This reverts commit 91a14b75ee56bdba22d97d8573e7878ce17bfa8c.
This creates the first "buffet" package, located in //src:base.
I plan to create all buffet packages in //src: and then use
aliases to make the public ones easily findable in //:
Having this be a target makes sure that none of the files in
base depend on things outside of base.
Enforcing IWYU took a bit of effort.
This adds a new macro for generating .h.cpp files from .h files
that only works if the file is defined in the same package
(folder) as the generating rule. I think this will eventually
replace the old rule.
I removed the files in the new base package from the generated
list of .h files because I saw conflicts as a result of the
current Bazel buffet defining SK_DEBUG as a define, whereas
the base package does not set any defines (the tentative plan
is to set those from files in base like SkAttributes.h). This
did catch at least two files (SkTFitsIn.h, SkSafeMath.h) which
was using SK_DEBUG without including the appropriate file.
I initially tried just generating .cpp files for all .h files,
but saw this tickle at least one IWYU bug (with templates?)
where IWYU wanted a header to include itself. Thus, we just
have a list of files to opt-in to header-generation and IWYU
enforcement.
See also:
- http://cl/503435314
- http://cl/503953788
Change-Id: Id1dafcfef632866b16db29acd7a6bc070d25d9f3
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/632578
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/include/private/base/BUILD.bazel
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/src/base/BUILD.bazel
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/infra/bots/tasks.json
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/include/private/base/SkTFitsIn.h
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/include/config/BUILD.bazel
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/include/BUILD.bazel
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/bazel/generate_cpp_files_for_headers.bzl
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/bazel/macros.bzl
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/src/base/SkSafeMath.h
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/infra/bots/jobs.json
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/infra/bots/gen_tasks_logic/gen_tasks_logic.go
[modify] https://crrev.com/b08a5b73a023371b65057f95fa2441f18c80d103/src/BUILD.bazel
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #43
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/876b045881a6b53d0db19ed812abd8814d7c359c
commit 876b045881a6b53d0db19ed812abd8814d7c359c
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 24 16:04:37 2023
[base] Add extra tests for cubic and quadratic root solving
This originally started as an attempt to unify the PathOps
and base root-finding algorithms [1], however that was abandoned
due to precision-sensitive code in PathOps.
While doing that, I found some cases that caused asserts because
sk_doubles_nearly_equal_ulps was used with two very small numbers
(which it Units of Least Precision are not the accurate choice
to differentiate). This inspired me to add a few more tests and
a simple fuzzer for the new code.
I initially tried to make the fuzzer verify the roots were correct,
however due to floating point imprecisions, this was an infeasible
game of whack-a-float. At least we can assert we do only return
finite numbers, the roots are unique, and for the case of the
ValidT roots, only roots in the range [0, 1].
CubicMapTest doesn't need the PathOps version of the root solver,
so I changed it to use the base version.
Change-Id: Ic5a190fe16a54046319da4946a95b5e4c1df6ba6
Bug: skia:13983, skia:14063
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/633476
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
[add] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/fuzz/oss_fuzz/FuzzCubicQuadRoots.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/src/base/SkCubics.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/tests/QuadRootsTest.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/tests/BUILD.bazel
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/src/pathops/SkPathOpsQuad.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/src/pathops/SkPathOpsCubic.cpp
[add] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/fuzz/FuzzCubicQuadRoots.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/tests/CubicRootsTest.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/BUILD.gn
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/src/base/SkQuads.h
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/fuzz/FuzzMain.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/src/base/SkQuads.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/src/base/SkCubics.h
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/tests/CubicMapTest.cpp
https://skia.googlesource.com/skia/+/876b045881a6b53d0db19ed812abd8814d7c359c
commit 876b045881a6b53d0db19ed812abd8814d7c359c
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jan 24 16:04:37 2023
[base] Add extra tests for cubic and quadratic root solving
This originally started as an attempt to unify the PathOps
and base root-finding algorithms [1], however that was abandoned
due to precision-sensitive code in PathOps.
While doing that, I found some cases that caused asserts because
sk_doubles_nearly_equal_ulps was used with two very small numbers
(which it Units of Least Precision are not the accurate choice
to differentiate). This inspired me to add a few more tests and
a simple fuzzer for the new code.
I initially tried to make the fuzzer verify the roots were correct,
however due to floating point imprecisions, this was an infeasible
game of whack-a-float. At least we can assert we do only return
finite numbers, the roots are unique, and for the case of the
ValidT roots, only roots in the range [0, 1].
CubicMapTest doesn't need the PathOps version of the root solver,
so I changed it to use the base version.
Change-Id: Ic5a190fe16a54046319da4946a95b5e4c1df6ba6
Bug: skia:13983, skia:14063
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/633476
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
[add] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/fuzz/oss_fuzz/FuzzCubicQuadRoots.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/src/base/SkCubics.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/tests/QuadRootsTest.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/tests/BUILD.bazel
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/src/pathops/SkPathOpsQuad.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/src/pathops/SkPathOpsCubic.cpp
[add] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/fuzz/FuzzCubicQuadRoots.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/tests/CubicRootsTest.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/BUILD.gn
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/src/base/SkQuads.h
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/fuzz/FuzzMain.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/src/base/SkQuads.cpp
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/src/base/SkCubics.h
[modify] https://crrev.com/876b045881a6b53d0db19ed812abd8814d7c359c/tests/CubicMapTest.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #44
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/668d32d23387111e495bb6975cbeeda27aa9df57
commit 668d32d23387111e495bb6975cbeeda27aa9df57
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 25 16:47:20 2023
[skia] Remove reference to empty SkUtilsArm.cpp file
The file is empty: https://github.com/google/skia/blob/876b045881a6b53d0db19ed812abd8814d7c359c/src/core/SkUtilsArm.cpp
Bug: skia:13983
Change-Id: I6424cacdc9de7c8b73417a9e9290fc4fd1baf602
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4194696
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Quick-Run: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1096815}
[modify] https://crrev.com/668d32d23387111e495bb6975cbeeda27aa9df57/skia/BUILD.gn
https://chromium.googlesource.com/chromium/src/+/668d32d23387111e495bb6975cbeeda27aa9df57
commit 668d32d23387111e495bb6975cbeeda27aa9df57
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 25 16:47:20 2023
[skia] Remove reference to empty SkUtilsArm.cpp file
The file is empty: https://github.com/google/skia/blob/876b045881a6b53d0db19ed812abd8814d7c359c/src/core/SkUtilsArm.cpp
Bug: skia:13983
Change-Id: I6424cacdc9de7c8b73417a9e9290fc4fd1baf602
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4194696
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Quick-Run: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1096815}
[modify] https://crrev.com/668d32d23387111e495bb6975cbeeda27aa9df57/skia/BUILD.gn
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #45
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/ed37743405279205cf68817e359a77d51902d8b6
commit ed37743405279205cf68817e359a77d51902d8b6
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 25 18:34:36 2023
[base] Move several more files from src/core into base.
Files moved:
- SkBuffer.h
- SkTBlockList.h
- SkTDPQueue.h
- SkTInternalLList.h
- SkTSearch.h
- SkTSort.h
- SkUtils.h
- SkZip.h
Client change:
- http://ag/21090138
Suggested review order:
- src/base/BUILD.bazel
- src/core/BUILD.bazel
- Files listed above (note some IWYU changes)
- gn/*.gni (these are generated from the BUILD.bazel files)
- BUILD.gn
- public.bzl
- Everything else, mostly done with find and replace and
cleaned up with the rewrite_includes.py script.
Change-Id: I2ea8146ca956daf1081693bdac3644022f888a40
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/633976
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkTInternalLList.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkRRect.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkFont.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkPictureRecord.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/MeshTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/gn/sksl.gni
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/BUILD.bazel
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/opts/SkChecksum_opts.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/pathops/SkOpEdgeBuilder.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/ports/SkFontConfigInterface_direct.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/GrRenderTask.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/gl/GrGLExtensions.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/codec/SkIcoCodec.cpp
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkUtils.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tools/ToolUtils.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkScan_AAAPath.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/GrResourceCache.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkICC.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkPixmap.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/pdf/SkPDFUtils.h
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkTSearch.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/vk/GrVkResourceProvider.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tools/fonts/TestTypeface.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/PathOpsTestCommon.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkRegion_path.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tools/flags/CommandLineFlags.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkString.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/pathops/SkOpAngle.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/SkGlyphBufferTest.cpp
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkUtils.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkGraphics.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/SkStrikeTest.cpp
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkZip.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/GrRenderTaskClusterTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkDescriptor.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/TDPQueueTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/gm/drawglyphs.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/graphite/ResourceCache.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tools/viewer/MixerSlide.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/GrDrawingManager.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/GrResourceCache.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/text/gpu/TextBlob.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/ops/SmallPathAtlasMgr.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/sfnt/SkOTTable_name.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/utils/SkPolyUtils.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/LListTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/StreamTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkLRUCache.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/GrGpu.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkRasterPipelineBlitter.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/pathops/SkPathOpsWinding.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/RandomTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/xps/SkXPSDevice.cpp
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkTSort.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/modules/skshaper/tests/ShaperTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/lazy/SkDiscardableMemoryPool.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/SkRasterPipelineTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/tessellate/Tessellation.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/GrRenderTaskCluster.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/geometry/GrPathUtils.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/text/GlyphRun.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/PathOpsAngleIdeas.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/public.bzl
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/vk/VulkanExtensions.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/gn/core.gni
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkDraw.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/text/GlyphRun.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/pathops/SkPathOpsTSect.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/sksl/codegen/SkSLRasterPipelineBuilder.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkPtrRecorder.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tools/viewer/AudioSlide.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkDevice.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/shaders/SkColorShader.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tools/viewer/Viewer.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/bench/GlyphQuadFillBench.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/opts/SkRasterPipeline_opts.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/bench/TypefaceBench.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkDraw_text.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkImageFilterCache.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/pdf/SkPDFMetadata.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/IncrTopoSortTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/GrThreadSafeCache.h
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkTDPQueue.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkRegion.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/gl/GrGLCaps.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/pathops/SkPathOpsCommon.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkPath_serial.cpp
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkBuffer.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/modules/svg/src/SkSVGDOM.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/pathops/SkPathWriter.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/utils/win/SkWGL_win.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/TypefaceMacTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/ports/SkFontMgr_android_parser.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkRuntimeEffect.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/BUILD.gn
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/GrDataUtils.cpp
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkBuffer.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/ports/SkFontMgr_android.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tools/fonts/TestSVGTypeface.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/ports/SkFontHost_FreeType.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkGlyphBuffer.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/AtlasTypes.h
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkTSearch.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/modules/skshaper/src/SkShaper_harfbuzz.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/BUILD.bazel
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/UtilsTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tools/skdiff/skdiff_main.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkContourMeasure.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/pathops/SkPathOpsCubic.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkScan_Path.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/modules/skottie/src/layers/TextLayer.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/GrGlyphVectorTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/bench/SortBench.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/SortTest.cpp
https://skia.googlesource.com/skia/+/ed37743405279205cf68817e359a77d51902d8b6
commit ed37743405279205cf68817e359a77d51902d8b6
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 25 18:34:36 2023
[base] Move several more files from src/core into base.
Files moved:
- SkBuffer.h
- SkTBlockList.h
- SkTDPQueue.h
- SkTInternalLList.h
- SkTSearch.h
- SkTSort.h
- SkUtils.h
- SkZip.h
Client change:
- http://ag/21090138
Suggested review order:
- src/base/BUILD.bazel
- src/core/BUILD.bazel
- Files listed above (note some IWYU changes)
- gn/*.gni (these are generated from the BUILD.bazel files)
- BUILD.gn
- public.bzl
- Everything else, mostly done with find and replace and
cleaned up with the rewrite_includes.py script.
Change-Id: I2ea8146ca956daf1081693bdac3644022f888a40
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/633976
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkTInternalLList.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkRRect.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkFont.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkPictureRecord.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/MeshTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/gn/sksl.gni
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/BUILD.bazel
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/opts/SkChecksum_opts.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/pathops/SkOpEdgeBuilder.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/ports/SkFontConfigInterface_direct.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/GrRenderTask.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/gl/GrGLExtensions.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/codec/SkIcoCodec.cpp
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkUtils.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tools/ToolUtils.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkScan_AAAPath.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/GrResourceCache.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkICC.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkPixmap.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/pdf/SkPDFUtils.h
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkTSearch.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/vk/GrVkResourceProvider.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tools/fonts/TestTypeface.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/PathOpsTestCommon.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkRegion_path.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tools/flags/CommandLineFlags.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkString.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/pathops/SkOpAngle.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/SkGlyphBufferTest.cpp
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkUtils.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkGraphics.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/SkStrikeTest.cpp
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkZip.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/GrRenderTaskClusterTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkDescriptor.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/TDPQueueTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/gm/drawglyphs.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/graphite/ResourceCache.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tools/viewer/MixerSlide.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/GrDrawingManager.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/GrResourceCache.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/text/gpu/TextBlob.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/ops/SmallPathAtlasMgr.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/sfnt/SkOTTable_name.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/utils/SkPolyUtils.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/LListTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/StreamTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkLRUCache.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/GrGpu.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkRasterPipelineBlitter.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/pathops/SkPathOpsWinding.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/RandomTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/xps/SkXPSDevice.cpp
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkTSort.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/modules/skshaper/tests/ShaperTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/lazy/SkDiscardableMemoryPool.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/SkRasterPipelineTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/tessellate/Tessellation.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/GrRenderTaskCluster.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/geometry/GrPathUtils.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/text/GlyphRun.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/PathOpsAngleIdeas.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/public.bzl
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/vk/VulkanExtensions.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/gn/core.gni
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkDraw.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/text/GlyphRun.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/pathops/SkPathOpsTSect.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/sksl/codegen/SkSLRasterPipelineBuilder.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkPtrRecorder.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tools/viewer/AudioSlide.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkDevice.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/shaders/SkColorShader.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tools/viewer/Viewer.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/bench/GlyphQuadFillBench.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/opts/SkRasterPipeline_opts.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/bench/TypefaceBench.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkDraw_text.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkImageFilterCache.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/pdf/SkPDFMetadata.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/IncrTopoSortTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/GrThreadSafeCache.h
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkTDPQueue.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkRegion.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/gl/GrGLCaps.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/pathops/SkPathOpsCommon.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkPath_serial.cpp
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkBuffer.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/modules/svg/src/SkSVGDOM.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/pathops/SkPathWriter.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/utils/win/SkWGL_win.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/TypefaceMacTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/ports/SkFontMgr_android_parser.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkRuntimeEffect.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/BUILD.gn
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/ganesh/GrDataUtils.cpp
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkBuffer.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/ports/SkFontMgr_android.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tools/fonts/TestSVGTypeface.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/ports/SkFontHost_FreeType.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkGlyphBuffer.h
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/gpu/AtlasTypes.h
[rename] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/SkTSearch.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/modules/skshaper/src/SkShaper_harfbuzz.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/base/BUILD.bazel
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/UtilsTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tools/skdiff/skdiff_main.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkContourMeasure.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/pathops/SkPathOpsCubic.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/src/core/SkScan_Path.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/modules/skottie/src/layers/TextLayer.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/GrGlyphVectorTest.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/bench/SortBench.cpp
[modify] https://crrev.com/ed37743405279205cf68817e359a77d51902d8b6/tests/SortTest.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #46
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d
commit 3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Jan 30 19:28:12 2023
Replace Pathops in Geometry::ChopMonoCubic implementation
This uses code in base instead, breaking the connection between
SkPath and Pathops.
This extracts one more function into SkBezierCurves.h, one
that converts between the control points and the polynomial.
It also adds a test comparing that functionality to the
Pathops one. We might be able to, in a follow-up CL, replace
SkDCubic::Coefficients with SkBezierCubic::ConvertToPolynomial.
Change-Id: I65e2b692c63a8c647ac48552008424ef1ea5d737
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/633458
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d/tests/CubicChopTest.cpp
[modify] https://crrev.com/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d/src/pathops/SkPathOpsCubic.cpp
[modify] https://crrev.com/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d/src/base/SkBezierCurves.cpp
[modify] https://crrev.com/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d/src/base/SkBezierCurves.h
[modify] https://crrev.com/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d/BUILD.gn
[modify] https://crrev.com/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d/src/core/SkGeometry.cpp
https://skia.googlesource.com/skia/+/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d
commit 3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Jan 30 19:28:12 2023
Replace Pathops in Geometry::ChopMonoCubic implementation
This uses code in base instead, breaking the connection between
SkPath and Pathops.
This extracts one more function into SkBezierCurves.h, one
that converts between the control points and the polynomial.
It also adds a test comparing that functionality to the
Pathops one. We might be able to, in a follow-up CL, replace
SkDCubic::Coefficients with SkBezierCubic::ConvertToPolynomial.
Change-Id: I65e2b692c63a8c647ac48552008424ef1ea5d737
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/633458
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d/tests/CubicChopTest.cpp
[modify] https://crrev.com/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d/src/pathops/SkPathOpsCubic.cpp
[modify] https://crrev.com/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d/src/base/SkBezierCurves.cpp
[modify] https://crrev.com/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d/src/base/SkBezierCurves.h
[modify] https://crrev.com/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d/BUILD.gn
[modify] https://crrev.com/3c4cd77c5e5dbb61a6dccfa9e37c23f151bc0b8d/src/core/SkGeometry.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #47
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/9785b14a32810b732ebff95cf74e1b5429acfbfd
commit 9785b14a32810b732ebff95cf74e1b5429acfbfd
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 25 19:48:33 2023
[base] Add SkBezierCubic::subdivide
This extracts SkDCubic::chopAt [1] into base and tests to
make sure the two implementations are identical. This also
adds documentation.
It's not clear to me if the "t == 0.5" conditional in the
original is a "fast path" or something for float precision
or something else. In any case, there is no explanation and
no unit tests that fail, so maybe it's ok.
[1] https://github.com/google/skia/blob/8106368d1f70d24e612afe7f6de8b6e6d1c6dd27/src/pathops/SkPathOpsCubic.cpp#L110
Change-Id: Iaa71b42b0b0b78259254711b54e8188c68fee63f
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/632583
Reviewed-by: Tyler Denniston <tdenniston@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
[modify] https://crrev.com/9785b14a32810b732ebff95cf74e1b5429acfbfd/tests/CubicChopTest.cpp
[modify] https://crrev.com/9785b14a32810b732ebff95cf74e1b5429acfbfd/gn/core.gni
[add] https://crrev.com/9785b14a32810b732ebff95cf74e1b5429acfbfd/src/base/SkBezierCurves.cpp
[add] https://crrev.com/9785b14a32810b732ebff95cf74e1b5429acfbfd/src/base/SkBezierCurves.h
[modify] https://crrev.com/9785b14a32810b732ebff95cf74e1b5429acfbfd/src/base/BUILD.bazel
[modify] https://crrev.com/9785b14a32810b732ebff95cf74e1b5429acfbfd/public.bzl
https://skia.googlesource.com/skia/+/9785b14a32810b732ebff95cf74e1b5429acfbfd
commit 9785b14a32810b732ebff95cf74e1b5429acfbfd
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 25 19:48:33 2023
[base] Add SkBezierCubic::subdivide
This extracts SkDCubic::chopAt [1] into base and tests to
make sure the two implementations are identical. This also
adds documentation.
It's not clear to me if the "t == 0.5" conditional in the
original is a "fast path" or something for float precision
or something else. In any case, there is no explanation and
no unit tests that fail, so maybe it's ok.
[1] https://github.com/google/skia/blob/8106368d1f70d24e612afe7f6de8b6e6d1c6dd27/src/pathops/SkPathOpsCubic.cpp#L110
Change-Id: Iaa71b42b0b0b78259254711b54e8188c68fee63f
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/632583
Reviewed-by: Tyler Denniston <tdenniston@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
[modify] https://crrev.com/9785b14a32810b732ebff95cf74e1b5429acfbfd/tests/CubicChopTest.cpp
[modify] https://crrev.com/9785b14a32810b732ebff95cf74e1b5429acfbfd/gn/core.gni
[add] https://crrev.com/9785b14a32810b732ebff95cf74e1b5429acfbfd/src/base/SkBezierCurves.cpp
[add] https://crrev.com/9785b14a32810b732ebff95cf74e1b5429acfbfd/src/base/SkBezierCurves.h
[modify] https://crrev.com/9785b14a32810b732ebff95cf74e1b5429acfbfd/src/base/BUILD.bazel
[modify] https://crrev.com/9785b14a32810b732ebff95cf74e1b5429acfbfd/public.bzl
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #48
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e
commit 86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Feb 01 13:36:05 2023
[modules] Sketch out out bare-bones core and functional pathops target
This introduces several "buffet" modules, in that a client can
pick and choose what they want. For example, the
//experimental/bazel_test:skia_with_pathops target
can choose just the core Skia and pathops part to do what it
needs to, without needing any of the CPU backend or other
parts of Skia.
To make this work, I made a bunch of new file groups (or used
existing ones) and put them into new targets. Note that these
targets do not have any feature-based selects (although I expect
them to have platform-specific ones at some point).
I didn't want to deal with SkPaint.cpp yet (there's a lot
of extra dependencies it would need), so I broke the link
between SkMatrix and SkPaint. While I was cleaning up SkMatrix,
I moved the RSXForm stuff into its own file (since it's in
its own header).
While testing this on Mac, I had to update some things to
make linking binaries work correctly.
This also adds "SkDebug.h" to the list of files that IWYU
won't tell us to remove because the IWYU build of skia_public
always sets SK_DEBUG but the modules build has this set
by SkDebug.h. Then, IWYU decided many files (semi-correctly)
needed to include SkDebug.h instead of getting them from SkTypes.h.
I'm also not sure why, but just now clang decided the use
of a non-string literal in SkDebug_stdio.cpp was suspect.
Future work will continue to add things into core
(e.g. SkPaint and SkCanvas). base will probably see a few
more additions as well.
Change-Id: I5be52329cbaa16b6c8d31b665f3915931e79cd11
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/633981
Owners-Override: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/modules/skunicode/src/SkUnicode_icu.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkRRect.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/DrawBitmapRectTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/codec/SkRawCodec.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/BUILD.bazel
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/SurfaceTest.cpp
[add] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkRSXform.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkOpContour.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/EGLImageTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/ImageFilterCacheTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tools/debugger/DebugLayerManager.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsConicQuadIntersectionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkIntersections.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/CodecTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/ClipCubicTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/modules/skunicode/src/SkUnicode.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkMatrixUtils.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkPathOpsQuad.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/ImageTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/gpu/ganesh/GrCaps.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkString.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkDConicLineIntersection.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/GrThreadSafeCacheTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/RefCntTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/gpu/ganesh/GrSurfaceProxy.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/BUILD.bazel
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/gpu/ganesh/GrResourceProvider.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsLineIntersectionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/include/core/SkPath.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/CubicMapTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkGlyph.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkRect.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/OSPathTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsConicLineIntersectionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsCubicLineIntersectionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkAddIntersections.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkPathPriv.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/utils/SkPolyUtils.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkDCubicLineIntersection.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/include/core/SkRefCnt.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkPathOpsCubic.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/include/pathops/BUILD.bazel
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkPathOpsConic.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsCubicQuadIntersectionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkPathOpsWinding.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsExtendedTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/utils/SkJSON.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkPathOpsTSect.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PointTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsQuadIntersectionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/ClipperTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsCubicConicIntersectionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/SkVMTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkCanvas.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/sksl/SkSLCompiler.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkPathOpsDebug.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/toolchain/linux_trampolines/clang_trampoline_linux.sh
[add] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/experimental/bazel_test/pathop_main.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/FontMgrAndroidParserTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkGeometry.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/ports/SkDebug_stdio.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/CanvasStateTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsQuadReduceOrderTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/images/SkPngEncoder.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/RRectInPathTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsAngleIdeas.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsDebug.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/include/core/BUILD.bazel
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/experimental/bazel_test/BUILD.bazel
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/public.bzl
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PremulAlphaRoundTripTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/toolchain/download_mac_toolchain.bzl
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsOpTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/BazelTestRunner.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/gn/core.gni
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PDFPrimitivesTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkDraw.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/BUILD.bazel
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsLineParametetersTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/gpu/ganesh/GrMemoryPool.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkOpSegment.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/Skbug6653.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkEdgeBuilder.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/GeometryTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsQuadLineIntersectionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/FontHostTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/CodecPartialTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PDFDeflateWStreamTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/IncrTopoSortTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/RegionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkEdgeClipper.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkStream.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkOpCoincidence.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/FontMgrTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/utils/SkShaderUtils.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/BitmapTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsCubicLineIntersectionIdeas.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/FontNamesTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/gpu/ganesh/GrTextureProxy.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/MatrixTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/SkBlockAllocatorTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/include/private/SkPathRef.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/StrokerTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsCubicReduceOrderTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/SubsetPath.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/include/private/BUILD.bazel
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkOpSpan.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/ProgramsTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkMatrix.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/ports/BUILD.bazel
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkOpAngle.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tools/debugger/DrawCommand.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/utils/SkMultiPictureDocument.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/sksl/analysis/SkSLProgramUsage.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/MathTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/ProcessorTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsCubicIntersectionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkPathOpsCurve.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsAngleTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/gpu/ganesh/GrRenderTargetProxy.h
https://skia.googlesource.com/skia/+/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e
commit 86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Feb 01 13:36:05 2023
[modules] Sketch out out bare-bones core and functional pathops target
This introduces several "buffet" modules, in that a client can
pick and choose what they want. For example, the
//experimental/bazel_test:skia_with_pathops target
can choose just the core Skia and pathops part to do what it
needs to, without needing any of the CPU backend or other
parts of Skia.
To make this work, I made a bunch of new file groups (or used
existing ones) and put them into new targets. Note that these
targets do not have any feature-based selects (although I expect
them to have platform-specific ones at some point).
I didn't want to deal with SkPaint.cpp yet (there's a lot
of extra dependencies it would need), so I broke the link
between SkMatrix and SkPaint. While I was cleaning up SkMatrix,
I moved the RSXForm stuff into its own file (since it's in
its own header).
While testing this on Mac, I had to update some things to
make linking binaries work correctly.
This also adds "SkDebug.h" to the list of files that IWYU
won't tell us to remove because the IWYU build of skia_public
always sets SK_DEBUG but the modules build has this set
by SkDebug.h. Then, IWYU decided many files (semi-correctly)
needed to include SkDebug.h instead of getting them from SkTypes.h.
I'm also not sure why, but just now clang decided the use
of a non-string literal in SkDebug_stdio.cpp was suspect.
Future work will continue to add things into core
(e.g. SkPaint and SkCanvas). base will probably see a few
more additions as well.
Change-Id: I5be52329cbaa16b6c8d31b665f3915931e79cd11
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/633981
Owners-Override: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/modules/skunicode/src/SkUnicode_icu.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkRRect.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/DrawBitmapRectTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/codec/SkRawCodec.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/BUILD.bazel
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/SurfaceTest.cpp
[add] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkRSXform.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkOpContour.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/EGLImageTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/ImageFilterCacheTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tools/debugger/DebugLayerManager.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsConicQuadIntersectionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkIntersections.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/CodecTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/ClipCubicTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/modules/skunicode/src/SkUnicode.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkMatrixUtils.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkPathOpsQuad.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/ImageTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/gpu/ganesh/GrCaps.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkString.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkDConicLineIntersection.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/GrThreadSafeCacheTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/RefCntTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/gpu/ganesh/GrSurfaceProxy.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/BUILD.bazel
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/gpu/ganesh/GrResourceProvider.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsLineIntersectionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/include/core/SkPath.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/CubicMapTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkGlyph.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkRect.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/OSPathTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsConicLineIntersectionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsCubicLineIntersectionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkAddIntersections.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkPathPriv.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/utils/SkPolyUtils.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkDCubicLineIntersection.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/include/core/SkRefCnt.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkPathOpsCubic.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/include/pathops/BUILD.bazel
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkPathOpsConic.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsCubicQuadIntersectionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkPathOpsWinding.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsExtendedTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/utils/SkJSON.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkPathOpsTSect.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PointTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsQuadIntersectionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/ClipperTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsCubicConicIntersectionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/SkVMTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkCanvas.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/sksl/SkSLCompiler.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkPathOpsDebug.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/toolchain/linux_trampolines/clang_trampoline_linux.sh
[add] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/experimental/bazel_test/pathop_main.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/FontMgrAndroidParserTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkGeometry.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/ports/SkDebug_stdio.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/CanvasStateTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsQuadReduceOrderTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/images/SkPngEncoder.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/RRectInPathTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsAngleIdeas.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsDebug.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/include/core/BUILD.bazel
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/experimental/bazel_test/BUILD.bazel
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/public.bzl
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PremulAlphaRoundTripTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/toolchain/download_mac_toolchain.bzl
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsOpTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/BazelTestRunner.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/gn/core.gni
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PDFPrimitivesTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkDraw.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/BUILD.bazel
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsLineParametetersTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/gpu/ganesh/GrMemoryPool.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkOpSegment.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/Skbug6653.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkEdgeBuilder.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/GeometryTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsQuadLineIntersectionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/FontHostTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/CodecPartialTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PDFDeflateWStreamTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/IncrTopoSortTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/RegionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkEdgeClipper.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkStream.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkOpCoincidence.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/FontMgrTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/utils/SkShaderUtils.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/BitmapTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsCubicLineIntersectionIdeas.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/FontNamesTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/gpu/ganesh/GrTextureProxy.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/MatrixTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/SkBlockAllocatorTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/include/private/SkPathRef.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/StrokerTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsCubicReduceOrderTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/SubsetPath.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/include/private/BUILD.bazel
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkOpSpan.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/ProgramsTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/core/SkMatrix.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/ports/BUILD.bazel
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkOpAngle.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tools/debugger/DrawCommand.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/utils/SkMultiPictureDocument.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/sksl/analysis/SkSLProgramUsage.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/MathTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/ProcessorTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsCubicIntersectionTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/pathops/SkPathOpsCurve.h
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/tests/PathOpsAngleTest.cpp
[modify] https://crrev.com/86f7b2dd2b4f4e3b1443089bfd97cc712ea3fb0e/src/gpu/ganesh/GrRenderTargetProxy.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #49
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/27876ec0d69511d3dfd1c2a12873e55eacddc0fd
commit 27876ec0d69511d3dfd1c2a12873e55eacddc0fd
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Feb 01 14:53:26 2023
Move SkHalf and SkVx to src/base
There are no other uses in include/ and SkHalf feels like it
fits in base reasonably well.
This also breaks the link between SkColorData.h and SkVx.h which
is a large contributor (294 MB, 0.1%) to Chrome's build size
according to go/chrome-includes [1]. The skvx usage from
SkColorData.h was moved to SkSwizzlePriv.h (SkColorPriv having
been taken), which is in src and only used by .cpp files.
In breaking the link, it was discovered that KeyHelpers.h
used the skvx::float4 data type, but it seemed to only be a
convenient way to hold 4 floats before writing them to
the PipelineDataGatherer (and subsequently the UniformManager).
kjlubick@ thinks it is a bad idea to have SkVX be in headers
(as this was the cause of the large Chrome build), so the
type was changed to SkV4 and plumbed through.
[1] https://commondatastorage.googleapis.com/chromium-browser-clang/chrome_includes_2023-01-31_154801.html#view=edges&filter=&sort=asize&reverse=&includer=&included=third_party%2Fskia&limit=1000
Change-Id: I7813ed2dc2e51f8361890d968681734a1855b4ba
Bug: skia:13052, skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/635796
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/geometry/GrQuad.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/modules/skottie/src/animator/VectorKeyframeAnimator.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tests/FloatingPointTextureTest.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/gn/core.gni
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/graphite/UniformManager.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/opts/SkSwizzler_opts.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/effects/imagefilters/SkBlurImageFilter.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/BUILD.bazel
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/gn/sksl.gni
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkPath.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/opts/SkBlitRow_opts.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkMipmap.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/gradients/GrGradientBitmapCache.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkCubicMap.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkPathBuilder.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkBlitter_ARGB32.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/codec/SkSwizzler.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tools/viewer/PathTextSlide.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkScan_Hairline.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/opts/SkBitmapProcState_opts.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/geometry/GrQuadUtils.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/modules/skottie/src/effects/MotionBlurEffect.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/GrColor.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/bench/Sk4fBench.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkPixmap.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/graphite/KeyHelpers.h
[rename] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/base/SkVx.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/ops/FillRRectOp.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkConvertPixels.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/effects/GrSkSLFP.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/opts/SkVM_opts.h
[rename] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/base/SkHalf.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkBitmap.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkBlendMode.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/bench/VertexColorSpaceBench.cpp
[rename] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/base/SkHalf.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/dm/DM.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/graphite/UniformManager.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tests/CubicMapTest.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/modules/canvaskit/wasm_tools/SIMD/simd_int_capabilities.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tests/graphite/UniformManagerTest.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkGlyph.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/geometry/GrQuadUtils.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/BufferWriter.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/tessellate/Tessellation.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkRect.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/gm/wacky_yuv_formats.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/modules/skottie/src/effects/CCTonerEffect.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/include/private/SkColorData.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/modules/skottie/src/text/TextAnimator.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkMaskBlurFilter.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkPathRef.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkColor.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkDraw_vertices.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/ops/AtlasPathRenderer.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/utils/SkPolyUtils.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkVM.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkOpts.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/include/private/BUILD.bazel
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tests/WangsFormulaTest.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkGeometry.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/opts/SkBlitMask_opts.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/effects/imagefilters/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/effects/imagefilters/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkMatrix.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/Sk4px.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/utils/SkPatchUtils.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/ports/SkFontHost_FreeType_common.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkRasterPipeline.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/include/private/base/BUILD.bazel
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tests/SkRasterPipelineTest.cpp
[add] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkSwizzlePriv.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/sksl/ir/SkSLFunctionCall.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tests/MathTest.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkM44.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/shaders/gradients/SkGradientShaderBase.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/base/BUILD.bazel
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/ops/QuadPerEdgeAA.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/SurfaceDrawContext.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/tessellate/WangsFormula.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkGeometry.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/modules/canvaskit/wasm_tools/SIMD/simd_float_capabilities.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkMatrixPriv.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tests/SkVxTest.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/graphite/geom/Rect.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/opts/SkUtils_opts.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/GrUniformDataManager.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tests/Float16Test.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/gl/GrGLGpu.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/effects/GrMatrixConvolutionEffect.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/public.bzl
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/graphite/PipelineData.h
https://skia.googlesource.com/skia/+/27876ec0d69511d3dfd1c2a12873e55eacddc0fd
commit 27876ec0d69511d3dfd1c2a12873e55eacddc0fd
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Feb 01 14:53:26 2023
Move SkHalf and SkVx to src/base
There are no other uses in include/ and SkHalf feels like it
fits in base reasonably well.
This also breaks the link between SkColorData.h and SkVx.h which
is a large contributor (294 MB, 0.1%) to Chrome's build size
according to go/chrome-includes [1]. The skvx usage from
SkColorData.h was moved to SkSwizzlePriv.h (SkColorPriv having
been taken), which is in src and only used by .cpp files.
In breaking the link, it was discovered that KeyHelpers.h
used the skvx::float4 data type, but it seemed to only be a
convenient way to hold 4 floats before writing them to
the PipelineDataGatherer (and subsequently the UniformManager).
kjlubick@ thinks it is a bad idea to have SkVX be in headers
(as this was the cause of the large Chrome build), so the
type was changed to SkV4 and plumbed through.
[1] https://commondatastorage.googleapis.com/chromium-browser-clang/chrome_includes_2023-01-31_154801.html#view=edges&filter=&sort=asize&reverse=&includer=&included=third_party%2Fskia&limit=1000
Change-Id: I7813ed2dc2e51f8361890d968681734a1855b4ba
Bug: skia:13052, skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/635796
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/geometry/GrQuad.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/modules/skottie/src/animator/VectorKeyframeAnimator.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tests/FloatingPointTextureTest.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/gn/core.gni
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/graphite/UniformManager.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/opts/SkSwizzler_opts.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/effects/imagefilters/SkBlurImageFilter.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/BUILD.bazel
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/gn/sksl.gni
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkPath.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/opts/SkBlitRow_opts.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkMipmap.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/gradients/GrGradientBitmapCache.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkCubicMap.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkPathBuilder.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkBlitter_ARGB32.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/codec/SkSwizzler.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tools/viewer/PathTextSlide.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkScan_Hairline.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/opts/SkBitmapProcState_opts.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/geometry/GrQuadUtils.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/modules/skottie/src/effects/MotionBlurEffect.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/GrColor.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/bench/Sk4fBench.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkPixmap.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/graphite/KeyHelpers.h
[rename] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/base/SkVx.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/ops/FillRRectOp.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkConvertPixels.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/effects/GrSkSLFP.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/opts/SkVM_opts.h
[rename] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/base/SkHalf.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkBitmap.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkBlendMode.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/bench/VertexColorSpaceBench.cpp
[rename] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/base/SkHalf.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/dm/DM.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/graphite/UniformManager.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tests/CubicMapTest.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/modules/canvaskit/wasm_tools/SIMD/simd_int_capabilities.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tests/graphite/UniformManagerTest.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkGlyph.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/geometry/GrQuadUtils.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/BufferWriter.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/tessellate/Tessellation.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkRect.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/gm/wacky_yuv_formats.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/modules/skottie/src/effects/CCTonerEffect.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/include/private/SkColorData.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/modules/skottie/src/text/TextAnimator.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkMaskBlurFilter.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkPathRef.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkColor.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkDraw_vertices.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/ops/AtlasPathRenderer.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/utils/SkPolyUtils.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkVM.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkOpts.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/include/private/BUILD.bazel
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tests/WangsFormulaTest.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkGeometry.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/opts/SkBlitMask_opts.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/effects/imagefilters/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/effects/imagefilters/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkMatrix.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/Sk4px.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/utils/SkPatchUtils.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/ports/SkFontHost_FreeType_common.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkRasterPipeline.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/include/private/base/BUILD.bazel
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tests/SkRasterPipelineTest.cpp
[add] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkSwizzlePriv.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/sksl/ir/SkSLFunctionCall.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tests/MathTest.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkM44.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/shaders/gradients/SkGradientShaderBase.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/base/BUILD.bazel
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/ops/QuadPerEdgeAA.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/SurfaceDrawContext.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/tessellate/WangsFormula.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkGeometry.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/modules/canvaskit/wasm_tools/SIMD/simd_float_capabilities.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/core/SkMatrixPriv.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tests/SkVxTest.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/graphite/geom/Rect.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/opts/SkUtils_opts.h
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/GrUniformDataManager.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/tests/Float16Test.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/gl/GrGLGpu.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/ganesh/effects/GrMatrixConvolutionEffect.cpp
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/public.bzl
[modify] https://crrev.com/27876ec0d69511d3dfd1c2a12873e55eacddc0fd/src/gpu/graphite/PipelineData.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #50
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/97fd0734cc5975df41c63a5155634dc7c7a4b6dc
commit 97fd0734cc5975df41c63a5155634dc7c7a4b6dc
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Feb 10 23:18:38 2023
Remove unused include of SkRandom.h
The Skia team intends to remove SkRandom.h from the public API.
This was the only known use of it in Chrome.
Change-Id: If16da227b45db34b43f70206da05b795700b63d7
Bug: skia:13983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4242158
Commit-Queue: Scott Violet <sky@chromium.org>
Quick-Run: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1104100}
[modify] https://crrev.com/97fd0734cc5975df41c63a5155634dc7c7a4b6dc/components/tab_groups/tab_group_color.cc
https://chromium.googlesource.com/chromium/src/+/97fd0734cc5975df41c63a5155634dc7c7a4b6dc
commit 97fd0734cc5975df41c63a5155634dc7c7a4b6dc
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Feb 10 23:18:38 2023
Remove unused include of SkRandom.h
The Skia team intends to remove SkRandom.h from the public API.
This was the only known use of it in Chrome.
Change-Id: If16da227b45db34b43f70206da05b795700b63d7
Bug: skia:13983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4242158
Commit-Queue: Scott Violet <sky@chromium.org>
Quick-Run: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1104100}
[modify] https://crrev.com/97fd0734cc5975df41c63a5155634dc7c7a4b6dc/components/tab_groups/tab_group_color.cc
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #51
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3
commit 0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Feb 13 14:13:10 2023
Move SkRandom and SkFixed into base
SkFixed requires a shim for Android [1].
Client CL:
- https://chromium-review.googlesource.com/c/chromium/src/+/4242158
SkFixed.h was moved to include/private/base because it is used
elsewhere in include/. SkRandom was not, so it is now in src/base.
See SkFixed.h, SkRandom.h, and the Bazel files for actual changes,
everything else was just find and replace.
The fiddles (docs/examples/*) were changed to use <random> because
we only want those to demonstrate Skia's public APIs.
The shim for SkTemplates.h no longer appears used.
[1] https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master/libs/hwui/SkiaInterpolator.cpp#20
Change-Id: Ie4fddd33ffb4141c1f0dc051712407d0da64aa4b
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/641776
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/fonts/TestTypeface.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/ChecksumBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/graphite/ResourceCache.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/CullTestTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/ports/SkFontConfigInterface_direct.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/ganesh/ops/DrawAtlasOp.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/TriangulatingPathRendererTests.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/OpChainTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/ToolUtils.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/ColorFilterTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/PathTextSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/ovals.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/CodecTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/ports/SkTypeface_mac_ct.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/SkPathRangeIterTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/RectanizerBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/widebuttcaps.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/addarc.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/effects/imagefilters/SkDisplacementMapImageFilter.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/runtimeintrinsics.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/arcto.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/docs/examples/sweep_gradient_talk_lots.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/PatchSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/3DSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/GrThreadSafeCacheTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/drawminibitmaprect.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/ganesh/ops/SmallPathShapeData.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/DDLTileHelper.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/utils/SkShadowUtils.cpp
[rename] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/base/SkRandom.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/Writer32Test.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PathOpsChalkboardTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/AAClipTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/ganesh/GrResourceCache.cpp
[delete] https://crrev.com/5ba61287b4e64ce7e0767fb0848a16431b31550b/include/private/SkTemplates.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/imageblur.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PathOpsTightBoundsTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/StreamTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/textblobmixedsizes.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PathOpsTigerTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/effects/imagefilters/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/RectBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/MorphologyBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/MatrixConvolutionBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/PathSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/ganesh/GrTestUtils.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/strokerects.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/degeneratesegments.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/GeometryBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/emptypath.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/HairlinePathBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PictureTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/PathEffectsSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/FontMgrAndroidParserTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/RegionContainBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PathBuilderTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/TypefaceTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/PathTextBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/InterpBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/rewrite_includes.py
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/quadpaths.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/runtimeimagefilter.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/ports/SkScalerContext_mac_ct.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/TopoSortTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/GrMemoryPoolBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/effects/SkTableMaskFilter.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/docs/examples/Bitmap_allocN32Pixels.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/shapes.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/TextBlobBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/imagemagnifier.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/effects/SkTableColorFilter.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/ganesh/ops/StrokeRectOp.cpp
[add] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/include/private/base/SkFixed.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/MegaStrokeSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/GeometryTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/SamplingTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/MathBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/LineBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/dstreadshuffle.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/GrQuadBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/nested.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PDFDeflateWStreamTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/RegionTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/include/core/SkColorSpace.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/effects/imagefilters/SkLightingImageFilter.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/BlurImageFilterBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/core/SkFontDescriptor.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/core/SkFDot6.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/effects/SkEmbossMask.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PathTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/mesh.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/imageblur2.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/modules/skottie/src/effects/FractalNoiseEffect.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/PDFBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PathOpsCubicLineIntersectionIdeas.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/ArcSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/ParticlesSlide.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/core/SkColorSpacePriv.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/StrokerTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gn/utils.gni
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/PathOpsBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/docs/examples/Octopus_Generator.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/WangsFormulaTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/beziereffects.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/ProgramsTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/simplerect.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/ports/SkFontMgr_android.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/manypaths.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/ports/SkFontMgr_mac_ct.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/include/private/base/BUILD.bazel
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/effects/SkDiscretePathEffect.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/BlendmodeBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/AtlasSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/ganesh/GrDirectContext.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/base/BUILD.bazel
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/QuickRejectBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/graphite/PaintParamsKeyTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/SkVxTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/mandoline.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/cubicpaths.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/ClipSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/MatrixProcsTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/ClockSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/pdf/SkPDFUtils.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/Float16Test.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/tallstretchedbitmaps.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/ganesh/gradients/GrGradientShader.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/ganesh/GrManagedResource.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/DrawBitmapRectTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/StrokeBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/strokes.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/TArrayTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/core/SkICC.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/SlidesSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/FSRectBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/M44Test.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PathOpsBuilderConicTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/ChartSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/utils/SkCustomTypeface.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/animatedimageblurs.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/CompositingImagesBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/points.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/persptext.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/TextBoxSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/trickycubicstrokes.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/SKPAnimationBench.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/graphite/IntersectionTreeBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/OverAlignedTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/core/SkScan.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/core/SkGlyph.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/AnimBlurSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/PicturePlaybackBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/TDPQueueTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/ColorPrivBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/sharedcorners.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/convexpaths.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/hittestpath.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/DashBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/docs/examples/drawarcs.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/BlurBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/RandomTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/RegionBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/savelayer.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/ganesh/GrDrawOpTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/imagealphathreshold.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/GameBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/linepaths.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/graphite/BoundsManagerBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/beziers.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/include/private/SkFixed.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/complexclip2.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/PathBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/RectanizerSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/ChartBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/vertices.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PathOpsAngleIdeas.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/graphite/IntersectionTreeTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/AnimatedTextSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/AAClipBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/public.bzl
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PDFPrimitivesTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gn/core.gni
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/Matrix44Bench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/BulkRectBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/ScalarBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/include/BUILD.bazel
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/MatrixBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/roundrects.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/RoundRectTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/blurcircles2.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/modules/canvaskit/particles_bindings.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/core/SkEdgeBuilder.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/MipMapTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/VertBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/GpuRectanizerTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/BlurRectBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/modules/skparagraph/slides/ParagraphSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/PathIterBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/XferSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/Point3Test.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/polygons.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/include/utils/BUILD.bazel
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/dm/DMSrcSink.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/getpostextpath.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/ManyRectsSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/FlutterAnimateSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/variedtext.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/BitmapTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/ChineseFlingSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/ColorTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/MatrixTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/yuv420_odd_dim.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/ImageCycleBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/fuzz/FuzzEncoders.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/docs/examples/Bitmap_installPixels_2.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/ports/SkFontMgr_android_parser.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/ChecksumTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/ShapesBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/modules/sksg/slides/SVGPongSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/CmapBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/MathTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/core/SkBitmapProcState.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/ports/SkFontMgr_fontconfig.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/runtimeshader.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/ProcessorTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/RTreeBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/UtilsTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/discard.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/docs/examples/Octopus_Generator_Animated.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/arcofzorro.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/TopoSortBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/GlyphTransformSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/WindowRectanglesTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/GrMemoryPoolTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/SortBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/SortTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/RELEASE_NOTES.txt
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/RTreeTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PathOpsAngleTest.cpp
https://skia.googlesource.com/skia/+/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3
commit 0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Feb 13 14:13:10 2023
Move SkRandom and SkFixed into base
SkFixed requires a shim for Android [1].
Client CL:
- https://chromium-review.googlesource.com/c/chromium/src/+/4242158
SkFixed.h was moved to include/private/base because it is used
elsewhere in include/. SkRandom was not, so it is now in src/base.
See SkFixed.h, SkRandom.h, and the Bazel files for actual changes,
everything else was just find and replace.
The fiddles (docs/examples/*) were changed to use <random> because
we only want those to demonstrate Skia's public APIs.
The shim for SkTemplates.h no longer appears used.
[1] https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master/libs/hwui/SkiaInterpolator.cpp#20
Change-Id: Ie4fddd33ffb4141c1f0dc051712407d0da64aa4b
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/641776
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/fonts/TestTypeface.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/ChecksumBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/graphite/ResourceCache.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/CullTestTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/ports/SkFontConfigInterface_direct.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/ganesh/ops/DrawAtlasOp.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/TriangulatingPathRendererTests.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/OpChainTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/ToolUtils.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/ColorFilterTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/PathTextSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/ovals.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/CodecTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/ports/SkTypeface_mac_ct.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/SkPathRangeIterTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/RectanizerBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/widebuttcaps.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/addarc.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/effects/imagefilters/SkDisplacementMapImageFilter.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/runtimeintrinsics.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/arcto.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/docs/examples/sweep_gradient_talk_lots.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/PatchSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/3DSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/GrThreadSafeCacheTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/drawminibitmaprect.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/ganesh/ops/SmallPathShapeData.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/DDLTileHelper.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/utils/SkShadowUtils.cpp
[rename] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/base/SkRandom.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/Writer32Test.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PathOpsChalkboardTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/AAClipTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/ganesh/GrResourceCache.cpp
[delete] https://crrev.com/5ba61287b4e64ce7e0767fb0848a16431b31550b/include/private/SkTemplates.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/imageblur.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PathOpsTightBoundsTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/StreamTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/textblobmixedsizes.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PathOpsTigerTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/effects/imagefilters/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/RectBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/MorphologyBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/MatrixConvolutionBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/PathSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/ganesh/GrTestUtils.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/strokerects.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/degeneratesegments.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/GeometryBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/emptypath.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/HairlinePathBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PictureTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/PathEffectsSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/FontMgrAndroidParserTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/RegionContainBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PathBuilderTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/TypefaceTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/PathTextBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/InterpBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/rewrite_includes.py
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/quadpaths.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/runtimeimagefilter.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/ports/SkScalerContext_mac_ct.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/TopoSortTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/GrMemoryPoolBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/effects/SkTableMaskFilter.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/docs/examples/Bitmap_allocN32Pixels.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/shapes.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/TextBlobBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/imagemagnifier.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/effects/SkTableColorFilter.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/ganesh/ops/StrokeRectOp.cpp
[add] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/include/private/base/SkFixed.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/MegaStrokeSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/GeometryTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/SamplingTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/MathBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/LineBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/dstreadshuffle.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/GrQuadBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/nested.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PDFDeflateWStreamTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/RegionTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/include/core/SkColorSpace.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/effects/imagefilters/SkLightingImageFilter.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/BlurImageFilterBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/core/SkFontDescriptor.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/core/SkFDot6.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/effects/SkEmbossMask.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PathTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/mesh.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/imageblur2.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/modules/skottie/src/effects/FractalNoiseEffect.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/PDFBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PathOpsCubicLineIntersectionIdeas.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/ArcSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/ParticlesSlide.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/core/SkColorSpacePriv.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/StrokerTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gn/utils.gni
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/PathOpsBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/docs/examples/Octopus_Generator.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/WangsFormulaTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/beziereffects.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/ProgramsTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/simplerect.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/ports/SkFontMgr_android.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/manypaths.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/ports/SkFontMgr_mac_ct.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/include/private/base/BUILD.bazel
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/effects/SkDiscretePathEffect.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/BlendmodeBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/AtlasSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/ganesh/GrDirectContext.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/base/BUILD.bazel
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/QuickRejectBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/graphite/PaintParamsKeyTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/SkVxTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/mandoline.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/cubicpaths.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/ClipSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/MatrixProcsTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/ClockSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/pdf/SkPDFUtils.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/Float16Test.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/tallstretchedbitmaps.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/ganesh/gradients/GrGradientShader.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/ganesh/GrManagedResource.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/DrawBitmapRectTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/StrokeBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/strokes.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/TArrayTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/core/SkICC.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/SlidesSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/FSRectBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/M44Test.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PathOpsBuilderConicTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/ChartSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/utils/SkCustomTypeface.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/animatedimageblurs.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/CompositingImagesBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/points.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/persptext.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/TextBoxSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/trickycubicstrokes.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/SKPAnimationBench.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/graphite/IntersectionTreeBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/OverAlignedTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/core/SkScan.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/core/SkGlyph.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/AnimBlurSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/PicturePlaybackBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/TDPQueueTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/ColorPrivBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/sharedcorners.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/convexpaths.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/hittestpath.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/DashBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/docs/examples/drawarcs.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/BlurBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/RandomTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/RegionBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/savelayer.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/gpu/ganesh/GrDrawOpTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/imagealphathreshold.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/GameBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/linepaths.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/graphite/BoundsManagerBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/beziers.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/include/private/SkFixed.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/complexclip2.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/PathBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/RectanizerSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/ChartBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/vertices.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PathOpsAngleIdeas.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/graphite/IntersectionTreeTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/AnimatedTextSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/AAClipBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/public.bzl
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PDFPrimitivesTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gn/core.gni
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/Matrix44Bench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/BulkRectBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/ScalarBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/include/BUILD.bazel
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/MatrixBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/roundrects.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/RoundRectTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/blurcircles2.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/modules/canvaskit/particles_bindings.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/core/SkEdgeBuilder.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/MipMapTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/VertBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/GpuRectanizerTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/BlurRectBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/modules/skparagraph/slides/ParagraphSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/PathIterBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/XferSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/Point3Test.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/polygons.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/include/utils/BUILD.bazel
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/dm/DMSrcSink.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/getpostextpath.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/ManyRectsSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/FlutterAnimateSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/variedtext.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/BitmapTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/ChineseFlingSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/ColorTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/MatrixTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/yuv420_odd_dim.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/ImageCycleBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/fuzz/FuzzEncoders.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/docs/examples/Bitmap_installPixels_2.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/ports/SkFontMgr_android_parser.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/ChecksumTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/ShapesBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/modules/sksg/slides/SVGPongSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/CmapBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/MathTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/core/SkBitmapProcState.h
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/src/ports/SkFontMgr_fontconfig.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/runtimeshader.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/ProcessorTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/RTreeBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/UtilsTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/discard.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/docs/examples/Octopus_Generator_Animated.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/gm/arcofzorro.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/TopoSortBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tools/viewer/GlyphTransformSlide.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/WindowRectanglesTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/GrMemoryPoolTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/bench/SortBench.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/SortTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/RELEASE_NOTES.txt
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/RTreeTest.cpp
[modify] https://crrev.com/0d4d11451c4f4e184305cbdbd67f6b3edfa4b0e3/tests/PathOpsAngleTest.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #52
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/2d666c4c768f85280666c905206140c4d39882a9
commit 2d666c4c768f85280666c905206140c4d39882a9
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Feb 13 16:33:13 2023
[base] Move SkMSAN into base
With some other misc fixes, like improving the IWYU mapping file.
Change-Id: I09a497825e9adc5d13a87914afe641691b42da40
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/642397
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/gn/core.gni
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/tests/SkVMTest.cpp
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/core/SkCanvas.cpp
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/core/BUILD.bazel
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/opts/SkBlitRow_opts.h
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/base/BUILD.bazel
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/images/SkJpegEncoder.cpp
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/opts/SkXfermode_opts.h
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/core/SkOpts_erms.cpp
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/opts/SkBitmapProcState_opts.h
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/images/SkPngEncoder.cpp
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/base/SkUtils.h
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/public.bzl
[rename] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/base/SkMSAN.h
https://skia.googlesource.com/skia/+/2d666c4c768f85280666c905206140c4d39882a9
commit 2d666c4c768f85280666c905206140c4d39882a9
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Feb 13 16:33:13 2023
[base] Move SkMSAN into base
With some other misc fixes, like improving the IWYU mapping file.
Change-Id: I09a497825e9adc5d13a87914afe641691b42da40
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/642397
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/gn/core.gni
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/tests/SkVMTest.cpp
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/core/SkCanvas.cpp
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/core/BUILD.bazel
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/opts/SkBlitRow_opts.h
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/base/BUILD.bazel
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/images/SkJpegEncoder.cpp
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/opts/SkXfermode_opts.h
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/core/SkOpts_erms.cpp
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/opts/SkBitmapProcState_opts.h
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/images/SkPngEncoder.cpp
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/base/SkUtils.h
[modify] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/public.bzl
[rename] https://crrev.com/2d666c4c768f85280666c905206140c4d39882a9/src/base/SkMSAN.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #53
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/c69d9991f51b749b867fdff8845db687a7d946a0
commit c69d9991f51b749b867fdff8845db687a7d946a0
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Feb 15 13:04:24 2023
Enforce IWYU on things needed for core build
Client CLs:
- http://ag/21408973
- https://crrev.com/c/4247679
- http://cl/509514434
- http://cl/509515755
non-trivial changes to:
- SkBitmap.h to allow forward declares of SkShader and SkTileMode.
- SkCanvas.h to allow SkSpecialImage to be forward-declared.
Everything else was mechanical.
Change-Id: I297fe955e1846cf3884da871a2a2a144bb7a9a42
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/642658
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkReadBuffer.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkWriteBuffer.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/tests/DrawBitmapRectTest.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkData.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/core/SkPixmap.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkICCPriv.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/core/SkData.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkMD5.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/encode/SkPngEncoder.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkColorSpacePriv.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/BUILD.bazel
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/tests/JpegGainmapTest.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/core/SkBitmap.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkMD5.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/shaders/SkColorShader.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkICC.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkPixmap.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkLocalMatrixImageFilter.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkReadBuffer.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/codec/SkCodec.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/encode/SkWebpEncoder.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkWriteBuffer.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/ports/SkFontHost_win.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/effects/SkRuntimeEffect.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkImageInfo.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/core/SkICC.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/encode/SkJpegEncoder.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkAutoPixmapStorage.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkCanvas.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/shaders/SkShader.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/gm/imagefromyuvtextures.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/gm/runtimeshader.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkDataTable.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/encode/SkEncoder.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkBitmap.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/tools/viewer/ClipSlide.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/images/SkImageEncoderPriv.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/core/SkCanvas.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/images/SkImageEncoderFns.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/BUILD.bazel
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/core/SkDataTable.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/gpu/ganesh/Device.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/core/SkImageInfo.h
https://skia.googlesource.com/skia/+/c69d9991f51b749b867fdff8845db687a7d946a0
commit c69d9991f51b749b867fdff8845db687a7d946a0
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Feb 15 13:04:24 2023
Enforce IWYU on things needed for core build
Client CLs:
- http://ag/21408973
- https://crrev.com/c/4247679
- http://cl/509514434
- http://cl/509515755
non-trivial changes to:
- SkBitmap.h to allow forward declares of SkShader and SkTileMode.
- SkCanvas.h to allow SkSpecialImage to be forward-declared.
Everything else was mechanical.
Change-Id: I297fe955e1846cf3884da871a2a2a144bb7a9a42
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/642658
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkReadBuffer.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkWriteBuffer.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/tests/DrawBitmapRectTest.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkData.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/core/SkPixmap.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkICCPriv.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/core/SkData.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkMD5.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/encode/SkPngEncoder.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkColorSpacePriv.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/BUILD.bazel
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/tests/JpegGainmapTest.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/core/SkBitmap.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkMD5.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/shaders/SkColorShader.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkICC.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkPixmap.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkLocalMatrixImageFilter.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkReadBuffer.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/codec/SkCodec.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/encode/SkWebpEncoder.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkWriteBuffer.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/ports/SkFontHost_win.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/effects/SkRuntimeEffect.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkImageInfo.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/core/SkICC.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/encode/SkJpegEncoder.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkAutoPixmapStorage.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkCanvas.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/shaders/SkShader.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/gm/imagefromyuvtextures.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/gm/runtimeshader.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkDataTable.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/encode/SkEncoder.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/core/SkBitmap.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/tools/viewer/ClipSlide.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/images/SkImageEncoderPriv.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/core/SkCanvas.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/images/SkImageEncoderFns.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/BUILD.bazel
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/core/SkDataTable.h
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/src/gpu/ganesh/Device.cpp
[modify] https://crrev.com/c69d9991f51b749b867fdff8845db687a7d946a0/include/core/SkImageInfo.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #54
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/0d5cd7f14fabb17c4aaa2a01b7358426c201a261
commit 0d5cd7f14fabb17c4aaa2a01b7358426c201a261
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Feb 15 17:02:29 2023
Split SkPixmap, and codec-related files for better modularization.
In the proof of concept PNG module build of Skia [1], splitting
these files makes it easier to build just the code necessary
to create a SkPixmap and encode it as a PNG file.
SkPixmapPriv only had one method which actually used the
private fields of SkPixmap and that was only used in one place.
Thus, I replaced it with a public API and inlined it, which
allowed the removal of the friend class. The remaining
usages were only used in the codec related code, so I moved
it out of core.
SkReadPixelsRec was used in one place (SkPixmap), so I
moved it from src/image to src/core and moved the implementation
out of SkImageInfo.cpp into its own file.
Likewise, SkWritePixelsRec is only used by SkBitmap
(so it stays in core) and had its implementation moved to
a new file.
To make the modularization attempt easier, I split out the
SkPixmap method implementations out which required
the CPU backend (erase, scalePixels). I'll figure out what
to do with those later.
Finally, SkEncoder's implementation of encodeRows was moved
to its own file to make bringing in exactly one codec
*without setting defines* easier. src/images/SkImageEncoder.cpp
will need a re-work as this project progresses.
[1] https://skia-review.googlesource.com/c/skia/+/636819
Bug: skia:13983
Change-Id: I91d3947f0c212b8440dd0161bd34f317bb70a77b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/643298
Reviewed-by: Ben Wagner <bungeman@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/gn/core.gni
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/include/core/SkPixmap.h
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/gn/codec.gni
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/core/BUILD.bazel
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/android/SkAnimatedImage.cpp
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/codec/SkCodecImageGenerator.cpp
[add] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/images/SkEncoder.cpp
[rename] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/core/SkReadPixelsRec.h
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/bench/ReadPixBench.cpp
[add] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/core/SkPixmapDraw.cpp
[add] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/core/SkWritePixelsRec.cpp
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/BUILD.gn
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/core/SkPixmap.cpp
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/image/BUILD.bazel
[add] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/core/SkReadPixelsRec.cpp
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/core/SkImageInfo.cpp
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/images/SkImageEncoder.cpp
[add] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/codec/SkPixmapUtils.cpp
[rename] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/codec/SkPixmapUtils.h
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/codec/BUILD.bazel
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/core/SkBitmap.cpp
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/ports/SkImageGeneratorCG.cpp
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/images/BUILD.bazel
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/public.bzl
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/core/SkWritePixelsRec.h
https://skia.googlesource.com/skia/+/0d5cd7f14fabb17c4aaa2a01b7358426c201a261
commit 0d5cd7f14fabb17c4aaa2a01b7358426c201a261
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Feb 15 17:02:29 2023
Split SkPixmap, and codec-related files for better modularization.
In the proof of concept PNG module build of Skia [1], splitting
these files makes it easier to build just the code necessary
to create a SkPixmap and encode it as a PNG file.
SkPixmapPriv only had one method which actually used the
private fields of SkPixmap and that was only used in one place.
Thus, I replaced it with a public API and inlined it, which
allowed the removal of the friend class. The remaining
usages were only used in the codec related code, so I moved
it out of core.
SkReadPixelsRec was used in one place (SkPixmap), so I
moved it from src/image to src/core and moved the implementation
out of SkImageInfo.cpp into its own file.
Likewise, SkWritePixelsRec is only used by SkBitmap
(so it stays in core) and had its implementation moved to
a new file.
To make the modularization attempt easier, I split out the
SkPixmap method implementations out which required
the CPU backend (erase, scalePixels). I'll figure out what
to do with those later.
Finally, SkEncoder's implementation of encodeRows was moved
to its own file to make bringing in exactly one codec
*without setting defines* easier. src/images/SkImageEncoder.cpp
will need a re-work as this project progresses.
[1] https://skia-review.googlesource.com/c/skia/+/636819
Bug: skia:13983
Change-Id: I91d3947f0c212b8440dd0161bd34f317bb70a77b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/643298
Reviewed-by: Ben Wagner <bungeman@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/gn/core.gni
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/include/core/SkPixmap.h
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/gn/codec.gni
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/core/BUILD.bazel
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/android/SkAnimatedImage.cpp
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/codec/SkCodecImageGenerator.cpp
[add] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/images/SkEncoder.cpp
[rename] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/core/SkReadPixelsRec.h
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/bench/ReadPixBench.cpp
[add] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/core/SkPixmapDraw.cpp
[add] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/core/SkWritePixelsRec.cpp
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/BUILD.gn
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/core/SkPixmap.cpp
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/image/BUILD.bazel
[add] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/core/SkReadPixelsRec.cpp
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/core/SkImageInfo.cpp
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/images/SkImageEncoder.cpp
[add] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/codec/SkPixmapUtils.cpp
[rename] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/codec/SkPixmapUtils.h
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/codec/BUILD.bazel
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/core/SkBitmap.cpp
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/ports/SkImageGeneratorCG.cpp
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/images/BUILD.bazel
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/public.bzl
[modify] https://crrev.com/0d5cd7f14fabb17c4aaa2a01b7358426c201a261/src/core/SkWritePixelsRec.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #55
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/7ab77ebd763de401cd559e3f254ee3e23ec3c2f4
commit 7ab77ebd763de401cd559e3f254ee3e23ec3c2f4
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Feb 16 14:19:51 2023
Have Skia build use lists of files instead of hard-coded paths
This makes renaming or otherwise splitting the encoder logic
easier.
Using skia_discardable_memory_chromium allows Skia to remove
chromium-specific files from its more general file lists.
Bug: skia:13983
Change-Id: I88c635db3197418e5ded8e279541bfd62b71d563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4260665
Reviewed-by: Florin Malita <fmalita@chromium.org>
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1106186}
[modify] https://crrev.com/7ab77ebd763de401cd559e3f254ee3e23ec3c2f4/skia/BUILD.gn
https://chromium.googlesource.com/chromium/src/+/7ab77ebd763de401cd559e3f254ee3e23ec3c2f4
commit 7ab77ebd763de401cd559e3f254ee3e23ec3c2f4
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Feb 16 14:19:51 2023
Have Skia build use lists of files instead of hard-coded paths
This makes renaming or otherwise splitting the encoder logic
easier.
Using skia_discardable_memory_chromium allows Skia to remove
chromium-specific files from its more general file lists.
Bug: skia:13983
Change-Id: I88c635db3197418e5ded8e279541bfd62b71d563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4260665
Reviewed-by: Florin Malita <fmalita@chromium.org>
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1106186}
[modify] https://crrev.com/7ab77ebd763de401cd559e3f254ee3e23ec3c2f4/skia/BUILD.gn
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #56
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/24984ec7ec49f93e6b6175ff8aa151f265188e39
commit 24984ec7ec49f93e6b6175ff8aa151f265188e39
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Feb 16 13:41:20 2023
Introduce filegroups and gni file lists for encoding logic
This will allow the Skia Chrome BUILD.gn file [3] have fewer
hard-coded paths and make CLs like [1] and [2] easier.
[1] https://skia-review.googlesource.com/c/skia/+/643298
[2] https://skia-review.googlesource.com/c/skia/+/644318
[3] https://source.chromium.org/chromium/chromium/src/+/main:skia/BUILD.gn;l=322;drc=1e4f64e234bf69fa231f5463cf18ebb74125f05c
Change-Id: Ie4f5c74f6a2a01c2e6f195a4680abd772d8f6c31
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/644658
Reviewed-by: Ben Wagner <bungeman@google.com>
[modify] https://crrev.com/24984ec7ec49f93e6b6175ff8aa151f265188e39/gn/core.gni
[modify] https://crrev.com/24984ec7ec49f93e6b6175ff8aa151f265188e39/BUILD.gn
[modify] https://crrev.com/24984ec7ec49f93e6b6175ff8aa151f265188e39/bazel/exporter_tool/main.go
[modify] https://crrev.com/24984ec7ec49f93e6b6175ff8aa151f265188e39/src/images/BUILD.bazel
https://skia.googlesource.com/skia/+/24984ec7ec49f93e6b6175ff8aa151f265188e39
commit 24984ec7ec49f93e6b6175ff8aa151f265188e39
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Feb 16 13:41:20 2023
Introduce filegroups and gni file lists for encoding logic
This will allow the Skia Chrome BUILD.gn file [3] have fewer
hard-coded paths and make CLs like [1] and [2] easier.
[1] https://skia-review.googlesource.com/c/skia/+/643298
[2] https://skia-review.googlesource.com/c/skia/+/644318
[3] https://source.chromium.org/chromium/chromium/src/+/main:skia/BUILD.gn;l=322;drc=1e4f64e234bf69fa231f5463cf18ebb74125f05c
Change-Id: Ie4f5c74f6a2a01c2e6f195a4680abd772d8f6c31
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/644658
Reviewed-by: Ben Wagner <bungeman@google.com>
[modify] https://crrev.com/24984ec7ec49f93e6b6175ff8aa151f265188e39/gn/core.gni
[modify] https://crrev.com/24984ec7ec49f93e6b6175ff8aa151f265188e39/BUILD.gn
[modify] https://crrev.com/24984ec7ec49f93e6b6175ff8aa151f265188e39/bazel/exporter_tool/main.go
[modify] https://crrev.com/24984ec7ec49f93e6b6175ff8aa151f265188e39/src/images/BUILD.bazel
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #57
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/64d3cff36a1596dfc50c1242d71ce47543d93723
commit 64d3cff36a1596dfc50c1242d71ce47543d93723
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Feb 16 19:10:32 2023
Use Skia's encode file lists instead of hard-coded files
After https://skia-review.googlesource.com/c/skia/+/644658 is rolled
into Chrome, this will clean up those hard-coded files so we
can seamlessly land CLs like
https://skia-review.googlesource.com/c/skia/+/644318
Bug: skia:13983
Change-Id: I01b1c5bcd6f15e1c74ef4c9c411ea075d6fcf718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4261368
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1106351}
[modify] https://crrev.com/64d3cff36a1596dfc50c1242d71ce47543d93723/skia/BUILD.gn
https://chromium.googlesource.com/chromium/src/+/64d3cff36a1596dfc50c1242d71ce47543d93723
commit 64d3cff36a1596dfc50c1242d71ce47543d93723
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Feb 16 19:10:32 2023
Use Skia's encode file lists instead of hard-coded files
After https://skia-review.googlesource.com/c/skia/+/644658 is rolled
into Chrome, this will clean up those hard-coded files so we
can seamlessly land CLs like
https://skia-review.googlesource.com/c/skia/+/644318
Bug: skia:13983
Change-Id: I01b1c5bcd6f15e1c74ef4c9c411ea075d6fcf718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4261368
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1106351}
[modify] https://crrev.com/64d3cff36a1596dfc50c1242d71ce47543d93723/skia/BUILD.gn
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #58
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/5c1224bc407e3c42cbb45a1ebed2f0fe7dd268b3
commit 5c1224bc407e3c42cbb45a1ebed2f0fe7dd268b3
Author: Iman Saboori <isaboori@google.com>
Date: Thu Feb 16 20:34:12 2023
Revert "Use Skia's encode file lists instead of hard-coded files"
This reverts commit 64d3cff36a1596dfc50c1242d71ce47543d93723.
Reason for revert: [Build sheriff] It stops code base to be compiled
crbug.com/1416980
Original change's description:
https://chromium.googlesource.com/chromium/src/+/5c1224bc407e3c42cbb45a1ebed2f0fe7dd268b3
commit 5c1224bc407e3c42cbb45a1ebed2f0fe7dd268b3
Author: Iman Saboori <isaboori@google.com>
Date: Thu Feb 16 20:34:12 2023
Revert "Use Skia's encode file lists instead of hard-coded files"
This reverts commit 64d3cff36a1596dfc50c1242d71ce47543d93723.
Reason for revert: [Build sheriff] It stops code base to be compiled
crbug.com/1416980
Original change's description:
Bug: skia:13983
Change-Id: If6f6a7e6deffe8b99d008c529bf85ebf50c35a75
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4262691
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Iman Saboori <isaboori@google.com>
Cr-Commit-Position: refs/heads/main@{#1106406}
[modify] https://crrev.com/5c1224bc407e3c42cbb45a1ebed2f0fe7dd268b3/skia/BUILD.gn
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #59
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/cdb0955534cd7400c67dc82b8e549a2892853e87
commit cdb0955534cd7400c67dc82b8e549a2892853e87
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Feb 16 19:45:43 2023
Move src/images to src/encode
This better aligns to include/encode and more accurately describes what
files in the folder do (encode pixels into .png, .jpeg, etc).
Change-Id: Ib85a6417ed4b03b9a02cc19582fddfc7d3802dbd
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/644318
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/.bazelrc
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/pdf/BUILD.bazel
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/gn/core.gni
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkJPEGWriteUtility.h
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkWebpEncoder.cpp
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkImageEncoderPriv.h
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/bazel/cc_binary_with_flags.bzl
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkJPEGWriteUtility.cpp
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/gm/encode_platform.cpp
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/BUILD.gn
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/defines.bzl
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/tests/NdkEncodeTest.cpp
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/ports/SkImageEncoder_CG.cpp
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkJpegGainmapEncoder.cpp
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/toolchain/linux_trampolines/clang_trampoline_linux.sh
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkImageEncoder.cpp
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkEncoder.cpp
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/codec/BUILD.bazel
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkImageEncoderFns.h
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/ports/SkImageEncoder_NDK.cpp
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/BUILD.bazel
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkJpegEncoder.cpp
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkPngEncoder.cpp
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/ports/SkImageEncoder_WIC.cpp
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/bazel/exporter_tool/main.go
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/BUILD.bazel
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/public.bzl
https://skia.googlesource.com/skia/+/cdb0955534cd7400c67dc82b8e549a2892853e87
commit cdb0955534cd7400c67dc82b8e549a2892853e87
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Feb 16 19:45:43 2023
Move src/images to src/encode
This better aligns to include/encode and more accurately describes what
files in the folder do (encode pixels into .png, .jpeg, etc).
Change-Id: Ib85a6417ed4b03b9a02cc19582fddfc7d3802dbd
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/644318
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/.bazelrc
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/pdf/BUILD.bazel
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/gn/core.gni
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkJPEGWriteUtility.h
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkWebpEncoder.cpp
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkImageEncoderPriv.h
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/bazel/cc_binary_with_flags.bzl
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkJPEGWriteUtility.cpp
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/gm/encode_platform.cpp
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/BUILD.gn
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/defines.bzl
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/tests/NdkEncodeTest.cpp
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/ports/SkImageEncoder_CG.cpp
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkJpegGainmapEncoder.cpp
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/toolchain/linux_trampolines/clang_trampoline_linux.sh
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkImageEncoder.cpp
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkEncoder.cpp
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/codec/BUILD.bazel
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkImageEncoderFns.h
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/ports/SkImageEncoder_NDK.cpp
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/BUILD.bazel
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkJpegEncoder.cpp
[rename] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/encode/SkPngEncoder.cpp
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/ports/SkImageEncoder_WIC.cpp
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/bazel/exporter_tool/main.go
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/src/BUILD.bazel
[modify] https://crrev.com/cdb0955534cd7400c67dc82b8e549a2892853e87/public.bzl
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #60
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/da6ae9bbeed261b92ba2bc26455dbc63b5636765
commit da6ae9bbeed261b92ba2bc26455dbc63b5636765
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Feb 16 23:02:17 2023
Revert "Move src/images to src/encode"
This reverts commit cdb0955534cd7400c67dc82b8e549a2892853e87.
Reason for revert: Chrome has reverted https://chromium-review.googlesource.com/c/chromium/src/+/4262691
Original change's description:
https://skia.googlesource.com/skia/+/da6ae9bbeed261b92ba2bc26455dbc63b5636765
commit da6ae9bbeed261b92ba2bc26455dbc63b5636765
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Feb 16 23:02:17 2023
Revert "Move src/images to src/encode"
This reverts commit cdb0955534cd7400c67dc82b8e549a2892853e87.
Reason for revert: Chrome has reverted https://chromium-review.googlesource.com/c/chromium/src/+/4262691
Original change's description:
Bug: skia:13983
Change-Id: Ic241d061edcd84e2ff3791a7df127014a483803a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/645058
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
[modify] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/.bazelrc
[modify] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/src/pdf/BUILD.bazel
[modify] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/gn/core.gni
[modify] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/bazel/cc_binary_with_flags.bzl
[rename] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/src/images/SkJpegGainmapEncoder.cpp
[rename] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/src/images/SkJpegEncoder.cpp
[rename] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/src/images/SkJPEGWriteUtility.cpp
[rename] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/src/images/SkWebpEncoder.cpp
[modify] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/gm/encode_platform.cpp
[rename] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/src/images/SkEncoder.cpp
[modify] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/BUILD.gn
[modify] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/defines.bzl
[modify] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/tests/NdkEncodeTest.cpp
[rename] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/src/images/SkImageEncoder.cpp
[modify] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/src/ports/SkImageEncoder_CG.cpp
[modify] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/src/codec/BUILD.bazel
[modify] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/src/ports/SkImageEncoder_NDK.cpp
[rename] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/src/images/SkImageEncoderPriv.h
[rename] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/src/images/SkPngEncoder.cpp
[modify] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/src/ports/SkImageEncoder_WIC.cpp
[modify] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/bazel/exporter_tool/main.go
[rename] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/src/images/SkImageEncoderFns.h
[modify] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/src/BUILD.bazel
[rename] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/src/images/BUILD.bazel
[rename] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/src/images/SkJPEGWriteUtility.h
[modify] https://crrev.com/da6ae9bbeed261b92ba2bc26455dbc63b5636765/public.bzl
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #61
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/372a0857bf47009a6b245679a5d926b3bf5ca92a
commit 372a0857bf47009a6b245679a5d926b3bf5ca92a
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Feb 17 11:44:38 2023
Reland "Move src/images to src/encode"
This reverts commit da6ae9bbeed261b92ba2bc26455dbc63b5636765.
Reason for revert: Chrome has rolled
Original change's description:
https://skia.googlesource.com/skia/+/372a0857bf47009a6b245679a5d926b3bf5ca92a
commit 372a0857bf47009a6b245679a5d926b3bf5ca92a
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Feb 17 11:44:38 2023
Reland "Move src/images to src/encode"
This reverts commit da6ae9bbeed261b92ba2bc26455dbc63b5636765.
Reason for revert: Chrome has rolled
Original change's description:
Bug: skia:13983
Change-Id: Ia7e1cf429fdbf9564f526c309f5b39b1d4ea0f0d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/645296
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
[modify] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/.bazelrc
[modify] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/src/pdf/BUILD.bazel
[modify] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/gn/core.gni
[rename] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/src/encode/SkJPEGWriteUtility.h
[rename] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/src/encode/SkImageEncoderPriv.h
[rename] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/src/encode/SkWebpEncoder.cpp
[modify] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/bazel/cc_binary_with_flags.bzl
[rename] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/src/encode/SkJPEGWriteUtility.cpp
[modify] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/gm/encode_platform.cpp
[modify] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/BUILD.gn
[modify] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/defines.bzl
[modify] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/tests/NdkEncodeTest.cpp
[rename] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/src/encode/SkJpegGainmapEncoder.cpp
[modify] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/src/ports/SkImageEncoder_CG.cpp
[modify] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/toolchain/linux_trampolines/clang_trampoline_linux.sh
[rename] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/src/encode/SkImageEncoder.cpp
[modify] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/src/codec/BUILD.bazel
[rename] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/src/encode/SkEncoder.cpp
[rename] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/src/encode/SkImageEncoderFns.h
[modify] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/src/ports/SkImageEncoder_NDK.cpp
[rename] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/src/encode/BUILD.bazel
[rename] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/src/encode/SkJpegEncoder.cpp
[rename] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/src/encode/SkPngEncoder.cpp
[modify] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/src/ports/SkImageEncoder_WIC.cpp
[modify] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/bazel/exporter_tool/main.go
[modify] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/src/BUILD.bazel
[modify] https://crrev.com/372a0857bf47009a6b245679a5d926b3bf5ca92a/public.bzl
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #62
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/d62f12f4d34253ba142430839137ecfd782fab73
commit d62f12f4d34253ba142430839137ecfd782fab73
Author: Kevin Lubick <kjlubick@chromium.org>
Date: Fri Feb 17 13:09:40 2023
Reland "Use Skia's encode file lists instead of hard-coded files"
This reverts commit 5c1224bc407e3c42cbb45a1ebed2f0fe7dd268b3.
Reason for revert: Can reland now that https://skia-review.googlesource.com/c/skia/+/644658 has rerolled into Chrome
Original change's description:
https://chromium.googlesource.com/chromium/src/+/d62f12f4d34253ba142430839137ecfd782fab73
commit d62f12f4d34253ba142430839137ecfd782fab73
Author: Kevin Lubick <kjlubick@chromium.org>
Date: Fri Feb 17 13:09:40 2023
Reland "Use Skia's encode file lists instead of hard-coded files"
This reverts commit 5c1224bc407e3c42cbb45a1ebed2f0fe7dd268b3.
Reason for revert: Can reland now that https://skia-review.googlesource.com/c/skia/+/644658 has rerolled into Chrome
Original change's description:
Bug: skia:13983
Change-Id: Icccc355d88396bd9fddb09d5c532ba3a8a095b0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4262157
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1106734}
[modify] https://crrev.com/d62f12f4d34253ba142430839137ecfd782fab73/skia/BUILD.gn
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #63
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a
commit ad8cdf1f6239a4a88a238577232c2d5c05f6a12a
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Feb 24 17:12:13 2023
Clear non-image stuff out of SkImage.cpp
Change-Id: I3fd2378e25ae86b116be08edf31be07d2be802c6
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/648856
Reviewed-by: Nicolette Prevost <nicolettep@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Nicolette Prevost <nicolettep@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
[add] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/src/core/SkMipmapBuilder.cpp
[modify] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/gn/core.gni
[modify] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/src/image/SkImage.cpp
[modify] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/src/core/SkSamplingPriv.h
[modify] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/src/core/BUILD.bazel
[modify] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/public.bzl
[modify] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/src/core/SkMipmapBuilder.h
https://skia.googlesource.com/skia/+/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a
commit ad8cdf1f6239a4a88a238577232c2d5c05f6a12a
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Feb 24 17:12:13 2023
Clear non-image stuff out of SkImage.cpp
Change-Id: I3fd2378e25ae86b116be08edf31be07d2be802c6
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/648856
Reviewed-by: Nicolette Prevost <nicolettep@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Nicolette Prevost <nicolettep@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
[add] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/src/core/SkMipmapBuilder.cpp
[modify] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/gn/core.gni
[modify] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/src/image/SkImage.cpp
[modify] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/src/core/SkSamplingPriv.h
[modify] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/src/core/BUILD.bazel
[modify] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/public.bzl
[modify] https://crrev.com/ad8cdf1f6239a4a88a238577232c2d5c05f6a12a/src/core/SkMipmapBuilder.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #64
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1
commit 7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Feb 27 13:39:31 2023
Remove SK_HAS_ANDROID_CODEC guard
It was only used in one place and was on by default in nearly every
build. Let's try removing the guard.
This requires breaking a dependency knot between SkCodec
and SkAndroidCodec. If a frame depends on frame N-1,
SkCodec would need to have SkAndroidCodec decode frame N-1, which
in turn requires a call to handleFrameIndex at N-1.
Instead of having SkCodec know about SkAndroidCodec, I turned
the call into a callback function, which *only* SkAndroidCodec sets.
This logic confused me greatly until I realized that this was
(complicated) recursion and then what the base case was (finding
a frame that does not need an earlier frame). I added some comments
to hopefully make that connection easier for future readers of
the code.
I also learned that if you want to be able to pass in a lambda
as a function parameter, you cannot use a function pointer
but must take in a std::function.
See also the discussion on https://skia-review.googlesource.com/c/skia/+/333225?tab=comments
Change-Id: I71c2e393d1a81b782f04433750134f32ea7dd2be
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/645436
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/modules/canvaskit/BUILD.gn
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/src/codec/SkCodec.cpp
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/BUILD.gn
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/include/codec/SkCodec.h
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/src/codec/SkAndroidCodec.cpp
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/public.bzl
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/defines.bzl
https://skia.googlesource.com/skia/+/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1
commit 7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Feb 27 13:39:31 2023
Remove SK_HAS_ANDROID_CODEC guard
It was only used in one place and was on by default in nearly every
build. Let's try removing the guard.
This requires breaking a dependency knot between SkCodec
and SkAndroidCodec. If a frame depends on frame N-1,
SkCodec would need to have SkAndroidCodec decode frame N-1, which
in turn requires a call to handleFrameIndex at N-1.
Instead of having SkCodec know about SkAndroidCodec, I turned
the call into a callback function, which *only* SkAndroidCodec sets.
This logic confused me greatly until I realized that this was
(complicated) recursion and then what the base case was (finding
a frame that does not need an earlier frame). I added some comments
to hopefully make that connection easier for future readers of
the code.
I also learned that if you want to be able to pass in a lambda
as a function parameter, you cannot use a function pointer
but must take in a std::function.
See also the discussion on https://skia-review.googlesource.com/c/skia/+/333225?tab=comments
Change-Id: I71c2e393d1a81b782f04433750134f32ea7dd2be
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/645436
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/modules/canvaskit/BUILD.gn
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/src/codec/SkCodec.cpp
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/BUILD.gn
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/include/codec/SkCodec.h
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/src/codec/SkAndroidCodec.cpp
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/public.bzl
[modify] https://crrev.com/7e67b0b0754d3fd739ec1c709ab56d1f8b1bfdb1/defines.bzl
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #65
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/a13d52c7aaa842ddc9cea34f779561152bbeff78
commit a13d52c7aaa842ddc9cea34f779561152bbeff78
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Feb 27 16:30:55 2023
Remove unused method from SkClipStack
This breaks one more link between src/core and src/gpu
Change-Id: I3d63edbc85cb22d9c0d2fe77ee60eb4386577841
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/649520
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Nicolette Prevost <nicolettep@google.com>
[modify] https://crrev.com/a13d52c7aaa842ddc9cea34f779561152bbeff78/src/core/SkClipStack.h
[modify] https://crrev.com/a13d52c7aaa842ddc9cea34f779561152bbeff78/src/core/SkClipStack.cpp
https://skia.googlesource.com/skia/+/a13d52c7aaa842ddc9cea34f779561152bbeff78
commit a13d52c7aaa842ddc9cea34f779561152bbeff78
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Feb 27 16:30:55 2023
Remove unused method from SkClipStack
This breaks one more link between src/core and src/gpu
Change-Id: I3d63edbc85cb22d9c0d2fe77ee60eb4386577841
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/649520
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Nicolette Prevost <nicolettep@google.com>
[modify] https://crrev.com/a13d52c7aaa842ddc9cea34f779561152bbeff78/src/core/SkClipStack.h
[modify] https://crrev.com/a13d52c7aaa842ddc9cea34f779561152bbeff78/src/core/SkClipStack.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #66
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/40d29bfd33c33e97bb3c412c901fb7ecbede9594
commit 40d29bfd33c33e97bb3c412c901fb7ecbede9594
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Feb 27 17:49:45 2023
Rename SK_SUPPORT_GPU -> SK_GANESH_ENABLED
Many things were a mechanical
SK_SUPPORT_GPU -> defined(SK_GANESH_ENABLED)
SK_GPU_V1 -> defined(SK_GANESH_ENABLED)
except SkTypes.h, which includes a backwards-compatible
check for the old define, and a few other files to clean
up some #ifdefs, #includes, and comments.
Suggested Review Order
- SkTypes.h, noting that SK_GANESH_ENABLED is no longer
on by default.
- BUILD.gn.
- defines.bzl to see updates for Bazel version.
- All other files
Change-Id: I05a68f1b52395978b6192485194c937b04ac5ca5
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/647540
Reviewed-by: Greg Daniel <egdaniel@google.com>
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkPictureRecord.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/imagefilters/SkBlurImageFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/TriangulatingPathRendererTests.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/modules/canvaskit/compile_gm.sh
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/ToolUtils.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkImage.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/text/gpu/SubRunContainer.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/gn/skia.gni
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkPictureShader.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkDeferredDisplayListPriv.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkComposeShader.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/VkYcbcrSamplerTest.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/text/gpu/SubRunContainer.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/core/SkImage.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkRecordDraw.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkBlendModeBlender.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkPicture.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkPictureData.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/debugger/DebugCanvas.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkMaskFilterBase.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/ToolUtils.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkGpuBlurUtils.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkBlendModePriv.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/imagefilters/SkDisplacementMapImageFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkBlendModeBlender.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/sksl/SkSLPool.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkColorFilterShader.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/gradients/SkLinearGradient.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkRecords.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/SkShaderMaskFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkPromiseImageTexture.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/gpu/GrContextThreadSafeProxy.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkBlenderBase.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/VkPriorityExtensionTest.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/utils/SkShadowUtils.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/imagefilters/SkMatrixConvolutionImageFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkCanvasPriv.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkMeshPriv.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkColorFilter_Matrix.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/gpu/ganesh/GrDrawingManager.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/imagefilters/SkBlendImageFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkStrikeSpec.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/text/gpu/TextBlob.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkStrikeSpec.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/imagefilters/SkMagnifierImageFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/config/SkUserConfig.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkGpuBlurUtils.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkPictureData.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/imagefilters/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/imagefilters/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/debugger/DebugCanvas.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/gpu/GrBackendSurface.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/gpu/graphite/Image_Base_Graphite.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkCoordClampShader.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkImage_Base.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/sksl/SkSLUtil.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/utils/SkShadowTessellator.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkColorFilterBase.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/gm/slug.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkCanvas.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkDevice.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/sksl/SkSLCompiler.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkSpecialImage.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/sksl/codegen/SkSLPipelineStageCodeGenerator.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/MultiPictureDocumentTest.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/viewer/RectanizerSlide.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/utils/SkNWayCanvas.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkPicturePlayback.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkImageShader.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkSurface_Gpu.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkTextBlob.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/viewer/AnimatedTextSlide.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkSpecialSurface.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkImageShader.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkLocalMatrixShader.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/public.bzl
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/gpu/graphite/Surface_Graphite.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/BazelTestRunner.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/text/gpu/TextBlobRedrawCoordinator.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/GrAHardwareBufferTest.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/gpu/ProxyUtils.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkImage_Lazy.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/core/SkTypes.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/VkProtectedContextTest.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/WrappedSurfaceCopyOnWriteTest.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkSurface_GpuMtl.mm
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/viewer/StrokeVerbSlide.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkSpecialSurface.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/SkTableColorFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkDevice.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkMesh.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkPictureRecord.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/sksl/SkSLMemoryPool.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkColorShader.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/viewer/Viewer.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkSurface.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkColorFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/android/SkAndroidFrameworkUtils.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/Test.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkYUVAPixmaps.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/skottie_ios_app/GrContextHolder.mm
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkStrike.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/defines.bzl
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/core/SkSurfaceCharacterization.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/android/SkAndroidFrameworkUtils.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/skottie_ios_app/main.mm
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkDeferredDisplayListRecorder.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/sksl/codegen/SkSLPipelineStageCodeGenerator.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/text/gpu/TextBlobRedrawCoordinator.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/gpu/graphite/SpecialImage_Graphite.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/imagefilters/SkLightingImageFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkMaskFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/gpu/graphite/Image_Base_Graphite.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/gpu/ProxyUtils.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkRecorder.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkDeferredDisplayList.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkChromeRemoteGlyphCache.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/bench/ColorFilterBench.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkLocalMatrixShader.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/core/SkImageGenerator.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkImageGenerator.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/text/gpu/GlyphVector.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkClipStack.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkSpecialImage.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/utils/SkGaussianColorFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/core/SkCanvas.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkSurface_Gpu.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkCanvasPriv.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/modules/canvaskit/BUILD.gn
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkShaderBase.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/viewer/ChineseFlingSlide.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/gradients/SkTwoPointConicalGradient.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkRecorder.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/sksl/SkSLUtil.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkXfermode.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkPerlinNoiseShader.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/core/SkPromiseImageTexture.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkImageFilter_Base.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkRuntimeEffect.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/BUILD.gn
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkSurfaceCharacterization.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/effects/SkRuntimeEffect.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkImageFilterTypes.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkRecordedDrawable.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkStrikeCache.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/gradients/SkLinearGradient.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/debugger/DrawCommand.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/gpu/graphite/Surface_Graphite.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/core/SkDeferredDisplayListRecorder.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkColorFilterShader.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkSurface_Base.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/fuzz/FuzzCanvas.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkModeColorFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/gradients/SkRadialGradient.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkShader.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/text/gpu/TextBlob.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/viewer/PathTessellatorsSlide.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkImageFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/gradients/SkSweepGradient.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/core/SkDeferredDisplayList.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/VkHardwareBufferTest.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/gpu/GrContextOptions.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/utils/SkNWayCanvas.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/modules/canvaskit/compile.sh
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/viewer/TextureUploadSlide.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/core/SkSurface.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkBlurMF.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/VkDrawableTest.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/RELEASE_NOTES.txt
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/imagefilters/SkAlphaThresholdImageFilter.cpp
https://skia.googlesource.com/skia/+/40d29bfd33c33e97bb3c412c901fb7ecbede9594
commit 40d29bfd33c33e97bb3c412c901fb7ecbede9594
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Feb 27 17:49:45 2023
Rename SK_SUPPORT_GPU -> SK_GANESH_ENABLED
Many things were a mechanical
SK_SUPPORT_GPU -> defined(SK_GANESH_ENABLED)
SK_GPU_V1 -> defined(SK_GANESH_ENABLED)
except SkTypes.h, which includes a backwards-compatible
check for the old define, and a few other files to clean
up some #ifdefs, #includes, and comments.
Suggested Review Order
- SkTypes.h, noting that SK_GANESH_ENABLED is no longer
on by default.
- BUILD.gn.
- defines.bzl to see updates for Bazel version.
- All other files
Change-Id: I05a68f1b52395978b6192485194c937b04ac5ca5
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/647540
Reviewed-by: Greg Daniel <egdaniel@google.com>
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkPictureRecord.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/imagefilters/SkBlurImageFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/TriangulatingPathRendererTests.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/modules/canvaskit/compile_gm.sh
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/ToolUtils.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkImage.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/text/gpu/SubRunContainer.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/gn/skia.gni
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkPictureShader.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkDeferredDisplayListPriv.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkComposeShader.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/VkYcbcrSamplerTest.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/text/gpu/SubRunContainer.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/core/SkImage.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkRecordDraw.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkBlendModeBlender.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkPicture.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkPictureData.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/debugger/DebugCanvas.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkMaskFilterBase.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/ToolUtils.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkGpuBlurUtils.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkBlendModePriv.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/imagefilters/SkDisplacementMapImageFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkBlendModeBlender.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/sksl/SkSLPool.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkColorFilterShader.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/gradients/SkLinearGradient.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkRecords.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/SkShaderMaskFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkPromiseImageTexture.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/gpu/GrContextThreadSafeProxy.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkBlenderBase.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/VkPriorityExtensionTest.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/utils/SkShadowUtils.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/imagefilters/SkMatrixConvolutionImageFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkCanvasPriv.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkMeshPriv.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkColorFilter_Matrix.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/gpu/ganesh/GrDrawingManager.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/imagefilters/SkBlendImageFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkStrikeSpec.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/text/gpu/TextBlob.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkStrikeSpec.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/imagefilters/SkMagnifierImageFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/config/SkUserConfig.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkGpuBlurUtils.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkPictureData.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/imagefilters/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/imagefilters/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/debugger/DebugCanvas.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/gpu/GrBackendSurface.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/gpu/graphite/Image_Base_Graphite.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkCoordClampShader.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkImage_Base.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/sksl/SkSLUtil.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/utils/SkShadowTessellator.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkColorFilterBase.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/gm/slug.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkCanvas.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkDevice.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/sksl/SkSLCompiler.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkSpecialImage.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/sksl/codegen/SkSLPipelineStageCodeGenerator.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/MultiPictureDocumentTest.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/viewer/RectanizerSlide.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/utils/SkNWayCanvas.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkPicturePlayback.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkImageShader.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkSurface_Gpu.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkTextBlob.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/viewer/AnimatedTextSlide.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkSpecialSurface.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkImageShader.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkLocalMatrixShader.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/public.bzl
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/gpu/graphite/Surface_Graphite.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/BazelTestRunner.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/text/gpu/TextBlobRedrawCoordinator.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/GrAHardwareBufferTest.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/gpu/ProxyUtils.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkImage_Lazy.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/core/SkTypes.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/VkProtectedContextTest.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/WrappedSurfaceCopyOnWriteTest.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkSurface_GpuMtl.mm
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/viewer/StrokeVerbSlide.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkSpecialSurface.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/SkTableColorFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkDevice.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkMesh.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkPictureRecord.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/sksl/SkSLMemoryPool.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkColorShader.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/viewer/Viewer.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkSurface.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkColorFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/android/SkAndroidFrameworkUtils.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/Test.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkYUVAPixmaps.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/skottie_ios_app/GrContextHolder.mm
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkStrike.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/defines.bzl
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/core/SkSurfaceCharacterization.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/android/SkAndroidFrameworkUtils.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/skottie_ios_app/main.mm
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkDeferredDisplayListRecorder.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/sksl/codegen/SkSLPipelineStageCodeGenerator.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/text/gpu/TextBlobRedrawCoordinator.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/gpu/graphite/SpecialImage_Graphite.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/imagefilters/SkLightingImageFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkMaskFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/gpu/graphite/Image_Base_Graphite.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/gpu/ProxyUtils.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkRecorder.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkDeferredDisplayList.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkChromeRemoteGlyphCache.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/bench/ColorFilterBench.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkLocalMatrixShader.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/core/SkImageGenerator.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkImageGenerator.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/text/gpu/GlyphVector.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkClipStack.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkSpecialImage.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/utils/SkGaussianColorFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/core/SkCanvas.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkSurface_Gpu.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkCanvasPriv.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/modules/canvaskit/BUILD.gn
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkShaderBase.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/viewer/ChineseFlingSlide.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/gradients/SkTwoPointConicalGradient.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkRecorder.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/sksl/SkSLUtil.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkXfermode.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkPerlinNoiseShader.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/core/SkPromiseImageTexture.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkImageFilter_Base.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkRuntimeEffect.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/BUILD.gn
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkSurfaceCharacterization.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/effects/SkRuntimeEffect.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkImageFilterTypes.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkRecordedDrawable.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkStrikeCache.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/gradients/SkLinearGradient.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/debugger/DrawCommand.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/gpu/graphite/Surface_Graphite.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/core/SkDeferredDisplayListRecorder.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkColorFilterShader.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/image/SkSurface_Base.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/fuzz/FuzzCanvas.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkModeColorFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/gradients/SkRadialGradient.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/SkShader.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/text/gpu/TextBlob.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/viewer/PathTessellatorsSlide.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkImageFilter.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/shaders/gradients/SkSweepGradient.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/core/SkDeferredDisplayList.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/VkHardwareBufferTest.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/gpu/GrContextOptions.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/utils/SkNWayCanvas.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/modules/canvaskit/compile.sh
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tools/viewer/TextureUploadSlide.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/include/core/SkSurface.h
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/core/SkBlurMF.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/tests/VkDrawableTest.cpp
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/RELEASE_NOTES.txt
[modify] https://crrev.com/40d29bfd33c33e97bb3c412c901fb7ecbede9594/src/effects/imagefilters/SkAlphaThresholdImageFilter.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #67
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/f9c77b544bbf313749ca5949c85048f500990a3c
commit f9c77b544bbf313749ca5949c85048f500990a3c
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Feb 28 12:30:15 2023
Remove shim files
This private files are no longer used by Android.
No-Try: true
Change-Id: Ib337c21d9c388edb3f74f7004f47f7aef60cf37a
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/650117
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/f9c77b544bbf313749ca5949c85048f500990a3c/gn/core.gni
[delete] https://crrev.com/bed6349fac158d3f121f06ea5add7200be44bf30/src/core/SkTSearch.h
[modify] https://crrev.com/f9c77b544bbf313749ca5949c85048f500990a3c/tools/rewrite_includes.py
[modify] https://crrev.com/f9c77b544bbf313749ca5949c85048f500990a3c/include/private/BUILD.bazel
[delete] https://crrev.com/bed6349fac158d3f121f06ea5add7200be44bf30/include/private/SkMalloc.h
[delete] https://crrev.com/bed6349fac158d3f121f06ea5add7200be44bf30/include/private/SkFixed.h
https://skia.googlesource.com/skia/+/f9c77b544bbf313749ca5949c85048f500990a3c
commit f9c77b544bbf313749ca5949c85048f500990a3c
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Feb 28 12:30:15 2023
Remove shim files
This private files are no longer used by Android.
No-Try: true
Change-Id: Ib337c21d9c388edb3f74f7004f47f7aef60cf37a
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/650117
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/f9c77b544bbf313749ca5949c85048f500990a3c/gn/core.gni
[delete] https://crrev.com/bed6349fac158d3f121f06ea5add7200be44bf30/src/core/SkTSearch.h
[modify] https://crrev.com/f9c77b544bbf313749ca5949c85048f500990a3c/tools/rewrite_includes.py
[modify] https://crrev.com/f9c77b544bbf313749ca5949c85048f500990a3c/include/private/BUILD.bazel
[delete] https://crrev.com/bed6349fac158d3f121f06ea5add7200be44bf30/include/private/SkMalloc.h
[delete] https://crrev.com/bed6349fac158d3f121f06ea5add7200be44bf30/include/private/SkFixed.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #68
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5
commit 78b8b95fdb15ab84d7c734fb2674a3504c6d13e5
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Mar 02 22:51:10 2023
Break up SkImage and SkSurfaces into more .h and .cpp files
We want to be able to make an SkImage_Raster subclass and that
is much easier if it is in its own file.
As long as I was breaking up that, I went and took care of some
other places where there were many class methods jammed into
other .cpp files.
Bug: skia:13983
Change-Id: I508d95ebaf84986914fdd6d83fbfa68c4a104bb1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/651422
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/gn/core.gni
[add] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkSurface_Null.cpp
[add] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkSurface_Raster.h
[add] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkImage_Raster.h
[modify] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkSurface_Base.h
[add] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkSurface_Base.cpp
[modify] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkImage.cpp
[modify] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkSurface.cpp
[add] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkImage_Base.cpp
[modify] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/BUILD.bazel
[modify] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkSurface_Raster.cpp
[modify] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/public.bzl
https://skia.googlesource.com/skia/+/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5
commit 78b8b95fdb15ab84d7c734fb2674a3504c6d13e5
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Mar 02 22:51:10 2023
Break up SkImage and SkSurfaces into more .h and .cpp files
We want to be able to make an SkImage_Raster subclass and that
is much easier if it is in its own file.
As long as I was breaking up that, I went and took care of some
other places where there were many class methods jammed into
other .cpp files.
Bug: skia:13983
Change-Id: I508d95ebaf84986914fdd6d83fbfa68c4a104bb1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/651422
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/gn/core.gni
[add] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkSurface_Null.cpp
[add] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkSurface_Raster.h
[add] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkImage_Raster.h
[modify] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkSurface_Base.h
[add] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkSurface_Base.cpp
[modify] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkImage.cpp
[modify] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkSurface.cpp
[add] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkImage_Base.cpp
[modify] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/BUILD.bazel
[modify] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/src/image/SkSurface_Raster.cpp
[modify] https://crrev.com/78b8b95fdb15ab84d7c734fb2674a3504c6d13e5/public.bzl
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #69
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/8a19083607ed9dc42a875919710bf99e36b67e87
commit 8a19083607ed9dc42a875919710bf99e36b67e87
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Mar 13 14:14:57 2023
Add alternate image pinning API
A smaller version of https://skia-review.googlesource.com/c/skia/+/651760
which eventually aims at moving the GPU code out of SkImage_Raster
and others.
It introduces a type() method to be able to correctly downcast
SkImage_Base subtypes.
Change-Id: Id42ad55722abca32b54c78e09c6ca54dae4d9cbe
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/651760
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/gpu/ganesh/BUILD.bazel
[add] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/gpu/ganesh/GrPinnableImage.cpp
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/image/SkImage_GpuYUVA.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/image/SkImage_Raster.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/image/SkImage_Lazy.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/include/android/BUILD.bazel
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/gn/gpu.gni
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/core/SkImagePriv.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/gpu/ganesh/GrDrawingManager.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/image/SkImage_Gpu.cpp
[add] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/image/SkImage_AndroidFactories.cpp
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/bazel/exporter_tool/main.go
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/gpu/graphite/Image_Base_Graphite.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/gpu/graphite/Image_YUVA_Graphite.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/image/BUILD.bazel
[add] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/include/android/SkImageAndroid.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/image/SkImage_Base.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/include/core/SkImage.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/gpu/graphite/Image_Graphite.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/image/SkImage_Gpu.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/tests/PinnedImageTest.cpp
https://skia.googlesource.com/skia/+/8a19083607ed9dc42a875919710bf99e36b67e87
commit 8a19083607ed9dc42a875919710bf99e36b67e87
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Mar 13 14:14:57 2023
Add alternate image pinning API
A smaller version of https://skia-review.googlesource.com/c/skia/+/651760
which eventually aims at moving the GPU code out of SkImage_Raster
and others.
It introduces a type() method to be able to correctly downcast
SkImage_Base subtypes.
Change-Id: Id42ad55722abca32b54c78e09c6ca54dae4d9cbe
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/651760
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/gpu/ganesh/BUILD.bazel
[add] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/gpu/ganesh/GrPinnableImage.cpp
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/image/SkImage_GpuYUVA.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/image/SkImage_Raster.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/image/SkImage_Lazy.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/include/android/BUILD.bazel
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/gn/gpu.gni
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/core/SkImagePriv.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/gpu/ganesh/GrDrawingManager.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/image/SkImage_Gpu.cpp
[add] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/image/SkImage_AndroidFactories.cpp
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/bazel/exporter_tool/main.go
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/gpu/graphite/Image_Base_Graphite.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/gpu/graphite/Image_YUVA_Graphite.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/image/BUILD.bazel
[add] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/include/android/SkImageAndroid.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/image/SkImage_Base.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/include/core/SkImage.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/gpu/graphite/Image_Graphite.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/src/image/SkImage_Gpu.h
[modify] https://crrev.com/8a19083607ed9dc42a875919710bf99e36b67e87/tests/PinnedImageTest.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #70
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/e6f75058404e0b3793ba365a72b9971bc32b3805
commit e6f75058404e0b3793ba365a72b9971bc32b3805
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Mar 02 19:27:11 2023
Enforce IWYU on ImageGenerator
Client CLs:
- https://crrev.com/c/4303437
- https://github.com/flutter/engine/pull/40026
Change-Id: Idcc4419e783130697ffcb6e9dff3b0f4ea2a08d0
Bug: skia:13983, skia:13052
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/651420
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/e6f75058404e0b3793ba365a72b9971bc32b3805/include/core/SkImageGenerator.h
[modify] https://crrev.com/e6f75058404e0b3793ba365a72b9971bc32b3805/src/core/SkImageGenerator.cpp
[modify] https://crrev.com/e6f75058404e0b3793ba365a72b9971bc32b3805/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/e6f75058404e0b3793ba365a72b9971bc32b3805/tests/GrAHardwareBufferTest.cpp
[modify] https://crrev.com/e6f75058404e0b3793ba365a72b9971bc32b3805/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/e6f75058404e0b3793ba365a72b9971bc32b3805/tools/gpu/YUVUtils.cpp
https://skia.googlesource.com/skia/+/e6f75058404e0b3793ba365a72b9971bc32b3805
commit e6f75058404e0b3793ba365a72b9971bc32b3805
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Mar 02 19:27:11 2023
Enforce IWYU on ImageGenerator
Client CLs:
- https://crrev.com/c/4303437
- https://github.com/flutter/engine/pull/40026
Change-Id: Idcc4419e783130697ffcb6e9dff3b0f4ea2a08d0
Bug: skia:13983, skia:13052
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/651420
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/e6f75058404e0b3793ba365a72b9971bc32b3805/include/core/SkImageGenerator.h
[modify] https://crrev.com/e6f75058404e0b3793ba365a72b9971bc32b3805/src/core/SkImageGenerator.cpp
[modify] https://crrev.com/e6f75058404e0b3793ba365a72b9971bc32b3805/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/e6f75058404e0b3793ba365a72b9971bc32b3805/tests/GrAHardwareBufferTest.cpp
[modify] https://crrev.com/e6f75058404e0b3793ba365a72b9971bc32b3805/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/e6f75058404e0b3793ba365a72b9971bc32b3805/tools/gpu/YUVUtils.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #71
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/321734e06f498271518c047a75e2f3716b51f645
commit 321734e06f498271518c047a75e2f3716b51f645
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Mar 14 14:46:56 2023
Rename SkImage::CompressionType -> SkTextureCompressionType
This appears to be in a few contexts outside of SkImages and this
will help with upcoming refactoring around the SkImage factories.
I inlined the one use of kCompressionTypeCount and decided to share
the value of kETC2_RGB8_UNORM with kETC1_RGB8 instead of
making a static constant variable.
go/skia-client-search showed no usage of the old
SkImage::CompressionType, only a few uses of SkImage::kETC1_SkCompressionType. Thus we only need an alias
for that static class variable until Chromium is migrated.
All other changes (the #include fixes) were a result of SkImage.h
not being included from GrTypesPriv.h. To assist with this,
I enforced IWYU on a few new files that gave me trouble as well as
having SkiaVulkan.h properly export the vulkan_core.h and friends
so IWYU doesn't try to make us directly include those.
Change-Id: I844372368478e3538fd4e8e01fdfefd988438e91
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/656237
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[add] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/core/SkTextureCompressionType.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/gn/core.gni
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrGpuResource.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mtl/GrMtlGpu.mm
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/private/gpu/ganesh/GrMockTypesPriv.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrBackendUtils.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/dawn/GrDawnCaps.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/d3d/GrD3DCaps.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mock/GrMockCaps.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/tools/viewer/MSKPSlide.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrDataUtils.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/gm/compressed_textures.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mock/GrMockCaps.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/dawn/GrDawnCaps.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/core/SkImage.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/core/SkCompressedDataUtils.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/vk/GrVkGpu.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrSurface.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/d3d/GrD3DGpu.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/tools/gpu/vk/VkYcbcrSamplerHelper.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/gm/exoticformats.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrGpu.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/core/SkGpuBlurUtils.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/gl/GrGLCaps.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/private/gpu/vk/SkiaVulkan.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrCaps.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/tools/gpu/ManagedBackendTexture.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrBackendUtils.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/d3d/GrD3DCaps.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/gl/GrGLCaps.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/tests/BackendAllocationTest.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/gpu/mock/GrMockTypes.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/gpu/GrDirectContext.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mtl/GrMtlCppUtil.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/gpu/GrContextThreadSafeProxy.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/vk/GrVkCaps.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mtl/GrMtlUtil.mm
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/graphite/Caps.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mock/GrMockSurfaceProxy.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mtl/GrMtlCaps.mm
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrProxyProvider.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/gl/GrGLGpu.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrProxyProvider.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/image/SkImage_Gpu.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/gm/bitmaptiled.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/core/SkCompressedDataUtils.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mock/GrMockGpu.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/vk/GrVkGpu.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/tests/GrSurfaceTest.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrContextThreadSafeProxy.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrGpu.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrDataUtils.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mock/GrMockTypes.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mtl/GrMtlUtil.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/tools/DDLTileHelper.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/gpu/GrBackendSurface.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mock/GrMockGpu.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/private/gpu/ganesh/GrTypesPriv.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrContext_Base.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrDirectContext.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrAttachment.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrCaps.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/tests/CompressedBackendAllocationTest.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/gm/bc1_transparency.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrSurface.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/vk/GrVkCaps.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mtl/GrMtlCaps.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/core/BUILD.bazel
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/RELEASE_NOTES.txt
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrBackendSurface.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/private/gpu/ganesh/GrContext_Base.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/public.bzl
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/gl/GrGLGpu.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mock/GrMockAttachment.h
https://skia.googlesource.com/skia/+/321734e06f498271518c047a75e2f3716b51f645
commit 321734e06f498271518c047a75e2f3716b51f645
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Mar 14 14:46:56 2023
Rename SkImage::CompressionType -> SkTextureCompressionType
This appears to be in a few contexts outside of SkImages and this
will help with upcoming refactoring around the SkImage factories.
I inlined the one use of kCompressionTypeCount and decided to share
the value of kETC2_RGB8_UNORM with kETC1_RGB8 instead of
making a static constant variable.
go/skia-client-search showed no usage of the old
SkImage::CompressionType, only a few uses of SkImage::kETC1_SkCompressionType. Thus we only need an alias
for that static class variable until Chromium is migrated.
All other changes (the #include fixes) were a result of SkImage.h
not being included from GrTypesPriv.h. To assist with this,
I enforced IWYU on a few new files that gave me trouble as well as
having SkiaVulkan.h properly export the vulkan_core.h and friends
so IWYU doesn't try to make us directly include those.
Change-Id: I844372368478e3538fd4e8e01fdfefd988438e91
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/656237
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[add] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/core/SkTextureCompressionType.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/gn/core.gni
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrGpuResource.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mtl/GrMtlGpu.mm
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/private/gpu/ganesh/GrMockTypesPriv.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrBackendUtils.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/dawn/GrDawnCaps.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/d3d/GrD3DCaps.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mock/GrMockCaps.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/tools/viewer/MSKPSlide.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrDataUtils.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/gm/compressed_textures.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mock/GrMockCaps.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/dawn/GrDawnCaps.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/core/SkImage.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/core/SkCompressedDataUtils.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/vk/GrVkGpu.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrSurface.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/d3d/GrD3DGpu.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/tools/gpu/vk/VkYcbcrSamplerHelper.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/gm/exoticformats.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrGpu.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/core/SkGpuBlurUtils.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/gl/GrGLCaps.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/private/gpu/vk/SkiaVulkan.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrCaps.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/tools/gpu/ManagedBackendTexture.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrBackendUtils.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/d3d/GrD3DCaps.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/gl/GrGLCaps.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/tests/BackendAllocationTest.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/gpu/mock/GrMockTypes.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/gpu/GrDirectContext.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mtl/GrMtlCppUtil.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/gpu/GrContextThreadSafeProxy.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/vk/GrVkCaps.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mtl/GrMtlUtil.mm
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/graphite/Caps.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mock/GrMockSurfaceProxy.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mtl/GrMtlCaps.mm
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrProxyProvider.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/gl/GrGLGpu.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrProxyProvider.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/image/SkImage_Gpu.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/gm/bitmaptiled.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/core/SkCompressedDataUtils.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mock/GrMockGpu.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/vk/GrVkGpu.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/tests/GrSurfaceTest.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrContextThreadSafeProxy.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrGpu.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrDataUtils.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mock/GrMockTypes.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mtl/GrMtlUtil.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/tools/DDLTileHelper.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/gpu/GrBackendSurface.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mock/GrMockGpu.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/private/gpu/ganesh/GrTypesPriv.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrContext_Base.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrDirectContext.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrAttachment.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrCaps.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/tests/CompressedBackendAllocationTest.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/gm/bc1_transparency.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrSurface.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/vk/GrVkCaps.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mtl/GrMtlCaps.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/core/BUILD.bazel
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/RELEASE_NOTES.txt
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/GrBackendSurface.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/include/private/gpu/ganesh/GrContext_Base.h
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/public.bzl
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/gl/GrGLGpu.cpp
[modify] https://crrev.com/321734e06f498271518c047a75e2f3716b51f645/src/gpu/ganesh/mock/GrMockAttachment.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #72
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/dc9dc6283bfb71ff667a7d32de1940693aefa922
commit dc9dc6283bfb71ff667a7d32de1940693aefa922
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Mar 14 16:54:01 2023
Rename SK_SUPPORT_GPU -> SK_GANESH_ENABLED
Also needed to cherry-pick https://github.com/google/skia/commit/a13d52c7aaa842ddc9cea34f779561152bbeff78
And remove CodeSize jobs from the CQ, since they will fail to build
on this branch
Many things were a mechanical
SK_SUPPORT_GPU -> defined(SK_GANESH_ENABLED)
SK_GPU_V1 -> defined(SK_GANESH_ENABLED)
except SkTypes.h, which includes a backwards-compatible
check for the old define, and a few other files to clean
up some #ifdefs, #includes, and comments.
Suggested Review Order
- SkTypes.h, noting that SK_GANESH_ENABLED is no longer
on by default.
- BUILD.gn.
- defines.bzl to see updates for Bazel version.
- All other files
Change-Id: I05a68f1b52395978b6192485194c937b04ac5ca5
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/647540
Reviewed-by: Greg Daniel <egdaniel@google.com>
(cherry picked from commit 40d29bfd33c33e97bb3c412c901fb7ecbede9594)
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/656240
Reviewed-by: Nolan Scobie <nscobie@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkPictureRecord.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/imagefilters/SkBlurImageFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/TriangulatingPathRendererTests.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/modules/canvaskit/compile_gm.sh
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/ToolUtils.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkImage.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/text/gpu/SubRunContainer.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/gn/skia.gni
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkPictureShader.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkDeferredDisplayListPriv.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkComposeShader.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/VkYcbcrSamplerTest.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/text/gpu/SubRunContainer.h
[delete] https://crrev.com/7a4aa03671d0afd1d07e20c364890e17312e18c5/src/gpu/dawn/BUILD.bazel
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/core/SkImage.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkRecordDraw.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkBlendModeBlender.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkPicture.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkPictureData.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/debugger/DebugCanvas.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkMaskFilterBase.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/ToolUtils.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkGpuBlurUtils.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkBlendModePriv.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/imagefilters/SkDisplacementMapImageFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkBlendModeBlender.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/sksl/SkSLPool.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkColorFilterShader.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/gradients/SkLinearGradient.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkRecords.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/SkShaderMaskFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkPromiseImageTexture.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkClipStack.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/gpu/GrContextThreadSafeProxy.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkBlenderBase.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/VkPriorityExtensionTest.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/utils/SkShadowUtils.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/imagefilters/SkMatrixConvolutionImageFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkCanvasPriv.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/infra/bots/tasks.json
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkMeshPriv.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkColorFilter_Matrix.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/gpu/ganesh/GrDrawingManager.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/imagefilters/SkBlendImageFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkStrikeSpec.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/text/gpu/TextBlob.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkStrikeSpec.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/imagefilters/SkMagnifierImageFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/config/SkUserConfig.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkGpuBlurUtils.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkPictureData.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/imagefilters/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/imagefilters/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/debugger/DebugCanvas.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/gpu/GrBackendSurface.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/gpu/graphite/Image_Base_Graphite.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkCoordClampShader.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkImage_Base.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/sksl/SkSLUtil.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/utils/SkShadowTessellator.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkColorFilterBase.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/gm/slug.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkCanvas.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkDevice.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/sksl/SkSLCompiler.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkSpecialImage.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/sksl/codegen/SkSLPipelineStageCodeGenerator.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/MultiPictureDocumentTest.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/viewer/RectanizerSlide.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/utils/SkNWayCanvas.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkPicturePlayback.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkImageShader.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkSurface_Gpu.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkTextBlob.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/viewer/AnimatedTextSlide.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkSpecialSurface.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkImageShader.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkLocalMatrixShader.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/public.bzl
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/gpu/graphite/Surface_Graphite.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/BazelTestRunner.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/text/gpu/TextBlobRedrawCoordinator.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/GrAHardwareBufferTest.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/gpu/ProxyUtils.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkImage_Lazy.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/core/SkTypes.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/VkProtectedContextTest.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/WrappedSurfaceCopyOnWriteTest.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkSurface_GpuMtl.mm
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/viewer/StrokeVerbSlide.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkSpecialSurface.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/SkTableColorFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkDevice.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkMesh.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkPictureRecord.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/sksl/SkSLMemoryPool.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkColorShader.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/viewer/Viewer.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkSurface.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkColorFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/android/SkAndroidFrameworkUtils.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/Test.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkYUVAPixmaps.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/skottie_ios_app/GrContextHolder.mm
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkStrike.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/defines.bzl
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/core/SkSurfaceCharacterization.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/android/SkAndroidFrameworkUtils.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/skottie_ios_app/main.mm
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkDeferredDisplayListRecorder.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/sksl/codegen/SkSLPipelineStageCodeGenerator.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/text/gpu/TextBlobRedrawCoordinator.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/gpu/graphite/SpecialImage_Graphite.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/imagefilters/SkLightingImageFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkMaskFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/gpu/graphite/Image_Base_Graphite.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/gpu/ProxyUtils.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkRecorder.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkDeferredDisplayList.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkChromeRemoteGlyphCache.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/bench/ColorFilterBench.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkLocalMatrixShader.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/core/SkImageGenerator.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkImageGenerator.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/text/gpu/GlyphVector.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkClipStack.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkSpecialImage.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/utils/SkGaussianColorFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/infra/bots/jobs.json
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/core/SkCanvas.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkSurface_Gpu.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkCanvasPriv.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/modules/canvaskit/BUILD.gn
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkShaderBase.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/viewer/ChineseFlingSlide.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/gradients/SkTwoPointConicalGradient.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkRecorder.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/sksl/SkSLUtil.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkXfermode.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkPerlinNoiseShader.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/core/SkPromiseImageTexture.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkImageFilter_Base.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkRuntimeEffect.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/BUILD.gn
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkSurfaceCharacterization.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/effects/SkRuntimeEffect.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkImageFilterTypes.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkRecordedDrawable.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkStrikeCache.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/gradients/SkLinearGradient.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/debugger/DrawCommand.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/gpu/graphite/Surface_Graphite.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/core/SkDeferredDisplayListRecorder.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkColorFilterShader.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkSurface_Base.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/fuzz/FuzzCanvas.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkModeColorFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/gradients/SkRadialGradient.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkShader.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/text/gpu/TextBlob.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/viewer/PathTessellatorsSlide.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkImageFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/gradients/SkSweepGradient.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/core/SkDeferredDisplayList.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/VkHardwareBufferTest.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/gpu/GrContextOptions.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/utils/SkNWayCanvas.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/modules/canvaskit/compile.sh
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/viewer/TextureUploadSlide.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/core/SkSurface.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkBlurMF.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/VkDrawableTest.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/RELEASE_NOTES.txt
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/imagefilters/SkAlphaThresholdImageFilter.cpp
https://skia.googlesource.com/skia/+/dc9dc6283bfb71ff667a7d32de1940693aefa922
commit dc9dc6283bfb71ff667a7d32de1940693aefa922
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Mar 14 16:54:01 2023
Rename SK_SUPPORT_GPU -> SK_GANESH_ENABLED
Also needed to cherry-pick https://github.com/google/skia/commit/a13d52c7aaa842ddc9cea34f779561152bbeff78
And remove CodeSize jobs from the CQ, since they will fail to build
on this branch
Many things were a mechanical
SK_SUPPORT_GPU -> defined(SK_GANESH_ENABLED)
SK_GPU_V1 -> defined(SK_GANESH_ENABLED)
except SkTypes.h, which includes a backwards-compatible
check for the old define, and a few other files to clean
up some #ifdefs, #includes, and comments.
Suggested Review Order
- SkTypes.h, noting that SK_GANESH_ENABLED is no longer
on by default.
- BUILD.gn.
- defines.bzl to see updates for Bazel version.
- All other files
Change-Id: I05a68f1b52395978b6192485194c937b04ac5ca5
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/647540
Reviewed-by: Greg Daniel <egdaniel@google.com>
(cherry picked from commit 40d29bfd33c33e97bb3c412c901fb7ecbede9594)
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/656240
Reviewed-by: Nolan Scobie <nscobie@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkPictureRecord.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/imagefilters/SkBlurImageFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/TriangulatingPathRendererTests.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/modules/canvaskit/compile_gm.sh
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/ToolUtils.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkImage.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/text/gpu/SubRunContainer.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/gn/skia.gni
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkPictureShader.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkDeferredDisplayListPriv.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkComposeShader.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/VkYcbcrSamplerTest.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/text/gpu/SubRunContainer.h
[delete] https://crrev.com/7a4aa03671d0afd1d07e20c364890e17312e18c5/src/gpu/dawn/BUILD.bazel
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/core/SkImage.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkRecordDraw.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkBlendModeBlender.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkPicture.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkPictureData.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/debugger/DebugCanvas.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkMaskFilterBase.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/ToolUtils.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkGpuBlurUtils.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkBlendModePriv.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/imagefilters/SkDisplacementMapImageFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkBlendModeBlender.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/sksl/SkSLPool.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkColorFilterShader.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/gradients/SkLinearGradient.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkRecords.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/SkShaderMaskFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkPromiseImageTexture.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkClipStack.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/gpu/GrContextThreadSafeProxy.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkBlenderBase.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/VkPriorityExtensionTest.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/utils/SkShadowUtils.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/imagefilters/SkMatrixConvolutionImageFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkCanvasPriv.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/infra/bots/tasks.json
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkMeshPriv.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkColorFilter_Matrix.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/gpu/ganesh/GrDrawingManager.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/imagefilters/SkBlendImageFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkStrikeSpec.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/text/gpu/TextBlob.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkStrikeSpec.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/imagefilters/SkMagnifierImageFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/config/SkUserConfig.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkGpuBlurUtils.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkPictureData.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/imagefilters/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/imagefilters/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/debugger/DebugCanvas.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/gpu/GrBackendSurface.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/gpu/graphite/Image_Base_Graphite.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkCoordClampShader.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkImage_Base.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/sksl/SkSLUtil.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/utils/SkShadowTessellator.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkColorFilterBase.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/gm/slug.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkCanvas.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkDevice.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/sksl/SkSLCompiler.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkSpecialImage.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/sksl/codegen/SkSLPipelineStageCodeGenerator.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/MultiPictureDocumentTest.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/viewer/RectanizerSlide.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/utils/SkNWayCanvas.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkPicturePlayback.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkImageShader.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkSurface_Gpu.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkTextBlob.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/viewer/AnimatedTextSlide.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkSpecialSurface.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkImageShader.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkLocalMatrixShader.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/public.bzl
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/gpu/graphite/Surface_Graphite.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/BazelTestRunner.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/text/gpu/TextBlobRedrawCoordinator.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/GrAHardwareBufferTest.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/gpu/ProxyUtils.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkImage_Lazy.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/core/SkTypes.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/VkProtectedContextTest.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/WrappedSurfaceCopyOnWriteTest.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkSurface_GpuMtl.mm
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/viewer/StrokeVerbSlide.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkSpecialSurface.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/SkTableColorFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkDevice.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkMesh.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkPictureRecord.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/sksl/SkSLMemoryPool.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkColorShader.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/viewer/Viewer.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkSurface.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkColorFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/android/SkAndroidFrameworkUtils.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/Test.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkYUVAPixmaps.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/skottie_ios_app/GrContextHolder.mm
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkStrike.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/defines.bzl
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/core/SkSurfaceCharacterization.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/android/SkAndroidFrameworkUtils.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/skottie_ios_app/main.mm
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkDeferredDisplayListRecorder.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/sksl/codegen/SkSLPipelineStageCodeGenerator.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/text/gpu/TextBlobRedrawCoordinator.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/gpu/graphite/SpecialImage_Graphite.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/imagefilters/SkLightingImageFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkMaskFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/gpu/graphite/Image_Base_Graphite.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/gpu/ProxyUtils.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkRecorder.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkDeferredDisplayList.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkChromeRemoteGlyphCache.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/bench/ColorFilterBench.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkLocalMatrixShader.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/core/SkImageGenerator.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkImageGenerator.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/text/gpu/GlyphVector.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkClipStack.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkSpecialImage.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/utils/SkGaussianColorFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/infra/bots/jobs.json
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/core/SkCanvas.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkSurface_Gpu.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkCanvasPriv.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/modules/canvaskit/BUILD.gn
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkShaderBase.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/viewer/ChineseFlingSlide.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/gradients/SkTwoPointConicalGradient.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkRecorder.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/sksl/SkSLUtil.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkXfermode.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkPerlinNoiseShader.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/core/SkPromiseImageTexture.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkImageFilter_Base.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkRuntimeEffect.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/BUILD.gn
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkSurfaceCharacterization.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/effects/SkRuntimeEffect.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkImageFilterTypes.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkRecordedDrawable.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkStrikeCache.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/gradients/SkLinearGradient.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/debugger/DrawCommand.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/gpu/graphite/Surface_Graphite.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/core/SkDeferredDisplayListRecorder.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkColorFilterShader.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/image/SkSurface_Base.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/fuzz/FuzzCanvas.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkModeColorFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/gradients/SkRadialGradient.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/SkShader.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/text/gpu/TextBlob.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/viewer/PathTessellatorsSlide.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkImageFilter.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/shaders/gradients/SkSweepGradient.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/core/SkDeferredDisplayList.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/VkHardwareBufferTest.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/gpu/GrContextOptions.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/utils/SkNWayCanvas.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/modules/canvaskit/compile.sh
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tools/viewer/TextureUploadSlide.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/include/core/SkSurface.h
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/core/SkBlurMF.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/tests/VkDrawableTest.cpp
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/RELEASE_NOTES.txt
[modify] https://crrev.com/dc9dc6283bfb71ff667a7d32de1940693aefa922/src/effects/imagefilters/SkAlphaThresholdImageFilter.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #73
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/9dcbea82236c37587cf48c6b1c9ec6499bc1704b
commit 9dcbea82236c37587cf48c6b1c9ec6499bc1704b
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Mar 15 17:17:16 2023
Update Chromium to use SkTextureCompressionType instead of SkImage constant
Follow-up to https://skia-review.googlesource.com/c/skia/+/656237
While I was fixing these files, I tidied up some #includes that
were missing/extra, as Skia is actively cleaning up our internal
includes and this will help reduce future churn.
Bug: skia:13983
Change-Id: I57c51e45266ea2171ff221f62b8fa99c01a80b30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4340209
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1117594}
[modify] https://crrev.com/9dcbea82236c37587cf48c6b1c9ec6499bc1704b/gpu/command_buffer/service/shared_image/wrapped_sk_image_backing.cc
[modify] https://crrev.com/9dcbea82236c37587cf48c6b1c9ec6499bc1704b/gpu/command_buffer/service/shared_image/wrapped_sk_image_backing_factory.cc
[modify] https://crrev.com/9dcbea82236c37587cf48c6b1c9ec6499bc1704b/gpu/command_buffer/service/skia_utils.cc
https://chromium.googlesource.com/chromium/src/+/9dcbea82236c37587cf48c6b1c9ec6499bc1704b
commit 9dcbea82236c37587cf48c6b1c9ec6499bc1704b
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Mar 15 17:17:16 2023
Update Chromium to use SkTextureCompressionType instead of SkImage constant
Follow-up to https://skia-review.googlesource.com/c/skia/+/656237
While I was fixing these files, I tidied up some #includes that
were missing/extra, as Skia is actively cleaning up our internal
includes and this will help reduce future churn.
Bug: skia:13983
Change-Id: I57c51e45266ea2171ff221f62b8fa99c01a80b30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4340209
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1117594}
[modify] https://crrev.com/9dcbea82236c37587cf48c6b1c9ec6499bc1704b/gpu/command_buffer/service/shared_image/wrapped_sk_image_backing.cc
[modify] https://crrev.com/9dcbea82236c37587cf48c6b1c9ec6499bc1704b/gpu/command_buffer/service/shared_image/wrapped_sk_image_backing_factory.cc
[modify] https://crrev.com/9dcbea82236c37587cf48c6b1c9ec6499bc1704b/gpu/command_buffer/service/skia_utils.cc
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #74
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/c947fef0b7b7bc0258e6778e5566e47ccb974705
commit c947fef0b7b7bc0258e6778e5566e47ccb974705
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Mar 15 17:31:16 2023
Fix includes as a result of removing SkImage
In https://skia-review.googlesource.com/c/skia/+/656879 we are
removing an unnecessary include that some files in Chromium
were transitively depending on. This CL fixes those dependencies
and a few others that I noticed were missing.
Bug: skia:13983
Change-Id: I2a4f54df1ba3613266716a1536d58146699a08b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4340411
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1117603}
[modify] https://crrev.com/c947fef0b7b7bc0258e6778e5566e47ccb974705/android_webview/browser/gfx/vulkan_gl_interop.cc
[modify] https://crrev.com/c947fef0b7b7bc0258e6778e5566e47ccb974705/android_webview/browser/gfx/vulkan_gl_interop.h
[modify] https://crrev.com/c947fef0b7b7bc0258e6778e5566e47ccb974705/gpu/skia_bindings/grcontext_for_gles2_interface.h
https://chromium.googlesource.com/chromium/src/+/c947fef0b7b7bc0258e6778e5566e47ccb974705
commit c947fef0b7b7bc0258e6778e5566e47ccb974705
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Mar 15 17:31:16 2023
Fix includes as a result of removing SkImage
In https://skia-review.googlesource.com/c/skia/+/656879 we are
removing an unnecessary include that some files in Chromium
were transitively depending on. This CL fixes those dependencies
and a few others that I noticed were missing.
Bug: skia:13983
Change-Id: I2a4f54df1ba3613266716a1536d58146699a08b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4340411
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1117603}
[modify] https://crrev.com/c947fef0b7b7bc0258e6778e5566e47ccb974705/android_webview/browser/gfx/vulkan_gl_interop.cc
[modify] https://crrev.com/c947fef0b7b7bc0258e6778e5566e47ccb974705/android_webview/browser/gfx/vulkan_gl_interop.h
[modify] https://crrev.com/c947fef0b7b7bc0258e6778e5566e47ccb974705/gpu/skia_bindings/grcontext_for_gles2_interface.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #75
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/22d81958032172454b575f7f6d767f8ccd6872bd
commit 22d81958032172454b575f7f6d767f8ccd6872bd
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Mar 14 17:07:09 2023
Remove legacy pin methods from SkImagePriv
Last usage removed in http://ag/21990732
Change-Id: Idb5684e5947f9d2e4f7e1b881d146b7b3172ed2d
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/656242
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/22d81958032172454b575f7f6d767f8ccd6872bd/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/22d81958032172454b575f7f6d767f8ccd6872bd/src/image/SkImage_Raster.h
[modify] https://crrev.com/22d81958032172454b575f7f6d767f8ccd6872bd/src/core/SkImagePriv.h
[modify] https://crrev.com/22d81958032172454b575f7f6d767f8ccd6872bd/tests/PinnedImageTest.cpp
https://skia.googlesource.com/skia/+/22d81958032172454b575f7f6d767f8ccd6872bd
commit 22d81958032172454b575f7f6d767f8ccd6872bd
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Mar 14 17:07:09 2023
Remove legacy pin methods from SkImagePriv
Last usage removed in http://ag/21990732
Change-Id: Idb5684e5947f9d2e4f7e1b881d146b7b3172ed2d
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/656242
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/22d81958032172454b575f7f6d767f8ccd6872bd/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/22d81958032172454b575f7f6d767f8ccd6872bd/src/image/SkImage_Raster.h
[modify] https://crrev.com/22d81958032172454b575f7f6d767f8ccd6872bd/src/core/SkImagePriv.h
[modify] https://crrev.com/22d81958032172454b575f7f6d767f8ccd6872bd/tests/PinnedImageTest.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #76
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/d21c3f85a2425d7d31ae1a258b920fccd53aed1c
commit d21c3f85a2425d7d31ae1a258b920fccd53aed1c
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Mar 17 22:04:20 2023
Introduce SkImages namespace; remove Ganesh GPU code from SkImage_Raster
This is the first of many CLs that aims to split the GPU and CPU
coupling to SkImage.
Step 1 was to move all SkImage::Make static functions (factories)
to their own namespace (SkImages), which allows us to define these
in different header files, which can be optionally exposed via the public API.
* SkImage::MakeBackendTextureFromSkImage -> SkImages::GetBackendTextureFromImage
* SkImage::MakeCrossContextFromPixmap -> SkImages::CrossContextTextureFromPixmap
* SkImage::MakeFromAdoptedTexture -> SkImages::AdoptTextureFrom
* SkImage::MakeFromBitmap -> SkImages::RasterFromBitmap
* SkImage::MakeFromCompressedTexture -> SkImages::TextureFromCompressedTexture
* SkImage::MakeFromEncoded -> SkImages::DeferredFromEncodedData
* SkImage::MakeFromGenerator -> SkImages::DeferredFromGenerator
* SkImage::MakeFromPicture -> SkImages::DeferredFromPicture
* SkImage::MakeFromRaster -> SkImages::RasterFromPixmap
* SkImage::MakeFromTexture -> SkImages::BorrowTextureFrom
* SkImage::MakeFromYUVAPixmaps -> SkImages::TextureFromYUVAPixmaps
* SkImage::MakeFromYUVATextures -> SkImages::TextureFromYUVATextures
* SkImage::MakePromiseTexture -> SkImages::PromiseTextureFrom
* SkImage::MakePromiseYUVATexture -> SkImages::PromiseTextureFromYUVA
* SkImage::MakeRasterCopy -> SkImages::RasterFromPixmapCopy
* SkImage::MakeRasterData -> SkImages::RasterFromData
* SkImage::MakeRasterFromCompressed -> SkImages::RasterFromCompressedTextureData
* SkImage::MakeTextureFromCompressed -> SkImages::TextureFromCompressedTextureData
We chose SkImages as the name because it aligns with existing
"effective namespaces" like `SkShaders` and `SkColorFilters`.
Step 2 was to move the logic requiring the Ganesh GPU backend out of
SkImage classes (starting with SkImage_Raster as an easy starting point)
and into files that live under src/gpu/ganesh. The graphite code
will come later. This involved making SkImage_Raster.h so ganesh
can see that subclass and exposing a few fields via getters/setters.
I don't think these steps can be easily split into two CLs (sorry).
I've left backwards compatible code so we can fix up clients
incrementally (and lock it in via the
SK_DISABLE_LEGACY_IMAGE_FACTORIES define).
I ran `git clang-format origin/main` after the renaming, and spot
checked the formatting; seemed fine to me.
Suggested review order:
- SkImage.h, SkImageGanesh.h, SkImageAndroid.h. Note that SkImage.h
has all the legacy factories guarded by an #ifdef at the bottom
for easier deletion in the future.
- src/image/SkImage_*Factories.cpp to see where the implementation
of these factories have been moved. We want them in separate files
to make the modular builds easier in the future.
- SkImage_Base.cpp, SkImage_Raster.h where things were moved out
of SkImage.cpp and SkImage_Raster.cpp for better organization.
- GrImageUtils.cpp/.h to see where the other methods of SkRaster
that used the GPU code were moved. I hope to follow suit with
other Images but for now just keep their onAsView etc methods
in place.
- Many other changes were mechanical to use the new namespace
and methods.
Change-Id: Ia345c2f0f1b1a2f65178a857bdd0d6118fee7e58
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/648297
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/crosscontextimage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/encode_platform.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/ToolUtils.h
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/GrImageUtils.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/image_shader.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_colorSpace.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_makeRasterImage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/ImageTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/utils/SkAnimCodecPlayer.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/GrCaps.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_CrossContextTextureFromPixmap.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/upscale_checkerboard.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/SerialProcsTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/dawn/GrDawnTexture.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/DDLTileHelper.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/GrPinnableImage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_Raster.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/GrTexture.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/pictureimagegenerator.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/ycbcrimage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/image.cpp
[rename] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_RasterFromData.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/JpegGainmapTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/flippity.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_RasterFactories.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/inlinepixmapconstructor.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/modules/jetski/src/Image.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/textblobmixedsizes.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/nearesthalfpixelimage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/encode_alpha_jpeg.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/ExtendedSkColorTypeTests.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_refColorSpace.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/GrMipMappedTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/GrTexture.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/core/SkSpecialImage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/GrCaps.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/bc1_transparency.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/pictureimagefilter.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/gpu_blur_utils.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/DeviceTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkRescaleAndReadPixels.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/BackendSurfaceMutableStateTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_refEncodedData.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/draw_pixel_array.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/d3d/GrD3DTexture.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/example3ps.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/gpu/ProxyUtils.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/GrAHardwareBufferTest.cpp
[delete] https://crrev.com/30456d261bd0869b1fefe64799490055fed95ba0/docs/examples/Image_MakeCrossContextFromPixmap.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/ImageIsOpaqueTest.cpp
[delete] https://crrev.com/30456d261bd0869b1fefe64799490055fed95ba0/docs/examples/Image_MakeFromEncoded.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/core/SkReadBuffer.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/vk/GrVkTexture.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/mtl/GrMtlTexture.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_peekPixels.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/core/SkDeferredDisplayListRecorder.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_GpuYUVA.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/EncodeTest.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/gpu/ganesh/SkImageGanesh.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/fuzz/oss_fuzz/FuzzImage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/fiddle/draw.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/rasterhandleallocator.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/core/SkImageGenerator.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/mesh.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/GLBackendSurfaceTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/gpu/BUILD.bazel
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/drawbitmaprect.cpp
[rename] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_GetBackendTextureFromImage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/bench/PDFBench.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/verylargebitmap.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/ImageGeneratorTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/wacky_yuv_formats.cpp
[rename] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_AdoptTextureFrom.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/PDFJpegEmbedTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/DMSAATest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_Gpu.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/graphite/Recorder.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/GrPipeline.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/graphite/Image_YUVA_Graphite.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/GainmapShaderTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Pixmap_const_SkImageInfo_const_star.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/PromiseImageTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/PinnedImageTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/rectangletexture.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/graphite/ImageProviderTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/Resources.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/VkHardwareBufferTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/core/SkDeferredDisplayList.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/viewer/ImGuiLayer.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_GpuYUVA.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/ImageFilterTest.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_BorrowTextureFrom_2.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/mirrortile.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_isValid.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/Device.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/image_pict.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/imagefiltersunpremul.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/SurfaceTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_makeNonTextureImage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_GpuBase.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/gl/GrGLTexture.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/DDLPromiseImageHelper.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/graphite/GraphiteResourceCacheTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/fiddle/all_examples.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/ImageFilterCacheTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/text/gpu/SubRunContainer.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/skbug_12212.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/imgcvt.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/VkYcbcrSamplerTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/SkSharingProc.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/core/SkImage.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/gpu/BackendTextureImageFactory.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/exoticformats.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/jpg_color_cube.cpp
[rename] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_DeferredFromPicture.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/gpu/ManagedBackendTexture.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/composeshader.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_FromBitmap.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/DecodeFile.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/GrDDLImageTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Surface_readPixels_2.cpp
[rename] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_RasterFromPixmapCopy.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/gpu/GrContextThreadSafeProxy.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/BUILD.bazel
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/mtl/GrMtlUtil.mm
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/imagemasksubset.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/gpu/ganesh/BUILD.bazel
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/VkBackendSurfaceTest.cpp
[rename] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_RasterFromPixmap.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/encode_color_types.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/simple_magnification.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/GifTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_encodeToData.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/gpu/GrBackendSurface.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_isAlphaOnly.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/graphite/Image_Base_Graphite.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_Base.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/core/SkStrikeCache.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/CachedDecodingPixelRefTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/readpixels.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/codec/SkPixmapUtils.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_makeTextureImage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/gl/GrGLTexture.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/GrTextureMipMapInvalidationTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/MultiPictureDocumentTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Alpha_Constants_b.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gn/gpu.gni
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/draw_pixel_array_nocopy.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/bench/GrMipmapBench.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/tilemodes.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/colorwheel.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_scalePixels.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/shaders/SkImageShader.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_DeferredFromGenerator.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/public.bzl
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_isLazyGenerated_a.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/encode.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Canvas_readPixels_a.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/graphitestart.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gn/core.gni
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/BUILD.bazel
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/graphite/Image_Graphite.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_GaneshFactories.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/core/SkMipmap.cpp
[delete] https://crrev.com/30456d261bd0869b1fefe64799490055fed95ba0/docs/examples/Image_MakeFromBitmap.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/gpu/YUVUtils.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/BUILD.bazel
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/viewer/Viewer.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/compressed_textures.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/DeferredDisplayListTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/BUILD.bazel
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/viewer/ImageSlide.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/android/SkImageAndroid.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/SkResourceCacheTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/draw_pixel_array_with_copy.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/skbug_633528.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/graphite/Image_Base_Graphite.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_BorrowTextureFrom.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/core/SkBitmap.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/UrlDataManager.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/Device_drawTexture.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/core/SkImageGenerator.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/mock/GrMockTexture.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_Base.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_LazyFactories.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/dm/DMSrcSink.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/BackendAllocationTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/gpu/mock/GrMockTypes.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_getBackendTexture.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/anisotropic.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/modules/skottie/src/SkottieTool.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/modules/canvaskit/canvaskit_bindings.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/ports/SkScalerContext_win_dw.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_isTextureBacked.cpp
[delete] https://crrev.com/30456d261bd0869b1fefe64799490055fed95ba0/docs/examples/Image_MakeFromTexture.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/dftext.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/experimental/ffmpeg/SkVideoDecoder.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/GrImageUtils.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/dftext_blob_persp.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/yuv420_odd_dim.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/fuzz/FuzzEncoders.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_AndroidFactories.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/asyncrescaleandread.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_GpuBase.h
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_DeferredFromEncodedData.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/fiddle/fiddle_main.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Alpha_Constants_a.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/core/SkDeferredDisplayListRecorder.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/fuzz/FuzzCanvas.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/GrDrawingManager.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/CompressedBackendAllocationTest.cpp
[delete] https://crrev.com/30456d261bd0869b1fefe64799490055fed95ba0/docs/examples/Image_MakeFromTexture_2.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_isLazyGenerated_b.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/encode_srgb.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/TextureBindingsResetTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/bazel/exporter_tool/main.go
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_encodeToData_2.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/RELEASE_NOTES.txt
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/fiddle/examples.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/SurfaceSemaphoreTest.cpp
[delete] https://crrev.com/30456d261bd0869b1fefe64799490055fed95ba0/docs/examples/Image_MakeFromGenerator.cpp
https://skia.googlesource.com/skia/+/d21c3f85a2425d7d31ae1a258b920fccd53aed1c
commit d21c3f85a2425d7d31ae1a258b920fccd53aed1c
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Mar 17 22:04:20 2023
Introduce SkImages namespace; remove Ganesh GPU code from SkImage_Raster
This is the first of many CLs that aims to split the GPU and CPU
coupling to SkImage.
Step 1 was to move all SkImage::Make static functions (factories)
to their own namespace (SkImages), which allows us to define these
in different header files, which can be optionally exposed via the public API.
* SkImage::MakeBackendTextureFromSkImage -> SkImages::GetBackendTextureFromImage
* SkImage::MakeCrossContextFromPixmap -> SkImages::CrossContextTextureFromPixmap
* SkImage::MakeFromAdoptedTexture -> SkImages::AdoptTextureFrom
* SkImage::MakeFromBitmap -> SkImages::RasterFromBitmap
* SkImage::MakeFromCompressedTexture -> SkImages::TextureFromCompressedTexture
* SkImage::MakeFromEncoded -> SkImages::DeferredFromEncodedData
* SkImage::MakeFromGenerator -> SkImages::DeferredFromGenerator
* SkImage::MakeFromPicture -> SkImages::DeferredFromPicture
* SkImage::MakeFromRaster -> SkImages::RasterFromPixmap
* SkImage::MakeFromTexture -> SkImages::BorrowTextureFrom
* SkImage::MakeFromYUVAPixmaps -> SkImages::TextureFromYUVAPixmaps
* SkImage::MakeFromYUVATextures -> SkImages::TextureFromYUVATextures
* SkImage::MakePromiseTexture -> SkImages::PromiseTextureFrom
* SkImage::MakePromiseYUVATexture -> SkImages::PromiseTextureFromYUVA
* SkImage::MakeRasterCopy -> SkImages::RasterFromPixmapCopy
* SkImage::MakeRasterData -> SkImages::RasterFromData
* SkImage::MakeRasterFromCompressed -> SkImages::RasterFromCompressedTextureData
* SkImage::MakeTextureFromCompressed -> SkImages::TextureFromCompressedTextureData
We chose SkImages as the name because it aligns with existing
"effective namespaces" like `SkShaders` and `SkColorFilters`.
Step 2 was to move the logic requiring the Ganesh GPU backend out of
SkImage classes (starting with SkImage_Raster as an easy starting point)
and into files that live under src/gpu/ganesh. The graphite code
will come later. This involved making SkImage_Raster.h so ganesh
can see that subclass and exposing a few fields via getters/setters.
I don't think these steps can be easily split into two CLs (sorry).
I've left backwards compatible code so we can fix up clients
incrementally (and lock it in via the
SK_DISABLE_LEGACY_IMAGE_FACTORIES define).
I ran `git clang-format origin/main` after the renaming, and spot
checked the formatting; seemed fine to me.
Suggested review order:
- SkImage.h, SkImageGanesh.h, SkImageAndroid.h. Note that SkImage.h
has all the legacy factories guarded by an #ifdef at the bottom
for easier deletion in the future.
- src/image/SkImage_*Factories.cpp to see where the implementation
of these factories have been moved. We want them in separate files
to make the modular builds easier in the future.
- SkImage_Base.cpp, SkImage_Raster.h where things were moved out
of SkImage.cpp and SkImage_Raster.cpp for better organization.
- GrImageUtils.cpp/.h to see where the other methods of SkRaster
that used the GPU code were moved. I hope to follow suit with
other Images but for now just keep their onAsView etc methods
in place.
- Many other changes were mechanical to use the new namespace
and methods.
Change-Id: Ia345c2f0f1b1a2f65178a857bdd0d6118fee7e58
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/648297
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/crosscontextimage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/encode_platform.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/ToolUtils.h
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/GrImageUtils.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/image_shader.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_colorSpace.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_makeRasterImage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/ImageTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/utils/SkAnimCodecPlayer.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/GrCaps.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_CrossContextTextureFromPixmap.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/upscale_checkerboard.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/SerialProcsTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/dawn/GrDawnTexture.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/DDLTileHelper.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/GrPinnableImage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_Raster.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/GrTexture.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/pictureimagegenerator.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/ycbcrimage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/image.cpp
[rename] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_RasterFromData.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/JpegGainmapTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/flippity.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_RasterFactories.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/inlinepixmapconstructor.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/modules/jetski/src/Image.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/textblobmixedsizes.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/nearesthalfpixelimage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/encode_alpha_jpeg.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/ExtendedSkColorTypeTests.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_refColorSpace.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/GrMipMappedTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/GrTexture.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/core/SkSpecialImage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/GrCaps.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/bc1_transparency.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/pictureimagefilter.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/gpu_blur_utils.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/DeviceTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkRescaleAndReadPixels.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/BackendSurfaceMutableStateTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_refEncodedData.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/draw_pixel_array.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/d3d/GrD3DTexture.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/example3ps.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/gpu/ProxyUtils.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/GrAHardwareBufferTest.cpp
[delete] https://crrev.com/30456d261bd0869b1fefe64799490055fed95ba0/docs/examples/Image_MakeCrossContextFromPixmap.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/ImageIsOpaqueTest.cpp
[delete] https://crrev.com/30456d261bd0869b1fefe64799490055fed95ba0/docs/examples/Image_MakeFromEncoded.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/core/SkReadBuffer.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/vk/GrVkTexture.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/mtl/GrMtlTexture.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_peekPixels.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/core/SkDeferredDisplayListRecorder.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_GpuYUVA.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/EncodeTest.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/gpu/ganesh/SkImageGanesh.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/fuzz/oss_fuzz/FuzzImage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/fiddle/draw.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/rasterhandleallocator.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/core/SkImageGenerator.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/mesh.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/GLBackendSurfaceTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/gpu/BUILD.bazel
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/drawbitmaprect.cpp
[rename] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_GetBackendTextureFromImage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/bench/PDFBench.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/verylargebitmap.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/ImageGeneratorTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/wacky_yuv_formats.cpp
[rename] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_AdoptTextureFrom.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/PDFJpegEmbedTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/DMSAATest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_Gpu.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/graphite/Recorder.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/GrPipeline.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/graphite/Image_YUVA_Graphite.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/GainmapShaderTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Pixmap_const_SkImageInfo_const_star.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/PromiseImageTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/PinnedImageTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/rectangletexture.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/graphite/ImageProviderTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/Resources.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/VkHardwareBufferTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/core/SkDeferredDisplayList.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/viewer/ImGuiLayer.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_GpuYUVA.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/ImageFilterTest.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_BorrowTextureFrom_2.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/mirrortile.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_isValid.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/Device.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/image_pict.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/imagefiltersunpremul.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/SurfaceTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_makeNonTextureImage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_GpuBase.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/gl/GrGLTexture.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/DDLPromiseImageHelper.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/graphite/GraphiteResourceCacheTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/fiddle/all_examples.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/ImageFilterCacheTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/text/gpu/SubRunContainer.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/skbug_12212.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/imgcvt.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/VkYcbcrSamplerTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/SkSharingProc.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/core/SkImage.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/gpu/BackendTextureImageFactory.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/exoticformats.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/jpg_color_cube.cpp
[rename] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_DeferredFromPicture.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/gpu/ManagedBackendTexture.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/composeshader.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_FromBitmap.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/DecodeFile.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/GrDDLImageTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Surface_readPixels_2.cpp
[rename] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_RasterFromPixmapCopy.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/gpu/GrContextThreadSafeProxy.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/BUILD.bazel
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/mtl/GrMtlUtil.mm
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/imagemasksubset.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/gpu/ganesh/BUILD.bazel
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/VkBackendSurfaceTest.cpp
[rename] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_RasterFromPixmap.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/encode_color_types.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/simple_magnification.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/GifTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_encodeToData.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/gpu/GrBackendSurface.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_isAlphaOnly.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/graphite/Image_Base_Graphite.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_Base.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/core/SkStrikeCache.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/CachedDecodingPixelRefTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/readpixels.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/codec/SkPixmapUtils.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_makeTextureImage.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/gl/GrGLTexture.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/GrTextureMipMapInvalidationTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/MultiPictureDocumentTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Alpha_Constants_b.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gn/gpu.gni
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/draw_pixel_array_nocopy.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/bench/GrMipmapBench.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/tilemodes.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/colorwheel.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_scalePixels.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/shaders/SkImageShader.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_DeferredFromGenerator.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/public.bzl
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_isLazyGenerated_a.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/encode.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Canvas_readPixels_a.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/graphitestart.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gn/core.gni
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/BUILD.bazel
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/graphite/Image_Graphite.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_GaneshFactories.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/core/SkMipmap.cpp
[delete] https://crrev.com/30456d261bd0869b1fefe64799490055fed95ba0/docs/examples/Image_MakeFromBitmap.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/gpu/YUVUtils.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/BUILD.bazel
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/viewer/Viewer.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/compressed_textures.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/DeferredDisplayListTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/BUILD.bazel
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/viewer/ImageSlide.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/android/SkImageAndroid.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/SkResourceCacheTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/draw_pixel_array_with_copy.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/skbug_633528.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/graphite/Image_Base_Graphite.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_BorrowTextureFrom.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/core/SkBitmap.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/UrlDataManager.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/Device_drawTexture.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/core/SkImageGenerator.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/mock/GrMockTexture.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_Base.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_LazyFactories.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/dm/DMSrcSink.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/BackendAllocationTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/gpu/mock/GrMockTypes.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_getBackendTexture.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/anisotropic.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/modules/skottie/src/SkottieTool.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/modules/canvaskit/canvaskit_bindings.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/ports/SkScalerContext_win_dw.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_isTextureBacked.cpp
[delete] https://crrev.com/30456d261bd0869b1fefe64799490055fed95ba0/docs/examples/Image_MakeFromTexture.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/dftext.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/experimental/ffmpeg/SkVideoDecoder.cpp
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/GrImageUtils.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/dftext_blob_persp.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/yuv420_odd_dim.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/fuzz/FuzzEncoders.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_AndroidFactories.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/asyncrescaleandread.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/image/SkImage_GpuBase.h
[add] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_DeferredFromEncodedData.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/fiddle/fiddle_main.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Alpha_Constants_a.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/include/core/SkDeferredDisplayListRecorder.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/fuzz/FuzzCanvas.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/src/gpu/ganesh/GrDrawingManager.h
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/CompressedBackendAllocationTest.cpp
[delete] https://crrev.com/30456d261bd0869b1fefe64799490055fed95ba0/docs/examples/Image_MakeFromTexture_2.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_isLazyGenerated_b.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/gm/encode_srgb.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/TextureBindingsResetTest.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/bazel/exporter_tool/main.go
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/docs/examples/Image_encodeToData_2.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/RELEASE_NOTES.txt
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tools/fiddle/examples.cpp
[modify] https://crrev.com/d21c3f85a2425d7d31ae1a258b920fccd53aed1c/tests/SurfaceSemaphoreTest.cpp
[delete] https://crrev.com/30456d261bd0869b1fefe64799490055fed95ba0/docs/examples/Image_MakeFromGenerator.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #77
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/5b2cbd717b555792602461e9d6f47b663dfd18c5
commit 5b2cbd717b555792602461e9d6f47b663dfd18c5
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Mar 20 10:50:43 2023
Revert "Introduce SkImages namespace; remove Ganesh GPU code from SkImage_Raster"
This reverts commit d21c3f85a2425d7d31ae1a258b920fccd53aed1c.
Reason for revert: Broke Chromium, Android, and G3
Original change's description:
https://skia.googlesource.com/skia/+/5b2cbd717b555792602461e9d6f47b663dfd18c5
commit 5b2cbd717b555792602461e9d6f47b663dfd18c5
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Mar 20 10:50:43 2023
Revert "Introduce SkImages namespace; remove Ganesh GPU code from SkImage_Raster"
This reverts commit d21c3f85a2425d7d31ae1a258b920fccd53aed1c.
Reason for revert: Broke Chromium, Android, and G3
Original change's description:
Bug: skia:13983
Change-Id: If4d0d5d6286d45e85c4ef2144b3b8d5312889a29
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/658556
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/crosscontextimage.cpp
[rename] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_MakeFromRaster.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/encode_platform.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/ToolUtils.h
[delete] https://crrev.com/f7e520c53ab022d81f91aae5a641bcb600c77167/src/gpu/ganesh/GrImageUtils.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/image/SkImage.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/image_shader.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_colorSpace.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_makeRasterImage.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/ImageTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/utils/SkAnimCodecPlayer.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/ganesh/GrCaps.cpp
[delete] https://crrev.com/f7e520c53ab022d81f91aae5a641bcb600c77167/docs/examples/Image_CrossContextTextureFromPixmap.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/upscale_checkerboard.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/SerialProcsTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/ganesh/dawn/GrDawnTexture.h
[rename] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_MakeRasterCopy.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/DDLTileHelper.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/ganesh/GrPinnableImage.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/image/SkImage_Raster.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/ganesh/GrTexture.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/pictureimagegenerator.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/image.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/ycbcrimage.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/JpegGainmapTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/flippity.cpp
[delete] https://crrev.com/f7e520c53ab022d81f91aae5a641bcb600c77167/src/image/SkImage_RasterFactories.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/inlinepixmapconstructor.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/modules/jetski/src/Image.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/textblobmixedsizes.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/nearesthalfpixelimage.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/encode_alpha_jpeg.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_refColorSpace.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/ExtendedSkColorTypeTests.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/GrMipMappedTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/ganesh/GrTexture.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/core/SkSpecialImage.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/ganesh/GrCaps.h
[rename] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_MakeBackendTextureFromSkImage.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/bc1_transparency.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/pictureimagefilter.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/gpu_blur_utils.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/image/SkRescaleAndReadPixels.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/DeviceTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/BackendSurfaceMutableStateTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_refEncodedData.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/draw_pixel_array.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/ganesh/d3d/GrD3DTexture.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/example3ps.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/GrAHardwareBufferTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/gpu/ProxyUtils.cpp
[add] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_MakeCrossContextFromPixmap.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/ImageIsOpaqueTest.cpp
[add] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_MakeFromEncoded.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/core/SkReadBuffer.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/ganesh/vk/GrVkTexture.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/ganesh/mtl/GrMtlTexture.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_peekPixels.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/core/SkDeferredDisplayListRecorder.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/image/SkImage_GpuYUVA.h
[delete] https://crrev.com/f7e520c53ab022d81f91aae5a641bcb600c77167/include/gpu/ganesh/SkImageGanesh.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/EncodeTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/fuzz/oss_fuzz/FuzzImage.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/fiddle/draw.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/rasterhandleallocator.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/include/core/SkImageGenerator.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/mesh.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/GLBackendSurfaceTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/drawbitmaprect.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/include/gpu/BUILD.bazel
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/bench/PDFBench.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/verylargebitmap.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/ImageGeneratorTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/wacky_yuv_formats.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/PDFJpegEmbedTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/DMSAATest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/image/SkImage_Gpu.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/graphite/Recorder.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/ganesh/GrPipeline.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/graphite/Image_YUVA_Graphite.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/GainmapShaderTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Pixmap_const_SkImageInfo_const_star.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/PinnedImageTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/PromiseImageTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/rectangletexture.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/graphite/ImageProviderTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/Resources.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/include/core/SkDeferredDisplayList.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/VkHardwareBufferTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/viewer/ImGuiLayer.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/image/SkImage_GpuYUVA.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/ImageFilterTest.cpp
[delete] https://crrev.com/f7e520c53ab022d81f91aae5a641bcb600c77167/docs/examples/Image_BorrowTextureFrom_2.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_isValid.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/mirrortile.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/ganesh/Device.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/image_pict.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/imagefiltersunpremul.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/SurfaceTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_makeNonTextureImage.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/image/SkImage_GpuBase.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/ganesh/gl/GrGLTexture.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/DDLPromiseImageHelper.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/graphite/GraphiteResourceCacheTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/fiddle/all_examples.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/text/gpu/SubRunContainer.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/ImageFilterCacheTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/skbug_12212.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/imgcvt.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/VkYcbcrSamplerTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/include/core/SkImage.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/SkSharingProc.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/gpu/BackendTextureImageFactory.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/exoticformats.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/jpg_color_cube.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/gpu/ManagedBackendTexture.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/composeshader.cpp
[delete] https://crrev.com/f7e520c53ab022d81f91aae5a641bcb600c77167/docs/examples/Image_FromBitmap.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/DecodeFile.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/GrDDLImageTest.cpp
[rename] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_MakeFromAdoptedTexture.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Surface_readPixels_2.cpp
[rename] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_MakeRasterData.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/include/gpu/GrContextThreadSafeProxy.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/ganesh/BUILD.bazel
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/ganesh/mtl/GrMtlUtil.mm
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/imagemasksubset.cpp
[delete] https://crrev.com/f7e520c53ab022d81f91aae5a641bcb600c77167/include/gpu/ganesh/BUILD.bazel
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/VkBackendSurfaceTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/encode_color_types.cpp
[rename] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_MakeFromPicture.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/simple_magnification.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/GifTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_encodeToData.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_isAlphaOnly.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/include/gpu/GrBackendSurface.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/graphite/Image_Base_Graphite.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/image/SkImage_Base.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/core/SkStrikeCache.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/CachedDecodingPixelRefTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/readpixels.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/codec/SkPixmapUtils.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_makeTextureImage.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/ganesh/gl/GrGLTexture.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/GrTextureMipMapInvalidationTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/MultiPictureDocumentTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Alpha_Constants_b.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gn/gpu.gni
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/bench/GrMipmapBench.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/draw_pixel_array_nocopy.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/tilemodes.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/colorwheel.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_scalePixels.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/shaders/SkImageShader.cpp
[delete] https://crrev.com/f7e520c53ab022d81f91aae5a641bcb600c77167/docs/examples/Image_DeferredFromGenerator.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/public.bzl
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_isLazyGenerated_a.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/encode.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Canvas_readPixels_a.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/graphitestart.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gn/core.gni
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/BUILD.bazel
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/graphite/Image_Graphite.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/core/SkMipmap.cpp
[delete] https://crrev.com/f7e520c53ab022d81f91aae5a641bcb600c77167/src/image/SkImage_GaneshFactories.cpp
[copy] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_MakeFromBitmap.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/gpu/YUVUtils.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/include/BUILD.bazel
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/compressed_textures.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/viewer/Viewer.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/DeferredDisplayListTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/image/BUILD.bazel
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/viewer/ImageSlide.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/include/android/SkImageAndroid.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/SkResourceCacheTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/draw_pixel_array_with_copy.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/skbug_633528.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/graphite/Image_Base_Graphite.cpp
[delete] https://crrev.com/f7e520c53ab022d81f91aae5a641bcb600c77167/docs/examples/Image_BorrowTextureFrom.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/core/SkBitmap.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/ganesh/Device_drawTexture.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/UrlDataManager.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/core/SkImageGenerator.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/ganesh/mock/GrMockTexture.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/dm/DMSrcSink.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/image/SkImage_Base.cpp
[delete] https://crrev.com/f7e520c53ab022d81f91aae5a641bcb600c77167/src/image/SkImage_LazyFactories.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/BackendAllocationTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_getBackendTexture.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/include/gpu/mock/GrMockTypes.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/anisotropic.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/modules/skottie/src/SkottieTool.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/modules/canvaskit/canvaskit_bindings.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/ports/SkScalerContext_win_dw.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_isTextureBacked.cpp
[add] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_MakeFromTexture.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/dftext.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/experimental/ffmpeg/SkVideoDecoder.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/dftext_blob_persp.cpp
[delete] https://crrev.com/f7e520c53ab022d81f91aae5a641bcb600c77167/src/gpu/ganesh/GrImageUtils.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/yuv420_odd_dim.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/fuzz/FuzzEncoders.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/image/SkImage_AndroidFactories.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/asyncrescaleandread.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/image/SkImage_GpuBase.h
[delete] https://crrev.com/f7e520c53ab022d81f91aae5a641bcb600c77167/docs/examples/Image_DeferredFromEncodedData.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/fiddle/fiddle_main.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Alpha_Constants_a.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/include/core/SkDeferredDisplayListRecorder.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/fuzz/FuzzCanvas.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/src/gpu/ganesh/GrDrawingManager.h
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/CompressedBackendAllocationTest.cpp
[add] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_MakeFromTexture_2.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_isLazyGenerated_b.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/gm/encode_srgb.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/TextureBindingsResetTest.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/bazel/exporter_tool/main.go
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_encodeToData_2.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/RELEASE_NOTES.txt
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tools/fiddle/examples.cpp
[add] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/docs/examples/Image_MakeFromGenerator.cpp
[modify] https://crrev.com/5b2cbd717b555792602461e9d6f47b663dfd18c5/tests/SurfaceSemaphoreTest.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #78
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5
commit ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Mar 20 20:31:01 2023
Reland "Introduce SkImages namespace; remove Ganesh GPU code from SkImage_Raster"
This is a reland of commit d21c3f85a2425d7d31ae1a258b920fccd53aed1c
- Removes a non-existent file from public.bzl
- Adds implementation of some missing backwards-compatible shims
- Re-adds an unintentionally deleted null check from gm/image.cpp
Original change's description:
https://skia.googlesource.com/skia/+/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5
commit ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Mar 20 20:31:01 2023
Reland "Introduce SkImages namespace; remove Ganesh GPU code from SkImage_Raster"
This is a reland of commit d21c3f85a2425d7d31ae1a258b920fccd53aed1c
- Removes a non-existent file from public.bzl
- Adds implementation of some missing backwards-compatible shims
- Re-adds an unintentionally deleted null check from gm/image.cpp
Original change's description:
Bug: skia:13983
Change-Id: I66bc3ad3197c59b2db971020d98227b39b098bf2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/658557
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/crosscontextimage.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/encode_platform.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/ToolUtils.h
[add] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/GrImageUtils.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/image/SkImage.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/image_shader.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_colorSpace.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_makeRasterImage.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/ImageTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/utils/SkAnimCodecPlayer.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/GrCaps.cpp
[add] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_CrossContextTextureFromPixmap.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/upscale_checkerboard.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/SerialProcsTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/dawn/GrDawnTexture.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/DDLTileHelper.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/GrPinnableImage.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/image/SkImage_Raster.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/GrTexture.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/pictureimagegenerator.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/image.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/ycbcrimage.cpp
[rename] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_RasterFromData.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/JpegGainmapTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/flippity.cpp
[add] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/image/SkImage_RasterFactories.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/inlinepixmapconstructor.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/modules/jetski/src/Image.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/textblobmixedsizes.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/nearesthalfpixelimage.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/encode_alpha_jpeg.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_refColorSpace.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/ExtendedSkColorTypeTests.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/GrMipMappedTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/GrTexture.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/core/SkSpecialImage.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/GrCaps.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/bc1_transparency.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/pictureimagefilter.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/gpu_blur_utils.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/image/SkRescaleAndReadPixels.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/DeviceTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/BackendSurfaceMutableStateTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_refEncodedData.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/draw_pixel_array.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/d3d/GrD3DTexture.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/example3ps.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/GrAHardwareBufferTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/gpu/ProxyUtils.cpp
[delete] https://crrev.com/c482ddadb04604708d97bc034c012fb9740d4ce9/docs/examples/Image_MakeCrossContextFromPixmap.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/ImageIsOpaqueTest.cpp
[delete] https://crrev.com/c482ddadb04604708d97bc034c012fb9740d4ce9/docs/examples/Image_MakeFromEncoded.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/core/SkReadBuffer.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/vk/GrVkTexture.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/mtl/GrMtlTexture.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_peekPixels.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/core/SkDeferredDisplayListRecorder.cpp
[add] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/include/gpu/ganesh/SkImageGanesh.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/EncodeTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/fuzz/oss_fuzz/FuzzImage.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/fiddle/draw.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/rasterhandleallocator.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/include/core/SkImageGenerator.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/mesh.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/GLBackendSurfaceTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/drawbitmaprect.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/include/gpu/BUILD.bazel
[rename] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_GetBackendTextureFromImage.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/bench/PDFBench.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/verylargebitmap.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/ImageGeneratorTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/wacky_yuv_formats.cpp
[rename] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_AdoptTextureFrom.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/PDFJpegEmbedTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/DMSAATest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/image/SkImage_Gpu.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/graphite/Recorder.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/GrPipeline.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/graphite/Image_YUVA_Graphite.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/GainmapShaderTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Pixmap_const_SkImageInfo_const_star.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/PinnedImageTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/PromiseImageTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/rectangletexture.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/graphite/ImageProviderTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/Resources.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/include/core/SkDeferredDisplayList.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/VkHardwareBufferTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/viewer/ImGuiLayer.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/image/SkImage_GpuYUVA.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/ImageFilterTest.cpp
[add] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_BorrowTextureFrom_2.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_isValid.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/mirrortile.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/Device.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/image_pict.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/imagefiltersunpremul.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/SurfaceTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_makeNonTextureImage.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/image/SkImage_GpuBase.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/gl/GrGLTexture.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/DDLPromiseImageHelper.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/graphite/GraphiteResourceCacheTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/fiddle/all_examples.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/text/gpu/SubRunContainer.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/ImageFilterCacheTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/skbug_12212.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/imgcvt.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/VkYcbcrSamplerTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/include/core/SkImage.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/SkSharingProc.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/gpu/BackendTextureImageFactory.cpp
[rename] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_DeferredFromPicture.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/exoticformats.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/jpg_color_cube.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/gpu/ManagedBackendTexture.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/composeshader.cpp
[add] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_FromBitmap.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/DecodeFile.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/GrDDLImageTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Surface_readPixels_2.cpp
[rename] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_RasterFromPixmapCopy.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/include/gpu/GrContextThreadSafeProxy.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/BUILD.bazel
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/mtl/GrMtlUtil.mm
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/imagemasksubset.cpp
[add] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/include/gpu/ganesh/BUILD.bazel
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/VkBackendSurfaceTest.cpp
[rename] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_RasterFromPixmap.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/encode_color_types.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/simple_magnification.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/GifTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_encodeToData.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_isAlphaOnly.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/include/gpu/GrBackendSurface.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/graphite/Image_Base_Graphite.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/image/SkImage_Base.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/core/SkStrikeCache.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/CachedDecodingPixelRefTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/readpixels.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/codec/SkPixmapUtils.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_makeTextureImage.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/gl/GrGLTexture.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/GrTextureMipMapInvalidationTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/MultiPictureDocumentTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Alpha_Constants_b.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gn/gpu.gni
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/bench/GrMipmapBench.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/draw_pixel_array_nocopy.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/tilemodes.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/colorwheel.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_scalePixels.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/shaders/SkImageShader.cpp
[add] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_DeferredFromGenerator.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/public.bzl
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_isLazyGenerated_a.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/encode.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Canvas_readPixels_a.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/graphitestart.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gn/core.gni
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/BUILD.bazel
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/graphite/Image_Graphite.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/core/SkMipmap.cpp
[add] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/image/SkImage_GaneshFactories.cpp
[delete] https://crrev.com/c482ddadb04604708d97bc034c012fb9740d4ce9/docs/examples/Image_MakeFromBitmap.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/gpu/YUVUtils.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/include/BUILD.bazel
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/compressed_textures.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/viewer/Viewer.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/DeferredDisplayListTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/image/BUILD.bazel
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/viewer/ImageSlide.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/include/android/SkImageAndroid.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/SkResourceCacheTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/draw_pixel_array_with_copy.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/skbug_633528.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/graphite/Image_Base_Graphite.cpp
[add] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_BorrowTextureFrom.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/core/SkBitmap.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/Device_drawTexture.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/UrlDataManager.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/core/SkImageGenerator.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/mock/GrMockTexture.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/dm/DMSrcSink.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/image/SkImage_Base.cpp
[add] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/image/SkImage_LazyFactories.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/BackendAllocationTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_getBackendTexture.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/include/gpu/mock/GrMockTypes.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/anisotropic.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/modules/skottie/src/SkottieTool.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/modules/canvaskit/canvaskit_bindings.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/ports/SkScalerContext_win_dw.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_isTextureBacked.cpp
[delete] https://crrev.com/c482ddadb04604708d97bc034c012fb9740d4ce9/docs/examples/Image_MakeFromTexture.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/dftext.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/experimental/ffmpeg/SkVideoDecoder.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/dftext_blob_persp.cpp
[add] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/GrImageUtils.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/yuv420_odd_dim.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/fuzz/FuzzEncoders.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/image/SkImage_AndroidFactories.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/asyncrescaleandread.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/image/SkImage_GpuBase.h
[add] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_DeferredFromEncodedData.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/fiddle/fiddle_main.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Alpha_Constants_a.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/include/core/SkDeferredDisplayListRecorder.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/fuzz/FuzzCanvas.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/src/gpu/ganesh/GrDrawingManager.h
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/CompressedBackendAllocationTest.cpp
[delete] https://crrev.com/c482ddadb04604708d97bc034c012fb9740d4ce9/docs/examples/Image_MakeFromTexture_2.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_isLazyGenerated_b.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/gm/encode_srgb.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/TextureBindingsResetTest.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/bazel/exporter_tool/main.go
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/docs/examples/Image_encodeToData_2.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/RELEASE_NOTES.txt
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tools/fiddle/examples.cpp
[delete] https://crrev.com/c482ddadb04604708d97bc034c012fb9740d4ce9/docs/examples/Image_MakeFromGenerator.cpp
[modify] https://crrev.com/ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5/tests/SurfaceSemaphoreTest.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #79
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/3e6bfdfea566b8368b10cd911499ae1bb09d3004
commit 3e6bfdfea566b8368b10cd911499ae1bb09d3004
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Mar 21 14:34:49 2023
Revert "Reland "Introduce SkImages namespace; remove Ganesh GPU code from SkImage_Raster""
This reverts commit ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5.
Reason for revert: Mysterious Android failures. Readback issues?
Original change's description:
https://skia.googlesource.com/skia/+/3e6bfdfea566b8368b10cd911499ae1bb09d3004
commit 3e6bfdfea566b8368b10cd911499ae1bb09d3004
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Mar 21 14:34:49 2023
Revert "Reland "Introduce SkImages namespace; remove Ganesh GPU code from SkImage_Raster""
This reverts commit ecbc27e5ed5d850d16c1d802fc77d0f0546bf3b5.
Reason for revert: Mysterious Android failures. Readback issues?
Original change's description:
Bug: skia:13983
Change-Id: Ib2c6c1990803d1a4e9b538c9c2d727187639fe1a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/659456
Owners-Override: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Nolan Scobie <nscobie@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Nolan Scobie <nscobie@google.com>
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/crosscontextimage.cpp
[rename] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_MakeFromRaster.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/encode_platform.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/ToolUtils.h
[delete] https://crrev.com/7277762ae1c0b92aa410d68fba86a4a346c93da8/src/gpu/ganesh/GrImageUtils.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/image/SkImage.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/image_shader.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_colorSpace.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_makeRasterImage.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/ImageTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/utils/SkAnimCodecPlayer.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/ganesh/GrCaps.cpp
[delete] https://crrev.com/7277762ae1c0b92aa410d68fba86a4a346c93da8/docs/examples/Image_CrossContextTextureFromPixmap.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/upscale_checkerboard.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/SerialProcsTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/ganesh/dawn/GrDawnTexture.h
[rename] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_MakeRasterCopy.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/DDLTileHelper.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/ganesh/GrPinnableImage.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/image/SkImage_Raster.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/ganesh/GrTexture.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/pictureimagegenerator.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/image.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/ycbcrimage.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/JpegGainmapTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/flippity.cpp
[delete] https://crrev.com/7277762ae1c0b92aa410d68fba86a4a346c93da8/src/image/SkImage_RasterFactories.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/inlinepixmapconstructor.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/modules/jetski/src/Image.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/textblobmixedsizes.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/nearesthalfpixelimage.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/encode_alpha_jpeg.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_refColorSpace.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/ExtendedSkColorTypeTests.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/GrMipMappedTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/ganesh/GrTexture.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/core/SkSpecialImage.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/ganesh/GrCaps.h
[rename] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_MakeBackendTextureFromSkImage.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/bc1_transparency.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/pictureimagefilter.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/gpu_blur_utils.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/image/SkRescaleAndReadPixels.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/DeviceTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/BackendSurfaceMutableStateTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_refEncodedData.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/draw_pixel_array.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/ganesh/d3d/GrD3DTexture.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/example3ps.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/GrAHardwareBufferTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/gpu/ProxyUtils.cpp
[add] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_MakeCrossContextFromPixmap.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/ImageIsOpaqueTest.cpp
[add] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_MakeFromEncoded.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/core/SkReadBuffer.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/ganesh/vk/GrVkTexture.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/ganesh/mtl/GrMtlTexture.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_peekPixels.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/core/SkDeferredDisplayListRecorder.cpp
[delete] https://crrev.com/7277762ae1c0b92aa410d68fba86a4a346c93da8/include/gpu/ganesh/SkImageGanesh.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/EncodeTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/fuzz/oss_fuzz/FuzzImage.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/fiddle/draw.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/rasterhandleallocator.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/include/core/SkImageGenerator.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/mesh.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/GLBackendSurfaceTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/drawbitmaprect.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/include/gpu/BUILD.bazel
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/bench/PDFBench.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/verylargebitmap.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/ImageGeneratorTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/wacky_yuv_formats.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/PDFJpegEmbedTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/DMSAATest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/image/SkImage_Gpu.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/graphite/Recorder.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/ganesh/GrPipeline.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/graphite/Image_YUVA_Graphite.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/GainmapShaderTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Pixmap_const_SkImageInfo_const_star.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/PinnedImageTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/PromiseImageTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/rectangletexture.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/graphite/ImageProviderTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/Resources.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/include/core/SkDeferredDisplayList.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/VkHardwareBufferTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/viewer/ImGuiLayer.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/image/SkImage_GpuYUVA.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/ImageFilterTest.cpp
[delete] https://crrev.com/7277762ae1c0b92aa410d68fba86a4a346c93da8/docs/examples/Image_BorrowTextureFrom_2.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_isValid.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/mirrortile.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/ganesh/Device.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/image_pict.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/imagefiltersunpremul.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/SurfaceTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_makeNonTextureImage.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/image/SkImage_GpuBase.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/ganesh/gl/GrGLTexture.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/DDLPromiseImageHelper.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/graphite/GraphiteResourceCacheTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/fiddle/all_examples.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/text/gpu/SubRunContainer.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/ImageFilterCacheTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/skbug_12212.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/imgcvt.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/VkYcbcrSamplerTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/include/core/SkImage.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/SkSharingProc.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/gpu/BackendTextureImageFactory.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/exoticformats.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/jpg_color_cube.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/gpu/ManagedBackendTexture.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/composeshader.cpp
[delete] https://crrev.com/7277762ae1c0b92aa410d68fba86a4a346c93da8/docs/examples/Image_FromBitmap.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/DecodeFile.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/GrDDLImageTest.cpp
[rename] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_MakeFromAdoptedTexture.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Surface_readPixels_2.cpp
[rename] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_MakeRasterData.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/ganesh/BUILD.bazel
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/ganesh/mtl/GrMtlUtil.mm
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/imagemasksubset.cpp
[delete] https://crrev.com/7277762ae1c0b92aa410d68fba86a4a346c93da8/include/gpu/ganesh/BUILD.bazel
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/VkBackendSurfaceTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/encode_color_types.cpp
[rename] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_MakeFromPicture.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/simple_magnification.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/GifTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_encodeToData.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_isAlphaOnly.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/include/gpu/GrBackendSurface.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/graphite/Image_Base_Graphite.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/image/SkImage_Base.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/core/SkStrikeCache.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/CachedDecodingPixelRefTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/readpixels.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/codec/SkPixmapUtils.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_makeTextureImage.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/ganesh/gl/GrGLTexture.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/GrTextureMipMapInvalidationTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/MultiPictureDocumentTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Alpha_Constants_b.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gn/gpu.gni
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/bench/GrMipmapBench.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/draw_pixel_array_nocopy.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/tilemodes.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/colorwheel.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_scalePixels.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/shaders/SkImageShader.cpp
[delete] https://crrev.com/7277762ae1c0b92aa410d68fba86a4a346c93da8/docs/examples/Image_DeferredFromGenerator.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/public.bzl
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_isLazyGenerated_a.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/encode.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Canvas_readPixels_a.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/graphitestart.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gn/core.gni
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/BUILD.bazel
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/graphite/Image_Graphite.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/core/SkMipmap.cpp
[delete] https://crrev.com/7277762ae1c0b92aa410d68fba86a4a346c93da8/src/image/SkImage_GaneshFactories.cpp
[copy] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_MakeFromBitmap.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/gpu/YUVUtils.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/include/BUILD.bazel
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/compressed_textures.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/viewer/Viewer.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/DeferredDisplayListTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/image/BUILD.bazel
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/viewer/ImageSlide.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/include/android/SkImageAndroid.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/SkResourceCacheTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/draw_pixel_array_with_copy.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/skbug_633528.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/graphite/Image_Base_Graphite.cpp
[delete] https://crrev.com/7277762ae1c0b92aa410d68fba86a4a346c93da8/docs/examples/Image_BorrowTextureFrom.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/core/SkBitmap.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/ganesh/Device_drawTexture.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/UrlDataManager.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/core/SkImageGenerator.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/ganesh/mock/GrMockTexture.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/dm/DMSrcSink.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/image/SkImage_Base.cpp
[delete] https://crrev.com/7277762ae1c0b92aa410d68fba86a4a346c93da8/src/image/SkImage_LazyFactories.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/BackendAllocationTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_getBackendTexture.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/include/gpu/mock/GrMockTypes.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/anisotropic.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/modules/skottie/src/SkottieTool.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/modules/canvaskit/canvaskit_bindings.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/ports/SkScalerContext_win_dw.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_isTextureBacked.cpp
[add] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_MakeFromTexture.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/dftext.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/experimental/ffmpeg/SkVideoDecoder.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/dftext_blob_persp.cpp
[delete] https://crrev.com/7277762ae1c0b92aa410d68fba86a4a346c93da8/src/gpu/ganesh/GrImageUtils.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/yuv420_odd_dim.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/fuzz/FuzzEncoders.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/image/SkImage_AndroidFactories.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/asyncrescaleandread.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/image/SkImage_GpuBase.h
[delete] https://crrev.com/7277762ae1c0b92aa410d68fba86a4a346c93da8/docs/examples/Image_DeferredFromEncodedData.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/fiddle/fiddle_main.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Alpha_Constants_a.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/include/core/SkDeferredDisplayListRecorder.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/fuzz/FuzzCanvas.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/src/gpu/ganesh/GrDrawingManager.h
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/CompressedBackendAllocationTest.cpp
[add] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_MakeFromTexture_2.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_isLazyGenerated_b.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/gm/encode_srgb.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/TextureBindingsResetTest.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/bazel/exporter_tool/main.go
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_encodeToData_2.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/RELEASE_NOTES.txt
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tools/fiddle/examples.cpp
[add] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/docs/examples/Image_MakeFromGenerator.cpp
[modify] https://crrev.com/3e6bfdfea566b8368b10cd911499ae1bb09d3004/tests/SurfaceSemaphoreTest.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #80
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/171ecb3b8a9e73445189f9f8dcc4f7586c22955e
commit 171ecb3b8a9e73445189f9f8dcc4f7586c22955e
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Mar 22 17:55:55 2023
[base] Move SkEndian.h to base
Change-Id: I37718d191e410c4650df2c24fad80040cd4f2f94
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/660377
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/ports/SkScalerContext_win_dw.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/gn/core.gni
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/core/SkFontStream.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/tests/FontNamesTest.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/core/BUILD.bazel
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_gasp.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_maxp_TT.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_name.cpp
[rename] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/base/SkEndian.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/core/SkICC.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_post.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_head.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/ports/SkTypeface_mac_ct.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/xps/SkXPSDevice.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/tests/FontHostTest.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_EBLC.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/codec/SkJpegMultiPicture.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/ports/SkFontMgr_win_dw.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_maxp_CFF.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/core/SkTypeface.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_fvar.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_glyf.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/tests/MathTest.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTableTypes.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/base/BUILD.bazel
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_OS_2_VA.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/codec/SkHeifCodec.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_name.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/tests/TypefaceTest.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_EBDT.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/core/SkBlurMask.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_OS_2_V2.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_hhea.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_hmtx.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_loca.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_OS_2_V1.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_OS_2_V4.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/ports/SkScalerContext_mac_ct.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_OS_2_V3.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTUtils.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/public.bzl
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkSFNTHeader.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_EBSC.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_OS_2_V0.h
https://skia.googlesource.com/skia/+/171ecb3b8a9e73445189f9f8dcc4f7586c22955e
commit 171ecb3b8a9e73445189f9f8dcc4f7586c22955e
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Mar 22 17:55:55 2023
[base] Move SkEndian.h to base
Change-Id: I37718d191e410c4650df2c24fad80040cd4f2f94
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/660377
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/ports/SkScalerContext_win_dw.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/gn/core.gni
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/core/SkFontStream.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/tests/FontNamesTest.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/core/BUILD.bazel
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_gasp.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_maxp_TT.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_name.cpp
[rename] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/base/SkEndian.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/core/SkICC.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_post.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_head.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/ports/SkTypeface_mac_ct.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/xps/SkXPSDevice.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/tests/FontHostTest.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_EBLC.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/codec/SkJpegMultiPicture.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/ports/SkFontMgr_win_dw.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_maxp_CFF.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/core/SkTypeface.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_fvar.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_glyf.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/tests/MathTest.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTableTypes.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/base/BUILD.bazel
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_OS_2_VA.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/codec/SkHeifCodec.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_name.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/tests/TypefaceTest.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_EBDT.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/core/SkBlurMask.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_OS_2_V2.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_hhea.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_hmtx.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_loca.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_OS_2_V1.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_OS_2_V4.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/ports/SkScalerContext_mac_ct.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_OS_2_V3.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTUtils.cpp
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/public.bzl
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkSFNTHeader.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_EBSC.h
[modify] https://crrev.com/171ecb3b8a9e73445189f9f8dcc4f7586c22955e/src/sfnt/SkOTTable_OS_2_V0.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #81
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/3b233921c78eb6b2bdaaad1525a8711c16a458af
commit 3b233921c78eb6b2bdaaad1525a8711c16a458af
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Mar 23 13:26:34 2023
Move some codec-related headers out of core
- `SkEncodedImageFormat.h` -> include/codec
- `SkPngChunkReader.h` -> include/codec
- `SkICC.h` -> include/encode
- `SkICC.cpp` -> src/encode
- `SkICCPriv.h` -> src/encode
Bug: skia:13983
Change-Id: I92d09820587804dc7e3abd3a88a7679e0b56b809
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/660381
Reviewed-by: Ben Wagner <bungeman@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[add] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/include/codec/SkEncodedImageFormat.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/gn/core.gni
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkPngCodec.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkWbmpCodec.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/core/BUILD.bazel
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/experimental/sktext/tests/FontResolvedText.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkWebpCodec.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/encode/SkImageEncoderPriv.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/android/SkAnimatedImage.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tests/CodecRecommendedTypeTest.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/gm/encode_platform.cpp
[add] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/include/encode/SkICC.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tools/ToolUtils.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/image/SkImage.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/gm/image_shader.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/experimental/sktext/tests/ShapedText.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tests/CodecTest.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/include/codec/SkAndroidCodec.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/pdf/SkPDFBitmap.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tests/ImageTest.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/include/core/SkICC.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkIcoCodec.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/gm/jpg_color_cube.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tests/EncodeTest.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkHeifCodec.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/encode/SkImageEncoder.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tools/HashAndEncode.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/encode/SkImageEncoderFns.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tests/AndroidCodecTest.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/client_utils/android/BitmapRegionDecoder.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkJpegCodec.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tools/get_images_from_skps.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkJpegxlCodec.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tests/ICCTest.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/BUILD.bazel
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tests/EncodedInfoTest.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkAvifCodec.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/modules/canvaskit/canvaskit_bindings.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkWuffsCodec.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkSampledCodec.cpp
[rename] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/include/codec/SkPngChunkReader.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tests/CodecPriv.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/gm/image.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/include/core/SkEncodedImageFormat.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/experimental/sktext/tests/UnicodeText.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/gm/encode_color_types.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/include/codec/BUILD.bazel
[rename] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/encode/SkICCPriv.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/include/encode/BUILD.bazel
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/experimental/sktext/tests/WrappedText.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/modules/skparagraph/tests/SkParagraphTest.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkBmpCodec.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tools/fonts/TestSVGTypeface.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/experimental/sktext/tests/SelectableText.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/xps/SkXPSDevice.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkPngCodec.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/fuzz/FuzzSkParagraph.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/gpu/ganesh/text/GrAtlasManager.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkAndroidCodec.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkRawCodec.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/gm/encode_srgb.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/encode/BUILD.bazel
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tools/rewrite_includes.py
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tests/TextBlobCacheTest.cpp
[rename] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/encode/SkICC.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/bazel/exporter_tool/main.go
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/include/core/BUILD.bazel
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/RELEASE_NOTES.txt
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/public.bzl
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/gm/encode.cpp
https://skia.googlesource.com/skia/+/3b233921c78eb6b2bdaaad1525a8711c16a458af
commit 3b233921c78eb6b2bdaaad1525a8711c16a458af
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Mar 23 13:26:34 2023
Move some codec-related headers out of core
- `SkEncodedImageFormat.h` -> include/codec
- `SkPngChunkReader.h` -> include/codec
- `SkICC.h` -> include/encode
- `SkICC.cpp` -> src/encode
- `SkICCPriv.h` -> src/encode
Bug: skia:13983
Change-Id: I92d09820587804dc7e3abd3a88a7679e0b56b809
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/660381
Reviewed-by: Ben Wagner <bungeman@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[add] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/include/codec/SkEncodedImageFormat.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/gn/core.gni
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkPngCodec.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkWbmpCodec.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/core/BUILD.bazel
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/experimental/sktext/tests/FontResolvedText.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkWebpCodec.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/encode/SkImageEncoderPriv.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/android/SkAnimatedImage.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tests/CodecRecommendedTypeTest.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/gm/encode_platform.cpp
[add] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/include/encode/SkICC.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tools/ToolUtils.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/image/SkImage.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/gm/image_shader.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/experimental/sktext/tests/ShapedText.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tests/CodecTest.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/include/codec/SkAndroidCodec.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/pdf/SkPDFBitmap.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tests/ImageTest.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/include/core/SkICC.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkIcoCodec.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/gm/jpg_color_cube.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tests/EncodeTest.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkHeifCodec.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/encode/SkImageEncoder.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tools/HashAndEncode.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/encode/SkImageEncoderFns.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tests/AndroidCodecTest.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/client_utils/android/BitmapRegionDecoder.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkJpegCodec.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tools/get_images_from_skps.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkJpegxlCodec.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tests/ICCTest.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/BUILD.bazel
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tests/EncodedInfoTest.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkAvifCodec.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/modules/canvaskit/canvaskit_bindings.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkWuffsCodec.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkSampledCodec.cpp
[rename] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/include/codec/SkPngChunkReader.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tests/CodecPriv.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/gm/image.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/include/core/SkEncodedImageFormat.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/experimental/sktext/tests/UnicodeText.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/gm/encode_color_types.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/include/codec/BUILD.bazel
[rename] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/encode/SkICCPriv.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/include/encode/BUILD.bazel
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/experimental/sktext/tests/WrappedText.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/modules/skparagraph/tests/SkParagraphTest.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkBmpCodec.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tools/fonts/TestSVGTypeface.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/experimental/sktext/tests/SelectableText.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/xps/SkXPSDevice.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkPngCodec.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/fuzz/FuzzSkParagraph.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/gpu/ganesh/text/GrAtlasManager.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkAndroidCodec.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/codec/SkRawCodec.h
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/gm/encode_srgb.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/encode/BUILD.bazel
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tools/rewrite_includes.py
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/tests/TextBlobCacheTest.cpp
[rename] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/src/encode/SkICC.cpp
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/bazel/exporter_tool/main.go
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/include/core/BUILD.bazel
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/RELEASE_NOTES.txt
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/public.bzl
[modify] https://crrev.com/3b233921c78eb6b2bdaaad1525a8711c16a458af/gm/encode.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #82
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/406dacdbf3405bfb6311925c13f322456aa7fea5
commit 406dacdbf3405bfb6311925c13f322456aa7fea5
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Mar 23 14:15:46 2023
Split SkRectMemcpy from SkConvertPixels
Several places (including SkImage_Raster) were including
SkConvertPixels.h only for SkRectMemcpy. This established
an unnecessary connection on Raster Pipeline (which currently
backs SkConvertPixels).
This removes those extra connections and enforces IWYU on
SkConvertPixels.
Change-Id: I84226a62e55e3d04341779445ec7e0cbfae52c57
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/660858
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/gpu/ganesh/vk/GrVkGpu.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/gn/core.gni
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/gpu/BufferWriter.h
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/gpu/ganesh/d3d/GrD3DGpu.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/core/SkConvertPixels.cpp
[add] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/base/SkRectMemcpy.h
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/gpu/graphite/Context.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/gpu/ganesh/mtl/GrMtlGpu.mm
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/base/BUILD.bazel
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/gm/lazytiling.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/core/SkConvertPixels.h
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/gpu/ganesh/GrDataUtils.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/core/SkYUVAPixmaps.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/gpu/ganesh/dawn/GrDawnGpu.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/tests/graphite/ReadWritePixelsGraphiteTest.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/public.bzl
https://skia.googlesource.com/skia/+/406dacdbf3405bfb6311925c13f322456aa7fea5
commit 406dacdbf3405bfb6311925c13f322456aa7fea5
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Mar 23 14:15:46 2023
Split SkRectMemcpy from SkConvertPixels
Several places (including SkImage_Raster) were including
SkConvertPixels.h only for SkRectMemcpy. This established
an unnecessary connection on Raster Pipeline (which currently
backs SkConvertPixels).
This removes those extra connections and enforces IWYU on
SkConvertPixels.
Change-Id: I84226a62e55e3d04341779445ec7e0cbfae52c57
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/660858
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/gpu/ganesh/vk/GrVkGpu.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/gn/core.gni
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/gpu/BufferWriter.h
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/gpu/ganesh/d3d/GrD3DGpu.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/core/SkConvertPixels.cpp
[add] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/base/SkRectMemcpy.h
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/gpu/graphite/Context.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/gpu/ganesh/mtl/GrMtlGpu.mm
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/base/BUILD.bazel
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/gm/lazytiling.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/core/SkConvertPixels.h
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/gpu/ganesh/GrDataUtils.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/core/SkYUVAPixmaps.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/src/gpu/ganesh/dawn/GrDawnGpu.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/tests/graphite/ReadWritePixelsGraphiteTest.cpp
[modify] https://crrev.com/406dacdbf3405bfb6311925c13f322456aa7fea5/public.bzl
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #83
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/77472bf8434041b6e8a239f93816088e680f479c
commit 77472bf8434041b6e8a239f93816088e680f479c
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Mar 24 11:11:17 2023
Reland "Reland "Introduce SkImages namespace; remove Ganesh GPU code from SkImage_Raster""
This reverts commit 3e6bfdfea566b8368b10cd911499ae1bb09d3004.
Reason for revert: Fixing Android
Original change's description:
https://skia.googlesource.com/skia/+/77472bf8434041b6e8a239f93816088e680f479c
commit 77472bf8434041b6e8a239f93816088e680f479c
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Mar 24 11:11:17 2023
Reland "Reland "Introduce SkImages namespace; remove Ganesh GPU code from SkImage_Raster""
This reverts commit 3e6bfdfea566b8368b10cd911499ae1bb09d3004.
Reason for revert: Fixing Android
Original change's description:
Bug: skia:13983
Change-Id: I355cbe3b624eb020e1bbd23738ae5249c234318f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/661059
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/crosscontextimage.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/encode_platform.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/ToolUtils.h
[add] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/GrImageUtils.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/image/SkImage.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/image_shader.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_colorSpace.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_makeRasterImage.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/ImageTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/utils/SkAnimCodecPlayer.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/GrCaps.cpp
[add] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_CrossContextTextureFromPixmap.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/upscale_checkerboard.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/SerialProcsTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/dawn/GrDawnTexture.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/DDLTileHelper.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/GrPinnableImage.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/image/SkImage_Raster.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/GrTexture.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/pictureimagegenerator.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/image.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/ycbcrimage.cpp
[rename] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_RasterFromData.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/JpegGainmapTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/flippity.cpp
[add] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/image/SkImage_RasterFactories.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/inlinepixmapconstructor.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/modules/jetski/src/Image.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/textblobmixedsizes.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/nearesthalfpixelimage.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/encode_alpha_jpeg.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/image/SkImage_Raster.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_refColorSpace.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/ExtendedSkColorTypeTests.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/GrMipMappedTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/GrTexture.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/core/SkSpecialImage.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/GrCaps.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/bc1_transparency.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/pictureimagefilter.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/gpu_blur_utils.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/image/SkRescaleAndReadPixels.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/DeviceTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/BackendSurfaceMutableStateTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_refEncodedData.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/draw_pixel_array.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/d3d/GrD3DTexture.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/example3ps.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/GrAHardwareBufferTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/gpu/ProxyUtils.cpp
[delete] https://crrev.com/e2e96a5cb161f74c172537d3cd6ef858a256cd94/docs/examples/Image_MakeCrossContextFromPixmap.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/ImageIsOpaqueTest.cpp
[delete] https://crrev.com/e2e96a5cb161f74c172537d3cd6ef858a256cd94/docs/examples/Image_MakeFromEncoded.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/core/SkReadBuffer.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/vk/GrVkTexture.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/mtl/GrMtlTexture.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_peekPixels.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/core/SkDeferredDisplayListRecorder.cpp
[add] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/include/gpu/ganesh/SkImageGanesh.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/EncodeTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/fuzz/oss_fuzz/FuzzImage.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/fiddle/draw.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/rasterhandleallocator.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/include/core/SkImageGenerator.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/mesh.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/GLBackendSurfaceTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/drawbitmaprect.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/include/gpu/BUILD.bazel
[rename] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_GetBackendTextureFromImage.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/bench/PDFBench.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/verylargebitmap.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/ImageGeneratorTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/wacky_yuv_formats.cpp
[rename] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_AdoptTextureFrom.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/PDFJpegEmbedTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/DMSAATest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/image/SkImage_Gpu.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/graphite/Recorder.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/GrPipeline.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/graphite/Image_YUVA_Graphite.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/GainmapShaderTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Pixmap_const_SkImageInfo_const_star.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/PinnedImageTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/PromiseImageTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/rectangletexture.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/graphite/ImageProviderTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/Resources.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/include/core/SkDeferredDisplayList.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/VkHardwareBufferTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/viewer/ImGuiLayer.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/image/SkImage_GpuYUVA.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/ImageFilterTest.cpp
[add] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_BorrowTextureFrom_2.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_isValid.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/mirrortile.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/Device.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/image_pict.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/imagefiltersunpremul.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/SurfaceTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_makeNonTextureImage.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/image/SkImage_GpuBase.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/gl/GrGLTexture.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/DDLPromiseImageHelper.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/graphite/GraphiteResourceCacheTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/fiddle/all_examples.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/text/gpu/SubRunContainer.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/ImageFilterCacheTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/skbug_12212.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/imgcvt.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/VkYcbcrSamplerTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/include/core/SkImage.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/SkSharingProc.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/gpu/BackendTextureImageFactory.cpp
[rename] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_DeferredFromPicture.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/exoticformats.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/jpg_color_cube.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/gpu/ManagedBackendTexture.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/composeshader.cpp
[add] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_FromBitmap.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/DecodeFile.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/GrDDLImageTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Surface_readPixels_2.cpp
[rename] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_RasterFromPixmapCopy.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/BUILD.bazel
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/mtl/GrMtlUtil.mm
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/imagemasksubset.cpp
[add] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/include/gpu/ganesh/BUILD.bazel
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/VkBackendSurfaceTest.cpp
[rename] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_RasterFromPixmap.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/encode_color_types.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/simple_magnification.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/GifTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_encodeToData.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_isAlphaOnly.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/include/gpu/GrBackendSurface.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/graphite/Image_Base_Graphite.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/image/SkImage_Base.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/core/SkStrikeCache.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/CachedDecodingPixelRefTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/readpixels.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/codec/SkPixmapUtils.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_makeTextureImage.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/gl/GrGLTexture.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/GrTextureMipMapInvalidationTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/MultiPictureDocumentTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Alpha_Constants_b.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gn/gpu.gni
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/bench/GrMipmapBench.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/draw_pixel_array_nocopy.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/tilemodes.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/colorwheel.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_scalePixels.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/shaders/SkImageShader.cpp
[add] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_DeferredFromGenerator.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/public.bzl
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_isLazyGenerated_a.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/encode.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Canvas_readPixels_a.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/graphitestart.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gn/core.gni
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/graphite/Image_Graphite.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/core/SkMipmap.cpp
[add] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/image/SkImage_GaneshFactories.cpp
[delete] https://crrev.com/e2e96a5cb161f74c172537d3cd6ef858a256cd94/docs/examples/Image_MakeFromBitmap.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/gpu/YUVUtils.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/include/BUILD.bazel
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/compressed_textures.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/viewer/Viewer.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/DeferredDisplayListTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/image/BUILD.bazel
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/viewer/ImageSlide.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/include/android/SkImageAndroid.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/SkResourceCacheTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/draw_pixel_array_with_copy.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/skbug_633528.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/graphite/Image_Base_Graphite.cpp
[add] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_BorrowTextureFrom.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/core/SkBitmap.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/Device_drawTexture.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/UrlDataManager.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/core/SkImageGenerator.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/mock/GrMockTexture.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/dm/DMSrcSink.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/image/SkImage_Base.cpp
[add] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/image/SkImage_LazyFactories.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/BackendAllocationTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_getBackendTexture.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/include/gpu/mock/GrMockTypes.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/anisotropic.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/modules/skottie/src/SkottieTool.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/modules/canvaskit/canvaskit_bindings.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/ports/SkScalerContext_win_dw.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_isTextureBacked.cpp
[delete] https://crrev.com/e2e96a5cb161f74c172537d3cd6ef858a256cd94/docs/examples/Image_MakeFromTexture.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/dftext.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/experimental/ffmpeg/SkVideoDecoder.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/dftext_blob_persp.cpp
[add] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/GrImageUtils.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/yuv420_odd_dim.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/fuzz/FuzzEncoders.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/image/SkImage_AndroidFactories.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/asyncrescaleandread.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/image/SkImage_GpuBase.h
[add] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_DeferredFromEncodedData.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/fiddle/fiddle_main.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Alpha_Constants_a.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/include/core/SkDeferredDisplayListRecorder.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/fuzz/FuzzCanvas.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/src/gpu/ganesh/GrDrawingManager.h
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/CompressedBackendAllocationTest.cpp
[delete] https://crrev.com/e2e96a5cb161f74c172537d3cd6ef858a256cd94/docs/examples/Image_MakeFromTexture_2.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_isLazyGenerated_b.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/gm/encode_srgb.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/TextureBindingsResetTest.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/bazel/exporter_tool/main.go
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/docs/examples/Image_encodeToData_2.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/RELEASE_NOTES.txt
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tools/fiddle/examples.cpp
[delete] https://crrev.com/e2e96a5cb161f74c172537d3cd6ef858a256cd94/docs/examples/Image_MakeFromGenerator.cpp
[modify] https://crrev.com/77472bf8434041b6e8a239f93816088e680f479c/tests/SurfaceSemaphoreTest.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #84
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/35abb3d4d0bdfd935622a16a6e31021c991f0c0e
commit 35abb3d4d0bdfd935622a16a6e31021c991f0c0e
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Mar 24 20:43:03 2023
Use SkImage factory methods from SkImages namespace
This new namespace will be added in https://skia-review.googlesource.com/c/skia/+/648297
This CL should be landed after that change rolls into
Chrome.
Bug: skia:13983
Change-Id: Idc71962cbd6534d640f5d66c2477b776d5ba149e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4348201
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1121911}
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/tiles/software_image_decode_cache_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/test/skia_common.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/gr_cache_controller_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/scoped_raster_flags_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/shared_image/iosurface_image_backing_factory_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/paint_filter.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/chromeos/utils/pdf_conversion.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/media/renderers/video_frame_rgba_to_yuva_converter.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/media/base/video_util.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/extensions/common/image_util.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/content/browser/android/synchronous_compositor_host.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/modules/webcodecs/image_decoder_core.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/shared_image/wrapped_sk_image_backing_factory_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/copy_shared_image_helper.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/mailbox_texture_backing.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/deferred_image_decoder_test_wo_platform.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/shared_image/external_vk_image_backing_factory_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/tiles/software_image_decode_cache_perftest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/components/viz/test/fake_skia_output_surface.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/components/viz/service/display/display_resource_provider_software.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/paint_shader_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/image_data_buffer.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/chrome/browser/ash/app_list/app_list_sort_browsertest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/shared_image/d3d_image_backing_factory_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/media/renderers/video_frame_yuv_mailboxes_holder.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/chrome/browser/ash/extensions/file_manager/private_api_thumbnail.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/components/paint_preview/common/serialized_recording_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/components/viz/service/display_embedder/skia_output_surface_impl.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/components/paint_preview/renderer/paint_preview_recorder_utils_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/image_transfer_cache_entry.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge_test.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/static_bitmap_image.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/tiles/software_image_decode_cache_utils.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/shared_image/test_utils.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/core/messaging/blink_transferable_message.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/device/vr/android/arcore/arcore_impl.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/core/inspector/inspector_audits_agent.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/skia_utils.h
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/paint_op_reader.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/core/page/drag_image_test.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/discardable_image_map_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/image-decoders/image_frame.h
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/android_webview/browser/gfx/vulkan_gl_interop.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/paint_op_writer.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/modules/webgpu/gpu_canvas_context.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/gpu/webgl_image_conversion.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/media/renderers/paint_canvas_video_renderer.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/raster/playback_image_provider_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/modules/accessibility/ax_node_object.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/pdf/pdfium/pdfium_page_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/components/paint_preview/renderer/paint_preview_recorder_utils.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/tiles/gpu_image_decode_cache_perftest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/image-decoders/image_frame.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/modules/mediacapturefromelement/canvas_capture_handler_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/shared_image/egl_image_backing_factory_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/filters/paint_filter_builder.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/components/viz/common/gpu/context_cache_controller_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context_base.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/image_transfer_cache_entry_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/core/frame/child_frame_compositing_helper.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/paint_shader.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/shared_image/shared_image_representation.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/components/viz/service/display/software_renderer.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/paint_image.cc
https://chromium.googlesource.com/chromium/src/+/35abb3d4d0bdfd935622a16a6e31021c991f0c0e
commit 35abb3d4d0bdfd935622a16a6e31021c991f0c0e
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Mar 24 20:43:03 2023
Use SkImage factory methods from SkImages namespace
This new namespace will be added in https://skia-review.googlesource.com/c/skia/+/648297
This CL should be landed after that change rolls into
Chrome.
Bug: skia:13983
Change-Id: Idc71962cbd6534d640f5d66c2477b776d5ba149e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4348201
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1121911}
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/tiles/software_image_decode_cache_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/test/skia_common.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/gr_cache_controller_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/scoped_raster_flags_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/shared_image/iosurface_image_backing_factory_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/paint_filter.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/chromeos/utils/pdf_conversion.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/media/renderers/video_frame_rgba_to_yuva_converter.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/media/base/video_util.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/extensions/common/image_util.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/content/browser/android/synchronous_compositor_host.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/modules/webcodecs/image_decoder_core.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/shared_image/wrapped_sk_image_backing_factory_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/copy_shared_image_helper.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/mailbox_texture_backing.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/deferred_image_decoder_test_wo_platform.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/shared_image/external_vk_image_backing_factory_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/tiles/software_image_decode_cache_perftest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/components/viz/test/fake_skia_output_surface.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/components/viz/service/display/display_resource_provider_software.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/paint_shader_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/image_data_buffer.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/chrome/browser/ash/app_list/app_list_sort_browsertest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/shared_image/d3d_image_backing_factory_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/media/renderers/video_frame_yuv_mailboxes_holder.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/chrome/browser/ash/extensions/file_manager/private_api_thumbnail.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/components/paint_preview/common/serialized_recording_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/components/viz/service/display_embedder/skia_output_surface_impl.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/components/paint_preview/renderer/paint_preview_recorder_utils_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/image_transfer_cache_entry.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge_test.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/static_bitmap_image.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/tiles/software_image_decode_cache_utils.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/shared_image/test_utils.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/core/messaging/blink_transferable_message.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/device/vr/android/arcore/arcore_impl.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/core/inspector/inspector_audits_agent.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/skia_utils.h
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/paint_op_reader.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/core/page/drag_image_test.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/discardable_image_map_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/image-decoders/image_frame.h
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/android_webview/browser/gfx/vulkan_gl_interop.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/paint_op_writer.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/modules/webgpu/gpu_canvas_context.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/gpu/webgl_image_conversion.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/media/renderers/paint_canvas_video_renderer.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/raster/playback_image_provider_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/modules/accessibility/ax_node_object.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/pdf/pdfium/pdfium_page_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/components/paint_preview/renderer/paint_preview_recorder_utils.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/tiles/gpu_image_decode_cache_perftest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/image-decoders/image_frame.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/modules/mediacapturefromelement/canvas_capture_handler_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/shared_image/egl_image_backing_factory_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/filters/paint_filter_builder.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/components/viz/common/gpu/context_cache_controller_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context_base.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/image_transfer_cache_entry_unittest.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/core/frame/child_frame_compositing_helper.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/paint_shader.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/gpu/command_buffer/service/shared_image/shared_image_representation.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/components/viz/service/display/software_renderer.cc
[modify] https://crrev.com/35abb3d4d0bdfd935622a16a6e31021c991f0c0e/cc/paint/paint_image.cc
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #85
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/bf174bc0b0840342619a88b41a056b725236715e
commit bf174bc0b0840342619a88b41a056b725236715e
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Mar 27 15:24:20 2023
Rename Ganesh-based SkImage and SkSurface and relocate to src/gpu/...
This will make it easier to partition the Ganesh backend and
make things more modular.
FYI: This will require a manual G3 roll due to the renamed
targets used by the vulkan build.
Change-Id: I0af38e5b3b5ab65ac5d58fa454fe754f06b1601a
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/661458
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/gm/image_pict.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tools/gpu/ProxyUtils.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tests/SurfaceTest.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/surface/SkSurface_Ganesh.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tools/DDLPromiseImageHelper.cpp
[add] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/BUILD.bazel
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/gm/compressed_textures.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/SkImage_GaneshBase.h
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/GrImageUtils.h
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/image/BUILD.bazel
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tools/gpu/GrTest.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/include/core/SkSurfaceCharacterization.h
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/vk/GrVkGpu.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tests/ImageTest.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/core/SkDeferredDisplayListRecorder.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/gm/exoticformats.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/SkImage_Ganesh.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/Device_drawTexture.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/GrPinnableImage.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/include/core/SkCanvas.h
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/BUILD.bazel
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/SkImage_GaneshYUVA.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/surface/SkSurface_GaneshMtl.mm
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tools/DDLTileHelper.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/BUILD.bazel
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/gm/imagemasksubset.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tests/VkBackendSurfaceTest.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/Device_v1.h
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/SkImage_GaneshBase.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/surface/SkSurface_Ganesh.h
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/GrDrawingManager.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/SkImage_GaneshFactories.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/image/SkImage_AndroidFactories.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/gm/flippity.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/GrContextThreadSafeProxy.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/core/SkRuntimeEffect.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/image/SkImage_Base.h
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tests/PinnedImageTest.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/SkImage_Ganesh.h
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tests/GrMipMappedTest.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/SkImage_GaneshYUVA.h
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/core/SkSpecialImage.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/gn/gpu.gni
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/gm/bc1_transparency.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/GrImageUtils.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/gm/gpu_blur_utils.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tests/ImageFilterTest.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/bazel/exporter_tool/main.go
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/shaders/SkImageShader.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/public.bzl
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/GrDirectContextPriv.cpp
[add] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/surface/BUILD.bazel
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/Device.cpp
https://skia.googlesource.com/skia/+/bf174bc0b0840342619a88b41a056b725236715e
commit bf174bc0b0840342619a88b41a056b725236715e
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Mar 27 15:24:20 2023
Rename Ganesh-based SkImage and SkSurface and relocate to src/gpu/...
This will make it easier to partition the Ganesh backend and
make things more modular.
FYI: This will require a manual G3 roll due to the renamed
targets used by the vulkan build.
Change-Id: I0af38e5b3b5ab65ac5d58fa454fe754f06b1601a
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/661458
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/gm/image_pict.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tools/gpu/ProxyUtils.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tests/SurfaceTest.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/surface/SkSurface_Ganesh.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tools/DDLPromiseImageHelper.cpp
[add] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/BUILD.bazel
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/gm/compressed_textures.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/SkImage_GaneshBase.h
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/GrImageUtils.h
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/image/BUILD.bazel
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tools/gpu/GrTest.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/include/core/SkSurfaceCharacterization.h
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/vk/GrVkGpu.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tests/ImageTest.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/core/SkDeferredDisplayListRecorder.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/gm/exoticformats.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/SkImage_Ganesh.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/Device_drawTexture.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/GrPinnableImage.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/include/core/SkCanvas.h
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/BUILD.bazel
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/SkImage_GaneshYUVA.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/surface/SkSurface_GaneshMtl.mm
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tools/DDLTileHelper.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/BUILD.bazel
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/gm/imagemasksubset.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tests/VkBackendSurfaceTest.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/Device_v1.h
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/SkImage_GaneshBase.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/surface/SkSurface_Ganesh.h
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/GrDrawingManager.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/SkImage_GaneshFactories.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/image/SkImage_AndroidFactories.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/gm/flippity.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/GrContextThreadSafeProxy.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/core/SkRuntimeEffect.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/image/SkImage_Base.h
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tests/PinnedImageTest.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/SkImage_Ganesh.h
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tests/GrMipMappedTest.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/SkImage_GaneshYUVA.h
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/core/SkSpecialImage.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/gn/gpu.gni
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/gm/bc1_transparency.cpp
[rename] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/image/GrImageUtils.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/gm/gpu_blur_utils.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/tests/ImageFilterTest.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/bazel/exporter_tool/main.go
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/shaders/SkImageShader.cpp
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/public.bzl
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/GrDirectContextPriv.cpp
[add] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/surface/BUILD.bazel
[modify] https://crrev.com/bf174bc0b0840342619a88b41a056b725236715e/src/gpu/ganesh/Device.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #86
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/89ea350e87a8f1ecef317e40b6386a138bb8e7b0
commit 89ea350e87a8f1ecef317e40b6386a138bb8e7b0
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Mar 30 15:07:34 2023
Remove some GPU-specific methods from SkImage
The following methods have been moved to static functions defined
in //include/gpu/ganesh/SkImageGanesh.h
* getBackendTexture() -> SkImages::GetBackendTextureFromImage()
* makeTextureImage() -> SkImages::TextureFromImage()
* flush() -> GrDirectContext::flush()
* flushAndSubmit() -> GrDirectContext::flushAndSubmit()
Additionally, the "old" SkImages::GetBackendTextureFromImage()
has been renamed to SkImages::MakeBackendTextureFromImage() to
make it clear that this static method will upload a texture if
there is not already one where as the Get* version will just
return the existing one.
Bridge code remains until clients can be migrated off the methods.
Making these be functions will make it easier to decouple
the GPU backend logic from SkImage and SkImageBase.
Additionally, the following methods have been marked as virtual
to also accomplish this:
* isTextureBacked()
* textureSize()
* isValid()
* makeTextureImage (the graphite version)
In early versions of the CL (e.g. PS 2), I tried making all the
affected methods virtual, but this did not accomplish the separation
I wanted in a few places. For example makeTextureImage() could
not be easily virtualized, as raster images would need to include
the GPU backend code to upload themselves. Furthermore, flush()
was mostly a no-op but still needed to return a GPU type (I briefly
introduced SkSemaphoresSubmitted in include/core, but that felt
like the wrong solution. Finally, getBackendTexture, as originally
written, always needed to return a GrBackendTexture object, even
if it was not supported, requiring raster images to need some
GPU code.
Suggested Review Order
- RELEASE_NOTES.txt and SkImage.h to get an overview of the changes
- SkImageGanesh.h to see the new APIs. The biggest difference
is that GetExistingBackendTexture now takes in a GrBackendTexture*
and returns a bool, similar to GetBackendTextureFromImage.
- GrDirectContext.* to see where the flush code moved.
- SkImage_GaneshFactories.cpp to see where the other two methods
moved.
- SkImage_GaneshBase.h to see the flush API pushed down here
(from SkImage).
- SkImage_Ganesh* to see no functionality really changed, only
function renames.
- SkImage.cpp to see the bridge code.
- All other files in any order.
Change-Id: Icfb7604247cc0a117941355aaeb90af638e0e2d2
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/661676
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tools/sk_app/win/D3D12WindowContext_win.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/GrFinishedFlushTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/image/SkImage_Raster.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/bench/BulkRectBench.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/image/SkImage_Lazy.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/SurfaceTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/VkBackendSurfaceTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/ganesh/image/SkImage_GaneshBase.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/gm/image.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/ganesh/image/SkImage_GaneshFactories.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/gm/asyncrescaleandread.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/RepeatedClippedBlurTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tools/fiddle/all_examples.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/bench/ImageFilterDAGBench.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/image/SkImage.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/ImageFilterCacheTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/ganesh/image/SkImage_GaneshBase.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/gm/makecolorspace.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/graphite/Image_Base_Graphite.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/image/SkImage_Base.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/include/core/SkImage.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/TextureProxyTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/gm/imagefilters.cpp
[add] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/docs/examples/Image_MakeBackendTextureFromImage.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/ganesh/image/SkImage_Ganesh.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/ImageTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/gm/readpixels.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/ganesh/image/SkImage_GaneshYUVA.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tools/ToolUtils.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/include/gpu/ganesh/SkImageGanesh.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/ganesh/GrDirectContext.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/ganesh/image/SkImage_Ganesh.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/GrTextureMipMapInvalidationTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/graphite/Image_Base_Graphite.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/ganesh/image/GrPinnableImage.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/RELEASE_NOTES.md
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/dm/DMSrcSink.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/image/SkImage_Base.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/DeviceTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/ganesh/image/SkImage_GaneshYUVA.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/include/gpu/GrDirectContext.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/BackendSurfaceMutableStateTest.cpp
[delete] https://crrev.com/79f097ca7c57b77d96135aa89761c41dfb2a3bb7/docs/examples/Image_GetBackendTextureFromImage.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/SurfaceSemaphoreTest.cpp
https://skia.googlesource.com/skia/+/89ea350e87a8f1ecef317e40b6386a138bb8e7b0
commit 89ea350e87a8f1ecef317e40b6386a138bb8e7b0
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Mar 30 15:07:34 2023
Remove some GPU-specific methods from SkImage
The following methods have been moved to static functions defined
in //include/gpu/ganesh/SkImageGanesh.h
* getBackendTexture() -> SkImages::GetBackendTextureFromImage()
* makeTextureImage() -> SkImages::TextureFromImage()
* flush() -> GrDirectContext::flush()
* flushAndSubmit() -> GrDirectContext::flushAndSubmit()
Additionally, the "old" SkImages::GetBackendTextureFromImage()
has been renamed to SkImages::MakeBackendTextureFromImage() to
make it clear that this static method will upload a texture if
there is not already one where as the Get* version will just
return the existing one.
Bridge code remains until clients can be migrated off the methods.
Making these be functions will make it easier to decouple
the GPU backend logic from SkImage and SkImageBase.
Additionally, the following methods have been marked as virtual
to also accomplish this:
* isTextureBacked()
* textureSize()
* isValid()
* makeTextureImage (the graphite version)
In early versions of the CL (e.g. PS 2), I tried making all the
affected methods virtual, but this did not accomplish the separation
I wanted in a few places. For example makeTextureImage() could
not be easily virtualized, as raster images would need to include
the GPU backend code to upload themselves. Furthermore, flush()
was mostly a no-op but still needed to return a GPU type (I briefly
introduced SkSemaphoresSubmitted in include/core, but that felt
like the wrong solution. Finally, getBackendTexture, as originally
written, always needed to return a GrBackendTexture object, even
if it was not supported, requiring raster images to need some
GPU code.
Suggested Review Order
- RELEASE_NOTES.txt and SkImage.h to get an overview of the changes
- SkImageGanesh.h to see the new APIs. The biggest difference
is that GetExistingBackendTexture now takes in a GrBackendTexture*
and returns a bool, similar to GetBackendTextureFromImage.
- GrDirectContext.* to see where the flush code moved.
- SkImage_GaneshFactories.cpp to see where the other two methods
moved.
- SkImage_GaneshBase.h to see the flush API pushed down here
(from SkImage).
- SkImage_Ganesh* to see no functionality really changed, only
function renames.
- SkImage.cpp to see the bridge code.
- All other files in any order.
Change-Id: Icfb7604247cc0a117941355aaeb90af638e0e2d2
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/661676
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tools/sk_app/win/D3D12WindowContext_win.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/GrFinishedFlushTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/image/SkImage_Raster.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/bench/BulkRectBench.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/image/SkImage_Lazy.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/SurfaceTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/VkBackendSurfaceTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/ganesh/image/SkImage_GaneshBase.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/gm/image.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/ganesh/image/SkImage_GaneshFactories.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/gm/asyncrescaleandread.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/RepeatedClippedBlurTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tools/fiddle/all_examples.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/bench/ImageFilterDAGBench.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/image/SkImage.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/ImageFilterCacheTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/ganesh/image/SkImage_GaneshBase.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/gm/makecolorspace.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/graphite/Image_Base_Graphite.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/image/SkImage_Base.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/include/core/SkImage.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/TextureProxyTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/gm/imagefilters.cpp
[add] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/docs/examples/Image_MakeBackendTextureFromImage.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/ganesh/image/SkImage_Ganesh.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/ImageTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/gm/readpixels.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/ganesh/image/SkImage_GaneshYUVA.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tools/ToolUtils.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/include/gpu/ganesh/SkImageGanesh.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/ganesh/GrDirectContext.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/ganesh/image/SkImage_Ganesh.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/GrTextureMipMapInvalidationTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/graphite/Image_Base_Graphite.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/ganesh/image/GrPinnableImage.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/RELEASE_NOTES.md
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/dm/DMSrcSink.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/image/SkImage_Base.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/DeviceTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/src/gpu/ganesh/image/SkImage_GaneshYUVA.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/include/gpu/GrDirectContext.h
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/BackendSurfaceMutableStateTest.cpp
[delete] https://crrev.com/79f097ca7c57b77d96135aa89761c41dfb2a3bb7/docs/examples/Image_GetBackendTextureFromImage.cpp
[modify] https://crrev.com/89ea350e87a8f1ecef317e40b6386a138bb8e7b0/tests/SurfaceSemaphoreTest.cpp
kj...@google.com <kj...@google.com> #87
[Empty comment from Monorail migration]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #88
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/f6c1eefd46005871af541940ea36fc000fec5451
commit f6c1eefd46005871af541940ea36fc000fec5451
Author: Michael Ludwig <michaelludwig@google.com>
Date: Thu Mar 30 19:56:51 2023
Revert "Remove some GPU-specific methods from SkImage"
This reverts commit 89ea350e87a8f1ecef317e40b6386a138bb8e7b0.
Reason for revert: breaking chrome build around flush() ambiguity
Original change's description:
https://skia.googlesource.com/skia/+/f6c1eefd46005871af541940ea36fc000fec5451
commit f6c1eefd46005871af541940ea36fc000fec5451
Author: Michael Ludwig <michaelludwig@google.com>
Date: Thu Mar 30 19:56:51 2023
Revert "Remove some GPU-specific methods from SkImage"
This reverts commit 89ea350e87a8f1ecef317e40b6386a138bb8e7b0.
Reason for revert: breaking chrome build around flush() ambiguity
Original change's description:
Bug: skia:13983
Change-Id: I4e121ff477f2f4499ead51159aac9a82e4bae469
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/664180
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/tools/sk_app/win/D3D12WindowContext_win.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/tests/GrFinishedFlushTest.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/src/image/SkImage_Raster.h
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/bench/BulkRectBench.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/src/image/SkImage_Lazy.h
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/tests/SurfaceTest.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/tests/VkBackendSurfaceTest.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/src/gpu/ganesh/image/SkImage_GaneshBase.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/gm/image.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/src/gpu/ganesh/image/SkImage_GaneshFactories.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/gm/asyncrescaleandread.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/tests/RepeatedClippedBlurTest.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/tools/fiddle/all_examples.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/bench/ImageFilterDAGBench.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/src/image/SkImage.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/tests/ImageFilterCacheTest.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/src/gpu/ganesh/image/SkImage_GaneshBase.h
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/gm/makecolorspace.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/src/gpu/graphite/Image_Base_Graphite.h
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/src/image/SkImage_Base.h
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/include/core/SkImage.h
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/tests/TextureProxyTest.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/gm/imagefilters.cpp
[delete] https://crrev.com/bd06820e298ebe4b6107af4864b39b745ece806c/docs/examples/Image_MakeBackendTextureFromImage.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/src/gpu/ganesh/image/SkImage_Ganesh.h
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/tests/ImageTest.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/gm/readpixels.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/src/gpu/ganesh/image/SkImage_GaneshYUVA.h
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/tools/ToolUtils.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/include/gpu/ganesh/SkImageGanesh.h
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/src/gpu/ganesh/GrDirectContext.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/src/gpu/ganesh/image/SkImage_Ganesh.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/tests/GrTextureMipMapInvalidationTest.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/src/gpu/graphite/Image_Base_Graphite.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/src/gpu/ganesh/image/GrPinnableImage.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/RELEASE_NOTES.md
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/dm/DMSrcSink.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/src/image/SkImage_Base.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/tests/DeviceTest.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/src/gpu/ganesh/image/SkImage_GaneshYUVA.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/include/gpu/GrDirectContext.h
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/tests/BackendSurfaceMutableStateTest.cpp
[add] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/docs/examples/Image_GetBackendTextureFromImage.cpp
[modify] https://crrev.com/f6c1eefd46005871af541940ea36fc000fec5451/tests/SurfaceSemaphoreTest.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #89
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/79f6ec67cb060f4cb13a030cdaded2276f489226
commit 79f6ec67cb060f4cb13a030cdaded2276f489226
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Mar 31 15:01:36 2023
Fix use of GrDirectContext->flush and Skia includes
In http://review.skia.org/664477 we
introduce a new API to GrDirectContext that requires disambiguating
flushes. Additional changes change up #includes a bit and
would otherwise break Chrome in places that were not
including correctly.
Bug: skia:13983, skia:13052
Change-Id: Ia14c826d1a32f97e5f9c510d32532805a38fc16d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4387338
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1124723}
[modify] https://crrev.com/79f6ec67cb060f4cb13a030cdaded2276f489226/gpu/command_buffer/service/shared_image/external_vk_image_backing.cc
[modify] https://crrev.com/79f6ec67cb060f4cb13a030cdaded2276f489226/printing/common/metafile_utils.cc
[modify] https://crrev.com/79f6ec67cb060f4cb13a030cdaded2276f489226/components/paint_preview/common/serial_utils.cc
[modify] https://crrev.com/79f6ec67cb060f4cb13a030cdaded2276f489226/printing/metafile_skia.h
https://chromium.googlesource.com/chromium/src/+/79f6ec67cb060f4cb13a030cdaded2276f489226
commit 79f6ec67cb060f4cb13a030cdaded2276f489226
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Mar 31 15:01:36 2023
Fix use of GrDirectContext->flush and Skia includes
In http://review.skia.org/664477 we
introduce a new API to GrDirectContext that requires disambiguating
flushes. Additional changes change up #includes a bit and
would otherwise break Chrome in places that were not
including correctly.
Bug: skia:13983, skia:13052
Change-Id: Ia14c826d1a32f97e5f9c510d32532805a38fc16d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4387338
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1124723}
[modify] https://crrev.com/79f6ec67cb060f4cb13a030cdaded2276f489226/gpu/command_buffer/service/shared_image/external_vk_image_backing.cc
[modify] https://crrev.com/79f6ec67cb060f4cb13a030cdaded2276f489226/printing/common/metafile_utils.cc
[modify] https://crrev.com/79f6ec67cb060f4cb13a030cdaded2276f489226/components/paint_preview/common/serial_utils.cc
[modify] https://crrev.com/79f6ec67cb060f4cb13a030cdaded2276f489226/printing/metafile_skia.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #90
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/aedee7ddca3b435793ce91ae1160b1e3aea753bf
commit aedee7ddca3b435793ce91ae1160b1e3aea753bf
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Mar 31 15:31:43 2023
Disable legacy SkImage factories
Follow-up to https://skia-review.googlesource.com/c/skia/+/661059
and https://chromium-review.googlesource.com/c/chromium/src/+/4348201
Chromium and all deps should be migrated to the new APIs at this
point, so we can set SK_DISABLE_LEGACY_IMAGE_FACTORIES to
prevent unintentional use.
Bug: skia:13983
Change-Id: Ibf7a7f900c142f6b6ab803758364aa98f84ef01b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4388783
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1124742}
[modify] https://crrev.com/aedee7ddca3b435793ce91ae1160b1e3aea753bf/skia/BUILD.gn
[modify] https://crrev.com/aedee7ddca3b435793ce91ae1160b1e3aea753bf/cc/paint/image_transfer_cache_entry.cc
https://chromium.googlesource.com/chromium/src/+/aedee7ddca3b435793ce91ae1160b1e3aea753bf
commit aedee7ddca3b435793ce91ae1160b1e3aea753bf
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Mar 31 15:31:43 2023
Disable legacy SkImage factories
Follow-up to https://skia-review.googlesource.com/c/skia/+/661059
and https://chromium-review.googlesource.com/c/chromium/src/+/4348201
Chromium and all deps should be migrated to the new APIs at this
point, so we can set SK_DISABLE_LEGACY_IMAGE_FACTORIES to
prevent unintentional use.
Bug: skia:13983
Change-Id: Ibf7a7f900c142f6b6ab803758364aa98f84ef01b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4388783
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1124742}
[modify] https://crrev.com/aedee7ddca3b435793ce91ae1160b1e3aea753bf/skia/BUILD.gn
[modify] https://crrev.com/aedee7ddca3b435793ce91ae1160b1e3aea753bf/cc/paint/image_transfer_cache_entry.cc
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #91
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5
commit 4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Mar 31 12:34:10 2023
Reland "Remove some GPU-specific methods from SkImage"
This reverts commit f6c1eefd46005871af541940ea36fc000fec5451.
Reason for revert: Fixed clients
Client CLs:
- https://crrev.com/c/4387338
Original change's description:
https://skia.googlesource.com/skia/+/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5
commit 4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Mar 31 12:34:10 2023
Reland "Remove some GPU-specific methods from SkImage"
This reverts commit f6c1eefd46005871af541940ea36fc000fec5451.
Reason for revert: Fixed clients
Client CLs:
- https://crrev.com/c/4387338
Original change's description:
Bug: skia:13983
Change-Id: I77bb6e5c5830b1806c025df8df9fda4be4956bfc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/664477
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/tools/sk_app/win/D3D12WindowContext_win.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/tests/GrFinishedFlushTest.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/src/image/SkImage_Raster.h
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/bench/BulkRectBench.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/src/image/SkImage_Lazy.h
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/tests/SurfaceTest.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/tests/VkBackendSurfaceTest.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/src/gpu/ganesh/image/SkImage_GaneshBase.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/gm/image.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/src/gpu/ganesh/image/SkImage_GaneshFactories.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/gm/asyncrescaleandread.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/tests/RepeatedClippedBlurTest.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/tools/fiddle/all_examples.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/bench/ImageFilterDAGBench.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/src/image/SkImage.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/tests/ImageFilterCacheTest.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/src/gpu/ganesh/image/SkImage_GaneshBase.h
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/gm/makecolorspace.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/src/gpu/graphite/Image_Base_Graphite.h
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/src/image/SkImage_Base.h
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/include/core/SkImage.h
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/tests/TextureProxyTest.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/gm/imagefilters.cpp
[add] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/docs/examples/Image_MakeBackendTextureFromImage.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/src/gpu/ganesh/image/SkImage_Ganesh.h
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/tests/ImageTest.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/gm/readpixels.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/src/gpu/ganesh/image/SkImage_GaneshYUVA.h
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/tools/ToolUtils.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/include/gpu/ganesh/SkImageGanesh.h
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/src/gpu/ganesh/GrDirectContext.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/src/gpu/ganesh/image/SkImage_Ganesh.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/tests/GrTextureMipMapInvalidationTest.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/src/gpu/graphite/Image_Base_Graphite.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/src/gpu/ganesh/image/GrPinnableImage.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/RELEASE_NOTES.md
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/dm/DMSrcSink.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/src/image/SkImage_Base.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/tests/DeviceTest.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/src/gpu/ganesh/image/SkImage_GaneshYUVA.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/include/gpu/GrDirectContext.h
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/tests/BackendSurfaceMutableStateTest.cpp
[delete] https://crrev.com/5119e326ab44f4667fad5323514af37392d9bc3e/docs/examples/Image_GetBackendTextureFromImage.cpp
[modify] https://crrev.com/4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5/tests/SurfaceSemaphoreTest.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #92
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/7ca5e4f609d6628c5294f8837cf384b2f2bbc342
commit 7ca5e4f609d6628c5294f8837cf384b2f2bbc342
Author: Michael Ludwig <michaelludwig@google.com>
Date: Sun Apr 02 00:39:33 2023
Revert "Reland "Remove some GPU-specific methods from SkImage""
This reverts commit 4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5.
Reason for revert: cc_unittest asserts in Skia code related to YUV
images and ref counting.
Original change's description:
https://skia.googlesource.com/skia/+/7ca5e4f609d6628c5294f8837cf384b2f2bbc342
commit 7ca5e4f609d6628c5294f8837cf384b2f2bbc342
Author: Michael Ludwig <michaelludwig@google.com>
Date: Sun Apr 02 00:39:33 2023
Revert "Reland "Remove some GPU-specific methods from SkImage""
This reverts commit 4d1e9cabf0c8c9d71f5749a2473b2ee5dee692b5.
Reason for revert: cc_unittest asserts in Skia code related to YUV
images and ref counting.
Original change's description:
Bug: skia:13983
Change-Id: Ia38635595144e73dd541bcf78c75ee88f800cc5f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/664984
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Florin Malita <fmalita@google.com>
Reviewed-by: Florin Malita <fmalita@google.com>
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/tools/sk_app/win/D3D12WindowContext_win.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/tests/GrFinishedFlushTest.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/src/image/SkImage_Raster.h
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/bench/BulkRectBench.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/src/image/SkImage_Lazy.h
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/tests/SurfaceTest.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/tests/VkBackendSurfaceTest.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/src/gpu/ganesh/image/SkImage_GaneshBase.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/gm/image.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/src/gpu/ganesh/image/SkImage_GaneshFactories.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/gm/asyncrescaleandread.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/tests/RepeatedClippedBlurTest.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/tools/fiddle/all_examples.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/bench/ImageFilterDAGBench.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/src/image/SkImage.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/tests/ImageFilterCacheTest.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/src/gpu/ganesh/image/SkImage_GaneshBase.h
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/gm/makecolorspace.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/src/gpu/graphite/Image_Base_Graphite.h
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/src/image/SkImage_Base.h
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/include/core/SkImage.h
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/tests/TextureProxyTest.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/gm/imagefilters.cpp
[delete] https://crrev.com/47d56658e6bf9305580b63fa299299d91571cdd2/docs/examples/Image_MakeBackendTextureFromImage.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/src/gpu/ganesh/image/SkImage_Ganesh.h
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/tests/ImageTest.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/gm/readpixels.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/src/gpu/ganesh/image/SkImage_GaneshYUVA.h
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/tools/ToolUtils.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/include/gpu/ganesh/SkImageGanesh.h
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/src/gpu/ganesh/GrDirectContext.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/src/gpu/ganesh/image/SkImage_Ganesh.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/tests/GrTextureMipMapInvalidationTest.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/src/gpu/graphite/Image_Base_Graphite.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/src/gpu/ganesh/image/GrPinnableImage.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/RELEASE_NOTES.md
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/dm/DMSrcSink.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/src/image/SkImage_Base.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/tests/DeviceTest.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/src/gpu/ganesh/image/SkImage_GaneshYUVA.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/include/gpu/GrDirectContext.h
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/tests/BackendSurfaceMutableStateTest.cpp
[add] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/docs/examples/Image_GetBackendTextureFromImage.cpp
[modify] https://crrev.com/7ca5e4f609d6628c5294f8837cf384b2f2bbc342/tests/SurfaceSemaphoreTest.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #93
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/7a2d1b334fc86133e203daa19d53dcacd6893757
commit 7a2d1b334fc86133e203daa19d53dcacd6893757
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Apr 04 13:50:57 2023
Reland "Reland "Remove some GPU-specific methods from SkImage""
This reverts commit 7ca5e4f609d6628c5294f8837cf384b2f2bbc342.
Fix use-after free by reffing pointers and avoid extra copy
in MakeBackendTextureFromImage which loses mipmaps.
Original change's description:
https://skia.googlesource.com/skia/+/7a2d1b334fc86133e203daa19d53dcacd6893757
commit 7a2d1b334fc86133e203daa19d53dcacd6893757
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Apr 04 13:50:57 2023
Reland "Reland "Remove some GPU-specific methods from SkImage""
This reverts commit 7ca5e4f609d6628c5294f8837cf384b2f2bbc342.
Fix use-after free by reffing pointers and avoid extra copy
in MakeBackendTextureFromImage which loses mipmaps.
Original change's description:
Bug: skia:13983
Change-Id: Ic9d4425088a9f05e52b79c9233fc61c485dcdb22
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/665236
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/tools/sk_app/win/D3D12WindowContext_win.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/tests/GrFinishedFlushTest.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/src/image/SkImage_Raster.h
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/bench/BulkRectBench.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/tests/SurfaceTest.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/src/image/SkImage_Lazy.h
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/tests/VkBackendSurfaceTest.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/src/gpu/ganesh/image/SkImage_GaneshBase.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/gm/image.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/src/gpu/ganesh/image/SkImage_GaneshFactories.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/tests/RepeatedClippedBlurTest.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/gm/asyncrescaleandread.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/tools/fiddle/all_examples.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/tests/ImageFilterCacheTest.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/src/image/SkImage.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/bench/ImageFilterDAGBench.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/src/gpu/ganesh/image/SkImage_GaneshBase.h
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/gm/makecolorspace.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/src/gpu/graphite/Image_Base_Graphite.h
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/src/image/SkImage_Base.h
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/tests/TextureProxyTest.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/include/core/SkImage.h
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/gm/imagefilters.cpp
[add] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/docs/examples/Image_MakeBackendTextureFromImage.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/tests/ImageTest.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/src/gpu/ganesh/image/SkImage_Ganesh.h
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/gm/readpixels.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/src/gpu/ganesh/image/SkImage_GaneshYUVA.h
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/tools/ToolUtils.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/include/gpu/ganesh/SkImageGanesh.h
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/src/gpu/ganesh/GrDirectContext.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/tests/GrTextureMipMapInvalidationTest.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/src/gpu/ganesh/image/SkImage_Ganesh.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/src/gpu/graphite/Image_Base_Graphite.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/src/gpu/ganesh/image/GrPinnableImage.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/RELEASE_NOTES.md
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/src/image/SkImage_Base.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/dm/DMSrcSink.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/tests/DeviceTest.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/src/gpu/ganesh/image/SkImage_GaneshYUVA.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/tests/BackendSurfaceMutableStateTest.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/include/gpu/GrDirectContext.h
[delete] https://crrev.com/37ddbdb99d18e7599071cdfd7400c0c67235f10f/docs/examples/Image_GetBackendTextureFromImage.cpp
[modify] https://crrev.com/7a2d1b334fc86133e203daa19d53dcacd6893757/tests/SurfaceSemaphoreTest.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #94
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/1e83bc195f7f035a54f3793aa13902f7209bee41
commit 1e83bc195f7f035a54f3793aa13902f7209bee41
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Apr 05 14:16:17 2023
Allow SkImage pointer in GetBackendTextureFromImage
While Skia exclusively uses the sk_sp version, clients seem to use
a mix of sk_sp and raw pointers. It seems silly to require clients
to wrap the pointer just to have it be unwrapped, so this extra alias
should make the transition more seamless.
Change-Id: Iaa45f9e75848297386c8cf261c69c08fddd99dac
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/666857
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/1e83bc195f7f035a54f3793aa13902f7209bee41/src/image/SkImage.cpp
[modify] https://crrev.com/1e83bc195f7f035a54f3793aa13902f7209bee41/include/gpu/ganesh/SkImageGanesh.h
[modify] https://crrev.com/1e83bc195f7f035a54f3793aa13902f7209bee41/src/gpu/ganesh/image/SkImage_GaneshFactories.cpp
https://skia.googlesource.com/skia/+/1e83bc195f7f035a54f3793aa13902f7209bee41
commit 1e83bc195f7f035a54f3793aa13902f7209bee41
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Apr 05 14:16:17 2023
Allow SkImage pointer in GetBackendTextureFromImage
While Skia exclusively uses the sk_sp version, clients seem to use
a mix of sk_sp and raw pointers. It seems silly to require clients
to wrap the pointer just to have it be unwrapped, so this extra alias
should make the transition more seamless.
Change-Id: Iaa45f9e75848297386c8cf261c69c08fddd99dac
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/666857
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/1e83bc195f7f035a54f3793aa13902f7209bee41/src/image/SkImage.cpp
[modify] https://crrev.com/1e83bc195f7f035a54f3793aa13902f7209bee41/include/gpu/ganesh/SkImageGanesh.h
[modify] https://crrev.com/1e83bc195f7f035a54f3793aa13902f7209bee41/src/gpu/ganesh/image/SkImage_GaneshFactories.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #95
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7
commit c6bda115cf96bf5e03bd3dc5fe67046da3f62da7
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Apr 05 19:34:43 2023
Move mipmap serialization and deserialization to read/writebuffer
This will allow compilation of SkImage related things (including
Mipmaps) without needing to bring in the PNG codec.
This re-uses the Image serialization and deserialization proc
for the mipmap layers, with the default still being PNG encoding.
It also reduces code size by letting the linker drop out the
WEBP and JPEG encoders in certain circumstances.
Bug: skia:13983
Change-Id: I0249be88e6f97bb8b70bbebf4b5acc5958836bbf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/664177
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7/RELEASE_NOTES.md
[modify] https://crrev.com/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7/src/core/SkMipmap.h
[modify] https://crrev.com/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7/include/core/SkSerialProcs.h
[modify] https://crrev.com/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7/src/core/SkReadBuffer.cpp
[modify] https://crrev.com/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7/src/core/SkMipmap.cpp
[modify] https://crrev.com/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7/src/core/SkWriteBuffer.cpp
https://skia.googlesource.com/skia/+/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7
commit c6bda115cf96bf5e03bd3dc5fe67046da3f62da7
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Apr 05 19:34:43 2023
Move mipmap serialization and deserialization to read/writebuffer
This will allow compilation of SkImage related things (including
Mipmaps) without needing to bring in the PNG codec.
This re-uses the Image serialization and deserialization proc
for the mipmap layers, with the default still being PNG encoding.
It also reduces code size by letting the linker drop out the
WEBP and JPEG encoders in certain circumstances.
Bug: skia:13983
Change-Id: I0249be88e6f97bb8b70bbebf4b5acc5958836bbf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/664177
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7/RELEASE_NOTES.md
[modify] https://crrev.com/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7/src/core/SkMipmap.h
[modify] https://crrev.com/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7/include/core/SkSerialProcs.h
[modify] https://crrev.com/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7/src/core/SkReadBuffer.cpp
[modify] https://crrev.com/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7/src/core/SkMipmap.cpp
[modify] https://crrev.com/c6bda115cf96bf5e03bd3dc5fe67046da3f62da7/src/core/SkWriteBuffer.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #96
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/f9a0d0472a5eef23c339e34708f543ce15e6bcf4
commit f9a0d0472a5eef23c339e34708f543ce15e6bcf4
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Apr 06 14:14:20 2023
Remove WIC and CG image encoders
These are unused inside of Skia and in our major clients. Removing
them will make modularization of the codecs easier.
Bug: skia:13983
Change-Id: Ibcc12c81fe723a4f06aeda7d6ca52e503439d8e3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/667142
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
[modify] https://crrev.com/f9a0d0472a5eef23c339e34708f543ce15e6bcf4/RELEASE_NOTES.md
[delete] https://crrev.com/3ff611ffaae34e87263f523b5cc80a1c0f521b13/src/ports/SkImageEncoder_CG.cpp
[modify] https://crrev.com/f9a0d0472a5eef23c339e34708f543ce15e6bcf4/BUILD.gn
[modify] https://crrev.com/f9a0d0472a5eef23c339e34708f543ce15e6bcf4/src/encode/SkImageEncoderPriv.h
[delete] https://crrev.com/3ff611ffaae34e87263f523b5cc80a1c0f521b13/src/ports/SkImageEncoder_WIC.cpp
[modify] https://crrev.com/f9a0d0472a5eef23c339e34708f543ce15e6bcf4/src/encode/SkImageEncoder.cpp
[modify] https://crrev.com/f9a0d0472a5eef23c339e34708f543ce15e6bcf4/public.bzl
[modify] https://crrev.com/f9a0d0472a5eef23c339e34708f543ce15e6bcf4/gm/encode_platform.cpp
https://skia.googlesource.com/skia/+/f9a0d0472a5eef23c339e34708f543ce15e6bcf4
commit f9a0d0472a5eef23c339e34708f543ce15e6bcf4
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Apr 06 14:14:20 2023
Remove WIC and CG image encoders
These are unused inside of Skia and in our major clients. Removing
them will make modularization of the codecs easier.
Bug: skia:13983
Change-Id: Ibcc12c81fe723a4f06aeda7d6ca52e503439d8e3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/667142
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
[modify] https://crrev.com/f9a0d0472a5eef23c339e34708f543ce15e6bcf4/RELEASE_NOTES.md
[delete] https://crrev.com/3ff611ffaae34e87263f523b5cc80a1c0f521b13/src/ports/SkImageEncoder_CG.cpp
[modify] https://crrev.com/f9a0d0472a5eef23c339e34708f543ce15e6bcf4/BUILD.gn
[modify] https://crrev.com/f9a0d0472a5eef23c339e34708f543ce15e6bcf4/src/encode/SkImageEncoderPriv.h
[delete] https://crrev.com/3ff611ffaae34e87263f523b5cc80a1c0f521b13/src/ports/SkImageEncoder_WIC.cpp
[modify] https://crrev.com/f9a0d0472a5eef23c339e34708f543ce15e6bcf4/src/encode/SkImageEncoder.cpp
[modify] https://crrev.com/f9a0d0472a5eef23c339e34708f543ce15e6bcf4/public.bzl
[modify] https://crrev.com/f9a0d0472a5eef23c339e34708f543ce15e6bcf4/gm/encode_platform.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #97
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/9f5c5af1aede1bccb819346fc7657ad18728fecd
commit 9f5c5af1aede1bccb819346fc7657ad18728fecd
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Apr 10 13:44:39 2023
Migrate some GPU SkImage methods to static functions
This helps decouple SkImages from our GPU backends. This is a follow-up
to https://skia-review.googlesource.com/c/skia/+/665236
and requires https://skia-review.googlesource.com/c/skia/+/666857
to land and roll into Skia.
Bug: skia:13983
Change-Id: I79a3b90ea234d2a533f3bf54287e4a95a1c8a369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4401454
Reviewed-by: Bo Liu <boliu@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1128136}
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/components/viz/common/gpu/context_cache_controller_unittest.cc
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/media/renderers/paint_canvas_video_renderer.cc
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/cc/test/skia_common.cc
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/gpu/command_buffer/service/gr_cache_controller_unittest.cc
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/android_webview/browser/gfx/vulkan_gl_interop.cc
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/skia/BUILD.gn
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/gpu/command_buffer/service/service_transfer_cache.cc
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/cc/paint/image_transfer_cache_entry.cc
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/third_party/blink/renderer/platform/graphics/mailbox_texture_backing.cc
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/cc/tiles/gpu_image_decode_cache_unittest.cc
https://chromium.googlesource.com/chromium/src/+/9f5c5af1aede1bccb819346fc7657ad18728fecd
commit 9f5c5af1aede1bccb819346fc7657ad18728fecd
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Apr 10 13:44:39 2023
Migrate some GPU SkImage methods to static functions
This helps decouple SkImages from our GPU backends. This is a follow-up
to https://skia-review.googlesource.com/c/skia/+/665236
and requires https://skia-review.googlesource.com/c/skia/+/666857
to land and roll into Skia.
Bug: skia:13983
Change-Id: I79a3b90ea234d2a533f3bf54287e4a95a1c8a369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4401454
Reviewed-by: Bo Liu <boliu@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1128136}
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/components/viz/common/gpu/context_cache_controller_unittest.cc
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/media/renderers/paint_canvas_video_renderer.cc
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/cc/test/skia_common.cc
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/gpu/command_buffer/service/gr_cache_controller_unittest.cc
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/android_webview/browser/gfx/vulkan_gl_interop.cc
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/skia/BUILD.gn
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/gpu/command_buffer/service/service_transfer_cache.cc
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/cc/paint/image_transfer_cache_entry.cc
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/third_party/blink/renderer/platform/graphics/mailbox_texture_backing.cc
[modify] https://crrev.com/9f5c5af1aede1bccb819346fc7657ad18728fecd/cc/tiles/gpu_image_decode_cache_unittest.cc
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #98
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/be9784a9b4901aa856618841210b7a50f6af585b
commit be9784a9b4901aa856618841210b7a50f6af585b
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Apr 07 17:59:35 2023
Remove legacy SkImage factories
All major clients should be migrated.
Change-Id: Ide026c79a96e48ffbe2d9b7ddefc2e5864fc9b1f
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/667305
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Herb Derby <herb@google.com>
[modify] https://crrev.com/be9784a9b4901aa856618841210b7a50f6af585b/src/image/SkImage.cpp
[modify] https://crrev.com/be9784a9b4901aa856618841210b7a50f6af585b/include/core/SkImage.h
https://skia.googlesource.com/skia/+/be9784a9b4901aa856618841210b7a50f6af585b
commit be9784a9b4901aa856618841210b7a50f6af585b
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Apr 07 17:59:35 2023
Remove legacy SkImage factories
All major clients should be migrated.
Change-Id: Ide026c79a96e48ffbe2d9b7ddefc2e5864fc9b1f
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/667305
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Herb Derby <herb@google.com>
[modify] https://crrev.com/be9784a9b4901aa856618841210b7a50f6af585b/src/image/SkImage.cpp
[modify] https://crrev.com/be9784a9b4901aa856618841210b7a50f6af585b/include/core/SkImage.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #99
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/9f27f16e5fb76a8a869432a6189e472a816faea4
commit 9f27f16e5fb76a8a869432a6189e472a816faea4
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Apr 10 15:51:29 2023
Add CHECK to SkImages::GetBackendTextureFromImage and squash NPE
It was noticed in https://chromium-review.googlesource.com/c/chromium/src/+/4401454
that there could be a null dereference (crash) if
SkImages::TextureFromYUVATextures returned false.
One way this can happen is if SkImages::GetBackendTextureFromImage
returns false (and thus the given yuv_texture is invalid).
This makes sure the three textures we get are valid (using CHECK
because they should always be gettable) and a nullness
check for yuva_image.
Bug: skia:13983
Change-Id: Ie5849a8bb56a9f4534cc511ad468e5eb0027b5a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4402159
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1128162}
[modify] https://crrev.com/9f27f16e5fb76a8a869432a6189e472a816faea4/cc/tiles/gpu_image_decode_cache.cc
https://chromium.googlesource.com/chromium/src/+/9f27f16e5fb76a8a869432a6189e472a816faea4
commit 9f27f16e5fb76a8a869432a6189e472a816faea4
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Apr 10 15:51:29 2023
Add CHECK to SkImages::GetBackendTextureFromImage and squash NPE
It was noticed in https://chromium-review.googlesource.com/c/chromium/src/+/4401454
that there could be a null dereference (crash) if
SkImages::TextureFromYUVATextures returned false.
One way this can happen is if SkImages::GetBackendTextureFromImage
returns false (and thus the given yuv_texture is invalid).
This makes sure the three textures we get are valid (using CHECK
because they should always be gettable) and a nullness
check for yuva_image.
Bug: skia:13983
Change-Id: Ie5849a8bb56a9f4534cc511ad468e5eb0027b5a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4402159
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1128162}
[modify] https://crrev.com/9f27f16e5fb76a8a869432a6189e472a816faea4/cc/tiles/gpu_image_decode_cache.cc
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #100
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/1537de2c4cc0d2c12cddc3e23cbc47306103c5ba
commit 1537de2c4cc0d2c12cddc3e23cbc47306103c5ba
Author: Greg Daniel <egdaniel@google.com>
Date: Mon Apr 10 16:38:52 2023
Revert "Remove legacy SkImage factories"
This reverts commit be9784a9b4901aa856618841210b7a50f6af585b.
Reason for revert: breaking all graphite builds
Original change's description:
https://skia.googlesource.com/skia/+/1537de2c4cc0d2c12cddc3e23cbc47306103c5ba
commit 1537de2c4cc0d2c12cddc3e23cbc47306103c5ba
Author: Greg Daniel <egdaniel@google.com>
Date: Mon Apr 10 16:38:52 2023
Revert "Remove legacy SkImage factories"
This reverts commit be9784a9b4901aa856618841210b7a50f6af585b.
Reason for revert: breaking all graphite builds
Original change's description:
Bug: skia:13983
Change-Id: I230dff1bb93f00ec4cd99eeef101a4df6fdac0fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/668576
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Greg Daniel <egdaniel@google.com>
[modify] https://crrev.com/1537de2c4cc0d2c12cddc3e23cbc47306103c5ba/src/image/SkImage.cpp
[modify] https://crrev.com/1537de2c4cc0d2c12cddc3e23cbc47306103c5ba/include/core/SkImage.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #101
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/a3db72436782867851ab512141284564f183067b
commit a3db72436782867851ab512141284564f183067b
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Apr 10 17:05:21 2023
Reland "Remove legacy SkImage factories"
This is a reland of commit be9784a9b4901aa856618841210b7a50f6af585b
Original change's description:
https://skia.googlesource.com/skia/+/a3db72436782867851ab512141284564f183067b
commit a3db72436782867851ab512141284564f183067b
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Apr 10 17:05:21 2023
Reland "Remove legacy SkImage factories"
This is a reland of commit be9784a9b4901aa856618841210b7a50f6af585b
Original change's description:
Bug: skia:13983
Change-Id: If14e147dca941d11b1401ca8dd6f8918d5c8743f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/668596
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/a3db72436782867851ab512141284564f183067b/src/image/SkImage.cpp
[modify] https://crrev.com/a3db72436782867851ab512141284564f183067b/include/gpu/graphite/Context.h
[modify] https://crrev.com/a3db72436782867851ab512141284564f183067b/include/core/SkImage.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #102
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/a976b1be29b42a417ea0f3136170f582e0d18764
commit a976b1be29b42a417ea0f3136170f582e0d18764
Author: Kevin Lubick <kjlubick@chromium.org>
Date: Tue Apr 11 22:37:05 2023
Include no-opt impl of jpeg encoding in non-blink builds
This will let us land a refactor of image encoding in Skia. [1]
This requires the following staging cl to land and roll [2].
[1] https://skia-review.googlesource.com/c/skia/+/667298
[2] https://skia-review.googlesource.com/c/skia/+/669116
Change-Id: I66e48ddaf06880f418ad954511306162b77e3f88
Bug: skia:13983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415176
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1128955}
[modify] https://crrev.com/a976b1be29b42a417ea0f3136170f582e0d18764/skia/BUILD.gn
https://chromium.googlesource.com/chromium/src/+/a976b1be29b42a417ea0f3136170f582e0d18764
commit a976b1be29b42a417ea0f3136170f582e0d18764
Author: Kevin Lubick <kjlubick@chromium.org>
Date: Tue Apr 11 22:37:05 2023
Include no-opt impl of jpeg encoding in non-blink builds
This will let us land a refactor of image encoding in Skia. [1]
This requires the following staging cl to land and roll [2].
[1] https://skia-review.googlesource.com/c/skia/+/667298
[2] https://skia-review.googlesource.com/c/skia/+/669116
Change-Id: I66e48ddaf06880f418ad954511306162b77e3f88
Bug: skia:13983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415176
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1128955}
[modify] https://crrev.com/a976b1be29b42a417ea0f3136170f582e0d18764/skia/BUILD.gn
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #103
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/f48d2b067874003ad2030bd8e2efda0a18f2bb22
commit f48d2b067874003ad2030bd8e2efda0a18f2bb22
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Apr 11 22:37:34 2023
Deprecate and migrate internal uses of SkImageEncoder
SkImageEncoder prevents modular builds of Skia because it adds
implicit ties to all three encoding types. By using the
specific encoder API explicitly, this allows us to be more modular
and cognizant of the dependencies.
This might make some things a bit faster as we no longer make a copy
of a pixmap (via peekPixels) before encoding it.
Change-Id: I5cb9ef62afbf997a2ff4d6b856910ce2df65f394
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/668696
Reviewed-by: Leon Scroggins <scroggo@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/CodecPriv.h
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/experimental/sktext/tests/FontResolvedText.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/gm/image.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/CodecRecommendedTypeTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/gm/encode_platform.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tools/ToolUtils.h
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/experimental/sktext/tests/UnicodeText.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/JpegGainmapTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/src/image/SkImage.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/PathOpsConicIntersectionTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/experimental/sktext/tests/WrappedText.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/include/core/SkImageEncoder.h
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/experimental/sktext/tests/ShapedText.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/modules/skparagraph/tests/SkParagraphTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/CodecTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/fuzz/FuzzMain.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/experimental/sktext/tests/SelectableText.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/gm/orientation.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/src/xps/SkXPSDevice.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tools/skdiff/skdiff_utils.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tools/viewer/SlidesSlide.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/NdkEncodeTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/ImageTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tools/skpbench/skpbench.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/fuzz/FuzzSkParagraph.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tools/ToolUtils.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/gm/jpg_color_cube.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/EncodeTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/src/gpu/ganesh/text/GrAtlasManager.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/bench/nanobench.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/src/encode/SkImageEncoder.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tools/skdiff/skdiff_main.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/GrMeshTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/RELEASE_NOTES.md
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/src/core/SkBitmapProcState.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/TextBlobCacheTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/EncodedInfoTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/NdkDecodeTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/gm/encode.cpp
https://skia.googlesource.com/skia/+/f48d2b067874003ad2030bd8e2efda0a18f2bb22
commit f48d2b067874003ad2030bd8e2efda0a18f2bb22
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Apr 11 22:37:34 2023
Deprecate and migrate internal uses of SkImageEncoder
SkImageEncoder prevents modular builds of Skia because it adds
implicit ties to all three encoding types. By using the
specific encoder API explicitly, this allows us to be more modular
and cognizant of the dependencies.
This might make some things a bit faster as we no longer make a copy
of a pixmap (via peekPixels) before encoding it.
Change-Id: I5cb9ef62afbf997a2ff4d6b856910ce2df65f394
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/668696
Reviewed-by: Leon Scroggins <scroggo@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/CodecPriv.h
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/experimental/sktext/tests/FontResolvedText.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/gm/image.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/CodecRecommendedTypeTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/gm/encode_platform.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tools/ToolUtils.h
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/experimental/sktext/tests/UnicodeText.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/JpegGainmapTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/src/image/SkImage.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/PathOpsConicIntersectionTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/experimental/sktext/tests/WrappedText.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/include/core/SkImageEncoder.h
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/experimental/sktext/tests/ShapedText.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/modules/skparagraph/tests/SkParagraphTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/CodecTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/fuzz/FuzzMain.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/experimental/sktext/tests/SelectableText.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/gm/orientation.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/src/xps/SkXPSDevice.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tools/skdiff/skdiff_utils.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tools/viewer/SlidesSlide.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/NdkEncodeTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/ImageTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tools/skpbench/skpbench.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/fuzz/FuzzSkParagraph.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tools/ToolUtils.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/gm/jpg_color_cube.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/EncodeTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/src/gpu/ganesh/text/GrAtlasManager.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/bench/nanobench.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/src/encode/SkImageEncoder.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tools/skdiff/skdiff_main.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/GrMeshTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/RELEASE_NOTES.md
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/src/core/SkBitmapProcState.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/TextBlobCacheTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/EncodedInfoTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/tests/NdkDecodeTest.cpp
[modify] https://crrev.com/f48d2b067874003ad2030bd8e2efda0a18f2bb22/gm/encode.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #104
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/3353d1d9e951af896ac990da38f89a11de86e8a6
commit 3353d1d9e951af896ac990da38f89a11de86e8a6
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Apr 11 22:37:09 2023
Make SkPngEncoder and SkJpegEncoder namespaces, not classes
(SkWebpEncoder was already a namespace). This allows us to have
two (or more) implementations of a Sk*Encoder interface and makes
it easier to switch between those implementations.
To be concrete, we have an implementation of a png encoder
written on top of libpng which now lives in
src/encode/SkPngEncoderImpl.cpp. We can ship with this implementation
or one which uses SkNDKConversions::toDataSpace (in
src/ports/SkImageEncoder_NDK.cpp) or (temporarily) a no-op
implementation in src/encode/SkPngEncoder_none.cpp.
We rely on the build system to only build one of these implementations
and the linker to complain if we configure this wrong. These changes
do not require the use of #defines (such as SK_ENCODE_PNG) to
enable or disable these, which makes it easier to set up using
Bazel (and a modular build setup).
See also:
- https://crrev.com/c/4415176
Change-Id: I21b187940ac54b688b228f7b33a7428e1243d1f6
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/667298
Owners-Override: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
[rename] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkPngEncoderImpl.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/gn/core.gni
[add] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkPngEncoderImpl.h
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkJpegEncoder_none.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkImageEncoderPriv.h
[add] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkJpegEncoderImpl.h
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/include/encode/SkPngEncoder.h
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/modules/canvaskit/compile_gm.sh
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/gm/encode_platform.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkPngEncoder_none.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkWebpEncoder_none.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/tests/JpegGainmapTest.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/BUILD.gn
[rename] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkJpegEncoderImpl.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/include/encode/SkWebpEncoder.h
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/defines.bzl
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/tests/NdkEncodeTest.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/include/encode/SkJpegEncoder.h
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkJpegGainmapEncoder.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/bazel/skia_rules.bzl
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkImageEncoder.cpp
[rename] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkWebpEncoderImpl.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/ports/SkImageEncoder_NDK.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/BUILD.bazel
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/RELEASE_NOTES.md
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/bazel/exporter_tool/main.go
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/public.bzl
https://skia.googlesource.com/skia/+/3353d1d9e951af896ac990da38f89a11de86e8a6
commit 3353d1d9e951af896ac990da38f89a11de86e8a6
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Apr 11 22:37:09 2023
Make SkPngEncoder and SkJpegEncoder namespaces, not classes
(SkWebpEncoder was already a namespace). This allows us to have
two (or more) implementations of a Sk*Encoder interface and makes
it easier to switch between those implementations.
To be concrete, we have an implementation of a png encoder
written on top of libpng which now lives in
src/encode/SkPngEncoderImpl.cpp. We can ship with this implementation
or one which uses SkNDKConversions::toDataSpace (in
src/ports/SkImageEncoder_NDK.cpp) or (temporarily) a no-op
implementation in src/encode/SkPngEncoder_none.cpp.
We rely on the build system to only build one of these implementations
and the linker to complain if we configure this wrong. These changes
do not require the use of #defines (such as SK_ENCODE_PNG) to
enable or disable these, which makes it easier to set up using
Bazel (and a modular build setup).
See also:
- https://crrev.com/c/4415176
Change-Id: I21b187940ac54b688b228f7b33a7428e1243d1f6
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/667298
Owners-Override: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
[rename] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkPngEncoderImpl.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/gn/core.gni
[add] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkPngEncoderImpl.h
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkJpegEncoder_none.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkImageEncoderPriv.h
[add] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkJpegEncoderImpl.h
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/include/encode/SkPngEncoder.h
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/modules/canvaskit/compile_gm.sh
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/gm/encode_platform.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkPngEncoder_none.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkWebpEncoder_none.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/tests/JpegGainmapTest.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/BUILD.gn
[rename] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkJpegEncoderImpl.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/include/encode/SkWebpEncoder.h
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/defines.bzl
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/tests/NdkEncodeTest.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/include/encode/SkJpegEncoder.h
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkJpegGainmapEncoder.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/bazel/skia_rules.bzl
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkImageEncoder.cpp
[rename] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/SkWebpEncoderImpl.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/ports/SkImageEncoder_NDK.cpp
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/src/encode/BUILD.bazel
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/RELEASE_NOTES.md
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/bazel/exporter_tool/main.go
[modify] https://crrev.com/3353d1d9e951af896ac990da38f89a11de86e8a6/public.bzl
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #105
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/bab392fd3d9a48e0b696d1799d5271444c199643
commit bab392fd3d9a48e0b696d1799d5271444c199643
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Apr 11 17:51:02 2023
Deprecate SkImage::encodeToData and migrate all internal uses
By removing this method, we will further (completely?) decouple
SkImage from our encoders, allowing for them to not contribute
to code size when not needed.
This adds replacement functions to include/encode/Sk*Encoder.h.
This CL must land with the follow-on CL to preserve the ability
to use NDK encoders instead of bundling in ones based on libpng
et al.
Change-Id: Ie20a41cfdf65c975f640fb9368f363a588bd9394
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/667296
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/src/encode/SkWebpEncoder.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/gm/image.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/include/encode/SkPngEncoder.h
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/gm/encode_color_types.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/docs/examples/Image_DeferredFromEncodedData.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/src/image/SkImage.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/gm/image_shader.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/tools/imgcvt.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/BUILD.gn
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/docs/examples/Image_encodeToData.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/tools/fonts/TestSVGTypeface.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/tools/fiddle/fiddle_main.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/include/core/SkImage.h
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/include/encode/SkWebpEncoder.h
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/tools/SkSharingProc.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/src/pdf/SkPDFBitmap.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/tests/ImageTest.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/include/encode/SkJpegEncoder.h
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/tools/blob_cache_sim.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/tests/SerialProcsTest.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/tests/CanvasStateTest.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/RELEASE_NOTES.md
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/src/encode/SkJpegEncoder.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/src/encode/SkPngEncoder.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/docs/examples/Image_encodeToData_2.cpp
https://skia.googlesource.com/skia/+/bab392fd3d9a48e0b696d1799d5271444c199643
commit bab392fd3d9a48e0b696d1799d5271444c199643
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Apr 11 17:51:02 2023
Deprecate SkImage::encodeToData and migrate all internal uses
By removing this method, we will further (completely?) decouple
SkImage from our encoders, allowing for them to not contribute
to code size when not needed.
This adds replacement functions to include/encode/Sk*Encoder.h.
This CL must land with the follow-on CL to preserve the ability
to use NDK encoders instead of bundling in ones based on libpng
et al.
Change-Id: Ie20a41cfdf65c975f640fb9368f363a588bd9394
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/667296
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/src/encode/SkWebpEncoder.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/gm/image.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/include/encode/SkPngEncoder.h
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/gm/encode_color_types.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/docs/examples/Image_DeferredFromEncodedData.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/src/image/SkImage.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/gm/image_shader.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/tools/imgcvt.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/BUILD.gn
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/docs/examples/Image_encodeToData.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/tools/fonts/TestSVGTypeface.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/tools/fiddle/fiddle_main.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/include/core/SkImage.h
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/include/encode/SkWebpEncoder.h
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/tools/SkSharingProc.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/src/pdf/SkPDFBitmap.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/tests/ImageTest.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/include/encode/SkJpegEncoder.h
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/tools/blob_cache_sim.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/tests/SerialProcsTest.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/tests/CanvasStateTest.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/RELEASE_NOTES.md
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/src/encode/SkJpegEncoder.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/src/svg/SkSVGDevice.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/src/encode/SkPngEncoder.cpp
[modify] https://crrev.com/bab392fd3d9a48e0b696d1799d5271444c199643/docs/examples/Image_encodeToData_2.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #106
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/62b95b68d49384463ce03415a212e30b0611ea2f
commit 62b95b68d49384463ce03415a212e30b0611ea2f
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Apr 12 12:16:47 2023
Fix Bazel test targets
Follow-up to https://skia-review.googlesource.com/c/skia/+/667296
Change-Id: I5169cf7a93f15f6f6fcdf2d9900fbda4efc62ccf
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/669856
Reviewed-by: Herb Derby <herb@google.com>
[modify] https://crrev.com/62b95b68d49384463ce03415a212e30b0611ea2f/tests/BUILD.bazel
https://skia.googlesource.com/skia/+/62b95b68d49384463ce03415a212e30b0611ea2f
commit 62b95b68d49384463ce03415a212e30b0611ea2f
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Apr 12 12:16:47 2023
Fix Bazel test targets
Follow-up to https://skia-review.googlesource.com/c/skia/+/667296
Change-Id: I5169cf7a93f15f6f6fcdf2d9900fbda4efc62ccf
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/669856
Reviewed-by: Herb Derby <herb@google.com>
[modify] https://crrev.com/62b95b68d49384463ce03415a212e30b0611ea2f/tests/BUILD.bazel
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #107
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/e2d3dc99f4642e474c5228b59e24995022463884
commit e2d3dc99f4642e474c5228b59e24995022463884
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Apr 12 13:51:15 2023
Remove encodeToData from CanvasKit and documentation
Follow-up to https://skia-review.googlesource.com/c/skia/+/667296
This adds gn arguments so clients can explicitly disable certain
encoders without having to use #ifdefs.
Change-Id: I49b9e2db3b268eaf4171b720ebfed09472af3859
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/669916
Reviewed-by: Leon Scroggins <scroggo@google.com>
[modify] https://crrev.com/e2d3dc99f4642e474c5228b59e24995022463884/modules/canvaskit/debugger_bindings.cpp
[modify] https://crrev.com/e2d3dc99f4642e474c5228b59e24995022463884/gn/skia.gni
[modify] https://crrev.com/e2d3dc99f4642e474c5228b59e24995022463884/site/docs/user/api/skcanvas_creation.md
[modify] https://crrev.com/e2d3dc99f4642e474c5228b59e24995022463884/modules/canvaskit/compile.sh
[modify] https://crrev.com/e2d3dc99f4642e474c5228b59e24995022463884/BUILD.gn
[modify] https://crrev.com/e2d3dc99f4642e474c5228b59e24995022463884/modules/canvaskit/canvaskit_bindings.cpp
https://skia.googlesource.com/skia/+/e2d3dc99f4642e474c5228b59e24995022463884
commit e2d3dc99f4642e474c5228b59e24995022463884
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Apr 12 13:51:15 2023
Remove encodeToData from CanvasKit and documentation
Follow-up to https://skia-review.googlesource.com/c/skia/+/667296
This adds gn arguments so clients can explicitly disable certain
encoders without having to use #ifdefs.
Change-Id: I49b9e2db3b268eaf4171b720ebfed09472af3859
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/669916
Reviewed-by: Leon Scroggins <scroggo@google.com>
[modify] https://crrev.com/e2d3dc99f4642e474c5228b59e24995022463884/modules/canvaskit/debugger_bindings.cpp
[modify] https://crrev.com/e2d3dc99f4642e474c5228b59e24995022463884/gn/skia.gni
[modify] https://crrev.com/e2d3dc99f4642e474c5228b59e24995022463884/site/docs/user/api/skcanvas_creation.md
[modify] https://crrev.com/e2d3dc99f4642e474c5228b59e24995022463884/modules/canvaskit/compile.sh
[modify] https://crrev.com/e2d3dc99f4642e474c5228b59e24995022463884/BUILD.gn
[modify] https://crrev.com/e2d3dc99f4642e474c5228b59e24995022463884/modules/canvaskit/canvaskit_bindings.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #108
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/65d42d9528fce4d188ea649fc7adab5054bf401c
commit 65d42d9528fce4d188ea649fc7adab5054bf401c
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Apr 14 18:25:04 2023
Export public headers from encoders in GN build
Follow-up to https://skia-review.googlesource.com/c/skia/+/668696
Canary-Flutter-PR: 41204
Change-Id: If114f3374ef6bd34881e6d025ebbbb2719b4f4af
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/671917
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
[modify] https://crrev.com/65d42d9528fce4d188ea649fc7adab5054bf401c/BUILD.gn
https://skia.googlesource.com/skia/+/65d42d9528fce4d188ea649fc7adab5054bf401c
commit 65d42d9528fce4d188ea649fc7adab5054bf401c
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Apr 14 18:25:04 2023
Export public headers from encoders in GN build
Follow-up to https://skia-review.googlesource.com/c/skia/+/668696
Canary-Flutter-PR: 41204
Change-Id: If114f3374ef6bd34881e6d025ebbbb2719b4f4af
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/671917
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
[modify] https://crrev.com/65d42d9528fce4d188ea649fc7adab5054bf401c/BUILD.gn
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #109
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/cdc94d73c9c17f2a399493fe471b5f779f9623e2
commit cdc94d73c9c17f2a399493fe471b5f779f9623e2
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Apr 14 20:27:04 2023
Replace deprecated SkImageEncoder APIs with new variants
SkImageEncoder was deprecated in https://skia-review.googlesource.com/c/skia/+/668696
and SkImage->encodeToData was deprecated in
https://skia-review.googlesource.com/c/skia/+/667296
These use the new variants (or delete unneeded references).
Change-Id: Iad6e719cecad37b000140247fdcb6d738dab3f9e
Bug: skia:13983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4419326
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1130653}
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/components/paint_preview/DEPS
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/chrome/browser/taskbar/taskbar_decorator_win.cc
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/skia/ext/skia_utils_base.cc
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/chrome/browser/ash/app_list/app_list_sort_browsertest.cc
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/skia/BUILD.gn
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/chrome/browser/android/vr/gvr_graphics_delegate.cc
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/chrome/browser/ash/extensions/file_manager/private_api_thumbnail.cc
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/chrome/browser/ui/webui/util/image_util.cc
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/chrome/browser/ui/web_applications/test/isolated_web_app_test_utils.cc
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/components/paint_preview/renderer/paint_preview_recorder_utils_unittest.cc
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/components/paint_preview/common/serial_utils.cc
https://chromium.googlesource.com/chromium/src/+/cdc94d73c9c17f2a399493fe471b5f779f9623e2
commit cdc94d73c9c17f2a399493fe471b5f779f9623e2
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Apr 14 20:27:04 2023
Replace deprecated SkImageEncoder APIs with new variants
SkImageEncoder was deprecated in https://skia-review.googlesource.com/c/skia/+/668696
and SkImage->encodeToData was deprecated in
https://skia-review.googlesource.com/c/skia/+/667296
These use the new variants (or delete unneeded references).
Change-Id: Iad6e719cecad37b000140247fdcb6d738dab3f9e
Bug: skia:13983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4419326
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1130653}
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/components/paint_preview/DEPS
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/chrome/browser/taskbar/taskbar_decorator_win.cc
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/skia/ext/skia_utils_base.cc
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/chrome/browser/ash/app_list/app_list_sort_browsertest.cc
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/skia/BUILD.gn
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/chrome/browser/android/vr/gvr_graphics_delegate.cc
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/chrome/browser/ash/extensions/file_manager/private_api_thumbnail.cc
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/chrome/browser/ui/webui/util/image_util.cc
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/chrome/browser/ui/web_applications/test/isolated_web_app_test_utils.cc
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/components/paint_preview/renderer/paint_preview_recorder_utils_unittest.cc
[modify] https://crrev.com/cdc94d73c9c17f2a399493fe471b5f779f9623e2/components/paint_preview/common/serial_utils.cc
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #110
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4
commit 1cd1998bdcf00f30ea443f0c1a9b91a298f571d4
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Apr 21 13:59:05 2023
Expose SkPixmapUtils
SkPixmapUtils::Orient is a useful utility when dealing with exif data.
See also https://github.com/flutter/engine/pull/41368
Bug: skia:13983
Change-Id: I69aeaa45f2b1fc44c2e9bad6afbb5d6361fa84ef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/676116
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/src/codec/SkPixmapUtils.cpp
[delete] https://crrev.com/e54b86b174002732c33bba5f5084174bce048a4a/src/codec/SkPixmapUtils.h
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/gn/codec.gni
[add] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/src/codec/SkPixmapUtilsPriv.h
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/src/android/SkAnimatedImage.cpp
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/src/codec/SkCodecImageGenerator.cpp
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/src/codec/BUILD.bazel
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/bench/ReadPixBench.cpp
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/include/codec/BUILD.bazel
[add] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/include/codec/SkPixmapUtils.h
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/src/ports/SkImageGeneratorCG.cpp
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/src/BUILD.bazel
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/public.bzl
https://skia.googlesource.com/skia/+/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4
commit 1cd1998bdcf00f30ea443f0c1a9b91a298f571d4
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Apr 21 13:59:05 2023
Expose SkPixmapUtils
SkPixmapUtils::Orient is a useful utility when dealing with exif data.
See also https://github.com/flutter/engine/pull/41368
Bug: skia:13983
Change-Id: I69aeaa45f2b1fc44c2e9bad6afbb5d6361fa84ef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/676116
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/src/codec/SkPixmapUtils.cpp
[delete] https://crrev.com/e54b86b174002732c33bba5f5084174bce048a4a/src/codec/SkPixmapUtils.h
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/gn/codec.gni
[add] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/src/codec/SkPixmapUtilsPriv.h
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/src/android/SkAnimatedImage.cpp
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/src/codec/SkCodecImageGenerator.cpp
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/src/codec/BUILD.bazel
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/bench/ReadPixBench.cpp
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/include/codec/BUILD.bazel
[add] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/include/codec/SkPixmapUtils.h
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/src/ports/SkImageGeneratorCG.cpp
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/src/BUILD.bazel
[modify] https://crrev.com/1cd1998bdcf00f30ea443f0c1a9b91a298f571d4/public.bzl
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #111
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/0ec4c84abd0b578a5c792b04b56653cbc325530e
commit 0ec4c84abd0b578a5c792b04b56653cbc325530e
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Apr 20 18:46:28 2023
Remove SkImageEncoder and SkImage::encodeToData
It has been replaced with direct calls to SkPngEncoder, SkJpegEncoder,
SkWebpEncoder or SkImage::refEncodedData
Select client CLs:
- http://ag/22782690
- http://cl/525805096
- http://cl/525850833
- http://cl/525275434
Change-Id: I095da707c301ee9a2b439c2d66b440f5f0e8644b
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/675126
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/0ec4c84abd0b578a5c792b04b56653cbc325530e/gn/core.gni
[modify] https://crrev.com/0ec4c84abd0b578a5c792b04b56653cbc325530e/src/encode/BUILD.bazel
[modify] https://crrev.com/0ec4c84abd0b578a5c792b04b56653cbc325530e/src/image/SkImage.cpp
[modify] https://crrev.com/0ec4c84abd0b578a5c792b04b56653cbc325530e/RELEASE_NOTES.md
[delete] https://crrev.com/85fa2b417721eafeedafa9da497776e67eb40cbc/include/core/SkImageEncoder.h
[modify] https://crrev.com/0ec4c84abd0b578a5c792b04b56653cbc325530e/include/core/BUILD.bazel
[delete] https://crrev.com/85fa2b417721eafeedafa9da497776e67eb40cbc/src/encode/SkImageEncoder.cpp
[modify] https://crrev.com/0ec4c84abd0b578a5c792b04b56653cbc325530e/public.bzl
[modify] https://crrev.com/0ec4c84abd0b578a5c792b04b56653cbc325530e/include/core/SkImage.h
https://skia.googlesource.com/skia/+/0ec4c84abd0b578a5c792b04b56653cbc325530e
commit 0ec4c84abd0b578a5c792b04b56653cbc325530e
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Apr 20 18:46:28 2023
Remove SkImageEncoder and SkImage::encodeToData
It has been replaced with direct calls to SkPngEncoder, SkJpegEncoder,
SkWebpEncoder or SkImage::refEncodedData
Select client CLs:
- http://ag/22782690
- http://cl/525805096
- http://cl/525850833
- http://cl/525275434
Change-Id: I095da707c301ee9a2b439c2d66b440f5f0e8644b
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/675126
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/0ec4c84abd0b578a5c792b04b56653cbc325530e/gn/core.gni
[modify] https://crrev.com/0ec4c84abd0b578a5c792b04b56653cbc325530e/src/encode/BUILD.bazel
[modify] https://crrev.com/0ec4c84abd0b578a5c792b04b56653cbc325530e/src/image/SkImage.cpp
[modify] https://crrev.com/0ec4c84abd0b578a5c792b04b56653cbc325530e/RELEASE_NOTES.md
[delete] https://crrev.com/85fa2b417721eafeedafa9da497776e67eb40cbc/include/core/SkImageEncoder.h
[modify] https://crrev.com/0ec4c84abd0b578a5c792b04b56653cbc325530e/include/core/BUILD.bazel
[delete] https://crrev.com/85fa2b417721eafeedafa9da497776e67eb40cbc/src/encode/SkImageEncoder.cpp
[modify] https://crrev.com/0ec4c84abd0b578a5c792b04b56653cbc325530e/public.bzl
[modify] https://crrev.com/0ec4c84abd0b578a5c792b04b56653cbc325530e/include/core/SkImage.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #112
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2
commit 4c4917042a3cdf7aa6dbe154ac1724194e6edfa2
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Apr 24 13:08:06 2023
Add minimal viewer build with Bazel.
This doesn't yet support all the slide types, but does allow us
to have a GM slide (with one gm for now).
I enforced IWYU on tools/viewer/ and gm/ to help resolve all
deps. How we handle command line flags is a bit unfortunate
(as a filegroup and not a cc_library), but I think that's
pretty tough to untangle for now.
We can add more slide types and gms as we see fit in future
CLs.
Change-Id: I41876f1b115f60e72b4b297a2106441b49cd4497
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/676118
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/gm/gm.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SKPSlide.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/bazel/deps.bzl
[add] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/BUILD.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/BUILD.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/MSKPSlide.cpp
[add] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/trace/BUILD.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/Viewer.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/gm/bitmaprect.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/gm/hardstop_gradients_many.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/ImageSlide.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/gpu/GrTest.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/MSKPSlide.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/TouchGesture.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/gm/fillrect_gradient.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/gpu/gl/GLTestContext.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/sk_app/BUILD.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SlideDir.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SKPSlide.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/ClickHandlerSlide.h
[add] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/gm/BUILD.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SkSLSlide.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SimpleStrokerSlide.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/src/utils/BUILD.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/BisectSlide.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/gm/verifiers/gmverifier.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SvgSlide.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/StatsLayer.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SkSLDebuggerSlide.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/WORKSPACE.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/ImageSlide.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/GMSlide.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/flags/BUILD.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/VariableWidthStrokerSlide.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/gm/verifiers/gmverifier.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/Viewer.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/BisectSlide.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/StatsLayer.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/GMSlide.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SvgSlide.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/gm/gm.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/ImGuiLayer.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SkSLDebuggerSlide.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SlideDir.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/bazel/deps_parser/deps_parser.go
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/gpu/BUILD.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/ImGuiLayer.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SkSLSlide.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/BUILD.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/TouchGesture.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/Slide.h
[add] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/bazel/external/imgui/BUILD.bazel
https://skia.googlesource.com/skia/+/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2
commit 4c4917042a3cdf7aa6dbe154ac1724194e6edfa2
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Apr 24 13:08:06 2023
Add minimal viewer build with Bazel.
This doesn't yet support all the slide types, but does allow us
to have a GM slide (with one gm for now).
I enforced IWYU on tools/viewer/ and gm/ to help resolve all
deps. How we handle command line flags is a bit unfortunate
(as a filegroup and not a cc_library), but I think that's
pretty tough to untangle for now.
We can add more slide types and gms as we see fit in future
CLs.
Change-Id: I41876f1b115f60e72b4b297a2106441b49cd4497
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/676118
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/gm/gm.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SKPSlide.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/bazel/deps.bzl
[add] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/BUILD.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/BUILD.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/MSKPSlide.cpp
[add] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/trace/BUILD.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/Viewer.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/gm/bitmaprect.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/gm/hardstop_gradients_many.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/ImageSlide.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/gpu/GrTest.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/MSKPSlide.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/TouchGesture.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/gm/fillrect_gradient.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/gpu/gl/GLTestContext.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/sk_app/BUILD.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SlideDir.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SKPSlide.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/ClickHandlerSlide.h
[add] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/gm/BUILD.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SkSLSlide.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SimpleStrokerSlide.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/src/utils/BUILD.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/BisectSlide.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/gm/verifiers/gmverifier.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SvgSlide.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/StatsLayer.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SkSLDebuggerSlide.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/WORKSPACE.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/ImageSlide.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/GMSlide.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/flags/BUILD.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/VariableWidthStrokerSlide.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/gm/verifiers/gmverifier.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/Viewer.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/BisectSlide.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/StatsLayer.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/GMSlide.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SvgSlide.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/gm/gm.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/ImGuiLayer.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SkSLDebuggerSlide.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SlideDir.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/bazel/deps_parser/deps_parser.go
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/gpu/BUILD.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/ImGuiLayer.cpp
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/SkSLSlide.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/BUILD.bazel
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/TouchGesture.h
[modify] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/tools/viewer/Slide.h
[add] https://crrev.com/4c4917042a3cdf7aa6dbe154ac1724194e6edfa2/bazel/external/imgui/BUILD.bazel
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #113
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/982db0d1bc06cbb20812d2b1de2b3adabdb861cd
commit 982db0d1bc06cbb20812d2b1de2b3adabdb861cd
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Apr 25 15:39:49 2023
Move cross-context image to use DeferredFromTextureGenerator
Should have been done in http://review.skia.org/673717
Bug: skia:13983
Change-Id: Ief2339b7ea4a1d8b0b45179c256f99b371390406
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/680557
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/982db0d1bc06cbb20812d2b1de2b3adabdb861cd/tests/GrMipMappedTest.cpp
[modify] https://crrev.com/982db0d1bc06cbb20812d2b1de2b3adabdb861cd/src/gpu/ganesh/GrBackendTextureImageGenerator.cpp
[modify] https://crrev.com/982db0d1bc06cbb20812d2b1de2b3adabdb861cd/src/gpu/ganesh/GrBackendTextureImageGenerator.h
[modify] https://crrev.com/982db0d1bc06cbb20812d2b1de2b3adabdb861cd/src/gpu/ganesh/image/SkImage_GaneshFactories.cpp
https://skia.googlesource.com/skia/+/982db0d1bc06cbb20812d2b1de2b3adabdb861cd
commit 982db0d1bc06cbb20812d2b1de2b3adabdb861cd
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Apr 25 15:39:49 2023
Move cross-context image to use DeferredFromTextureGenerator
Should have been done in http://review.skia.org/673717
Bug: skia:13983
Change-Id: Ief2339b7ea4a1d8b0b45179c256f99b371390406
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/680557
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/982db0d1bc06cbb20812d2b1de2b3adabdb861cd/tests/GrMipMappedTest.cpp
[modify] https://crrev.com/982db0d1bc06cbb20812d2b1de2b3adabdb861cd/src/gpu/ganesh/GrBackendTextureImageGenerator.cpp
[modify] https://crrev.com/982db0d1bc06cbb20812d2b1de2b3adabdb861cd/src/gpu/ganesh/GrBackendTextureImageGenerator.h
[modify] https://crrev.com/982db0d1bc06cbb20812d2b1de2b3adabdb861cd/src/gpu/ganesh/image/SkImage_GaneshFactories.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #114
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/95449a75506a28ae31ae7eb383f44bdddbe036e6
commit 95449a75506a28ae31ae7eb383f44bdddbe036e6
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Apr 25 19:27:58 2023
Remove unnecessary include of SkEncodedImageFormat
Bug: skia:13983
Change-Id: I53de9ad7350e67195914cf75ebdc408d69e7b8c8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/681356
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Julia Lavrova <jlavrova@google.com>
[modify] https://crrev.com/95449a75506a28ae31ae7eb383f44bdddbe036e6/experimental/sktext/tests/UnicodeText.cpp
[modify] https://crrev.com/95449a75506a28ae31ae7eb383f44bdddbe036e6/fuzz/FuzzSkParagraph.cpp
[modify] https://crrev.com/95449a75506a28ae31ae7eb383f44bdddbe036e6/experimental/sktext/tests/WrappedText.cpp
[modify] https://crrev.com/95449a75506a28ae31ae7eb383f44bdddbe036e6/experimental/sktext/tests/ShapedText.cpp
[modify] https://crrev.com/95449a75506a28ae31ae7eb383f44bdddbe036e6/modules/skparagraph/tests/SkParagraphTest.cpp
[modify] https://crrev.com/95449a75506a28ae31ae7eb383f44bdddbe036e6/experimental/sktext/tests/FontResolvedText.cpp
[modify] https://crrev.com/95449a75506a28ae31ae7eb383f44bdddbe036e6/experimental/sktext/tests/SelectableText.cpp
https://skia.googlesource.com/skia/+/95449a75506a28ae31ae7eb383f44bdddbe036e6
commit 95449a75506a28ae31ae7eb383f44bdddbe036e6
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Apr 25 19:27:58 2023
Remove unnecessary include of SkEncodedImageFormat
Bug: skia:13983
Change-Id: I53de9ad7350e67195914cf75ebdc408d69e7b8c8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/681356
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Julia Lavrova <jlavrova@google.com>
[modify] https://crrev.com/95449a75506a28ae31ae7eb383f44bdddbe036e6/experimental/sktext/tests/UnicodeText.cpp
[modify] https://crrev.com/95449a75506a28ae31ae7eb383f44bdddbe036e6/fuzz/FuzzSkParagraph.cpp
[modify] https://crrev.com/95449a75506a28ae31ae7eb383f44bdddbe036e6/experimental/sktext/tests/WrappedText.cpp
[modify] https://crrev.com/95449a75506a28ae31ae7eb383f44bdddbe036e6/experimental/sktext/tests/ShapedText.cpp
[modify] https://crrev.com/95449a75506a28ae31ae7eb383f44bdddbe036e6/modules/skparagraph/tests/SkParagraphTest.cpp
[modify] https://crrev.com/95449a75506a28ae31ae7eb383f44bdddbe036e6/experimental/sktext/tests/FontResolvedText.cpp
[modify] https://crrev.com/95449a75506a28ae31ae7eb383f44bdddbe036e6/experimental/sktext/tests/SelectableText.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #115
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/e72842a382b78ee5a239e1dc85eca662855c48b9
commit e72842a382b78ee5a239e1dc85eca662855c48b9
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Apr 25 14:02:39 2023
Move Ganesh Skp texture code into GrImageUtils
This is a follow-up to http://review.skia.org/673717 which
makes SkPictureImageGenerator Ganesh-agnostic (and moves it
to src/image/ so it can be closer to its friends).
Change-Id: I61e0e8d5e026fd782da9651c4d90be51daee0734
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/678656
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[add] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/image/SkImage_Picture.cpp
[delete] https://crrev.com/f90ca5d9e508dc9d5208ec0f8034d68bb8431ffb/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/gn/core.gni
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/core/BUILD.bazel
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/image/SkImage_Lazy.h
[add] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/image/SkPictureImageGenerator.h
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/gpu/ganesh/image/GrImageUtils.cpp
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/image/SkImage.cpp
[add] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/image/SkImage_Picture.h
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/image/SkImage_LazyFactories.cpp
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/image/BUILD.bazel
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/image/SkImage_Base.h
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/include/core/SkImage.h
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/public.bzl
[add] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/image/SkPictureImageGenerator.cpp
https://skia.googlesource.com/skia/+/e72842a382b78ee5a239e1dc85eca662855c48b9
commit e72842a382b78ee5a239e1dc85eca662855c48b9
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Apr 25 14:02:39 2023
Move Ganesh Skp texture code into GrImageUtils
This is a follow-up to http://review.skia.org/673717 which
makes SkPictureImageGenerator Ganesh-agnostic (and moves it
to src/image/ so it can be closer to its friends).
Change-Id: I61e0e8d5e026fd782da9651c4d90be51daee0734
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/678656
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[add] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/image/SkImage_Picture.cpp
[delete] https://crrev.com/f90ca5d9e508dc9d5208ec0f8034d68bb8431ffb/src/core/SkPictureImageGenerator.cpp
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/gn/core.gni
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/core/BUILD.bazel
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/image/SkImage_Lazy.h
[add] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/image/SkPictureImageGenerator.h
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/gpu/ganesh/image/GrImageUtils.cpp
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/image/SkImage.cpp
[add] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/image/SkImage_Picture.h
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/image/SkImage_LazyFactories.cpp
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/image/BUILD.bazel
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/image/SkImage_Base.h
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/include/core/SkImage.h
[modify] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/public.bzl
[add] https://crrev.com/e72842a382b78ee5a239e1dc85eca662855c48b9/src/image/SkPictureImageGenerator.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #116
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/1b1bc99c13729be3dfab95c4c7771a4936365222
commit 1b1bc99c13729be3dfab95c4c7771a4936365222
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 01 13:19:16 2023
Remove last SK_GANESH #ifdefs from non-Ganesh SkImage code
Change-Id: Ic546e0dea6108ba38b1dcc230870b54dc5db8719
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/684578
Owners-Override: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[add] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/relnotes/skimage_methods.md
[modify] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/src/image/SkImage.cpp
[modify] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/src/gpu/ganesh/image/SkImage_GaneshBase.h
[modify] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/src/image/SkImage_Base.cpp
[modify] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/src/gpu/ganesh/image/SkImage_GaneshBase.cpp
[modify] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/src/image/SkImage_Base.h
[modify] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/include/core/SkImage.h
https://skia.googlesource.com/skia/+/1b1bc99c13729be3dfab95c4c7771a4936365222
commit 1b1bc99c13729be3dfab95c4c7771a4936365222
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 01 13:19:16 2023
Remove last SK_GANESH #ifdefs from non-Ganesh SkImage code
Change-Id: Ic546e0dea6108ba38b1dcc230870b54dc5db8719
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/684578
Owners-Override: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[add] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/relnotes/skimage_methods.md
[modify] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/src/image/SkImage.cpp
[modify] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/src/gpu/ganesh/image/SkImage_GaneshBase.h
[modify] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/src/image/SkImage_Base.cpp
[modify] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/src/gpu/ganesh/image/SkImage_GaneshBase.cpp
[modify] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/src/image/SkImage_Base.h
[modify] https://crrev.com/1b1bc99c13729be3dfab95c4c7771a4936365222/include/core/SkImage.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #117
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52
commit c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 01 20:35:40 2023
Mark SkSurface::recordingContext() and recorder() as const
Also remove deprecated constants.
Change-Id: I9581b6cbc6671cd59e29b8cd645a044e61fb853b
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/688037
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52/src/gpu/graphite/Surface_Graphite.cpp
[modify] https://crrev.com/c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52/src/gpu/graphite/Surface_Graphite.h
[modify] https://crrev.com/c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52/src/image/SkSurface.cpp
[modify] https://crrev.com/c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52/src/image/SkSurface_Base.h
[modify] https://crrev.com/c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52/include/core/SkSurface.h
[modify] https://crrev.com/c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52/src/gpu/ganesh/surface/SkSurface_Ganesh.h
[modify] https://crrev.com/c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52/src/image/SkSurface_Base.cpp
[modify] https://crrev.com/c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52/src/gpu/ganesh/surface/SkSurface_Ganesh.cpp
https://skia.googlesource.com/skia/+/c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52
commit c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 01 20:35:40 2023
Mark SkSurface::recordingContext() and recorder() as const
Also remove deprecated constants.
Change-Id: I9581b6cbc6671cd59e29b8cd645a044e61fb853b
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/688037
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52/src/gpu/graphite/Surface_Graphite.cpp
[modify] https://crrev.com/c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52/src/gpu/graphite/Surface_Graphite.h
[modify] https://crrev.com/c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52/src/image/SkSurface.cpp
[modify] https://crrev.com/c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52/src/image/SkSurface_Base.h
[modify] https://crrev.com/c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52/include/core/SkSurface.h
[modify] https://crrev.com/c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52/src/gpu/ganesh/surface/SkSurface_Ganesh.h
[modify] https://crrev.com/c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52/src/image/SkSurface_Base.cpp
[modify] https://crrev.com/c2b3f0c8c37c6cfd3c3037e6bfb8b4e0e9894d52/src/gpu/ganesh/surface/SkSurface_Ganesh.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #118
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/089b9cca26fec8d8bfcc8c7393f39520f5636b07
commit 089b9cca26fec8d8bfcc8c7393f39520f5636b07
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue May 02 18:34:15 2023
Move SkSurface::GetBackend* to SkSurfaces namespace
This will help us decouple SkSurface from the GPU backend. The
existing #ifdefs make it hard to build with Bazel as a modular build.
Another method, replaceBackendTexture has been added as a virtual
method instead of sometimes being defined and sometimes not.
Bug: skia:13983
Change-Id: I552c229ad779dd8e92322f505333123f1e9d1f72
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/687642
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/src/gpu/graphite/Surface_Graphite.cpp
[add] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/include/gpu/ganesh/SkSurfaceGanesh.h
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/include/gpu/ganesh/BUILD.bazel
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/src/image/SkSurface_Null.cpp
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/src/image/SkSurface_Raster.h
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/src/gpu/graphite/Surface_Graphite.h
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/src/image/SkSurface_Base.h
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/tests/SurfaceTest.cpp
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/tests/VkProtectedContextTest.cpp
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/src/gpu/ganesh/surface/SkSurface_Ganesh.h
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/src/image/SkSurface_Base.cpp
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/src/gpu/ganesh/surface/SkSurface_Ganesh.cpp
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/gn/gpu.gni
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/include/BUILD.bazel
[add] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/relnotes/sksurface_backend.md
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/src/image/SkSurface.cpp
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/tests/DeferredDisplayListTest.cpp
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/include/core/SkSurface.h
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/public.bzl
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/tests/SurfaceSemaphoreTest.cpp
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/modules/canvaskit/canvaskit_bindings.cpp
https://skia.googlesource.com/skia/+/089b9cca26fec8d8bfcc8c7393f39520f5636b07
commit 089b9cca26fec8d8bfcc8c7393f39520f5636b07
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue May 02 18:34:15 2023
Move SkSurface::GetBackend* to SkSurfaces namespace
This will help us decouple SkSurface from the GPU backend. The
existing #ifdefs make it hard to build with Bazel as a modular build.
Another method, replaceBackendTexture has been added as a virtual
method instead of sometimes being defined and sometimes not.
Bug: skia:13983
Change-Id: I552c229ad779dd8e92322f505333123f1e9d1f72
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/687642
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/src/gpu/graphite/Surface_Graphite.cpp
[add] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/include/gpu/ganesh/SkSurfaceGanesh.h
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/include/gpu/ganesh/BUILD.bazel
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/src/image/SkSurface_Null.cpp
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/src/image/SkSurface_Raster.h
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/src/gpu/graphite/Surface_Graphite.h
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/src/image/SkSurface_Base.h
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/tests/SurfaceTest.cpp
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/tests/VkProtectedContextTest.cpp
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/src/gpu/ganesh/surface/SkSurface_Ganesh.h
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/src/image/SkSurface_Base.cpp
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/src/gpu/ganesh/surface/SkSurface_Ganesh.cpp
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/gn/gpu.gni
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/include/BUILD.bazel
[add] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/relnotes/sksurface_backend.md
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/src/image/SkSurface.cpp
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/tests/DeferredDisplayListTest.cpp
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/include/core/SkSurface.h
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/public.bzl
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/tests/SurfaceSemaphoreTest.cpp
[modify] https://crrev.com/089b9cca26fec8d8bfcc8c7393f39520f5636b07/modules/canvaskit/canvaskit_bindings.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #119
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/a88cd1bb5f323981c7dc796d2d3d9a8fa09aae37
commit a88cd1bb5f323981c7dc796d2d3d9a8fa09aae37
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu May 04 11:25:46 2023
Put MakeRenderTarget behind an #ifdef
This is needed to land https://skia-review.googlesource.com/c/skia/+/687779
because this code is compiled sometimes with no GPU backend
(e.g. ios_simulator).
Bug: skia:13983
Change-Id: Ie756fa34e616f347072b3ab1f23150ba8756aeb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4503058
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1139439}
[modify] https://crrev.com/a88cd1bb5f323981c7dc796d2d3d9a8fa09aae37/ui/gfx/color_conversion_sk_filter_cache.cc
https://chromium.googlesource.com/chromium/src/+/a88cd1bb5f323981c7dc796d2d3d9a8fa09aae37
commit a88cd1bb5f323981c7dc796d2d3d9a8fa09aae37
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu May 04 11:25:46 2023
Put MakeRenderTarget behind an #ifdef
This is needed to land https://skia-review.googlesource.com/c/skia/+/687779
because this code is compiled sometimes with no GPU backend
(e.g. ios_simulator).
Bug: skia:13983
Change-Id: Ie756fa34e616f347072b3ab1f23150ba8756aeb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4503058
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1139439}
[modify] https://crrev.com/a88cd1bb5f323981c7dc796d2d3d9a8fa09aae37/ui/gfx/color_conversion_sk_filter_cache.cc
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #120
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/64ba57381c94352724cff0af77b24d14d18a5024
commit 64ba57381c94352724cff0af77b24d14d18a5024
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed May 03 12:36:52 2023
Don't define SkSurface::MakeRenderTarget when there is no GPU backend
Follow up on Android TODO in SkSurface
Client CLs:
- http://ag/22965803
- http://ag/22989547
- https://crrev.com/c/4503058
Change-Id: I8ba72c2c60c9c1ca2fa2a55e720e9eabc99451ad
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/687779
Reviewed-by: Leon Scroggins <scroggo@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/64ba57381c94352724cff0af77b24d14d18a5024/src/image/SkSurface.cpp
[modify] https://crrev.com/64ba57381c94352724cff0af77b24d14d18a5024/include/core/SkSurface.h
https://skia.googlesource.com/skia/+/64ba57381c94352724cff0af77b24d14d18a5024
commit 64ba57381c94352724cff0af77b24d14d18a5024
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed May 03 12:36:52 2023
Don't define SkSurface::MakeRenderTarget when there is no GPU backend
Follow up on Android TODO in SkSurface
Client CLs:
- http://ag/22965803
- http://ag/22989547
- https://crrev.com/c/4503058
Change-Id: I8ba72c2c60c9c1ca2fa2a55e720e9eabc99451ad
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/687779
Reviewed-by: Leon Scroggins <scroggo@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/64ba57381c94352724cff0af77b24d14d18a5024/src/image/SkSurface.cpp
[modify] https://crrev.com/64ba57381c94352724cff0af77b24d14d18a5024/include/core/SkSurface.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #121
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/082284fe5351f9b5e8de3403631d62c06614f44b
commit 082284fe5351f9b5e8de3403631d62c06614f44b
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 08 17:34:24 2023
[base] Move SkSpinlock and SkSharedMutex to src/base
No usages in include/ nor third-party clients, so this should be a
trivial move.
Change-Id: I6b481872b9e449c8197c95ae4107d4ef94e17994
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/694696
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Herb Derby <herb@google.com>
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/ports/SkScalerContext_win_dw.cpp
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/gn/core.gni
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/text/gpu/TextBlobRedrawCoordinator.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/gpu/graphite/GlobalCache.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/core/BUILD.bazel
[rename] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/base/SkSharedMutex.cpp
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/gpu/ganesh/GrProcessor.cpp
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/tests/SkSharedMutexTest.cpp
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/include/private/BUILD.bazel
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/gpu/graphite/ShaderCodeDictionary.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/core/SkStrikeCache.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/gpu/ganesh/image/SkImage_Ganesh.h
[rename] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/base/SkSpinlock.cpp
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/ports/SkFontHost_FreeType_common.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/core/SkExecutor.cpp
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/gpu/ganesh/mtl/GrMtlResourceProvider.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/base/BUILD.bazel
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/tools/trace/ChromeTracingTracer.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/gpu/ganesh/GrThreadSafeCache.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/tests/TextBlobCacheTest.cpp
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/bench/MutexBench.cpp
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/dm/DM.cpp
[rename] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/base/SkSpinlock.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/effects/imagefilters/SkRuntimeImageFilter.cpp
[rename] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/base/SkSharedMutex.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/public.bzl
https://skia.googlesource.com/skia/+/082284fe5351f9b5e8de3403631d62c06614f44b
commit 082284fe5351f9b5e8de3403631d62c06614f44b
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 08 17:34:24 2023
[base] Move SkSpinlock and SkSharedMutex to src/base
No usages in include/ nor third-party clients, so this should be a
trivial move.
Change-Id: I6b481872b9e449c8197c95ae4107d4ef94e17994
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/694696
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Herb Derby <herb@google.com>
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/ports/SkScalerContext_win_dw.cpp
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/gn/core.gni
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/text/gpu/TextBlobRedrawCoordinator.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/gpu/graphite/GlobalCache.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/core/BUILD.bazel
[rename] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/base/SkSharedMutex.cpp
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/gpu/ganesh/GrProcessor.cpp
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/tests/SkSharedMutexTest.cpp
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/include/private/BUILD.bazel
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/gpu/graphite/ShaderCodeDictionary.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/core/SkStrikeCache.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/gpu/ganesh/image/SkImage_Ganesh.h
[rename] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/base/SkSpinlock.cpp
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/ports/SkFontHost_FreeType_common.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/core/SkExecutor.cpp
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/gpu/ganesh/mtl/GrMtlResourceProvider.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/base/BUILD.bazel
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/tools/trace/ChromeTracingTracer.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/gpu/ganesh/GrThreadSafeCache.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/tests/TextBlobCacheTest.cpp
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/bench/MutexBench.cpp
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/dm/DM.cpp
[rename] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/base/SkSpinlock.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/effects/imagefilters/SkRuntimeImageFilter.cpp
[rename] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/src/base/SkSharedMutex.h
[modify] https://crrev.com/082284fe5351f9b5e8de3403631d62c06614f44b/public.bzl
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #122
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/70b7b2ca2106a2022ad636c0cd44335f5931c22f
commit 70b7b2ca2106a2022ad636c0cd44335f5931c22f
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 08 21:40:46 2023
Fix include of GrTypes.h
In https://skia-review.googlesource.com/c/skia/+/687639, we
remove GrTypes.h from SkSurface.h and this would otherwise
break.
Bug: skia:13983
Change-Id: Iac65504dcf76bca88ad696d3dd3a84b1a9ebfb6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4514119
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1141068}
[modify] https://crrev.com/70b7b2ca2106a2022ad636c0cd44335f5931c22f/third_party/blink/renderer/platform/graphics/canvas_resource_provider.h
https://chromium.googlesource.com/chromium/src/+/70b7b2ca2106a2022ad636c0cd44335f5931c22f
commit 70b7b2ca2106a2022ad636c0cd44335f5931c22f
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 08 21:40:46 2023
Fix include of GrTypes.h
In https://skia-review.googlesource.com/c/skia/+/687639, we
remove GrTypes.h from SkSurface.h and this would otherwise
break.
Bug: skia:13983
Change-Id: Iac65504dcf76bca88ad696d3dd3a84b1a9ebfb6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4514119
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1141068}
[modify] https://crrev.com/70b7b2ca2106a2022ad636c0cd44335f5931c22f/third_party/blink/renderer/platform/graphics/canvas_resource_provider.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #123
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/5c93acf313d1cf72f8b73886168bd925b5011b8c
commit 5c93acf313d1cf72f8b73886168bd925b5011b8c
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue May 09 16:11:43 2023
Move SkSurface factories to SkSurfaces namespace
* SkSurface::MakeFromAHardwareBuffer -> SkSurfaces::WrapAndroidHardwareBuffer
* SkSurface::MakeFromBackendRenderTarget -> SkSurfaces::WrapBackendRenderTarget
* SkSurface::MakeFromBackendTexture -> SkSurfaces::WrapBackendTexture
* SkSurface::MakeFromCAMetalLayer -> SkSurfaces::WrapCAMetalLayer
* SkSurface::MakeFromMTKView -> SkSurfaces::WrapMTKView
* SkSurface::MakeGraphite -> SkSurfaces::RenderTarget
* SkSurface::MakeGraphiteFromBackendTexture -> SkSurfaces::WrapBackendTexture
* SkSurface::MakeRaster -> SkSurfaces::Raster
* SkSurface::MakeRasterDirect -> SkSurfaces::WrapPixels
* SkSurface::MakeRasterDirectReleaseProc -> SkSurfaces::WrapPixels
* SkSurface::MakeRasterN32Premul -> SkSurfaces::Raster
* SkSurface::MakeRenderTarget -> SkSurfaces::RenderTarget
Suggested review order:
- include/*
- src/gpu/ganesh/surface/SkSurface_Ganesh.cpp
- src/image/SkSurface_Raster.cpp
- src/image/SkSurface.cpp
- All other changes which were mostly find-replace followed
by `git clang-format origin/main`
Change-Id: Idb18ab5c2beb12d8b4ec6712e9abee286646424f
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/687639
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/win/D3D12WindowContext_win.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/TextBlobTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_writePixels_2.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/imagefilterscropped.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/fm/fm.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ColorFilterTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/RepeatedClippedBlurTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/debugger/DebugLayerManager.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/RecordingSurfacesTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ImageNewShaderTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/image_shader.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_writePixels.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ClipCubicTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/core/SkBitmapDevice.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzPathDeserialize.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/DrawTextTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/FuzzGradients.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ImageTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/RectTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/skpbench/skpbench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/imagefilterstransformed.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/imagemakewithfilter.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/runtimeintrinsics.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/ImageFilterCollapse.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/android/RasterWindowContext_android.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SerialProcsTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/experimental/webgpu-bazel/src/bindings.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzAnimatedImage.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrThreadSafeCacheTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/skottie_ios_app/SkMetalViewBridge.mm
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/drawminibitmaprect.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/ImageBench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrSlugTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/DDLTileHelper.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_makeImageSnapshot_2.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/GraphitePromiseImageTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/image.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/arithmode.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/flippity.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/modules/canvaskit/gm_bindings.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/textblobmixedsizes.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/ganesh/GrGpu.h
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/Skbug5221.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Image_MakeBackendTextureFromImage.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/convexpolyclip.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/croppedrects.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ExtendedSkColorTypeTests.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrMipMappedTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrOpListFlushTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/TextureStripAtlasManagerTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/FuzzCreateDDL.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/bicubic.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrSurfaceResolveTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/resizeimagefilter.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzTextBlobDeserialize.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/modules/svg/utils/SvgTool.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/RecordOptsTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/CanvasStateTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/rewrite_includes.py
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/gpu_blur_utils.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/showmiplevels.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/image/SkRescaleAndReadPixels.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Image_isOpaque.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/filterfastbounds.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/image/SkPictureImageGenerator.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/PremulAlphaRoundTripTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/dropshadowimagefilter.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/50_percent_gray.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrFinishedFlushTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrAHardwareBufferTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/pdf/SkPDFShader.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ImageIsOpaqueTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_readPixels.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_readPixels_3.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/Skbug6653.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/bitmaprect.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/matrixconvolution.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SamplingTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/DrawPathTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_MakeRasterDirectReleaseProc.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/BlurTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/dstreadshuffle.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/ImageShaderTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/MutableImagesTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/path_stroke_with_zero_length.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/blob_cache_sim.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/shader_alphaimage.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/EncodeTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzImage.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/fiddle/draw.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/crbug_905548.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/skottie_ios_app/SkiaGLContext.mm
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/MergeBench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/modules/jetski/src/Surface.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/rasterhandleallocator.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/RecorderTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/PathTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/viewer/QuadStrokerSlide.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GLBackendSurfaceTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SkSLES2ConformanceTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/ReadWritePixelsGraphiteTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/ganesh/surface/SkSurface_GaneshMtl.mm
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzCOLRv1.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/verylargebitmap.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/Skbug12214.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/imagefilterscropexpand.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/IndexedPngOverflowTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/surface.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/DMSAATest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_getCanvas.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/window/VulkanWindowContext.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/ClipMaskBench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/viewer/FatBitsSlide.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ApplyGammaTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/pathfill.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/MultisampleTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzAndroidCodec.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SerializationTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/fonts/TestSVGTypeface.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/gpu/BackendSurfaceFactory.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzRegionDeserialize.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/DisplacementBench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/fatpathfill.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/PinnedImageTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/PromiseImageTest.cpp
[add] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/ganesh/surface/SkSurface_AndroidFactories.cpp
[add] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/include/gpu/graphite/Surface.h
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/platform_tools/android/apps/skottie/skottielib/src/main/cpp/native-lib.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/crop_imagefilter.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/viewer/AtlasSlide.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SkSLTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrTextBlobTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/ImageProviderTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/DrawBitmapAABench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/PaintParamsKeyTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/ganesh/image/GrImageUtils.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/VkHardwareBufferTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_MakeRaster_2.cpp
[add] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/include/android/SkSurfaceAndroid.h
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/include/core/SkSurface.h
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ImageFilterTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_notifyContentWillChange.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrContextOOM.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/skottie2movie.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_props.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/ganesh/surface/BUILD.bazel
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_makeImageSnapshot.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/ganesh/Device.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/VulkanWindowContext.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/bigtileimagefilter.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/kawase_blur_rt.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/image_pict.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/mipmap.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SurfaceTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/imagefiltersscaled.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/hugepath.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ShaderImageFilterTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SkRemoteGlyphCacheTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrStyledShapeTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/GraphiteResourceCacheTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/MetalWindowContext.mm
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/FuzzDrawFunctions.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/DashPathEffectTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/skbug_12212.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SVGDeviceTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/VerticesTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/imgcvt.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/win/RasterWindowContext_win.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/unix/RasterWindowContext_unix.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/VkYcbcrSamplerTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/localmatrixshader.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/ToolUtils.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_MakeRenderTarget_2.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/f16to8888drawImageBug.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/BackendTextureTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/emboss.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrDDLImageTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/imagesource2.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/Skbug6389.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_peekPixels.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GpuDrawPathTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/image/SkSurface_Raster.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_readPixels_2.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/LazyStencilAttachmentTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/imagemasksubset.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/modules/skottie/tests/Image.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/graphite/Device.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/bug6783.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/encode_color_types.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_draw_2.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/GLWindowContext.cpp
[add] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/relnotes/sksurface_namespace.md
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/viewer/TimingSlide.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/orientation.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_MakeRasterN32Premul.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/crbug_224618.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/codec/SkPixmapUtils.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/alphaimage_shader_colorfilter.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/morphology.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_makeSurface.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/experimental/ffmpeg/SkVideoEncoder.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrTextureMipMapInvalidationTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/MultiPictureDocumentTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/nanobench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_MakeRaster.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gn/gpu.gni
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Canvas_makeSurface.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/imagefromyuvtextures.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/GrMipmapBench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/WritePixelsTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/RecordingXfermodeTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzSKP.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/TextBlobCacheTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/imagefiltersclipped.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ResourceAllocatorTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/modules/skottie/src/SkottieTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/public.bzl
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/viewer/ThinAASlide.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/graphite/Surface_Graphite.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/include/gpu/ganesh/SkSurfaceGanesh.h
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/MatrixColorFilterTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/color4f.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/drawimageset.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ClearTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrSubmittedFlushTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_MakeRenderTarget.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/UpdateBackendTextureTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/graphite/Image_Graphite.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/ganesh/surface/SkSurface_Ganesh.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/transparency.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/gpu/YUVUtils.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/RecordDrawTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/GraphiteMetalWindowContext.mm
[add] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/include/gpu/ganesh/mtl/BUILD.bazel
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SkRuntimeEffectTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/viewer/Viewer.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/core/SkPixmapDraw.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/50_percent_srgb.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/DeferredDisplayListTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/purplestamp.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzSkRuntimeEffect.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzSVG.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/srcmode.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/MipMapTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SkResourceCacheTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/mac_aa_explorer.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/overdrawcanvas.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_draw.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/RuntimeBlendTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/ColorFilterBench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/dm/DMSrcSink.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/BackendAllocationTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/blur4444.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/anisotropic.cpp
[add] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/include/gpu/ganesh/mtl/SkSurfaceMetal.h
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/rsxtext.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_MakeRenderTarget_3.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/modules/skottie/src/SkottieTool.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/modules/canvaskit/canvaskit_bindings.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/DawnWindowContext.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/f16to8888busted.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/CanvasTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/ShaderMaskFilterBench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/mac/RasterWindowContext_mac.mm
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/dftext.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/clipshader.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/dftext_blob_persp.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/yuv420_odd_dim.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_MakeFromBackendTexture.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/GraphiteDawnWindowContext.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/pictureshadercache.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/asyncrescaleandread.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/RecordingOrderTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/core/SkRuntimeEffect.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/example/VulkanBasic.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/fiddle/fiddle_main.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_characterize.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SaveLayerOriginTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/runtimecolorfilter.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/FuzzCanvas.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/skiaserve/Request.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/runtimeshader.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/CompressedBackendAllocationTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GradientTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/discard.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/postercircle.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/PictureShaderTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/ios/RasterWindowContext_ios.mm
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SrcSrcOverBatchTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/window/GLWindowContext.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_MakeRasterDirect.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/viewer/TextureUploadSlide.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/TextureBindingsResetTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/VkDrawableTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bazel/exporter_tool/main.go
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SurfaceSemaphoreTest.cpp
https://skia.googlesource.com/skia/+/5c93acf313d1cf72f8b73886168bd925b5011b8c
commit 5c93acf313d1cf72f8b73886168bd925b5011b8c
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue May 09 16:11:43 2023
Move SkSurface factories to SkSurfaces namespace
* SkSurface::MakeFromAHardwareBuffer -> SkSurfaces::WrapAndroidHardwareBuffer
* SkSurface::MakeFromBackendRenderTarget -> SkSurfaces::WrapBackendRenderTarget
* SkSurface::MakeFromBackendTexture -> SkSurfaces::WrapBackendTexture
* SkSurface::MakeFromCAMetalLayer -> SkSurfaces::WrapCAMetalLayer
* SkSurface::MakeFromMTKView -> SkSurfaces::WrapMTKView
* SkSurface::MakeGraphite -> SkSurfaces::RenderTarget
* SkSurface::MakeGraphiteFromBackendTexture -> SkSurfaces::WrapBackendTexture
* SkSurface::MakeRaster -> SkSurfaces::Raster
* SkSurface::MakeRasterDirect -> SkSurfaces::WrapPixels
* SkSurface::MakeRasterDirectReleaseProc -> SkSurfaces::WrapPixels
* SkSurface::MakeRasterN32Premul -> SkSurfaces::Raster
* SkSurface::MakeRenderTarget -> SkSurfaces::RenderTarget
Suggested review order:
- include/*
- src/gpu/ganesh/surface/SkSurface_Ganesh.cpp
- src/image/SkSurface_Raster.cpp
- src/image/SkSurface.cpp
- All other changes which were mostly find-replace followed
by `git clang-format origin/main`
Change-Id: Idb18ab5c2beb12d8b4ec6712e9abee286646424f
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/687639
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/win/D3D12WindowContext_win.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/TextBlobTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_writePixels_2.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/imagefilterscropped.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/fm/fm.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ColorFilterTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/RepeatedClippedBlurTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/debugger/DebugLayerManager.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/RecordingSurfacesTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ImageNewShaderTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/image_shader.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_writePixels.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ClipCubicTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/core/SkBitmapDevice.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzPathDeserialize.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/DrawTextTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/FuzzGradients.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ImageTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/RectTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/skpbench/skpbench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/imagefilterstransformed.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/imagemakewithfilter.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/runtimeintrinsics.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/ImageFilterCollapse.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/android/RasterWindowContext_android.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SerialProcsTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/experimental/webgpu-bazel/src/bindings.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzAnimatedImage.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrThreadSafeCacheTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/skottie_ios_app/SkMetalViewBridge.mm
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/drawminibitmaprect.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/ImageBench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrSlugTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/DDLTileHelper.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_makeImageSnapshot_2.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/GraphitePromiseImageTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/image.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/arithmode.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/flippity.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/modules/canvaskit/gm_bindings.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/textblobmixedsizes.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/ganesh/GrGpu.h
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/Skbug5221.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Image_MakeBackendTextureFromImage.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/convexpolyclip.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/croppedrects.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ExtendedSkColorTypeTests.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrMipMappedTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrOpListFlushTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/TextureStripAtlasManagerTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/FuzzCreateDDL.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/bicubic.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrSurfaceResolveTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/resizeimagefilter.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzTextBlobDeserialize.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/modules/svg/utils/SvgTool.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/RecordOptsTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/CanvasStateTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/rewrite_includes.py
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/gpu_blur_utils.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/showmiplevels.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/image/SkRescaleAndReadPixels.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Image_isOpaque.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/filterfastbounds.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/image/SkPictureImageGenerator.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/PremulAlphaRoundTripTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/dropshadowimagefilter.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/50_percent_gray.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrFinishedFlushTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrAHardwareBufferTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/pdf/SkPDFShader.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ImageIsOpaqueTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_readPixels.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_readPixels_3.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/Skbug6653.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/bitmaprect.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/matrixconvolution.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SamplingTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/DrawPathTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_MakeRasterDirectReleaseProc.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/BlurTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/dstreadshuffle.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/ImageShaderTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/MutableImagesTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/path_stroke_with_zero_length.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/blob_cache_sim.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/shader_alphaimage.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/EncodeTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzImage.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/fiddle/draw.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/crbug_905548.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/skottie_ios_app/SkiaGLContext.mm
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/MergeBench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/modules/jetski/src/Surface.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/rasterhandleallocator.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/RecorderTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/PathTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/viewer/QuadStrokerSlide.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GLBackendSurfaceTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SkSLES2ConformanceTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/ReadWritePixelsGraphiteTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/ganesh/surface/SkSurface_GaneshMtl.mm
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzCOLRv1.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/verylargebitmap.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/Skbug12214.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/imagefilterscropexpand.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/IndexedPngOverflowTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/surface.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/DMSAATest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_getCanvas.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/window/VulkanWindowContext.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/ClipMaskBench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/viewer/FatBitsSlide.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ApplyGammaTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/pathfill.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/MultisampleTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzAndroidCodec.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SerializationTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/fonts/TestSVGTypeface.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/gpu/BackendSurfaceFactory.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzRegionDeserialize.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/DisplacementBench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/fatpathfill.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/PinnedImageTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/PromiseImageTest.cpp
[add] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/ganesh/surface/SkSurface_AndroidFactories.cpp
[add] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/include/gpu/graphite/Surface.h
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/platform_tools/android/apps/skottie/skottielib/src/main/cpp/native-lib.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/crop_imagefilter.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/viewer/AtlasSlide.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SkSLTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrTextBlobTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/ImageProviderTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/DrawBitmapAABench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/PaintParamsKeyTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/ganesh/image/GrImageUtils.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/VkHardwareBufferTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_MakeRaster_2.cpp
[add] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/include/android/SkSurfaceAndroid.h
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/include/core/SkSurface.h
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ImageFilterTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_notifyContentWillChange.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrContextOOM.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/skottie2movie.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_props.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/ganesh/surface/BUILD.bazel
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_makeImageSnapshot.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/ganesh/Device.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/VulkanWindowContext.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/bigtileimagefilter.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/kawase_blur_rt.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/image_pict.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/mipmap.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SurfaceTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/imagefiltersscaled.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ReadPixelsTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/hugepath.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ShaderImageFilterTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SkRemoteGlyphCacheTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrStyledShapeTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/GraphiteResourceCacheTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/MetalWindowContext.mm
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/FuzzDrawFunctions.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/DashPathEffectTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/skbug_12212.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SVGDeviceTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/VerticesTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/imgcvt.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/win/RasterWindowContext_win.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/unix/RasterWindowContext_unix.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/VkYcbcrSamplerTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/localmatrixshader.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/ToolUtils.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_MakeRenderTarget_2.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/f16to8888drawImageBug.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/BackendTextureTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/emboss.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrDDLImageTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/imagesource2.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/Skbug6389.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_peekPixels.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GpuDrawPathTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ReadWritePixelsGpuTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/image/SkSurface_Raster.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_readPixels_2.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/LazyStencilAttachmentTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/imagemasksubset.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/modules/skottie/tests/Image.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/graphite/Device.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/bug6783.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/encode_color_types.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_draw_2.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/GLWindowContext.cpp
[add] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/relnotes/sksurface_namespace.md
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/viewer/TimingSlide.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/orientation.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_MakeRasterN32Premul.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/crbug_224618.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/codec/SkPixmapUtils.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/alphaimage_shader_colorfilter.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/morphology.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_makeSurface.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/experimental/ffmpeg/SkVideoEncoder.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrTextureMipMapInvalidationTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/MultiPictureDocumentTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/nanobench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_MakeRaster.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gn/gpu.gni
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Canvas_makeSurface.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/imagefromyuvtextures.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/GrMipmapBench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/WritePixelsTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/RecordingXfermodeTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzSKP.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/TextBlobCacheTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/imagefiltersclipped.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ResourceAllocatorTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/modules/skottie/src/SkottieTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/public.bzl
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/viewer/ThinAASlide.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/graphite/Surface_Graphite.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/include/gpu/ganesh/SkSurfaceGanesh.h
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/MatrixColorFilterTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/color4f.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/drawimageset.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/ClearTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GrSubmittedFlushTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_MakeRenderTarget.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/UpdateBackendTextureTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/graphite/Image_Graphite.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/gpu/ganesh/surface/SkSurface_Ganesh.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/transparency.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/gpu/YUVUtils.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/RecordDrawTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/GraphiteMetalWindowContext.mm
[add] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/include/gpu/ganesh/mtl/BUILD.bazel
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SkRuntimeEffectTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/viewer/Viewer.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/core/SkPixmapDraw.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/50_percent_srgb.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/DeferredDisplayListTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/purplestamp.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzSkRuntimeEffect.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/oss_fuzz/FuzzSVG.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/srcmode.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/MipMapTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SkResourceCacheTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/mac_aa_explorer.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/overdrawcanvas.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_draw.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/RuntimeBlendTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/ColorFilterBench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/dm/DMSrcSink.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/BackendAllocationTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/blur4444.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/anisotropic.cpp
[add] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/include/gpu/ganesh/mtl/SkSurfaceMetal.h
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/rsxtext.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_MakeRenderTarget_3.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/modules/skottie/src/SkottieTool.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/modules/canvaskit/canvaskit_bindings.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/DawnWindowContext.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/f16to8888busted.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/CanvasTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bench/ShaderMaskFilterBench.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/mac/RasterWindowContext_mac.mm
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/dftext.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/clipshader.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/dftext_blob_persp.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/yuv420_odd_dim.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_MakeFromBackendTexture.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/GraphiteDawnWindowContext.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/pictureshadercache.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/asyncrescaleandread.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/graphite/RecordingOrderTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/src/core/SkRuntimeEffect.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/example/VulkanBasic.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/fiddle/fiddle_main.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_characterize.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SaveLayerOriginTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/runtimecolorfilter.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/fuzz/FuzzCanvas.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/skiaserve/Request.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/runtimeshader.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/CompressedBackendAllocationTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/GradientTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/discard.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/gm/postercircle.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/PictureShaderTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/sk_app/ios/RasterWindowContext_ios.mm
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SrcSrcOverBatchTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/window/GLWindowContext.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/docs/examples/Surface_MakeRasterDirect.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tools/viewer/TextureUploadSlide.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/TextureBindingsResetTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/VkDrawableTest.cpp
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/bazel/exporter_tool/main.go
[modify] https://crrev.com/5c93acf313d1cf72f8b73886168bd925b5011b8c/tests/SurfaceSemaphoreTest.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #124
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/539fb10d7cfb3e73ae43bdedba7d11b2012f5446
commit 539fb10d7cfb3e73ae43bdedba7d11b2012f5446
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu May 11 17:54:20 2023
Move SkSurface::MakeNull to SkSurfaces::Null
Follow-up to https://skia-review.googlesource.com/c/skia/+/687639
Change-Id: I19c01a0c3957460d6c79c9edb2ddabd4c8c2d2cf
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/696537
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/539fb10d7cfb3e73ae43bdedba7d11b2012f5446/fuzz/FuzzDrawFunctions.cpp
[modify] https://crrev.com/539fb10d7cfb3e73ae43bdedba7d11b2012f5446/docs/examples/Surface_height.cpp
[modify] https://crrev.com/539fb10d7cfb3e73ae43bdedba7d11b2012f5446/src/image/SkSurface_Null.cpp
[modify] https://crrev.com/539fb10d7cfb3e73ae43bdedba7d11b2012f5446/relnotes/sksurface_namespace.md
[modify] https://crrev.com/539fb10d7cfb3e73ae43bdedba7d11b2012f5446/tests/SurfaceTest.cpp
[modify] https://crrev.com/539fb10d7cfb3e73ae43bdedba7d11b2012f5446/include/core/SkSurface.h
[modify] https://crrev.com/539fb10d7cfb3e73ae43bdedba7d11b2012f5446/docs/examples/Surface_width.cpp
[modify] https://crrev.com/539fb10d7cfb3e73ae43bdedba7d11b2012f5446/docs/examples/Surface_MakeNull.cpp
https://skia.googlesource.com/skia/+/539fb10d7cfb3e73ae43bdedba7d11b2012f5446
commit 539fb10d7cfb3e73ae43bdedba7d11b2012f5446
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu May 11 17:54:20 2023
Move SkSurface::MakeNull to SkSurfaces::Null
Follow-up to https://skia-review.googlesource.com/c/skia/+/687639
Change-Id: I19c01a0c3957460d6c79c9edb2ddabd4c8c2d2cf
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/696537
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/539fb10d7cfb3e73ae43bdedba7d11b2012f5446/fuzz/FuzzDrawFunctions.cpp
[modify] https://crrev.com/539fb10d7cfb3e73ae43bdedba7d11b2012f5446/docs/examples/Surface_height.cpp
[modify] https://crrev.com/539fb10d7cfb3e73ae43bdedba7d11b2012f5446/src/image/SkSurface_Null.cpp
[modify] https://crrev.com/539fb10d7cfb3e73ae43bdedba7d11b2012f5446/relnotes/sksurface_namespace.md
[modify] https://crrev.com/539fb10d7cfb3e73ae43bdedba7d11b2012f5446/tests/SurfaceTest.cpp
[modify] https://crrev.com/539fb10d7cfb3e73ae43bdedba7d11b2012f5446/include/core/SkSurface.h
[modify] https://crrev.com/539fb10d7cfb3e73ae43bdedba7d11b2012f5446/docs/examples/Surface_width.cpp
[modify] https://crrev.com/539fb10d7cfb3e73ae43bdedba7d11b2012f5446/docs/examples/Surface_MakeNull.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #125
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9
commit 682f84e1ca3c72fdbd77e2bd3d8151310e4726d9
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri May 12 14:11:00 2023
Migrate uses of SkSurface factories
In http://review.skia.org/687639, many SkSurface static methods
were moved and one was deleted (SkSurface::MakeRasterN32Premul).
This changes the calls in Chromium to match those moved functions.
There should be no functional difference and everything was done
pretty mechanically (e.g. find and replace, regexes, git cl format).
Bug: skia:13983
Change-Id: Iffbfae6b03bd002fe833ae994089318b051b0d43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4518554
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1143250}
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/media/renderers/video_frame_yuv_converter.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/modules/webcodecs/video_frame_test.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/base/x/x11_software_bitmap_presenter.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/ozone/platform/wayland/gpu/wayland_canvas_surface.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator_test.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/ozone/platform/drm/gpu/mock_drm_device.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/chrome/browser/vr/native_gl_surface_provider.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/layout/layout_video_test.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/paint/display_item_list_unittest.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/platform/graphics/deferred_image_decoder_test_wo_platform.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/ozone/demo/skia/skia_surfaceless_gl_renderer.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/raster/raster_buffer_provider.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/ozone/demo/skia/skia_gl_renderer.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/paint/paint_shader_unittest.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/layers/heads_up_display_layer_impl.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/media/renderers/video_frame_yuv_mailboxes_holder.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/android_webview/test/shell/src/draw_fn/context_manager.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/chrome/browser/vr/cmd_buffer_surface_provider.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/testing/libfuzzer/fuzzers/skia_path_fuzzer.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_serializer_test.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/gfx/color_conversion_sk_filter_cache.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/ozone/platform/drm/gpu/drm_dumb_buffer.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/paint/timing/image_paint_timing_detector_test.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/ozone/platform/headless/headless_surface_factory.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/content/browser/gpu/gpu_ipc_browsertests.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/layout/shapes/shape.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/gfx/linux/gbm_wrapper.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/ozone/platform/flatland/flatland_surface_canvas.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/trees/layer_tree_host_pixeltest_blending.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/pdf/paint_manager.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/platform/graphics/image.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/paint/timing/largest_contentful_paint_calculator_test.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/page/drag_image_test.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/paint/paint_op_buffer_fuzzer.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/paint/timing/image_element_timing_test.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/ozone/platform/scenic/scenic_window_canvas.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/clipboard/data_transfer.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/platform/image-decoders/image_frame.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/tiles/gpu_image_decode_cache_perftest.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/trees/layer_tree_host_pixeltest_masks.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/skia/ext/skottie_unittest.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/platform/graphics/gpu/xr_webgl_drawing_buffer.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/ozone/platform/wayland/common/wayland_util.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/imagebitmap/image_bitmap_test.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/skia/ext/skia_utils_win.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/pdf/test/test_helpers.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
https://chromium.googlesource.com/chromium/src/+/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9
commit 682f84e1ca3c72fdbd77e2bd3d8151310e4726d9
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri May 12 14:11:00 2023
Migrate uses of SkSurface factories
In http://review.skia.org/687639, many SkSurface static methods
were moved and one was deleted (SkSurface::MakeRasterN32Premul).
This changes the calls in Chromium to match those moved functions.
There should be no functional difference and everything was done
pretty mechanically (e.g. find and replace, regexes, git cl format).
Bug: skia:13983
Change-Id: Iffbfae6b03bd002fe833ae994089318b051b0d43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4518554
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1143250}
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/media/renderers/video_frame_yuv_converter.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/modules/webcodecs/video_frame_test.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/base/x/x11_software_bitmap_presenter.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/ozone/platform/wayland/gpu/wayland_canvas_surface.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator_test.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/ozone/platform/drm/gpu/mock_drm_device.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/chrome/browser/vr/native_gl_surface_provider.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/layout/layout_video_test.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/paint/display_item_list_unittest.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/platform/graphics/deferred_image_decoder_test_wo_platform.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/ozone/demo/skia/skia_surfaceless_gl_renderer.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/raster/raster_buffer_provider.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/ozone/demo/skia/skia_gl_renderer.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/paint/paint_shader_unittest.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/layers/heads_up_display_layer_impl.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/media/renderers/video_frame_yuv_mailboxes_holder.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/android_webview/test/shell/src/draw_fn/context_manager.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/chrome/browser/vr/cmd_buffer_surface_provider.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/testing/libfuzzer/fuzzers/skia_path_fuzzer.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_serializer_test.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/gfx/color_conversion_sk_filter_cache.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/ozone/platform/drm/gpu/drm_dumb_buffer.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/paint/timing/image_paint_timing_detector_test.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/ozone/platform/headless/headless_surface_factory.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/content/browser/gpu/gpu_ipc_browsertests.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/layout/shapes/shape.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/gfx/linux/gbm_wrapper.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/ozone/platform/flatland/flatland_surface_canvas.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/trees/layer_tree_host_pixeltest_blending.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/pdf/paint_manager.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/platform/graphics/image.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/paint/timing/largest_contentful_paint_calculator_test.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/page/drag_image_test.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/paint/paint_op_buffer_fuzzer.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/paint/timing/image_element_timing_test.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/ozone/platform/scenic/scenic_window_canvas.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/clipboard/data_transfer.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/platform/image-decoders/image_frame.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/tiles/gpu_image_decode_cache_perftest.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/trees/layer_tree_host_pixeltest_masks.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/skia/ext/skottie_unittest.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/platform/graphics/gpu/xr_webgl_drawing_buffer.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/ui/ozone/platform/wayland/common/wayland_util.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/imagebitmap/image_bitmap_test.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/skia/ext/skia_utils_win.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/pdf/test/test_helpers.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/682f84e1ca3c72fdbd77e2bd3d8151310e4726d9/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #126
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/671644d008ea54d606ad6105121f6e25b83b613e
commit 671644d008ea54d606ad6105121f6e25b83b613e
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri May 12 16:32:00 2023
Migrate more uses of SkSurface factories
Part 2 of https://crrev.com/c/4518554
Bug: skia:13983
Change-Id: Ie2e25a55fad036e5d145325e16961f5aa7f80965
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4523129
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1143312}
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/third_party/blink/renderer/core/messaging/blink_transferable_message_mojom_traits_test.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/angle_vulkan_image_backing.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/external_vk_image_skia_representation.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/wrapped_graphite_texture_backing.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display_embedder/skia_output_device_dcomp.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/skia_graphite_dawn_image_representation.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display_embedder/image_context_impl.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/skia_vk_android_image_representation.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/wrapped_sk_image_backing.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display_embedder/skia_output_device_vulkan.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display_embedder/software_output_device_ozone_unittest.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/third_party/blink/renderer/modules/imagecapture/image_capture_frame_grabber.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display_embedder/skia_output_device_offscreen.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/copy_shared_image_helper.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/raw_draw_image_backing.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display/software_output_device.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/test/fake_skia_output_surface.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/dcomp_surface_image_backing.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/test_image_backing.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/exo/wayland/clients/blur.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/d3d_image_backing_factory_unittest.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/skia/BUILD.gn
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display_embedder/skia_output_device_dawn.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/third_party/blink/renderer/modules/document_picture_in_picture/picture_in_picture_controller_test.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display_embedder/skia_output_device_webview.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/third_party/blink/renderer/modules/canvas/offscreencanvas/OffscreenCanvas-commit.md
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/skia_vk_ozone_image_representation.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display_embedder/skia_output_device_gl.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/exo/wayland/clients/client_base.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/iosurface_image_backing.mm
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/skia_gl_image_representation.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/gl_texture_common_representations.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display/software_renderer.cc
https://chromium.googlesource.com/chromium/src/+/671644d008ea54d606ad6105121f6e25b83b613e
commit 671644d008ea54d606ad6105121f6e25b83b613e
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri May 12 16:32:00 2023
Migrate more uses of SkSurface factories
Part 2 of https://crrev.com/c/4518554
Bug: skia:13983
Change-Id: Ie2e25a55fad036e5d145325e16961f5aa7f80965
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4523129
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1143312}
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/third_party/blink/renderer/core/messaging/blink_transferable_message_mojom_traits_test.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/angle_vulkan_image_backing.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/external_vk_image_skia_representation.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/wrapped_graphite_texture_backing.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display_embedder/skia_output_device_dcomp.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/skia_graphite_dawn_image_representation.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display_embedder/image_context_impl.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/skia_vk_android_image_representation.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/wrapped_sk_image_backing.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display_embedder/skia_output_device_vulkan.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display_embedder/software_output_device_ozone_unittest.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/third_party/blink/renderer/modules/imagecapture/image_capture_frame_grabber.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display_embedder/skia_output_device_offscreen.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/copy_shared_image_helper.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/raw_draw_image_backing.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display/software_output_device.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/test/fake_skia_output_surface.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/dcomp_surface_image_backing.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/test_image_backing.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/exo/wayland/clients/blur.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/d3d_image_backing_factory_unittest.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/skia/BUILD.gn
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display_embedder/skia_output_device_dawn.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/third_party/blink/renderer/modules/document_picture_in_picture/picture_in_picture_controller_test.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display_embedder/skia_output_device_webview.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/third_party/blink/renderer/modules/canvas/offscreencanvas/OffscreenCanvas-commit.md
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/skia_vk_ozone_image_representation.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display_embedder/skia_output_device_gl.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/exo/wayland/clients/client_base.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/iosurface_image_backing.mm
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/skia_gl_image_representation.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/gpu/command_buffer/service/shared_image/gl_texture_common_representations.cc
[modify] https://crrev.com/671644d008ea54d606ad6105121f6e25b83b613e/components/viz/service/display/software_renderer.cc
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #127
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/32f2606a1ebe97e5b9b95c89860b503d2ba3f292
commit 32f2606a1ebe97e5b9b95c89860b503d2ba3f292
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 15 14:28:25 2023
Fix legacy SkSurface::MakeNull call
This prevents us from setting SK_DISABLE_LEGACY_SKSURFACE_FACTORIES
Change-Id: I75971bcfcc2290f2e6c34a67d16ecc7e86acf6af
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/698058
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/32f2606a1ebe97e5b9b95c89860b503d2ba3f292/src/image/SkSurface_Null.cpp
https://skia.googlesource.com/skia/+/32f2606a1ebe97e5b9b95c89860b503d2ba3f292
commit 32f2606a1ebe97e5b9b95c89860b503d2ba3f292
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 15 14:28:25 2023
Fix legacy SkSurface::MakeNull call
This prevents us from setting SK_DISABLE_LEGACY_SKSURFACE_FACTORIES
Change-Id: I75971bcfcc2290f2e6c34a67d16ecc7e86acf6af
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/698058
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/32f2606a1ebe97e5b9b95c89860b503d2ba3f292/src/image/SkSurface_Null.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #128
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/48bb742b07579762a12c9801d4ec245f35f5e999
commit 48bb742b07579762a12c9801d4ec245f35f5e999
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 15 15:40:18 2023
Use relocated SkImages context typedefs
In http://review.skia.org/661059, we moved many SkImage related
methods, including these typedefs. This updates Chromium to use
the moved types.
Bug: skia:13983
Change-Id: Ie4b033fcb49e4dc5551c0d7d896f232f60e27631
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4521842
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1144128}
[modify] https://crrev.com/48bb742b07579762a12c9801d4ec245f35f5e999/gpu/command_buffer/service/shared_image/shared_image_representation.h
[modify] https://crrev.com/48bb742b07579762a12c9801d4ec245f35f5e999/cc/paint/image_transfer_cache_entry_unittest.cc
[modify] https://crrev.com/48bb742b07579762a12c9801d4ec245f35f5e999/gpu/ipc/service/image_decode_accelerator_stub.cc
[modify] https://crrev.com/48bb742b07579762a12c9801d4ec245f35f5e999/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/48bb742b07579762a12c9801d4ec245f35f5e999/gpu/command_buffer/service/shared_image/shared_image_representation.cc
[modify] https://crrev.com/48bb742b07579762a12c9801d4ec245f35f5e999/cc/paint/image_transfer_cache_entry.cc
https://chromium.googlesource.com/chromium/src/+/48bb742b07579762a12c9801d4ec245f35f5e999
commit 48bb742b07579762a12c9801d4ec245f35f5e999
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 15 15:40:18 2023
Use relocated SkImages context typedefs
In http://review.skia.org/661059, we moved many SkImage related
methods, including these typedefs. This updates Chromium to use
the moved types.
Bug: skia:13983
Change-Id: Ie4b033fcb49e4dc5551c0d7d896f232f60e27631
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4521842
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1144128}
[modify] https://crrev.com/48bb742b07579762a12c9801d4ec245f35f5e999/gpu/command_buffer/service/shared_image/shared_image_representation.h
[modify] https://crrev.com/48bb742b07579762a12c9801d4ec245f35f5e999/cc/paint/image_transfer_cache_entry_unittest.cc
[modify] https://crrev.com/48bb742b07579762a12c9801d4ec245f35f5e999/gpu/ipc/service/image_decode_accelerator_stub.cc
[modify] https://crrev.com/48bb742b07579762a12c9801d4ec245f35f5e999/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/48bb742b07579762a12c9801d4ec245f35f5e999/gpu/command_buffer/service/shared_image/shared_image_representation.cc
[modify] https://crrev.com/48bb742b07579762a12c9801d4ec245f35f5e999/cc/paint/image_transfer_cache_entry.cc
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #129
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/d26f042bb364f459bd2eb82cf91eb910d2466c70
commit d26f042bb364f459bd2eb82cf91eb910d2466c70
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 15 19:03:53 2023
SkSurface::MakeNull -> SkSurfaces::Null
API change happened in https://skia-review.googlesource.com/c/skia/+/696537
Change-Id: Ie0ffbe66d83004f7a6fea1a7e1d23ddc8ae7c300
Bug: skia:13983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4532575
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1144281}
[modify] https://crrev.com/d26f042bb364f459bd2eb82cf91eb910d2466c70/ui/ozone/platform/cast/surface_factory_cast.cc
https://chromium.googlesource.com/chromium/src/+/d26f042bb364f459bd2eb82cf91eb910d2466c70
commit d26f042bb364f459bd2eb82cf91eb910d2466c70
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 15 19:03:53 2023
SkSurface::MakeNull -> SkSurfaces::Null
API change happened in https://skia-review.googlesource.com/c/skia/+/696537
Change-Id: Ie0ffbe66d83004f7a6fea1a7e1d23ddc8ae7c300
Bug: skia:13983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4532575
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1144281}
[modify] https://crrev.com/d26f042bb364f459bd2eb82cf91eb910d2466c70/ui/ozone/platform/cast/surface_factory_cast.cc
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #130
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/5a3cae2a9dbba6bde350ee93c91c4246a8f9e524
commit 5a3cae2a9dbba6bde350ee93c91c4246a8f9e524
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 15 19:46:10 2023
Remove one more legacy SkSurface factory
Change-Id: Ib68429cad836ad96486b477f0f5462d83a110f99
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/698315
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/5a3cae2a9dbba6bde350ee93c91c4246a8f9e524/src/gpu/graphite/ImageFactories.cpp
https://skia.googlesource.com/skia/+/5a3cae2a9dbba6bde350ee93c91c4246a8f9e524
commit 5a3cae2a9dbba6bde350ee93c91c4246a8f9e524
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon May 15 19:46:10 2023
Remove one more legacy SkSurface factory
Change-Id: Ib68429cad836ad96486b477f0f5462d83a110f99
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/698315
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/5a3cae2a9dbba6bde350ee93c91c4246a8f9e524/src/gpu/graphite/ImageFactories.cpp
kj...@google.com <kj...@google.com> #131
[Empty comment from Monorail migration]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #132
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/9ca6646e9f1d4146cd9612e25ec3fb28b18693a9
commit 9ca6646e9f1d4146cd9612e25ec3fb28b18693a9
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed May 17 14:33:52 2023
Delete unused shim image factory code
This should have been deleted in
https://skia-review.googlesource.com/c/skia/+/668596
Change-Id: Ic2e935d40ee330cf9e4e79b4e156f19ddf108275
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/699537
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/9ca6646e9f1d4146cd9612e25ec3fb28b18693a9/src/image/SkImage_AndroidFactories.cpp
https://skia.googlesource.com/skia/+/9ca6646e9f1d4146cd9612e25ec3fb28b18693a9
commit 9ca6646e9f1d4146cd9612e25ec3fb28b18693a9
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed May 17 14:33:52 2023
Delete unused shim image factory code
This should have been deleted in
https://skia-review.googlesource.com/c/skia/+/668596
Change-Id: Ic2e935d40ee330cf9e4e79b4e156f19ddf108275
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/699537
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/9ca6646e9f1d4146cd9612e25ec3fb28b18693a9/src/image/SkImage_AndroidFactories.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #133
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/280b58560f3430b5eecd223d69ff792682dd6d15
commit 280b58560f3430b5eecd223d69ff792682dd6d15
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri May 19 15:09:24 2023
Remove legacy SkSurface factories
All clients have been migrated, e.g.:
- https://crrev.com/c/4518554
- http://ag/23214919
- https://github.com/flutter/engine/pull/42158
- http://ag/23339542
Canary-Android-Topic: remove-surfaces
Bug: skia:13983
Change-Id: I5f48f7c4c9ad6bbfbd08f5666dd6d4eb63bd6a8a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/700223
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/280b58560f3430b5eecd223d69ff792682dd6d15/src/gpu/graphite/Surface_Graphite.cpp
[modify] https://crrev.com/280b58560f3430b5eecd223d69ff792682dd6d15/src/image/SkSurface_Null.cpp
[modify] https://crrev.com/280b58560f3430b5eecd223d69ff792682dd6d15/src/gpu/graphite/ImageFactories.cpp
[modify] https://crrev.com/280b58560f3430b5eecd223d69ff792682dd6d15/include/core/SkSurface.h
[modify] https://crrev.com/280b58560f3430b5eecd223d69ff792682dd6d15/src/image/SkSurface_Raster.cpp
[modify] https://crrev.com/280b58560f3430b5eecd223d69ff792682dd6d15/src/gpu/ganesh/surface/SkSurface_Ganesh.cpp
[modify] https://crrev.com/280b58560f3430b5eecd223d69ff792682dd6d15/src/gpu/ganesh/surface/SkSurface_GaneshMtl.mm
[modify] https://crrev.com/280b58560f3430b5eecd223d69ff792682dd6d15/src/gpu/ganesh/surface/SkSurface_AndroidFactories.cpp
[modify] https://crrev.com/280b58560f3430b5eecd223d69ff792682dd6d15/src/image/SkImage_AndroidFactories.cpp
https://skia.googlesource.com/skia/+/280b58560f3430b5eecd223d69ff792682dd6d15
commit 280b58560f3430b5eecd223d69ff792682dd6d15
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri May 19 15:09:24 2023
Remove legacy SkSurface factories
All clients have been migrated, e.g.:
- https://crrev.com/c/4518554
- http://ag/23214919
- https://github.com/flutter/engine/pull/42158
- http://ag/23339542
Canary-Android-Topic: remove-surfaces
Bug: skia:13983
Change-Id: I5f48f7c4c9ad6bbfbd08f5666dd6d4eb63bd6a8a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/700223
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/280b58560f3430b5eecd223d69ff792682dd6d15/src/gpu/graphite/Surface_Graphite.cpp
[modify] https://crrev.com/280b58560f3430b5eecd223d69ff792682dd6d15/src/image/SkSurface_Null.cpp
[modify] https://crrev.com/280b58560f3430b5eecd223d69ff792682dd6d15/src/gpu/graphite/ImageFactories.cpp
[modify] https://crrev.com/280b58560f3430b5eecd223d69ff792682dd6d15/include/core/SkSurface.h
[modify] https://crrev.com/280b58560f3430b5eecd223d69ff792682dd6d15/src/image/SkSurface_Raster.cpp
[modify] https://crrev.com/280b58560f3430b5eecd223d69ff792682dd6d15/src/gpu/ganesh/surface/SkSurface_Ganesh.cpp
[modify] https://crrev.com/280b58560f3430b5eecd223d69ff792682dd6d15/src/gpu/ganesh/surface/SkSurface_GaneshMtl.mm
[modify] https://crrev.com/280b58560f3430b5eecd223d69ff792682dd6d15/src/gpu/ganesh/surface/SkSurface_AndroidFactories.cpp
[modify] https://crrev.com/280b58560f3430b5eecd223d69ff792682dd6d15/src/image/SkImage_AndroidFactories.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #134
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/c80e566b30f6b35ea1b08b7794b3a894deaee47c
commit c80e566b30f6b35ea1b08b7794b3a894deaee47c
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri May 19 21:05:35 2023
Revert "Remove legacy SkSurface factories"
This reverts commit 280b58560f3430b5eecd223d69ff792682dd6d15.
Reason for revert: Need to land https://github.com/flutter/engine/pull/42158 and have that roll into G3
Original change's description:
https://skia.googlesource.com/skia/+/c80e566b30f6b35ea1b08b7794b3a894deaee47c
commit c80e566b30f6b35ea1b08b7794b3a894deaee47c
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri May 19 21:05:35 2023
Revert "Remove legacy SkSurface factories"
This reverts commit 280b58560f3430b5eecd223d69ff792682dd6d15.
Reason for revert: Need to land https://github.com/flutter/engine/pull/42158 and have that roll into G3
Original change's description:
Bug: skia:13983
Change-Id: Idcab7309af07392c31e19c6ab7a63d6bc9ec0766
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/700798
Owners-Override: Kevin Lubick <kjlubick@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
[modify] https://crrev.com/c80e566b30f6b35ea1b08b7794b3a894deaee47c/src/gpu/graphite/Surface_Graphite.cpp
[modify] https://crrev.com/c80e566b30f6b35ea1b08b7794b3a894deaee47c/src/image/SkSurface_Null.cpp
[modify] https://crrev.com/c80e566b30f6b35ea1b08b7794b3a894deaee47c/src/gpu/graphite/ImageFactories.cpp
[modify] https://crrev.com/c80e566b30f6b35ea1b08b7794b3a894deaee47c/include/core/SkSurface.h
[modify] https://crrev.com/c80e566b30f6b35ea1b08b7794b3a894deaee47c/src/image/SkSurface_Raster.cpp
[modify] https://crrev.com/c80e566b30f6b35ea1b08b7794b3a894deaee47c/src/gpu/ganesh/surface/SkSurface_Ganesh.cpp
[modify] https://crrev.com/c80e566b30f6b35ea1b08b7794b3a894deaee47c/src/gpu/ganesh/surface/SkSurface_GaneshMtl.mm
[modify] https://crrev.com/c80e566b30f6b35ea1b08b7794b3a894deaee47c/src/gpu/ganesh/surface/SkSurface_AndroidFactories.cpp
[modify] https://crrev.com/c80e566b30f6b35ea1b08b7794b3a894deaee47c/src/image/SkImage_AndroidFactories.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #135
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/225d51031ad0737ecf355cd985fa33041a4e9331
commit 225d51031ad0737ecf355cd985fa33041a4e9331
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue May 23 11:04:53 2023
Make codec registration for decoding explicit
Rather than having SkCodec create a list of codecs at compile
time (using #ifdefs), this requires the explicit registration
of codecs by the client. This allows SkCodec.cpp to not directly
have a dependency on all possible Skia codecs and allows clients
to specify their own decoders too.
Until we migrate clients, SkCodecs will automatically register
codecs and registering the same codec twice will just replace the
decoder (so it is safe to have the shim registration and the
new, explicit one).
Most of our Codecs already supported the SkCodecs::Decoder API,
but some required a bit of refactoring (Heif, Raw, Wuffs). I added
a test for SkRawDecoder::IsRaw, since that is new functionality.
As I accidentally broke things, I added some debug asserts to
help me track those down and decided to leave them in to avoid
future issues (or aid future debugging).
Bug: skia:13983
Change-Id: Iba06cc3bb3f59d59a3ae714a8e558bd3b63fdb01
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/689016
Reviewed-by: Leon Scroggins <scroggo@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkPngCodec.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkWuffsCodec.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkJpegxlCodec.cpp
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkBmpDecoder.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkRawCodec.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkWbmpCodec.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkIcoCodec.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/tools/fm/fm.cpp
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkJpegDecoder.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/gm/texelsubset.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/BUILD.bazel
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkBmpCodec.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkWebpCodec.cpp
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/android/SkHeifDecoder.h
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkWebpDecoder.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkCodec.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkCodec.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkJpegCodec.cpp
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkAvifDecoder.h
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkWbmpDecoder.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkHeifCodec.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkHeifCodec.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/bench/nanobench.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/BUILD.bazel
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkGifDecoder.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkAvifCodec.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkWuffsCodec.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/tools/Resources.h
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkJpegxlDecoder.h
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkPngDecoder.h
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/relnotes/skcodecs_register.md
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkRawDecoder.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/dm/DM.cpp
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkIcoDecoder.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/public.bzl
https://skia.googlesource.com/skia/+/225d51031ad0737ecf355cd985fa33041a4e9331
commit 225d51031ad0737ecf355cd985fa33041a4e9331
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue May 23 11:04:53 2023
Make codec registration for decoding explicit
Rather than having SkCodec create a list of codecs at compile
time (using #ifdefs), this requires the explicit registration
of codecs by the client. This allows SkCodec.cpp to not directly
have a dependency on all possible Skia codecs and allows clients
to specify their own decoders too.
Until we migrate clients, SkCodecs will automatically register
codecs and registering the same codec twice will just replace the
decoder (so it is safe to have the shim registration and the
new, explicit one).
Most of our Codecs already supported the SkCodecs::Decoder API,
but some required a bit of refactoring (Heif, Raw, Wuffs). I added
a test for SkRawDecoder::IsRaw, since that is new functionality.
As I accidentally broke things, I added some debug asserts to
help me track those down and decided to leave them in to avoid
future issues (or aid future debugging).
Bug: skia:13983
Change-Id: Iba06cc3bb3f59d59a3ae714a8e558bd3b63fdb01
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/689016
Reviewed-by: Leon Scroggins <scroggo@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkPngCodec.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkWuffsCodec.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkJpegxlCodec.cpp
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkBmpDecoder.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkRawCodec.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkWbmpCodec.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkIcoCodec.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/tools/fm/fm.cpp
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkJpegDecoder.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/gm/texelsubset.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/BUILD.bazel
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkBmpCodec.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkWebpCodec.cpp
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/android/SkHeifDecoder.h
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkWebpDecoder.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkCodec.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkCodec.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkJpegCodec.cpp
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkAvifDecoder.h
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkWbmpDecoder.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkHeifCodec.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkHeifCodec.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/bench/nanobench.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/BUILD.bazel
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkGifDecoder.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkAvifCodec.cpp
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/src/codec/SkWuffsCodec.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/tools/Resources.h
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkJpegxlDecoder.h
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkPngDecoder.h
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/relnotes/skcodecs_register.md
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkRawDecoder.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/dm/DM.cpp
[add] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/include/codec/SkIcoDecoder.h
[modify] https://crrev.com/225d51031ad0737ecf355cd985fa33041a4e9331/public.bzl
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #136
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed
commit 657ed9cf2379a950b925cb2aba7c85d6e1dd36ed
Author: Brian Osman <brianosman@google.com>
Date: Tue May 23 12:40:12 2023
Reland "Replace SkOpts::hash/hash_fn with SkChecksum::Hash32"
This reverts commit fc369d15070f10199e122d0be2d94e060e81d795.
Reason for revert: Added SK_SPI to fix shared library builds
Original change's description:
https://skia.googlesource.com/skia/+/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed
commit 657ed9cf2379a950b925cb2aba7c85d6e1dd36ed
Author: Brian Osman <brianosman@google.com>
Date: Tue May 23 12:40:12 2023
Reland "Replace SkOpts::hash/hash_fn with SkChecksum::Hash32"
This reverts commit fc369d15070f10199e122d0be2d94e060e81d795.
Reason for revert: Added SK_SPI to fix shared library builds
Original change's description:
Bug: skia:13983
Change-Id: Ief2bd9a3573c5abe0569837f96cfd6ac0994e96e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/701856
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/core/SkVMBlitter.cpp
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/gpu/ResourceKey.cpp
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/gpu/graphite/PipelineData.cpp
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/core/SkChecksum.h
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/gpu/ganesh/vk/GrVkSampler.h
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/gn/sksl.gni
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/core/BUILD.bazel
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/gpu/ganesh/d3d/GrD3DResourceProvider.h
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/gpu/ganesh/gl/GrGLGpu.h
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/core/SkDescriptor.cpp
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/core/SkMesh.cpp
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/tools/gpu/MemoryCache.h
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/core/SkVM.cpp
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/gpu/ganesh/ops/SmallPathShapeData.h
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/gpu/ganesh/vk/GrVkSamplerYcbcrConversion.h
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/tests/ChecksumTest.cpp
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/core/SkRuntimeEffect.cpp
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/gpu/ganesh/mtl/GrMtlDepthStencil.h
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/sksl/codegen/SkSLSPIRVCodeGenerator.cpp
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/tests/HashTest.cpp
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/gpu/graphite/PaintParamsKey.h
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/core/SkImageFilterCache.cpp
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/pdf/SkPDFGradientShader.cpp
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/core/SkResourceCache.cpp
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/sksl/ir/SkSLSymbolTable.h
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/gpu/graphite/ShaderCodeDictionary.cpp
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/gpu/ganesh/mtl/GrMtlResourceProvider.h
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/gpu/ganesh/vk/GrVkResourceProvider.h
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/gpu/ganesh/GrDDLContext.cpp
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/tools/UrlDataManager.h
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/gpu/ganesh/d3d/GrD3DResourceProvider.cpp
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/gpu/ganesh/dawn/GrDawnGpu.h
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/core/SkColorSpace.cpp
[modify] https://crrev.com/657ed9cf2379a950b925cb2aba7c85d6e1dd36ed/src/gpu/ganesh/mtl/GrMtlSampler.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #137
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/69f7860093b4ec7971d1e3bee458847aa849c351
commit 69f7860093b4ec7971d1e3bee458847aa849c351
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue May 23 18:27:44 2023
Add placeholders to pdf.gni for SkJpegInfo
We need to land this first to fix Chrome's build rules
Bug: skia:13983
Change-Id: I825e4ade1742836e44089b6b07ce159c5ed0cade
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/702221
Reviewed-by: Ben Wagner <bungeman@google.com>
[modify] https://crrev.com/69f7860093b4ec7971d1e3bee458847aa849c351/gn/pdf.gni
[modify] https://crrev.com/69f7860093b4ec7971d1e3bee458847aa849c351/bazel/exporter/gni_exporter.go
https://skia.googlesource.com/skia/+/69f7860093b4ec7971d1e3bee458847aa849c351
commit 69f7860093b4ec7971d1e3bee458847aa849c351
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue May 23 18:27:44 2023
Add placeholders to pdf.gni for SkJpegInfo
We need to land this first to fix Chrome's build rules
Bug: skia:13983
Change-Id: I825e4ade1742836e44089b6b07ce159c5ed0cade
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/702221
Reviewed-by: Ben Wagner <bungeman@google.com>
[modify] https://crrev.com/69f7860093b4ec7971d1e3bee458847aa849c351/gn/pdf.gni
[modify] https://crrev.com/69f7860093b4ec7971d1e3bee458847aa849c351/bazel/exporter/gni_exporter.go
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #138
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/b5e69114df6d10a6d19be48c83acfa3f7bcaac69
commit b5e69114df6d10a6d19be48c83acfa3f7bcaac69
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri May 19 15:09:24 2023
Reland "Remove legacy SkSurface factories"
This is a reland of commit 280b58560f3430b5eecd223d69ff792682dd6d15
flutter->G3 has landed, so we should be good to go
Original change's description:
https://skia.googlesource.com/skia/+/b5e69114df6d10a6d19be48c83acfa3f7bcaac69
commit b5e69114df6d10a6d19be48c83acfa3f7bcaac69
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri May 19 15:09:24 2023
Reland "Remove legacy SkSurface factories"
This is a reland of commit 280b58560f3430b5eecd223d69ff792682dd6d15
flutter->G3 has landed, so we should be good to go
Original change's description:
Bug: skia:13983
Change-Id: I2f80663d316fc7c81a5909d9dd41b4fc51bc51e7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/701519
Reviewed-by: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/b5e69114df6d10a6d19be48c83acfa3f7bcaac69/src/gpu/graphite/Surface_Graphite.cpp
[modify] https://crrev.com/b5e69114df6d10a6d19be48c83acfa3f7bcaac69/src/image/SkSurface_Null.cpp
[modify] https://crrev.com/b5e69114df6d10a6d19be48c83acfa3f7bcaac69/src/gpu/graphite/ImageFactories.cpp
[modify] https://crrev.com/b5e69114df6d10a6d19be48c83acfa3f7bcaac69/include/core/SkSurface.h
[modify] https://crrev.com/b5e69114df6d10a6d19be48c83acfa3f7bcaac69/src/image/SkSurface_Raster.cpp
[modify] https://crrev.com/b5e69114df6d10a6d19be48c83acfa3f7bcaac69/src/gpu/ganesh/surface/SkSurface_Ganesh.cpp
[modify] https://crrev.com/b5e69114df6d10a6d19be48c83acfa3f7bcaac69/src/gpu/ganesh/surface/SkSurface_GaneshMtl.mm
[modify] https://crrev.com/b5e69114df6d10a6d19be48c83acfa3f7bcaac69/src/image/SkImage_AndroidFactories.cpp
[modify] https://crrev.com/b5e69114df6d10a6d19be48c83acfa3f7bcaac69/src/gpu/ganesh/surface/SkSurface_AndroidFactories.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #139
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/6b21dd5cba02e2bb57ba701def95c76936a362b0
commit 6b21dd5cba02e2bb57ba701def95c76936a362b0
Author: Brian Osman <brianosman@google.com>
Date: Tue May 23 15:38:11 2023
Remove empty SkOpts files (crc32, sse42)
Bug: skia:13983
Change-Id: Ie4de8f8a92cb2c204ac807f4eabdd78311acac00
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/702837
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/6b21dd5cba02e2bb57ba701def95c76936a362b0/gn/opts.gni
[modify] https://crrev.com/6b21dd5cba02e2bb57ba701def95c76936a362b0/gn/shared_sources.gni
[delete] https://crrev.com/5ebf90ed364b03354d75e7640421cdc0c181043f/src/opts/SkOpts_crc32.cpp
[modify] https://crrev.com/6b21dd5cba02e2bb57ba701def95c76936a362b0/BUILD.gn
[modify] https://crrev.com/6b21dd5cba02e2bb57ba701def95c76936a362b0/gn/gn_to_bp.py
[modify] https://crrev.com/6b21dd5cba02e2bb57ba701def95c76936a362b0/src/opts/BUILD.bazel
[delete] https://crrev.com/5ebf90ed364b03354d75e7640421cdc0c181043f/src/opts/SkOpts_sse42.cpp
https://skia.googlesource.com/skia/+/6b21dd5cba02e2bb57ba701def95c76936a362b0
commit 6b21dd5cba02e2bb57ba701def95c76936a362b0
Author: Brian Osman <brianosman@google.com>
Date: Tue May 23 15:38:11 2023
Remove empty SkOpts files (crc32, sse42)
Bug: skia:13983
Change-Id: Ie4de8f8a92cb2c204ac807f4eabdd78311acac00
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/702837
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/6b21dd5cba02e2bb57ba701def95c76936a362b0/gn/opts.gni
[modify] https://crrev.com/6b21dd5cba02e2bb57ba701def95c76936a362b0/gn/shared_sources.gni
[delete] https://crrev.com/5ebf90ed364b03354d75e7640421cdc0c181043f/src/opts/SkOpts_crc32.cpp
[modify] https://crrev.com/6b21dd5cba02e2bb57ba701def95c76936a362b0/BUILD.gn
[modify] https://crrev.com/6b21dd5cba02e2bb57ba701def95c76936a362b0/gn/gn_to_bp.py
[modify] https://crrev.com/6b21dd5cba02e2bb57ba701def95c76936a362b0/src/opts/BUILD.bazel
[delete] https://crrev.com/5ebf90ed364b03354d75e7640421cdc0c181043f/src/opts/SkOpts_sse42.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #140
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/1bd909bbe61a290fa99f0e5c7913fd3de0dafe9c
commit 1bd909bbe61a290fa99f0e5c7913fd3de0dafe9c
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed May 24 17:25:52 2023
Use file lists for Skia's pdf jpeg parsing code
Follow-up to https://skia-review.googlesource.com/c/skia/+/702221
and precursor to https://skia-review.googlesource.com/c/skia/+/702138
Bug: skia:13983
Change-Id: Ida9b3667f5854e023629e061d190149b8f5f0b2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4562335
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1148610}
[modify] https://crrev.com/1bd909bbe61a290fa99f0e5c7913fd3de0dafe9c/skia/BUILD.gn
https://chromium.googlesource.com/chromium/src/+/1bd909bbe61a290fa99f0e5c7913fd3de0dafe9c
commit 1bd909bbe61a290fa99f0e5c7913fd3de0dafe9c
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed May 24 17:25:52 2023
Use file lists for Skia's pdf jpeg parsing code
Follow-up to https://skia-review.googlesource.com/c/skia/+/702221
and precursor to https://skia-review.googlesource.com/c/skia/+/702138
Bug: skia:13983
Change-Id: Ida9b3667f5854e023629e061d190149b8f5f0b2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4562335
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1148610}
[modify] https://crrev.com/1bd909bbe61a290fa99f0e5c7913fd3de0dafe9c/skia/BUILD.gn
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #141
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/037719930ce77dcb8e84974ebc7798abd59b5253
commit 037719930ce77dcb8e84974ebc7798abd59b5253
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed May 24 15:09:36 2023
Move gpu-specific methods off SkSurface
This should fully decouple SkSurface and the GPU backend, aiding
the ongoing effort to modularize Skia.
- SkSurface::asImage -> SkSurfaces::AsImage
- SkSurface::makeImageCopy -> SkSurfaces::AsImageCopy
- SkSurface::flushAndSubmit -> GrDirectContext::flushAndSubmit
- SkSurface::flush -> GrDirectContext::flush
There is also a skgpu::ganesh::Flush function which will help migrate
existing calls where the GrDirectContext is not readily available.
It will pull the GrRecordingContext off the surface, cast it to
a direct context, and then call flush (with appropriate null checks).
This could be done with existing public APIs, but adds a fair bit
of boilerplate that a one-liner makes clear.
This also moves the implementation of a Graphite Surface's
onFlush function to skgpu::graphite::Flush, but I didn't see any
places where it would have been explicitly used in unit tests.
No graphite tests seem to be failing, so maybe that flushing
wasn't really being used?
This also removes the old legacy define for surface methods,
as all clients have been upgraded.
Change-Id: Ibc36705cae9f212a4d5664a9923eb98703e4d945
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/698237
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/graphite/Surface_Graphite.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/include/gpu/ganesh/SkSurfaceGanesh.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/modules/canvaskit/debugger_bindings.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/d3d/GrD3DGpu.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/sk_app/win/D3D12WindowContext_win.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/GrSubmittedFlushTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/gm/kawase_blur_rt.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/GrFinishedFlushTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/SurfaceTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/modules/jetski/src/Surface.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/graphite/ImageFactories.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/graphite/Image_Graphite.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/surface/SkSurface_Ganesh.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/bench/SKPBench.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/experimental/minimal_ios_mtl_skia_app/main.mm
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/GrDirectContextPriv.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/debugger/DebugLayerManager.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/viewer/Viewer.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/image/SkSurface.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/DeferredDisplayListTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/VkYcbcrSamplerTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/vk/GrVkGpu.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/ImageTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/d3d/GrD3DGpu.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/skpbench/skpbench.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/graphite/MutableImagesTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/bench/CompositingImagesBench.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/GrGpu.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/image/SkImage_Ganesh.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/skottie_ios_app/SkiaGLContext.mm
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/modules/jetski/src/Surface.cpp
[add] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/bench/GpuTools.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/experimental/webgpu-bazel/src/bindings.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/dm/DMSrcSink.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/GLBackendSurfaceTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/bench/SKPAnimationBench.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/GpuDrawPathTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/image/SkImage_GaneshYUVA.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/include/gpu/GrDirectContext.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/modules/canvaskit/canvaskit_bindings.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/LazyStencilAttachmentTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/SurfaceContext.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/surface/SkSurface_Ganesh.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/DMSAATest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/window/VulkanWindowContext.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/GrDrawingManager.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/bench/ImageCycleBench.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/image/SkImage_AndroidFactories.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/vk/GrVkGpu.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/modules/canvaskit/gm_bindings.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/ApplyGammaTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/GrGpu.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/example/VulkanBasic.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/fonts/TestSVGTypeface.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/PromiseImageTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/GrMipMappedTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/include/gpu/graphite/Surface.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/graphite/Surface_Graphite.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/image/SkSurface_Base.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/skiaserve/Request.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/GrDirectContext.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/GrTextureMipMapInvalidationTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/GrDrawingManager.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/GrSurfaceResolveTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/sk_app/Window.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/WritePixelsTest.cpp
[add] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/relnotes/sksurface_methods.md
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/VkHardwareBufferTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/TextureBindingsResetTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/include/core/SkSurface.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/GrContextOOM.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/skottie_ios_app/SkiaMetalContext.mm
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/SurfaceSemaphoreTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/GrDirectContextPriv.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/sk_app/VulkanWindowContext.cpp
https://skia.googlesource.com/skia/+/037719930ce77dcb8e84974ebc7798abd59b5253
commit 037719930ce77dcb8e84974ebc7798abd59b5253
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed May 24 15:09:36 2023
Move gpu-specific methods off SkSurface
This should fully decouple SkSurface and the GPU backend, aiding
the ongoing effort to modularize Skia.
- SkSurface::asImage -> SkSurfaces::AsImage
- SkSurface::makeImageCopy -> SkSurfaces::AsImageCopy
- SkSurface::flushAndSubmit -> GrDirectContext::flushAndSubmit
- SkSurface::flush -> GrDirectContext::flush
There is also a skgpu::ganesh::Flush function which will help migrate
existing calls where the GrDirectContext is not readily available.
It will pull the GrRecordingContext off the surface, cast it to
a direct context, and then call flush (with appropriate null checks).
This could be done with existing public APIs, but adds a fair bit
of boilerplate that a one-liner makes clear.
This also moves the implementation of a Graphite Surface's
onFlush function to skgpu::graphite::Flush, but I didn't see any
places where it would have been explicitly used in unit tests.
No graphite tests seem to be failing, so maybe that flushing
wasn't really being used?
This also removes the old legacy define for surface methods,
as all clients have been upgraded.
Change-Id: Ibc36705cae9f212a4d5664a9923eb98703e4d945
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/698237
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/graphite/Surface_Graphite.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/include/gpu/ganesh/SkSurfaceGanesh.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/modules/canvaskit/debugger_bindings.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/d3d/GrD3DGpu.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/sk_app/win/D3D12WindowContext_win.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/GrSubmittedFlushTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/gm/kawase_blur_rt.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/GrFinishedFlushTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/SurfaceTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/modules/jetski/src/Surface.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/graphite/ImageFactories.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/graphite/Image_Graphite.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/surface/SkSurface_Ganesh.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/bench/SKPBench.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/experimental/minimal_ios_mtl_skia_app/main.mm
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/GrDirectContextPriv.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/debugger/DebugLayerManager.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/viewer/Viewer.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/image/SkSurface.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/DeferredDisplayListTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/VkYcbcrSamplerTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/vk/GrVkGpu.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/ImageTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/d3d/GrD3DGpu.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/skpbench/skpbench.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/graphite/MutableImagesTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/bench/CompositingImagesBench.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/GrGpu.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/image/SkImage_Ganesh.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/skottie_ios_app/SkiaGLContext.mm
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/modules/jetski/src/Surface.cpp
[add] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/bench/GpuTools.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/fuzz/FuzzDDLThreading.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/experimental/webgpu-bazel/src/bindings.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/dm/DMSrcSink.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/GLBackendSurfaceTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/bench/SKPAnimationBench.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/GpuDrawPathTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/image/SkImage_GaneshYUVA.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/include/gpu/GrDirectContext.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/pdf/SkPDFDevice.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/modules/canvaskit/canvaskit_bindings.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/LazyStencilAttachmentTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/SurfaceContext.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/surface/SkSurface_Ganesh.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/DMSAATest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/window/VulkanWindowContext.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/GrDrawingManager.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/bench/ImageCycleBench.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/image/SkImage_AndroidFactories.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/vk/GrVkGpu.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/modules/canvaskit/gm_bindings.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/ApplyGammaTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/GrGpu.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/example/VulkanBasic.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/fonts/TestSVGTypeface.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/PromiseImageTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/GrMipMappedTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/include/gpu/graphite/Surface.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/graphite/Surface_Graphite.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/image/SkSurface_Base.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/skiaserve/Request.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/GrDirectContext.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/GrTextureMipMapInvalidationTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/GrDrawingManager.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/GrSurfaceResolveTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/sk_app/Window.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/WritePixelsTest.cpp
[add] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/relnotes/sksurface_methods.md
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/VkHardwareBufferTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/TextureBindingsResetTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/include/core/SkSurface.h
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/GrContextOOM.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/skottie_ios_app/SkiaMetalContext.mm
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tests/SurfaceSemaphoreTest.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/src/gpu/ganesh/GrDirectContextPriv.cpp
[modify] https://crrev.com/037719930ce77dcb8e84974ebc7798abd59b5253/tools/sk_app/VulkanWindowContext.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #142
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46
commit ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed May 24 18:21:36 2023
Move SkJpegInfo impls to src/pdf
I ran into an accidental issue where there were two implementations of
SkGetJpegInfo at link time after http://review.skia.org/689016 landed.
This moves the implementations to seperate files to make it more
explicit that we only want one at a time depending on if we compiled
in actual JPEG support or not.
Bug: skia:13983
Change-Id: I30d268c995beebed89e9fd30cd6a32bf8088492e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/702138
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/src/codec/SkJpegPriv.h
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/src/pdf/BUILD.bazel
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/gn/pdf.gni
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/src/pdf/SkJpegInfo.h
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/src/codec/SkCodecPriv.h
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/BUILD.gn
[rename] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/src/pdf/SkJpegInfo_none.cpp
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/bazel/exporter_tool/main.go
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/bazel/exporter/gni_exporter.go
[add] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/src/pdf/SkJpegInfo_libjpegturbo.cpp
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/src/ports/BUILD.bazel
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/src/codec/SkJpegCodec.cpp
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/public.bzl
https://skia.googlesource.com/skia/+/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46
commit ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed May 24 18:21:36 2023
Move SkJpegInfo impls to src/pdf
I ran into an accidental issue where there were two implementations of
SkGetJpegInfo at link time after http://review.skia.org/689016 landed.
This moves the implementations to seperate files to make it more
explicit that we only want one at a time depending on if we compiled
in actual JPEG support or not.
Bug: skia:13983
Change-Id: I30d268c995beebed89e9fd30cd6a32bf8088492e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/702138
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/src/codec/SkJpegPriv.h
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/src/pdf/BUILD.bazel
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/gn/pdf.gni
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/toolchain/linux_trampolines/clang_trampoline_linux.sh
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/src/pdf/SkJpegInfo.h
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/src/codec/SkCodecPriv.h
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/BUILD.gn
[rename] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/src/pdf/SkJpegInfo_none.cpp
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/bazel/exporter_tool/main.go
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/bazel/exporter/gni_exporter.go
[add] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/src/pdf/SkJpegInfo_libjpegturbo.cpp
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/src/ports/BUILD.bazel
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/src/codec/SkJpegCodec.cpp
[modify] https://crrev.com/ab7e1840c94b7d1c85e1c06d1e27a2a69c908d46/public.bzl
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #143
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/156faa03aa5ef28c9b2e187255fccc0aec79ff8f
commit 156faa03aa5ef28c9b2e187255fccc0aec79ff8f
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu May 25 13:38:30 2023
Update Skia's legacy build flags
The deleted defines are no longer in the Skia codebase
(and thus have no effect). PDFium has rolled, so we should
be able to disable unintentional calls to the shim surface
factories.
Bug: skia:13983
Change-Id: I104f3fdfc566b338757b41b97c1a66dbe43b3432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4544537
Reviewed-by: Florin Malita <fmalita@chromium.org>
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1149058}
[modify] https://crrev.com/156faa03aa5ef28c9b2e187255fccc0aec79ff8f/skia/BUILD.gn
https://chromium.googlesource.com/chromium/src/+/156faa03aa5ef28c9b2e187255fccc0aec79ff8f
commit 156faa03aa5ef28c9b2e187255fccc0aec79ff8f
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu May 25 13:38:30 2023
Update Skia's legacy build flags
The deleted defines are no longer in the Skia codebase
(and thus have no effect). PDFium has rolled, so we should
be able to disable unintentional calls to the shim surface
factories.
Bug: skia:13983
Change-Id: I104f3fdfc566b338757b41b97c1a66dbe43b3432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4544537
Reviewed-by: Florin Malita <fmalita@chromium.org>
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1149058}
[modify] https://crrev.com/156faa03aa5ef28c9b2e187255fccc0aec79ff8f/skia/BUILD.gn
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #144
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/bab82f14da1a77c782f307b3765f29aa251bf57f
commit bab82f14da1a77c782f307b3765f29aa251bf57f
Author: Brian Osman <brianosman@google.com>
Date: Tue May 30 13:33:21 2023
Switch back to Skia CPU defines in SkVx.h
This effectively reverts commit:
7d3b27d90ea433dd02a556f7831e55f6c4ef27b7
I intend to switch the compilation target within translation units, and
this style makes it much simpler (we can just redefine SK_CPU_SSE_LEVEL,
rather than the set of compiler CPU defines).
Notes:
- I removed the __F16C__ 8-wide half/float conversion blocks. These were
never used, except in the to-be-deleted SkVM interpreter (and even
then, only when dealing with half-float buffers).
- I left the WASM checks using the compiler define - we don't have a
Skia name for that yet, and there's only one target at this point, so
no need to re-define and re-compile.
- Similarly, I did change the various NEON defines back, but I left the
__aarch64__ checks. Those are guarding intrinsics that are specific to
64-bit NEON, and ALL 64-bit ARM has that functionality, so gating it
on the compiler defines doesn't hurt anything.
Bug: skia:13983
Change-Id: I2c5ad50081e747c10ab047caa82d9eafe3cbe571
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/704780
Reviewed-by: John Stiles <johnstiles@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/bab82f14da1a77c782f307b3765f29aa251bf57f/src/base/SkVx.h
https://skia.googlesource.com/skia/+/bab82f14da1a77c782f307b3765f29aa251bf57f
commit bab82f14da1a77c782f307b3765f29aa251bf57f
Author: Brian Osman <brianosman@google.com>
Date: Tue May 30 13:33:21 2023
Switch back to Skia CPU defines in SkVx.h
This effectively reverts commit:
7d3b27d90ea433dd02a556f7831e55f6c4ef27b7
I intend to switch the compilation target within translation units, and
this style makes it much simpler (we can just redefine SK_CPU_SSE_LEVEL,
rather than the set of compiler CPU defines).
Notes:
- I removed the __F16C__ 8-wide half/float conversion blocks. These were
never used, except in the to-be-deleted SkVM interpreter (and even
then, only when dealing with half-float buffers).
- I left the WASM checks using the compiler define - we don't have a
Skia name for that yet, and there's only one target at this point, so
no need to re-define and re-compile.
- Similarly, I did change the various NEON defines back, but I left the
__aarch64__ checks. Those are guarding intrinsics that are specific to
64-bit NEON, and ALL 64-bit ARM has that functionality, so gating it
on the compiler defines doesn't hurt anything.
Bug: skia:13983
Change-Id: I2c5ad50081e747c10ab047caa82d9eafe3cbe571
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/704780
Reviewed-by: John Stiles <johnstiles@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
[modify] https://crrev.com/bab82f14da1a77c782f307b3765f29aa251bf57f/src/base/SkVx.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #145
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45
commit 6abb9c6ab1f716ed3ff64794ed51fb85b7453c45
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue May 30 21:28:22 2023
Migrate calls from SkSurface::flush -> GrDirectContext::flush
Presently, SkSurface::flush() defers to the GrDirectContext used
to create the surface to send work to the GPU. As part of an effort
to decouple SkSurface from the GPU code, we want to explicitly
call flush on the GrDirectContext and remove flushing from Surfaces.
http://review.skia.org/698237
In migrating these APIs, I tried to track where that context was
and use it directly and explicitly. In cases where that was not
obvious, I fell back to the existing behavior of "extract
GrRecordingContext, cast to GrDirectContext, check if it is non-null
(e.g. Raster or Graphite surfaces), and then call flush". In cases
where the default flush options were used, the helper
skgpu::ganesh::Flush() was used.
One peculiarity I found was in skia_output_device_dawn.cc where
the surfaces made in that file appear to be Graphite-backed
(and thus calling flush is a no-op), but when I removed that flush,
tests broke. So, I kept flushing in that spot.
Bug: skia:13983
Change-Id: Ifc68815b5da4b1a0d53099d1154440600e59175d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4566404
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1150871}
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/components/viz/test/fake_skia_output_surface.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/media/renderers/video_frame_yuv_converter.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/gpu/command_buffer/service/webgpu_decoder_impl.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/components/viz/service/display_embedder/skia_output_device.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/gpu/command_buffer/service/shared_image/d3d_image_backing_factory_unittest.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/third_party/blink/renderer/platform/image-decoders/image_frame.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/skia/BUILD.gn
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/android_webview/test/shell/src/draw_fn/context_manager.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/components/viz/service/display/skia_readback_pixeltest.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/components/viz/service/display_embedder/skia_output_device_dawn.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/gpu/command_buffer/service/shared_image/dcomp_image_backing_factory_unittest.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/components/viz/service/display_embedder/image_context_impl.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/components/viz/service/display_embedder/skia_output_device_vulkan.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/gpu/command_buffer/service/copy_shared_image_helper.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/gpu/command_buffer/service/shared_image/shared_image_representation.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/components/viz/service/display_embedder/output_presenter.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/gpu/command_buffer/service/shared_image/raw_draw_image_backing.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/gpu/command_buffer/service/shared_image/external_vk_image_backing_factory_unittest.cc
https://chromium.googlesource.com/chromium/src/+/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45
commit 6abb9c6ab1f716ed3ff64794ed51fb85b7453c45
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue May 30 21:28:22 2023
Migrate calls from SkSurface::flush -> GrDirectContext::flush
Presently, SkSurface::flush() defers to the GrDirectContext used
to create the surface to send work to the GPU. As part of an effort
to decouple SkSurface from the GPU code, we want to explicitly
call flush on the GrDirectContext and remove flushing from Surfaces.
http://review.skia.org/698237
In migrating these APIs, I tried to track where that context was
and use it directly and explicitly. In cases where that was not
obvious, I fell back to the existing behavior of "extract
GrRecordingContext, cast to GrDirectContext, check if it is non-null
(e.g. Raster or Graphite surfaces), and then call flush". In cases
where the default flush options were used, the helper
skgpu::ganesh::Flush() was used.
One peculiarity I found was in skia_output_device_dawn.cc where
the surfaces made in that file appear to be Graphite-backed
(and thus calling flush is a no-op), but when I removed that flush,
tests broke. So, I kept flushing in that spot.
Bug: skia:13983
Change-Id: Ifc68815b5da4b1a0d53099d1154440600e59175d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4566404
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1150871}
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/components/viz/test/fake_skia_output_surface.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/media/renderers/video_frame_yuv_converter.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/gpu/command_buffer/service/webgpu_decoder_impl.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/components/viz/service/display_embedder/skia_output_device.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/gpu/command_buffer/service/shared_image/d3d_image_backing_factory_unittest.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/third_party/blink/renderer/platform/image-decoders/image_frame.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/skia/BUILD.gn
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/android_webview/test/shell/src/draw_fn/context_manager.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/components/viz/service/display/skia_readback_pixeltest.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/components/viz/service/display_embedder/skia_output_device_dawn.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/gpu/command_buffer/service/shared_image/dcomp_image_backing_factory_unittest.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/components/viz/service/display_embedder/image_context_impl.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/components/viz/service/display_embedder/skia_output_device_vulkan.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/gpu/command_buffer/service/copy_shared_image_helper.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/gpu/command_buffer/service/shared_image/shared_image_representation.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/components/viz/service/display_embedder/output_presenter.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/gpu/command_buffer/service/shared_image/raw_draw_image_backing.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/6abb9c6ab1f716ed3ff64794ed51fb85b7453c45/gpu/command_buffer/service/shared_image/external_vk_image_backing_factory_unittest.cc
br...@google.com <br...@google.com> #146
[Empty comment from Monorail migration]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #147
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/074580d41cd5d30a175359b7d3ad9352ae7a3dbc
commit 074580d41cd5d30a175359b7d3ad9352ae7a3dbc
Author: Colin Blundell <blundell@chromium.org>
Date: Thu Jun 01 12:09:22 2023
[//viz] Restore capturing result of flush() following recent CL
[1] inadvertently dropped the capturing of the result of a call to
flush(), which will result in incorrect behavior. This CL restores this
capturing.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/4566404
Bug: skia:13983
Change-Id: Iffec24ffb86e113d863ca41574b468cc442288a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4579018
Auto-Submit: Colin Blundell <blundell@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1151786}
[modify] https://crrev.com/074580d41cd5d30a175359b7d3ad9352ae7a3dbc/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
https://chromium.googlesource.com/chromium/src/+/074580d41cd5d30a175359b7d3ad9352ae7a3dbc
commit 074580d41cd5d30a175359b7d3ad9352ae7a3dbc
Author: Colin Blundell <blundell@chromium.org>
Date: Thu Jun 01 12:09:22 2023
[//viz] Restore capturing result of flush() following recent CL
[1] inadvertently dropped the capturing of the result of a call to
flush(), which will result in incorrect behavior. This CL restores this
capturing.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/4566404
Bug: skia:13983
Change-Id: Iffec24ffb86e113d863ca41574b468cc442288a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4579018
Auto-Submit: Colin Blundell <blundell@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1151786}
[modify] https://crrev.com/074580d41cd5d30a175359b7d3ad9352ae7a3dbc/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #148
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf
commit ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jun 20 20:56:44 2023
Add decoder #includes to implementation files
Without these, the various Sk*Decoder::Decode functions were not properly
being marked with SK_API and were not visible to Chromium.
Change-Id: I29b5bb630e54a26205a8f562d61929d61bc4aaec
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/714237
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Florin Malita <fmalita@google.com>
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkWuffsCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkPngCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkJpegxlCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkWbmpDecoder.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkBmpDecoder.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkRawCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkWbmpCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkIcoCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkAvifCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkGifDecoder.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkJpegDecoder.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkJpegxlDecoder.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkPngDecoder.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkWebpCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkBmpCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkWebpDecoder.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkRawDecoder.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkIcoDecoder.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkCodec.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkJpegCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkAvifDecoder.h
https://skia.googlesource.com/skia/+/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf
commit ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jun 20 20:56:44 2023
Add decoder #includes to implementation files
Without these, the various Sk*Decoder::Decode functions were not properly
being marked with SK_API and were not visible to Chromium.
Change-Id: I29b5bb630e54a26205a8f562d61929d61bc4aaec
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/714237
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Florin Malita <fmalita@google.com>
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkWuffsCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkPngCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkJpegxlCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkWbmpDecoder.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkBmpDecoder.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkRawCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkWbmpCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkIcoCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkAvifCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkGifDecoder.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkJpegDecoder.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkJpegxlDecoder.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkPngDecoder.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkWebpCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkBmpCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkWebpDecoder.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkRawDecoder.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkIcoDecoder.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkCodec.h
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/src/codec/SkJpegCodec.cpp
[modify] https://crrev.com/ec70dfbaa2e99ae34cc40bebe7c59e3b87d31eaf/include/codec/SkAvifDecoder.h
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #149
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/61afceadc4c747b0de775aeb25aeac5500708ae8
commit 61afceadc4c747b0de775aeb25aeac5500708ae8
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Jun 26 13:50:08 2023
Make use of Skia's codecs explicit in Blink gif decoding and viz unittests
In http://review.skia.org/689016, Skia added APIs to allow a single
codec to be explicitly used.
This CL replaces the 2 use of SkCodec::Make* with an explicit,
specific codec that is intended. This means it will no longer
try to decode the bytes with all of the compiled-in Skia codecs,
but only PNG or GIF (depending on the file).
Bug: skia:13983
Change-Id: Ia58061be43027c4b2f6b4eecdf6dc6ea8357c61d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615536
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Cr-Commit-Position: refs/heads/main@{#1162373}
[modify] https://crrev.com/61afceadc4c747b0de775aeb25aeac5500708ae8/components/viz/service/debugger/viz_debugger_unittests/viz_debugger_unittest_base.cc
[modify] https://crrev.com/61afceadc4c747b0de775aeb25aeac5500708ae8/third_party/blink/renderer/platform/image-decoders/gif/gif_image_decoder.cc
https://chromium.googlesource.com/chromium/src/+/61afceadc4c747b0de775aeb25aeac5500708ae8
commit 61afceadc4c747b0de775aeb25aeac5500708ae8
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Jun 26 13:50:08 2023
Make use of Skia's codecs explicit in Blink gif decoding and viz unittests
In http://review.skia.org/689016, Skia added APIs to allow a single
codec to be explicitly used.
This CL replaces the 2 use of SkCodec::Make* with an explicit,
specific codec that is intended. This means it will no longer
try to decode the bytes with all of the compiled-in Skia codecs,
but only PNG or GIF (depending on the file).
Bug: skia:13983
Change-Id: Ia58061be43027c4b2f6b4eecdf6dc6ea8357c61d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615536
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Cr-Commit-Position: refs/heads/main@{#1162373}
[modify] https://crrev.com/61afceadc4c747b0de775aeb25aeac5500708ae8/components/viz/service/debugger/viz_debugger_unittests/viz_debugger_unittest_base.cc
[modify] https://crrev.com/61afceadc4c747b0de775aeb25aeac5500708ae8/third_party/blink/renderer/platform/image-decoders/gif/gif_image_decoder.cc
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #150
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/095359e3efca1a43f6c5bb154033e7fe919569aa
commit 095359e3efca1a43f6c5bb154033e7fe919569aa
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jun 27 14:27:45 2023
Remove conditional compilation of SkJpegSourceMgr.cpp
The only thing SK_CODEC_DECODES_JPEG should control is the legacy
registration of decoding the JPEG codec.
Other uses had been removed previously in http://review.skia.org/689016
Change-Id: Ib12eae183fb1e87747442807e55d6605e6230765
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/717077
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
[modify] https://crrev.com/095359e3efca1a43f6c5bb154033e7fe919569aa/src/codec/SkJpegSourceMgr.cpp
https://skia.googlesource.com/skia/+/095359e3efca1a43f6c5bb154033e7fe919569aa
commit 095359e3efca1a43f6c5bb154033e7fe919569aa
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jun 27 14:27:45 2023
Remove conditional compilation of SkJpegSourceMgr.cpp
The only thing SK_CODEC_DECODES_JPEG should control is the legacy
registration of decoding the JPEG codec.
Other uses had been removed previously in http://review.skia.org/689016
Change-Id: Ib12eae183fb1e87747442807e55d6605e6230765
Bug: skia:13983
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/717077
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
[modify] https://crrev.com/095359e3efca1a43f6c5bb154033e7fe919569aa/src/codec/SkJpegSourceMgr.cpp
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #151
The following revision refers to this bug:
https://skia.googlesource.com/skia/+/5768563647c16ed56ed528f6ad4c30cca7140f95
commit 5768563647c16ed56ed528f6ad4c30cca7140f95
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jun 29 17:06:54 2023
Remove #ifdefs from SkAndroidCodec.cpp
We don't have two gif codecs anymore and if we cannot decode
a certain format (WebP, DNG) codec should be nullptr earlier
in the chain anyway.
The AVIF #ifdef was the trickiest to duplicate the functionality
of (see https://skia-review.googlesource.com/c/skia/+/566440).
I added a way to query the registered codecs so we don't have
#ifdefs (which make modular builds difficult in Bazel).
Bug: skia:13983
Change-Id: I0d2b614dcd76ff3a118a4e8160f03badafb6f45a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/717156
Owners-Override: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/5768563647c16ed56ed528f6ad4c30cca7140f95/include/android/SkHeifDecoder.h
[modify] https://crrev.com/5768563647c16ed56ed528f6ad4c30cca7140f95/src/codec/SkCodecPriv.h
[modify] https://crrev.com/5768563647c16ed56ed528f6ad4c30cca7140f95/src/codec/SkCodec.cpp
[modify] https://crrev.com/5768563647c16ed56ed528f6ad4c30cca7140f95/src/codec/SkAndroidCodec.cpp
https://skia.googlesource.com/skia/+/5768563647c16ed56ed528f6ad4c30cca7140f95
commit 5768563647c16ed56ed528f6ad4c30cca7140f95
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jun 29 17:06:54 2023
Remove #ifdefs from SkAndroidCodec.cpp
We don't have two gif codecs anymore and if we cannot decode
a certain format (WebP, DNG) codec should be nullptr earlier
in the chain anyway.
The AVIF #ifdef was the trickiest to duplicate the functionality
of (see https://skia-review.googlesource.com/c/skia/+/566440).
I added a way to query the registered codecs so we don't have
#ifdefs (which make modular builds difficult in Bazel).
Bug: skia:13983
Change-Id: I0d2b614dcd76ff3a118a4e8160f03badafb6f45a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/717156
Owners-Override: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
[modify] https://crrev.com/5768563647c16ed56ed528f6ad4c30cca7140f95/include/android/SkHeifDecoder.h
[modify] https://crrev.com/5768563647c16ed56ed528f6ad4c30cca7140f95/src/codec/SkCodecPriv.h
[modify] https://crrev.com/5768563647c16ed56ed528f6ad4c30cca7140f95/src/codec/SkCodec.cpp
[modify] https://crrev.com/5768563647c16ed56ed528f6ad4c30cca7140f95/src/codec/SkAndroidCodec.cpp
is...@google.com <is...@google.com> #152
Edits/notes reflect the following in Monorail: blocked-on.
[Monorail blocked-on: crbug.com/skia/14317, crbug.com/skia/14355]
[Monorail blocked-on: crbug.com/skia/14317, crbug.com/skia/14355]
kj...@google.com <kj...@google.com>
ap...@google.com <ap...@google.com> #153
Project: skia
Branch: main
commit e3ca856e7ed6c285734dacf87faccdbf9a321f05
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jul 26 08:58:05 2023
Remove legacy SkImage and SkSurface methods
Client CLs:
- http://ag/23168890
- http://ag/23171851
- http://ag/23473641
- http://ag/23494824
- http://cl/551209733
- https://crrev.com/c/4566404
- https://crrev.com/c/4705004
- https://github.com/flutter/engine/pull/42425
- https://github.com/flutter/engine/pull/43786
- https://github.com/flutter/engine/pull/43965
Change-Id: I06c71cf6dc77aeaa3f78dec61c7b7c6eca688884
Bug: b/40045064
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/729776
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
M gm/colorspace.cpp
M gm/makecolorspace.cpp
M gm/runtimeshader.cpp
M gm/wacky_yuv_formats.cpp
M include/core/SkImage.h
M include/core/SkSurface.h
M src/gpu/graphite/Image_Graphite.cpp
M src/image/SkImage.cpp
M src/image/SkSurface.cpp
M tests/ImageTest.cpp
https://skia-review.googlesource.com/729776
Branch: main
commit e3ca856e7ed6c285734dacf87faccdbf9a321f05
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jul 26 08:58:05 2023
Remove legacy SkImage and SkSurface methods
Client CLs:
- http://ag/23168890
- http://ag/23171851
- http://ag/23473641
- http://ag/23494824
- http://cl/551209733
- https://crrev.com/c/4566404
- https://crrev.com/c/4705004
- https://github.com/flutter/engine/pull/42425
- https://github.com/flutter/engine/pull/43786
- https://github.com/flutter/engine/pull/43965
Change-Id: I06c71cf6dc77aeaa3f78dec61c7b7c6eca688884
Bug:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/729776
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
M gm/colorspace.cpp
M gm/makecolorspace.cpp
M gm/runtimeshader.cpp
M gm/wacky_yuv_formats.cpp
M include/core/SkImage.h
M include/core/SkSurface.h
M src/gpu/graphite/Image_Graphite.cpp
M src/image/SkImage.cpp
M src/image/SkSurface.cpp
M tests/ImageTest.cpp
https://skia-review.googlesource.com/729776
ap...@google.com <ap...@google.com> #154
Project: skia
Branch: main
commit 84e1ebb63bc71171998ebf3ab8f70964dbe0167b
Author: Brian Osman <brianosman@google.com>
Date: Fri Aug 04 17:16:54 2023
Split out BlitMask opts into separate cpp files
See https://skia-review.googlesource.com/c/skia/+/727257 for details
Bug: b/40045064
Bug: b/40045066
Change-Id: I2294e49be894d7b470e6a69b4a7ec06ec44439cd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/736881
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
M gn/core.gni
M public.bzl
M src/core/BUILD.bazel
A src/core/SkBlitMask.h
A src/core/SkBlitMask_opts.cpp
A src/core/SkBlitMask_opts_ssse3.cpp
M src/core/SkBlitter_ARGB32.cpp
M src/core/SkGraphics.cpp
M src/core/SkOpts.cpp
M src/core/SkOpts.h
M src/opts/SkOpts_ssse3.cpp
https://skia-review.googlesource.com/736881
Branch: main
commit 84e1ebb63bc71171998ebf3ab8f70964dbe0167b
Author: Brian Osman <brianosman@google.com>
Date: Fri Aug 04 17:16:54 2023
Split out BlitMask opts into separate cpp files
See https://skia-review.googlesource.com/c/skia/+/727257 for details
Bug:
Bug:
Change-Id: I2294e49be894d7b470e6a69b4a7ec06ec44439cd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/736881
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
M gn/core.gni
M public.bzl
M src/core/BUILD.bazel
A src/core/SkBlitMask.h
A src/core/SkBlitMask_opts.cpp
A src/core/SkBlitMask_opts_ssse3.cpp
M src/core/SkBlitter_ARGB32.cpp
M src/core/SkGraphics.cpp
M src/core/SkOpts.cpp
M src/core/SkOpts.h
M src/opts/SkOpts_ssse3.cpp
https://skia-review.googlesource.com/736881
ap...@google.com <ap...@google.com> #155
Project: skia
Branch: main
commit 7a1fec6b197f14894118dc16c22b317af6d92bb4
Author: Brian Osman <brianosman@google.com>
Date: Mon Aug 07 16:50:59 2023
Split out BlitRow opts into separate cpp files
Bug: b/40045064
Bug: b/40045066
Change-Id: I79ab47708ed68d6af8a071fa24d51b10bb61ec1b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/736360
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
M gn/core.gni
M public.bzl
M src/core/BUILD.bazel
M src/core/SkBlitRow.h
A src/core/SkBlitRow_opts.cpp
A src/core/SkBlitRow_opts_hsw.cpp
M src/core/SkGraphics.cpp
M src/core/SkOpts.cpp
M src/core/SkOpts.h
M src/opts/SkOpts_hsw.cpp
https://skia-review.googlesource.com/736360
Branch: main
commit 7a1fec6b197f14894118dc16c22b317af6d92bb4
Author: Brian Osman <brianosman@google.com>
Date: Mon Aug 07 16:50:59 2023
Split out BlitRow opts into separate cpp files
Bug:
Bug:
Change-Id: I79ab47708ed68d6af8a071fa24d51b10bb61ec1b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/736360
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
M gn/core.gni
M public.bzl
M src/core/BUILD.bazel
M src/core/SkBlitRow.h
A src/core/SkBlitRow_opts.cpp
A src/core/SkBlitRow_opts_hsw.cpp
M src/core/SkGraphics.cpp
M src/core/SkOpts.cpp
M src/core/SkOpts.h
M src/opts/SkOpts_hsw.cpp
https://skia-review.googlesource.com/736360
ap...@google.com <ap...@google.com> #156
Project: skia
Branch: main
commit a45e98a60a3bdd444cce9c1f7443e11f9c2b30db
Author: Brian Osman <brianosman@google.com>
Date: Thu Aug 10 16:55:04 2023
Split out Swizzler opts into separate cpp files
Bug: b/40045064
Bug: b/40045066
Change-Id: I9fd6e0818b1c3aff4176af6d5a84e8e90b9a38ec
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/740296
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
M bench/SwizzleBench.cpp
M dm/DMSrcSink.cpp
M gm/png_codec.cpp
M gn/core.gni
M public.bzl
M src/codec/SkJpegxlCodec.cpp
M src/codec/SkSwizzler.cpp
M src/codec/SkSwizzler.h
M src/core/BUILD.bazel
M src/core/SkConvertPixels.cpp
M src/core/SkGraphics.cpp
M src/core/SkOpts.cpp
M src/core/SkOpts.h
M src/core/SkSwizzle.cpp
A src/core/SkSwizzler_opts.cpp
A src/core/SkSwizzler_opts_hsw.cpp
A src/core/SkSwizzler_opts_ssse3.cpp
M src/gpu/AtlasTypes.cpp
M src/opts/SkOpts_hsw.cpp
M src/opts/SkOpts_ssse3.cpp
M tests/SwizzlerTest.cpp
https://skia-review.googlesource.com/740296
Branch: main
commit a45e98a60a3bdd444cce9c1f7443e11f9c2b30db
Author: Brian Osman <brianosman@google.com>
Date: Thu Aug 10 16:55:04 2023
Split out Swizzler opts into separate cpp files
Bug:
Bug:
Change-Id: I9fd6e0818b1c3aff4176af6d5a84e8e90b9a38ec
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/740296
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
M bench/SwizzleBench.cpp
M dm/DMSrcSink.cpp
M gm/png_codec.cpp
M gn/core.gni
M public.bzl
M src/codec/SkJpegxlCodec.cpp
M src/codec/SkSwizzler.cpp
M src/codec/SkSwizzler.h
M src/core/BUILD.bazel
M src/core/SkConvertPixels.cpp
M src/core/SkGraphics.cpp
M src/core/SkOpts.cpp
M src/core/SkOpts.h
M src/core/SkSwizzle.cpp
A src/core/SkSwizzler_opts.cpp
A src/core/SkSwizzler_opts_hsw.cpp
A src/core/SkSwizzler_opts_ssse3.cpp
M src/gpu/AtlasTypes.cpp
M src/opts/SkOpts_hsw.cpp
M src/opts/SkOpts_ssse3.cpp
M tests/SwizzlerTest.cpp
https://skia-review.googlesource.com/740296
ap...@google.com <ap...@google.com> #157
Project: skia
Branch: main
commit 1cf6f71c81206fd9deb46d68540dd167f98b79b3
Author: Brian Osman <brianosman@google.com>
Date: Fri Aug 11 11:54:45 2023
Split out memset opts into separate cpp files
These used to be in SkUtils_opts. I also renamed everything so that
they're declared in SkMemset.h, and defined in SkMemset_opts.h.
Bug: b/40045064
Bug: b/40045066
Change-Id: Idefa5b8d5f59595ddce907742f50e02174e42964
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/740638
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
M bench/MemsetBench.cpp
M gn/core.gni
M public.bzl
M src/codec/SkPngCodec.cpp
M src/codec/SkSampler.cpp
M src/core/BUILD.bazel
M src/core/SkAlphaRuns.cpp
M src/core/SkBitmapProcState.cpp
M src/core/SkBitmapProcState_matrixProcs.cpp
M src/core/SkBlitRow_D32.cpp
M src/core/SkBlitter.cpp
M src/core/SkBlitter_ARGB32.cpp
M src/core/SkDevice.cpp
M src/core/SkGraphics.cpp
A src/core/SkMemset.h
A src/core/SkMemset_opts.cpp
A src/core/SkMemset_opts_avx.cpp
A src/core/SkMemset_opts_erms.cpp
M src/core/SkOpts.cpp
M src/core/SkOpts.h
D src/core/SkOpts_erms.cpp
M src/core/SkPixmap.cpp
M src/core/SkRasterPipelineBlitter.cpp
M src/core/SkVertices.cpp
M src/gpu/ganesh/GrDrawOpAtlas.cpp
M src/gpu/ganesh/GrResourceCache.cpp
M src/gpu/ganesh/vk/GrVkPipelineStateCache.cpp
M src/gpu/graphite/DrawAtlas.cpp
M src/opts/BUILD.bazel
M src/opts/SkMemset_opts.h
M src/opts/SkOpts_avx.cpp
M src/pdf/SkPDFGraphicState.h
M src/ports/SkScalerContext_mac_ct.cpp
M tests/ApplyGammaTest.cpp
M tests/BitmapCopyTest.cpp
M tests/CachedDecodingPixelRefTest.cpp
M tests/CopySurfaceTest.cpp
M tests/ImageTest.cpp
M tests/MemsetTest.cpp
M tests/RasterPipelineBuilderTest.cpp
M tools/fiddle/fiddle_main.cpp
https://skia-review.googlesource.com/740638
Branch: main
commit 1cf6f71c81206fd9deb46d68540dd167f98b79b3
Author: Brian Osman <brianosman@google.com>
Date: Fri Aug 11 11:54:45 2023
Split out memset opts into separate cpp files
These used to be in SkUtils_opts. I also renamed everything so that
they're declared in SkMemset.h, and defined in SkMemset_opts.h.
Bug:
Bug:
Change-Id: Idefa5b8d5f59595ddce907742f50e02174e42964
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/740638
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
M bench/MemsetBench.cpp
M gn/core.gni
M public.bzl
M src/codec/SkPngCodec.cpp
M src/codec/SkSampler.cpp
M src/core/BUILD.bazel
M src/core/SkAlphaRuns.cpp
M src/core/SkBitmapProcState.cpp
M src/core/SkBitmapProcState_matrixProcs.cpp
M src/core/SkBlitRow_D32.cpp
M src/core/SkBlitter.cpp
M src/core/SkBlitter_ARGB32.cpp
M src/core/SkDevice.cpp
M src/core/SkGraphics.cpp
A src/core/SkMemset.h
A src/core/SkMemset_opts.cpp
A src/core/SkMemset_opts_avx.cpp
A src/core/SkMemset_opts_erms.cpp
M src/core/SkOpts.cpp
M src/core/SkOpts.h
D src/core/SkOpts_erms.cpp
M src/core/SkPixmap.cpp
M src/core/SkRasterPipelineBlitter.cpp
M src/core/SkVertices.cpp
M src/gpu/ganesh/GrDrawOpAtlas.cpp
M src/gpu/ganesh/GrResourceCache.cpp
M src/gpu/ganesh/vk/GrVkPipelineStateCache.cpp
M src/gpu/graphite/DrawAtlas.cpp
M src/opts/BUILD.bazel
M src/opts/SkMemset_opts.h
M src/opts/SkOpts_avx.cpp
M src/pdf/SkPDFGraphicState.h
M src/ports/SkScalerContext_mac_ct.cpp
M tests/ApplyGammaTest.cpp
M tests/BitmapCopyTest.cpp
M tests/CachedDecodingPixelRefTest.cpp
M tests/CopySurfaceTest.cpp
M tests/ImageTest.cpp
M tests/MemsetTest.cpp
M tests/RasterPipelineBuilderTest.cpp
M tools/fiddle/fiddle_main.cpp
https://skia-review.googlesource.com/740638
ap...@google.com <ap...@google.com> #158
Project: skia
Branch: main
commit 022415d74e73de8e4a496ed047ac6b361a44a7f9
Author: Leon Scroggins III <scroggo@google.com>
Date: Mon Aug 14 09:48:06 2023
Fix typo in EncodeAnimated for NDK
Bug: 40045064
Change-Id: I2eed07d3db88160fd6f4749fb3ea00841a5b2836
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/741516
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
M src/ports/SkImageEncoder_NDK.cpp
https://skia-review.googlesource.com/741516
Branch: main
commit 022415d74e73de8e4a496ed047ac6b361a44a7f9
Author: Leon Scroggins III <scroggo@google.com>
Date: Mon Aug 14 09:48:06 2023
Fix typo in EncodeAnimated for NDK
Bug: 40045064
Change-Id: I2eed07d3db88160fd6f4749fb3ea00841a5b2836
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/741516
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
M src/ports/SkImageEncoder_NDK.cpp
https://skia-review.googlesource.com/741516
ap...@google.com <ap...@google.com> #159
Project: skia
Branch: main
commit 625f61e96c8e99a625d3aacc7f24a1d0d8e72b4b
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Aug 29 10:26:26 2023
Move SkOpts things around for easier modularization
It's a bit awkward to have a src/core depend on src/codec,
so the swizzles that are needed in core are now defined in
src/SkSwizzlePriv.h.
Additionally, it's a bit awkward to have many of the SkOpts
implementations actually depend on SkOpts due to the indirect
#include of SkRasterPipelineOpList.h, so I split out the
defines that are necessary into their own file.
Change-Id: Iba4efdd756996b234fb6dfa593e0e1ff444d6f20
Bug: b/284138320 , b/40045064
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/748876
Reviewed-by: Brian Osman <brianosman@google.com>
M .bazelrc
M bench/SwizzleBench.cpp
M dm/DMSrcSink.cpp
M gn/core.gni
M public.bzl
M src/codec/SkJpegxlCodec.cpp
M src/codec/SkPngCodec.cpp
M src/codec/SkSwizzler.cpp
M src/codec/SkSwizzler.h
M src/core/BUILD.bazel
M src/core/SkBitmapProcState_opts.cpp
M src/core/SkBitmapProcState_opts_hsw.cpp
M src/core/SkBitmapProcState_opts_ssse3.cpp
M src/core/SkBlitMask_opts.cpp
M src/core/SkBlitMask_opts_ssse3.cpp
M src/core/SkBlitRow_opts.cpp
M src/core/SkBlitRow_opts_hsw.cpp
M src/core/SkConvertPixels.cpp
M src/core/SkGraphics.cpp
M src/core/SkMemset_opts.cpp
M src/core/SkMemset_opts_avx.cpp
M src/core/SkOpts.h
A src/core/SkOptsTargets.h
M src/core/SkSwizzle.cpp
M src/core/SkSwizzlePriv.h
M src/core/SkSwizzler_opts.cpp
M src/core/SkSwizzler_opts_hsw.cpp
M src/core/SkSwizzler_opts_ssse3.cpp
M src/gpu/AtlasTypes.cpp
M tests/SwizzlerTest.cpp
https://skia-review.googlesource.com/748876
Branch: main
commit 625f61e96c8e99a625d3aacc7f24a1d0d8e72b4b
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Aug 29 10:26:26 2023
Move SkOpts things around for easier modularization
It's a bit awkward to have a src/core depend on src/codec,
so the swizzles that are needed in core are now defined in
src/SkSwizzlePriv.h.
Additionally, it's a bit awkward to have many of the SkOpts
implementations actually depend on SkOpts due to the indirect
#include of SkRasterPipelineOpList.h, so I split out the
defines that are necessary into their own file.
Change-Id: Iba4efdd756996b234fb6dfa593e0e1ff444d6f20
Bug:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/748876
Reviewed-by: Brian Osman <brianosman@google.com>
M .bazelrc
M bench/SwizzleBench.cpp
M dm/DMSrcSink.cpp
M gn/core.gni
M public.bzl
M src/codec/SkJpegxlCodec.cpp
M src/codec/SkPngCodec.cpp
M src/codec/SkSwizzler.cpp
M src/codec/SkSwizzler.h
M src/core/BUILD.bazel
M src/core/SkBitmapProcState_opts.cpp
M src/core/SkBitmapProcState_opts_hsw.cpp
M src/core/SkBitmapProcState_opts_ssse3.cpp
M src/core/SkBlitMask_opts.cpp
M src/core/SkBlitMask_opts_ssse3.cpp
M src/core/SkBlitRow_opts.cpp
M src/core/SkBlitRow_opts_hsw.cpp
M src/core/SkConvertPixels.cpp
M src/core/SkGraphics.cpp
M src/core/SkMemset_opts.cpp
M src/core/SkMemset_opts_avx.cpp
M src/core/SkOpts.h
A src/core/SkOptsTargets.h
M src/core/SkSwizzle.cpp
M src/core/SkSwizzlePriv.h
M src/core/SkSwizzler_opts.cpp
M src/core/SkSwizzler_opts_hsw.cpp
M src/core/SkSwizzler_opts_ssse3.cpp
M src/gpu/AtlasTypes.cpp
M tests/SwizzlerTest.cpp
https://skia-review.googlesource.com/748876
ap...@google.com <ap...@google.com> #160
Project: skia
Branch: main
commit e51a4e742e2889674b18c02174852b1792efa619
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Aug 29 10:31:26 2023
Enforce IWYU on SkResourceCache etc
Makes the modularization easier.
Change-Id: Ie85d6fd7c2298947a16e3502d5f28578903b6314
Bug: b/40045064 , b/284138320
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/748877
Reviewed-by: Ben Wagner <bungeman@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
M include/core/SkRegion.h
M src/core/SkRegion.cpp
M src/core/SkRegion_path.cpp
M src/core/SkResourceCache.cpp
M src/core/SkResourceCache.h
M toolchain/linux_trampolines/clang_trampoline_linux.sh
https://skia-review.googlesource.com/748877
Branch: main
commit e51a4e742e2889674b18c02174852b1792efa619
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Aug 29 10:31:26 2023
Enforce IWYU on SkResourceCache etc
Makes the modularization easier.
Change-Id: Ie85d6fd7c2298947a16e3502d5f28578903b6314
Bug:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/748877
Reviewed-by: Ben Wagner <bungeman@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
M include/core/SkRegion.h
M src/core/SkRegion.cpp
M src/core/SkRegion_path.cpp
M src/core/SkResourceCache.cpp
M src/core/SkResourceCache.h
M toolchain/linux_trampolines/clang_trampoline_linux.sh
https://skia-review.googlesource.com/748877
ap...@google.com <ap...@google.com> #161
Project: skia
Branch: main
commit a13a9d6efbbc35a4d4f645c162be4af8dfed081d
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Aug 30 16:11:55 2023
Misc IWYU cleanups
This removes SkFuzzLogging.h which had appeared unused as well
as SkAutoTime which also appeared unused.
I would like to remove SkTime.h from the public API in a future
change.
Change-Id: Iaea43df7f22581c19ae3b36793cb82b6e1ed6e63
Bug: b/40045064
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/749656
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
M include/core/SkGraphics.h
M include/core/SkImageFilter.h
M include/core/SkTime.h
M include/core/SkTypeface.h
M src/core/SkGraphics.cpp
M src/core/SkImageFilter.cpp
M src/core/SkTime.cpp
M src/core/SkTypeface.cpp
M toolchain/linux_trampolines/IWYU_mapping.imp
M toolchain/linux_trampolines/clang_trampoline_linux.sh
https://skia-review.googlesource.com/749656
Branch: main
commit a13a9d6efbbc35a4d4f645c162be4af8dfed081d
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Aug 30 16:11:55 2023
Misc IWYU cleanups
This removes SkFuzzLogging.h which had appeared unused as well
as SkAutoTime which also appeared unused.
I would like to remove SkTime.h from the public API in a future
change.
Change-Id: Iaea43df7f22581c19ae3b36793cb82b6e1ed6e63
Bug:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/749656
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
M include/core/SkGraphics.h
M include/core/SkImageFilter.h
M include/core/SkTime.h
M include/core/SkTypeface.h
M src/core/SkGraphics.cpp
M src/core/SkImageFilter.cpp
M src/core/SkTime.cpp
M src/core/SkTypeface.cpp
M toolchain/linux_trampolines/IWYU_mapping.imp
M toolchain/linux_trampolines/clang_trampoline_linux.sh
https://skia-review.googlesource.com/749656
ap...@google.com <ap...@google.com> #162
Project: chromium/src
Branch: main
commit becc92d6485af6b0b483a7bae262b4326f39a2ea
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Sep 08 13:12:35 2023
Set SkSerialProcs for explicit image encoding
Skia plans to stop the default behavior of encoding SkImages in
SkPictures using a PNG encoder. To preserve that behavior,
clients need to explicitly set an SkSerialProc to do so.
I assume that picture_debug_util.cc and gpu_benchmarking_extension.cc
both have SkPictures which could contain SkImages. I can tell by
inspection serial_utils_unittest.cc does not, but figured we could
make the use of the default behavior explicit.
Bug: b/40045064
Change-Id: I54b0fb960eec688359e11cb27948f00ce9463f56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845659
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1194054}
M cc/debug/BUILD.gn
M cc/debug/picture_debug_util.cc
M components/paint_preview/common/serial_utils_unittest.cc
M content/renderer/gpu_benchmarking_extension.cc
https://chromium-review.googlesource.com/4845659
Branch: main
commit becc92d6485af6b0b483a7bae262b4326f39a2ea
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Sep 08 13:12:35 2023
Set SkSerialProcs for explicit image encoding
Skia plans to stop the default behavior of encoding SkImages in
SkPictures using a PNG encoder. To preserve that behavior,
clients need to explicitly set an SkSerialProc to do so.
I assume that picture_debug_util.cc and gpu_benchmarking_extension.cc
both have SkPictures which could contain SkImages. I can tell by
inspection serial_utils_unittest.cc does not, but figured we could
make the use of the default behavior explicit.
Bug:
Change-Id: I54b0fb960eec688359e11cb27948f00ce9463f56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845659
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1194054}
M cc/debug/BUILD.gn
M cc/debug/picture_debug_util.cc
M components/paint_preview/common/serial_utils_unittest.cc
M content/renderer/gpu_benchmarking_extension.cc
https://chromium-review.googlesource.com/4845659
ap...@google.com <ap...@google.com> #163
Project: skia
Branch: main
commit 55c9c377f0b028c4966481d7e437536eeca8a734
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Sep 11 17:23:42 2023
Make SKP deserialize null instead of PNG images by default.
Client CLs:
- http://cl/563413765
- https://pdfium-review.googlesource.com/c/pdfium/+/111650
- https://github.com/flutter/engine/pull/45511
- https://crrev.com/c/4833521
- http://ag/24692530
Change-Id: I9fa03445e3cd41b1692e2d5a1aae3c7ff7e72e45
Bug: b/40045064
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/752378
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
M dm/DMSrcSink.cpp
D docs/examples/Picture_008.cpp
M docs/examples/Picture_MakeFromData.cpp
M docs/examples/Picture_MakeFromStream.cpp
M docs/examples/Picture_serialize.cpp
M docs/examples/Picture_serialize_2.cpp
M fuzz/FuzzCanvas.cpp
M gm/3d.cpp
M gm/image.cpp
M include/core/SkPicture.h
M modules/skottie/src/SkottieTool.cpp
A relnotes/skpicture_png.md
M src/core/SkGlyph.cpp
M src/core/SkPicture.cpp
M src/core/SkWriteBuffer.cpp
M src/core/SkWriteBuffer.h
M tests/ImageFilterTest.cpp
M tests/PictureTest.cpp
M tests/SerializationTest.cpp
M tools/dump_record.cpp
M tools/fiddle/all_examples.cpp
M tools/viewer/Viewer.cpp
https://skia-review.googlesource.com/752378
Branch: main
commit 55c9c377f0b028c4966481d7e437536eeca8a734
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Sep 11 17:23:42 2023
Make SKP deserialize null instead of PNG images by default.
Client CLs:
- http://cl/563413765
- https://pdfium-review.googlesource.com/c/pdfium/+/111650
- https://github.com/flutter/engine/pull/45511
- https://crrev.com/c/4833521
- http://ag/24692530
Change-Id: I9fa03445e3cd41b1692e2d5a1aae3c7ff7e72e45
Bug:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/752378
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
M dm/DMSrcSink.cpp
D docs/examples/Picture_008.cpp
M docs/examples/Picture_MakeFromData.cpp
M docs/examples/Picture_MakeFromStream.cpp
M docs/examples/Picture_serialize.cpp
M docs/examples/Picture_serialize_2.cpp
M fuzz/FuzzCanvas.cpp
M gm/3d.cpp
M gm/image.cpp
M include/core/SkPicture.h
M modules/skottie/src/SkottieTool.cpp
A relnotes/skpicture_png.md
M src/core/SkGlyph.cpp
M src/core/SkPicture.cpp
M src/core/SkWriteBuffer.cpp
M src/core/SkWriteBuffer.h
M tests/ImageFilterTest.cpp
M tests/PictureTest.cpp
M tests/SerializationTest.cpp
M tools/dump_record.cpp
M tools/fiddle/all_examples.cpp
M tools/viewer/Viewer.cpp
https://skia-review.googlesource.com/752378
ap...@google.com <ap...@google.com> #164
Project: skia
Branch: main
commit 2d295711337cf6fcbf66dfc90af39d4188999108
Author: Ben Wagner <bungeman@google.com>
Date: Tue Sep 12 19:56:37 2023
Revert "Make SKP deserialize null instead of PNG images by default."
This reverts commit 55c9c377f0b028c4966481d7e437536eeca8a734.
Reason for revert: Test-Mac12-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-Slug
Slug serialization and deserialization in Chrome need to be updated.
Original change's description:
> Make SKP deserialize null instead of PNG images by default.
>
> Client CLs:
> - http://cl/563413765
> - https://pdfium-review.googlesource.com/c/pdfium/+/111650
> - https://github.com/flutter/engine/pull/45511
> - https://crrev.com/c/4833521
> - http://ag/24692530
> Change-Id: I9fa03445e3cd41b1692e2d5a1aae3c7ff7e72e45
> Bug: b/40045064
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/752378
> Commit-Queue: Kevin Lubick <kjlubick@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>
Bug: b/40045064
Change-Id: I409cecaf333938a61493ab412cf7cb365c267505
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/755036
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: Ben Wagner <bungeman@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Brian Osman <brianosman@google.com>
M dm/DMSrcSink.cpp
A docs/examples/Picture_008.cpp
M docs/examples/Picture_MakeFromData.cpp
M docs/examples/Picture_MakeFromStream.cpp
M docs/examples/Picture_serialize.cpp
M docs/examples/Picture_serialize_2.cpp
M fuzz/FuzzCanvas.cpp
M gm/3d.cpp
M gm/image.cpp
M include/core/SkPicture.h
M modules/skottie/src/SkottieTool.cpp
D relnotes/skpicture_png.md
M src/core/SkGlyph.cpp
M src/core/SkPicture.cpp
M src/core/SkWriteBuffer.cpp
M src/core/SkWriteBuffer.h
M tests/ImageFilterTest.cpp
M tests/PictureTest.cpp
M tests/SerializationTest.cpp
M tools/dump_record.cpp
M tools/fiddle/all_examples.cpp
M tools/viewer/Viewer.cpp
https://skia-review.googlesource.com/755036
Branch: main
commit 2d295711337cf6fcbf66dfc90af39d4188999108
Author: Ben Wagner <bungeman@google.com>
Date: Tue Sep 12 19:56:37 2023
Revert "Make SKP deserialize null instead of PNG images by default."
This reverts commit 55c9c377f0b028c4966481d7e437536eeca8a734.
Reason for revert: Test-Mac12-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-Slug
Slug serialization and deserialization in Chrome need to be updated.
Original change's description:
> Make SKP deserialize null instead of PNG images by default.
>
> Client CLs:
> - http://cl/563413765
> - https://pdfium-review.googlesource.com/c/pdfium/+/111650
> - https://github.com/flutter/engine/pull/45511
> - https://crrev.com/c/4833521
> - http://ag/24692530
> Change-Id: I9fa03445e3cd41b1692e2d5a1aae3c7ff7e72e45
> Bug:
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/752378
> Commit-Queue: Kevin Lubick <kjlubick@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>
Bug:
Change-Id: I409cecaf333938a61493ab412cf7cb365c267505
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/755036
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: Ben Wagner <bungeman@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Brian Osman <brianosman@google.com>
M dm/DMSrcSink.cpp
A docs/examples/Picture_008.cpp
M docs/examples/Picture_MakeFromData.cpp
M docs/examples/Picture_MakeFromStream.cpp
M docs/examples/Picture_serialize.cpp
M docs/examples/Picture_serialize_2.cpp
M fuzz/FuzzCanvas.cpp
M gm/3d.cpp
M gm/image.cpp
M include/core/SkPicture.h
M modules/skottie/src/SkottieTool.cpp
D relnotes/skpicture_png.md
M src/core/SkGlyph.cpp
M src/core/SkPicture.cpp
M src/core/SkWriteBuffer.cpp
M src/core/SkWriteBuffer.h
M tests/ImageFilterTest.cpp
M tests/PictureTest.cpp
M tests/SerializationTest.cpp
M tools/dump_record.cpp
M tools/fiddle/all_examples.cpp
M tools/viewer/Viewer.cpp
https://skia-review.googlesource.com/755036
ap...@google.com <ap...@google.com> #165
Project: skia
Branch: main
commit 37ea783440eafda23fa9ccadefe9235cd6c456fa
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Sep 14 14:53:18 2023
Remove some unused path effects
SkMergePathEffect, SkMatrixPathEffect, SkStrokePathEffect, and
SkStrokeAndFillPathEffect are removed.
These appear unused by our major clients and would be adding
complexity to the modular build effort.
Change-Id: Idfe1a420424cd63df86061c55e01a94a62b2d9bf
Bug: b/40045064
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/755996
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
M gm/circulararcs.cpp
M gm/patheffects.cpp
M gm/strokefill.cpp
M gm/typeface.cpp
M gn/effects.gni
M include/effects/BUILD.bazel
D include/effects/SkOpPathEffect.h
D include/effects/SkStrokeAndFillPathEffect.h
M public.bzl
A relnotes/patheffects.md
M src/effects/BUILD.bazel
D src/effects/SkOpPE.h
D src/effects/SkOpPathEffect.cpp
M src/ports/SkGlobalInitialization_default.cpp
M tools/viewer/PatchSlide.cpp
https://skia-review.googlesource.com/755996
Branch: main
commit 37ea783440eafda23fa9ccadefe9235cd6c456fa
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Sep 14 14:53:18 2023
Remove some unused path effects
SkMergePathEffect, SkMatrixPathEffect, SkStrokePathEffect, and
SkStrokeAndFillPathEffect are removed.
These appear unused by our major clients and would be adding
complexity to the modular build effort.
Change-Id: Idfe1a420424cd63df86061c55e01a94a62b2d9bf
Bug:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/755996
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
M gm/circulararcs.cpp
M gm/patheffects.cpp
M gm/strokefill.cpp
M gm/typeface.cpp
M gn/effects.gni
M include/effects/BUILD.bazel
D include/effects/SkOpPathEffect.h
D include/effects/SkStrokeAndFillPathEffect.h
M public.bzl
A relnotes/patheffects.md
M src/effects/BUILD.bazel
D src/effects/SkOpPE.h
D src/effects/SkOpPathEffect.cpp
M src/ports/SkGlobalInitialization_default.cpp
M tools/viewer/PatchSlide.cpp
https://skia-review.googlesource.com/755996
ap...@google.com <ap...@google.com> #166
Project: skia
Branch: main
commit a2d4f1efa87dbe184daefd7cc84f14b2a9879348
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Sep 15 11:21:18 2023
Add SkSerialProcs and SkDeserialProcs to Slug serialization
The shadertext3 gm started asserting when run in the glserializeslug
config after [1] landed. This was because the gm draws text with a
paint that has an image shader in it. During serialization, the
shader tried to serialize the (raster) SkImage and failed because
the default behavior of "use the PNG codec" was removed in [1].
This pipes in a way for the SkTestCanvas to supply that png codec
behavior for both serialization and deserialization (even though
it is a bit more ergonomic to simply register the decoder and
rely on the default behavior in practice).
This also makes SkSerialProcs required for SkWriteBuffer and
SkBinaryWriteBuffer since the default behavior for images is
nothing and should be specified if SkImages are being serialized.
[1] https://skia-review.googlesource.com/c/skia/+/752378
Bug: b/40045064
Change-Id: I26d3e069d4512d110afd25261ff0b07f2046aecd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/754856
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
M gm/image.cpp
M include/private/chromium/SkChromeRemoteGlyphCache.h
M include/private/chromium/Slug.h
M src/core/SkFlattenable.cpp
M src/core/SkPicture.cpp
M src/core/SkPictureData.cpp
M src/core/SkScalerContext.cpp
M src/core/SkTextBlob.cpp
M src/core/SkTextBlobTrace.cpp
M src/core/SkWriteBuffer.cpp
M src/core/SkWriteBuffer.h
M src/gpu/ganesh/GrPersistentCacheUtils.cpp
M src/gpu/ganesh/gl/builders/GrGLProgramBuilder.cpp
M src/gpu/ganesh/mtl/GrMtlPipelineStateBuilder.mm
M src/text/gpu/SkChromeRemoteGlyphCache.cpp
M src/text/gpu/Slug.cpp
M src/utils/SkTestCanvas.cpp
M tests/ColorFilterTest.cpp
M tests/DescriptorTest.cpp
M tests/FlattenDrawableTest.cpp
M tests/FontTest.cpp
M tests/GrGlyphVectorTest.cpp
M tests/PaintTest.cpp
M tests/PathTest.cpp
M tests/SerializationTest.cpp
M tests/SkFontMetricsPrivTest.cpp
M tests/SkGlyphTest.cpp
M tests/SkRemoteGlyphCacheTest.cpp
M tests/SkStrikeTest.cpp
M tests/StrikeForGPUTest.cpp
M tests/VerticesTest.cpp
M tools/debugger/DrawCommand.cpp
M tools/debugger/JsonWriteBuffer.h
https://skia-review.googlesource.com/754856
Branch: main
commit a2d4f1efa87dbe184daefd7cc84f14b2a9879348
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Sep 15 11:21:18 2023
Add SkSerialProcs and SkDeserialProcs to Slug serialization
The shadertext3 gm started asserting when run in the glserializeslug
config after [1] landed. This was because the gm draws text with a
paint that has an image shader in it. During serialization, the
shader tried to serialize the (raster) SkImage and failed because
the default behavior of "use the PNG codec" was removed in [1].
This pipes in a way for the SkTestCanvas to supply that png codec
behavior for both serialization and deserialization (even though
it is a bit more ergonomic to simply register the decoder and
rely on the default behavior in practice).
This also makes SkSerialProcs required for SkWriteBuffer and
SkBinaryWriteBuffer since the default behavior for images is
nothing and should be specified if SkImages are being serialized.
[1] https://skia-review.googlesource.com/c/skia/+/752378
Bug:
Change-Id: I26d3e069d4512d110afd25261ff0b07f2046aecd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/754856
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
M gm/image.cpp
M include/private/chromium/SkChromeRemoteGlyphCache.h
M include/private/chromium/Slug.h
M src/core/SkFlattenable.cpp
M src/core/SkPicture.cpp
M src/core/SkPictureData.cpp
M src/core/SkScalerContext.cpp
M src/core/SkTextBlob.cpp
M src/core/SkTextBlobTrace.cpp
M src/core/SkWriteBuffer.cpp
M src/core/SkWriteBuffer.h
M src/gpu/ganesh/GrPersistentCacheUtils.cpp
M src/gpu/ganesh/gl/builders/GrGLProgramBuilder.cpp
M src/gpu/ganesh/mtl/GrMtlPipelineStateBuilder.mm
M src/text/gpu/SkChromeRemoteGlyphCache.cpp
M src/text/gpu/Slug.cpp
M src/utils/SkTestCanvas.cpp
M tests/ColorFilterTest.cpp
M tests/DescriptorTest.cpp
M tests/FlattenDrawableTest.cpp
M tests/FontTest.cpp
M tests/GrGlyphVectorTest.cpp
M tests/PaintTest.cpp
M tests/PathTest.cpp
M tests/SerializationTest.cpp
M tests/SkFontMetricsPrivTest.cpp
M tests/SkGlyphTest.cpp
M tests/SkRemoteGlyphCacheTest.cpp
M tests/SkStrikeTest.cpp
M tests/StrikeForGPUTest.cpp
M tests/VerticesTest.cpp
M tools/debugger/DrawCommand.cpp
M tools/debugger/JsonWriteBuffer.h
https://skia-review.googlesource.com/754856
ap...@google.com <ap...@google.com> #167
Project: skia
Branch: main
commit a8d0102a90b46d144919cb89c2f0a1305c1989fc
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Sep 18 11:33:07 2023
Remove TextBlob's empty mailbox in favor of delegate
The empty mailbox is a bit awkward with a buffet build because
the client would have to select the "empty" implementation
or incur link errors from SkTextBlob.cpp
This has the gpu backend register a callback function to be
invoked when the textblob is being destroyed.
Change-Id: I90ce506961a5ced41f68c5519977228268b836f7
Bug: b/40045064
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/755597
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
M bazel/exporter_tool/main.go
M gn/core.gni
M include/core/SkTextBlob.h
M public.bzl
M src/BUILD.bazel
M src/core/SkTextBlob.cpp
M src/text/BUILD.bazel
D src/text/EmptyMailboxImpl.cpp
M src/text/GlyphRun.cpp
M src/text/GlyphRun.h
D src/text/TextBlobMailbox.h
M src/text/gpu/TextBlobRedrawCoordinator.cpp
https://skia-review.googlesource.com/755597
Branch: main
commit a8d0102a90b46d144919cb89c2f0a1305c1989fc
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Sep 18 11:33:07 2023
Remove TextBlob's empty mailbox in favor of delegate
The empty mailbox is a bit awkward with a buffet build because
the client would have to select the "empty" implementation
or incur link errors from SkTextBlob.cpp
This has the gpu backend register a callback function to be
invoked when the textblob is being destroyed.
Change-Id: I90ce506961a5ced41f68c5519977228268b836f7
Bug:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/755597
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
M bazel/exporter_tool/main.go
M gn/core.gni
M include/core/SkTextBlob.h
M public.bzl
M src/BUILD.bazel
M src/core/SkTextBlob.cpp
M src/text/BUILD.bazel
D src/text/EmptyMailboxImpl.cpp
M src/text/GlyphRun.cpp
M src/text/GlyphRun.h
D src/text/TextBlobMailbox.h
M src/text/gpu/TextBlobRedrawCoordinator.cpp
https://skia-review.googlesource.com/755597
ap...@google.com <ap...@google.com> #168
Project: skia
Branch: main
commit 7e4d9768657c9cc730b24507dd705580e0f2fdf5
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Sep 19 09:54:10 2023
Add way to get GrDirectContext from Ganesh-backed image
This will help us more cautiously roll out https://crrev.com/c/4864397
Bug: b/40045064
Change-Id: I772535ec638920ddcb792cb2875f9d48ec9dd2b5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/757496
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
M include/private/chromium/SkImageChromium.h
M src/gpu/ganesh/image/SkImage_GaneshBase.cpp
https://skia-review.googlesource.com/757496
Branch: main
commit 7e4d9768657c9cc730b24507dd705580e0f2fdf5
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Sep 19 09:54:10 2023
Add way to get GrDirectContext from Ganesh-backed image
This will help us more cautiously roll out https://crrev.com/c/4864397
Bug:
Change-Id: I772535ec638920ddcb792cb2875f9d48ec9dd2b5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/757496
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
M include/private/chromium/SkImageChromium.h
M src/gpu/ganesh/image/SkImage_GaneshBase.cpp
https://skia-review.googlesource.com/757496
ap...@google.com <ap...@google.com> #169
Project: chromium/src
Branch: main
commit be4a28535f13c9a099d2a915e6f8ff1eea864296
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Sep 20 17:44:42 2023
Add SkSerialProcs for slugs
This is a follow-up to https://crrev.com/c/4845659 and
a precursor to https://skia-review.googlesource.com/c/skia/+/755548
where Skia will stop automatically serializing SkImages -> PNG
for SkPictures.
Slugs do not (AFAICT) currently have glyphs which are backed
by SkDrawables which have SkImages, but they do have SkPaints,
which can have SkImages in them (e.g. SkImageShader).
Bug: b/40045064
Change-Id: I1f26bbb31dad7d155cabd7e416abf07a1e5fc3ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4864397
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1199106}
M cc/paint/paint_op_reader.cc
M cc/paint/paint_op_writer.cc
https://chromium-review.googlesource.com/4864397
Branch: main
commit be4a28535f13c9a099d2a915e6f8ff1eea864296
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Sep 20 17:44:42 2023
Add SkSerialProcs for slugs
This is a follow-up to https://crrev.com/c/4845659 and
a precursor to https://skia-review.googlesource.com/c/skia/+/755548
where Skia will stop automatically serializing SkImages -> PNG
for SkPictures.
Slugs do not (AFAICT) currently have glyphs which are backed
by SkDrawables which have SkImages, but they do have SkPaints,
which can have SkImages in them (e.g. SkImageShader).
Bug:
Change-Id: I1f26bbb31dad7d155cabd7e416abf07a1e5fc3ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4864397
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1199106}
M cc/paint/paint_op_reader.cc
M cc/paint/paint_op_writer.cc
https://chromium-review.googlesource.com/4864397
ap...@google.com <ap...@google.com> #170
Project: skia
Branch: main
commit 7de94b89ddbc03885c85612e0f37ec77bc30f4d2
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Sep 22 11:14:34 2023
Extract SkImageGenerator::MakeFromEncoded into own file
This will hopefully make it easier to bring in the implementation of
this only when one or more code is registered instead of explicitly
needing to bring a file when there are no codecs installed.
Change-Id: I725f589dd615dbd3520751edc23056908782c251
Bug: b/40045064
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/759457
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
M BUILD.gn
M gn/codec.gni
M public.bzl
M src/codec/BUILD.bazel
A src/codec/SkImageGenerator_FromEncoded.cpp
M src/core/SkImageGenerator.cpp
M src/image/SkImageGeneratorPriv.h
M src/ports/BUILD.bazel
M src/ports/SkImageGenerator_none.cpp
M src/ports/SkImageGenerator_skia.cpp
https://skia-review.googlesource.com/759457
Branch: main
commit 7de94b89ddbc03885c85612e0f37ec77bc30f4d2
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Sep 22 11:14:34 2023
Extract SkImageGenerator::MakeFromEncoded into own file
This will hopefully make it easier to bring in the implementation of
this only when one or more code is registered instead of explicitly
needing to bring a file when there are no codecs installed.
Change-Id: I725f589dd615dbd3520751edc23056908782c251
Bug:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/759457
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
M BUILD.gn
M gn/codec.gni
M public.bzl
M src/codec/BUILD.bazel
A src/codec/SkImageGenerator_FromEncoded.cpp
M src/core/SkImageGenerator.cpp
M src/image/SkImageGeneratorPriv.h
M src/ports/BUILD.bazel
M src/ports/SkImageGenerator_none.cpp
M src/ports/SkImageGenerator_skia.cpp
https://skia-review.googlesource.com/759457
ap...@google.com <ap...@google.com> #171
Project: skia
Branch: main
commit c3bac5ba5017d9f3e80547b54426a7bf93388028
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Sep 25 08:43:57 2023
Reland "Make SKP deserialize null instead of PNG images by default."
This make SKP deserialize null instead of PNG images by default,
with a SK_DISABLE_LEGACY_PNG_WRITEBUFFER guard to preserve the
previous behavior.
The reason we need to do this is allow SkPictures to be serialized
or deserialized without a dependency on codecs, to allow the build
to be more modular and not have subtle dependencies.
Clients will need to update places where they serialize SkPictures
(or MultiPictureDocuments) to expressly include an SkSerialProc
(and SkDeserialProc) for images if encoding is desired. Some changes
are listed below:
- http://cl/563413765
- https://pdfium-review.googlesource.com/c/pdfium/+/111650
- https://github.com/flutter/engine/pull/45511
- https://crrev.com/c/4845659
- http://ag/24692530
Original change's description:
> Reland "Revert "Make SKP deserialize null instead of PNG images by default.""
>
> This reverts commit b78c91996051d250b6a2946a7b6f14719e014d57.
>
> Reason for revert: Possible cause of https://crbug.com/1485891
>
> Original change's description:
> > Revert "Revert "Make SKP deserialize null instead of PNG images by default.""
> >
> > This reverts commit 2d295711337cf6fcbf66dfc90af39d4188999108.
> >
> > Change-Id: I158484509c1d067cbebdc99f97e42ff734fa855a
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/755548
> > Reviewed-by: Brian Osman <brianosman@google.com>
> > Commit-Queue: Kevin Lubick <kjlubick@google.com>
>
> Change-Id: Ifb716927460a8ab6a03dafc168d1eb1eb230fea7
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/759268
> Owners-Override: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Kevin Lubick <kjlubick@google.com>
> Auto-Submit: Kevin Lubick <kjlubick@google.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Change-Id: Ia93eff9b5ff42fabdd6abae69ba997ddd7c9b1c7
Bug: b/40045064 , chromium:1485891
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/759936
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
M dm/DMSrcSink.cpp
D docs/examples/Picture_008.cpp
M docs/examples/Picture_MakeFromData.cpp
M docs/examples/Picture_MakeFromStream.cpp
M docs/examples/Picture_serialize.cpp
M docs/examples/Picture_serialize_2.cpp
M fuzz/FuzzCanvas.cpp
M gm/3d.cpp
M include/core/SkPicture.h
M modules/skottie/src/SkottieTool.cpp
A relnotes/skpicture_png.md
M src/core/SkGlyph.cpp
M src/core/SkPicture.cpp
M src/core/SkWriteBuffer.cpp
M src/core/SkWriteBuffer.h
M tests/ImageFilterTest.cpp
M tests/PictureTest.cpp
M tests/SerializationTest.cpp
M tools/dump_record.cpp
M tools/fiddle/all_examples.cpp
M tools/viewer/Viewer.cpp
https://skia-review.googlesource.com/759936
Branch: main
commit c3bac5ba5017d9f3e80547b54426a7bf93388028
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Sep 25 08:43:57 2023
Reland "Make SKP deserialize null instead of PNG images by default."
This make SKP deserialize null instead of PNG images by default,
with a SK_DISABLE_LEGACY_PNG_WRITEBUFFER guard to preserve the
previous behavior.
The reason we need to do this is allow SkPictures to be serialized
or deserialized without a dependency on codecs, to allow the build
to be more modular and not have subtle dependencies.
Clients will need to update places where they serialize SkPictures
(or MultiPictureDocuments) to expressly include an SkSerialProc
(and SkDeserialProc) for images if encoding is desired. Some changes
are listed below:
- http://cl/563413765
- https://pdfium-review.googlesource.com/c/pdfium/+/111650
- https://github.com/flutter/engine/pull/45511
- https://crrev.com/c/4845659
- http://ag/24692530
Original change's description:
> Reland "Revert "Make SKP deserialize null instead of PNG images by default.""
>
> This reverts commit b78c91996051d250b6a2946a7b6f14719e014d57.
>
> Reason for revert: Possible cause of https://crbug.com/1485891
>
> Original change's description:
> > Revert "Revert "Make SKP deserialize null instead of PNG images by default.""
> >
> > This reverts commit 2d295711337cf6fcbf66dfc90af39d4188999108.
> >
> > Change-Id: I158484509c1d067cbebdc99f97e42ff734fa855a
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/755548
> > Reviewed-by: Brian Osman <brianosman@google.com>
> > Commit-Queue: Kevin Lubick <kjlubick@google.com>
>
> Change-Id: Ifb716927460a8ab6a03dafc168d1eb1eb230fea7
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/759268
> Owners-Override: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Kevin Lubick <kjlubick@google.com>
> Auto-Submit: Kevin Lubick <kjlubick@google.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Change-Id: Ia93eff9b5ff42fabdd6abae69ba997ddd7c9b1c7
Bug:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/759936
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
M dm/DMSrcSink.cpp
D docs/examples/Picture_008.cpp
M docs/examples/Picture_MakeFromData.cpp
M docs/examples/Picture_MakeFromStream.cpp
M docs/examples/Picture_serialize.cpp
M docs/examples/Picture_serialize_2.cpp
M fuzz/FuzzCanvas.cpp
M gm/3d.cpp
M include/core/SkPicture.h
M modules/skottie/src/SkottieTool.cpp
A relnotes/skpicture_png.md
M src/core/SkGlyph.cpp
M src/core/SkPicture.cpp
M src/core/SkWriteBuffer.cpp
M src/core/SkWriteBuffer.h
M tests/ImageFilterTest.cpp
M tests/PictureTest.cpp
M tests/SerializationTest.cpp
M tools/dump_record.cpp
M tools/fiddle/all_examples.cpp
M tools/viewer/Viewer.cpp
https://skia-review.googlesource.com/759936
ap...@google.com <ap...@google.com> #172
Project: chromium/src
Branch: main
commit 09b321368cc2a74ba32c1a2135322b91cc148516
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Oct 02 18:52:25 2023
Disable legacy SkWriteBuffer behavior w/r to png encoding
Bug: b/40045064
Change-Id: I216e156b7cdb2b81623b212c1ea54f8b8f8798d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4902280
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204173}
M skia/BUILD.gn
https://chromium-review.googlesource.com/4902280
Branch: main
commit 09b321368cc2a74ba32c1a2135322b91cc148516
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Oct 02 18:52:25 2023
Disable legacy SkWriteBuffer behavior w/r to png encoding
Bug:
Change-Id: I216e156b7cdb2b81623b212c1ea54f8b8f8798d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4902280
Auto-Submit: Kevin Lubick <kjlubick@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204173}
M skia/BUILD.gn
https://chromium-review.googlesource.com/4902280
ap...@google.com <ap...@google.com> #173
Project: skia
Branch: main
commit 0c81587d7ddec88f1fedcd56b45bfd5981ec71f6
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Oct 05 11:20:54 2023
Make SkReadBuffer *not* call SkImages::DeferredFromEncodedData by default
This previous behavior resulted in an implicit dependency between core
and codecs. This CL removes that dep.
If someone wants to call SkImages::DeferredFromEncodedData,
this will now be a link error unless at least one codec is built in.
Change-Id: Ib649b8efdf74872791b38b4a2f021380acd430e3
Bug: b/40045064
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761881
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
M include/core/SkSerialProcs.h
A relnotes/readbuffer-deserial.md
M src/codec/SkImageGenerator_FromEncoded.cpp
M src/core/BUILD.bazel
M src/core/SkReadBuffer.cpp
M src/image/SkImage_LazyFactories.cpp
https://skia-review.googlesource.com/761881
Branch: main
commit 0c81587d7ddec88f1fedcd56b45bfd5981ec71f6
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Oct 05 11:20:54 2023
Make SkReadBuffer *not* call SkImages::DeferredFromEncodedData by default
This previous behavior resulted in an implicit dependency between core
and codecs. This CL removes that dep.
If someone wants to call SkImages::DeferredFromEncodedData,
this will now be a link error unless at least one codec is built in.
Change-Id: Ib649b8efdf74872791b38b4a2f021380acd430e3
Bug:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761881
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
M include/core/SkSerialProcs.h
A relnotes/readbuffer-deserial.md
M src/codec/SkImageGenerator_FromEncoded.cpp
M src/core/BUILD.bazel
M src/core/SkReadBuffer.cpp
M src/image/SkImage_LazyFactories.cpp
https://skia-review.googlesource.com/761881
ap...@google.com <ap...@google.com> #174
Project: skia
Branch: main
commit be579dcde23b33c286fdf602fc38fc3ce99e21dc
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Oct 05 11:11:20 2023
Enforce IWYU on ToolUtils.h
I plan to split this up to avoid #ifdefs in a follow-on CL
Bug: b/40045064
Change-Id: I84c918a9407faeb642d3b6c86cf1fe1105fa2e52
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/762402
Reviewed-by: Ben Wagner <bungeman@google.com>
M dm/DM.cpp
M gm/drawatlas.cpp
M gm/imagefilterstransformed.cpp
M gm/imagemakewithfilter.cpp
M gm/palette.cpp
M gm/stroketext.cpp
M modules/skottie/tests/Text.cpp
M src/gpu/graphite/DrawAtlas.cpp
M tests/graphite/RecordingOrderTest.cpp
M toolchain/linux_trampolines/clang_trampoline_linux.sh
M tools/ToolUtils.cpp
M tools/ToolUtils.h
M tools/fonts/ToolUtilsFont.cpp
M tools/viewer/FatBitsSlide.cpp
M tools/viewer/GlyphTransformSlide.cpp
https://skia-review.googlesource.com/762402
Branch: main
commit be579dcde23b33c286fdf602fc38fc3ce99e21dc
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Oct 05 11:11:20 2023
Enforce IWYU on ToolUtils.h
I plan to split this up to avoid #ifdefs in a follow-on CL
Bug:
Change-Id: I84c918a9407faeb642d3b6c86cf1fe1105fa2e52
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/762402
Reviewed-by: Ben Wagner <bungeman@google.com>
M dm/DM.cpp
M gm/drawatlas.cpp
M gm/imagefilterstransformed.cpp
M gm/imagemakewithfilter.cpp
M gm/palette.cpp
M gm/stroketext.cpp
M modules/skottie/tests/Text.cpp
M src/gpu/graphite/DrawAtlas.cpp
M tests/graphite/RecordingOrderTest.cpp
M toolchain/linux_trampolines/clang_trampoline_linux.sh
M tools/ToolUtils.cpp
M tools/ToolUtils.h
M tools/fonts/ToolUtilsFont.cpp
M tools/viewer/FatBitsSlide.cpp
M tools/viewer/GlyphTransformSlide.cpp
https://skia-review.googlesource.com/762402
ap...@google.com <ap...@google.com> #175
Project: skia
Branch: main
commit 9b028376f9166aa35a7cf113a70d2fa64eec152c
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Oct 05 15:04:54 2023
Split ToolUtils into a few files for easier modularization
The plan is to have a "test_base" module which all tests depend on,
and then some other test modules that "tests who need pathops"
or "tests that need a gpu" will depend on.
test_base:
deps [core_skia, base_skia]
srcs [ToolUtils.h/cpp, ...
test_ganesh_gl
deps [test_base, ganesh_gl, core_skia, ...]
srcs [GpuToolUtils.h/.cpp, ...]
In theory, we could keep tool utils the way it is, and just
change the deps, but that would involve some duplication of
the test harnesses and I think will be a bit less neat.
Bug: b/40045064
Change-Id: Ic4bce9df859d3f831c879cf17ac1608bc6612355
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/762976
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
M BUILD.gn
M bench/graphite/BoundsManagerBench.cpp
M bench/graphite/IntersectionTreeBench.cpp
M bench/nanobench.cpp
M dm/DMSrcSink.cpp
M gm/bitmaprect.cpp
M gm/colorwheel.cpp
M gm/composeshader.cpp
M gm/crop_imagefilter.cpp
M gm/croppedrects.cpp
M gm/draw_bitmap_rect_skbug4374.cpp
M gm/drawbitmaprect.cpp
M gm/drawimageset.cpp
M gm/drawminibitmaprect.cpp
M gm/graphite_replay.cpp
M gm/graphitestart.cpp
M gm/image.cpp
M gm/imagemakewithfilter.cpp
M gm/imagemasksubset.cpp
M gm/localmatrixshader.cpp
M gm/orientation.cpp
M gm/perspimages.cpp
M gm/tallstretchedbitmaps.cpp
M gm/tilemodes.cpp
M src/gpu/ganesh/image/GrImageUtils.h
M tests/BigImageTest.cpp
M tests/FilterResultTest.cpp
M tests/ImageFilterTest.cpp
M tests/NdkDecodeTest.cpp
M tests/NdkEncodeTest.cpp
M tests/ProcessorTest.cpp
M tests/ShaderImageFilterTest.cpp
M tests/TestUtils.cpp
M tests/TestUtils.h
M tests/graphite/CacheKeyTest.cpp
M tests/graphite/ImageProviderTest.cpp
M tests/graphite/ImageShaderTest.cpp
M toolchain/linux_trampolines/clang_trampoline_linux.sh
M tools/BUILD.bazel
A tools/EncodeUtils.cpp
A tools/EncodeUtils.h
A tools/GpuToolUtils.cpp
A tools/GpuToolUtils.h
A tools/SvgPathExtractor.cpp
A tools/SvgPathExtractor.h
M tools/ToolUtils.cpp
M tools/ToolUtils.h
M tools/skdiff/skdiff_utils.cpp
M tools/skpbench/skpbench.cpp
M tools/viewer/BisectSlide.cpp
M tools/viewer/SlidesSlide.cpp
M tools/window/GraphiteDawnWindowContext.cpp
M tools/window/GraphiteMetalWindowContext.mm
M tools/window/GraphiteVulkanWindowContext.cpp
https://skia-review.googlesource.com/762976
Branch: main
commit 9b028376f9166aa35a7cf113a70d2fa64eec152c
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Oct 05 15:04:54 2023
Split ToolUtils into a few files for easier modularization
The plan is to have a "test_base" module which all tests depend on,
and then some other test modules that "tests who need pathops"
or "tests that need a gpu" will depend on.
test_base:
deps [core_skia, base_skia]
srcs [ToolUtils.h/cpp, ...
test_ganesh_gl
deps [test_base, ganesh_gl, core_skia, ...]
srcs [GpuToolUtils.h/.cpp, ...]
In theory, we could keep tool utils the way it is, and just
change the deps, but that would involve some duplication of
the test harnesses and I think will be a bit less neat.
Bug:
Change-Id: Ic4bce9df859d3f831c879cf17ac1608bc6612355
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/762976
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
M BUILD.gn
M bench/graphite/BoundsManagerBench.cpp
M bench/graphite/IntersectionTreeBench.cpp
M bench/nanobench.cpp
M dm/DMSrcSink.cpp
M gm/bitmaprect.cpp
M gm/colorwheel.cpp
M gm/composeshader.cpp
M gm/crop_imagefilter.cpp
M gm/croppedrects.cpp
M gm/draw_bitmap_rect_skbug4374.cpp
M gm/drawbitmaprect.cpp
M gm/drawimageset.cpp
M gm/drawminibitmaprect.cpp
M gm/graphite_replay.cpp
M gm/graphitestart.cpp
M gm/image.cpp
M gm/imagemakewithfilter.cpp
M gm/imagemasksubset.cpp
M gm/localmatrixshader.cpp
M gm/orientation.cpp
M gm/perspimages.cpp
M gm/tallstretchedbitmaps.cpp
M gm/tilemodes.cpp
M src/gpu/ganesh/image/GrImageUtils.h
M tests/BigImageTest.cpp
M tests/FilterResultTest.cpp
M tests/ImageFilterTest.cpp
M tests/NdkDecodeTest.cpp
M tests/NdkEncodeTest.cpp
M tests/ProcessorTest.cpp
M tests/ShaderImageFilterTest.cpp
M tests/TestUtils.cpp
M tests/TestUtils.h
M tests/graphite/CacheKeyTest.cpp
M tests/graphite/ImageProviderTest.cpp
M tests/graphite/ImageShaderTest.cpp
M toolchain/linux_trampolines/clang_trampoline_linux.sh
M tools/BUILD.bazel
A tools/EncodeUtils.cpp
A tools/EncodeUtils.h
A tools/GpuToolUtils.cpp
A tools/GpuToolUtils.h
A tools/SvgPathExtractor.cpp
A tools/SvgPathExtractor.h
M tools/ToolUtils.cpp
M tools/ToolUtils.h
M tools/skdiff/skdiff_utils.cpp
M tools/skpbench/skpbench.cpp
M tools/viewer/BisectSlide.cpp
M tools/viewer/SlidesSlide.cpp
M tools/window/GraphiteDawnWindowContext.cpp
M tools/window/GraphiteMetalWindowContext.mm
M tools/window/GraphiteVulkanWindowContext.cpp
https://skia-review.googlesource.com/762976
ap...@google.com <ap...@google.com> #176
Project: skia
Branch: main
commit 8b741889ed193b6f9ee0c1a41d1c0f45c7e8d5cd
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Oct 06 11:41:38 2023
Split codec-related parts out of tools/Resources.h
This will make tests easier to modularize since only a few
unit tests actually need to decode an image to work.
Change-Id: I1ded07f22b4bcbf356a36f7b3b4fd56d21c828cf
Bug: b/40045064
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/763560
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
M BUILD.gn
M bench/BlendmodeBench.cpp
M bench/ColorFilterBench.cpp
M bench/DecodeBench.cpp
M bench/EncodeBench.cpp
M bench/FilteringBench.cpp
M bench/ImageFilterDAGBench.cpp
M bench/PDFBench.cpp
M bench/ParagraphBench.cpp
M bench/VertBench.cpp
M docs/examples/Canvas_saveLayer_3.cpp
M gm/all_bitmap_configs.cpp
M gm/alpha_image.cpp
M gm/animated_image_orientation.cpp
M gm/asyncrescaleandread.cpp
M gm/bigtext.cpp
M gm/bitmapimage.cpp
M gm/blurimagevmask.cpp
M gm/blurs.cpp
M gm/colorfilterimagefilter.cpp
M gm/colorfilters.cpp
M gm/colorspace.cpp
M gm/colorwheel.cpp
M gm/complexclip.cpp
M gm/compositor_quads.cpp
M gm/coordclampshader.cpp
M gm/copy_to_4444.cpp
M gm/destcolor.cpp
M gm/draw_bitmap_rect_skbug4374.cpp
M gm/drawatlas.cpp
M gm/ducky_yuv_blend.cpp
M gm/encode.cpp
M gm/encode_alpha_jpeg.cpp
M gm/encode_color_types.cpp
M gm/encode_platform.cpp
M gm/filterindiabox.cpp
M gm/fontations_ft_compare.cpp
M gm/fpcoordinateoverride.cpp
M gm/graphite_replay.cpp
M gm/graphitestart.cpp
M gm/grayscalejpg.cpp
M gm/hsl.cpp
M gm/imagefilters.cpp
M gm/imagefilterstransformed.cpp
M gm/imagefromyuvtextures.cpp
M gm/imagemakewithfilter.cpp
M gm/kawase_blur_rt.cpp
M gm/localmatriximageshader.cpp
M gm/localmatrixshader.cpp
M gm/lumafilter.cpp
M gm/make_raster_image.cpp
M gm/makecolorspace.cpp
M gm/mesh.cpp
M gm/orientation.cpp
M gm/patch.cpp
M gm/perspimages.cpp
M gm/perspshaders.cpp
M gm/repeated_bitmap.cpp
M gm/rippleshadergm.cpp
M gm/runtimecolorfilter.cpp
M gm/runtimeimagefilter.cpp
M gm/runtimeshader.cpp
M gm/savelayer.cpp
M gm/showmiplevels.cpp
M gm/skbug_8664.cpp
M gm/srgb.cpp
M gm/subsetshader.cpp
M gm/swizzle.cpp
M gm/texelsubset.cpp
M gm/tilemodes.cpp
M gm/tilemodes_alpha.cpp
M gm/vertices.cpp
M gm/wacky_yuv_formats.cpp
M gm/yuv420_odd_dim.cpp
M tests/CodecTest.cpp
M tests/EncodeTest.cpp
M tests/ImageIsOpaqueTest.cpp
M tests/ImageNewShaderTest.cpp
M tests/ImageTest.cpp
M tests/JpegGainmapTest.cpp
M tests/MipMapTest.cpp
M tests/NdkDecodeTest.cpp
M tests/NdkEncodeTest.cpp
M tests/SamplingTest.cpp
M tests/SerialProcsTest.cpp
M tests/Skbug6389.cpp
M tests/TextureStripAtlasManagerTest.cpp
M tests/graphite/ProxyCacheTest.cpp
M third_party/vulkanmemoryallocator/GrVulkanMemoryAllocator.cpp
M toolchain/linux_trampolines/clang_trampoline_linux.sh
M tools/BUILD.bazel
D tools/DecodeFile.h
A tools/DecodeUtils.cpp
A tools/DecodeUtils.h
M tools/Resources.cpp
M tools/Resources.h
M tools/viewer/3DSlide.cpp
M tools/viewer/CameraSlide.cpp
M tools/viewer/ClipSlide.cpp
M tools/viewer/LayersSlide.cpp
M tools/viewer/MeshSlide.cpp
M tools/viewer/MixerSlide.cpp
M tools/viewer/PatchSlide.cpp
M tools/viewer/ShadowReferenceSlide.cpp
M tools/viewer/ShipSlide.cpp
M tools/viewer/SkSLSlide.cpp
M tools/viewer/SlidesSlide.cpp
M tools/viewer/Viewer.cpp
M tools/viewer/XferSlide.cpp
https://skia-review.googlesource.com/763560
Branch: main
commit 8b741889ed193b6f9ee0c1a41d1c0f45c7e8d5cd
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Oct 06 11:41:38 2023
Split codec-related parts out of tools/Resources.h
This will make tests easier to modularize since only a few
unit tests actually need to decode an image to work.
Change-Id: I1ded07f22b4bcbf356a36f7b3b4fd56d21c828cf
Bug:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/763560
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
M BUILD.gn
M bench/BlendmodeBench.cpp
M bench/ColorFilterBench.cpp
M bench/DecodeBench.cpp
M bench/EncodeBench.cpp
M bench/FilteringBench.cpp
M bench/ImageFilterDAGBench.cpp
M bench/PDFBench.cpp
M bench/ParagraphBench.cpp
M bench/VertBench.cpp
M docs/examples/Canvas_saveLayer_3.cpp
M gm/all_bitmap_configs.cpp
M gm/alpha_image.cpp
M gm/animated_image_orientation.cpp
M gm/asyncrescaleandread.cpp
M gm/bigtext.cpp
M gm/bitmapimage.cpp
M gm/blurimagevmask.cpp
M gm/blurs.cpp
M gm/colorfilterimagefilter.cpp
M gm/colorfilters.cpp
M gm/colorspace.cpp
M gm/colorwheel.cpp
M gm/complexclip.cpp
M gm/compositor_quads.cpp
M gm/coordclampshader.cpp
M gm/copy_to_4444.cpp
M gm/destcolor.cpp
M gm/draw_bitmap_rect_skbug4374.cpp
M gm/drawatlas.cpp
M gm/ducky_yuv_blend.cpp
M gm/encode.cpp
M gm/encode_alpha_jpeg.cpp
M gm/encode_color_types.cpp
M gm/encode_platform.cpp
M gm/filterindiabox.cpp
M gm/fontations_ft_compare.cpp
M gm/fpcoordinateoverride.cpp
M gm/graphite_replay.cpp
M gm/graphitestart.cpp
M gm/grayscalejpg.cpp
M gm/hsl.cpp
M gm/imagefilters.cpp
M gm/imagefilterstransformed.cpp
M gm/imagefromyuvtextures.cpp
M gm/imagemakewithfilter.cpp
M gm/kawase_blur_rt.cpp
M gm/localmatriximageshader.cpp
M gm/localmatrixshader.cpp
M gm/lumafilter.cpp
M gm/make_raster_image.cpp
M gm/makecolorspace.cpp
M gm/mesh.cpp
M gm/orientation.cpp
M gm/patch.cpp
M gm/perspimages.cpp
M gm/perspshaders.cpp
M gm/repeated_bitmap.cpp
M gm/rippleshadergm.cpp
M gm/runtimecolorfilter.cpp
M gm/runtimeimagefilter.cpp
M gm/runtimeshader.cpp
M gm/savelayer.cpp
M gm/showmiplevels.cpp
M gm/skbug_8664.cpp
M gm/srgb.cpp
M gm/subsetshader.cpp
M gm/swizzle.cpp
M gm/texelsubset.cpp
M gm/tilemodes.cpp
M gm/tilemodes_alpha.cpp
M gm/vertices.cpp
M gm/wacky_yuv_formats.cpp
M gm/yuv420_odd_dim.cpp
M tests/CodecTest.cpp
M tests/EncodeTest.cpp
M tests/ImageIsOpaqueTest.cpp
M tests/ImageNewShaderTest.cpp
M tests/ImageTest.cpp
M tests/JpegGainmapTest.cpp
M tests/MipMapTest.cpp
M tests/NdkDecodeTest.cpp
M tests/NdkEncodeTest.cpp
M tests/SamplingTest.cpp
M tests/SerialProcsTest.cpp
M tests/Skbug6389.cpp
M tests/TextureStripAtlasManagerTest.cpp
M tests/graphite/ProxyCacheTest.cpp
M third_party/vulkanmemoryallocator/GrVulkanMemoryAllocator.cpp
M toolchain/linux_trampolines/clang_trampoline_linux.sh
M tools/BUILD.bazel
D tools/DecodeFile.h
A tools/DecodeUtils.cpp
A tools/DecodeUtils.h
M tools/Resources.cpp
M tools/Resources.h
M tools/viewer/3DSlide.cpp
M tools/viewer/CameraSlide.cpp
M tools/viewer/ClipSlide.cpp
M tools/viewer/LayersSlide.cpp
M tools/viewer/MeshSlide.cpp
M tools/viewer/MixerSlide.cpp
M tools/viewer/PatchSlide.cpp
M tools/viewer/ShadowReferenceSlide.cpp
M tools/viewer/ShipSlide.cpp
M tools/viewer/SkSLSlide.cpp
M tools/viewer/SlidesSlide.cpp
M tools/viewer/Viewer.cpp
M tools/viewer/XferSlide.cpp
https://skia-review.googlesource.com/763560
ap...@google.com <ap...@google.com> #177
Project: skia
Branch: main
commit b136cffed41c890fac71772751c0caae73f22e82
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Oct 06 11:56:48 2023
Remove tests based on flag-based Bazel rules
It will be easier to make use of the buffet build modules if
we don't have similar-sounding names in the way.
Change-Id: I58d04f52cf8f49fd41a56eef6129e6b605cce394
Bug: b/40045064
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/763561
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
M .bazelrc
M bazel/buildrc
M infra/bots/jobs.json
M infra/bots/tasks.json
M tests/BUILD.bazel
M tests/testgroups.bzl
M tests/tests.bzl
https://skia-review.googlesource.com/763561
Branch: main
commit b136cffed41c890fac71772751c0caae73f22e82
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Oct 06 11:56:48 2023
Remove tests based on flag-based Bazel rules
It will be easier to make use of the buffet build modules if
we don't have similar-sounding names in the way.
Change-Id: I58d04f52cf8f49fd41a56eef6129e6b605cce394
Bug:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/763561
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
M .bazelrc
M bazel/buildrc
M infra/bots/jobs.json
M infra/bots/tasks.json
M tests/BUILD.bazel
M tests/testgroups.bzl
M tests/tests.bzl
https://skia-review.googlesource.com/763561
ap...@google.com <ap...@google.com> #178
Project: skia
Branch: main
commit c5541e2bd2131c1f87ab7f765d3219e8513e71e2
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Oct 09 08:19:28 2023
Make tests which depend on modular Bazel build
Future CLs will add more skia_cc_libraries to tests/BUILD.bazel
and make use of all the various groups defined in testgroups.bzl.
Change-Id: If76fb53bebab8e3f6a38c2120e5dec0c07e7dc4e
Bug: b/40045064
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761862
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
M include/utils/BUILD.bazel
M infra/bots/gen_tasks_logic/gen_tasks_logic.go
M infra/bots/jobs.json
M infra/bots/tasks.json
M resources/BUILD.bazel
M src/base/BUILD.bazel
M src/utils/BUILD.bazel
M tests/BUILD.bazel
M tests/testgroups.bzl
M tests/tests.bzl
M tools/BUILD.bazel
M tools/flags/BUILD.bazel
M tools/fonts/BUILD.bazel
https://skia-review.googlesource.com/761862
Branch: main
commit c5541e2bd2131c1f87ab7f765d3219e8513e71e2
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Oct 09 08:19:28 2023
Make tests which depend on modular Bazel build
Future CLs will add more skia_cc_libraries to tests/BUILD.bazel
and make use of all the various groups defined in testgroups.bzl.
Change-Id: If76fb53bebab8e3f6a38c2120e5dec0c07e7dc4e
Bug:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761862
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
M include/utils/BUILD.bazel
M infra/bots/gen_tasks_logic/gen_tasks_logic.go
M infra/bots/jobs.json
M infra/bots/tasks.json
M resources/BUILD.bazel
M src/base/BUILD.bazel
M src/utils/BUILD.bazel
M tests/BUILD.bazel
M tests/testgroups.bzl
M tests/tests.bzl
M tools/BUILD.bazel
M tools/flags/BUILD.bazel
M tools/fonts/BUILD.bazel
https://skia-review.googlesource.com/761862
ap...@google.com <ap...@google.com> #179
Project: chromium/src
Branch: main
commit f360efc64e740ebff326a9a51533cf7f13c50ea9
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Oct 11 18:58:21 2023
Register deserialization of Slugs in SkPicture
In https://skia-review.googlesource.com/c/skia/+/755550 we deprecated
the default behavior of SkPictures deserializing Slugs (currently
a gpu-only type) so serialization works without a subtle link to
a GPU backend.
This means clients who need to deserialize Slugs in SkPictures
need to register that behavior explicitly, using a provided
helper function.
The change does *not* impact directly serializing Slugs, only
in situations where an SkPicture would have a Slug inside it
(e.g. a call to drawSlug).
Bug: b:40045064
Change-Id: Icb9e9e520aa70b2b0b03512eb7cd0e0a976990ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4885951
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1208367}
M components/paint_preview/DEPS
M components/paint_preview/common/serial_utils.cc
M skia/BUILD.gn
https://chromium-review.googlesource.com/4885951
Branch: main
commit f360efc64e740ebff326a9a51533cf7f13c50ea9
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Oct 11 18:58:21 2023
Register deserialization of Slugs in SkPicture
In https://skia-review.googlesource.com/c/skia/+/755550 we deprecated
the default behavior of SkPictures deserializing Slugs (currently
a gpu-only type) so serialization works without a subtle link to
a GPU backend.
This means clients who need to deserialize Slugs in SkPictures
need to register that behavior explicitly, using a provided
helper function.
The change does *not* impact directly serializing Slugs, only
in situations where an SkPicture would have a Slug inside it
(e.g. a call to drawSlug).
Bug: b:40045064
Change-Id: Icb9e9e520aa70b2b0b03512eb7cd0e0a976990ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4885951
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1208367}
M components/paint_preview/DEPS
M components/paint_preview/common/serial_utils.cc
M skia/BUILD.gn
https://chromium-review.googlesource.com/4885951
ap...@google.com <ap...@google.com> #180
Project: skia
Branch: main
commit 1931535039ed26abd38ff321fe5b7edc0521b01c
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Oct 11 14:56:20 2023
Minor fixes for buffet build
Certain toolchains compile headers independently, and thus noticed some
missing #includes. This also removes the default_malloc_impl module,
as that gives linking errors in some environments because a symbol
is potentially missing depending on link order.
See also http://cl/572301023
Bug: b/40045064
Bug: b/237076898
Change-Id: Ia0a3f32bdab9bc92d09eddd3e5dc7c190cb5caf3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/765357
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
M BUILD.bazel
M bazel/exporter_tool/main.go
M example/external_client/BUILD.bazel
M gn/core.gni
M include/core/BUILD.bazel
M include/private/BUILD.bazel
M src/core/BUILD.bazel
M src/core/SkBlitBWMaskTemplate.h
M src/core/SkTextFormatParams.h
M src/core/SkVerticesPriv.h
M src/opts/BUILD.bazel
M src/pathops/BUILD.bazel
M src/ports/BUILD.bazel
M src/sksl/analysis/SkSLNoOpErrorReporter.h
M src/sksl/ir/SkSLEmptyExpression.h
M src/sksl/ir/SkSLFunctionReference.h
M src/sksl/ir/SkSLMethodReference.h
M src/sksl/ir/SkSLPoison.h
M src/sksl/transform/SkSLTransform.h
M tests/BUILD.bazel
https://skia-review.googlesource.com/765357
Branch: main
commit 1931535039ed26abd38ff321fe5b7edc0521b01c
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Oct 11 14:56:20 2023
Minor fixes for buffet build
Certain toolchains compile headers independently, and thus noticed some
missing #includes. This also removes the default_malloc_impl module,
as that gives linking errors in some environments because a symbol
is potentially missing depending on link order.
See also http://cl/572301023
Bug:
Bug:
Change-Id: Ia0a3f32bdab9bc92d09eddd3e5dc7c190cb5caf3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/765357
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
M BUILD.bazel
M bazel/exporter_tool/main.go
M example/external_client/BUILD.bazel
M gn/core.gni
M include/core/BUILD.bazel
M include/private/BUILD.bazel
M src/core/BUILD.bazel
M src/core/SkBlitBWMaskTemplate.h
M src/core/SkTextFormatParams.h
M src/core/SkVerticesPriv.h
M src/opts/BUILD.bazel
M src/pathops/BUILD.bazel
M src/ports/BUILD.bazel
M src/sksl/analysis/SkSLNoOpErrorReporter.h
M src/sksl/ir/SkSLEmptyExpression.h
M src/sksl/ir/SkSLFunctionReference.h
M src/sksl/ir/SkSLMethodReference.h
M src/sksl/ir/SkSLPoison.h
M src/sksl/transform/SkSLTransform.h
M tests/BUILD.bazel
https://skia-review.googlesource.com/765357